From b4365a8c9ba7ddb9337acc1495f76ac8e654001e Mon Sep 17 00:00:00 2001
From: James Bunton <jamesbunton@delx.net.au>
Date: Sun, 3 May 2020 12:38:39 +1000
Subject: [PATCH] lib-ext-backup: cleanups

---
 lib-ext-backup | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/lib-ext-backup b/lib-ext-backup
index b45d9d7..35aca43 100644
--- a/lib-ext-backup
+++ b/lib-ext-backup
@@ -10,7 +10,7 @@ function cryptsetup_open {
         echo "> cryptsetup luksOpen $DEVICE $CRYPTNAME"
         cryptsetup luksOpen "$DEVICE" "$CRYPTNAME" --key-file "/etc/lukskeys/${DISKNAME}"
         mkdir -p /run/ext-backup-crypt/
-        ln -s "/dev/mapper/$CRYPTNAME" /run/ext-backup-crypt/
+        ln -sf "/dev/mapper/$CRYPTNAME" /run/ext-backup-crypt/
     done
 }
 
@@ -58,19 +58,19 @@ function pool_setup {
     zfs set acltype=posixacl "$ZPOOLNAME"
 }
 
-function cleanup_snapshots {
-    echo "> Cleaning snapshots"
-
-    sanoid --configdir=/etc/sanoid/ext-backup --verbose --prune-snapshots
+function syncoidw {
+    echo "> syncoid $1"
+    syncoid "$@" --identifier "$ZPOOLNAME"
 
-    zfs list -t snapshot -r "$ZPOOLNAME" -H -o name \
+    zfs list -t snapshot -H -o name -r "$ZPOOLNAME" \
         | grep -F @syncoid_ \
         | grep -Fv "@syncoid_$ZPOOLNAME" \
         | xargs -rn1 zfs destroy -v
 }
 
-function syncoidw {
-    syncoid --identifier "$ZPOOLNAME" "$@"
+function snapshot_cleanup {
+    echo "> Cleaning snapshots"
+    sanoid --configdir=/etc/sanoid/ext-backup --verbose --prune-snapshots
 }
 
 function main {
@@ -78,8 +78,8 @@ function main {
     cryptsetup_open
     pool_import
     pool_setup
-    sync_snapshots
-    cleanup_snapshots
+    snapshot_sync
+    snapshot_cleanup
     pool_export
     cryptsetup_close
 }
-- 
2.39.2