From: John Goerzen <jgoerzen@complete.org>
Date: Tue, 12 Aug 2008 14:12:25 +0000 (-0500)
Subject: Working on getFullLine_count
X-Git-Url: https://code.delx.au/offlineimap/commitdiff_plain/0332e2d67d8ef3bb9611a353bfdeec9581841e68

Working on getFullLine_count
---

diff --git a/src/Network/IMAP/Parser.hs b/src/Network/IMAP/Parser.hs
index 7e0b13a..c8cf6ca 100644
--- a/src/Network/IMAP/Parser.hs
+++ b/src/Network/IMAP/Parser.hs
@@ -36,8 +36,10 @@ readFullResponse conn expectedtag =
 
 {- | Read a full line from the server, handling any continuation stuff.
 
-FIXME: for now, we naively assume that any line ending in '}\r\n' is
-having a continuation piece. -}
+If a {x}\r\n occurs, then that string (including the \r\n) will occur
+literally in the result, followed by the literal read, and the rest of the
+data.
+ -}
 
 getFullLine :: Monad m => 
                IMAPString ->    -- ^ The accumulator (empty for first call)
@@ -50,9 +52,9 @@ getFullLine accum conn =
          Nothing -> return (accum ++ input)
          Just (size) -> 
              do literal <- readBytes conn size
-                getFullLine (accum ++ input ++ literal) conn
+                getFullLine (accum ++ input ++ "\r\n" ++ literal) conn
     where checkContinuation :: String -> Maybe Int64
           checkContinuation i =
-              case i =~ "\\{([0-9]+)\\}$" of
-                [] -> Nothing
-                x -> Just (read x)
+              case i =~ "\\{([0-9]+)\\}$" :: (String, String, String, [String]) of
+                (_, _, _, [x]) -> Just (read x)
+                _ -> Nothing
diff --git a/testsrc/TestParser.hs b/testsrc/TestParser.hs
index 4049869..1ccc3f1 100644
--- a/testsrc/TestParser.hs
+++ b/testsrc/TestParser.hs
@@ -45,9 +45,9 @@ prop_getFullLine_count s =
            ==> 
            runLinesConnection lenS (getFullLine []) @?=
                               Right (expectedResult, (expectedRemain, []))
-    where lenS = [head s ++ "{" ++ show (length (s !! 1)) ++ "}\r\n" ++ (s !! 1)]
-                 ++ (drop 2 s)
-          expectedResult = concat (take 2 s)
+    where lenS = [braceString] ++ [(head . tail $ s)] ++ drop 2 s
+          braceString = head s ++ "{" ++ show (length (s !! 1)) ++ "}"
+          expectedResult = braceString ++ "\r\n" ++ (s !! 1)
           expectedRemain = expectedString (drop 2 s)
 
 allt = [q "getFullLine_basic" prop_getFullLine_basic,