From: Peter Meerwald <p.meerwald@bct-electronic.com>
Date: Mon, 16 Dec 2013 15:44:28 +0000 (+0100)
Subject: modules: Fix resource leak in raop_client
X-Git-Url: https://code.delx.au/pulseaudio/commitdiff_plain/9d3d732a63749763a2c19ef56d512cfc33691161

modules: Fix resource leak in raop_client

https://scan7.coverity.com:8443/reports.htm#v10205/p10016/fileInstanceId=8899&defectInstanceId=3735&mergedDefectId=591272

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
---

diff --git a/src/modules/raop/raop_client.c b/src/modules/raop/raop_client.c
index 98a98224..5bb0bb45 100644
--- a/src/modules/raop/raop_client.c
+++ b/src/modules/raop/raop_client.c
@@ -367,7 +367,7 @@ static void rtsp_cb(pa_rtsp_client *rtsp, pa_rtsp_state state, pa_headerlist* he
 
 pa_raop_client* pa_raop_client_new(pa_core *core, const char* host) {
     pa_parsed_address a;
-    pa_raop_client* c = pa_xnew0(pa_raop_client, 1);
+    pa_raop_client* c;
 
     pa_assert(core);
     pa_assert(host);
@@ -375,6 +375,7 @@ pa_raop_client* pa_raop_client_new(pa_core *core, const char* host) {
     if (pa_parse_address(host, &a) < 0 || a.type == PA_PARSED_ADDRESS_UNIX)
         return NULL;
 
+    c = pa_xnew0(pa_raop_client, 1);
     c->core = core;
     c->fd = -1;