From: Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
Date: Mon, 18 Nov 2013 16:48:05 +0000 (+0200)
Subject: ucm: Add a FIXME comment about bad error handling
X-Git-Url: https://code.delx.au/pulseaudio/commitdiff_plain/bee86af3ccc247834bf38a57296958f9cd35ffc4

ucm: Add a FIXME comment about bad error handling
---

diff --git a/src/modules/alsa/alsa-ucm.c b/src/modules/alsa/alsa-ucm.c
index ef3ddb29..ac7f70d9 100644
--- a/src/modules/alsa/alsa-ucm.c
+++ b/src/modules/alsa/alsa-ucm.c
@@ -1125,6 +1125,9 @@ static void alsa_mapping_add_ucm_modifier(pa_alsa_mapping *m, pa_alsa_ucm_modifi
     }
 
     if (channel_str) {
+        /* FIXME: channel_str is unsanitized input from the UCM configuration,
+         * we should do proper error handling instead of asserting.
+         * https://bugs.freedesktop.org/show_bug.cgi?id=71823 */
         pa_assert_se(pa_atou(channel_str, &channels) == 0 && channels < PA_CHANNELS_MAX);
         pa_log_debug("Got channel count %" PRIu32 " for modifier", channels);
     }