From ded196f93a26726089374f0eae20127bdca544a2 Mon Sep 17 00:00:00 2001 From: Arun Raghavan Date: Tue, 3 Jul 2012 18:04:48 +0530 Subject: [PATCH] Revert "Revert "role-cork: Fix a minor leak"" This reverts commit a2c4bf22e0813d529f153c01d7421345a792f3bc. As Tanu points out, I'm stupid. The pa_xstrdup(n) was unnecessary because pa_split() allocates a new string for us. --- src/modules/module-role-cork.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/module-role-cork.c b/src/modules/module-role-cork.c index 70e1628f..8306987e 100644 --- a/src/modules/module-role-cork.c +++ b/src/modules/module-role-cork.c @@ -227,7 +227,7 @@ int pa__init(pa_module *m) { char *n = NULL; while ((n = pa_split(roles, ",", &split_state))) if (n[0] != '\0') - pa_idxset_put(u->trigger_roles, pa_xstrdup(n), NULL); + pa_idxset_put(u->trigger_roles, n, NULL); } if (pa_idxset_isempty(u->trigger_roles)) { pa_log_debug("Using role 'phone' as trigger role."); @@ -241,7 +241,7 @@ int pa__init(pa_module *m) { char *n = NULL; while ((n = pa_split(roles, ",", &split_state))) if (n[0] != '\0') - pa_idxset_put(u->cork_roles, pa_xstrdup(n), NULL); + pa_idxset_put(u->cork_roles, n, NULL); } if (pa_idxset_isempty(u->cork_roles)) { pa_log_debug("Using roles 'music' and 'video' as cork roles."); -- 2.39.2