]> code.delx.au - gnu-emacs-elpa/blobdiff - diff-hl-flydiff.el
One fewer version check
[gnu-emacs-elpa] / diff-hl-flydiff.el
index 0b7781e91af7df6edd93ece7d93221ad762feea3..0c421cea0cc4653e7fe0c82b1b69ef54724de9ae 100644 (file)
@@ -1,4 +1,4 @@
-;; Copyright (C) 2012-2013  Free Software Foundation, Inc.
+;; Copyright (C) 2015 Free Software Foundation, Inc.
 
 ;; Author:   Jonathan Hayase <PythonNut@gmail.com>
 ;; URL:      https://github.com/dgutov/diff-hl
 ;;; Code:
 
 (require 'diff-hl)
-(require 'nadvice)
+(require 'diff)
+(unless (require 'nadvice nil t)
+  (error "`diff-hl-flydiff-mode' requires Emacs 24.4 or newer"))
 
 (defvar diff-hl-flydiff-modified-tick 0)
 (defvar diff-hl-flydiff-timer)
 (make-variable-buffer-local 'diff-hl-flydiff-modified-tick)
 
+(defun diff-hl-flydiff/vc-git--symbolic-ref (file)
+  (or
+   (vc-file-getprop file 'vc-git-symbolic-ref)
+   (let* (process-file-side-effects
+          (str (vc-git--run-command-string nil "symbolic-ref" "HEAD")))
+     (vc-file-setprop file 'vc-git-symbolic-ref
+                      (if str
+                          (if (string-match "^\\(refs/heads/\\)?\\(.+\\)$" str)
+                              (match-string 2 str)
+                            str))))))
+
+(defun diff-hl-flydiff/vc-git-working-revision (_file)
+  "Git-specific version of `vc-working-revision'."
+  (let (process-file-side-effects)
+    (vc-git--rev-parse "HEAD")))
+
+(defun diff-hl-flydiff/vc-git-mode-line-string (file)
+  "Return a string for `vc-mode-line' to put in the mode line for FILE."
+  (let* ((rev (vc-working-revision file))
+         (disp-rev (or (diff-hl-flydiff/vc-git--symbolic-ref file)
+                       (substring rev 0 7)))
+         (def-ml (vc-default-mode-line-string 'Git file))
+         (help-echo (get-text-property 0 'help-echo def-ml))
+         (face   (get-text-property 0 'face def-ml)))
+    (propertize (replace-regexp-in-string (concat rev "\\'") disp-rev def-ml t t)
+                'face face
+                'help-echo (concat help-echo "\nCurrent revision: " rev))))
+
 ;; Polyfill concrete revisions for vc-git-working-revision in Emacs 24.4, 24.5
 (when (version<= emacs-version "25.0")
   (with-eval-after-load 'vc-git
-    (defun vc-git--symbolic-ref (file)
-      (or
-        (vc-file-getprop file 'vc-git-symbolic-ref)
-        (let* (process-file-side-effects
-                (str (vc-git--run-command-string nil "symbolic-ref" "HEAD")))
-          (vc-file-setprop file 'vc-git-symbolic-ref
-            (if str
-              (if (string-match "^\\(refs/heads/\\)?\\(.+\\)$" str)
-                (match-string 2 str)
-                str))))))
-
-    (defun diff-hl-flydiff/vc-git-working-revision (_file)
-      "Git-specific version of `vc-working-revision'."
-      (let (process-file-side-effects)
-        (vc-git--rev-parse "HEAD")))
-
-    (defun diff-hl-flydiff/vc-git-mode-line-string (file)
-      "Return a string for `vc-mode-line' to put in the mode line for FILE."
-      (let* ((rev (vc-working-revision file))
-              (disp-rev (or (vc-git--symbolic-ref file)
-                          (substring rev 0 7)))
-              (def-ml (vc-default-mode-line-string 'Git file))
-              (help-echo (get-text-property 0 'help-echo def-ml)))
-        (propertize (replace-regexp-in-string (concat rev "\\'") disp-rev def-ml t t)
-          'help-echo (concat help-echo "\nCurrent revision: " rev))))
-
     (advice-add 'vc-git-working-revision :override
-      #'diff-hl-flydiff/vc-git-working-revision)
+                #'diff-hl-flydiff/vc-git-working-revision)
     (advice-add 'vc-git-mode-line-string :override
-      #'diff-hl-flydiff/vc-git-mode-line-string)))
+                #'diff-hl-flydiff/vc-git-mode-line-string)))
+
+(defun diff-hl-flydiff/working-revision (file)
+  "Like vc-working-revision, but always up-to-date"
+  (vc-file-setprop file 'vc-working-revision
+    (vc-call-backend (vc-backend file) 'working-revision file)))
 
 (defun diff-hl-flydiff-make-temp-file-name (file rev &optional manual)
   "Return a backup file name for REV or the current version of FILE.
@@ -103,25 +112,21 @@ the user should be returned."
                 (delete-file filename)))))))
     filename))
 
-(defun diff-hl-flydiff-buffer-with-head ()
+(defun diff-hl-flydiff-buffer-with-head (file &optional backend)
   "View the differences between BUFFER and its associated file.
 This requires the external program `diff' to be in your `exec-path'."
   (interactive)
   (vc-ensure-vc-buffer)
   (with-current-buffer (get-buffer (current-buffer))
-    (let* ((file buffer-file-name)
-            (temporary-file-directory
-              (if (file-directory-p "/dev/shm/")
-                "/dev/shm/"
-                temporary-file-directory))
-            (rev (diff-hl-flydiff-create-revision
-                   file
-                   (vc-working-revision file
-                     (vc-responsible-backend file)))))
-      (diff-no-select rev (current-buffer) "-U 0" 'noasync
+    (let* ((temporary-file-directory
+             (if (file-directory-p "/dev/shm/")
+               "/dev/shm/"
+               temporary-file-directory))
+            (rev (diff-hl-flydiff-create-revision file
+                   (diff-hl-flydiff/working-revision file))))
+      (diff-no-select rev (current-buffer) "-U 0 --strip-trailing-cr" 'noasync
         (get-buffer-create " *diff-hl-diff*")))))
 
-
 (defun diff-hl-flydiff/update (old-fun &optional auto)
   (unless (and auto
             (or
@@ -130,47 +135,11 @@ This requires the external program `diff' to be in your `exec-path'."
               (not (buffer-modified-p))))
     (funcall old-fun)))
 
-(defun diff-hl-flydiff/changes (&rest args)
-  (let* ((file buffer-file-name)
-          (backend (vc-backend file)))
-    (when backend
-      (let ((state (vc-state file backend)))
-        (cond
-          ((or
-             (buffer-modified-p)
-             (eq state 'edited)
-             (and (eq state 'up-to-date)
-               ;; VC state is stale in after-revert-hook.
-               (or revert-buffer-in-progress-p
-                 ;; Diffing against an older revision.
-                 diff-hl-reference-revision)))
-            (let (diff-auto-refine-mode res)
-              (with-current-buffer (diff-hl-flydiff-buffer-with-head)
-                (goto-char (point-min))
-                (unless (eobp)
-                  (ignore-errors
-                    (diff-beginning-of-hunk t))
-                  (while (looking-at diff-hunk-header-re-unified)
-                    (let ((line (string-to-number (match-string 3)))
-                           (len (let ((m (match-string 4)))
-                                  (if m (string-to-number m) 1)))
-                           (beg (point)))
-                      (diff-end-of-hunk)
-                      (let* ((inserts (diff-count-matches "^\\+" beg (point)))
-                              (deletes (diff-count-matches "^-" beg (point)))
-                              (type (cond ((zerop deletes) 'insert)
-                                      ((zerop inserts) 'delete)
-                                      (t 'change))))
-                        (when (eq type 'delete)
-                          (setq len 1)
-                          (cl-incf line))
-                        (push (list line len type) res))))))
-              (setq diff-hl-flydiff-modified-tick (buffer-modified-tick))
-              (nreverse res)))
-          ((eq state 'added)
-            `((1 ,(line-number-at-pos (point-max)) insert)))
-          ((eq state 'removed)
-            `((1 ,(line-number-at-pos (point-max)) delete))))))))
+(defun diff-hl-flydiff/modified-p (state)
+  (buffer-modified-p))
+
+(defun diff-hl-flydiff/update-modified-tick (&rest args)
+  (setq diff-hl-flydiff-modified-tick (buffer-modified-tick)))
 
 ;;;###autoload
 (define-minor-mode diff-hl-flydiff-mode
@@ -180,15 +149,24 @@ This requires the external program `diff' to be in your `exec-path'."
   (if diff-hl-flydiff-mode
     (progn
       (advice-add 'diff-hl-update :around #'diff-hl-flydiff/update)
-      (advice-add 'diff-hl-changes :override #'diff-hl-flydiff/changes)
-      (advice-add 'diff-hl-overlay-modified :override #'ignored)
+      (advice-add 'diff-hl-overlay-modified :override #'ignore)
+
+      (advice-add 'diff-hl-modified-p :before-until
+        #'diff-hl-flydiff/modified-p)
+      (advice-add 'diff-hl-changes-buffer :override
+        #'diff-hl-flydiff-buffer-with-head)
+      (advice-add 'diff-hl-change :after
+        #'diff-hl-flydiff/update-modified-tick)
 
       (setq diff-hl-flydiff-timer
         (run-with-idle-timer 0.3 t #'diff-hl-update t)))
 
     (advice-remove 'diff-hl-update #'diff-hl-flydiff/update)
-    (advice-remove 'diff-hl-changes #'diff-hl-flydiff/changes)
-    (advice-remove 'diff-hl-overlay-modified #'ignored)
+    (advice-remove 'diff-hl-overlay-modified #'ignore)
+
+    (advice-remove 'diff-hl-modified-p #'diff-hl-flydiff/modified-p)
+    (advice-remove 'diff-hl-changes-buffer #'diff-hl-flydiff-buffer-with-head)
+    (advice-remove 'diff-hl-change #'diff-hl-flydiff/update-modified-tick)
 
     (cancel-timer diff-hl-flydiff-timer)))