code.delx.au - gnu-emacs/blob - lisp/emacs-lisp/elint.el

   1 ;;; elint.el --- Lint Emacs Lisp
   2
   3 ;; Copyright (C) 1997, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008,
   4 ;;   2009, 2010, 2011  Free Software Foundation, Inc.
   5
   6 ;; Author: Peter Liljenberg <petli@lysator.liu.se>
   7 ;; Created: May 1997
   8 ;; Keywords: lisp
   9
  10 ;; This file is part of GNU Emacs.
  11
  12 ;; GNU Emacs is free software: you can redistribute it and/or modify
  13 ;; it under the terms of the GNU General Public License as published by
  14 ;; the Free Software Foundation, either version 3 of the License, or
  15 ;; (at your option) any later version.
  16
  17 ;; GNU Emacs is distributed in the hope that it will be useful,
  18 ;; but WITHOUT ANY WARRANTY; without even the implied warranty of
  19 ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  20 ;; GNU General Public License for more details.
  21
  22 ;; You should have received a copy of the GNU General Public License
  23 ;; along with GNU Emacs.  If not, see <http://www.gnu.org/licenses/>.
  24
  25 ;;; Commentary:
  26
  27 ;; This is a linter for Emacs Lisp.  Currently, it mainly catches
  28 ;; misspellings and undefined variables, although it can also catch
  29 ;; function calls with the wrong number of arguments.
  30
  31 ;; To use, call elint-current-buffer or elint-defun to lint a buffer
  32 ;; or defun.  The first call runs `elint-initialize' to set up some
  33 ;; argument data, which may take a while.
  34
  35 ;; The linter will try to "include" any require'd libraries to find
  36 ;; the variables defined in those.  There is a fair amount of voodoo
  37 ;; involved in this, but it seems to work in normal situations.
  38
  39 ;;; To do:
  40
  41 ;; * Adding type checking. (Stop that sniggering!)
  42 ;; * Make eval-when-compile be sensitive to the difference between
  43 ;;   funcs and macros.
  44 ;; * Requires within function bodies.
  45 ;; * Handle defstruct.
  46 ;; * Prevent recursive requires.
  47
  48 ;;; Code:
  49
  50 (defgroup elint nil
  51   "Linting for Emacs Lisp."
  52   :prefix "elint-"
  53   :group 'maint)
  54
  55 (defcustom elint-log-buffer "*Elint*"
  56   "The buffer in which to log lint messages."
  57   :type 'string
  58   :safe 'stringp
  59   :group 'elint)
  60
  61 (defcustom elint-scan-preloaded t
  62   "Non-nil means to scan `preloaded-file-list' when initializing.
  63 Otherwise, just scan the DOC file for functions and variables.
  64 This is faster, but less accurate, since it misses undocumented features.
  65 This may result in spurious warnings about unknown functions, etc."
  66   :type 'boolean
  67   :safe 'booleanp
  68   :group 'elint
  69   :version "23.2")
  70
  71 (defcustom elint-ignored-warnings nil
  72   "If non-nil, a list of issue types that Elint should ignore.
  73 This is useful if Elint has trouble understanding your code and
  74 you need to suppress lots of spurious warnings.  The valid list elements
  75 are as follows, and suppress messages about the indicated features:
  76   undefined-functions - calls to unknown functions
  77   unbound-reference   - reference to unknown variables
  78   unbound-assignment  - assignment to unknown variables
  79   macro-expansions    - failure to expand macros
  80   empty-let           - let-bindings with empty variable lists"
  81   :type '(choice (const :tag "Don't suppress any warnings" nil)
  82                  (repeat :tag "List of issues to ignore"
  83                          (choice (const undefined-functions
  84                                         :tag "Calls to unknown functions")
  85                                  (const unbound-reference
  86                                         :tag "Reference to unknown variables")
  87                                  (const unbound-assignment
  88                                         :tag "Assignment to unknown variables")
  89                                  (const macro-expansion
  90                                         :tag "Failure to expand macros")
  91                                  (const empty-let
  92                                         :tag "Let-binding with empty varlist"))))
  93   :safe (lambda (value) (or (null value)
  94                             (and (listp value)
  95                                  (equal value
  96                                         (mapcar
  97                                          (lambda (e)
  98                                            (if (memq e
  99                                                      '(undefined-functions
 100                                                        unbound-reference
 101                                                        unbound-assignment
 102                                                        macro-expansion
 103                                                        empty-let))
 104                                                e))
 105                                          value)))))
 106   :version "23.2"
 107   :group 'elint)
 108
 109 (defcustom elint-directory-skip-re "\\(ldefs-boot\\|loaddefs\\)\\.el\\'"
 110   "If nil, a regexp matching files to skip when linting a directory."
 111   :type '(choice (const :tag "Lint all files" nil)
 112                  (regexp :tag "Regexp to skip"))
 113   :safe 'string-or-null-p
 114   :group 'elint
 115   :version "23.2")
 116
 117 ;;;
 118 ;;; Data
 119 ;;;
 120
 121 (defconst elint-standard-variables
 122   ;; Most of these are defined in C with no documentation.
 123   ;; FIXME I don't see why they shouldn't just get doc-strings.
 124   '(vc-mode local-write-file-hooks activate-menubar-hook buffer-name-history
 125             coding-system-history extended-command-history
 126             kbd-macro-termination-hook read-expression-history
 127             yes-or-no-p-history)
 128   "Standard variables, excluding `elint-builtin-variables'.
 129 These are variables that we cannot detect automatically for some reason.")
 130
 131 (defvar elint-builtin-variables nil
 132   "List of built-in variables.  Set by `elint-initialize'.
 133 This is actually all those documented in the DOC file, which includes
 134 built-in variables and those from dumped Lisp files.")
 135
 136 (defvar elint-autoloaded-variables nil
 137   "List of `loaddefs.el' variables.  Set by `elint-initialize'.")
 138
 139 (defvar elint-preloaded-env nil
 140   "Environment defined by the preloaded (dumped) Lisp files.
 141 Set by `elint-initialize', if `elint-scan-preloaded' is non-nil.")
 142
 143 (defconst elint-unknown-builtin-args
 144   ;; encode-time allows extra arguments for use with decode-time.
 145   ;; For some reason, some people seem to like to use them in other cases.
 146   '((encode-time second minute hour day month year &rest zone))
 147   "Those built-ins for which we can't find arguments, if any.")
 148
 149 (defvar elint-extra-errors '(file-locked file-supersession ftp-error)
 150   "Errors without `error-message' or `error-conditions' properties.")
 151
 152 (defconst elint-preloaded-skip-re
 153   (regexp-opt '("loaddefs.el" "loadup.el" "cus-start" "language/"
 154                 "eucjp-ms" "mule-conf" "/characters" "/charprop"
 155                 "cp51932"))
 156   "Regexp matching elements of `preloaded-file-list' to ignore.
 157 We ignore them because they contain no definitions of use to Elint.")
 158
 159 ;;;
 160 ;;; ADT: top-form
 161 ;;;
 162
 163 (defsubst elint-make-top-form (form pos)
 164   "Create a top form.
 165 FORM is the form, and POS is the point where it starts in the buffer."
 166   (cons form pos))
 167
 168 (defsubst elint-top-form-form (top-form)
 169   "Extract the form from a TOP-FORM."
 170   (car top-form))
 171
 172 (defsubst elint-top-form-pos (top-form)
 173   "Extract the position from a TOP-FORM."
 174   (cdr top-form))
 175
 176 ;;;
 177 ;;; ADT: env
 178 ;;;
 179
 180 (defsubst elint-make-env ()
 181   "Create an empty environment."
 182   (list (list nil) nil nil))
 183
 184 (defsubst elint-env-add-env (env newenv)
 185   "Augment ENV with NEWENV.
 186 None of them is modified, and the new env is returned."
 187   (list (append (car env) (car newenv))
 188         (append (cadr env) (cadr newenv))
 189         (append (car (cdr (cdr env))) (car (cdr (cdr newenv))))))
 190
 191 (defsubst elint-env-add-var (env var)
 192   "Augment ENV with the variable VAR.
 193 The new environment is returned, the old is unmodified."
 194   (cons (cons (list var) (car env)) (cdr env)))
 195
 196 (defsubst elint-env-add-global-var (env var)
 197   "Augment ENV with the variable VAR.
 198 ENV is modified so VAR is seen everywhere.
 199 ENV is returned."
 200   (nconc (car env) (list (list var)))
 201   env)
 202
 203 (defsubst elint-env-find-var (env var)
 204   "Non-nil if ENV contains the variable VAR.
 205 Actually, a list with VAR as a single element is returned."
 206   (assq var (car env)))
 207
 208 (defsubst elint-env-add-func (env func args)
 209   "Augment ENV with the function FUNC, which has the arguments ARGS.
 210 The new environment is returned, the old is unmodified."
 211   (list (car env)
 212         (cons (list func args) (cadr env))
 213         (car (cdr (cdr env)))))
 214
 215 (defsubst elint-env-find-func (env func)
 216   "Non-nil if ENV contains the function FUNC.
 217 Actually, a list of (FUNC ARGS) is returned."
 218   (assq func (cadr env)))
 219
 220 (defsubst elint-env-add-macro (env macro def)
 221   "Augment ENV with the macro named MACRO.
 222 DEF is the macro definition (a lambda expression or similar).
 223 The new environment is returned, the old is unmodified."
 224   (list (car env)
 225         (cadr env)
 226         (cons (cons macro def) (car (cdr (cdr env))))))
 227
 228 (defsubst elint-env-macro-env (env)
 229   "Return the macro environment of ENV.
 230 This environment can be passed to `macroexpand'."
 231   (car (cdr (cdr env))))
 232
 233 (defsubst elint-env-macrop (env macro)
 234   "Non-nil if ENV contains MACRO."
 235   (assq macro (elint-env-macro-env env)))
 236
 237 ;;;
 238 ;;; User interface
 239 ;;;
 240
 241 ;;;###autoload
 242 (defun elint-file (file)
 243   "Lint the file FILE."
 244   (interactive "fElint file: ")
 245   (setq file (expand-file-name file))
 246   (or elint-builtin-variables
 247       (elint-initialize))
 248   (let ((dir (file-name-directory file)))
 249     (let ((default-directory dir))
 250       (elint-display-log))
 251     (elint-set-mode-line t)
 252     (with-current-buffer elint-log-buffer
 253       (unless (string-equal default-directory dir)
 254         (elint-log-message (format "\f\nLeaving directory `%s'"
 255                                    default-directory) t)
 256         (elint-log-message (format "Entering directory `%s'" dir) t)
 257         (setq default-directory dir))))
 258   (let ((str (format "Linting file %s" file)))
 259     (message "%s..." str)
 260     (or noninteractive
 261         (elint-log-message (format "\f\n%s at %s" str (current-time-string)) t))
 262     ;; elint-current-buffer clears log.
 263     (with-temp-buffer
 264       (insert-file-contents file)
 265       (let ((buffer-file-name file)
 266             (max-lisp-eval-depth (max 1000 max-lisp-eval-depth)))
 267         (with-syntax-table emacs-lisp-mode-syntax-table
 268           (mapc 'elint-top-form (elint-update-env)))))
 269     (elint-set-mode-line)
 270     (message "%s...done" str)))
 271
 272 ;; cf byte-recompile-directory.
 273 ;;;###autoload
 274 (defun elint-directory (directory)
 275   "Lint all the .el files in DIRECTORY.
 276 A complicated directory may require a lot of memory."
 277   (interactive "DElint directory: ")
 278   (let ((elint-running t))
 279     (dolist (file (directory-files directory t))
 280       ;; Bytecomp has emacs-lisp-file-regexp.
 281       (when (and (string-match "\\.el\\'" file)
 282                  (file-readable-p file)
 283                  (not (auto-save-file-name-p file)))
 284         (if (string-match elint-directory-skip-re file)
 285             (message "Skipping file %s" file)
 286           (elint-file file)))))
 287   (elint-set-mode-line))
 288
 289 ;;;###autoload
 290 (defun elint-current-buffer ()
 291   "Lint the current buffer.
 292 If necessary, this first calls `elint-initialize'."
 293   (interactive)
 294   (or elint-builtin-variables
 295       (elint-initialize))
 296   (elint-clear-log (format "Linting %s" (or (buffer-file-name)
 297                                             (buffer-name))))
 298   (elint-display-log)
 299   (elint-set-mode-line t)
 300   (mapc 'elint-top-form (elint-update-env))
 301   ;; Tell the user we're finished.  This is terribly klugy: we set
 302     ;; elint-top-form-logged so elint-log-message doesn't print the
 303     ;; ** top form ** header...
 304   (elint-set-mode-line)
 305   (elint-log-message "\nLinting finished.\n" t))
 306
 307
 308 ;;;###autoload
 309 (defun elint-defun ()
 310   "Lint the function at point.
 311 If necessary, this first calls `elint-initialize'."
 312   (interactive)
 313   (or elint-builtin-variables
 314       (elint-initialize))
 315   (save-excursion
 316     (or (beginning-of-defun) (error "Lint what?"))
 317     (let ((pos (point))
 318           (def (read (current-buffer))))
 319       (elint-display-log)
 320       (elint-update-env)
 321       (elint-top-form (elint-make-top-form def pos)))))
 322
 323 ;;;
 324 ;;; Top form functions
 325 ;;;
 326
 327 (defvar elint-buffer-env nil
 328   "The environment of an elisp buffer.
 329 Will be local in linted buffers.")
 330
 331 (defvar elint-buffer-forms nil
 332   "The top forms in a buffer.
 333 Will be local in linted buffers.")
 334
 335 (defvar elint-last-env-time nil
 336   "The last time the buffers env was updated.
 337 Is measured in buffer-modified-ticks and is local in linted buffers.")
 338
 339 ;; This is a minor optimization.  It is local to every buffer, and so
 340 ;; does not prevent recursive requirs.  It does not list the requires
 341 ;; of requires.
 342 (defvar elint-features nil
 343   "List of all libraries this buffer has required, or that have been provided.")
 344
 345 (defun elint-update-env ()
 346   "Update the elint environment in the current buffer.
 347 Don't do anything if the buffer hasn't been changed since this
 348 function was called the last time.
 349 Returns the forms."
 350   (if (and (local-variable-p 'elint-buffer-env (current-buffer))
 351            (local-variable-p 'elint-buffer-forms (current-buffer))
 352            (local-variable-p 'elint-last-env-time (current-buffer))
 353            (= (buffer-modified-tick) elint-last-env-time))
 354       ;; Env is up to date
 355       elint-buffer-forms
 356     ;; Remake env
 357     (set (make-local-variable 'elint-buffer-forms) (elint-get-top-forms))
 358     (set (make-local-variable 'elint-features) nil)
 359     (set (make-local-variable 'elint-buffer-env)
 360          (elint-init-env elint-buffer-forms))
 361     (if elint-preloaded-env
 362         (elint-env-add-env elint-preloaded-env elint-buffer-env))
 363     (set (make-local-variable 'elint-last-env-time) (buffer-modified-tick))
 364     elint-buffer-forms))
 365
 366 (defun elint-get-top-forms ()
 367   "Collect all the top forms in the current buffer."
 368   (save-excursion
 369     (let (tops)
 370       (goto-char (point-min))
 371       (while (elint-find-next-top-form)
 372         (let ((elint-current-pos (point)))
 373           ;; non-list check could be here too. errors may be out of seq.
 374           ;; quoted check cannot be elsewhere, since quotes skipped.
 375           (if (looking-back "'")
 376               ;; Eg cust-print.el uses ' as a comment syntax.
 377               (elint-warning "Skipping quoted form `'%.20s...'"
 378                            (read (current-buffer)))
 379             (condition-case nil
 380                 (setq tops (cons
 381                             (elint-make-top-form (read (current-buffer))
 382                                                  elint-current-pos)
 383                             tops))
 384               (end-of-file
 385                (goto-char elint-current-pos)
 386                (error "Missing ')' in top form: %s"
 387                       (buffer-substring elint-current-pos
 388                                         (line-end-position))))))))
 389       (nreverse tops))))
 390
 391 (defun elint-find-next-top-form ()
 392   "Find the next top form from point.
 393 Return nil if there are no more forms, t otherwise."
 394   (parse-partial-sexp (point) (point-max) nil t)
 395   (not (eobp)))
 396
 397 (defvar elint-env)                      ; from elint-init-env
 398
 399 (defun elint-init-form (form)
 400   "Process FORM, adding to ELINT-ENV if recognized."
 401   (cond
 402    ;; Eg nnmaildir seems to use [] as a form of comment syntax.
 403    ((not (listp form))
 404     (elint-warning "Skipping non-list form `%s'" form))
 405    ;; Add defined variable
 406    ((memq (car form) '(defvar defconst defcustom))
 407     (setq elint-env (elint-env-add-var elint-env (cadr form))))
 408    ;; Add function
 409    ((memq (car form) '(defun defsubst))
 410     (setq elint-env (elint-env-add-func elint-env (cadr form) (nth 2 form))))
 411    ;; FIXME needs a handler to say second arg is not a variable when we come
 412    ;; to scan the form.
 413    ((eq (car form) 'define-derived-mode)
 414     (setq elint-env (elint-env-add-func elint-env (cadr form) ())
 415           elint-env (elint-env-add-var elint-env (cadr form))
 416           elint-env (elint-env-add-var elint-env
 417                                        (intern (format "%s-map" (cadr form))))))
 418    ((eq (car form) 'define-minor-mode)
 419     (setq elint-env (elint-env-add-func elint-env (cadr form) '(&optional arg))
 420           ;; FIXME mode map?
 421           elint-env (elint-env-add-var elint-env (cadr form))))
 422    ((and (eq (car form) 'easy-menu-define)
 423          (cadr form))
 424     (setq elint-env (elint-env-add-func elint-env (cadr form) '(event))
 425           elint-env (elint-env-add-var elint-env (cadr form))))
 426    ;; FIXME it would be nice to check the autoloads are correct.
 427    ((eq (car form) 'autoload)
 428     (setq elint-env (elint-env-add-func elint-env (cadr (cadr form)) 'unknown)))
 429    ((eq (car form) 'declare-function)
 430     (setq elint-env (elint-env-add-func
 431                elint-env (cadr form)
 432                (if (or (< (length form) 4)
 433                        (eq (nth 3 form) t)
 434                        (unless (stringp (nth 2 form))
 435                          (elint-error "Malformed declaration for `%s'"
 436                                       (cadr form))
 437                          t))
 438                    'unknown
 439                  (nth 3 form)))))
 440    ((and (eq (car form) 'defalias) (listp (nth 2 form)))
 441     ;; If the alias points to something already in the environment,
 442     ;; add the alias to the environment with the same arguments.
 443     ;; FIXME symbol-function, eg backquote.el?
 444     (let ((def (elint-env-find-func elint-env (cadr (nth 2 form)))))
 445       (setq elint-env (elint-env-add-func elint-env (cadr (cadr form))
 446                                     (if def (cadr def) 'unknown)))))
 447    ;; Add macro, both as a macro and as a function
 448    ((eq (car form) 'defmacro)
 449     (setq elint-env (elint-env-add-macro elint-env (cadr form)
 450                                    (cons 'lambda (cddr form)))
 451           elint-env (elint-env-add-func elint-env (cadr form) (nth 2 form))))
 452    ((and (eq (car form) 'put)
 453          (= 4 (length form))
 454          (eq (car-safe (cadr form)) 'quote)
 455          (equal (nth 2 form) '(quote error-conditions)))
 456     (set (make-local-variable 'elint-extra-errors)
 457          (cons (cadr (cadr form)) elint-extra-errors)))
 458    ((eq (car form) 'provide)
 459     (add-to-list 'elint-features (eval (cadr form))))
 460    ;; Import variable definitions
 461    ((memq (car form) '(require cc-require cc-require-when-compile))
 462     (let ((name (eval (cadr form)))
 463           (file (eval (nth 2 form)))
 464           (elint-doing-cl (bound-and-true-p elint-doing-cl)))
 465       (unless (memq name elint-features)
 466         (add-to-list 'elint-features name)
 467         ;; cl loads cl-macs in an opaque manner.
 468         ;; Since cl-macs requires cl, we can just process cl-macs.
 469         (and (eq name 'cl) (not elint-doing-cl)
 470              ;; We need cl if elint-form is to be able to expand cl macros.
 471              (require 'cl)
 472              (setq name 'cl-macs
 473                    file nil
 474                    elint-doing-cl t)) ; blech
 475         (setq elint-env (elint-add-required-env elint-env name file))))))
 476   elint-env)
 477
 478 (defun elint-init-env (forms)
 479   "Initialize the environment from FORMS."
 480   (let ((elint-env (elint-make-env))
 481         form)
 482     (while forms
 483       (setq form (elint-top-form-form (car forms))
 484             forms (cdr forms))
 485       ;; FIXME eval-when-compile should be treated differently (macros).
 486       ;; Could bind something that makes elint-init-form only check
 487       ;; defmacros.
 488       (if (memq (car-safe form)
 489                 '(eval-and-compile eval-when-compile progn prog1 prog2
 490                                    with-no-warnings))
 491           (mapc 'elint-init-form (cdr form))
 492         (elint-init-form form)))
 493     elint-env))
 494
 495 (defun elint-add-required-env (env name file)
 496   "Augment ENV with the variables defined by feature NAME in FILE."
 497   (condition-case err
 498       (let* ((libname (if (stringp file)
 499                           file
 500                         (symbol-name name)))
 501
 502              ;; First try to find .el files, then the raw name
 503              (lib1 (locate-library (concat libname ".el") t))
 504              (lib (or lib1 (locate-library libname t))))
 505         ;; Clear the messages :-/
 506         ;; (Messes up the "Initializing elint..." message.)
 507 ;;;     (message nil)
 508         (if lib
 509             (with-current-buffer (find-file-noselect lib)
 510               ;; FIXME this doesn't use a temp buffer, because it
 511               ;; stores the result in buffer-local variables so that
 512               ;; it can be reused.
 513               (elint-update-env)
 514               (setq env (elint-env-add-env env elint-buffer-env)))
 515               ;;; (with-temp-buffer
 516               ;;;       (insert-file-contents lib)
 517               ;;;       (with-syntax-table emacs-lisp-mode-syntax-table
 518               ;;;         (elint-update-env))
 519               ;;;       (setq env (elint-env-add-env env elint-buffer-env))))
 520               ;;(message "Elint processed (require '%s)" name))
 521           (error "%s.el not found in load-path" libname)))
 522     (error
 523      (message "Can't get variables from require'd library %s: %s"
 524               name (error-message-string err))))
 525   env)
 526
 527 (defvar elint-top-form nil
 528   "The currently linted top form, or nil.")
 529
 530 (defvar elint-top-form-logged nil
 531   "The value t if the currently linted top form has been mentioned in the log buffer.")
 532
 533 (defun elint-top-form (form)
 534   "Lint a top FORM."
 535   (let ((elint-top-form form)
 536         (elint-top-form-logged nil)
 537         (elint-current-pos (elint-top-form-pos form)))
 538     (elint-form (elint-top-form-form form) elint-buffer-env)))
 539
 540 ;;;
 541 ;;; General form linting functions
 542 ;;;
 543
 544 (defconst elint-special-forms
 545   '((let . elint-check-let-form)
 546     (let* . elint-check-let-form)
 547     (setq . elint-check-setq-form)
 548     (quote . elint-check-quote-form)
 549     (function . elint-check-quote-form)
 550     (cond . elint-check-cond-form)
 551     (lambda . elint-check-defun-form)
 552     (function . elint-check-function-form)
 553     (setq-default . elint-check-setq-form)
 554     (defalias . elint-check-defalias-form)
 555     (defun . elint-check-defun-form)
 556     (defsubst . elint-check-defun-form)
 557     (defmacro . elint-check-defun-form)
 558     (defvar . elint-check-defvar-form)
 559     (defconst . elint-check-defvar-form)
 560     (defcustom . elint-check-defcustom-form)
 561     (macro . elint-check-macro-form)
 562     (condition-case . elint-check-condition-case-form)
 563     (if . elint-check-conditional-form)
 564     (when . elint-check-conditional-form)
 565     (unless . elint-check-conditional-form)
 566     (and . elint-check-conditional-form)
 567     (or . elint-check-conditional-form))
 568   "Functions to call when some special form should be linted.")
 569
 570 (defun elint-form (form env &optional nohandler)
 571   "Lint FORM in the environment ENV.
 572 Optional argument NOHANDLER non-nil means ignore `elint-special-forms'.
 573 Returns the environment created by the form."
 574   (cond
 575    ((consp form)
 576     (let ((func (cdr (assq (car form) elint-special-forms))))
 577       (if (and func (not nohandler))
 578           ;; Special form
 579           (funcall func form env)
 580
 581         (let* ((func (car form))
 582                (args (elint-get-args func env))
 583                (argsok t))
 584           (cond
 585            ((eq args 'undefined)
 586             (setq argsok nil)
 587             (or (memq 'undefined-functions elint-ignored-warnings)
 588                 (elint-error "Call to undefined function: %s" func)))
 589
 590            ((eq args 'unknown) nil)
 591
 592            (t (setq argsok (elint-match-args form args))))
 593
 594           ;; Is this a macro?
 595           (if (elint-env-macrop env func)
 596               ;; Macro defined in buffer, expand it
 597               (if argsok
 598                   ;; FIXME error if macro uses macro, eg bytecomp.el.
 599                   (condition-case nil
 600                       (elint-form
 601                        (macroexpand form (elint-env-macro-env env)) env)
 602                     (error
 603                      (or (memq 'macro-expansion elint-ignored-warnings)
 604                          (elint-error "Elint failed to expand macro: %s" func))
 605                      env))
 606                 env)
 607
 608             (let ((fcode (if (symbolp func)
 609                              (if (fboundp func)
 610                                  (indirect-function func))
 611                            func)))
 612               (if (and (listp fcode) (eq (car fcode) 'macro))
 613                   ;; Macro defined outside buffer
 614                   (if argsok
 615                       (elint-form (macroexpand form) env)
 616                     env)
 617                 ;; Function, lint its parameters
 618                 (elint-forms (cdr form) env))))))))
 619    ((symbolp form)
 620     ;; :foo variables are quoted
 621     (and (/= (aref (symbol-name form) 0) ?:)
 622          (not (memq 'unbound-reference elint-ignored-warnings))
 623          (elint-unbound-variable form env)
 624          (elint-warning "Reference to unbound symbol: %s" form))
 625     env)
 626
 627    (t env)))
 628
 629 (defun elint-forms (forms env)
 630   "Lint the FORMS, accumulating an environment, starting with ENV."
 631   ;; grumblegrumbletailrecursiongrumblegrumble
 632   (if (listp forms)
 633       (dolist (f forms env)
 634         (setq env (elint-form f env)))
 635     ;; Loop macro?
 636     (elint-error "Elint failed to parse form: %s" forms)
 637     env))
 638
 639 (defvar elint-bound-variable nil
 640   "Name of a temporarily bound symbol.")
 641
 642 (defun elint-unbound-variable (var env)
 643   "Return t if VAR is unbound in ENV."
 644   ;; #1063 suggests adding (symbol-file var) here, but I don't think
 645   ;; this is right, because it depends on what files you happen to have
 646   ;; loaded at the time, which might not be the same when the code runs.
 647   ;; It also suggests adding:
 648   ;; (numberp (get var 'variable-documentation))
 649   ;; (numberp (cdr-safe (get var 'variable-documentation)))
 650   ;; but this is not needed now elint-scan-doc-file exists.
 651   (not (or (memq var '(nil t))
 652            (eq var elint-bound-variable)
 653            (elint-env-find-var env var)
 654            (memq var elint-builtin-variables)
 655            (memq var elint-autoloaded-variables)
 656            (memq var elint-standard-variables))))
 657
 658 ;;;
 659 ;;; Function argument checking
 660 ;;;
 661
 662 (defun elint-match-args (arglist argpattern)
 663   "Match ARGLIST against ARGPATTERN."
 664   (let ((state 'all)
 665         (al (cdr arglist))
 666         (ap argpattern)
 667         (ok t))
 668     (while
 669         (cond
 670          ((and (null al) (null ap)) nil)
 671          ((eq (car ap) '&optional)
 672           (setq state 'optional)
 673           (setq ap (cdr ap))
 674           t)
 675          ((eq (car ap) '&rest)
 676           nil)
 677          ((or (and (eq state 'all) (or (null al) (null ap)))
 678               (and (eq state 'optional) (and al (null ap))))
 679           (elint-error "Wrong number of args: %s, %s" arglist argpattern)
 680           (setq ok nil)
 681           nil)
 682          ((and (eq state 'optional) (null al))
 683           nil)
 684          (t (setq al (cdr al)
 685                   ap (cdr ap))
 686             t)))
 687     ok))
 688
 689 (defvar elint-bound-function nil
 690   "Name of a temporarily bound function symbol.")
 691
 692 (defun elint-get-args (func env)
 693   "Find the args of FUNC in ENV.
 694 Returns `unknown' if we couldn't find arguments."
 695   (let ((f (elint-env-find-func env func)))
 696     (if f
 697         (cadr f)
 698       (if (symbolp func)
 699           (if (eq func elint-bound-function)
 700               'unknown
 701             (if (fboundp func)
 702                 (let ((fcode (indirect-function func)))
 703                   (if (subrp fcode)
 704                       ;; FIXME builtins with no args have args = nil.
 705                       (or (get func 'elint-args) 'unknown)
 706                     (elint-find-args-in-code fcode)))
 707               'undefined))
 708         (elint-find-args-in-code func)))))
 709
 710 (defun elint-find-args-in-code (code)
 711   "Extract the arguments from CODE.
 712 CODE can be a lambda expression, a macro, or byte-compiled code."
 713   (cond
 714    ((byte-code-function-p code)
 715     (aref code 0))
 716    ((and (listp code) (eq (car code) 'lambda))
 717     (car (cdr code)))
 718    ((and (listp code) (eq (car code) 'macro))
 719     (elint-find-args-in-code (cdr code)))
 720    (t 'unknown)))
 721
 722 ;;;
 723 ;;; Functions to check some special forms
 724 ;;;
 725
 726 (defun elint-check-cond-form (form env)
 727   "Lint a cond FORM in ENV."
 728   (dolist (f (cdr form))
 729     (if (consp f)
 730         (let ((test (car f)))
 731           (cond ((equal test '(featurep (quote xemacs))))
 732                 ((equal test '(not (featurep (quote emacs)))))
 733                 ;; FIXME (and (boundp 'foo)
 734                 ((and (eq (car-safe test) 'fboundp)
 735                       (= 2 (length test))
 736                       (eq (car-safe (cadr test)) 'quote))
 737                  (let ((elint-bound-function (cadr (cadr test))))
 738                    (elint-forms f env)))
 739                 ((and (eq (car-safe test) 'boundp)
 740                       (= 2 (length test))
 741                       (eq (car-safe (cadr test)) 'quote))
 742                  (let ((elint-bound-variable (cadr (cadr test))))
 743                    (elint-forms f env)))
 744                 (t (elint-forms f env))))
 745       (elint-error "cond clause should be a list: %s" f)))
 746   env)
 747
 748 (defun elint-check-defun-form (form env)
 749   "Lint a defun/defmacro/lambda FORM in ENV."
 750   (setq form (if (eq (car form) 'lambda) (cdr form) (cddr form)))
 751   (mapc (lambda (p)
 752           (or (memq p '(&optional &rest))
 753               (setq env (elint-env-add-var env p))))
 754         (car form))
 755   (elint-forms (cdr form) env))
 756
 757 (defun elint-check-defalias-form (form env)
 758   "Lint a defalias FORM in ENV."
 759   (let ((alias (cadr form))
 760         (target (nth 2 form)))
 761     (and (eq (car-safe alias) 'quote)
 762          (eq (car-safe target) 'quote)
 763          (eq (elint-get-args (cadr target) env) 'undefined)
 764          (elint-warning "Alias `%s' has unknown target `%s'"
 765                         (cadr alias) (cadr target))))
 766   (elint-form form env t))
 767
 768 (defun elint-check-let-form (form env)
 769   "Lint the let/let* FORM in ENV."
 770   (let ((varlist (cadr form)))
 771     (if (not varlist)
 772         (if (> (length form) 2)
 773             ;; An empty varlist is not really an error.  Eg some cl macros
 774             ;; can expand to such a form.
 775             (progn
 776               (or (memq 'empty-let elint-ignored-warnings)
 777                   (elint-warning "Empty varlist in let: %s" form))
 778               ;; Lint the body forms
 779               (elint-forms (cddr form) env))
 780           (elint-error "Malformed let: %s" form)
 781           env)
 782       ;; Check for (let (a (car b)) ...) type of error
 783       (if (and (= (length varlist) 2)
 784                (symbolp (car varlist))
 785                (listp (car (cdr varlist)))
 786                (fboundp (car (car (cdr varlist)))))
 787           (elint-warning "Suspect varlist: %s" form))
 788       ;; Add variables to environment, and check the init values
 789       (let ((newenv env))
 790         (mapc (lambda (s)
 791                 (cond
 792                  ((symbolp s)
 793                   (setq newenv (elint-env-add-var newenv s)))
 794                  ((and (consp s) (<= (length s) 2))
 795                   (elint-form (cadr s)
 796                               (if (eq (car form) 'let)
 797                                   env
 798                                 newenv))
 799                   (setq newenv
 800                         (elint-env-add-var newenv (car s))))
 801                  (t (elint-error
 802                      "Malformed `let' declaration: %s" s))))
 803               varlist)
 804
 805         ;; Lint the body forms
 806         (elint-forms (cddr form) newenv)))))
 807
 808 (defun elint-check-setq-form (form env)
 809   "Lint the setq FORM in ENV."
 810   (or (= (mod (length form) 2) 1)
 811       ;; (setq foo) is valid and equivalent to (setq foo nil).
 812       (elint-warning "Missing value in setq: %s" form))
 813   (let ((newenv env)
 814         sym val)
 815     (setq form (cdr form))
 816     (while form
 817       (setq sym (car form)
 818             val (car (cdr form))
 819             form (cdr (cdr form)))
 820       (if (symbolp sym)
 821           (and (not (memq 'unbound-assignment elint-ignored-warnings))
 822                (elint-unbound-variable sym newenv)
 823                (elint-warning "Setting previously unbound symbol: %s" sym))
 824         (elint-error "Setting non-symbol in setq: %s" sym))
 825       (elint-form val newenv)
 826       (if (symbolp sym)
 827           (setq newenv (elint-env-add-var newenv sym))))
 828     newenv))
 829
 830 (defun elint-check-defvar-form (form env)
 831   "Lint the defvar/defconst FORM in ENV."
 832   (if (or (= (length form) 2)
 833           (= (length form) 3)
 834           ;; Eg the defcalcmodevar macro can expand with a nil doc-string.
 835           (and (= (length form) 4) (string-or-null-p (nth 3 form))))
 836           (elint-env-add-global-var (elint-form (nth 2 form) env)
 837                              (car (cdr form)))
 838     (elint-error "Malformed variable declaration: %s" form)
 839     env))
 840
 841 (defun elint-check-defcustom-form (form env)
 842   "Lint the defcustom FORM in ENV."
 843   (if (and (> (length form) 3)
 844            ;; even no. of keyword/value args ?
 845            (zerop (logand (length form) 1)))
 846       (elint-env-add-global-var (elint-form (nth 2 form) env)
 847                                 (car (cdr form)))
 848     (elint-error "Malformed variable declaration: %s" form)
 849     env))
 850
 851 (defun elint-check-function-form (form env)
 852   "Lint the function FORM in ENV."
 853   (let ((func (car (cdr-safe form))))
 854     (cond
 855      ((symbolp func)
 856       (or (elint-env-find-func env func)
 857           ;; FIXME potentially bogus, since it uses the current
 858           ;; environment rather than a clean one.
 859           (fboundp func)
 860           (elint-warning "Reference to undefined function: %s" form))
 861       env)
 862      ((and (consp func) (memq (car func) '(lambda macro)))
 863       (elint-form func env))
 864      ((stringp func) env)
 865      (t (elint-error "Not a function object: %s" form)
 866         env))))
 867
 868 (defun elint-check-quote-form (form env)
 869   "Lint the quote FORM in ENV."
 870   env)
 871
 872 (defun elint-check-macro-form (form env)
 873   "Check the macro FORM in ENV."
 874   (elint-check-function-form (list (car form) (cdr form)) env))
 875
 876 (defun elint-check-condition-case-form (form env)
 877   "Check the `condition-case' FORM in ENV."
 878   (let ((resenv env))
 879     (if (< (length form) 3)
 880         (elint-error "Malformed condition-case: %s" form)
 881       (or (symbolp (cadr form))
 882           (elint-warning "First parameter should be a symbol: %s" form))
 883       (setq resenv (elint-form (nth 2 form) env))
 884       (let ((newenv (elint-env-add-var env (cadr form)))
 885             errlist)
 886         (dolist (err (nthcdr 3 form))
 887           (setq errlist (car err))
 888           (mapc (lambda (s)
 889                   (or (get s 'error-conditions)
 890                       (get s 'error-message)
 891                       (memq s elint-extra-errors)
 892                       (elint-warning
 893                        "Not an error symbol in error handler: %s" s)))
 894                 (cond
 895                  ((symbolp errlist) (list errlist))
 896                  ((listp errlist) errlist)
 897                  (t (elint-error "Bad error list in error handler: %s"
 898                                  errlist)
 899                     nil)))
 900           (elint-forms (cdr err) newenv))))
 901     resenv))
 902
 903 ;; For the featurep parts, an alternative is to have
 904 ;; elint-get-top-forms skip the irrelevant branches.
 905 (defun elint-check-conditional-form (form env)
 906   "Check the when/unless/and/or FORM in ENV.
 907 Does basic handling of `featurep' tests."
 908   (let ((func (car form))
 909         (test (cadr form))
 910         sym)
 911     ;; Misses things like (and t (featurep 'xemacs))
 912     ;; Check byte-compile-maybe-guarded.
 913     (cond ((and (memq func '(when and))
 914                 (eq (car-safe test) 'boundp)
 915                 (= 2 (length test))
 916                 (eq (car-safe (cadr test)) 'quote))
 917            ;; Cf elint-check-let-form, which modifies the whole ENV.
 918            (let ((elint-bound-variable (cadr (cadr test))))
 919              (elint-form form env t)))
 920           ((and (memq func '(when and))
 921                 (eq (car-safe test) 'fboundp)
 922                 (= 2 (length test))
 923                 (eq (car-safe (cadr test)) 'quote))
 924            (let ((elint-bound-function (cadr (cadr test))))
 925              (elint-form form env t)))
 926           ;; Let's not worry about (if (not (boundp...
 927           ((and (eq func 'if)
 928                 (eq (car-safe test) 'boundp)
 929                 (= 2 (length test))
 930                 (eq (car-safe (cadr test)) 'quote))
 931            (let ((elint-bound-variable (cadr (cadr test))))
 932              (elint-form (nth 2 form) env))
 933            (dolist (f (nthcdr 3 form))
 934              (elint-form f env)))
 935           ((and (eq func 'if)
 936                 (eq (car-safe test) 'fboundp)
 937                 (= 2 (length test))
 938                 (eq (car-safe (cadr test)) 'quote))
 939            (let ((elint-bound-function (cadr (cadr test))))
 940              (elint-form (nth 2 form) env))
 941            (dolist (f (nthcdr 3 form))
 942              (elint-form f env)))
 943           ((and (memq func '(when and)) ; skip all
 944                 (or (null test)
 945                     (member test '((featurep (quote xemacs))
 946                                    (not (featurep (quote emacs)))))
 947                     (and (eq (car-safe test) 'and)
 948                          (equal (car-safe (cdr test))
 949                                 '(featurep (quote xemacs)))))))
 950           ((and (memq func '(unless or))
 951                 (equal test '(featurep (quote emacs)))))
 952           ((and (eq func 'if)
 953                 (or (null test)       ; eg custom-browse-insert-prefix
 954                     (member test '((featurep (quote xemacs))
 955                                    (not (featurep (quote emacs)))))
 956                     (and (eq (car-safe test) 'and)
 957                          (equal (car-safe (cdr test))
 958                                 '(featurep (quote xemacs))))))
 959            (dolist (f (nthcdr 3 form))
 960              (elint-form f env)))       ; lint the else branch
 961           ((and (eq func 'if)
 962                 (equal test '(featurep (quote emacs))))
 963            (elint-form (nth 2 form) env)) ; lint the if branch
 964           ;; Process conditional as normal, without handler.
 965           (t
 966            (elint-form form env t))))
 967   env)
 968
 969 ;;;
 970 ;;; Message functions
 971 ;;;
 972
 973 (defvar elint-current-pos)       ; dynamically bound in elint-top-form
 974
 975 (defun elint-log (type string args)
 976   (elint-log-message (format "%s:%d:%s: %s"
 977                              (let ((f (buffer-file-name)))
 978                                (if f
 979                                    (file-name-nondirectory f)
 980                                  (buffer-name)))
 981                              (if (boundp 'elint-current-pos)
 982                                  (save-excursion
 983                                    (goto-char elint-current-pos)
 984                                    (1+ (count-lines (point-min)
 985                                                     (line-beginning-position))))
 986                                0)       ; unknown position
 987                              type
 988                              (apply 'format string args))))
 989
 990 (defun elint-error (string &rest args)
 991   "Report a linting error.
 992 STRING and ARGS are thrown on `format' to get the message."
 993   (elint-log "Error" string args))
 994
 995 (defun elint-warning (string &rest args)
 996   "Report a linting warning.
 997 See `elint-error'."
 998   (elint-log "Warning" string args))
 999
1000 (defun elint-output (string)
1001   "Print or insert STRING, depending on value of `noninteractive'."
1002   (if noninteractive
1003       (message "%s" string)
1004     (insert string "\n")))
1005
1006 (defun elint-log-message (errstr &optional top)
1007   "Insert ERRSTR last in the lint log buffer.
1008 Optional argument TOP non-nil means pretend `elint-top-form-logged' is non-nil."
1009   (with-current-buffer (elint-get-log-buffer)
1010     (goto-char (point-max))
1011     (let ((inhibit-read-only t))
1012       (or (bolp) (newline))
1013       ;; Do we have to say where we are?
1014       (unless (or elint-top-form-logged top)
1015         (let* ((form (elint-top-form-form elint-top-form))
1016                (top (car form)))
1017           (elint-output (cond
1018                          ((memq top '(defun defsubst))
1019                           (format "\nIn function %s:" (cadr form)))
1020                          ((eq top 'defmacro)
1021                           (format "\nIn macro %s:" (cadr form)))
1022                          ((memq top '(defvar defconst))
1023                           (format "\nIn variable %s:" (cadr form)))
1024                          (t "\nIn top level expression:"))))
1025         (setq elint-top-form-logged t))
1026       (elint-output errstr))))
1027
1028 (defun elint-clear-log (&optional header)
1029   "Clear the lint log buffer.
1030 Insert HEADER followed by a blank line if non-nil."
1031   (let ((dir default-directory))
1032     (with-current-buffer (elint-get-log-buffer)
1033       (setq default-directory dir)
1034       (let ((inhibit-read-only t))
1035         (erase-buffer)
1036         (if header (insert header "\n"))))))
1037
1038 (defun elint-display-log ()
1039   "Display the lint log buffer."
1040   (let ((pop-up-windows t))
1041     (display-buffer (elint-get-log-buffer))
1042     (sit-for 0)))
1043
1044 (defvar elint-running)
1045
1046 (defun elint-set-mode-line (&optional on)
1047   "Set the mode-line-process of the Elint log buffer."
1048   (with-current-buffer (elint-get-log-buffer)
1049     (and (eq major-mode 'compilation-mode)
1050          (setq mode-line-process
1051                (list (if (or on (bound-and-true-p elint-running))
1052                          (propertize ":run" 'face 'compilation-warning)
1053                        (propertize ":finished" 'face 'compilation-info)))))))
1054
1055 (defun elint-get-log-buffer ()
1056   "Return a log buffer for elint."
1057   (or (get-buffer elint-log-buffer)
1058       (with-current-buffer (get-buffer-create elint-log-buffer)
1059         (or (eq major-mode 'compilation-mode)
1060             (compilation-mode))
1061         (setq buffer-undo-list t)
1062         (current-buffer))))
1063
1064 ;;;
1065 ;;; Initializing code
1066 ;;;
1067
1068 (defun elint-put-function-args (func args)
1069   "Mark function FUNC as having argument list ARGS."
1070   (and (symbolp func)
1071        args
1072        (not (eq args 'unknown))
1073        (put func 'elint-args args)))
1074
1075 ;;;###autoload
1076 (defun elint-initialize (&optional reinit)
1077   "Initialize elint.
1078 If elint is already initialized, this does nothing, unless
1079 optional prefix argument REINIT is non-nil."
1080   (interactive "P")
1081   (if (and elint-builtin-variables (not reinit))
1082       (message "Elint is already initialized")
1083     (message "Initializing elint...")
1084     (setq elint-builtin-variables (elint-scan-doc-file)
1085           elint-autoloaded-variables (elint-find-autoloaded-variables))
1086     (mapc (lambda (x) (elint-put-function-args (car x) (cdr x)))
1087           (elint-find-builtin-args))
1088     (if elint-unknown-builtin-args
1089         (mapc (lambda (x) (elint-put-function-args (car x) (cdr x)))
1090               elint-unknown-builtin-args))
1091     (when elint-scan-preloaded
1092       (dolist (lib preloaded-file-list)
1093         ;; Skip files that contain nothing of use to us.
1094         (unless (string-match elint-preloaded-skip-re lib)
1095           (setq elint-preloaded-env
1096                 (elint-add-required-env elint-preloaded-env nil lib)))))
1097     (message "Initializing elint...done")))
1098
1099
1100 ;; This includes all the built-in and dumped things with documentation.
1101 (defun elint-scan-doc-file ()
1102   "Scan the DOC file for function and variables.
1103 Marks the function wih their arguments, and returns a list of variables."
1104   ;; Cribbed from help-fns.el.
1105   (let ((docbuf " *DOC*")
1106         vars sym args)
1107     (save-excursion
1108       (if (get-buffer docbuf)
1109           (progn
1110             (set-buffer docbuf)
1111             (goto-char (point-min)))
1112         (set-buffer (get-buffer-create docbuf))
1113         (insert-file-contents-literally
1114          (expand-file-name internal-doc-file-name doc-directory)))
1115       (while (re-search-forward "\1f\\([VF]\\)" nil t)
1116         (when (setq sym (intern-soft (buffer-substring (point)
1117                                                        (line-end-position))))
1118           (if (string-equal (match-string 1) "V")
1119               ;; Excludes platform-specific stuff not relevant to the
1120               ;; running platform.
1121               (if (boundp sym) (setq vars (cons sym vars)))
1122             ;; Function.
1123             (when (fboundp sym)
1124               (when (re-search-forward "\\(^(fn.*)\\)?\1f" nil t)
1125                 (backward-char 1)
1126                 ;; FIXME distinguish no args from not found.
1127                 (and (setq args (match-string 1))
1128                      (setq args
1129                            (ignore-errors
1130                              (read
1131                               (replace-regexp-in-string "^(fn ?" "(" args))))
1132                      (elint-put-function-args sym args))))))))
1133     vars))
1134
1135 (defun elint-find-autoloaded-variables ()
1136   "Return a list of all autoloaded variables."
1137   (let (var vars)
1138     (with-temp-buffer
1139       (insert-file-contents (locate-library "loaddefs.el"))
1140       (while (re-search-forward "^(defvar \\([[:alnum:]_-]+\\)" nil t)
1141         (and (setq var (intern-soft (match-string 1)))
1142              (boundp var)
1143              (setq vars (cons var vars)))))
1144     vars))
1145
1146 (defun elint-find-builtins ()
1147   "Return a list of all built-in functions."
1148   (let (subrs)
1149     (mapatoms (lambda (s) (and (fboundp s) (subrp (symbol-function s))
1150                                (setq subrs (cons s subrs)))))
1151     subrs))
1152
1153 (defun elint-find-builtin-args (&optional list)
1154   "Return a list of the built-in functions and their arguments.
1155 If LIST is nil, call `elint-find-builtins' to get a list of all built-in
1156 functions, otherwise use LIST.
1157
1158 Each function is represented by a cons cell:
1159 \(function-symbol . args)
1160 If no documentation could be found args will be `unknown'."
1161   (mapcar (lambda (f)
1162             (let ((doc (documentation f t)))
1163               (or (and doc
1164                        (string-match "\n\n(fn\\(.*)\\)\\'" doc)
1165                        (ignore-errors
1166                         ;; "BODY...)" -> "&rest BODY)".
1167                         (read (replace-regexp-in-string
1168                                "\\([^ ]+\\)\\.\\.\\.)\\'" "&rest \\1)"
1169                                (format "(%s %s" f (match-string 1 doc)) t))))
1170                   (cons f 'unknown))))
1171           (or list (elint-find-builtins))))
1172
1173 (provide 'elint)
1174
1175 ;;; elint.el ends here