]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Merge from emacs-23; up to 2010-06-15T03:34:12Z!rgm@gnu.org.
[gnu-emacs] / src / ChangeLog
1 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2
3 * dispnew.c (scrolling_window): Before scrolling, turn off a
4 mouse-highlight in the window being scrolled.
5
6 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7
8 Move DEFSYM to lisp.h and use everywhere.
9
10 * character.h (DEFSYM): Move declaration...
11 * lisp.h (DEFSYM): ...here.
12
13 * gnutls.c:
14 * minibuf.c:
15 * w32menu.c:
16 * w32proc.c:
17 * w32select.c: Don't include character.h.
18
19 * alloc.c (syms_of_alloc):
20 * buffer.c (syms_of_buffer):
21 * bytecode.c (syms_of_bytecode):
22 * callint.c (syms_of_callint):
23 * casefiddle.c (syms_of_casefiddle):
24 * casetab.c (init_casetab_once):
25 * category.c (init_category_once, syms_of_category):
26 * ccl.c (syms_of_ccl):
27 * cmds.c (syms_of_cmds):
28 * composite.c (syms_of_composite):
29 * dbusbind.c (syms_of_dbusbind):
30 * dired.c (syms_of_dired):
31 * dispnew.c (syms_of_display):
32 * doc.c (syms_of_doc):
33 * editfns.c (syms_of_editfns):
34 * emacs.c (syms_of_emacs):
35 * eval.c (syms_of_eval):
36 * fileio.c (syms_of_fileio):
37 * fns.c (syms_of_fns):
38 * frame.c (syms_of_frame):
39 * fringe.c (syms_of_fringe):
40 * insdel.c (syms_of_insdel):
41 * keymap.c (syms_of_keymap):
42 * lread.c (init_obarray, syms_of_lread):
43 * macros.c (syms_of_macros):
44 * msdos.c (syms_of_msdos):
45 * print.c (syms_of_print):
46 * process.c (syms_of_process):
47 * search.c (syms_of_search):
48 * sound.c (syms_of_sound):
49 * syntax.c (init_syntax_once, syms_of_syntax):
50 * terminal.c (syms_of_terminal):
51 * textprop.c (syms_of_textprop):
52 * undo.c (syms_of_undo):
53 * w32.c (globals_of_w32):
54 * window.c (syms_of_window):
55 * xdisp.c (syms_of_xdisp):
56 * xfaces.c (syms_of_xfaces):
57 * xfns.c (syms_of_xfns):
58 * xmenu.c (syms_of_xmenu):
59 * xsettings.c (syms_of_xsettings):
60 * xterm.c (syms_of_xterm): Use DEFSYM.
61
62 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
63
64 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
65
66 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
67
68 Integer and buffer overflow fixes (Bug#8873).
69
70 * print.c (printchar, strout): Check for string overflow.
71 (PRINTPREPARE, printchar, strout):
72 Don't set size unless allocation succeeds.
73
74 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
75 for sizes. Check for string overflow more accurately.
76 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
77
78 * macros.c: Integer and buffer overflow fixes.
79 * keyboard.h (struct keyboard.kbd_macro_bufsize):
80 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
81 Use ptrdiff_t, not int, for sizes.
82 Don't increment bufsize until after realloc succeeds.
83 Check for size-calculation overflow.
84 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
85
86 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
87
88 * lread.c: Integer overflow fixes.
89 (read_integer): Radix is now EMACS_INT, not int,
90 to improve quality of diagnostics for out-of-range radices.
91 Calculate buffer size correctly for out-of-range radices.
92 (read1): Check for integer overflow in radices, and in
93 read-circle numbers.
94 (read_escape): Avoid int overflow.
95 (Fload, openp, read_buffer_size, read1)
96 (substitute_object_recurse, read_vector, read_list, map_obarray):
97 Use ptrdiff_t, not int, for sizes.
98 (read1): Use EMACS_INT, not int, for sizes.
99 Check for size overflow.
100
101 * image.c (cache_image): Check for size arithmetic overflow.
102
103 * lread.c: Integer overflow issues.
104 (saved_doc_string_size, saved_doc_string_length)
105 (prev_saved_doc_string_size, prev_saved_doc_string_length):
106 Now ptrdiff_t, not int.
107 (read1): Don't assume doc string length fits in int. Check for
108 out-of-range doc string lengths.
109 (read_list): Don't assume file position fits in int.
110 (read_escape): Check for hex character overflow.
111
112 2011-06-22 Leo Liu <sdl.web@gmail.com>
113
114 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
115 Move to minibuffer.el.
116
117 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
118
119 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
120 The following patches are for when GLYPH_DEBUG && !XASSERT.
121 * dispextern.h (trace_redisplay_p, dump_glyph_string):
122 * dispnew.c (flush_stdout):
123 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
124 Mark as externally visible.
125 * dispnew.c (check_window_matrix_pointers): Now static.
126 * dispnew.c (window_to_frame_vpos):
127 * xfns.c (unwind_create_frame):
128 * xterm.c (x_check_font): Remove unused local.
129 * scroll.c (CHECK_BOUNDS):
130 * xfaces.c (cache_fache): Rename local to avoid shadowing.
131 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
132 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
133 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
134 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
135 Now static.
136 (debug_method_add): Use va_list and vsprintf rather than relying
137 on undefined behavior with wrong number of arguments.
138 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
139 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
140 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
141 since we're not interested in debugging glyphs with old libraries.
142 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
143 GCC 4.6.0's static checking.
144
145 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
146
147 Integer overflow and signedness fixes (Bug#8873).
148 A few related buffer overrun fixes, too.
149
150 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
151
152 * dispextern.h (struct face.stipple):
153 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
154 (x_bitmap_mask, x_allocate_bitmap_record)
155 (x_create_bitmap_from_data, x_create_bitmap_from_file)
156 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
157 (x_create_bitmap_from_xpm_data):
158 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
159 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
160 (.bitmaps_last):
161 * xfaces.c (load_pixmap):
162 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
163 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
164 (.bitmaps_last, struct x_output.icon_bitmap):
165 Use ptrdiff_t, not int, for bitmap indexes.
166 (x_allocate_bitmap_record): Check for size overflow.
167 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
168
169 Use ptrdiff_t, not int, for overlay counts.
170 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
171 * editfns.c (overlays_around, get_pos_property):
172 * textprop.c (get_char_property_and_overlay):
173 * xdisp.c (next_overlay_change, note_mouse_highlight):
174 * xfaces.c (face_at_buffer_position):
175 * buffer.c (OVERLAY_COUNT_MAX): New macro.
176 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
177 (Fnext_overlay_change, Fprevious_overlay_change)
178 (mouse_face_overlay_overlaps, Foverlays_in):
179 Use ptrdiff_t, not int, for sizes.
180 (overlays_at, overlays_in): Check for size-calculation overflow.
181
182 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
183
184 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
185 (x_session_initialize): Do not assume string length fits in int.
186
187 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
188 This is unlikely, but can occur if DPI is outlandish.
189
190 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
191 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
192
193 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
194 * xrdb.c (magic_file_p, search_magic_path):
195 Omit last arg SUFFIX; it was always 0. All callers changed.
196 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
197
198 * xfont.c (xfont_match): Avoid need for strlen.
199
200 * xfns.c: Don't assume strlen fits in int.
201 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
202
203 * xdisp.c (message_log_check_duplicate): Return intmax_t,
204 not unsigned long, as we prefer signed integers. All callers changed.
205 Detect integer overflow in repeat count.
206 (message_dolog): Don't assume print length fits in 39 bytes.
207 (display_mode_element): Don't assume strlen fits in int.
208
209 * termcap.c: Don't assume sizes fit in int and never overflow.
210 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
211 (gobble_line): Check for size-calculation overflow.
212
213 * minibuf.c (Fread_buffer):
214 * lread.c (intern, intern_c_string):
215 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
216 Don't assume string length fits in int.
217
218 * keyboard.c (parse_tool_bar_item):
219 * gtkutil.c (style_changed_cb): Avoid need for strlen.
220
221 * font.c: Don't assume string length fits in int.
222 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
223 Use ptrdiff_t, not int.
224 (font_intern_prop): Don't assume string length fits in int.
225 Don't assume integer property fits in fixnum.
226 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
227
228 * filelock.c: Fix some buffer overrun and integer overflow issues.
229 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
230 Reformulate so as not to need the command string.
231 Invoke gzip -cd rather than gunzip, as it's more portable.
232 (lock_info_type, lock_file_1, lock_file):
233 Don't assume pid_t and time_t fit in unsigned long.
234 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
235 (current_lock_owner): Prefer signed type for sizes.
236 Use memcpy, not strncpy, where memcpy is what is really wanted.
237 Don't assume (via atoi) that time_t and pid_t fit in int.
238 Check for time_t and/or pid_t out of range, e.g., via a network share.
239 Don't alloca where an auto var works fine.
240
241 * fileio.c: Fix some integer overflow issues.
242 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
243 Don't assume string length fits in int.
244 (directory_file_name): Don't assume string length fits in long.
245 (make_temp_name): Don't assume pid fits in int, or that its print
246 length is less than 20.
247
248 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
249
250 * coding.c (make_subsidiaries): Don't assume string length fits in int.
251
252 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
253
254 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
255 We prefer signed integers, even for size calculations.
256
257 * emacs.c: Don't assume string length fits in 'int'.
258 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
259 (main): Don't invoke strlen when not needed.
260
261 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
262 (XD_DEBUG_MESSAGE): Don't waste a byte.
263
264 * callproc.c (getenv_internal_1, getenv_internal)
265 (Fgetenv_internal):
266 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
267
268 * lread.c (invalid_syntax): Omit length argument.
269 All uses changed. This doesn't fix a bug, but it simplifies the
270 code away from its former Hollerith-constant appearance, and it's
271 one less 'int' to worry about when looking at integer-overflow issues.
272 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
273
274 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
275 This didn't break anything, but it didn't help either.
276 It's confusing to put a bogus integer in a place where the actual
277 value does not matter.
278 (LIST_END_P): Remove unused macro and its bogus comment.
279 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
280
281 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
282 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
283 implementation.
284 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
285 We prefer signed types, and the value cannot exceed the EMACS_INT
286 range anyway (because otherwise the length would not be representable).
287 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
288 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
289 This avoids a GCC warning when WIDE_EMACS_INT.
290
291 * indent.c (sane_tab_width): New function.
292 (current_column, scan_for_column, Findent_to, position_indentation)
293 (compute_motion): Use it. This is just for clarity.
294 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
295
296 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
297
298 * lisp.h (lint_assume): New macro.
299 * composite.c (composition_gstring_put_cache):
300 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
301
302 * editfns.c, insdel.c:
303 Omit unnecessary forward decls, to simplify future changes.
304
305 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
306
307 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
308
309 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
310 Use much-faster test for byte-length change.
311 Don't assume string byte-length fits in 'int'.
312 Check that character arg fits in 'int'.
313 (mapcar1): Declare byte as byte, for clarity.
314
315 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
316
317 * fns.c (concat): Catch string overflow earlier.
318 Do not rely on integer wraparound.
319
320 * dispextern.h (struct it.overlay_strings_charpos)
321 (struct it.selective): Now EMACS_INT, not int.
322 * xdisp.c (forward_to_next_line_start)
323 (back_to_previous_visible_line_start)
324 (reseat_at_next_visible_line_start, next_element_from_buffer):
325 Don't arbitrarily truncate the value of 'selective' to int.
326
327 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
328
329 * composite.c: Don't truncate sizes to 'int'.
330 (composition_gstring_p, composition_reseat_it)
331 (composition_adjust_point): Use EMACS_INT, not int.
332 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
333 not EMACS_UINT, for indexes.
334
335 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
336
337 * buffer.c: Include <verify.h>.
338 (struct sortvec.priority, struct sortstr.priority):
339 Now EMACS_INT, not int.
340 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
341 (struct sortstr.size, record_overlay_string)
342 (struct sortstrlist.size, struct sortlist.used):
343 Don't truncate size to int.
344 (record_overlay_string): Check for size-calculation overflow.
345 (init_buffer_once): Check at compile-time, not run-time.
346
347 2011-06-22 Jim Meyering <meyering@redhat.com>
348
349 don't leak an XBM-image-sized buffer
350 * image.c (xbm_load): Free the image buffer after using it.
351
352 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
353
354 Port to Sun C.
355 * composite.c (find_automatic_composition): Omit needless 'return 0;'
356 that Sun C diagnosed.
357 * fns.c (secure_hash): Fix pointer signedness issue.
358 * intervals.c (static_offset_intervals): New function.
359 (offset_intervals): Use it.
360
361 2011-06-21 Leo Liu <sdl.web@gmail.com>
362
363 * deps.mk (fns.o):
364 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
365 sha512.h.
366
367 * fns.c (secure_hash): Rename from crypto_hash_function and change
368 the first arg to accept symbols.
369 (Fsecure_hash): New primtive.
370 (syms_of_fns): New symbols.
371
372 2011-06-20 Deniz Dogan <deniz@dogan.se>
373
374 * process.c (Fset_process_buffer): Clarify return value in
375 docstring.
376
377 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
378
379 * dispnew.c (add_window_display_history): Use BVAR.
380
381 * xdisp.c (debug_method_add): Use BVAR.
382 (check_window_end, dump_glyph_matrix, dump_glyph)
383 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
384
385 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
386 Likewise.
387
388 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
389 check till after the cache is created in init_frame_faces.
390
391 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
392
393 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
394
395 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
396
397 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
398 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
399 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
400
401 Improve buffer-overflow checking (Bug#8873).
402 * fileio.c (Finsert_file_contents):
403 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
404 Remove the old (too-loose) buffer overflow checks.
405 They weren't needed, since make_gap checks for buffer overflow.
406 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
407 The old code merely checked for Emacs fixnum overflow, and relied
408 on undefined (wraparound) behavior. The new code avoids undefined
409 behavior, and also checks for ptrdiff_t and/or size_t overflow.
410
411 * editfns.c (Finsert_char): Don't dump core with very negative counts.
412 Tune. Don't use wider integers than needed. Don't use alloca.
413 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
414
415 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
416
417 * insdel.c, lisp.h (buffer_overflow): New function.
418 (insert_from_buffer_1, replace_range, replace_range_2):
419 * insdel.c (make_gap_larger):
420 * editfns.c (Finsert_char):
421 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
422
423 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
424
425 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
426
427 Integer overflow and signedness fixes (Bug#8873).
428
429 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
430 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
431
432 * fileio.c: Don't assume EMACS_INT fits in off_t.
433 (emacs_lseek): New static function.
434 (Finsert_file_contents, Fwrite_region): Use it.
435 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
436
437 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
438
439 * fns.c: Don't overflow int when computing a list length.
440 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
441 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
442 truncation on 64-bit hosts. Check for QUIT every
443 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
444 faster and is responsive enough.
445 (Flength): Report an error instead of overflowing an integer.
446 (Fsafe_length): Return a float if the value is not representable
447 as a fixnum. This shouldn't happen except in contrived situations.
448 (Fnthcdr, Fsort): Don't assume list length fits in int.
449 (Fcopy_sequence): Don't assume vector length fits in int.
450
451 * alloc.c: Check that resized vectors' lengths fit in fixnums.
452 (header_size, word_size): New constants.
453 (allocate_vectorlike): Don't check size overflow here.
454 (allocate_vector): Check it here instead, since this is the only
455 caller of allocate_vectorlike that could cause overflow.
456 Check that the new vector's length is representable as a fixnum.
457
458 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
459 The previous code was bogus. For example, next_almost_prime (32)
460 returned 39, which is undesirable as it is a multiple of 3; and
461 next_almost_prime (24) returned 25, which is a multiple of 5 so
462 why was the code bothering to check for multiples of 7?
463
464 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
465
466 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
467
468 Variadic C functions now count arguments with ptrdiff_t.
469 This partly undoes my 2011-03-30 change, which replaced int with size_t.
470 Back then I didn't know that the Emacs coding style prefers signed int.
471 Also, in the meantime I found a few more instances where arguments
472 were being counted with int, which may truncate counts on 64-bit
473 machines, or EMACS_INT, which may be unnecessarily wide.
474 * lisp.h (struct Lisp_Subr.function.aMANY)
475 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
476 Arg counts are now ptrdiff_t, not size_t.
477 All variadic functions and their callers changed accordingly.
478 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
479 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
480 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
481 * callint.c (Fcall_interactively): Check arg count for overflow,
482 to avoid potential buffer overrun. Use signed char, not 'int',
483 for 'varies' array, so that we needn't bother to check its size
484 calculation for overflow.
485 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
486 * eval.c (apply_lambda):
487 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
488 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
489 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
490
491 * callint.c (Fcall_interactively): Don't use index var as event count.
492
493 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
494 * mem-limits.h (SIZE): Remove; no longer used.
495
496 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
497
498 Remove unnecessary casts.
499 * xterm.c (x_term_init):
500 * xfns.c (x_set_border_pixel):
501 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
502 These aren't needed now that we assume ANSI C.
503
504 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
505 It's more likely to cause problems (due to unsigned overflow)
506 than to cure them.
507
508 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
509
510 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
511
512 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
513
514 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
515
516 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
517
518 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
519
520 GLYPH_CODE_FACE returns EMACS_INT, not int.
521 * dispextern.h (merge_faces):
522 * xfaces.c (merge_faces):
523 * xdisp.c (get_next_display_element, next_element_from_display_vector):
524 Don't assume EMACS_INT fits in int.
525
526 * character.h (CHAR_VALID_P): Remove unused parameter.
527 * fontset.c, lisp.h, xdisp.c: All uses changed.
528
529 * editfns.c (Ftranslate_region_internal): Omit redundant test.
530
531 * fns.c (concat): Minor tuning based on overflow analysis.
532 This doesn't fix any bugs. Use int to hold character, instead
533 of constantly refetching from Emacs object. Use XFASTINT, not
534 XINT, for value known to be a character. Don't bother comparing
535 a single byte to 0400, as it's always less.
536
537 * floatfns.c (Fexpt):
538 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
539
540 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
541 for characters.
542
543 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
544
545 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
546 Without this fix, on a 64-bit host (aset S 0 4294967386) would
547 incorrectly succeed when S was a string, because 4294967386 was
548 truncated before it was used.
549
550 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
551 Otherwise, an out-of-range integer could cause undefined behavior
552 on a 64-bit host.
553
554 * composite.c: Use int, not EMACS_INT, for characters.
555 (fill_gstring_body, composition_compute_stop_pos): Use int, not
556 EMACS_INT, for values that are known to be in character range.
557 This doesn't fix any bugs but is the usual style inside Emacs and
558 may generate better code on 32-bit machines.
559
560 Make sure a 64-bit char is never passed to ENCODE_CHAR.
561 This is for reasons similar to the recent CHAR_STRING fix.
562 * charset.c (Fencode_char): Check that character arg is actually
563 a character. Pass an int to ENCODE_CHAR.
564 * charset.h (ENCODE_CHAR): Verify that the character argument is no
565 wider than 'int', as a compile-time check to prevent future regressions
566 in this area.
567
568 * character.c (char_string): Remove unnecessary casts.
569
570 Make sure a 64-bit char is never passed to CHAR_STRING.
571 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
572 by silently ignoring the top 32 bits, allowing some values
573 that were far too large to be valid characters.
574 * character.h: Include <verify.h>.
575 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
576 arguments are no wider than unsigned, as a compile-time check
577 to prevent future regressions in this area.
578 * data.c (Faset):
579 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
580 (Fsubst_char_in_region):
581 * fns.c (concat):
582 * xdisp.c (decode_mode_spec_coding):
583 Adjust to CHAR_STRING's new requirement.
584 * editfns.c (Finsert_char, Fsubst_char_in_region):
585 * fns.c (concat): Check that character args are actually
586 characters. Without this test, these functions did the wrong
587 thing with wildly out-of-range values on 64-bit hosts.
588
589 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
590 These casts should not be needed on 32-bit hosts, either.
591 * keyboard.c (read_char):
592 * lread.c (Fload): Remove casts to unsigned.
593
594 * lisp.h (UNSIGNED_CMP): New macro.
595 This fixes comparison bugs on 64-bit hosts.
596 (ASCII_CHAR_P): Use it.
597 * casefiddle.c (casify_object):
598 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
599 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
600 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
601 * dispextern.h (FACE_FROM_ID):
602 * keyboard.c (read_char): Use UNSIGNED_CMP.
603
604 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
605 not to EMACS_INT, to avoid GCC warning.
606
607 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
608
609 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
610 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
611 isn't needed on 32-bit machines.
612
613 * buffer.c (Fgenerate_new_buffer_name):
614 Use EMACS_INT for count, not int.
615 (advance_to_char_boundary): Return EMACS_INT, not int.
616
617 * data.c (Qcompiled_function): Now static.
618
619 * window.c (window_body_lines): Now static.
620
621 * image.c (gif_load): Rename local to avoid shadowing.
622
623 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
624 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
625 * alloc.c (make_save_value): Integer argument is now of type
626 ptrdiff_t, not int.
627 (mark_object): Use ptrdiff_t, not int.
628 * lisp.h (pD): New macro.
629 * print.c (print_object): Use it.
630
631 * alloc.c: Use EMACS_INT, not int, to count objects.
632 (total_conses, total_markers, total_symbols, total_vector_size)
633 (total_free_conses, total_free_markers, total_free_symbols)
634 (total_free_floats, total_floats, total_free_intervals)
635 (total_intervals, total_strings, total_free_strings):
636 Now EMACS_INT, not int. All uses changed.
637 (Fgarbage_collect): Compute overall total using a double, so that
638 integer overflow is less likely to be a problem. Check for overflow
639 when converting back to an integer.
640 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
641 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
642 These were 'int' variables that could overflow on 64-bit hosts;
643 they were never used, so remove them instead of repairing them.
644 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
645 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
646 Previously, this ceilinged at INT_MAX, but that doesn't work on
647 64-bit machines.
648 (allocate_pseudovector): Don't use EMACS_INT when int would do.
649
650 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
651 (allocate_vectorlike): Check for ptrdiff_t overflow.
652 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
653 when a (possibly-narrower) signed value would do just as well.
654 We prefer using signed arithmetic, to avoid comparison confusion.
655
656 * alloc.c: Catch some string size overflows that we were missing.
657 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
658 for convenience in STRING_BYTES_MAX.
659 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
660 The definition here is exact; the one in lisp.h was approximate.
661 (allocate_string_data): Check for string overflow. This catches
662 some instances we weren't catching before. Also, it catches
663 size_t overflow on (unusual) hosts where SIZE_MAX <= min
664 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
665 and ptrdiff_t and EMACS_INT are both 64 bits.
666
667 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
668 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
669 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
670
671 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
672
673 * alloc.c (Fmake_string): Check for out-of-range init.
674
675 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
676
677 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
678
679 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
680
681 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
682 xg_get_default_scrollbar_width.
683
684 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
685 (int_gtk_range_get_value): Move to the scroll bar part of the file.
686 (style_changed_cb): Call update_theme_scrollbar_width and call
687 x_set_scroll_bar_default_width and xg_frame_set_char_size for
688 all frames (Bug#8505).
689 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
690 Call gtk_window_set_resizable if HAVE_GTK3.
691 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
692 and height if HAVE_GTK3 (Bug#8505).
693 (scroll_bar_width_for_theme): New variable.
694 (update_theme_scrollbar_width): New function.
695 (xg_get_default_scrollbar_width): Move code to
696 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
697 (xg_initialize): Call update_theme_scrollbar_width.
698
699 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
700
701 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
702
703 2011-06-12 Martin Rudalics <rudalics@gmx.at>
704
705 * frame.c (make_frame): Call other_buffer_safely instead of
706 other_buffer.
707
708 * window.c (temp_output_buffer_show): Call display_buffer with
709 second argument Vtemp_buffer_show_specifiers and reset latter
710 immediately after the call.
711 (Vtemp_buffer_show_specifiers): New variable.
712 (auto_window_vscroll_p, next_screen_context_lines)
713 (Vscroll_preserve_screen_position): Remove leading asterisks from
714 doc-strings.
715
716 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
717
718 Fix minor problems found by GCC 4.6.0 static checking.
719 * buffer.c (Qclone_number): Remove for now, as it's unused.
720 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
721 (record_buffer): Remove unused local.
722 * frame.c (other_visible_frames, frame_buffer_list): Now static.
723 (set_frame_buffer_list): Remove; unused.
724 * frame.h (other_visible_frames): Remove decl.
725 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
726 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
727 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
728 if HAVE_GPM.
729 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
730 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
731 Define only if HAVE_GPM.
732 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
733 (update_hints_inhibit): Remove; never set. All uses removed.
734 * widgetprv.h (emacsFrameClassRec): Remove decl.
735 * window.c (delete_deletable_window): Now returns void, since it
736 wasn't returning anything.
737 (compare_window_configurations): Remove unused locals.
738 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
739 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
740 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
741 the same widths as pointers. This follows up on the 2011-05-06 patch.
742 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
743 * xterm.h: Likewise.
744 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
745
746 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
747
748 * makefile.w32-in: Update dependencies.
749 (LISP_H): Add lib/intprops.h.
750
751 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
752
753 * image.c (gif_load): Add animation frame delay to the metadata.
754 (syms_of_image): Use DEFSYM. New symbol `delay'.
755
756 2011-06-11 Martin Rudalics <rudalics@gmx.at>
757
758 * window.c (delete_deletable_window): Re-add.
759 (Fset_window_configuration): Rewrite to handle dead buffers and
760 consequently deletable windows.
761 (window_tree, Fwindow_tree): Remove. Supply functionality in
762 window.el.
763 (compare_window_configurations): Simplify code.
764
765 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
766
767 * image.c (imagemagick_load_image): Fix type mismatch.
768 (Fimagemagick_types): Likewise.
769
770 * window.h (replace_buffer_in_windows): Declare.
771
772 2011-06-11 Martin Rudalics <rudalics@gmx.at>
773
774 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
775 Qclone_number. Remove external declaration of Qdelete_window.
776 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
777 code.
778 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
779 Qbuffer_list_update_hook if allowed.
780 (Fother_buffer): Rewrite doc-string. Major rewrite for new
781 buffer list implementation.
782 (other_buffer_safely): New function.
783 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
784 calls to replace_buffer_in_windows and
785 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
786 if allowed.
787 (record_buffer): Inhibit quitting and rewrite using quittable
788 functions. Run Qbuffer_list_update_hook if allowed.
789 (Frecord_buffer, Funrecord_buffer): New functions.
790 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
791 switch-to-buffer to window.el.
792 (bury-buffer): Move to window.el.
793 (Vbuffer_list_update_hook): New variable.
794
795 * lisp.h (other_buffer_safely): Add prototype in buffer.c
796 section.
797
798 * window.h (resize_frame_windows): Move up in code.
799 (Fwindow_frame): Remove EXFUN.
800 (replace_buffer_in_all_windows): Remove prototype.
801 (replace_buffer_in_windows_safely): Add prototype.
802
803 * window.c: Declare Qdelete_window static again. Move down
804 declaration of select_count.
805 (Fnext_window, Fprevious_window): Rewrite doc-strings.
806 (Fother_window): Move to window.el.
807 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
808 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
809 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
810 window.el.
811 (replace_buffer_in_windows): Implement by calling
812 Qreplace_buffer_in_windows.
813 (replace_buffer_in_all_windows): Remove with some functionality
814 moved into replace_buffer_in_windows_safely.
815 (replace_buffer_in_windows_safely): New function.
816 (select_window_norecord, select_frame_norecord): Move in front
817 of run_window_configuration_change_hook. Remove now obsolete
818 declarations.
819 (Fset_window_buffer): Rewrite doc-string. Call
820 Qrecord_window_buffer.
821 (keys_of_window): Move binding for other-window to window.el.
822
823 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
824
825 * dispextern.h (struct image): Replace data member, whose int_val
826 and ptr_val fields were not used by anything, with a single
827 lisp_val object.
828
829 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
830 (gif_clear_image, gif_load, imagemagick_load_image)
831 (gs_clear_image, gs_load): Callers changed.
832
833 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
834
835 * buffer.h: Include <time.h>, for time_t.
836 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
837
838 Fix minor problems found by static checking.
839
840 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
841
842 Make identifiers static if they are not used in other modules.
843 * data.c (Qcompiled_function, Qframe, Qvector):
844 * image.c (QimageMagick, Qsvg):
845 * minibuf.c (Qmetadata):
846 * window.c (resize_window_check, resize_root_window): Now static.
847 * window.h (resize_window_check, resize_root_window): Remove decls.
848
849 * window.c (window_deletion_count, delete_deletable_window):
850 Remove; unused.
851 (window_body_lines): Now static.
852 (Fdelete_other_windows_internal): Mark vars as initialized.
853 Make sure 'resize_failed' is initialized.
854 (run_window_configuration_change_hook): Rename local to avoid shadowing.
855 (resize_window_apply): Remove unused local.
856 * window.h (delete_deletable_window): Remove decl.
857
858 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
859 (imagemagick_load_image): Fix pointer signedness problem by changing
860 last arg from unsigned char * to char *. All uses changed.
861 Also, fix a local for similar reasons.
862 Remove unused locals. Remove locals to avoid shadowing.
863 (fn_rsvg_handle_free): Remove; unused.
864 (svg_load, svg_load_image): Fix pointer signedness problem.
865 (imagemagick_load_image): Don't use garbage pointer image_wand.
866
867 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
868
869 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
870
871 * image.c (gif_load): Fix omitted cast error introduced by
872 2011-06-06 change.
873
874 2011-06-10 Martin Rudalics <rudalics@gmx.at>
875
876 * window.h (resize_proportionally, orig_total_lines)
877 (orig_top_line): Remove from window structure.
878 (set_window_height, set_window_width, change_window_heights)
879 (Fdelete_window): Remove prototypes.
880 (resize_frame_windows): Remove duplicate declaration.
881
882 2011-06-10 Eli Zaretskii <eliz@gnu.org>
883
884 * window.h (resize_frame_windows, resize_window_check)
885 (delete_deletable_window, resize_root_window)
886 (resize_frame_windows): Declare prototypes.
887
888 * window.c (resize_window_apply): Make definition be "static" to
889 match the prototype.
890
891 2011-06-10 Martin Rudalics <rudalics@gmx.at>
892
893 * window.c: Remove declarations of Qwindow_size_fixed,
894 window_min_size_1, window_min_size_2, window_min_size,
895 size_window, window_fixed_size_p, enlarge_window, delete_window.
896 Remove static from declaration of Qdelete_window, it's
897 temporarily needed by Fbury_buffer.
898 (replace_window): Don't assign orig_top_line and
899 orig_total_lines.
900 (Fdelete_window, delete_window): Remove. Window deletion is
901 handled by window.el.
902 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
903 Fdelete_window calls with calls to Qdelete_window.
904 (Fdelete_other_windows): Remove. Deleting other windows is
905 handled by window.el.
906 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
907 handled in window.el.
908 (window_min_size_2, window_min_size_1, window_min_size): Remove.
909 Window minimum sizes are handled in window.el.
910 (shrink_windows, size_window, set_window_height)
911 (set_window_width, change_window_heights, window_height)
912 (window_width, CURBEG, CURSIZE, enlarge_window)
913 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
914 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
915 handled in window.el.
916 (make_dummy_parent): Rename to make_parent_window and give it a
917 second argument horflag.
918 (make_window): Don't set resize_proportionally any more.
919 (Fsplit_window): Remove. Windows are split in window.el.
920 (save_restore_action, save_restore_orig_size)
921 (shrink_window_lowest_first, save_restore_orig_size): Remove.
922 Resize mini windows in window.el.
923 (grow_mini_window, shrink_mini_window): Implement by calling
924 Qresize_root_window_vertically, resize_window_check and
925 resize_window_apply.
926 (saved_window, Fset_window_configuration, save_window_save): Do
927 not handle orig_top_line, orig_total_lines, and
928 resize_proportionally.
929 (window_min_height, window_min_width): Move to window.el.
930 (keys_of_window): Move bindings for delete-other-windows,
931 split-window, delete-window and enlarge-window to window.el.
932
933 * buffer.c: Temporarily extern Qdelete_window.
934 (Fbury_buffer): Temporarily call Qdelete_window instead of
935 Fdelete_window (Fbury_buffer will move to window.el soon).
936
937 * frame.c (set_menu_bar_lines_1): Remove code handling
938 orig_top_line and orig_total_lines.
939
940 * dispnew.c (adjust_frame_glyphs_initially): Don't use
941 set_window_height but set heights directly.
942 (change_frame_size_1): Use resize_frame_windows.
943
944 * xdisp.c (init_xdisp): Don't use set_window_height but set
945 heights directly.
946
947 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
948 resize_frame_windows instead of change_window_heights and run
949 run_window_configuration_change_hook.
950
951 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
952 instead of change_window_heights and run
953 run_window_configuration_change_hook.
954
955 2011-06-09 Martin Rudalics <rudalics@gmx.at>
956
957 * window.c (replace_window): Rename second argument REPLACEMENT to
958 NEW. New third argument SETFLAG. Rewrite.
959 (delete_window, make_dummy_parent): Call replace_window with
960 third argument 1.
961 (window_list_1): Move down in code.
962 (run_window_configuration_change_hook): Move set_buffer part
963 before select_frame_norecord part in order to unwind correctly.
964 Rename count1 to count.
965 (recombine_windows, delete_deletable_window, resize_root_window)
966 (Fdelete_other_windows_internal)
967 (Frun_window_configuration_change_hook, make_parent_window)
968 (resize_window_check, resize_window_apply, Fresize_window_apply)
969 (resize_frame_windows, Fsplit_window_internal)
970 (Fdelete_window_internal, Fresize_mini_window_internal): New
971 functions.
972 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
973
974 2011-06-08 Martin Rudalics <rudalics@gmx.at>
975
976 * window.h (window): Add some new members to window structure -
977 normal_lines, normal_cols, new_total, new_normal, clone_number,
978 splits, nest, prev_buffers, next_buffers.
979 (WINDOW_TOTAL_SIZE): Move here from window.c.
980 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
981
982 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
983 Remove.
984 (make_dummy_parent): Set new members of windows structure.
985 (make_window): Move down in code. Handle new members of window
986 structure.
987 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
988 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
989 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
990 (Fset_window_prev_buffers, Fwindow_next_buffers)
991 (Fset_window_next_buffers, Fset_window_clone_number): New
992 functions.
993 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
994 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
995 Doc-string fixes.
996 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
997 Argument WINDOW can be now internal window too.
998 (Fwindow_use_time): Move up in code.
999 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1000 Rewrite doc-string.
1001 (Fset_window_configuration, saved_window)
1002 (Fcurrent_window_configuration, save_window_save): Handle new
1003 members of window structure.
1004 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1005 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1006 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1007 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1008 Qget_mru_window, Qresize_root_window,
1009 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1010 Qauto_buffer_name; staticpro them.
1011
1012 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1013
1014 * window.c (Fwindow_total_size, Fwindow_left_column)
1015 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1016 (Fwindow_list_1): New functions.
1017 (window_box_text_cols): Replace with window_body_cols.
1018 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1019 window_body_cols instead of window_box_text_cols.
1020 (delete_window, Fset_window_configuration): Call
1021 delete_all_subwindows with window as argument.
1022 (delete_all_subwindows): Take a window as argument and not a
1023 structure. Rewrite.
1024 (window_loop): Remove handling of GET_LRU_WINDOW and
1025 GET_LARGEST_WINDOW.
1026 (Fget_lru_window, Fget_largest_window): Move to window.el.
1027
1028 * window.h: Extern window_body_cols instead of
1029 window_box_text_cols. delete_all_subwindows now takes a
1030 Lisp_Object as argument.
1031
1032 * indent.c (compute_motion, Fcompute_motion): Use
1033 window_body_cols instead of window_box_text_cols.
1034
1035 * frame.c (delete_frame): Call delete_all_subwindows with root
1036 window as argument.
1037
1038 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1039
1040 * fns.c (Fputhash): Document return value.
1041
1042 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1043
1044 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1045
1046 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1047
1048 Cons<->int and similar integer overflow fixes (Bug#8794).
1049
1050 Check for overflow when converting integer to cons and back.
1051 * charset.c (Fdefine_charset_internal, Fdecode_char):
1052 Use cons_to_unsigned to catch overflow.
1053 (Fencode_char): Use INTEGER_TO_CONS.
1054 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1055 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1056 * data.c (long_to_cons, cons_to_long): Remove.
1057 (cons_to_unsigned, cons_to_signed): New functions.
1058 These signal an error for invalid or out-of-range values.
1059 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1060 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1061 * font.c (Ffont_variation_glyphs):
1062 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1063 * lisp.h: Include <intprops.h>.
1064 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1065 (cons_to_signed, cons_to_unsigned): New decls.
1066 (long_to_cons, cons_to_long): Remove decls.
1067 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1068 (Fprimitive_undo): Use CONS_TO_INTEGER.
1069 * xfns.c (Fx_window_property): Likewise.
1070 * xselect.c: Include <limits.h>.
1071 (x_own_selection, selection_data_to_lisp_data):
1072 Use INTEGER_TO_CONS.
1073 (x_handle_selection_request, x_handle_selection_clear)
1074 (x_get_foreign_selection, Fx_disown_selection_internal)
1075 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1076 (lisp_data_to_selection_data): Use cons_to_unsigned.
1077 (x_fill_property_data): Use cons_to_signed.
1078 Report values out of range.
1079
1080 Check for buffer and string overflow more precisely.
1081 * buffer.h (BUF_BYTES_MAX): New macro.
1082 * lisp.h (STRING_BYTES_MAX): New macro.
1083 * alloc.c (Fmake_string):
1084 * character.c (string_escape_byte8):
1085 * coding.c (coding_alloc_by_realloc):
1086 * doprnt.c (doprnt):
1087 * editfns.c (Fformat):
1088 * eval.c (verror):
1089 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1090 since they may not be the same number.
1091 * editfns.c (Finsert_char):
1092 * fileio.c (Finsert_file_contents):
1093 Likewise for BUF_BYTES_MAX.
1094
1095 * image.c: Use ptrdiff_t, not int, for sizes.
1096 (slurp_file): Switch from int to ptrdiff_t.
1097 All uses changed.
1098 (slurp_file): Check that file size fits in both size_t (for
1099 malloc) and ptrdiff_t (for sanity and safety).
1100
1101 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1102 if b->modtime has its maximal value.
1103
1104 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1105
1106 Don't assume time_t can fit into int.
1107 * buffer.h (struct buffer.modtime): Now time_t, not int.
1108 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1109 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1110
1111 Minor fixes for signed vs unsigned integers.
1112 * character.h (MAYBE_UNIFY_CHAR):
1113 * charset.c (maybe_unify_char):
1114 * keyboard.c (read_char, reorder_modifiers):
1115 XINT -> XFASTINT, since the integer must be nonnegative.
1116 * ftfont.c (ftfont_spec_pattern):
1117 * keymap.c (access_keymap, silly_event_symbol_error):
1118 XUINT -> XFASTINT, since the integer must be nonnegative.
1119 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1120 since it makes no difference and we prefer signed.
1121 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1122 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1123 nonnegative.
1124
1125 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1126
1127 * window.h (Fwindow_frame): Declare.
1128
1129 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1130
1131 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1132 (SPARE_MEMORY): Always define.
1133 (LARGE_REQUEST): Remove.
1134 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1135
1136 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1137
1138 * lisp.h: Move EXFUNS for Fframe_root_window,
1139 Fframe_first_window and Fset_frame_selected_window to window.h.
1140
1141 * window.h: Move EXFUNS for Fframe_root_window,
1142 Fframe_first_window and Fset_frame_selected_window here from
1143 lisp.h.
1144
1145 * frame.c (Fwindow_frame, Fframe_first_window)
1146 (Fframe_root_window, Fframe_selected_window)
1147 (Fset_frame_selected_window): Move to window.c.
1148 (Factive_minibuffer_window): Move to minibuf.c.
1149 (Fother_visible_frames_p): New function.
1150
1151 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1152
1153 * window.c (decode_window, decode_any_window): Move up in code.
1154 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1155 (inhibit_frame_unsplittable): Remove unused variable.
1156 (Fwindow_buffer): Move up and rewrite doc-string.
1157 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1158 (Fwindow_prev): New functions.
1159 (Fwindow_frame): Move here from frame.c. Accept any window as
1160 argument.
1161 (Fframe_root_window, Fframe_first_window)
1162 (Fframe_selected_window): Move here from frame.c. Accept frame
1163 or arbitrary window as argument. Update doc-strings.
1164 (Fminibuffer_window): Move up in code.
1165 (Fwindow_minibuffer_p): Move up in code and simplify.
1166 (Fset_frame_selected_window): Move here from frame.c.
1167 Marginal rewrite.
1168 (Fselected_window, select_window, Fselect_window): Move up in
1169 code. Minor doc-string fixes.
1170
1171 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1172
1173 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1174 Do not assume that spare memory exists; that assumption is valid
1175 only if SYSTEM_MALLOC.
1176 (LARGE_REQUEST): New macro, so that the issue of large requests
1177 is separated from the issue of spare memory.
1178
1179 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1180
1181 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1182 format. (Bug#8806)
1183
1184 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1185
1186 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1187 before statements.
1188
1189 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1190
1191 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1192
1193 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1194
1195 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1196 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1197
1198 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1199
1200 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1201
1202 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1203
1204 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1205 (x_clipboard_manager_save): Add return value.
1206 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1207 New error handlers.
1208 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1209 Obey Vx_select_enable_clipboard_manager. Catch errors in
1210 x_clipboard_manager_save (Bug#8779).
1211 (Vx_select_enable_clipboard_manager): New variable.
1212 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1213
1214 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1215
1216 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1217
1218 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1219
1220 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1221 in the current matrix if keep_current_p is non-zero.
1222
1223 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1224
1225 * bidi.c (bidi_level_of_next_char): Fix last change.
1226
1227 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1228
1229 Support bidi reordering of text covered by display properties.
1230
1231 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1232 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1233 (bidi_cache_search, bidi_cache_iterator_state)
1234 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1235 (bidi_level_of_next_char, bidi_move_to_visually_next):
1236 Support character positions inside a run of characters covered by a
1237 display string.
1238 (bidi_paragraph_init, bidi_resolve_explicit_1)
1239 (bidi_level_of_next_char): Call bidi_fetch_char and
1240 bidi_fetch_char_advance instead of FETCH_CHAR and
1241 FETCH_CHAR_ADVANCE.
1242 (bidi_init_it): Initialize new members.
1243 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1244 definitions.
1245 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1246 instead of using explicit *_CHAR codes.
1247 (bidi_resolve_explicit, bidi_resolve_weak):
1248 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1249 bidirectional text is supported only in multibyte buffers.
1250 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1251 it to initialize the frame_window_p member of struct bidi_it.
1252 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1253 (bidi_resolve_explicit, bidi_resolve_weak)
1254 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1255 bidi_it->nchars is non-positive.
1256 (bidi_level_of_next_char): Don't try to lookup the cache for the
1257 next/previous character if nothing is cached there yet, or if we
1258 were just reseat()'ed to a new position.
1259
1260 * xdisp.c (set_cursor_from_row): Set start and stop points
1261 according to the row's direction when priming the loop that looks
1262 for the glyph on which to display cursor.
1263 (single_display_spec_intangible_p): Function deleted.
1264 (display_prop_intangible_p): Reimplement to call
1265 handle_display_spec instead of single_display_spec_intangible_p.
1266 Accept 3 additional arguments needed by handle_display_spec.
1267 This fixes incorrect cursor motion across display property with complex
1268 values: lists, `(when COND...)' forms, etc.
1269 (single_display_spec_string_p): Support property values that are
1270 lists with the argument STRING its top-level element.
1271 (display_prop_string_p): Fix the condition for processing a
1272 property that is a list to be consistent with handle_display_spec.
1273 (handle_display_spec): New function, refactored from the
1274 last portion of handle_display_prop.
1275 (compute_display_string_pos): Accept additional argument
1276 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1277 value of a `display' property is a "replacing spec".
1278 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1279 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1280 the display property, but just return a value indicating whether
1281 the display property will replace the characters it covers.
1282 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1283 frame_window_p members of struct bidi_it.
1284 (compute_display_string_pos, compute_display_string_end):
1285 New functions.
1286 (push_it): Accept second argument POSITION, where pop_it should
1287 jump to continue iteration.
1288 (reseat_1): Initialize bidi_it.disp_pos.
1289
1290 * keyboard.c (adjust_point_for_property): Adjust the call to
1291 display_prop_intangible_p to its new signature.
1292
1293 * dispextern.h (struct bidi_it): New member frame_window_p.
1294 (bidi_init_it): Update prototypes.
1295 (display_prop_intangible_p): Update prototype.
1296 (compute_display_string_pos, compute_display_string_end):
1297 Declare prototypes.
1298 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1299 EMACS_INT.
1300
1301 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1302
1303 Malloc failure behavior now depends on size of allocation.
1304 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1305 * lisp.h: Change signatures accordingly.
1306 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1307 All callers changed. (Bug#8762)
1308
1309 * gnutls.c: Use Emacs's memory allocators.
1310 Without this change, the gnutls library would invoke malloc etc.
1311 directly, which causes problems on non-SYNC_INPUT hosts, and which
1312 runs afoul of improving memory_full behavior. (Bug#8761)
1313 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1314 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1315 xfree instead of the default malloc, realloc, free.
1316 (Fgnutls_boot): No need to check for memory allocation failure,
1317 since xmalloc does that for us.
1318
1319 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1320 * category.c (hash_get_category_set):
1321 * ccl.c (ccl_driver):
1322 * charset.c (Fdefine_charset_internal):
1323 * charset.h (struct charset.hash_index):
1324 * composite.c (get_composition_id, gstring_lookup_cache)
1325 (composition_gstring_put_cache):
1326 * composite.h (struct composition.hash_index):
1327 * dispextern.h (struct image.hash):
1328 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1329 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1330 (hashfn_equal, hashfn_user_defined, make_hash_table)
1331 (maybe_resize_hash_table, hash_lookup, hash_put)
1332 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1333 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1334 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1335 * image.c (make_image, search_image_cache, lookup_image)
1336 (xpm_put_color_table_h):
1337 * lisp.h (struct Lisp_Hash_Table):
1338 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1339 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1340 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1341 * alloc.c (allocate_vectorlike):
1342 Check for overflow in vector size calculations.
1343 * ccl.c (ccl_driver):
1344 Check for overflow when converting EMACS_INT to int.
1345 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1346 need to be updated by these changes.
1347 * fns.c (make_hash_table, maybe_resize_hash_table):
1348 Check for integer overflow with large hash tables.
1349 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1350 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1351 (SXHASH_REDUCE): New macro.
1352 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1353 Use it instead of discarding useful hash info with large hash values.
1354 (sxhash_float): New function.
1355 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1356 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1357 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1358 Rewrite to use FIXNUM_BITS, as this simplifies things.
1359 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1360 Adjust signatures to match updated version of code.
1361 (consing_since_gc): Now EMACS_INT, since a single hash table can
1362 use more than INT_MAX bytes.
1363
1364 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1365
1366 Make it possible to build with GCC-4.6+ -O2 -flto.
1367
1368 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1369
1370 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1371
1372 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1373 Call minibuffer-inactive-mode.
1374
1375 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1376
1377 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1378 Update dependencies.
1379
1380 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1381
1382 * data.c (init_data): Remove code for UTS, this system is not
1383 supported anymore.
1384
1385 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1386
1387 Don't force ./temacs to start in terminal mode.
1388
1389 * frame.c (make_initial_frame): Initialize faces in all cases, not
1390 only when CANNOT_DUMP is defined.
1391 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1392
1393 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1394
1395 * dispnew.c (add_window_display_history): Use const for the string
1396 pointer. Remove declaration, not needed.
1397
1398 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1399
1400 Use 'inline', not 'INLINE'.
1401 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1402 * alloc.c, fontset.c (INLINE): Remove.
1403 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1404 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1405 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1406 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1407 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1408
1409 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1410
1411 Make it possible to run ./temacs.
1412
1413 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1414 syms_of_callproc does the same thing. Remove test for
1415 "initialized", do it in the caller.
1416 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1417
1418 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1419
1420 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1421 (read_minibuf): Use get_minibuffer.
1422 (syms_of_minibuf): Use DEFSYM.
1423 (Qmetadata): New var.
1424 * data.c (Qbuffer): Don't make it static.
1425 (syms_of_data): Use DEFSYM.
1426
1427 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1428
1429 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1430 (CCL_CODE_MIN): New macro.
1431
1432 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1433
1434 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1435
1436 * eval.c (Qdebug): Now static.
1437 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1438 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1439 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1440
1441 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1442
1443 * image.c: Various fixes to ImageMagick code comments.
1444 (Fimagemagick_types): Doc fix.
1445
1446 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1447
1448 Minor fixes prompted by GCC 4.6.0 warnings.
1449
1450 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1451
1452 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1453 (x_clipboard_manager_save_all): Move extern decl to ...
1454 * xterm.h: ... here, so that it can be checked for consistency.
1455
1456 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1457
1458 * xselect.c (x_clipboard_manager_save_frame)
1459 (x_clipboard_manager_save_all): New functions.
1460 (Fx_clipboard_manager_save): Lisp function deleted.
1461
1462 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1463 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1464
1465 * xterm.h: Update prototype.
1466
1467 2011-05-28 William Xu <william.xwl@gmail.com>
1468
1469 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1470 exiting (Bug#8239).
1471
1472 2011-05-28 Jim Meyering <meyering@redhat.com>
1473
1474 Avoid a sign-extension bug in crypto_hash_function.
1475 * fns.c (to_uchar): Define.
1476 (crypto_hash_function): Use it to convert some newly-signed
1477 variables to unsigned, to avoid sign-extension bugs. For example,
1478 without this change, (md5 "truc") would evaluate to
1479 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1480 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1481 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1482
1483 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1484
1485 Integer overflow fixes.
1486
1487 * dbusbind.c: Serial number integer overflow fixes.
1488 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1489 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1490 to hold a serial number that is too large for a fixnum.
1491 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1492 Check for serial numbers out of range. Decode any serial number
1493 that was so large that it became a float. (Bug#8722)
1494
1495 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1496 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1497 Use XFASTINT rather than XUINT when numbers are nonnegative.
1498 (xd_append_arg, Fdbus_method_return_internal):
1499 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1500 arguments, check that Lisp number is nonnegative, rather than
1501 silently wrapping negative numbers around. (Bug#8722)
1502 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1503 (Bug#8722)
1504
1505 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1506
1507 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1508
1509 ccl: add integer overflow checks
1510 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1511 (IN_INT_RANGE): New macros.
1512 (ccl_driver): Use them to check for integer overflow when
1513 decoding a CCL program. Many of the new checks are whether XINT (x)
1514 fits in int; it doesn't always, on 64-bit hosts. The new version
1515 doesn't catch all possible integer overflows, but it's an
1516 improvement. (Bug#8719)
1517
1518 * alloc.c (make_event_array): Use XINT, not XUINT.
1519 There's no need for unsigned here.
1520
1521 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1522 This follows up to the 2011-05-06 change that substituted uintptr_t
1523 for EMACS_INT. This case wasn't caught back then.
1524
1525 Rework Fformat to avoid integer overflow issues.
1526 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1527 now (part of C89). Include <verify.h>.
1528 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1529 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1530 (Fformat): Avoid the prepass trying to compute sizes; it was only
1531 approximate and thus did not catch overflow reliably. Instead, walk
1532 through the format just once, formatting and computing sizes as we go,
1533 checking for integer overflow at every step, and allocating a larger
1534 buffer as needed. Keep track separately whether the format is
1535 multibyte. Keep only the most-recently calculated precision, rather
1536 than them all. Record whether each argument has been converted to
1537 string. Use EMACS_INT, not int, for byte and char and arg counts.
1538 Support field widths and precisions larger than INT_MAX. Avoid
1539 sprintf's undefined behavior with conversion specifications such as %#d
1540 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1541 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1542 formatting out-of-range floating point numbers with int
1543 formats. (Bug#8668)
1544
1545 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1546
1547 * data.c: Avoid integer truncation in expressions involving floats.
1548 * data.c: Include <intprops.h>.
1549 (arith_driver): When there's an integer overflow in an expression
1550 involving floating point, convert the integers to floating point
1551 so that the resulting value does not suffer from catastrophic
1552 integer truncation. For example, on a 64-bit host (* 4
1553 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1554 Do not rely on undefined behavior after integer overflow.
1555
1556 merge count_size_as_multibyte, parse_str_to_multibyte
1557 * character.c, character.h (count_size_as_multibyte):
1558 Rename from parse_str_to_multibyte; all uses changed.
1559 Check for integer overflow.
1560 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1561 since it's now a duplicate of the other. This is more of
1562 a character than a buffer op, so better that it's in character.c.
1563 * fns.c, print.c: Adjust to above changes.
1564
1565 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1566
1567 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1568
1569 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1570
1571 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1572 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1573 (x_clipboard_manager_save): Now static.
1574 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1575
1576 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1577 (crypto_hash_function): Now static.
1578 Fix pointer signedness problems. Avoid unnecessary initializations.
1579
1580 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1581
1582 * termhooks.h (Vselection_alist): Make it terminal-local.
1583
1584 * terminal.c (create_terminal): Initialize it.
1585
1586 * xselect.c: Support for clipboard managers.
1587 (Vselection_alist): Move to termhooks.h as terminal-local var.
1588 (LOCAL_SELECTION): New macro.
1589 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1590 (symbol_to_x_atom): Remove gratuitous arg.
1591 (x_handle_selection_request, lisp_data_to_selection_data)
1592 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1593 (x_own_selection, x_get_local_selection, x_convert_selection):
1594 New arg, specifying work frame. Use terminal-local Vselection_alist.
1595 (some_frame_on_display): Delete unused function.
1596 (Fx_own_selection_internal, Fx_get_selection_internal)
1597 (Fx_disown_selection_internal, Fx_selection_owner_p)
1598 (Fx_selection_exists_p): New optional frame arg.
1599 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1600 (x_handle_selection_clear): Don't treat other terminals with the
1601 same keyboard specially. Use the terminal-local Vselection_alist.
1602 (x_clear_frame_selections): Use Frun_hook_with_args.
1603
1604 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1605
1606 * xterm.h: Add support for those atoms.
1607
1608 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1609
1610 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1611 (converted_selections, conversion_fail_tag): New global variables.
1612 (x_selection_request_lisp_error): Free the above.
1613 (x_get_local_selection): Remove unnecessary code.
1614 (x_reply_selection_request): Args changed; handle arbitrary array
1615 of converted selections stored in converted_selections.
1616 Separate the XChangeProperty and SelectionNotify steps.
1617 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1618 (x_convert_selection): New function.
1619 (x_handle_selection_event): Simplify.
1620 (x_get_foreign_selection): Don't ignore incoming requests while
1621 waiting for an answer; this will fail when we implement
1622 SAVE_TARGETS, and seems unnecessary anyway.
1623 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1624 (Vx_sent_selection_functions): Doc fix.
1625
1626 2011-05-26 Leo Liu <sdl.web@gmail.com>
1627
1628 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1629
1630 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1631
1632 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1633
1634 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1635 for fringe update if it has periodic bitmap.
1636 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1637 and fringe_bitmap_periodic_p.
1638
1639 * fringe.c (get_fringe_bitmap_data): New function.
1640 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1641 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1642 row. Mark glyph row for fringe update if periodicity changed.
1643
1644 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1645 for fringe update unless it has periodic bitmap.
1646
1647 2011-05-25 Kenichi Handa <handa@m17n.org>
1648
1649 * xdisp.c (get_next_display_element): Set correct it->face_id for
1650 a static composition.
1651
1652 2011-05-24 Leo Liu <sdl.web@gmail.com>
1653
1654 * deps.mk (fns.o):
1655 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1656
1657 * fns.c (crypto_hash_function, Fsha1): New function.
1658 (Fmd5): Use crypto_hash_function.
1659 (syms_of_fns): Add Ssha1.
1660
1661 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1662
1663 * gnutls.c: Remove unused macros.
1664 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1665 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1666 Remove macros that are defined and never used.
1667 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1668
1669 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1670
1671 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1672 (Fx_get_selection_internal): Minor cleanup.
1673 (Fx_own_selection_internal): Rename arguments for consistency with
1674 select.el.
1675
1676 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1677
1678 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1679
1680 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1681
1682 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1683
1684 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1685
1686 * dispnew.c (scrolling_window): Don't exclude the case that the
1687 last enabled row in the desired matrix touches the bottom boundary.
1688
1689 2011-05-21 Glenn Morris <rgm@gnu.org>
1690
1691 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1692 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1693 and add some more files.
1694
1695 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1696
1697 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1698 report_file_error introduced by the change from 2011-05-07.
1699
1700 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1701
1702 * systime.h (Time): Define only if emacs is defined.
1703 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1704 where the include path doesn't have X11/X.h by default. See
1705 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1706
1707 2011-05-20 Kenichi Handa <handa@m17n.org>
1708
1709 * composite.c (find_automatic_composition): Fix previous change.
1710
1711 2011-05-20 Glenn Morris <rgm@gnu.org>
1712
1713 * lisp.mk: New file, split from Makefile.in.
1714 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1715 (shortlisp): Remove.
1716 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1717
1718 2011-05-19 Glenn Morris <rgm@gnu.org>
1719
1720 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1721 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1722 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1723 (lisp): Set the order to that of loadup.el.
1724 (shortlisp): Make it a copy of $lisp.
1725 (SOME_MACHINE_LISP): Remove.
1726 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1727 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1728
1729 2011-05-18 Kenichi Handa <handa@m17n.org>
1730
1731 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1732 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1733 (find_automatic_composition): Mostly rewrite for efficiency.
1734
1735 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1736
1737 * makefile.w32-in: Update dependencies.
1738
1739 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1740
1741 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1742 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1743
1744 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1745
1746 Fix some integer overflow issues, such as string length overflow.
1747
1748 * insdel.c (count_size_as_multibyte): Check for string overflow.
1749
1750 * character.c (lisp_string_width): Check for string overflow.
1751 Use EMACS_INT, not int, for string indexes and lengths; in
1752 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1753 the resulting string length overflows an EMACS_INT; instead,
1754 report a string overflow if no precision given. When checking for
1755 precision exhaustion, use a check that cannot possibly have
1756 integer overflow. (Bug#8675)
1757 * character.h (lisp_string_width): Adjust to new signature.
1758
1759 * alloc.c (string_overflow): New function.
1760 (Fmake_string): Use it. This doesn't change behavior, but saves
1761 a few bytes and will simplify future changes.
1762 * character.c (string_escape_byte8): Likewise.
1763 * lisp.h (string_overflow): New decl.
1764
1765 Fixups, following up to the user-interface timestamp change.
1766 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1767 for UI timestamps, instead of unsigned long.
1768 * msdos.c (mouse_get_pos): Likewise.
1769 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1770 * w32gui.h (Time): Define by including "systime.h" rather than by
1771 declaring it ourselves. (Bug#8664)
1772
1773 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1774 * image.c (clear_image_cache): Likewise.
1775
1776 * term.c (term_mouse_position): Don't assume time_t wraparound.
1777
1778 Be more systematic about user-interface timestamps.
1779 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1780 and sometimes 'EMACS_UINT', to represent these timestamps.
1781 This change causes it to use 'Time' uniformly, as that's what X uses.
1782 This makes the code easier to follow, and makes it easier to catch
1783 integer overflow bugs such as Bug#8664.
1784 * frame.c (Fmouse_position, Fmouse_pixel_position):
1785 Use Time, not unsigned long, for user-interface timestamps.
1786 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1787 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1788 * keyboard.h (last_event_timestamp): Likewise.
1789 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1790 * menu.h (xmenu_show): Likewise.
1791 * term.c (term_mouse_position): Likewise.
1792 * termhooks.h (struct input_event.timestamp): Likewise.
1793 (struct terminal.mouse_position_hook): Likewise.
1794 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1795 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1796 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1797 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1798 what it was before.
1799 * menu.h, termhooks.h: Include "systime.h", for Time.
1800
1801 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1802 Don't assume that the difference between two unsigned long values
1803 can fit into an integer. At this point, we know button_down_time
1804 <= event->timestamp, so the difference must be nonnegative, so
1805 there's no need to cast the result if double-click-time is
1806 nonnegative, as it should be; check that it's nonnegative, just in
1807 case. This bug is triggered when events are more than 2**31 ms
1808 apart (about 25 days). (Bug#8664)
1809
1810 * xselect.c (last_event_timestamp): Remove duplicate decl.
1811 (x_own_selection): Remove needless cast to unsigned long.
1812
1813 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1814 that always fit in int. Use a sentinel instead of a counter, to
1815 avoid a temp and to allay GCC's concerns about possible int overflow.
1816 * frame.h (struct frame): Use int for menu_bar_items_used
1817 instead of EMACS_INT, since it always fits in int.
1818
1819 * menu.c (grow_menu_items): Check for int overflow.
1820
1821 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1822
1823 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1824 Before, the code was not consistent. These values cannot exceed
1825 2**31 - 1 so there's no need to make them unsigned.
1826 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1827 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1828 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1829 as modifiers.
1830 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1831
1832 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1833 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1834 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1835 presumably because the widths might not match.
1836
1837 * window.c (size_window): Avoid needless test at loop start.
1838
1839 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1840
1841 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1842
1843 2011-05-12 Drew Adams <drew.adams@oracle.com>
1844
1845 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1846
1847 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1848
1849 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1850 `width' to `bar_area_x' and `bar_area_width', respectively.
1851 (x_scroll_run): Take account of fringe background extension.
1852
1853 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1854 Rename local vars `left' and `width' to `bar_area_x' and
1855 `bar_area_width', respectively.
1856 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1857 background extension.
1858
1859 2011-05-10 Jim Meyering <meyering@redhat.com>
1860
1861 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1862
1863 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1864
1865 * image.c (Finit_image_library): Return t for built-in image types,
1866 like pbm and xbm. (Bug#8640)
1867
1868 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1869
1870 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1871
1872 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1873
1874 * w32console.c (Fset_screen_color): Doc fix.
1875 (Fget_screen_color): New function.
1876 (syms_of_ntterm): Defsubr it.
1877
1878 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1879 unlink the temporary file if Fcall_process didn't create it in the
1880 first place.
1881 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1882 child process will be redirected to a file specified with `:file'.
1883 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1884 cue to call_process_cleanup not to close that handle.
1885
1886 2011-05-07 Ben Key <bkey76@gmail.com>
1887
1888 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1889 one of two shell specific rules, either bootstrap-temacs-CMD or
1890 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1891 to the previous implementation of the bootstrap-temacs rule.
1892 The bootstrap-temacs-CMD rule is similar to the previous
1893 implementation of the bootstrap-temacs rule except that it
1894 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1895 variable.
1896
1897 These changes, along with some changes to nt/configure.bat,
1898 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1899 earlier fix to add support for --cflags and --ldflags options
1900 that include quotes so that it works whether make uses cmd or
1901 sh as the shell.
1902
1903 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1904
1905 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1906 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1907 is a constant.
1908 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1909 a string. Handle both cases.
1910 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1911 (Fdbus_register_method): Use Qinvalid_function.
1912
1913 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1914
1915 * makefile.w32-in: Update dependencies.
1916 (LISP_H): Add inttypes.h and stdin.h.
1917 (PROCESS_H): Add unistd.h.
1918
1919 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1920
1921 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1922 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1923
1924 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1925
1926 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1927
1928 * term.c (vfatal): Remove stray call to va_end.
1929 It's not needed and the C Standard doesn't allow it here anyway.
1930
1931 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1932 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1933
1934 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1935 bytes.
1936
1937 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1938
1939 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1940
1941 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1942
1943 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1944
1945 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1946
1947 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1948 * charset.c (Fdefine_charset_internal): Don't initialize
1949 charset.code_space[15]. The value was garbage, on hosts with
1950 32-bit int (Bug#8600).
1951
1952 * lread.c (read_integer): Be more consistent with string-to-number.
1953 Use string_to_number to do the actual conversion; this avoids
1954 rounding errors and fixes some other screwups. Without this fix,
1955 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1956 (digit_to_number): Move earlier, for benefit of read_integer.
1957 Return -1 if the digit is out of range for the base, -2 if it is
1958 not a digit in any supported base. (Bug#8602)
1959
1960 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1961
1962 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1963 to match comment at start of function. This also removes a
1964 GCC warning about overflow in a 32+64-bit port.
1965
1966 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1967
1968 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1969 Reported by Stefan Monnier in
1970 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1971 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1972 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1973
1974 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1975 (EMACS_UINTPTR): Likewise, with uintptr_t.
1976
1977 * lisp.h: Prefer 64-bit EMACS_INT if available.
1978 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1979 on 32-bit hosts that have 64-bit int, so that they can access
1980 large files.
1981 However, temporarily disable this change unless the temporary
1982 symbol WIDE_EMACS_INT is defined.
1983
1984 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1985
1986 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1987 This removes an assumption that EMACS_INT and long are the same
1988 width as pointers. The assumption is true for Emacs porting targets
1989 now, but we want to make other targets possible.
1990 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1991 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1992 In the rest of the code, change types of integers that hold casted
1993 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1994 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1995 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1996 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1997 No need to cast type when ORing.
1998 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1999 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2000 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2001 assume EMACS_INT is the same width as char *.
2002 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2003 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2004 Remove no-longer-needed casts.
2005 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2006 (xg_tool_bar_help_callback, xg_make_tool_item):
2007 Use EMACS_INTPTR to hold an integer
2008 that will be cast to void *; this can avoid a GCC warning
2009 if EMACS_INT is not the same width as void *.
2010 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2011 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2012 (current_message_1, set_message_1):
2013 Use a local to convert to proper width without a cast.
2014 * xmenu.c (dialog_selection_callback): Likewise.
2015
2016 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2017 Also, don't assume VALBITS / RAND_BITS is less than 5,
2018 and don't rely on undefined behavior when shifting a 1 left into
2019 the sign bit.
2020 * lisp.h (get_random): Change signature to match.
2021
2022 * lread.c (hash_string): Use size_t, not int, for hash computation.
2023 Normally we prefer signed values; but hashing is special, because
2024 it's better to use unsigned division on hash table sizes so that
2025 the remainder is nonnegative. Also, size_t is the natural width
2026 for hashing into memory. The previous code used 'int', which doesn't
2027 retain enough info to hash well into very large tables.
2028 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2029
2030 * dbusbind.c: Don't possibly lose pointer info when converting.
2031 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2032 Use XPNTR rather than XHASH, so that the high-order bits of
2033 the pointer aren't lost when converting through void *.
2034
2035 * eval.c (Fautoload): Don't double-shift a pointer.
2036
2037 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2038
2039 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2040
2041 * gnutls.c (DEF_GNUTLS_FN):
2042 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2043
2044 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2045
2046 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2047 marker. (Bug#8610)
2048
2049 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2050
2051 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2052 New version that can reserve upto 2GB of heap space.
2053
2054 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2055
2056 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2057
2058 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2059
2060 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2061 `gnutls_certificate_set_x509_key_file'.
2062
2063 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2064
2065 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2066 Update dependencies.
2067
2068 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2069
2070 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2071 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2072 Remove unused parameter `fildes'.
2073 * process.c (read_process_output, send_process): Don't pass it.
2074
2075 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2076
2077 Fix previous change: the library cache is defined in w32.c.
2078 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2079 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2080
2081 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2082
2083 Implement dynamic loading of GnuTLS on Windows.
2084
2085 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2086 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2087 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2088 Declare.
2089
2090 * gnutls.c (Qgnutls_dll): Define.
2091 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2092 (gnutls_*): Declare function pointers.
2093 (init_gnutls_functions): New function to initialize function pointers.
2094 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2095 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2096 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2097 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2098 (emacs_gnutls_write, emacs_gnutls_read)
2099 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2100 (Fgnutls_available_p): New function.
2101 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2102 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2103 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2104
2105 * image.c: Include w32.h.
2106 (Vimage_type_cache): Delete.
2107 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2108 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2109 (w32_delayed_load): Move to w32.c.
2110
2111 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2112
2113 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2114 (w32_delayed_load): Move from image.c. When loading a library, record
2115 its filename in the :loaded-from property of the library id.
2116 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2117 Initialize and staticpro them.
2118 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2119
2120 * process.c: Include lisp.h before w32.h, not after.
2121 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2122 instead of gnutls_record_check_pending.
2123
2124 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2125
2126 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2127
2128 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2129 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2130 as passed in.
2131
2132 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2133
2134 * xterm.c (x_set_frame_alpha): Do not set property on anything
2135 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2136
2137 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2138
2139 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2140
2141 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2142
2143 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2144 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2145 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2146 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2147 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2148 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2149 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2150 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2151 (Qgnutls_bootprop_callbacks_verify): Make static.
2152
2153 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2154
2155 * callproc.c: Indentation fixup.
2156
2157 * sysdep.c (wait_for_termination_1): Make static.
2158 (wait_for_termination, interruptible_wait_for_termination):
2159 Move after wait_for_termination_1.
2160
2161 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2162
2163 * sysdep.c (interruptible_wait_for_termination): New function
2164 which is like wait_for_termination, but allows keyboard
2165 interruptions.
2166
2167 * callproc.c (Fcall_process): Add (:file "file") as an option for
2168 the STDOUT buffer.
2169 (Fcall_process_region): Ditto.
2170
2171 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2172
2173 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2174 rather than `XVECTOR (FOO)->size'.
2175
2176 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2177 inttypes.h, as a gnulib replacement is used if it not available in
2178 system headers.
2179
2180 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2181
2182 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2183 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2184 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2185
2186 * coding.c (coding_alloc_by_realloc): Error out if destination
2187 will grow beyond MOST_POSITIVE_FIXNUM.
2188 (decode_coding_emacs_mule): Abort if there isn't enough place in
2189 charbuf for the composition carryover bytes. Reserve an extra
2190 space for up to 2 characters produced in a loop.
2191 (decode_coding_iso_2022): Abort if there isn't enough place in
2192 charbuf for the composition carryover bytes.
2193
2194 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2195
2196 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2197 aborting when %lld or %lll format is passed.
2198 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2199 %llo or %llx format is passed. (Bug#8545)
2200
2201 * window.c (window_scroll_line_based): Use a marker instead of
2202 simple variables to record original value of point. (Bug#7952)
2203
2204 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2205 produced by %s or %c overflows available buffer space. (Bug#8545)
2206
2207 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2208
2209 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2210 (SIZE_MAX): Move defn after all includes, as they might #define it.
2211
2212 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2213
2214 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2215
2216 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2217
2218 * keyboard.c (Qdelayed_warnings_hook): Define.
2219 (command_loop_1): Run `delayed-warnings-hook'
2220 if Vdelayed_warnings_list is non-nil.
2221 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2222 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2223
2224 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2225
2226 * doprnt.c (doprnt): Don't return value smaller than the buffer
2227 size if the message was truncated. (Bug#8545).
2228
2229 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2230
2231 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2232 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2233
2234 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2235
2236 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2237
2238 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2239
2240 * makefile.w32-in: Update dependencies.
2241
2242 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2243
2244 Improve `doprnt' and its usage. (Bug#8545)
2245 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2246 `format_end'. Remove support for %l as a conversion specifier.
2247 Don't use xrealloc. Improve diagnostics when the %l size modifier
2248 is used. Update the commentary.
2249
2250 * eval.c (verror): Simplify calculation of size_t.
2251
2252 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2253 messages.
2254
2255 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2256
2257 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2258 change.
2259
2260 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2261
2262 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2263 This makes this file independent of the recent pseudovector change.
2264
2265 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2266
2267 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2268
2269 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2270 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2271 Remove unused local.
2272 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2273
2274 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2275 GCC 4.6.0 optimizes based on type-based alias analysis.
2276 For example, if b is of type struct buffer * and v of type struct
2277 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2278 != &v->size, and therefore "v->size = 1; b->size = 2; return
2279 v->size;" must therefore return 1. This assumption is incorrect
2280 for Emacs, since it type-puns struct Lisp_Vector * with many other
2281 types. To fix this problem, this patch adds a new type struct
2282 vectorlike_header that documents the constraints on layout of vectors
2283 and pseudovectors, and helps optimizing compilers not get fooled
2284 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2285 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2286 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2287 the size member.
2288 (XSETPVECTYPE): Rewrite in terms of new macro.
2289 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2290 This is a bit clearer, and further avoids the possibility of
2291 undesirable aliasing.
2292 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2293 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2294 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2295 since Lisp_Subr is a special case (no "next" field).
2296 (ASIZE): Now uses header.size rather than size.
2297 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2298 to avoid the hassle of writing XVECTOR (foo)->header.size.
2299 (struct vectorlike_header): New type.
2300 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2301 object, to help avoid aliasing.
2302 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2303 (SUBRP): Likewise, since Lisp_Subr is a special case.
2304 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2305 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2306 (struct Lisp_Hash_Table): Combine first two members into a single
2307 struct vectorlike_header member. All uses of "size" and "next" members
2308 changed to be "header.size" and "header.next".
2309 * buffer.h (struct buffer): Likewise.
2310 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2311 * frame.h (struct frame): Likewise.
2312 * process.h (struct Lisp_Process): Likewise.
2313 * termhooks.h (struct terminal): Likewise.
2314 * window.c (struct save_window_data, struct saved_window): Likewise.
2315 * window.h (struct window): Likewise.
2316 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2317 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2318 * buffer.c (init_buffer_once): Likewise.
2319 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2320 special case.
2321 * process.c (Fformat_network_address): Use local var for size,
2322 for brevity.
2323
2324 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2325
2326 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2327 * data.c (atof): Remove decl; no longer used or needed.
2328 (digit_to_number): Move to lread.c.
2329 (Fstring_to_number): Use new string_to_number function, to be
2330 consistent with how the Lisp reader treats infinities and NaNs.
2331 Do not assume that floating-point numbers represent EMACS_INT
2332 without losing information; this is not true on most 64-bit hosts.
2333 Avoid double-rounding errors, by insisting on integers when
2334 parsing non-base-10 numbers, as the documentation specifies.
2335 * lisp.h (string_to_number): New decl, replacing ...
2336 (isfloat_string): Remove.
2337 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2338 (read1): Do not accept +. and -. as integers; this
2339 appears to have been a coding error. Similarly, do not accept
2340 strings like +-1e0 as floating point numbers. Do not report
2341 overflow for integer overflows unless the base is not 10 which
2342 means we have no simple and reliable way to continue.
2343 Break out the floating-point parsing into a new
2344 function string_to_number, so that Fstring_to_number parses
2345 floating point numbers consistently with the Lisp reader.
2346 (digit_to_number): Move here from data.c. Make it static inline.
2347 (E_CHAR, EXP_INT): Remove, replacing with ...
2348 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2349 (string_to_number): New function, replacing isfloat_string.
2350 This function checks for valid syntax and produces the resulting
2351 Lisp float number too. Rework it so that string-to-number
2352 no longer mishandles examples like "1.0e+". Use strtoumax,
2353 so that overflow for non-base-10 numbers is reported only when
2354 there's no portable and simple way to convert to floating point.
2355
2356 * textprop.c (set_text_properties_1): Rewrite for clarity,
2357 and to avoid GCC warning about integer overflow.
2358
2359 * intervals.h (struct interval): Use EMACS_INT for members
2360 where EMACS_UINT might cause problems. See
2361 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2362 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2363 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2364 All uses changed.
2365 (offset_intervals): Tell GCC not to worry about length overflow
2366 when negating a negative length.
2367
2368 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2369 (overrun_check_free): Likewise.
2370
2371 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2372 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2373 word size.
2374
2375 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2376 (gnutls_make_error): Rename local to avoid shadowing.
2377 (gnutls_emacs_global_deinit): ifdef out; not used.
2378 (Fgnutls_boot): Use const for pointer to readonly storage.
2379 Comment out unused local. Fix pointer signedness problems.
2380
2381 * lread.c (openp): Don't stuff size_t into an 'int'.
2382 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2383 about possible signed overflow.
2384
2385 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2386 (GDK_KEY_g): Don't define if already defined.
2387 (xg_prepare_tooltip): Avoid pointer signedness problem.
2388 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2389
2390 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2391 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2392
2393 * xfns.c (Fx_window_property): Simplify a bit,
2394 to make a bit faster and to avoid GCC 4.6.0 warning.
2395 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2396
2397 * fns.c (internal_equal): Don't assume size_t fits in int.
2398
2399 * alloc.c (compact_small_strings): Tighten assertion a little.
2400
2401 Replace pEd with more-general pI, and fix some printf arg casts.
2402 * lisp.h (pI): New macro, generalizing old pEd macro to other
2403 conversion specifiers. For example, use "...%"pI"d..." rather
2404 than "...%"pEd"...".
2405 (pEd): Remove. All uses replaced with similar uses of pI.
2406 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2407 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2408 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2409 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2410 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2411 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2412 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2413 64-bit hosts.
2414 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2415 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2416 * print.c (safe_debug_print, print_object): Likewise.
2417 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2418 to int.
2419 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2420 avoiding the 0 flag, which is not portable.
2421 * process.c (Fmake_network_process): Use pI to avoid cast.
2422 * region-cache.c (pp_cache): Likewise.
2423 * xdisp.c (decode_mode_spec): Likewise.
2424 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2425 behavior on 64-bit hosts with printf arg.
2426 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2427 (x_stop_queuing_selection_requests): Likewise.
2428 (x_get_window_property): Don't truncate byte count to an 'int'
2429 when tracing.
2430
2431 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2432 here, since it parses constructs like leading '-' and spaces,
2433 which are not wanted; and it overflows with large numbers.
2434 Instead, simply match F[0-9]+, which is what is wanted anyway.
2435
2436 * alloc.c: Remove unportable assumptions about struct layout.
2437 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2438 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2439 (allocate_vectorlike, make_pure_vector): Use the new macros,
2440 plus offsetof, to remove unportable assumptions about struct layout.
2441 These assumptions hold on all porting targets that I know of, but
2442 they are not guaranteed, they're easy to remove, and removing them
2443 makes further changes easier.
2444
2445 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2446 This doesn't fix a bug but makes the code clearer.
2447 (string_overrun_cookie): Now const. Use initializers that
2448 don't formally overflow signed char, to avoid warnings.
2449 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2450 can cause Emacs to crash when string overrun checking is enabled.
2451 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2452 multiple of sizeof (EMACS_INT); it need not be, if
2453 alignof(EMACS_INT) < sizeof (EMACS_INT).
2454 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2455
2456 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2457
2458 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2459
2460 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2461
2462 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2463 supposed to be handshaking. (Bug#8556)
2464 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2465
2466 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2467
2468 * lisp.h (Qdebug): List symbol.
2469 * eval.c (Qdebug): Restore global linkage.
2470 * keyboard.c (debug-on-event): New variable.
2471 (handle_user_signal): Break into debugger when debug-on-event
2472 matches the current signal symbol.
2473
2474 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2475
2476 * alloc.c (check_sblock, check_string_bytes)
2477 (check_string_free_list): Convert to standard C.
2478
2479 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2480
2481 * w32.c (emacs_gnutls_push): Fix typo.
2482
2483 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2484
2485 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2486 "cast to pointer from integer of different size".
2487
2488 Improve doprnt and its use in verror. (Bug#8545)
2489 * doprnt.c (doprnt): Document the set of format control sequences
2490 supported by the function. Use SAFE_ALLOCA instead of always
2491 using `alloca'.
2492
2493 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2494 is one byte too soon. Don't use xrealloc; instead xfree and
2495 xmalloc anew.
2496
2497 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2498
2499 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2500 callbacks stage.
2501
2502 * gnutls.c: Renamed global_initialized to
2503 gnutls_global_initialized. Added internals for the
2504 :verify-hostname-error, :verify-error, and :verify-flags
2505 parameters of `gnutls-boot' and documented those parameters in the
2506 docstring. Start callback support.
2507 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2508 unless a fatal error occured. Call gnutls_alert_send_appropriate
2509 on error. Return error code.
2510 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2511 (emacs_gnutls_read): Likewise.
2512 (Fgnutls_boot): Return handshake error code.
2513 (emacs_gnutls_handle_error): New function.
2514 (wsaerror_to_errno): Likewise.
2515
2516 * w32.h (emacs_gnutls_pull): Add prototype.
2517 (emacs_gnutls_push): Likewise.
2518
2519 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2520 (emacs_gnutls_push): Likewise.
2521
2522 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2523
2524 * process.c (wait_reading_process_output): Check if GnuTLS
2525 buffered some data internally if no FDs are set for TLS
2526 connections.
2527
2528 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2529 (LIBS): Link to USER_LIBS.
2530 ($(BLD)/gnutls.$(0)): New target.
2531
2532 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2533
2534 * xdisp.c (handle_single_display_spec): Rename the
2535 display_replaced_before_p argument into display_replaced_p, to
2536 make it consistent with the commentary. Fix typos in the
2537 commentary.
2538
2539 * textprop.c (syms_of_textprop): Remove dead code.
2540 (copy_text_properties): Delete obsolete commentary about an
2541 interface that was deleted long ago. Fix typos in the description
2542 of arguments.
2543
2544 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2545 to changes in oldXMenu/XMenu.h from 2011-04-16.
2546 <menu_help_message, prev_menu_help_message>: Constify.
2547 (IT_menu_make_room): menu->help_text is now `const char **';
2548 adjust.
2549
2550 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2551 to changes in oldXMenu/XMenu.h from 2011-04-16.
2552 (struct XMenu): Declare `help_text' `const char **'.
2553
2554 * xfaces.c <Qunspecified>: Make extern again.
2555
2556 * syntax.c: Include sys/types.h before including regex.h, as
2557 required by Posix.
2558
2559 * doc.c (get_doc_string): Improve the format passed to `error'.
2560
2561 * doprnt.c (doprnt): Improve commentary.
2562
2563 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2564
2565 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2566 them with etags.
2567
2568 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2569 changes in globals.h immediately force recompilation.
2570 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2571 $(CURDIR)/s/ms-w32.h.
2572 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2573
2574 * character.c (Fchar_direction): Function deleted.
2575 (syms_of_character): Don't defsubr it.
2576 <char-direction-table>: Deleted.
2577
2578 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2579
2580 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2581 * doprnt.c: Include limits.h.
2582 (SIZE_MAX): New macro.
2583 (doprnt): Return a size_t value. 2nd arg is now size_t.
2584 Many local variables are now size_t instead of int or unsigned.
2585 Improve overflow protection. Support `l' modifier for integer
2586 conversions. Support %l conversion. Don't assume an EMACS_INT
2587 argument for integer conversions and for %c.
2588
2589 * lisp.h (doprnt): Restore prototype.
2590
2591 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2592 $(SRC)/character.h.
2593
2594 * Makefile.in (base_obj): Add back doprnt.o.
2595
2596 * deps.mk (doprnt.o): Add back prerequisites.
2597 (callint.o): Depend on character.h.
2598
2599 * eval.c (internal_lisp_condition_case): Include the handler
2600 representation in the error message.
2601 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2602 when breaking from the loop.
2603
2604 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2605
2606 * callint.c (Fcall_interactively): When displaying error message
2607 about invalid control letter, pass the character's codepoint, not
2608 a pointer to its multibyte form. Improve display of the character
2609 in octal and display also its hex code.
2610
2611 * character.c (char_string): Use %x to display the (unsigned)
2612 codepoint of an invalid character, to avoid displaying a bogus
2613 negative value.
2614
2615 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2616 `error', not SYMBOL_NAME itself.
2617
2618 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2619 character arguments to `error'.
2620
2621 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2622 to `error' in error message about FINAL_CHAR argument. Make sure
2623 FINAL_CHAR is a character, and use %c when it is passed as
2624 argument to `error'.
2625
2626 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2627
2628 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2629
2630 * w32.c: Include <time.h>.
2631 (sys_localtime): New function.
2632
2633 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2634
2635 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2636
2637 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2638
2639 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2640
2641 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2642 zombies (Bug#8467).
2643
2644 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2645
2646 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2647 gl_state.e_property when gl_state.object is Qt.
2648
2649 * insdel.c (make_gap_larger): Remove limitation of buffer size
2650 to <= INT_MAX.
2651
2652 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2653
2654 * xdisp.c (lookup_glyphless_char_display)
2655 (produce_glyphless_glyph): Handle cons cell entry in
2656 glyphless-char-display.
2657 (Vglyphless_char_display): Document it.
2658
2659 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2660 glyphless-char-display.
2661
2662 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2663
2664 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2665
2666 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2667
2668 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2669 definition for no-X builds.
2670
2671 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2672
2673 Static checks with GCC 4.6.0 and non-default toolkits.
2674
2675 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2676
2677 * process.c (keyboard_bit_set): Define only if SIGIO.
2678 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2679 (send_process): Repair possible setjmp clobbering.
2680
2681 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2682
2683 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2684
2685 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2686
2687 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2688 Define only if needed.
2689
2690 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2691 by pacifying GCC about it. Maybe it's time to retire it?
2692 * xfaces.c (USG, __TIMEVAL__): Likewise.
2693
2694 * dispextern.h (struct redisplay_interface): Rename param
2695 to avoid shadowing.
2696 * termhooks.h (struct terminal): Likewise.
2697 * xterm.c (xembed_send_message): Likewise.
2698
2699 * insdel.c (make_gap_smaller): Define only if
2700 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2701
2702 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2703 it.
2704
2705 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2706 so that we aren't warned about unused symbols.
2707
2708 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2709
2710 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2711
2712 * xfns.c (x_real_positions): Mark locals as initialized.
2713
2714 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2715
2716 * xterm.c: Fix problems found by static analysis with other toolkits.
2717 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2718 (x_dispatch_event): Declare static if USE_GTK, and
2719 define if USE_GTK || USE_X_TOOLKIT.
2720 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2721 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2722 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2723 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2724
2725 * xmenu.c (menu_help_callback): Pointer type fixes.
2726 Use const pointers when pointing at readonly data. Avoid pointer
2727 signedness clashes.
2728 (FALSE): Remove unused macro.
2729 (update_frame_menubar): Remove unused decl.
2730
2731 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2732
2733 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2734 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2735 (single_menu_item): Rename local to avoid shadowing.
2736
2737 * keyboard.c (make_lispy_event): Remove unused local var.
2738
2739 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2740 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2741
2742 * bitmaps: Change bitmaps from unsigned char back to the X11
2743 compatible char. Avoid the old compiler warnings about
2744 out-of-range initializers by using, for example, '\xab' rather
2745 than 0xab.
2746
2747 * xgselect.c (xgselect_initialize): Check vs interface
2748 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2749
2750 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2751
2752 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2753 to read-only memory.
2754
2755 * fns.c (vector): Remove; this old hack is no longer needed.
2756
2757 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2758 Remove unused var.
2759 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2760
2761 * xrdb.c (x_load_resources): Omit unused local.
2762
2763 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2764 (x_window): Rename locals to avoid shadowing.
2765 (USG): Use the kludged USG macro, to pacify gcc.
2766
2767 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2768 (x_term_init): Remove local to avoid shadowing.
2769
2770 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2771
2772 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2773 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2774
2775 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2776
2777 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2778
2779 Fix regex.c, syntax.c and friends for buffers > 2GB.
2780 * syntax.h (struct gl_state_s): Declare character position members
2781 EMACS_INT.
2782
2783 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2784
2785 * textprop.c (verify_interval_modification, interval_of):
2786 Declare arguments EMACS_INT.
2787
2788 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2789 EMACS_INT.
2790
2791 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2792
2793 * indent.c (Fvertical_motion): Local variable it_start is now
2794 EMACS_INT.
2795
2796 * regex.c (re_match, re_match_2, re_match_2_internal)
2797 (bcmp_translate, regcomp, regexec, print_double_string)
2798 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2799 (re_compile_pattern, re_exec): Declare arguments and local
2800 variables `size_t' and `ssize_t' and return values `regoff_t', as
2801 appropriate.
2802 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2803 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2804 <compile_stack_type>: `size' and `avail' are now `size_t'.
2805
2806 * regex.h <regoff_t>: Use ssize_t, not int.
2807 (re_search, re_search_2, re_match, re_match_2): Arguments that
2808 specify buffer/string position and length are now ssize_t and
2809 size_t. Return type is regoff_t.
2810
2811 2011-04-16 Ben Key <bkey76@gmail.com>
2812
2813 * nsfont.m: Fixed bugs in ns_get_family and
2814 ns_descriptor_to_entity that were caused by using free to
2815 deallocate memory blocks that were allocated by xmalloc (via
2816 xstrdup). This caused Emacs to crash when compiled with
2817 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2818 --enable-checking=xmallocoverrun). xfree is now used to
2819 deallocate these memory blocks.
2820
2821 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2822
2823 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2824
2825 emacs_write: Accept and return EMACS_INT for sizes.
2826 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2827 et seq.
2828 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2829 Accept and return EMACS_INT.
2830 (emacs_gnutls_write): Return the number of bytes written on
2831 partial writes.
2832 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2833 (emacs_read, emacs_write): Remove check for negative size, as the
2834 Emacs source code has been audited now.
2835 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2836 (emacs_read, emacs_write): Use it.
2837 * process.c (send_process): Adjust to the new signatures of
2838 emacs_write and emacs_gnutls_write. Do not attempt to store
2839 a byte offset into an 'int'; it might overflow.
2840 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2841
2842 * sound.c: Don't assume sizes fit in 'int'.
2843 (struct sound_device.period_size, alsa_period_size):
2844 Return EMACS_INT, not int.
2845 (struct sound_device.write, vox_write, alsa_write):
2846 Accept EMACS_INT, not int.
2847 (wav_play, au_play): Use EMACS_INT to store sizes and to
2848 record read return values.
2849
2850 2011-04-15 Ben Key <bkey76@gmail.com>
2851
2852 * keyboard.c (Qundefined): Don't declare static since it is used
2853 in nsfns.m.
2854 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2855 static since they are used in nsfont.m.
2856
2857 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2858
2859 * process.c (Qprocessp): Don't declare static.
2860 * lisp.h (Qprocessp): Declare again.
2861
2862 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2863
2864 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2865
2866 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2867
2868 Improve C-level modularity by making more things 'static'.
2869
2870 Don't publish debugger-only interfaces to other modules.
2871 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2872 (verify_bytepos, count_markers): Move decls to the only modules
2873 that need them.
2874 * region-cache.h (pp_cache): Likewise.
2875 * window.h (check_all_windows): Likewise.
2876 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2877
2878 * sysdep.c (croak): Now static, if
2879 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2880 * syssignal.h (croak): Declare only if not static.
2881
2882 * alloc.c (refill_memory_reserve): Now static if
2883 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2884 * lisp.h (refill_memory_reserve): Declare only if not static.
2885
2886 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2887 Define only if USE_LUCID.
2888
2889 * xrdb.c (x_customization_string, x_rm_string): Now static.
2890
2891 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2892 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2893
2894 * xdisp.c (draw_row_with_mouse_face): Now static.
2895 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2896
2897 * window.h (check_all_windows): Mark externally visible.
2898
2899 * window.c (window_deletion_count): Now static.
2900
2901 * undo.c: Make symbols static if they're not exported.
2902 (last_undo_buffer, last_boundary_position, pending_boundary):
2903 Now static.
2904
2905 * textprop.c (interval_insert_behind_hooks): Now static.
2906 (interval_insert_in_front_hooks): Likewise.
2907
2908 * term.c: Make symbols static if they're not exported.
2909 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2910 (max_frame_lines, tty_set_terminal_modes):
2911 (tty_reset_terminal_modes, tty_turn_off_highlight):
2912 (get_tty_terminal): Now static.
2913 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2914 * termhooks.h (term_mouse_moveto): Do not declare if
2915 HAVE_WINDOW_SYSTEM.
2916 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2917 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2918
2919 * sysdep.c: Make symbols static if they're not exported.
2920 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2921 Now static.
2922 (sigprocmask_set, full_mask): Remove; unused.
2923 (wait_debugging): Mark as visible.
2924 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2925 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2926
2927 * syntax.c (syntax_temp): Define only if !__GNUC__.
2928
2929 * sound.c (current_sound_device, current_sound): Now static.
2930
2931 * search.c (searchbufs, searchbuf_head): Now static.
2932
2933 * scroll.c (scroll_cost): Remove; unused.
2934 * dispextern.h (scroll_cost): Remove decl.
2935
2936 * region-cache.h (pp_cache): Mark as externally visible.
2937
2938 * process.c: Make symbols static if they're not exported.
2939 (process_tick, update_tick, create_process, chan_process):
2940 (Vprocess_alist, proc_buffered_char, datagram_access):
2941 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2942 (deactivate_process): Mark defn as static, as well as decl.
2943 * lisp.h (create_process): Remove decl.
2944 * process.h (chan_process, Vprocess_alist): Remove decls.
2945
2946 * print.c: Make symbols static if they're not exported.
2947 (print_depth, new_backquote_output, being_printed, print_buffer):
2948 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2949 (print_interval, print_number_index, initial_stderr_stream):
2950 Now static.
2951 * lisp.h (Fprinc): Remove decl.
2952 (debug_output_compilation_hack): Mark as externally visible.
2953
2954 * sysdep.c (croak): Move decl from here to syssignal.h.
2955 * syssignal.h (croak): Put it here, so the API can be checked when
2956 'croak' is called from dissociate_if_controlling_tty.
2957
2958 * minibuf.c: Make symbols static if they're not exported.
2959 (minibuf_save_list, choose_minibuf_frame): Now static.
2960 * lisp.h (choose_minibuf_frame): Remove decl.
2961
2962 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2963
2964 * lread.c: Make symbols static if they're not exported.
2965 (read_objects, initial_obarray, oblookup_last_bucket_number):
2966 Now static.
2967 (make_symbol): Remove; unused.
2968 * lisp.h (initial_obarray, make_symbol): Remove decls.
2969
2970 * keyboard.c: Make symbols static if they're not exported.
2971 (single_kboard, recent_keys_index, total_keys, recent_keys):
2972 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2973 (this_single_command_key_start, echoing, last_auto_save):
2974 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2975 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2976 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2977 (Vlispy_mouse_stem, double_click_count):
2978 Now static.
2979 (force_auto_save_soon): Define only if SIGDANGER.
2980 (ignore_mouse_drag_p): Now static if
2981 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2982 (print_help): Remove; unused.
2983 (stop_character, last_timer_event): Mark as externally visible.
2984 * keyboard.h (ignore_mouse_drag_p): Declare only if
2985 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2986 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2987 * lisp.h (echoing): Remove decl.
2988 (force_auto_save_soon): Declare only if SIGDANGER.
2989 * xdisp.c (redisplay_window): Simplify code, to make it more
2990 obvious that ignore_mouse_drag_p is not accessed if !defined
2991 USE_GTK && !defined HAVE_NS.
2992
2993 * intervals.c: Make symbols static if they're not exported.
2994 (merge_properties_sticky, merge_interval_right, delete_interval):
2995 Now static.
2996 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2997
2998 * insdel.c: Make symbols static if they're not exported.
2999 However, leave prepare_to_modify_buffer alone. It's never
3000 called from outside this function, but that appears to be a bug.
3001 (combine_after_change_list, combine_after_change_buffer):
3002 (adjust_after_replace, signal_before_change): Now static.
3003 (adjust_after_replace_noundo): Remove; unused.
3004 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3005 (signal_before_change): Remove decls.
3006
3007 * indent.c (val_compute_motion, val_vmotion): Now static.
3008
3009 * image.c: Make symbols static if they're not exported.
3010 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3011 if USE_GTK.
3012 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3013 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3014
3015 * fringe.c (standard_bitmaps): Now static.
3016 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3017
3018 * frame.c: Make symbols static if they're not exported.
3019 (x_report_frame_params, make_terminal_frame): Now static.
3020 (get_frame_param): Now static, unless HAVE_NS.
3021 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3022 (x_get_resource_string): Remove; not used.
3023 * frame.h (make_terminal_frame, x_report_frame_params):
3024 (x_get_resource_string); Remove decls.
3025 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3026 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3027
3028 * font.c, fontset.c: Make symbols static if they're not exported.
3029 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3030 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3031 * font.c (font_close_object): Now static.
3032 * font.h (font_close_object): Remove.
3033 * fontset.c (FONTSET_OBJLIST): Remove.
3034 (free_realized_fontset) #if-0 the body, which does nothing.
3035 (face_suitable_for_char_p): #if-0, as it's never called.
3036 * fontset.h (face_suitable_for_char_p): Remove decl.
3037 * xfaces.c (face_at_string_position):
3038 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3039 since 0 is always ASCII.
3040
3041 * fns.c (weak_hash_tables): Now static.
3042
3043 * fileio.c: Make symbols static if they're not exported.
3044 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3045 (Vwrite_region_annotation_buffers): Now static.
3046
3047 * eval.c: Make symbols static if they're not exported.
3048 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3049 * lisp.h (backtrace_list): Remove decl.
3050
3051 * emacs.c: Make symbols static if they're not exported.
3052 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3053 (fatal_error_code, fatal_error_signal_hook, standard_args):
3054 Now static.
3055 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3056 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3057 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3058 * lisp.h (fatal_error_signal_hook): Remove decl.
3059 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3060
3061 * editfns.c: Move a (normally-unused) function to its only use.
3062 * editfns.c, lisp.h (get_operating_system_release): Remove.
3063 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3064 worth the hassle of breaking this out.
3065
3066 * xterm.c: Make symbols static if they're not exported.
3067 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3068 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3069 (x_destroy_window, x_delete_display):
3070 Now static.
3071 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3072 (x_mouse_leave): Remove; unused.
3073 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3074 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3075 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3076 Remove decls.
3077 (x_mouse_leave): Declare only if WINDOWSNT.
3078 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3079 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3080 USE_X_TOOLKIT.
3081
3082 * ftxfont.c: Make symbols static if they're not exported.
3083 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3084 HAVE_FREETYPE.
3085 * font.h (ftxfont_driver): Likewise.
3086
3087 * xfns.c: Make symbols static if they're not exported.
3088 (x_last_font_name, x_display_info_for_name):
3089 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3090 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3091 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3092 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3093 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3094 (last_show_tip_args): Now static.
3095 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3096 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3097 (x_screen_planes): Remove; unused.
3098 * dispextern.h (x_screen_planes): Remove decl.
3099
3100 * dispnew.c: Make symbols static if they're not exported.
3101 * dispextern.h (redraw_garbaged_frames, scrolling):
3102 (increment_row_positions): Remove.
3103 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3104 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3105 Now static.
3106 (redraw_garbaged_frames): Remove; unused.
3107
3108 * xfaces.c: Make symbols static if they're not exported.
3109 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3110 Remove decls.
3111 * xterm.h (defined_color): Remove decls.
3112 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3113 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3114 (menu_face_changed_default, defined_color, free_realized_face):
3115 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3116 (ascii_face_of_lisp_face): Remove; unused.
3117
3118 * xdisp.c: Make symbols static if they're not exported.
3119 * dispextern.h (scratch_glyph_row, window_box_edges):
3120 (glyph_to_pixel_coords, set_cursor_from_row):
3121 (get_next_display_element, set_iterator_to_next):
3122 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3123 (show_mouse_face): Remove decls
3124 * frame.h (message_buf_print): Likewise.
3125 * lisp.h (pop_message, set_message, check_point_in_composition):
3126 Likewise.
3127 * xterm.h (set_vertical_scroll_bar): Likewise.
3128 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3129 (message_buf_print, scratch_glyph_row, displayed_buffer):
3130 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3131 (get_next_display_element, show_mouse_face, window_box_edges):
3132 (frame_to_window_pixel_xy, check_point_in_composition):
3133 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3134 (glyph_to_pixel_coords): Remove; unused.
3135
3136 * dired.c (file_name_completion): Now static.
3137
3138 * dbusbind.c (xd_in_read_queued_messages): Now static.
3139
3140 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3141 * data.c (circular_list_error): Remove.
3142
3143 * commands.h (last_point_position, last_point_position_buffer):
3144 (last_point_position_window): Remove decls.
3145 * keyboard.c: Make these variables static.
3146
3147 * coding.h (coding, code_convert_region, encode_coding_gap):
3148 Remove decls.
3149 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3150 (iso_code_class, detect_coding, code_convert_region): Now static.
3151 (encode_coding_gap): Remove; unused.
3152
3153 * chartab.c (chartab_chars, chartab_bits): Now static.
3154
3155 * charset.h (charset_iso_8859_1): Remove decl.
3156 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3157 Now static.
3158
3159 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3160 * ccl.c (Vccl_program_table): Now static.
3161 (check_ccl_update): Remove; unused.
3162
3163 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3164 * category.h: ... from here.
3165 * category.c (check_category_table, set_category_set): Now static.
3166
3167 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3168 * lisp.h: Remove these decls.
3169
3170 * buffer.c (buffer_count): Remove unused var.
3171
3172 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3173 so that it's not optimized away.
3174 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3175 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3176 exported only to the debugger.
3177
3178 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3179 * atimer.h (run_all_atimers): Remove; not exported.
3180
3181 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3182 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3183 was inaccessible from Lisp.
3184 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3185 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3186
3187 alloc.c: Import and export fewer symbols, and remove unused items.
3188 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3189 is defined.
3190 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3191 it's not optimized away by whole-program optimization.
3192 (message_enable_multibyte, free_misc): Remove.
3193 (catchlist, handlerlist, mark_backtrace):
3194 Declare only if BYTE_MARK_STACK.
3195 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3196 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3197 (message_enable_multibyte): Remove decl.
3198 (free_misc, interval_free_list, float_block, float_block_index):
3199 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3200 (cons_free_list, last_marked_index):
3201 Now static.
3202 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3203 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3204 (mark_backtrace): Define only if BYTE_MARK_STACK.
3205 * xdisp.c (message_enable_multibyte): Now static.
3206
3207 Declare Lisp_Object Q* variables to be 'static' if not exported.
3208 This makes it easier for human readers (and static analyzers)
3209 to see whether these variables are used from other modules.
3210 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3211 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3212 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3213 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3214 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3215 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3216 * xmenu.c, xselect.c:
3217 Declare Q* vars static if they are not used in other modules.
3218 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3219 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3220 Remove decls of unexported vars.
3221 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3222
3223 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3224
3225 Make Emacs functions such as Fatom 'static' by default.
3226 This makes it easier for human readers (and static analyzers)
3227 to see whether these functions can be called from other modules.
3228 DEFUN now defines a static function. To make the function external
3229 so that it can be used in other C modules, use the new macro DEFUE.
3230 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3231 (Finit_image_library):
3232 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3233 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3234 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3235 Remove decls, since these functions are now static.
3236 (Funintern, Fget_internal_run_time): New decls, since these functions
3237 were already external.
3238
3239 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3240 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3241 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3242 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3243 * keyboard.c, keymap.c, lread.c:
3244 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3245 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3246 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3247 Mark functions with DEFUE instead of DEFUN,
3248 if they are used in other modules.
3249 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3250 decls for now-static functions.
3251 * buffer.h (Fdelete_overlay): Remove decl.
3252 * callproc.c (Fgetenv_internal): Mark as internal.
3253 * composite.c (Fremove_list_of_text_properties): Remove decl.
3254 (Fcomposition_get_gstring): New forward static decl.
3255 * composite.h (Fcomposite_get_gstring): Remove decl.
3256 * dired.c (Ffile_attributes): New forward static decl.
3257 * doc.c (Fdocumntation_property): New forward static decl.
3258 * eval.c (Ffetch_bytecode): New forward static decl.
3259 (Funintern): Remove extern decl; now in .h file where it belongs.
3260 * fileio.c (Fmake_symbolic_link): New forward static decl.
3261 * image.c (Finit_image_library): New forward static decl.
3262 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3263 * intervals.h (Fprevious_property_change):
3264 (Fremove_list_of_text_properties): Remove decls.
3265 * keyboard.c (Fthis_command_keys): Remove decl.
3266 (Fcommand_execute): New forward static decl.
3267 * keymap.c (Flookup_key): New forward static decl.
3268 (Fcopy_keymap): Now static.
3269 * keymap.h (Flookup_key): Remove decl.
3270 * process.c (Fget_process): New forward static decl.
3271 (Fprocess_datagram_address): Mark as internal.
3272 * syntax.c (Fsyntax_table_p): New forward static decl.
3273 (skip_chars): Remove duplicate decl.
3274 * textprop.c (Fprevious_property_change): New forward static decl.
3275 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3276 Now internal.
3277 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3278 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3279
3280 * editfns.c (Fformat): Remove unreachable code.
3281
3282 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3283
3284 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3285 change. (Bug#8496)
3286
3287 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3288
3289 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3290 when at ZV. (Bug#8487)
3291
3292 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3293
3294 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3295 (Bug#8437)
3296 * keyboard.c (parse_tool_bar_item): Likewise.
3297 * sound.c (sound_cleanup, alsa_close): Likewise.
3298 * termcap.c (tgetent): Likewise.
3299 * xfns.c (x_default_font_parameter): Likewise.
3300 * xsettings.c (read_and_apply_settings): Likewise.
3301
3302 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3303 (overrun_check_free): Protoize.
3304
3305 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3306
3307 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3308 since callers should never pass a negative size.
3309 Change the signature to match that of plain 'read' and 'write'; see
3310 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3311 * lisp.h: Update prototypes of emacs_write and emacs_read.
3312
3313 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3314
3315 * xdisp.c (redisplay_window): Don't try to determine the character
3316 position of the scroll margin if the window start point w->startp
3317 is outside the buffer's accessible region. (Bug#8468)
3318
3319 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3320
3321 Fix write-region and its subroutines for buffers > 2GB.
3322 * fileio.c (a_write, e_write): Modify declaration of arguments and
3323 local variables to support buffers larger than 2GB.
3324 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3325
3326 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3327 argument, local variables, and return value.
3328
3329 * lisp.h: Update prototypes of emacs_write and emacs_read.
3330
3331 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3332
3333 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3334
3335 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3336
3337 Fix more problems found by GCC 4.6.0's static checks.
3338
3339 * xdisp.c (vmessage): Use a better test for character truncation.
3340
3341 * charset.c (load_charset_map): <, not <=, for optimization,
3342 and to avoid potential problems with integer overflow.
3343 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3344 * casetab.c (set_identity, shuffle): Likewise.
3345 * editfns.c (Fformat): Likewise.
3346 * syntax.c (skip_chars): Likewise.
3347
3348 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3349 This also lets GCC 4.6.0 generate slightly better loop code.
3350
3351 * callint.c (Fcall_interactively): <, not <=, for optimization.
3352 (Fcall_interactively): Count the number of arguments produced,
3353 not the number of arguments given. This is simpler and lets GCC
3354 4.6.0 generate slightly better code.
3355
3356 * ftfont.c: Distingish more carefully between FcChar8 and char.
3357 The previous code passed unsigned char * to a functions like
3358 strlen and xstrcasecmp that expect char *, which does not
3359 conform to the C standard.
3360 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3361 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3362 char * when the C standard requires it.
3363
3364 * keyboard.c (read_char): Remove unused var.
3365
3366 * eval.c: Port to Windows vsnprintf (Bug#8435).
3367 Include <limits.h>.
3368 (SIZE_MAX): Define if the headers do not.
3369 (verror): Do not give up if vsnprintf returns a negative count.
3370 Instead, grow the buffer. This ports to Windows vsnprintf, which
3371 does not conform to C99. Problem reported by Eli Zaretskii.
3372 Also, simplify the allocation scheme, by avoiding the need for
3373 calling realloc, and removing the ALLOCATED variable.
3374
3375 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3376
3377 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3378 But keep the doprint source code for now, as we might revamp it
3379 and use it again (Bug#8435).
3380 * lisp.h (doprnt): Remove.
3381 * Makefile.in (base_obj): Remove doprnt.o.
3382 * deps.mk (doprnt.o): Remove.
3383
3384 error: Print 32- and 64-bit integers portably (Bug#8435).
3385 Without this change, on typical 64-bit hosts error ("...%d...", N)
3386 was used to print both 32- and 64-bit integers N, which relied on
3387 undefined behavior.
3388 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3389 New macro.
3390 * lisp.h (error, verror): Mark as printf-like functions.
3391 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3392 Report overflow in size calculations when allocating printf buffer.
3393 Do not truncate output string at its first null byte.
3394 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3395 Truncate the output at a character boundary, since vsnprintf does not
3396 do that.
3397 * charset.c (check_iso_charset_parameter): Convert internal
3398 character to string before calling 'error', since %c now has the
3399 printf meaning.
3400 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3401 overflow when computing char to be passed to 'error'. Do not
3402 pass Lisp_Object to 'error'; pass the integer instead.
3403 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3404 formatted with plain %d.
3405
3406 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3407
3408 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3409
3410 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3411
3412 * xterm.c (x_catch_errors): Remove duplicate declaration.
3413
3414 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3415
3416 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3417
3418 2011-04-10 Jim Meyering <meyering@redhat.com>
3419
3420 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3421 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3422 return ssize_t not "int", and use size_t as the buffer length.
3423 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3424 * gnutls.h: Update declarations.
3425 * process.c (read_process_output): Use ssize_t, to match.
3426 (send_process): Likewise.
3427
3428 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3429
3430 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3431
3432 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3433
3434 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3435 Use unsigned char, to match FcChar8 type definition.
3436
3437 * xterm.c (handle_one_xevent):
3438 * xmenu.c (create_and_show_popup_menu):
3439 * xselect.c (x_decline_selection_request)
3440 (x_reply_selection_request): Avoid type-punned deref of X events.
3441
3442 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3443
3444 Fix some uses of `int' instead of EMACS_INT.
3445 * search.c (string_match_1, fast_string_match)
3446 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3447 (scan_buffer, find_next_newline_no_quit)
3448 (find_before_next_newline, search_command, Freplace_match)
3449 (Fmatch_data): Make some `int' variables be EMACS_INT.
3450
3451 * xdisp.c (display_count_lines): 3rd argument and return value now
3452 EMACS_INT. All callers changed.
3453 (pint2hrstr): Last argument is now EMACS_INT.
3454
3455 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3456 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3457 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3458 (decode_coding_utf_16, decode_coding_emacs_mule)
3459 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3460 (decode_coding_ccl, decode_coding_charset)
3461 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3462 (decode_coding_iso_2022, decode_coding_emacs_mule)
3463 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3464 <char_offset, last_offset>: Declare EMACS_INT.
3465 (encode_coding_utf_8, encode_coding_utf_16)
3466 (encode_coding_emacs_mule, encode_invocation_designation)
3467 (encode_designation_at_bol, encode_coding_iso_2022)
3468 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3469 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3470 Declare EMACS_INT.
3471 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3472 (encode_invocation_designation): Last argument P_NCHARS is now
3473 EMACS_INT.
3474 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3475 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3476
3477 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3478 All users changed.
3479
3480 * ccl.c (Fccl_execute_on_string): Declare some variables
3481 EMACS_INT.
3482
3483 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3484
3485 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3486
3487 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3488
3489 * process.c (Fformat_network_address): Doc fix.
3490
3491 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3492
3493 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3494
3495 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3496
3497 * keyboard.c (read_char): Call Lisp function help-form-show,
3498 instead of using internal_with_output_to_temp_buffer.
3499 (Qhelp_form_show): New var.
3500 (syms_of_keyboard): Use DEFSYM macro.
3501
3502 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3503
3504 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3505
3506 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3507
3508 * process.c (Flist_processes): Remove to Lisp.
3509 (list_processes_1): Delete.
3510
3511 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3512
3513 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3514
3515 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3516
3517 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3518
3519 Fix more problems found by GCC 4.6.0's static checks.
3520
3521 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3522
3523 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3524
3525 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3526
3527 * xdisp.c (vmessage): Mark as a printf-like function.
3528
3529 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3530
3531 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3532
3533 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3534 printf-like functions.
3535 (tiff_load): Add casts to remove these marks before passing them
3536 to system-supplied API.
3537
3538 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3539
3540 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3541 This avoids several warnings with gcc -Wstrict-overflow.
3542 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3543 directly, rather than having caller test rule sign. This avoids
3544 some unnecessary tests.
3545 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3546 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3547 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3548
3549 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3550 (xfont_open): Avoid unnecessary tests.
3551
3552 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3553
3554 * composite.h, composite.c (composition_gstring_put_cache):
3555 Use EMACS_INT, not int, for length.
3556
3557 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3558 breaking out part of COMPOSITION_DECODE_RULE.
3559 (COMPOSITION_DECODE_RULE): Use it.
3560 * composite.c (get_composition_id): Remove unused local vars,
3561 by using the new macro.
3562
3563 * textprop.c (set_text_properties_1): Change while to do-while,
3564 since the condition is always true at first.
3565
3566 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3567 (interval_deletion_adjustment): Return unsigned value.
3568 All uses changed.
3569
3570 * process.c (list_processes_1, create_pty, read_process_output):
3571 (exec_sentinel): Remove vars that were set but not used.
3572 (create_pty): Remove unnecessary "volatile"s.
3573 (Fnetwork_interface_info): Avoid possibility of int overflow.
3574 (read_process_output): Do adaptive read buffering even if carryover.
3575 (read_process_output): Simplify nbytes computation if buffered.
3576
3577 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3578
3579 * syntax.c (scan_words): Remove var that was set but not used.
3580 (update_syntax_table): Use unsigned instead of int.
3581
3582 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3583 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3584 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3585
3586 * print.c (print_error_message): Avoid int overflow.
3587
3588 * font.c (font_list_entities): Redo for clarity,
3589 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3590
3591 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3592 (font_score): Avoid potential overflow in diff calculation.
3593
3594 * fns.c (substring_both): Remove var that is set but not used.
3595 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3596
3597 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3598
3599 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3600 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3601 can always succeed if overflow has undefined behavior.
3602
3603 * search.c (boyer_moore, wordify): Remove vars set but not used.
3604 (wordify): Omit three unnecessary tests.
3605
3606 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3607 All callers changed. This avoids the need for an unused var.
3608
3609 * casefiddle.c (casify_region): Remove var that is set but not used.
3610
3611 * dired.c (file_name_completion): Remove var that is set but not used.
3612
3613 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3614
3615 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3616 (Finsert_file_contents): Remove unnecessary code checking fd.
3617
3618 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3619 Check for integer overflow on size calculations.
3620
3621 * buffer.c (Fprevious_overlay_change): Remove var that is set
3622 but not used.
3623
3624 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3625 Remove vars that are set but not used.
3626 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3627 (timer_check_2): Mark vars as initialized.
3628
3629 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3630
3631 * image.c (lookup_image): Remove var that is set but not used.
3632 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3633
3634 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3635 that are set but not used.
3636
3637 * xfns.c (make_invisible_cursor): Don't return garbage
3638 if XCreateBitmapFromData fails (Bug#8410).
3639
3640 * xselect.c (x_get_local_selection, x_handle_property_notify):
3641 Remove vars that are set but not used.
3642
3643 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3644 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3645
3646 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3647 Remove var that is set but not used.
3648 (scroll_bar_windows_size): Now size_t, not int.
3649 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3650 Check for overflow.
3651
3652 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3653 (map_tty_color) [!defined MSDOS]: Likewise.
3654
3655 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3656
3657 * coding.c: Remove vars that are set but not used.
3658 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3659 All callers changed.
3660 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3661 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3662 (decode_coding_charset): Remove vars that are set but not used.
3663
3664 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3665 that is set but not used.
3666
3667 * print.c (print_object): Remove var that is set but not used.
3668
3669 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3670 The gnulib version avoids calling malloc in the usual case,
3671 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3672 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3673 * filelock.c (current_lock_owner): Likewise.
3674 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3675 * sysdep.c: Include allocator.h, careadlinkat.h.
3676 (emacs_no_realloc_allocator): New static constant.
3677 (emacs_readlink): New function.
3678 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3679 ../lib/careadlinkat.h.
3680
3681 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3682
3683 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3684 first non-nil return value).
3685
3686 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3687
3688 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3689 if not defined (Bug#8403).
3690
3691 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3692
3693 * xdisp.c (display_count_lines): Remove parameter `start',
3694 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3695 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3696 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3697 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3698 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3699 and thereabouts. All callers changed.
3700 (get_per_char_metric): Remove parameter `f', unused since
3701 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3702
3703 2011-04-02 Jim Meyering <meyering@redhat.com>
3704
3705 do not dereference NULL upon failed strdup
3706 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3707 (ns_get_family): Likewise.
3708
3709 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3710
3711 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3712
3713 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3714
3715 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3716 later (Bug#8403).
3717
3718 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3719
3720 Add lexical binding.
3721
3722 * window.c (Ftemp_output_buffer_show): New fun.
3723 (Fsave_window_excursion):
3724 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3725
3726 * lread.c (lisp_file_lexically_bound_p): New function.
3727 (Fload): Bind Qlexical_binding.
3728 (readevalloop): Remove `evalfun' arg.
3729 Bind Qinternal_interpreter_environment.
3730 (Feval_buffer): Bind Qlexical_binding.
3731 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3732 Mark as dynamic.
3733 (syms_of_lread): Declare `lexical-binding'.
3734
3735 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3736
3737 * keyboard.c (eval_dyn): New fun.
3738 (menu_item_eval_property): Use it.
3739
3740 * image.c (parse_image_spec): Use Ffunctionp.
3741
3742 * fns.c (concat, mapcar1): Accept byte-code-functions.
3743
3744 * eval.c (Fsetq): Handle lexical vars.
3745 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3746 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3747 (FletX, Flet): Obey lexical binding.
3748 (Fcommandp): Handle closures.
3749 (Feval): New `lexical' arg.
3750 (eval_sub): New function extracted from Feval. Use it almost
3751 everywhere where Feval was used. Look up vars in lexical env.
3752 Handle closures.
3753 (Ffunctionp): Move from subr.el.
3754 (Ffuncall): Handle closures.
3755 (apply_lambda): Remove `eval_flags'.
3756 (funcall_lambda): Handle closures and new byte-code-functions.
3757 (Fspecial_variable_p): New function.
3758 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3759 but without exporting it to Lisp.
3760
3761 * doc.c (Fdocumentation, store_function_docstring):
3762 * data.c (Finteractive_form): Handle closures.
3763
3764 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3765 interactive spec.
3766
3767 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3768 New byte-codes.
3769 (exec_byte_code): New function extracted from Fbyte_code to handle new
3770 calling convention for byte-code-functions. Add new byte-codes.
3771
3772 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3773
3774 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3775
3776 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3777
3778 * xdisp.c (redisplay_internal): Fix prototype.
3779
3780 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3781
3782 * xdisp.c (SCROLL_LIMIT): New macro.
3783 (try_scrolling): Use it when setting scroll_limit.
3784 Limit scrolling to 100 screen lines.
3785 (redisplay_window): Even when falling back on "recentering",
3786 position point in the window according to scroll-conservatively,
3787 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3788
3789 (try_scrolling): When point is above the window, allow searching
3790 as far as scroll_max, or one screenful, to compute vertical
3791 distance from PT to the scroll margin position. This prevents
3792 try_scrolling from unnecessarily failing when
3793 scroll-conservatively is set to a value slightly larger than the
3794 window height. Clean up the case of PT below the margin at bottom
3795 of window: scroll_max can no longer be INT_MAX. When aggressive
3796 scrolling is in use, don't let point enter the opposite scroll
3797 margin as result of the scroll.
3798 (syms_of_xdisp) <scroll-conservatively>: Document the
3799 threshold of 100 lines for never-recentering scrolling.
3800
3801 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3802
3803 * dispextern.h (move_it_by_lines):
3804 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3805 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3806 (message_log_check_duplicate): Remove parameters `prev_bol' and
3807 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3808 (redisplay_internal): Remove parameter `preserve_echo_area',
3809 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3810
3811 * indent.c (Fvertical_motion):
3812 * window.c (window_scroll_pixel_based, Frecenter):
3813 Don't pass `need_y_p' to `move_it_by_lines'.
3814
3815 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3816
3817 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3818 steal a few bits to be more compact.
3819 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3820 Remove unneeded casts.
3821
3822 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3823
3824 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3825
3826 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3827 binding" message (bug#7967).
3828
3829 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3830
3831 Fix more problems found by GCC 4.6.0's static checks.
3832
3833 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3834 Remove unused local var.
3835
3836 * editfns.c (Fmessage_box): Remove unused local var.
3837
3838 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3839 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3840 Omit unused local vars.
3841 * window.c (shrink_windows): Omit unused local var.
3842 * menu.c (digest_single_submenu): Omit unused local var.
3843 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3844 Omit unused local var.
3845
3846 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3847 Don't assume string length fits in int.
3848 (keyremap_step, read_key_sequence): Use size_t for sizes.
3849 (read_key_sequence): Don't check last_real_key_start redundantly.
3850
3851 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3852 instead of alloca (Bug#8344).
3853
3854 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3855 (Fbacktrace_frame): Don't assume nframes fits in int.
3856
3857 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3858
3859 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3860 concerns.
3861
3862 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3863
3864 * cm.c (calccost): Turn while-do into do-while, for clarity.
3865
3866 * keyboard.c (syms_of_keyboard): Use the same style as later
3867 in this function when indexing through an array. This also
3868 works around GCC bug 48267.
3869
3870 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3871
3872 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3873
3874 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3875 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3876
3877 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3878 This avoids undefined behavior on integer overflow, and is a bit
3879 more convenient anyway since it is compared to a size_t variable.
3880
3881 Variadic C functions now count arguments with size_t, not int.
3882 This avoids an unnecessary limitation on 64-bit machines, which
3883 caused (substring ...) to crash on large vectors (Bug#8344).
3884 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3885 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3886 All variadic functions and their callers changed accordingly.
3887 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3888 * data.c (arith_driver, float_arith_driver): Likewise.
3889 * editfns.c (general_insert_function): Likewise.
3890 * eval.c (struct backtrace.nargs, interactive_p)
3891 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3892 (funcall_lambda, mark_backtrace): Likewise.
3893 * fns.c (concat): Likewise.
3894 * frame.c (x_set_frame_parameters): Likewise.
3895 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3896 0 if not found, not -1. All callers changed.
3897
3898 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3899 (stack_copy_size): Now size_t, not int.
3900 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3901
3902 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3903
3904 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3905 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3906 All callers changed.
3907
3908 * lisp.h (multibyte_char_to_unibyte):
3909 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3910 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3911 * character.h (CHAR_TO_BYTE8):
3912 * cmds.c (internal_self_insert):
3913 * editfns.c (general_insert_function):
3914 * keymap.c (push_key_description):
3915 * search.c (Freplace_match):
3916 * xdisp.c (message_dolog, set_message_1): All callers changed.
3917
3918 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3919
3920 * keyboard.c (safe_run_hook_funcall): New function.
3921 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3922 don't set the hook to nil, but remove the offending function instead.
3923 (Qcommand_hook_internal): Remove, unused.
3924 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3925 Vcommand_hook_internal.
3926
3927 * eval.c (enum run_hooks_condition): Remove.
3928 (funcall_nil, funcall_not): New functions.
3929 (run_hook_with_args): Call each function through a `funcall' argument.
3930 Remove `cond' argument, now redundant.
3931 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3932 (Frun_hook_with_args_until_failure): Adjust accordingly.
3933 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3934
3935 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3936
3937 * dispextern.h (string_buffer_position): Remove declaration.
3938
3939 * print.c (strout): Remove parameter `multibyte', unused since
3940 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3941
3942 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3943 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3944 All callers changed.
3945
3946 * w32.c (_wsa_errlist): Use braces for struct initializers.
3947
3948 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3949 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3950 All callers changed.
3951 (string_buffer_position): Likewise. Also, make static (it's never
3952 used outside xdisp.c).
3953 (cursor_row_p): Remove parameter `w', unused since
3954 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3955 (decode_mode_spec): Remove parameter `precision', introduced during
3956 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3957 All callers changed.
3958
3959 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3960
3961 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3962
3963 2011-03-27 Anders Lindgren <andlind@gmail.com>
3964
3965 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3966 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3967 (ns_update_auto_hide_menu_bar): New functions.
3968 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3969 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3970 ns_constrain_all_frames.
3971 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3972 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3973
3974 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3975
3976 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3977
3978 2011-03-27 Glenn Morris <rgm@gnu.org>
3979
3980 * syssignal.h: Replace RETSIGTYPE with void.
3981 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3982 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3983 Replace SIGTYPE with void everywhere.
3984 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3985 * s/template.h (SIGTYPE): Remove commented out definition.
3986
3987 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3988
3989 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3990 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3991
3992 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3993
3994 * w32.c (read_unc_volume): Use parameter `henum', instead of
3995 global variable `wget_enum_handle'.
3996
3997 * keymap.c (describe_vector): Remove parameters `indices' and
3998 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3999 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4000
4001 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4002
4003 * keyboard.c (timer_check): Remove parameter `do_it_now',
4004 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4005 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4006 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4007
4008 * keyboard.c (read_char):
4009 * w32menu.c (w32_menu_display_help):
4010 * xmenu.c (show_help_event, menu_help_callback):
4011 Adjust calls to `show_help_echo'.
4012
4013 * gtkutil.c (xg_maybe_add_timer):
4014 * keyboard.c (readable_events):
4015 * process.c (wait_reading_process_output):
4016 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4017
4018 * insdel.c (adjust_markers_gap_motion):
4019 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4020 (gap_left, gap_right): Don't call it.
4021
4022 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4023
4024 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4025 incurred during fontification.
4026
4027 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4028
4029 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4030 (DEFVAR_PER_BUFFER): Don't pass it.
4031
4032 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4033 (scrolling_window): Don't pass it.
4034
4035 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4036
4037 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4038
4039 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4040 and `suffix'.
4041 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4042 of variables specific to SELinux and computation of `encoded_absname'.
4043
4044 * image.c (XPutPixel): Remove unused variable `height'.
4045
4046 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4047
4048 * unexw32.c (get_section_info): Remove unused variable `section'.
4049
4050 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4051 (system_process_attributes): Remove unused variable `sess'.
4052 (sys_read): Remove unused variable `err'.
4053
4054 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4055 (w32_wnd_proc): Remove unused variable `isdead'.
4056 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4057 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4058 (x_create_tip_frame): Remove unused variable `tem'.
4059
4060 * w32inevt.c (w32_console_read_socket):
4061 Remove unused variable `no_events'.
4062
4063 * w32term.c (x_draw_composite_glyph_string_foreground):
4064 Remove unused variable `width'.
4065
4066 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4067
4068 * w32term.c (x_set_glyph_string_clipping):
4069 Don't pass uninitialized region to CombineRgn.
4070
4071 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4072
4073 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4074 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4075 (Fx_close_connection): Remove unused variable `i'.
4076
4077 * w32font.c (w32font_draw): Return number of glyphs.
4078 (w32font_open_internal): Remove unused variable `i'.
4079 (w32font_driver): Add missing initializer.
4080
4081 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4082 (fill_in_menu): Remove unused variable `items_added'.
4083
4084 * w32term.c (last_mouse_press_frame): Remove static global variable.
4085 (w32_clip_to_row): Remove unused variable `f'.
4086 (x_delete_terminal): Remove unused variable `i'.
4087
4088 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4089 (NOTHING): Remove unused static global variable.
4090 (uniscribe_check_otf): Remove unused variable `table'.
4091 (uniscribe_font_driver): Add missing initializers.
4092
4093 2011-03-23 Julien Danjou <julien@danjou.info>
4094
4095 * term.c (Fsuspend_tty, Fresume_tty):
4096 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4097 * window.c (temp_output_buffer_show):
4098 * insdel.c (signal_before_change):
4099 * frame.c (Fhandle_switch_frame):
4100 * fileio.c (Fdo_auto_save):
4101 * emacs.c (Fkill_emacs):
4102 * editfns.c (save_excursion_restore):
4103 * cmds.c (internal_self_insert):
4104 * callint.c (Fcall_interactively):
4105 * buffer.c (Fkill_all_local_variables):
4106 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4107 Use Frun_hooks.
4108 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4109 unconditionnaly since it does the check itself.
4110
4111 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4112
4113 Fix more problems found by GCC 4.5.2's static checks.
4114
4115 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4116 the first time through the loop, since we know p0 < p1 then.
4117 This also avoids a gcc -Wstrict-overflow warning.
4118
4119 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4120 leading to a memory leak, possible in functions like
4121 load_charset_map_from_file that can allocate an unbounded number
4122 of objects (Bug#8318).
4123
4124 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4125 that could (at least in theory) be that large.
4126
4127 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4128 This is less likely to overflow, and avoids undefined behavior if
4129 overflow does occur. All callers changed. Use strtoul to scan
4130 for the unsigned long integer.
4131 (pint2hrstr): Simplify and tune code slightly.
4132 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4133
4134 * scroll.c (do_scrolling): Work around GCC bug 48228.
4135 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4136
4137 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4138 This also avoids a warning with gcc -Wstrict-overflow.
4139 (validate_x_resource_name): Simplify count usage.
4140 This also avoids a warning with gcc -Wstrict-overflow.
4141
4142 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4143 fail (Bug#8306).
4144
4145 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4146
4147 * process.c (Fmake_network_process): Use socklen_t, not int,
4148 where POSIX says socklen_t is required in portable programs.
4149 This fixes a porting bug on hosts like 64-bit HP-UX, where
4150 socklen_t is wider than int (Bug#8277).
4151 (Fmake_network_process, server_accept_connection):
4152 (wait_reading_process_output, read_process_output):
4153 Likewise.
4154
4155 * process.c: Rename or move locals to avoid shadowing.
4156 (list_processes_1, Fmake_network_process):
4157 (read_process_output_error_handler, exec_sentinel_error_handler):
4158 Rename or move locals.
4159 (Fmake_network_process): Define label "retry_connect" only if needed.
4160 (Fnetwork_interface_info): Fix pointer signedness.
4161 (process_send_signal): Add cast to avoid pointer signedness problem.
4162 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4163 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4164
4165 Make tparam.h and terminfo.c consistent.
4166 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4167 Include tparam.h instead, since it declares them.
4168 * cm.h (PC): Remove extern decl; tparam.h now does this.
4169 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4170 * terminfo.c: Include tparam.h, to check interfaces.
4171 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4172 (tparam): Adjust signature to match interface in tparam.h;
4173 this removes some undefined behavior. Check that outstring and len
4174 are zero, which they always are with Emacs.
4175 * tparam.h (PC, BC, UP): New extern decls.
4176
4177 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4178 (xftfont_open): Rename locals to avoid shadowing.
4179
4180 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4181 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4182 (OTF_TAG_SYM): Omit macro if not needed.
4183 (ftfont_list): Remove unused local.
4184 (get_adstyle_property, ftfont_pattern_entity):
4185 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4186 Rename locals to avoid shadowing.
4187
4188 * xfont.c (xfont_list_family): Mark var as initialized.
4189
4190 * xml.c (make_dom): Now static.
4191
4192 * composite.c (composition_compute_stop_pos): Rename local to
4193 avoid shadowing.
4194 (composition_reseat_it): Remove unused locals.
4195 (find_automatic_composition, composition_adjust_point): Likewise.
4196 (composition_update_it): Mark var as initialized.
4197 (find_automatic_composition): Mark vars as initialized,
4198 with a FIXME (Bug#8290).
4199
4200 character.h: Rename locals to avoid shadowing.
4201 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4202 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4203 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4204 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4205 to avoid shadowing.
4206
4207 * textprop.c (property_change_between_p): Remove; unused.
4208
4209 * intervals.c (interval_start_pos): Now static.
4210
4211 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4212
4213 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4214 Rename locals to avoid shadowing.
4215
4216 * sound.c (wav_play, au_play, Fplay_sound_internal):
4217 Fix pointer signedness.
4218 (alsa_choose_format): Remove unused local var.
4219 (wav_play): Initialize a variable to 0, to prevent undefined
4220 behavior (Bug#8278).
4221
4222 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4223
4224 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4225
4226 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4227 clobbering (Bug#8298).
4228 * sysdep.c (sys_subshell): Likewise.
4229 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4230
4231 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4232 This should get cleaned up, so that child_setup has the
4233 same signature on all platforms.
4234
4235 * callproc.c (call_process_cleanup): Now static.
4236 (relocate_fd): Rename locals to avoid shadowing.
4237
4238 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4239
4240 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4241 not to be necessary, and produces flickering.
4242
4243 2011-03-20 Glenn Morris <rgm@gnu.org>
4244
4245 * config.in: Remove file.
4246
4247 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4248
4249 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4250 are now in src/globals.h.
4251 (syms_of_minibuf): Remove spurious & from previous change.
4252
4253 2011-03-20 Leo <sdl.web@gmail.com>
4254
4255 * minibuf.c (completing-read-function): New variable.
4256 (completing-read-default): Rename from completing-read.
4257 (completing-read): Call completing-read-function.
4258
4259 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4260
4261 * xfaces.c (Fx_load_color_file):
4262 Read color file from absolute filename (bug#8250).
4263
4264 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4265
4266 * makefile.w32-in: Update dependencies.
4267
4268 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4269
4270 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4271
4272 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4273
4274 Fix more problems found by GCC 4.5.2's static checks.
4275
4276 * process.c (make_serial_process_unwind, send_process_trap):
4277 (sigchld_handler): Now static.
4278
4279 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4280 That way, the code declares only the vars that it needs.
4281 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4282 * s/cygwin.h (PTY_ITERATION): Likewise.
4283 * s/darwin.h (PTY_ITERATION): Likewise.
4284 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4285
4286 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4287 * process.c (allocate_pty): Don't declare stb unless it's needed.
4288
4289 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4290 (CONSTANTLIM): Remove; unused.
4291 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4292 Define only if needed.
4293
4294 * unexelf.c (unexec): Name an expression,
4295 to avoid gcc -Wbad-function-cast warning.
4296 Use a different way to cause a compilation error if anyone uses
4297 n rather than nn, a way that does not involve shadowing.
4298 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4299
4300 * deps.mk (unexalpha.o): Remove; unused.
4301
4302 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4303 * unexec.h: New file.
4304 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4305 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4306 Depend on unexec.h.
4307 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4308 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4309 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4310 Change as necessary to match prototype in unexec.h.
4311
4312 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4313 shadowing.
4314 (back_comment, skip_chars): Mark vars as initialized.
4315
4316 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4317 Rename locals to avoid shadowing.
4318
4319 * lread.c (read1): Rewrite so as not to use empty "else".
4320 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4321
4322 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4323
4324 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4325 warning when compiling print.c.
4326
4327 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4328 instead of using an uninitialized var.
4329 (font_sort_entities): Mark var as initialized.
4330
4331 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4332
4333 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4334 pointers to constants.
4335 (font_parse_fcname): Remove unused vars.
4336 (font_delete_unmatched): Now static.
4337 (font_get_spec): Remove; unused.
4338 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4339 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4340 Rename or move locals to avoid shadowing.
4341
4342 * fns.c (require_nesting_list, require_unwind): Now static.
4343 (Ffillarray): Rename locals to avoid shadowing.
4344
4345 * floatfns.c (domain_error2): Define only if needed.
4346 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4347
4348 * alloc.c (mark_backtrace): Move decl from here ...
4349 * lisp.h: ... to here, so that it can be checked.
4350
4351 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4352 (Fdefvar): Rewrite so as not to use empty "else".
4353 (lisp_indirect_variable): Name an expression,
4354 to avoid gcc -Wbad-function-cast warning.
4355 (Fdefvar): Rename locals to avoid shadowing.
4356
4357 * callint.c (quotify_arg, quotify_args): Now static.
4358 (Fcall_interactively): Rename locals to avoid shadowing.
4359 Use const pointer when appropriate.
4360
4361 * lisp.h (get_system_name, get_operating_system_release):
4362 Move decls here, to check interfaces.
4363 * process.c (get_operating_system_release): Move decl to lisp.h.
4364 * xrdb.c (get_system_name): Likewise.
4365 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4366 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4367 some of which prompt warnings from gcc -Wbad-function-cast.
4368 (Fformat_time_string, Fencode_time, Finsert_char):
4369 (Ftranslate_region_internal, Fformat):
4370 Rename or remove local vars to avoid shadowing.
4371 (Ftranslate_region_internal): Mark var as initialized.
4372
4373 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4374 avoid shadowing.
4375
4376 * lisp.h (eassert): Check that the argument compiles, even if
4377 ENABLE_CHECKING is not defined.
4378
4379 * data.c (Findirect_variable): Name an expression, to avoid
4380 gcc -Wbad-function-cast warning.
4381 (default_value, arithcompare, arith_driver, arith_error): Now static.
4382 (store_symval_forwarding): Rename local to avoid shadowing.
4383 (Fmake_variable_buffer_local, Fmake_local_variable):
4384 Mark variables as initialized.
4385 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4386
4387 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4388 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4389 Rename locals to avoid shadowing.
4390 (mark_stack): Move local variables into the #ifdef region where
4391 they're used.
4392 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4393 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4394 needed otherwise.
4395 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4396 (GC_STRING_CHARS): Remove; not used.
4397 (Fmemory_limit): Cast sbrk's returned value to char *.
4398
4399 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4400 avoids undefined behavior in theory.
4401
4402 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4403
4404 Use functions, not macros, for up- and down-casing (Bug#8254).
4405 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4406 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4407 to use the following functions instead of these macros.
4408 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4409 EMACS_INT, since callers assume the returned value fits in int.
4410 (upcase1): Likewise, for UPCASE_TABLE.
4411 (uppercasep, lowercasep, upcase): New static inline functions.
4412 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4413 the race-condition problem in the old DOWNCASE.
4414
4415 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4416 Rename locals to avoid shadowing.
4417 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4418 (regex_compile, re_search_2, re_match_2_internal):
4419 Remove unused local vars.
4420 (FREE_VAR): Rewrite so as not to use empty "else",
4421 which gcc can warn about.
4422 (regex_compile, re_match_2_internal): Mark locals as initialized.
4423 (RETALLOC_IF): Define only if needed.
4424 (WORDCHAR_P): Likewise. This one is never needed, but is used
4425 only in a comment talking about a compiler bug, so put inside
4426 the #if 0 of that comment.
4427 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4428 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4429 Remove; unused.
4430
4431 * search.c (boyer_moore): Rename locals to avoid shadowing.
4432 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4433 (PREV_CHAR_BOUNDARY): Likewise.
4434
4435 * search.c (simple_search): Remove unused var.
4436
4437 * dired.c (compile_pattern): Move decl from here ...
4438 * lisp.h: ... to here, so that it can be checked.
4439 (struct re_registers): New forward decl.
4440
4441 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4442
4443 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4444 All uses changed.
4445 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4446 Rename locals to avoid shadowing.
4447 (Fvertical_motion): Mark locals as initialized.
4448
4449 * casefiddle.c (casify_object, casify_region): Now static.
4450 (casify_region): Mark local as initialized.
4451
4452 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4453
4454 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4455 New macros, so that the caller can use some names other than
4456 gcpro1, gcpro2, etc.
4457 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4458 of the new macros.
4459 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4460 argument, for consistency with GCPRO2_VAR, etc: it is now the
4461 prefix of the variable, not the variable itself. All uses
4462 changed.
4463 * dired.c (directory_files_internal, file_name_completion):
4464 Rename locals to avoid shadowing.
4465
4466 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4467 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4468 dired.c's scmp function, had undefined behavior.
4469 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4470 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4471 * buffer.h: ... to here, because these macros use current_buffer,
4472 and the new implementation with inline functions needs to have
4473 current_buffer in scope now, rather than later when the macros
4474 are used.
4475 (downcase, upcase1): New static inline functions.
4476 (DOWNCASE, UPCASE1): Reimplement using these functions.
4477 This avoids undefined behavior in expressions like
4478 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4479 from race conditions in accessing the global variables
4480 case_temp1 and case_temp2.
4481 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4482 * lisp.h (case_temp1, case_temp2): Remove their decls.
4483 * character.h (ASCII_CHAR_P): Move from here ...
4484 * lisp.h: ... to here, so that the inline functions mentioned
4485 above can use them.
4486
4487 * dired.c (directory_files_internal_unwind): Now static.
4488
4489 * fileio.c (file_name_as_directory, directory_file_name):
4490 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4491 Now static.
4492 (file_name_as_directory): Use const pointers when appropriate.
4493 (Fexpand_file_name): Likewise. In particular, newdir might
4494 point at constant storage, so make it a const pointer.
4495 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4496 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4497 signedness issues.
4498 (Fset_file_times, Finsert_file_contents, auto_save_error):
4499 Rename locals to avoid shadowing.
4500
4501 * minibuf.c (choose_minibuf_frame_1): Now static.
4502 (Ftry_completion, Fall_completions): Rename or remove locals
4503 to avoid shadowing.
4504
4505 * marker.c (bytepos_to_charpos): Remove; unused.
4506
4507 * lisp.h (verify_bytepos, count_markers): New decls,
4508 so that gcc does not warn that these functions aren't declared.
4509
4510 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4511 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4512 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4513 (copy_text): Remove unused local var.
4514
4515 * filelock.c (within_one_second): Now static.
4516 (lock_file_1): Rename local to avoid shadowing.
4517
4518 * buffer.c (fix_overlays_before): Mark locals as initialized.
4519 (fix_start_end_in_overlays): Likewise. This function should be
4520 simplified by using pointers-to-pointers, but that's a different
4521 matter.
4522 (switch_to_buffer_1): Now static.
4523 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4524 (report_overlay_modification): Rename locals to avoid shadowing.
4525
4526 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4527 Fix pointer signedness issue.
4528 (sys_subshell): Mark local as volatile if checking for lint,
4529 to suppress a gcc -Wclobbered warning that does not seem to be right.
4530 (MAXPATHLEN): Define only if needed.
4531
4532 * process.c (serial_open, serial_configure): Move decls from here ...
4533 * systty.h: ... to here, so that they can be checked.
4534
4535 * fns.c (get_random, seed_random): Move extern decls from here ...
4536 * lisp.h: ... to here, so that they can be checked.
4537
4538 * sysdep.c (reset_io): Now static.
4539 (wait_for_termination_signal): Remove; unused.
4540
4541 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4542 (copy_keymap_item, append_key, push_text_char_description):
4543 Now static.
4544 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4545 (DENSE_TABLE_SIZE): Remove; unused.
4546 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4547 (describe_map_tree):
4548 Rename locals to avoid shadowing.
4549
4550 * keyboard.c: Declare functions static if they are not used elsewhere.
4551 (echo_char, echo_dash, cmd_error, top_level_2):
4552 (poll_for_input, handle_async_input): Now static.
4553 (read_char, kbd_buffer_get_event, make_lispy_position):
4554 (make_lispy_event, make_lispy_movement, apply_modifiers):
4555 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4556 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4557 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4558 (read_key_sequence, read_char): Mark locals as initialized.
4559 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4560
4561 * keyboard.h (make_ctrl_char): New decl.
4562 (mark_kboards): Move decl here ...
4563 * alloc.c (mark_kboards): ... from here.
4564
4565 * lisp.h (force_auto_save_soon): New decl.
4566
4567 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4568 (DEFINE_DUMMY_FUNCTION): New macro.
4569 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4570 Use it.
4571 (main): Add casts to avoid warnings
4572 if GCC considers string literals to be constants.
4573
4574 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4575
4576 * dbusbind.c: Pointer signedness fixes.
4577 (xd_signature, xd_append_arg, xd_initialize):
4578 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4579 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4580 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4581 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4582
4583 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4584 if GCC considers string literals to be constants.
4585 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4586
4587 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4588
4589 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4590 (print_preprocess, print_object): New macro to fix last change.
4591
4592 * print.c (print_preprocess): Don't forget font objects.
4593
4594 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4595
4596 * emacs.c (USAGE3): Doc fixes.
4597
4598 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4599
4600 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4601 structure.
4602
4603 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4604
4605 * lisp.h (VWindow_system, Qfile_name_history):
4606 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4607 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4608 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4609
4610 * w32select.c: Don't #include "keyboard.h".
4611 (run_protected): Add extern declaration for waiting_for_input.
4612
4613 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4614 * w32console.c (detect_input_pending, read_input_pending)
4615 (encode_terminal_code):
4616 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4617 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4618 (w32_system_caret_y, Qfile_name_history):
4619 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4620 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4621 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4622 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4623 * w32proc.c (Qlocal, report_file_error):
4624 * w32term.c (Vwindow_system, updating_frame):
4625 * w32uniscribe.c (initialized, uniscribe_font_driver):
4626 Remove unneeded extern declarations.
4627
4628 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4629
4630 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4631
4632 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4633
4634 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4635 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4636 These macros can no longer be used for assignment.
4637
4638 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4639 Assign struct members directly, instead of using BUF_BEGV etc.
4640 (record_buffer_markers, fetch_buffer_markers): New functions for
4641 recording and fetching special buffer markers.
4642 (set_buffer_internal_1, set_buffer_temp): Use them.
4643
4644 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4645
4646 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4647
4648 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4649 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4650
4651 * xdisp.c (hscroll_window_tree):
4652 (reconsider_clip_changes): Use PT instead of BUF_PT.
4653
4654 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4655
4656 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4657 $(EMACS_ROOT)/lib/intprops.h.
4658
4659 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4660
4661 Fix more problems found by GCC 4.5.2's static checks.
4662
4663 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4664 to unsigned char * to avoid compiler diagnostic.
4665 (xg_free_frame_widgets): Make it clear that a local variable is
4666 needed only if USE_GTK_TOOLTIP.
4667 (gdk_window_get_screen): Make it clear that this macro is needed
4668 only if USE_GTK_TOOLTIP.
4669 (int_gtk_range_get_value): New function, which avoids a diagnostic
4670 from gcc -Wbad-function-cast.
4671 (xg_set_toolkit_scroll_bar_thumb): Use it.
4672 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4673 diagnostic from gcc -Wbad-function-cast.
4674 (get_utf8_string, xg_get_file_with_chooser):
4675 Rename locals to avoid shadowing.
4676 (create_dialog): Move locals to avoid shadowing.
4677
4678 * xgselect.c (xg_select): Remove unused var.
4679
4680 * image.c (four_corners_best): Mark locals as initialized.
4681 (gif_load): Initialize transparent_p to zero (Bug#8238).
4682 Mark another local as initialized.
4683 (my_png_error, my_error_exit): Mark with NO_RETURN.
4684
4685 * image.c (clear_image_cache): Now static.
4686 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4687 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4688 (x_edge_detection): Remove unnecessary cast that
4689 gcc -Wbad-function-cast diagnoses.
4690 (gif_load): Fix pointer signedness.
4691 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4692 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4693
4694 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4695
4696 Improve quality of tests for time stamp overflow.
4697 For example, without this patch (encode-time 0 0 0 1 1
4698 1152921504606846976) returns the obviously-bogus value (-948597
4699 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4700 reports time overflow. See
4701 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4702 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4703 * editfns.c: Include limits.h and intprops.h.
4704 (TIME_T_MIN, TIME_T_MAX): New macros.
4705 (time_overflow): Move earlier, to before first use.
4706 (hi_time, lo_time): New functions, for an accurate test for
4707 out-of-range times.
4708 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4709 (Fget_internal_run_time): Don't assume time_t fits in int.
4710 (make_time): Use list2 instead of Fcons twice.
4711 (Fdecode_time): More accurate test for out-of-range times.
4712 (check_tm_member): New function.
4713 (Fencode_time): Use it, to test for out-of-range times.
4714 (lisp_time_argument): Don't rely on undefined left-shift and
4715 right-shift behavior when checking for time stamp overflow.
4716
4717 * editfns.c (time_overflow): New function, refactoring common code.
4718 (Fformat_time_string, Fdecode_time, Fencode_time):
4719 (Fcurrent_time_string): Use it.
4720
4721 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4722 * dired.c (make_time): Move to ...
4723 * editfns.c (make_time): ... here.
4724 * systime.h: Note the move.
4725
4726 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4727
4728 * fringe.c (update_window_fringes): Remove unused variables.
4729
4730 * unexmacosx.c (copy_data_segment): Also copy __got section.
4731 (Bug#8223)
4732
4733 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4734
4735 * termcap.c [MSDOS]: Include "msdos.h".
4736 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4737 Constify `char *' arguments and their references according to
4738 prototypes in tparam.h.
4739
4740 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4741
4742 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4743 Adapt all references accordingly.
4744
4745 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4746
4747 2011-03-11 Tom Tromey <tromey@redhat.com>
4748
4749 * buffer.c (syms_of_buffer): Remove obsolete comment.
4750
4751 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4752
4753 * termhooks.h (encode_terminal_code): Declare prototype.
4754
4755 * msdos.c (encode_terminal_code): Don't declare prototype.
4756
4757 * term.c (encode_terminal_code): Now external again, used by
4758 w32console.c and msdos.c.
4759
4760 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4761 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4762
4763 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4764
4765 Fix some minor problems found by GCC 4.5.2's static checks.
4766
4767 * fringe.c (update_window_fringes): Mark locals as initialized
4768 (Bug#8227).
4769 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4770
4771 * alloc.c (mark_fringe_data): Move decl from here ...
4772 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4773 to check its interface.
4774 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4775
4776 * fontset.c (free_realized_fontset): Now static.
4777 (Fset_fontset_font): Rename local to avoid shadowing.
4778 (fontset_font): Mark local as initialized.
4779 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4780
4781 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4782
4783 * xselect.c (x_disown_buffer_selections): Remove; not used.
4784 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4785 (x_own_selection, Fx_disown_selection_internal): Rename locals
4786 to avoid shadowing.
4787 (x_handle_dnd_message): Remove local to avoid shadowing.
4788
4789 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4790 so that the caller can use some name other than gcpro1.
4791 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4792 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4793 (Fx_backspace_delete_keys_p):
4794 Use them to avoid shadowing, and rename vars to avoid shadowing.
4795 (x_decode_color, x_set_name, x_window): Now static.
4796 (Fx_create_frame): Add braces to silence GCC warning.
4797 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4798 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4799 Remove unused locals.
4800 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4801 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4802 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4803 macros.
4804
4805 * xterm.h (x_mouse_leave): New decl.
4806
4807 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4808 Remove unused functions.
4809 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4810 (x_calc_absolute_position): Now static.
4811 (XTread_socket): Don't define label "out" unless it's used.
4812 Don't declare local "event" unless it's used.
4813 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4814 unless they are used.
4815 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4816 (x_fatal_error_signal): Remove; not used.
4817 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4818 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4819 (x_error_catcher, x_connection_closed, x_error_handler):
4820 (x_error_quitter, xembed_send_message, x_iconify_frame):
4821 (my_log_handler): Rename locals to avoid shadowing.
4822 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4823 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4824
4825 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4826 Rename or move locals to avoid shadowing.
4827 (tty_defined_color, merge_face_heights): Now static.
4828 (free_realized_faces_for_fontset): Remove; not used.
4829 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4830 does not deduce is never used uninitialized.
4831 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4832 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4833
4834 * terminal.c (store_terminal_param): Now static.
4835
4836 * xmenu.c (menu_highlight_callback): Now static.
4837 (set_frame_menubar): Remove unused local.
4838 (xmenu_show): Rename parameter to avoid shadowing.
4839 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4840 since they might point to immutable storage.
4841 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4842 since it's unused otherwise.
4843
4844 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4845 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4846 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4847 avoids a gcc -Wuninitialized diagnostic.
4848 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4849 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4850 does not deduce are never used uninitialized.
4851
4852 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4853
4854 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4855 * window.c (window_loop, size_window):
4856 (run_window_configuration_change_hook, enlarge_window): Likewise.
4857
4858 * window.c (display_buffer): Now static.
4859 (size_window): Mark variables that gcc -Wuninitialized
4860 does not deduce are never used uninitialized.
4861 * window.h (check_all_windows): New decl, to forestall
4862 gcc -Wmissing-prototypes diagnostic.
4863 * dispextern.h (bidi_dump_cached_states): Likewise.
4864
4865 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4866 shadowing.
4867 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4868 Include <limits.h>.
4869 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4870 and to avoid gcc -Wuninitialized warning.
4871 (load_charset_map): Mark variables that gcc -Wuninitialized
4872 does not deduce are never used uninitialized.
4873 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4874
4875 * coding.c (coding_set_source, coding_set_destination):
4876 Use "else { /* comment */ }" rather than "else /* comment */;"
4877 for clarity, and to avoid gcc -Wempty-body warning.
4878 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4879 a block, when the outer 'i' will do.
4880 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4881 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4882 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4883 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4884 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4885 Rename locals to avoid shadowing.
4886 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4887 * coding.c (emacs_mule_char, encode_invocation_designation):
4888 Now static, since they're not used elsewhere.
4889 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4890 (decode_coding_object, encode_coding_object, detect_coding_system):
4891 (decode_coding_emacs_mule): Mark variables that gcc
4892 -Wuninitialized does not deduce are never used uninitialized.
4893 (detect_coding_iso_2022): Initialize a local variable that might
4894 be used uninitialized. Leave a FIXME because it's not clear that
4895 this initialization is needed. (Bug#8211)
4896 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4897 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4898 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4899 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4900 Remove unused macros.
4901
4902 * category.c (hash_get_category_set): Remove unused local var.
4903 (copy_category_table): Now static, since it's not used elsewhere.
4904 * character.c (string_count_byte8): Likewise.
4905
4906 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4907 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4908
4909 * chartab.c (copy_sub_char_table): Now static, since it's not used
4910 elsewhere.
4911 (sub_char_table_ref_and_range, char_table_ref_and_range):
4912 Rename locals to avoid shadowing.
4913 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4914
4915 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4916 (BIDI_BOB): Remove unused macro.
4917
4918 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4919 deduce are never used uninitialized.
4920 * term.c (encode_terminal_code): Likewise.
4921
4922 * term.c (encode_terminal_code): Now static. Remove unused local.
4923
4924 * tparam.h: New file.
4925 * term.c, tparam.h: Include it.
4926 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4927 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4928 Move these decls to tparam.h, and make them agree with what
4929 is actually in tparam.c. The previous trick of using incompatible
4930 decls in different modules does not conform to the C standard.
4931 All callers of tparam changed to use tparam's actual API.
4932 * tparam.c (tparam1, tparam, tgoto):
4933 Use const pointers where appropriate.
4934
4935 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4936 * cm.h (struct cm): Likewise.
4937 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4938 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4939 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4940 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4941 (turn_on_face, init_tty): Likewise.
4942 * termchar.h (struct tty_display_info): Likewise.
4943
4944 * term.c (term_mouse_position): Rename local to avoid shadowing.
4945
4946 * alloc.c (mark_ttys): Move decl from here ...
4947 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4948
4949 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4950
4951 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4952
4953 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4954
4955 * search.c (compile_pattern_1): Remove argument regp, unused since
4956 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4957 (compile_pattern): Don't pass it.
4958
4959 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4960
4961 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4962 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4963 for ! HAVE_GTK3.
4964 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4965
4966 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4967
4968 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4969 gdk_window_get_screen, gdk_window_get_geometry,
4970 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4971 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4972 (xg_get_pixbuf_from_pixmap): New function.
4973 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4974 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4975 Call xg_get_pixbuf_from_pixmap instead of
4976 gdk_pixbuf_get_from_drawable.
4977 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4978 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4979 (xg_check_special_colors): Use GtkStyleContext and its functions
4980 for HAVE_GTK3.
4981 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4982 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4983 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4984 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4985 Call gtk_widget_get_preferred_size.
4986 (xg_frame_resized): gdk_window_get_geometry only takes 5
4987 parameters.
4988 (xg_win_to_widget, xg_event_is_for_menubar):
4989 Call gdk_x11_window_lookup_for_display.
4990 (xg_set_widget_bg): New function.
4991 (delete_cb): New function.
4992 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4993 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4994 (xg_set_background_color): Call xg_set_widget_bg.
4995 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4996 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4997 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4998 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4999 if ! HAVE_GTK3.
5000 (update_frame_tool_bar): Call gtk_widget_hide.
5001 (xg_initialize): Use GDK_KEY_g.
5002
5003 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5004 if ! HAVE_GTK3
5005 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5006
5007 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5008 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5009 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5010
5011 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5012
5013 * w32xfns.c (select_palette): Check success of RealizePalette against
5014 GDI_ERROR, not zero.
5015
5016 See ChangeLog.11 for earlier changes.
5017
5018 ;; Local Variables:
5019 ;; coding: utf-8
5020 ;; End:
5021
5022 Copyright (C) 2011 Free Software Foundation, Inc.
5023
5024 This file is part of GNU Emacs.
5025
5026 GNU Emacs is free software: you can redistribute it and/or modify
5027 it under the terms of the GNU General Public License as published by
5028 the Free Software Foundation, either version 3 of the License, or
5029 (at your option) any later version.
5030
5031 GNU Emacs is distributed in the hope that it will be useful,
5032 but WITHOUT ANY WARRANTY; without even the implied warranty of
5033 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5034 GNU General Public License for more details.
5035
5036 You should have received a copy of the GNU General Public License
5037 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.