]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Merge from emacs-23 branch
[gnu-emacs] / src / ChangeLog
1 2011-07-07 Kenichi Handa <handa@m17n.org>
2
3 * composite.c (composition_compute_stop_pos): Ignore a static
4 composition starting before CHARPOS (Bug#8915).
5
6 * xdisp.c (handle_composition_prop): Likewise.
7
8 2011-07-07 Eli Zaretskii <eliz@gnu.org>
9
10 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
11 (Bug#9015)
12
13 2011-07-07 Kenichi Handa <handa@m17n.org>
14
15 * character.h (unicode_category_t): New enum type.
16
17 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
18 (Qchar_code_property_table): New variable.
19 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
20 (UNIPROP_COMPRESSED_FORM_P): New macros.
21 (char_table_ascii): Uncompress the compressed values.
22 (sub_char_table_ref): New arg is_uniprop. Callers changed.
23 Uncompress the compressed values.
24 (sub_char_table_ref_and_range): Likewise.
25 (char_table_ref_and_range): Uncompress the compressed values.
26 (sub_char_table_set): New arg is_uniprop. Callers changed.
27 Uncompress the compressed values.
28 (sub_char_table_set_range): Args changed. Callers changed.
29 (char_table_set_range): Adjuted for the above change.
30 (map_sub_char_table): Delete args default_val and parent. Add arg
31 top. Give decoded values to a Lisp function.
32 (map_char_table): Adjusted for the above change. Give decoded
33 values to a Lisp function. Gcpro more variables.
34 (uniprop_table_uncompress)
35 (uniprop_decode_value_run_length): New functions.
36 (uniprop_decoder, uniprop_decoder_count): New variables.
37 (uniprop_get_decoder, uniprop_encode_value_character)
38 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
39 New functions.
40 (uniprop_encoder, uniprop_encoder_count): New variables.
41 (uniprop_get_encoder, uniprop_table)
42 (Funicode_property_table_internal, Fget_unicode_property_internal)
43 (Fput_unicode_property_internal): New functions.
44 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
45 Sunicode_property_table_internal, Sget_unicode_property_internal,
46 and Sput_unicode_property_internal. Defvar_lisp
47 char-code-property-alist.
48
49 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
50 Vunicode_category_table.
51
52 * font.c (font_range): Adjusted for the change of
53 Vunicode_category_table.
54
55 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
56
57 * m/iris4d.h: Remove file, move contents ...
58 * s/irix6-5.h: ... here.
59
60 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
61
62 Remove unportable assumption about struct layout (Bug#8884).
63 * alloc.c (mark_buffer):
64 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
65 (clone_per_buffer_values): Don't assume that
66 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
67 This isn't true in general, and it's particularly not true
68 if Emacs is configured with --with-wide-int.
69 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
70 New macros, used in the buffer.c change.
71
72 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
73
74 * xsettings.c: Use both GConf and GSettings if both are available.
75 (store_config_changed_event): Add comment.
76 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
77 (store_tool_bar_style_changed): New functions.
78 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
79 (struct xsettings): Move font inside HAVE_XFT.
80 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
81 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
82 Move inside HAVE_XFT.
83 (something_changed_gsettingsCB): Renamed from something_changedCB.
84 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
85 also.
86 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
87 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
88 (something_changed_gconfCB): Renamed from something_changedCB.
89 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
90 (parse_settings): Move check for font inside HAVE_XFT.
91 (read_settings, apply_xft_settings): Add comment.
92 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
93 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
94 call store_font_name_changed.
95 (xft_settings_event): Add comment.
96 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
97 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
98 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
99 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
100 (xsettings_initialize): Call init_gsettings last.
101 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
102 comment.
103
104 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
105
106 Random fixes. E.g., (random) never returned negative values.
107 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
108 subseconds part to the entropy, as that's a bit more random.
109 Prefer signed to unsigned, since the signedness doesn't matter and
110 in general we prefer signed. When given a limit, use a
111 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
112 latter isn't right if USE_2_TAGS_FOR_INTS.
113 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
114 not 0..VALMASK. Don't discard "excess" bits that random () returns.
115
116 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
117
118 * textprop.c (text_property_stickiness):
119 Obey Vtext_property_default_nonsticky.
120 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
121 * w32fns.c (syms_of_w32fns):
122 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
123
124 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
125
126 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
127 This is more efficient than Ffile_directory_p and avoids a minor race.
128
129 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
130
131 * buffer.c (Foverlay_put): Say what the return value is
132 (bug#7835).
133
134 * fileio.c (barf_or_query_if_file_exists): Check first if the file
135 is a directory before asking whether to use the file name
136 (bug#7564).
137 (barf_or_query_if_file_exists): Make the "File is a directory"
138 error be more correct.
139
140 * fns.c (Frequire): Remove the mention of the .gz files, since
141 that's installation-specific, but keep the mention of
142 `get-load-suffixes'.
143
144 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
145
146 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
147 Report string overflow if the output is too long.
148
149 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
150
151 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
152 (syms_of_gnutls): Remove duplicate DEFSYM for
153 Qgnutls_bootprop_verify_hostname_error, an error for
154 Qgnutls_bootprop_verify_error (which is no longer used).
155
156 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
157 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
158 Also (re)move comments that are misplaced or no longer relevant.
159
160 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
161
162 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
163
164 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
165
166 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
167 and background color parameters if they have been changed.
168
169 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
170
171 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
172
173 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
174
175 * xsettings.c (SYSTEM_FONT): Define only when used.
176 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
177
178 * keymap.c (access_keymap_1): Now static.
179
180 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
181
182 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
183 leave any prefix arg for the up event (Bug#1586).
184
185 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
186
187 * lread.c (syms_of_lread): Mention single symbols defined by
188 `defvar' or `defconst' (bug#7154).
189
190 * fns.c (Frequire): Mention .el.gz files (bug#7314).
191 (Frequire): Mention get-load-suffixes.
192
193 2011-07-02 Martin Rudalics <rudalics@gmx.at>
194
195 * window.h (window): Remove clone_number slot.
196 * window.c (Fwindow_clone_number, Fset_window_clone_number):
197 Remove.
198 (make_parent_window, make_window, saved_window)
199 (Fset_window_configuration, save_window_save): Don't deal with
200 clone numbers.
201 * buffer.c (Qclone_number): Remove declaration.
202 (sort_overlays, overlay_strings): Don't deal with clone numbers.
203
204 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
205
206 Add multiple inheritance to keymaps.
207 * keymap.c (Fmake_composed_keymap): New function.
208 (Fset_keymap_parent): Simplify.
209 (fix_submap_inheritance): Remove.
210 (access_keymap_1): New function extracted from access_keymap to handle
211 embedded parents and handle lists of maps.
212 (access_keymap): Use it.
213 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
214 (Fcopy_keymap): Handle embedded parents.
215 (Fcommand_remapping, define_as_prefix): Simplify.
216 (Fkey_binding): Simplify.
217 (syms_of_keymap): Move minibuffer-local-completion-map,
218 minibuffer-local-filename-completion-map,
219 minibuffer-local-must-match-map, and
220 minibuffer-local-filename-must-match-map to Elisp.
221 (syms_of_keymap): Defsubr make-composed-keymap.
222 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
223 (parse_menu_item): Trivial simplification.
224
225 2011-07-01 Glenn Morris <rgm@gnu.org>
226
227 * Makefile.in (SETTINGS_LIBS): Fix typo.
228
229 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
230
231 * coding.c (Fencode_coding_string): Record the last coding system
232 used, as the function doc string says (bug#8738).
233
234 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
235
236 * xsettings.c (store_monospaced_changed): Take new font as arg and
237 check for change against current_mono_font.
238 (EMACS_TYPE_SETTINGS): Remove this and related defines.
239 (emacs_settings_constructor, emacs_settings_get_property)
240 (emacs_settings_set_property, emacs_settings_class_init)
241 (emacs_settings_init, gsettings_obj): Remove.
242 (something_changedCB): New function for HAVE_GSETTINGS.
243 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
244 with value as argument.
245 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
246 g_settings_new (Bug#8967). Do not create gsettings_obj.
247 Remove calls to g_settings_bind. Connect something_changedCB to
248 "changed".
249
250 * xgselect.c: Add defined (HAVE_GSETTINGS).
251 (xgselect_initialize): Ditto.
252
253 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
254 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
255 xg_select.
256
257 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
258
259 * eval.c (struct backtrace): Simplify and port the data structure.
260 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
261 signed bit field, as this assumption is not portable and it makes
262 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
263 "char debug_on_exit : 1" as this is not portable either; instead,
264 use the portable "unsigned int debug_on_exit : 1". Remove unused
265 member evalargs. Remove obsolete comments about cc bombing out.
266
267 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
268
269 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
270 Let HAVE_GSETTINGS override HAVE_GCONF.
271 (store_monospaced_changed): New function.
272 (EMACS_SETTINGS): A new type derived from GObject to handle
273 GSettings notifications.
274 (emacs_settings_constructor, emacs_settings_get_property)
275 (emacs_settings_set_property, emacs_settings_class_init):
276 New functions.
277 (gsettings_client, gsettings_obj): New variables.
278 (GSETTINGS_SCHEMA): New define.
279 (something_changedCB): Call store_monospaced_changed.
280 (init_gsettings): New function.
281 (xsettings_initialize): Call init_gsettings.
282 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
283 to NULL.
284
285 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
286 GCONF_CFLAGS/LIBS.
287
288 2011-06-29 Martin Rudalics <rudalics@gmx.at>
289
290 * window.c (resize_root_window, grow_mini_window)
291 (shrink_mini_window): Rename Qresize_root_window to
292 Qwindow_resize_root_window and Qresize_root_window_vertically to
293 Qwindow_resize_root_window_vertically.
294
295 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
296
297 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
298
299 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
300
301 * makefile.w32-in: Redesign dependencies so they reflect more
302 clearly which files are directly included by each source file,
303 and not through other includes.
304
305 2011-06-27 Martin Rudalics <rudalics@gmx.at>
306
307 * buffer.c (Qclone_number): Declare static and DEFSYM it.
308 (sort_overlays, overlay_strings): When an overlay's clone number
309 matches the window's clone number process the overlay even if
310 the overlay's window property doesn't match the current window.
311
312 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
313 (Fwindow_hchild): Rename to Fwindow_left_child.
314 (Fwindow_next): Rename to Fwindow_next_sibling.
315 (Fwindow_prev): Rename to Fwindow_prev_sibling.
316 (resize_window_check): Rename to window_resize_check.
317 (resize_window_apply): Rename to window_resize_apply.
318 (Fresize_window_apply): Rename to Fwindow_resize_apply.
319 (Fdelete_other_windows_internal, resize_frame_windows)
320 (Fsplit_window_internal, Fdelete_window_internal)
321 (grow_mini_window, shrink_mini_window)
322 (Fresize_mini_window_internal): Fix callers accordingly.
323
324 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
325
326 * emacsgtkfixed.h: State that this is only used with Gtk+3.
327 (emacs_fixed_set_min_size): Remove.
328 (emacs_fixed_new): Take frame as argument.
329
330 * emacsgtkfixed.c: State that this is only used with Gtk+3.
331 (_EmacsFixedPrivate): Remove minwidth/height.
332 Add struct frame *f.
333 (emacs_fixed_init): Initialize priv->f.
334 (get_parent_class, emacs_fixed_set_min_size): Remove.
335 (emacs_fixed_new): Set priv->f to argument.
336 (emacs_fixed_get_preferred_width)
337 (emacs_fixed_get_preferred_height): Use min_width/height from
338 frames size_hint to set minimum and natural (Bug#8919).
339 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
340 and use min_width/height from frames size_hint to set
341 min_width/height (Bug#8919).
342
343 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
344 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
345 Fix indentation.
346
347 2011-06-26 Eli Zaretskii <eliz@gnu.org>
348
349 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
350 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
351 called at ZV.
352
353 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
354
355 * process.c (wait_reading_process_output): Bypass select if
356 waiting for a cell while ignoring keyboard input, and input is
357 pending. Suggested by Jan Djärv (Bug#8869).
358
359 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
360
361 Use gnulib's dup2 module instead of rolling our own.
362 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
363
364 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
365
366 * dispnew.c (scrolling_window): Before scrolling, turn off a
367 mouse-highlight in the window being scrolled.
368
369 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
370
371 Move DEFSYM to lisp.h and use everywhere.
372
373 * character.h (DEFSYM): Move declaration...
374 * lisp.h (DEFSYM): ...here.
375
376 * gnutls.c:
377 * minibuf.c:
378 * w32menu.c:
379 * w32proc.c:
380 * w32select.c: Don't include character.h.
381
382 * alloc.c (syms_of_alloc):
383 * buffer.c (syms_of_buffer):
384 * bytecode.c (syms_of_bytecode):
385 * callint.c (syms_of_callint):
386 * casefiddle.c (syms_of_casefiddle):
387 * casetab.c (init_casetab_once):
388 * category.c (init_category_once, syms_of_category):
389 * ccl.c (syms_of_ccl):
390 * cmds.c (syms_of_cmds):
391 * composite.c (syms_of_composite):
392 * dbusbind.c (syms_of_dbusbind):
393 * dired.c (syms_of_dired):
394 * dispnew.c (syms_of_display):
395 * doc.c (syms_of_doc):
396 * editfns.c (syms_of_editfns):
397 * emacs.c (syms_of_emacs):
398 * eval.c (syms_of_eval):
399 * fileio.c (syms_of_fileio):
400 * fns.c (syms_of_fns):
401 * frame.c (syms_of_frame):
402 * fringe.c (syms_of_fringe):
403 * insdel.c (syms_of_insdel):
404 * keymap.c (syms_of_keymap):
405 * lread.c (init_obarray, syms_of_lread):
406 * macros.c (syms_of_macros):
407 * msdos.c (syms_of_msdos):
408 * print.c (syms_of_print):
409 * process.c (syms_of_process):
410 * search.c (syms_of_search):
411 * sound.c (syms_of_sound):
412 * syntax.c (init_syntax_once, syms_of_syntax):
413 * terminal.c (syms_of_terminal):
414 * textprop.c (syms_of_textprop):
415 * undo.c (syms_of_undo):
416 * w32.c (globals_of_w32):
417 * window.c (syms_of_window):
418 * xdisp.c (syms_of_xdisp):
419 * xfaces.c (syms_of_xfaces):
420 * xfns.c (syms_of_xfns):
421 * xmenu.c (syms_of_xmenu):
422 * xsettings.c (syms_of_xsettings):
423 * xterm.c (syms_of_xterm): Use DEFSYM.
424
425 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
426
427 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
428
429 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
430
431 Integer and buffer overflow fixes (Bug#8873).
432
433 * print.c (printchar, strout): Check for string overflow.
434 (PRINTPREPARE, printchar, strout):
435 Don't set size unless allocation succeeds.
436
437 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
438 for sizes. Check for string overflow more accurately.
439 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
440
441 * macros.c: Integer and buffer overflow fixes.
442 * keyboard.h (struct keyboard.kbd_macro_bufsize):
443 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
444 Use ptrdiff_t, not int, for sizes.
445 Don't increment bufsize until after realloc succeeds.
446 Check for size-calculation overflow.
447 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
448
449 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
450
451 * lread.c: Integer overflow fixes.
452 (read_integer): Radix is now EMACS_INT, not int,
453 to improve quality of diagnostics for out-of-range radices.
454 Calculate buffer size correctly for out-of-range radices.
455 (read1): Check for integer overflow in radices, and in
456 read-circle numbers.
457 (read_escape): Avoid int overflow.
458 (Fload, openp, read_buffer_size, read1)
459 (substitute_object_recurse, read_vector, read_list, map_obarray):
460 Use ptrdiff_t, not int, for sizes.
461 (read1): Use EMACS_INT, not int, for sizes.
462 Check for size overflow.
463
464 * image.c (cache_image): Check for size arithmetic overflow.
465
466 * lread.c: Integer overflow issues.
467 (saved_doc_string_size, saved_doc_string_length)
468 (prev_saved_doc_string_size, prev_saved_doc_string_length):
469 Now ptrdiff_t, not int.
470 (read1): Don't assume doc string length fits in int. Check for
471 out-of-range doc string lengths.
472 (read_list): Don't assume file position fits in int.
473 (read_escape): Check for hex character overflow.
474
475 2011-06-22 Leo Liu <sdl.web@gmail.com>
476
477 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
478 Move to minibuffer.el.
479
480 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
481
482 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
483 The following patches are for when GLYPH_DEBUG && !XASSERT.
484 * dispextern.h (trace_redisplay_p, dump_glyph_string):
485 * dispnew.c (flush_stdout):
486 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
487 Mark as externally visible.
488 * dispnew.c (check_window_matrix_pointers): Now static.
489 * dispnew.c (window_to_frame_vpos):
490 * xfns.c (unwind_create_frame):
491 * xterm.c (x_check_font): Remove unused local.
492 * scroll.c (CHECK_BOUNDS):
493 * xfaces.c (cache_fache): Rename local to avoid shadowing.
494 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
495 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
496 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
497 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
498 Now static.
499 (debug_method_add): Use va_list and vsprintf rather than relying
500 on undefined behavior with wrong number of arguments.
501 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
502 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
503 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
504 since we're not interested in debugging glyphs with old libraries.
505 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
506 GCC 4.6.0's static checking.
507
508 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
509
510 Integer overflow and signedness fixes (Bug#8873).
511 A few related buffer overrun fixes, too.
512
513 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
514
515 * dispextern.h (struct face.stipple):
516 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
517 (x_bitmap_mask, x_allocate_bitmap_record)
518 (x_create_bitmap_from_data, x_create_bitmap_from_file)
519 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
520 (x_create_bitmap_from_xpm_data):
521 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
522 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
523 (.bitmaps_last):
524 * xfaces.c (load_pixmap):
525 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
526 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
527 (.bitmaps_last, struct x_output.icon_bitmap):
528 Use ptrdiff_t, not int, for bitmap indexes.
529 (x_allocate_bitmap_record): Check for size overflow.
530 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
531
532 Use ptrdiff_t, not int, for overlay counts.
533 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
534 * editfns.c (overlays_around, get_pos_property):
535 * textprop.c (get_char_property_and_overlay):
536 * xdisp.c (next_overlay_change, note_mouse_highlight):
537 * xfaces.c (face_at_buffer_position):
538 * buffer.c (OVERLAY_COUNT_MAX): New macro.
539 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
540 (Fnext_overlay_change, Fprevious_overlay_change)
541 (mouse_face_overlay_overlaps, Foverlays_in):
542 Use ptrdiff_t, not int, for sizes.
543 (overlays_at, overlays_in): Check for size-calculation overflow.
544
545 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
546
547 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
548 (x_session_initialize): Do not assume string length fits in int.
549
550 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
551 This is unlikely, but can occur if DPI is outlandish.
552
553 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
554 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
555
556 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
557 * xrdb.c (magic_file_p, search_magic_path):
558 Omit last arg SUFFIX; it was always 0. All callers changed.
559 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
560
561 * xfont.c (xfont_match): Avoid need for strlen.
562
563 * xfns.c: Don't assume strlen fits in int.
564 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
565
566 * xdisp.c (message_log_check_duplicate): Return intmax_t,
567 not unsigned long, as we prefer signed integers. All callers changed.
568 Detect integer overflow in repeat count.
569 (message_dolog): Don't assume print length fits in 39 bytes.
570 (display_mode_element): Don't assume strlen fits in int.
571
572 * termcap.c: Don't assume sizes fit in int and never overflow.
573 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
574 (gobble_line): Check for size-calculation overflow.
575
576 * minibuf.c (Fread_buffer):
577 * lread.c (intern, intern_c_string):
578 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
579 Don't assume string length fits in int.
580
581 * keyboard.c (parse_tool_bar_item):
582 * gtkutil.c (style_changed_cb): Avoid need for strlen.
583
584 * font.c: Don't assume string length fits in int.
585 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
586 Use ptrdiff_t, not int.
587 (font_intern_prop): Don't assume string length fits in int.
588 Don't assume integer property fits in fixnum.
589 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
590
591 * filelock.c: Fix some buffer overrun and integer overflow issues.
592 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
593 Reformulate so as not to need the command string.
594 Invoke gzip -cd rather than gunzip, as it's more portable.
595 (lock_info_type, lock_file_1, lock_file):
596 Don't assume pid_t and time_t fit in unsigned long.
597 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
598 (current_lock_owner): Prefer signed type for sizes.
599 Use memcpy, not strncpy, where memcpy is what is really wanted.
600 Don't assume (via atoi) that time_t and pid_t fit in int.
601 Check for time_t and/or pid_t out of range, e.g., via a network share.
602 Don't alloca where an auto var works fine.
603
604 * fileio.c: Fix some integer overflow issues.
605 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
606 Don't assume string length fits in int.
607 (directory_file_name): Don't assume string length fits in long.
608 (make_temp_name): Don't assume pid fits in int, or that its print
609 length is less than 20.
610
611 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
612
613 * coding.c (make_subsidiaries): Don't assume string length fits in int.
614
615 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
616
617 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
618 We prefer signed integers, even for size calculations.
619
620 * emacs.c: Don't assume string length fits in 'int'.
621 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
622 (main): Don't invoke strlen when not needed.
623
624 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
625 (XD_DEBUG_MESSAGE): Don't waste a byte.
626
627 * callproc.c (getenv_internal_1, getenv_internal)
628 (Fgetenv_internal):
629 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
630
631 * lread.c (invalid_syntax): Omit length argument.
632 All uses changed. This doesn't fix a bug, but it simplifies the
633 code away from its former Hollerith-constant appearance, and it's
634 one less 'int' to worry about when looking at integer-overflow issues.
635 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
636
637 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
638 This didn't break anything, but it didn't help either.
639 It's confusing to put a bogus integer in a place where the actual
640 value does not matter.
641 (LIST_END_P): Remove unused macro and its bogus comment.
642 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
643
644 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
645 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
646 implementation.
647 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
648 We prefer signed types, and the value cannot exceed the EMACS_INT
649 range anyway (because otherwise the length would not be representable).
650 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
651 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
652 This avoids a GCC warning when WIDE_EMACS_INT.
653
654 * indent.c (sane_tab_width): New function.
655 (current_column, scan_for_column, Findent_to, position_indentation)
656 (compute_motion): Use it. This is just for clarity.
657 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
658
659 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
660
661 * lisp.h (lint_assume): New macro.
662 * composite.c (composition_gstring_put_cache):
663 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
664
665 * editfns.c, insdel.c:
666 Omit unnecessary forward decls, to simplify future changes.
667
668 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
669
670 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
671
672 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
673 Use much-faster test for byte-length change.
674 Don't assume string byte-length fits in 'int'.
675 Check that character arg fits in 'int'.
676 (mapcar1): Declare byte as byte, for clarity.
677
678 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
679
680 * fns.c (concat): Catch string overflow earlier.
681 Do not rely on integer wraparound.
682
683 * dispextern.h (struct it.overlay_strings_charpos)
684 (struct it.selective): Now EMACS_INT, not int.
685 * xdisp.c (forward_to_next_line_start)
686 (back_to_previous_visible_line_start)
687 (reseat_at_next_visible_line_start, next_element_from_buffer):
688 Don't arbitrarily truncate the value of 'selective' to int.
689
690 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
691
692 * composite.c: Don't truncate sizes to 'int'.
693 (composition_gstring_p, composition_reseat_it)
694 (composition_adjust_point): Use EMACS_INT, not int.
695 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
696 not EMACS_UINT, for indexes.
697
698 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
699
700 * buffer.c: Include <verify.h>.
701 (struct sortvec.priority, struct sortstr.priority):
702 Now EMACS_INT, not int.
703 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
704 (struct sortstr.size, record_overlay_string)
705 (struct sortstrlist.size, struct sortlist.used):
706 Don't truncate size to int.
707 (record_overlay_string): Check for size-calculation overflow.
708 (init_buffer_once): Check at compile-time, not run-time.
709
710 2011-06-22 Jim Meyering <meyering@redhat.com>
711
712 Don't leak an XBM-image-sized buffer
713 * image.c (xbm_load): Free the image buffer after using it.
714
715 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
716
717 Port to Sun C.
718 * composite.c (find_automatic_composition): Omit needless 'return 0;'
719 that Sun C diagnosed.
720 * fns.c (secure_hash): Fix pointer signedness issue.
721 * intervals.c (static_offset_intervals): New function.
722 (offset_intervals): Use it.
723
724 2011-06-21 Leo Liu <sdl.web@gmail.com>
725
726 * deps.mk (fns.o):
727 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
728 sha512.h.
729
730 * fns.c (secure_hash): Rename from crypto_hash_function and change
731 the first arg to accept symbols.
732 (Fsecure_hash): New primitive.
733 (syms_of_fns): New symbols.
734
735 2011-06-20 Deniz Dogan <deniz@dogan.se>
736
737 * process.c (Fset_process_buffer): Clarify return value in
738 docstring.
739
740 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
741
742 * dispnew.c (add_window_display_history): Use BVAR.
743
744 * xdisp.c (debug_method_add): Use BVAR.
745 (check_window_end, dump_glyph_matrix, dump_glyph)
746 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
747
748 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
749 Likewise.
750
751 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
752 check till after the cache is created in init_frame_faces.
753
754 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
755
756 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
757
758 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
759
760 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
761 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
762 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
763
764 Improve buffer-overflow checking (Bug#8873).
765 * fileio.c (Finsert_file_contents):
766 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
767 Remove the old (too-loose) buffer overflow checks.
768 They weren't needed, since make_gap checks for buffer overflow.
769 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
770 The old code merely checked for Emacs fixnum overflow, and relied
771 on undefined (wraparound) behavior. The new code avoids undefined
772 behavior, and also checks for ptrdiff_t and/or size_t overflow.
773
774 * editfns.c (Finsert_char): Don't dump core with very negative counts.
775 Tune. Don't use wider integers than needed. Don't use alloca.
776 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
777
778 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
779
780 * insdel.c, lisp.h (buffer_overflow): New function.
781 (insert_from_buffer_1, replace_range, replace_range_2):
782 * insdel.c (make_gap_larger):
783 * editfns.c (Finsert_char):
784 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
785
786 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
787
788 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
789
790 Integer overflow and signedness fixes (Bug#8873).
791
792 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
793 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
794
795 * fileio.c: Don't assume EMACS_INT fits in off_t.
796 (emacs_lseek): New static function.
797 (Finsert_file_contents, Fwrite_region): Use it.
798 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
799
800 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
801
802 * fns.c: Don't overflow int when computing a list length.
803 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
804 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
805 truncation on 64-bit hosts. Check for QUIT every
806 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
807 faster and is responsive enough.
808 (Flength): Report an error instead of overflowing an integer.
809 (Fsafe_length): Return a float if the value is not representable
810 as a fixnum. This shouldn't happen except in contrived situations.
811 (Fnthcdr, Fsort): Don't assume list length fits in int.
812 (Fcopy_sequence): Don't assume vector length fits in int.
813
814 * alloc.c: Check that resized vectors' lengths fit in fixnums.
815 (header_size, word_size): New constants.
816 (allocate_vectorlike): Don't check size overflow here.
817 (allocate_vector): Check it here instead, since this is the only
818 caller of allocate_vectorlike that could cause overflow.
819 Check that the new vector's length is representable as a fixnum.
820
821 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
822 The previous code was bogus. For example, next_almost_prime (32)
823 returned 39, which is undesirable as it is a multiple of 3; and
824 next_almost_prime (24) returned 25, which is a multiple of 5 so
825 why was the code bothering to check for multiples of 7?
826
827 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
828
829 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
830
831 Variadic C functions now count arguments with ptrdiff_t.
832 This partly undoes my 2011-03-30 change, which replaced int with size_t.
833 Back then I didn't know that the Emacs coding style prefers signed int.
834 Also, in the meantime I found a few more instances where arguments
835 were being counted with int, which may truncate counts on 64-bit
836 machines, or EMACS_INT, which may be unnecessarily wide.
837 * lisp.h (struct Lisp_Subr.function.aMANY)
838 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
839 Arg counts are now ptrdiff_t, not size_t.
840 All variadic functions and their callers changed accordingly.
841 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
842 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
843 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
844 * callint.c (Fcall_interactively): Check arg count for overflow,
845 to avoid potential buffer overrun. Use signed char, not 'int',
846 for 'varies' array, so that we needn't bother to check its size
847 calculation for overflow.
848 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
849 * eval.c (apply_lambda):
850 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
851 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
852 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
853
854 * callint.c (Fcall_interactively): Don't use index var as event count.
855
856 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
857 * mem-limits.h (SIZE): Remove; no longer used.
858
859 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
860
861 Remove unnecessary casts.
862 * xterm.c (x_term_init):
863 * xfns.c (x_set_border_pixel):
864 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
865 These aren't needed now that we assume ANSI C.
866
867 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
868 It's more likely to cause problems (due to unsigned overflow)
869 than to cure them.
870
871 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
872
873 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
874
875 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
876
877 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
878
879 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
880
881 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
882
883 GLYPH_CODE_FACE returns EMACS_INT, not int.
884 * dispextern.h (merge_faces):
885 * xfaces.c (merge_faces):
886 * xdisp.c (get_next_display_element, next_element_from_display_vector):
887 Don't assume EMACS_INT fits in int.
888
889 * character.h (CHAR_VALID_P): Remove unused parameter.
890 * fontset.c, lisp.h, xdisp.c: All uses changed.
891
892 * editfns.c (Ftranslate_region_internal): Omit redundant test.
893
894 * fns.c (concat): Minor tuning based on overflow analysis.
895 This doesn't fix any bugs. Use int to hold character, instead
896 of constantly refetching from Emacs object. Use XFASTINT, not
897 XINT, for value known to be a character. Don't bother comparing
898 a single byte to 0400, as it's always less.
899
900 * floatfns.c (Fexpt):
901 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
902
903 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
904 for characters.
905
906 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
907
908 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
909 Without this fix, on a 64-bit host (aset S 0 4294967386) would
910 incorrectly succeed when S was a string, because 4294967386 was
911 truncated before it was used.
912
913 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
914 Otherwise, an out-of-range integer could cause undefined behavior
915 on a 64-bit host.
916
917 * composite.c: Use int, not EMACS_INT, for characters.
918 (fill_gstring_body, composition_compute_stop_pos): Use int, not
919 EMACS_INT, for values that are known to be in character range.
920 This doesn't fix any bugs but is the usual style inside Emacs and
921 may generate better code on 32-bit machines.
922
923 Make sure a 64-bit char is never passed to ENCODE_CHAR.
924 This is for reasons similar to the recent CHAR_STRING fix.
925 * charset.c (Fencode_char): Check that character arg is actually
926 a character. Pass an int to ENCODE_CHAR.
927 * charset.h (ENCODE_CHAR): Verify that the character argument is no
928 wider than 'int', as a compile-time check to prevent future regressions
929 in this area.
930
931 * character.c (char_string): Remove unnecessary casts.
932
933 Make sure a 64-bit char is never passed to CHAR_STRING.
934 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
935 by silently ignoring the top 32 bits, allowing some values
936 that were far too large to be valid characters.
937 * character.h: Include <verify.h>.
938 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
939 arguments are no wider than unsigned, as a compile-time check
940 to prevent future regressions in this area.
941 * data.c (Faset):
942 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
943 (Fsubst_char_in_region):
944 * fns.c (concat):
945 * xdisp.c (decode_mode_spec_coding):
946 Adjust to CHAR_STRING's new requirement.
947 * editfns.c (Finsert_char, Fsubst_char_in_region):
948 * fns.c (concat): Check that character args are actually
949 characters. Without this test, these functions did the wrong
950 thing with wildly out-of-range values on 64-bit hosts.
951
952 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
953 These casts should not be needed on 32-bit hosts, either.
954 * keyboard.c (read_char):
955 * lread.c (Fload): Remove casts to unsigned.
956
957 * lisp.h (UNSIGNED_CMP): New macro.
958 This fixes comparison bugs on 64-bit hosts.
959 (ASCII_CHAR_P): Use it.
960 * casefiddle.c (casify_object):
961 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
962 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
963 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
964 * dispextern.h (FACE_FROM_ID):
965 * keyboard.c (read_char): Use UNSIGNED_CMP.
966
967 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
968 not to EMACS_INT, to avoid GCC warning.
969
970 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
971
972 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
973 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
974 isn't needed on 32-bit machines.
975
976 * buffer.c (Fgenerate_new_buffer_name):
977 Use EMACS_INT for count, not int.
978 (advance_to_char_boundary): Return EMACS_INT, not int.
979
980 * data.c (Qcompiled_function): Now static.
981
982 * window.c (window_body_lines): Now static.
983
984 * image.c (gif_load): Rename local to avoid shadowing.
985
986 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
987 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
988 * alloc.c (make_save_value): Integer argument is now of type
989 ptrdiff_t, not int.
990 (mark_object): Use ptrdiff_t, not int.
991 * lisp.h (pD): New macro.
992 * print.c (print_object): Use it.
993
994 * alloc.c: Use EMACS_INT, not int, to count objects.
995 (total_conses, total_markers, total_symbols, total_vector_size)
996 (total_free_conses, total_free_markers, total_free_symbols)
997 (total_free_floats, total_floats, total_free_intervals)
998 (total_intervals, total_strings, total_free_strings):
999 Now EMACS_INT, not int. All uses changed.
1000 (Fgarbage_collect): Compute overall total using a double, so that
1001 integer overflow is less likely to be a problem. Check for overflow
1002 when converting back to an integer.
1003 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1004 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1005 These were 'int' variables that could overflow on 64-bit hosts;
1006 they were never used, so remove them instead of repairing them.
1007 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1008 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1009 Previously, this ceilinged at INT_MAX, but that doesn't work on
1010 64-bit machines.
1011 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1012
1013 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1014 (allocate_vectorlike): Check for ptrdiff_t overflow.
1015 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1016 when a (possibly-narrower) signed value would do just as well.
1017 We prefer using signed arithmetic, to avoid comparison confusion.
1018
1019 * alloc.c: Catch some string size overflows that we were missing.
1020 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1021 for convenience in STRING_BYTES_MAX.
1022 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1023 The definition here is exact; the one in lisp.h was approximate.
1024 (allocate_string_data): Check for string overflow. This catches
1025 some instances we weren't catching before. Also, it catches
1026 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1027 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1028 and ptrdiff_t and EMACS_INT are both 64 bits.
1029
1030 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1031 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1032 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1033
1034 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1035
1036 * alloc.c (Fmake_string): Check for out-of-range init.
1037
1038 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1039
1040 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1041
1042 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1043
1044 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1045 xg_get_default_scrollbar_width.
1046
1047 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1048 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1049 (style_changed_cb): Call update_theme_scrollbar_width and call
1050 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1051 all frames (Bug#8505).
1052 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1053 Call gtk_window_set_resizable if HAVE_GTK3.
1054 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1055 and height if HAVE_GTK3 (Bug#8505).
1056 (scroll_bar_width_for_theme): New variable.
1057 (update_theme_scrollbar_width): New function.
1058 (xg_get_default_scrollbar_width): Move code to
1059 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1060 (xg_initialize): Call update_theme_scrollbar_width.
1061
1062 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1063
1064 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1065
1066 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1067
1068 * frame.c (make_frame): Call other_buffer_safely instead of
1069 other_buffer.
1070
1071 * window.c (temp_output_buffer_show): Call display_buffer with
1072 second argument Vtemp_buffer_show_specifiers and reset latter
1073 immediately after the call.
1074 (Vtemp_buffer_show_specifiers): New variable.
1075 (auto_window_vscroll_p, next_screen_context_lines)
1076 (Vscroll_preserve_screen_position): Remove leading asterisks from
1077 doc-strings.
1078
1079 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1080
1081 Fix minor problems found by GCC 4.6.0 static checking.
1082 * buffer.c (Qclone_number): Remove for now, as it's unused.
1083 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1084 (record_buffer): Remove unused local.
1085 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1086 (set_frame_buffer_list): Remove; unused.
1087 * frame.h (other_visible_frames): Remove decl.
1088 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1089 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1090 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1091 if HAVE_GPM.
1092 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1093 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1094 Define only if HAVE_GPM.
1095 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1096 (update_hints_inhibit): Remove; never set. All uses removed.
1097 * widgetprv.h (emacsFrameClassRec): Remove decl.
1098 * window.c (delete_deletable_window): Now returns void, since it
1099 wasn't returning anything.
1100 (compare_window_configurations): Remove unused locals.
1101 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1102 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1103 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1104 the same widths as pointers. This follows up on the 2011-05-06 patch.
1105 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1106 * xterm.h: Likewise.
1107 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1108
1109 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1110
1111 * makefile.w32-in: Update dependencies.
1112 (LISP_H): Add lib/intprops.h.
1113
1114 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1115
1116 * image.c (gif_load): Add animation frame delay to the metadata.
1117 (syms_of_image): Use DEFSYM. New symbol `delay'.
1118
1119 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1120
1121 * window.c (delete_deletable_window): Re-add.
1122 (Fset_window_configuration): Rewrite to handle dead buffers and
1123 consequently deletable windows.
1124 (window_tree, Fwindow_tree): Remove. Supply functionality in
1125 window.el.
1126 (compare_window_configurations): Simplify code.
1127
1128 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1129
1130 * image.c (imagemagick_load_image): Fix type mismatch.
1131 (Fimagemagick_types): Likewise.
1132
1133 * window.h (replace_buffer_in_windows): Declare.
1134
1135 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1136
1137 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1138 Qclone_number. Remove external declaration of Qdelete_window.
1139 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1140 code.
1141 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1142 Qbuffer_list_update_hook if allowed.
1143 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1144 buffer list implementation.
1145 (other_buffer_safely): New function.
1146 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1147 calls to replace_buffer_in_windows and
1148 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1149 if allowed.
1150 (record_buffer): Inhibit quitting and rewrite using quittable
1151 functions. Run Qbuffer_list_update_hook if allowed.
1152 (Frecord_buffer, Funrecord_buffer): New functions.
1153 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1154 switch-to-buffer to window.el.
1155 (bury-buffer): Move to window.el.
1156 (Vbuffer_list_update_hook): New variable.
1157
1158 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1159 section.
1160
1161 * window.h (resize_frame_windows): Move up in code.
1162 (Fwindow_frame): Remove EXFUN.
1163 (replace_buffer_in_all_windows): Remove prototype.
1164 (replace_buffer_in_windows_safely): Add prototype.
1165
1166 * window.c: Declare Qdelete_window static again. Move down
1167 declaration of select_count.
1168 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1169 (Fother_window): Move to window.el.
1170 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1171 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1172 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1173 window.el.
1174 (replace_buffer_in_windows): Implement by calling
1175 Qreplace_buffer_in_windows.
1176 (replace_buffer_in_all_windows): Remove with some functionality
1177 moved into replace_buffer_in_windows_safely.
1178 (replace_buffer_in_windows_safely): New function.
1179 (select_window_norecord, select_frame_norecord): Move in front
1180 of run_window_configuration_change_hook. Remove now obsolete
1181 declarations.
1182 (Fset_window_buffer): Rewrite doc-string. Call
1183 Qrecord_window_buffer.
1184 (keys_of_window): Move binding for other-window to window.el.
1185
1186 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1187
1188 * dispextern.h (struct image): Replace data member, whose int_val
1189 and ptr_val fields were not used by anything, with a single
1190 lisp_val object.
1191
1192 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1193 (gif_clear_image, gif_load, imagemagick_load_image)
1194 (gs_clear_image, gs_load): Callers changed.
1195
1196 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1197
1198 * buffer.h: Include <time.h>, for time_t.
1199 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1200
1201 Fix minor problems found by static checking.
1202
1203 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1204
1205 Make identifiers static if they are not used in other modules.
1206 * data.c (Qcompiled_function, Qframe, Qvector):
1207 * image.c (QimageMagick, Qsvg):
1208 * minibuf.c (Qmetadata):
1209 * window.c (resize_window_check, resize_root_window): Now static.
1210 * window.h (resize_window_check, resize_root_window): Remove decls.
1211
1212 * window.c (window_deletion_count, delete_deletable_window):
1213 Remove; unused.
1214 (window_body_lines): Now static.
1215 (Fdelete_other_windows_internal): Mark vars as initialized.
1216 Make sure 'resize_failed' is initialized.
1217 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1218 (resize_window_apply): Remove unused local.
1219 * window.h (delete_deletable_window): Remove decl.
1220
1221 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1222 (imagemagick_load_image): Fix pointer signedness problem by changing
1223 last arg from unsigned char * to char *. All uses changed.
1224 Also, fix a local for similar reasons.
1225 Remove unused locals. Remove locals to avoid shadowing.
1226 (fn_rsvg_handle_free): Remove; unused.
1227 (svg_load, svg_load_image): Fix pointer signedness problem.
1228 (imagemagick_load_image): Don't use garbage pointer image_wand.
1229
1230 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1231
1232 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1233
1234 * image.c (gif_load): Fix omitted cast error introduced by
1235 2011-06-06 change.
1236
1237 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1238
1239 * window.h (resize_proportionally, orig_total_lines)
1240 (orig_top_line): Remove from window structure.
1241 (set_window_height, set_window_width, change_window_heights)
1242 (Fdelete_window): Remove prototypes.
1243 (resize_frame_windows): Remove duplicate declaration.
1244
1245 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1246
1247 * window.h (resize_frame_windows, resize_window_check)
1248 (delete_deletable_window, resize_root_window)
1249 (resize_frame_windows): Declare prototypes.
1250
1251 * window.c (resize_window_apply): Make definition be "static" to
1252 match the prototype.
1253
1254 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1255
1256 * window.c: Remove declarations of Qwindow_size_fixed,
1257 window_min_size_1, window_min_size_2, window_min_size,
1258 size_window, window_fixed_size_p, enlarge_window, delete_window.
1259 Remove static from declaration of Qdelete_window, it's
1260 temporarily needed by Fbury_buffer.
1261 (replace_window): Don't assign orig_top_line and
1262 orig_total_lines.
1263 (Fdelete_window, delete_window): Remove. Window deletion is
1264 handled by window.el.
1265 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1266 Fdelete_window calls with calls to Qdelete_window.
1267 (Fdelete_other_windows): Remove. Deleting other windows is
1268 handled by window.el.
1269 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1270 handled in window.el.
1271 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1272 Window minimum sizes are handled in window.el.
1273 (shrink_windows, size_window, set_window_height)
1274 (set_window_width, change_window_heights, window_height)
1275 (window_width, CURBEG, CURSIZE, enlarge_window)
1276 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1277 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1278 handled in window.el.
1279 (make_dummy_parent): Rename to make_parent_window and give it a
1280 second argument horflag.
1281 (make_window): Don't set resize_proportionally any more.
1282 (Fsplit_window): Remove. Windows are split in window.el.
1283 (save_restore_action, save_restore_orig_size)
1284 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1285 Resize mini windows in window.el.
1286 (grow_mini_window, shrink_mini_window): Implement by calling
1287 Qresize_root_window_vertically, resize_window_check and
1288 resize_window_apply.
1289 (saved_window, Fset_window_configuration, save_window_save): Do
1290 not handle orig_top_line, orig_total_lines, and
1291 resize_proportionally.
1292 (window_min_height, window_min_width): Move to window.el.
1293 (keys_of_window): Move bindings for delete-other-windows,
1294 split-window, delete-window and enlarge-window to window.el.
1295
1296 * buffer.c: Temporarily extern Qdelete_window.
1297 (Fbury_buffer): Temporarily call Qdelete_window instead of
1298 Fdelete_window (Fbury_buffer will move to window.el soon).
1299
1300 * frame.c (set_menu_bar_lines_1): Remove code handling
1301 orig_top_line and orig_total_lines.
1302
1303 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1304 set_window_height but set heights directly.
1305 (change_frame_size_1): Use resize_frame_windows.
1306
1307 * xdisp.c (init_xdisp): Don't use set_window_height but set
1308 heights directly.
1309
1310 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1311 resize_frame_windows instead of change_window_heights and run
1312 run_window_configuration_change_hook.
1313
1314 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1315 instead of change_window_heights and run
1316 run_window_configuration_change_hook.
1317
1318 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1319
1320 * window.c (replace_window): Rename second argument REPLACEMENT to
1321 NEW. New third argument SETFLAG. Rewrite.
1322 (delete_window, make_dummy_parent): Call replace_window with
1323 third argument 1.
1324 (window_list_1): Move down in code.
1325 (run_window_configuration_change_hook): Move set_buffer part
1326 before select_frame_norecord part in order to unwind correctly.
1327 Rename count1 to count.
1328 (recombine_windows, delete_deletable_window, resize_root_window)
1329 (Fdelete_other_windows_internal)
1330 (Frun_window_configuration_change_hook, make_parent_window)
1331 (resize_window_check, resize_window_apply, Fresize_window_apply)
1332 (resize_frame_windows, Fsplit_window_internal)
1333 (Fdelete_window_internal, Fresize_mini_window_internal): New
1334 functions.
1335 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1336
1337 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1338
1339 * window.h (window): Add some new members to window structure -
1340 normal_lines, normal_cols, new_total, new_normal, clone_number,
1341 splits, nest, prev_buffers, next_buffers.
1342 (WINDOW_TOTAL_SIZE): Move here from window.c.
1343 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1344
1345 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1346 Remove.
1347 (make_dummy_parent): Set new members of windows structure.
1348 (make_window): Move down in code. Handle new members of window
1349 structure.
1350 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1351 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1352 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1353 (Fset_window_prev_buffers, Fwindow_next_buffers)
1354 (Fset_window_next_buffers, Fset_window_clone_number): New
1355 functions.
1356 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1357 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1358 Doc-string fixes.
1359 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1360 Argument WINDOW can be now internal window too.
1361 (Fwindow_use_time): Move up in code.
1362 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1363 Rewrite doc-string.
1364 (Fset_window_configuration, saved_window)
1365 (Fcurrent_window_configuration, save_window_save): Handle new
1366 members of window structure.
1367 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1368 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1369 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1370 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1371 Qget_mru_window, Qresize_root_window,
1372 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1373 Qauto_buffer_name; staticpro them.
1374
1375 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1376
1377 * window.c (Fwindow_total_size, Fwindow_left_column)
1378 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1379 (Fwindow_list_1): New functions.
1380 (window_box_text_cols): Replace with window_body_cols.
1381 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1382 window_body_cols instead of window_box_text_cols.
1383 (delete_window, Fset_window_configuration): Call
1384 delete_all_subwindows with window as argument.
1385 (delete_all_subwindows): Take a window as argument and not a
1386 structure. Rewrite.
1387 (window_loop): Remove handling of GET_LRU_WINDOW and
1388 GET_LARGEST_WINDOW.
1389 (Fget_lru_window, Fget_largest_window): Move to window.el.
1390
1391 * window.h: Extern window_body_cols instead of
1392 window_box_text_cols. delete_all_subwindows now takes a
1393 Lisp_Object as argument.
1394
1395 * indent.c (compute_motion, Fcompute_motion): Use
1396 window_body_cols instead of window_box_text_cols.
1397
1398 * frame.c (delete_frame): Call delete_all_subwindows with root
1399 window as argument.
1400
1401 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1402
1403 * fns.c (Fputhash): Document return value.
1404
1405 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1406
1407 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1408
1409 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1410
1411 Cons<->int and similar integer overflow fixes (Bug#8794).
1412
1413 Check for overflow when converting integer to cons and back.
1414 * charset.c (Fdefine_charset_internal, Fdecode_char):
1415 Use cons_to_unsigned to catch overflow.
1416 (Fencode_char): Use INTEGER_TO_CONS.
1417 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1418 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1419 * data.c (long_to_cons, cons_to_long): Remove.
1420 (cons_to_unsigned, cons_to_signed): New functions.
1421 These signal an error for invalid or out-of-range values.
1422 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1423 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1424 * font.c (Ffont_variation_glyphs):
1425 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1426 * lisp.h: Include <intprops.h>.
1427 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1428 (cons_to_signed, cons_to_unsigned): New decls.
1429 (long_to_cons, cons_to_long): Remove decls.
1430 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1431 (Fprimitive_undo): Use CONS_TO_INTEGER.
1432 * xfns.c (Fx_window_property): Likewise.
1433 * xselect.c: Include <limits.h>.
1434 (x_own_selection, selection_data_to_lisp_data):
1435 Use INTEGER_TO_CONS.
1436 (x_handle_selection_request, x_handle_selection_clear)
1437 (x_get_foreign_selection, Fx_disown_selection_internal)
1438 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1439 (lisp_data_to_selection_data): Use cons_to_unsigned.
1440 (x_fill_property_data): Use cons_to_signed.
1441 Report values out of range.
1442
1443 Check for buffer and string overflow more precisely.
1444 * buffer.h (BUF_BYTES_MAX): New macro.
1445 * lisp.h (STRING_BYTES_MAX): New macro.
1446 * alloc.c (Fmake_string):
1447 * character.c (string_escape_byte8):
1448 * coding.c (coding_alloc_by_realloc):
1449 * doprnt.c (doprnt):
1450 * editfns.c (Fformat):
1451 * eval.c (verror):
1452 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1453 since they may not be the same number.
1454 * editfns.c (Finsert_char):
1455 * fileio.c (Finsert_file_contents):
1456 Likewise for BUF_BYTES_MAX.
1457
1458 * image.c: Use ptrdiff_t, not int, for sizes.
1459 (slurp_file): Switch from int to ptrdiff_t.
1460 All uses changed.
1461 (slurp_file): Check that file size fits in both size_t (for
1462 malloc) and ptrdiff_t (for sanity and safety).
1463
1464 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1465 if b->modtime has its maximal value.
1466
1467 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1468
1469 Don't assume time_t can fit into int.
1470 * buffer.h (struct buffer.modtime): Now time_t, not int.
1471 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1472 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1473
1474 Minor fixes for signed vs unsigned integers.
1475 * character.h (MAYBE_UNIFY_CHAR):
1476 * charset.c (maybe_unify_char):
1477 * keyboard.c (read_char, reorder_modifiers):
1478 XINT -> XFASTINT, since the integer must be nonnegative.
1479 * ftfont.c (ftfont_spec_pattern):
1480 * keymap.c (access_keymap, silly_event_symbol_error):
1481 XUINT -> XFASTINT, since the integer must be nonnegative.
1482 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1483 since it makes no difference and we prefer signed.
1484 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1485 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1486 nonnegative.
1487
1488 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1489
1490 * window.h (Fwindow_frame): Declare.
1491
1492 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1493
1494 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1495 (SPARE_MEMORY): Always define.
1496 (LARGE_REQUEST): Remove.
1497 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1498
1499 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1500
1501 * lisp.h: Move EXFUNS for Fframe_root_window,
1502 Fframe_first_window and Fset_frame_selected_window to window.h.
1503
1504 * window.h: Move EXFUNS for Fframe_root_window,
1505 Fframe_first_window and Fset_frame_selected_window here from
1506 lisp.h.
1507
1508 * frame.c (Fwindow_frame, Fframe_first_window)
1509 (Fframe_root_window, Fframe_selected_window)
1510 (Fset_frame_selected_window): Move to window.c.
1511 (Factive_minibuffer_window): Move to minibuf.c.
1512 (Fother_visible_frames_p): New function.
1513
1514 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1515
1516 * window.c (decode_window, decode_any_window): Move up in code.
1517 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1518 (inhibit_frame_unsplittable): Remove unused variable.
1519 (Fwindow_buffer): Move up and rewrite doc-string.
1520 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1521 (Fwindow_prev): New functions.
1522 (Fwindow_frame): Move here from frame.c. Accept any window as
1523 argument.
1524 (Fframe_root_window, Fframe_first_window)
1525 (Fframe_selected_window): Move here from frame.c. Accept frame
1526 or arbitrary window as argument. Update doc-strings.
1527 (Fminibuffer_window): Move up in code.
1528 (Fwindow_minibuffer_p): Move up in code and simplify.
1529 (Fset_frame_selected_window): Move here from frame.c.
1530 Marginal rewrite.
1531 (Fselected_window, select_window, Fselect_window): Move up in
1532 code. Minor doc-string fixes.
1533
1534 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1535
1536 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1537 Do not assume that spare memory exists; that assumption is valid
1538 only if SYSTEM_MALLOC.
1539 (LARGE_REQUEST): New macro, so that the issue of large requests
1540 is separated from the issue of spare memory.
1541
1542 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1543
1544 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1545 format. (Bug#8806)
1546
1547 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1548
1549 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1550 before statements.
1551
1552 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1553
1554 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1555
1556 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1557
1558 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1559 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1560
1561 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1562
1563 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1564
1565 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1566
1567 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1568 (x_clipboard_manager_save): Add return value.
1569 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1570 New error handlers.
1571 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1572 Obey Vx_select_enable_clipboard_manager. Catch errors in
1573 x_clipboard_manager_save (Bug#8779).
1574 (Vx_select_enable_clipboard_manager): New variable.
1575 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1576
1577 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1578
1579 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1580
1581 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1582
1583 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1584 in the current matrix if keep_current_p is non-zero.
1585
1586 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1587
1588 * bidi.c (bidi_level_of_next_char): Fix last change.
1589
1590 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1591
1592 Support bidi reordering of text covered by display properties.
1593
1594 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1595 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1596 (bidi_cache_search, bidi_cache_iterator_state)
1597 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1598 (bidi_level_of_next_char, bidi_move_to_visually_next):
1599 Support character positions inside a run of characters covered by a
1600 display string.
1601 (bidi_paragraph_init, bidi_resolve_explicit_1)
1602 (bidi_level_of_next_char): Call bidi_fetch_char and
1603 bidi_fetch_char_advance instead of FETCH_CHAR and
1604 FETCH_CHAR_ADVANCE.
1605 (bidi_init_it): Initialize new members.
1606 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1607 definitions.
1608 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1609 instead of using explicit *_CHAR codes.
1610 (bidi_resolve_explicit, bidi_resolve_weak):
1611 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1612 bidirectional text is supported only in multibyte buffers.
1613 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1614 it to initialize the frame_window_p member of struct bidi_it.
1615 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1616 (bidi_resolve_explicit, bidi_resolve_weak)
1617 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1618 bidi_it->nchars is non-positive.
1619 (bidi_level_of_next_char): Don't try to lookup the cache for the
1620 next/previous character if nothing is cached there yet, or if we
1621 were just reseat()'ed to a new position.
1622
1623 * xdisp.c (set_cursor_from_row): Set start and stop points
1624 according to the row's direction when priming the loop that looks
1625 for the glyph on which to display cursor.
1626 (single_display_spec_intangible_p): Function deleted.
1627 (display_prop_intangible_p): Reimplement to call
1628 handle_display_spec instead of single_display_spec_intangible_p.
1629 Accept 3 additional arguments needed by handle_display_spec.
1630 This fixes incorrect cursor motion across display property with complex
1631 values: lists, `(when COND...)' forms, etc.
1632 (single_display_spec_string_p): Support property values that are
1633 lists with the argument STRING its top-level element.
1634 (display_prop_string_p): Fix the condition for processing a
1635 property that is a list to be consistent with handle_display_spec.
1636 (handle_display_spec): New function, refactored from the
1637 last portion of handle_display_prop.
1638 (compute_display_string_pos): Accept additional argument
1639 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1640 value of a `display' property is a "replacing spec".
1641 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1642 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1643 the display property, but just return a value indicating whether
1644 the display property will replace the characters it covers.
1645 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1646 frame_window_p members of struct bidi_it.
1647 (compute_display_string_pos, compute_display_string_end):
1648 New functions.
1649 (push_it): Accept second argument POSITION, where pop_it should
1650 jump to continue iteration.
1651 (reseat_1): Initialize bidi_it.disp_pos.
1652
1653 * keyboard.c (adjust_point_for_property): Adjust the call to
1654 display_prop_intangible_p to its new signature.
1655
1656 * dispextern.h (struct bidi_it): New member frame_window_p.
1657 (bidi_init_it): Update prototypes.
1658 (display_prop_intangible_p): Update prototype.
1659 (compute_display_string_pos, compute_display_string_end):
1660 Declare prototypes.
1661 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1662 EMACS_INT.
1663
1664 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1665
1666 Malloc failure behavior now depends on size of allocation.
1667 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1668 * lisp.h: Change signatures accordingly.
1669 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1670 All callers changed. (Bug#8762)
1671
1672 * gnutls.c: Use Emacs's memory allocators.
1673 Without this change, the gnutls library would invoke malloc etc.
1674 directly, which causes problems on non-SYNC_INPUT hosts, and which
1675 runs afoul of improving memory_full behavior. (Bug#8761)
1676 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1677 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1678 xfree instead of the default malloc, realloc, free.
1679 (Fgnutls_boot): No need to check for memory allocation failure,
1680 since xmalloc does that for us.
1681
1682 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1683 * category.c (hash_get_category_set):
1684 * ccl.c (ccl_driver):
1685 * charset.c (Fdefine_charset_internal):
1686 * charset.h (struct charset.hash_index):
1687 * composite.c (get_composition_id, gstring_lookup_cache)
1688 (composition_gstring_put_cache):
1689 * composite.h (struct composition.hash_index):
1690 * dispextern.h (struct image.hash):
1691 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1692 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1693 (hashfn_equal, hashfn_user_defined, make_hash_table)
1694 (maybe_resize_hash_table, hash_lookup, hash_put)
1695 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1696 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1697 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1698 * image.c (make_image, search_image_cache, lookup_image)
1699 (xpm_put_color_table_h):
1700 * lisp.h (struct Lisp_Hash_Table):
1701 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1702 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1703 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1704 * alloc.c (allocate_vectorlike):
1705 Check for overflow in vector size calculations.
1706 * ccl.c (ccl_driver):
1707 Check for overflow when converting EMACS_INT to int.
1708 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1709 need to be updated by these changes.
1710 * fns.c (make_hash_table, maybe_resize_hash_table):
1711 Check for integer overflow with large hash tables.
1712 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1713 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1714 (SXHASH_REDUCE): New macro.
1715 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1716 Use it instead of discarding useful hash info with large hash values.
1717 (sxhash_float): New function.
1718 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1719 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1720 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1721 Rewrite to use FIXNUM_BITS, as this simplifies things.
1722 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1723 Adjust signatures to match updated version of code.
1724 (consing_since_gc): Now EMACS_INT, since a single hash table can
1725 use more than INT_MAX bytes.
1726
1727 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1728
1729 Make it possible to build with GCC-4.6+ -O2 -flto.
1730
1731 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1732
1733 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1734
1735 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1736 Call minibuffer-inactive-mode.
1737
1738 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1739
1740 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1741 Update dependencies.
1742
1743 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1744
1745 * data.c (init_data): Remove code for UTS, this system is not
1746 supported anymore.
1747
1748 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1749
1750 Don't force ./temacs to start in terminal mode.
1751
1752 * frame.c (make_initial_frame): Initialize faces in all cases, not
1753 only when CANNOT_DUMP is defined.
1754 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1755
1756 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1757
1758 * dispnew.c (add_window_display_history): Use const for the string
1759 pointer. Remove declaration, not needed.
1760
1761 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1762
1763 Use 'inline', not 'INLINE'.
1764 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1765 * alloc.c, fontset.c (INLINE): Remove.
1766 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1767 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1768 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1769 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1770 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1771
1772 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1773
1774 Make it possible to run ./temacs.
1775
1776 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1777 syms_of_callproc does the same thing. Remove test for
1778 "initialized", do it in the caller.
1779 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1780
1781 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1782
1783 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1784 (read_minibuf): Use get_minibuffer.
1785 (syms_of_minibuf): Use DEFSYM.
1786 (Qmetadata): New var.
1787 * data.c (Qbuffer): Don't make it static.
1788 (syms_of_data): Use DEFSYM.
1789
1790 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1791
1792 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1793 (CCL_CODE_MIN): New macro.
1794
1795 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1796
1797 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1798
1799 * eval.c (Qdebug): Now static.
1800 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1801 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1802 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1803
1804 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1805
1806 * image.c: Various fixes to ImageMagick code comments.
1807 (Fimagemagick_types): Doc fix.
1808
1809 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1810
1811 Minor fixes prompted by GCC 4.6.0 warnings.
1812
1813 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1814
1815 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1816 (x_clipboard_manager_save_all): Move extern decl to ...
1817 * xterm.h: ... here, so that it can be checked for consistency.
1818
1819 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1820
1821 * xselect.c (x_clipboard_manager_save_frame)
1822 (x_clipboard_manager_save_all): New functions.
1823 (Fx_clipboard_manager_save): Lisp function deleted.
1824
1825 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1826 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1827
1828 * xterm.h: Update prototype.
1829
1830 2011-05-28 William Xu <william.xwl@gmail.com>
1831
1832 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1833 exiting (Bug#8239).
1834
1835 2011-05-28 Jim Meyering <meyering@redhat.com>
1836
1837 Avoid a sign-extension bug in crypto_hash_function.
1838 * fns.c (to_uchar): Define.
1839 (crypto_hash_function): Use it to convert some newly-signed
1840 variables to unsigned, to avoid sign-extension bugs. For example,
1841 without this change, (md5 "truc") would evaluate to
1842 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1843 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1844 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1845
1846 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1847
1848 Integer overflow fixes.
1849
1850 * dbusbind.c: Serial number integer overflow fixes.
1851 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1852 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1853 to hold a serial number that is too large for a fixnum.
1854 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1855 Check for serial numbers out of range. Decode any serial number
1856 that was so large that it became a float. (Bug#8722)
1857
1858 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1859 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1860 Use XFASTINT rather than XUINT when numbers are nonnegative.
1861 (xd_append_arg, Fdbus_method_return_internal):
1862 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1863 arguments, check that Lisp number is nonnegative, rather than
1864 silently wrapping negative numbers around. (Bug#8722)
1865 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1866 (Bug#8722)
1867
1868 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1869
1870 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1871
1872 ccl: add integer overflow checks
1873 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1874 (IN_INT_RANGE): New macros.
1875 (ccl_driver): Use them to check for integer overflow when
1876 decoding a CCL program. Many of the new checks are whether XINT (x)
1877 fits in int; it doesn't always, on 64-bit hosts. The new version
1878 doesn't catch all possible integer overflows, but it's an
1879 improvement. (Bug#8719)
1880
1881 * alloc.c (make_event_array): Use XINT, not XUINT.
1882 There's no need for unsigned here.
1883
1884 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1885 This follows up to the 2011-05-06 change that substituted uintptr_t
1886 for EMACS_INT. This case wasn't caught back then.
1887
1888 Rework Fformat to avoid integer overflow issues.
1889 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1890 now (part of C89). Include <verify.h>.
1891 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1892 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1893 (Fformat): Avoid the prepass trying to compute sizes; it was only
1894 approximate and thus did not catch overflow reliably. Instead, walk
1895 through the format just once, formatting and computing sizes as we go,
1896 checking for integer overflow at every step, and allocating a larger
1897 buffer as needed. Keep track separately whether the format is
1898 multibyte. Keep only the most-recently calculated precision, rather
1899 than them all. Record whether each argument has been converted to
1900 string. Use EMACS_INT, not int, for byte and char and arg counts.
1901 Support field widths and precisions larger than INT_MAX. Avoid
1902 sprintf's undefined behavior with conversion specifications such as %#d
1903 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1904 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1905 formatting out-of-range floating point numbers with int
1906 formats. (Bug#8668)
1907
1908 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1909
1910 * data.c: Avoid integer truncation in expressions involving floats.
1911 * data.c: Include <intprops.h>.
1912 (arith_driver): When there's an integer overflow in an expression
1913 involving floating point, convert the integers to floating point
1914 so that the resulting value does not suffer from catastrophic
1915 integer truncation. For example, on a 64-bit host (* 4
1916 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1917 Do not rely on undefined behavior after integer overflow.
1918
1919 merge count_size_as_multibyte, parse_str_to_multibyte
1920 * character.c, character.h (count_size_as_multibyte):
1921 Rename from parse_str_to_multibyte; all uses changed.
1922 Check for integer overflow.
1923 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1924 since it's now a duplicate of the other. This is more of
1925 a character than a buffer op, so better that it's in character.c.
1926 * fns.c, print.c: Adjust to above changes.
1927
1928 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1929
1930 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1931
1932 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1933
1934 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1935 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1936 (x_clipboard_manager_save): Now static.
1937 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1938
1939 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1940 (crypto_hash_function): Now static.
1941 Fix pointer signedness problems. Avoid unnecessary initializations.
1942
1943 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1944
1945 * termhooks.h (Vselection_alist): Make it terminal-local.
1946
1947 * terminal.c (create_terminal): Initialize it.
1948
1949 * xselect.c: Support for clipboard managers.
1950 (Vselection_alist): Move to termhooks.h as terminal-local var.
1951 (LOCAL_SELECTION): New macro.
1952 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1953 (symbol_to_x_atom): Remove gratuitous arg.
1954 (x_handle_selection_request, lisp_data_to_selection_data)
1955 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1956 (x_own_selection, x_get_local_selection, x_convert_selection):
1957 New arg, specifying work frame. Use terminal-local Vselection_alist.
1958 (some_frame_on_display): Delete unused function.
1959 (Fx_own_selection_internal, Fx_get_selection_internal)
1960 (Fx_disown_selection_internal, Fx_selection_owner_p)
1961 (Fx_selection_exists_p): New optional frame arg.
1962 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1963 (x_handle_selection_clear): Don't treat other terminals with the
1964 same keyboard specially. Use the terminal-local Vselection_alist.
1965 (x_clear_frame_selections): Use Frun_hook_with_args.
1966
1967 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1968
1969 * xterm.h: Add support for those atoms.
1970
1971 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1972
1973 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1974 (converted_selections, conversion_fail_tag): New global variables.
1975 (x_selection_request_lisp_error): Free the above.
1976 (x_get_local_selection): Remove unnecessary code.
1977 (x_reply_selection_request): Args changed; handle arbitrary array
1978 of converted selections stored in converted_selections.
1979 Separate the XChangeProperty and SelectionNotify steps.
1980 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1981 (x_convert_selection): New function.
1982 (x_handle_selection_event): Simplify.
1983 (x_get_foreign_selection): Don't ignore incoming requests while
1984 waiting for an answer; this will fail when we implement
1985 SAVE_TARGETS, and seems unnecessary anyway.
1986 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1987 (Vx_sent_selection_functions): Doc fix.
1988
1989 2011-05-26 Leo Liu <sdl.web@gmail.com>
1990
1991 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1992
1993 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1994
1995 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1996
1997 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1998 for fringe update if it has periodic bitmap.
1999 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2000 and fringe_bitmap_periodic_p.
2001
2002 * fringe.c (get_fringe_bitmap_data): New function.
2003 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2004 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2005 row. Mark glyph row for fringe update if periodicity changed.
2006
2007 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2008 for fringe update unless it has periodic bitmap.
2009
2010 2011-05-25 Kenichi Handa <handa@m17n.org>
2011
2012 * xdisp.c (get_next_display_element): Set correct it->face_id for
2013 a static composition.
2014
2015 2011-05-24 Leo Liu <sdl.web@gmail.com>
2016
2017 * deps.mk (fns.o):
2018 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2019
2020 * fns.c (crypto_hash_function, Fsha1): New function.
2021 (Fmd5): Use crypto_hash_function.
2022 (syms_of_fns): Add Ssha1.
2023
2024 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2025
2026 * gnutls.c: Remove unused macros.
2027 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2028 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2029 Remove macros that are defined and never used.
2030 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2031
2032 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2033
2034 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2035 (Fx_get_selection_internal): Minor cleanup.
2036 (Fx_own_selection_internal): Rename arguments for consistency with
2037 select.el.
2038
2039 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2040
2041 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2042
2043 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2044
2045 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2046
2047 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2048
2049 * dispnew.c (scrolling_window): Don't exclude the case that the
2050 last enabled row in the desired matrix touches the bottom boundary.
2051
2052 2011-05-21 Glenn Morris <rgm@gnu.org>
2053
2054 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2055 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2056 and add some more files.
2057
2058 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2059
2060 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2061 report_file_error introduced by the change from 2011-05-07.
2062
2063 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2064
2065 * systime.h (Time): Define only if emacs is defined.
2066 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2067 where the include path doesn't have X11/X.h by default. See
2068 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2069
2070 2011-05-20 Kenichi Handa <handa@m17n.org>
2071
2072 * composite.c (find_automatic_composition): Fix previous change.
2073
2074 2011-05-20 Glenn Morris <rgm@gnu.org>
2075
2076 * lisp.mk: New file, split from Makefile.in.
2077 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2078 (shortlisp): Remove.
2079 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2080
2081 2011-05-19 Glenn Morris <rgm@gnu.org>
2082
2083 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2084 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2085 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2086 (lisp): Set the order to that of loadup.el.
2087 (shortlisp): Make it a copy of $lisp.
2088 (SOME_MACHINE_LISP): Remove.
2089 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2090 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2091
2092 2011-05-18 Kenichi Handa <handa@m17n.org>
2093
2094 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2095 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2096 (find_automatic_composition): Mostly rewrite for efficiency.
2097
2098 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2099
2100 * makefile.w32-in: Update dependencies.
2101
2102 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2103
2104 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2105 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2106
2107 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2108
2109 Fix some integer overflow issues, such as string length overflow.
2110
2111 * insdel.c (count_size_as_multibyte): Check for string overflow.
2112
2113 * character.c (lisp_string_width): Check for string overflow.
2114 Use EMACS_INT, not int, for string indexes and lengths; in
2115 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2116 the resulting string length overflows an EMACS_INT; instead,
2117 report a string overflow if no precision given. When checking for
2118 precision exhaustion, use a check that cannot possibly have
2119 integer overflow. (Bug#8675)
2120 * character.h (lisp_string_width): Adjust to new signature.
2121
2122 * alloc.c (string_overflow): New function.
2123 (Fmake_string): Use it. This doesn't change behavior, but saves
2124 a few bytes and will simplify future changes.
2125 * character.c (string_escape_byte8): Likewise.
2126 * lisp.h (string_overflow): New decl.
2127
2128 Fixups, following up to the user-interface timestamp change.
2129 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2130 for UI timestamps, instead of unsigned long.
2131 * msdos.c (mouse_get_pos): Likewise.
2132 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2133 * w32gui.h (Time): Define by including "systime.h" rather than by
2134 declaring it ourselves. (Bug#8664)
2135
2136 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2137 * image.c (clear_image_cache): Likewise.
2138
2139 * term.c (term_mouse_position): Don't assume time_t wraparound.
2140
2141 Be more systematic about user-interface timestamps.
2142 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2143 and sometimes 'EMACS_UINT', to represent these timestamps.
2144 This change causes it to use 'Time' uniformly, as that's what X uses.
2145 This makes the code easier to follow, and makes it easier to catch
2146 integer overflow bugs such as Bug#8664.
2147 * frame.c (Fmouse_position, Fmouse_pixel_position):
2148 Use Time, not unsigned long, for user-interface timestamps.
2149 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2150 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2151 * keyboard.h (last_event_timestamp): Likewise.
2152 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2153 * menu.h (xmenu_show): Likewise.
2154 * term.c (term_mouse_position): Likewise.
2155 * termhooks.h (struct input_event.timestamp): Likewise.
2156 (struct terminal.mouse_position_hook): Likewise.
2157 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2158 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2159 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2160 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2161 what it was before.
2162 * menu.h, termhooks.h: Include "systime.h", for Time.
2163
2164 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2165 Don't assume that the difference between two unsigned long values
2166 can fit into an integer. At this point, we know button_down_time
2167 <= event->timestamp, so the difference must be nonnegative, so
2168 there's no need to cast the result if double-click-time is
2169 nonnegative, as it should be; check that it's nonnegative, just in
2170 case. This bug is triggered when events are more than 2**31 ms
2171 apart (about 25 days). (Bug#8664)
2172
2173 * xselect.c (last_event_timestamp): Remove duplicate decl.
2174 (x_own_selection): Remove needless cast to unsigned long.
2175
2176 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2177 that always fit in int. Use a sentinel instead of a counter, to
2178 avoid a temp and to allay GCC's concerns about possible int overflow.
2179 * frame.h (struct frame): Use int for menu_bar_items_used
2180 instead of EMACS_INT, since it always fits in int.
2181
2182 * menu.c (grow_menu_items): Check for int overflow.
2183
2184 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2185
2186 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2187 Before, the code was not consistent. These values cannot exceed
2188 2**31 - 1 so there's no need to make them unsigned.
2189 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2190 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2191 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2192 as modifiers.
2193 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2194
2195 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2196 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2197 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2198 presumably because the widths might not match.
2199
2200 * window.c (size_window): Avoid needless test at loop start.
2201
2202 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2203
2204 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2205
2206 2011-05-12 Drew Adams <drew.adams@oracle.com>
2207
2208 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2209
2210 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2211
2212 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2213 `width' to `bar_area_x' and `bar_area_width', respectively.
2214 (x_scroll_run): Take account of fringe background extension.
2215
2216 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2217 Rename local vars `left' and `width' to `bar_area_x' and
2218 `bar_area_width', respectively.
2219 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2220 background extension.
2221
2222 2011-05-10 Jim Meyering <meyering@redhat.com>
2223
2224 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2225
2226 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2227
2228 * image.c (Finit_image_library): Return t for built-in image types,
2229 like pbm and xbm. (Bug#8640)
2230
2231 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2232
2233 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2234
2235 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2236
2237 * w32console.c (Fset_screen_color): Doc fix.
2238 (Fget_screen_color): New function.
2239 (syms_of_ntterm): Defsubr it.
2240
2241 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2242 unlink the temporary file if Fcall_process didn't create it in the
2243 first place.
2244 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2245 child process will be redirected to a file specified with `:file'.
2246 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2247 cue to call_process_cleanup not to close that handle.
2248
2249 2011-05-07 Ben Key <bkey76@gmail.com>
2250
2251 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2252 one of two shell specific rules, either bootstrap-temacs-CMD or
2253 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2254 to the previous implementation of the bootstrap-temacs rule.
2255 The bootstrap-temacs-CMD rule is similar to the previous
2256 implementation of the bootstrap-temacs rule except that it
2257 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2258 variable.
2259
2260 These changes, along with some changes to nt/configure.bat,
2261 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2262 earlier fix to add support for --cflags and --ldflags options
2263 that include quotes so that it works whether make uses cmd or
2264 sh as the shell.
2265
2266 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2267
2268 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2269 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2270 is a constant.
2271 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2272 a string. Handle both cases.
2273 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2274 (Fdbus_register_method): Use Qinvalid_function.
2275
2276 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2277
2278 * makefile.w32-in: Update dependencies.
2279 (LISP_H): Add inttypes.h and stdin.h.
2280 (PROCESS_H): Add unistd.h.
2281
2282 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2283
2284 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2285 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2286
2287 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2288
2289 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2290
2291 * term.c (vfatal): Remove stray call to va_end.
2292 It's not needed and the C Standard doesn't allow it here anyway.
2293
2294 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2295 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2296
2297 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2298 bytes.
2299
2300 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2301
2302 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2303
2304 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2305
2306 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2307
2308 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2309
2310 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2311 * charset.c (Fdefine_charset_internal): Don't initialize
2312 charset.code_space[15]. The value was garbage, on hosts with
2313 32-bit int (Bug#8600).
2314
2315 * lread.c (read_integer): Be more consistent with string-to-number.
2316 Use string_to_number to do the actual conversion; this avoids
2317 rounding errors and fixes some other screwups. Without this fix,
2318 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2319 (digit_to_number): Move earlier, for benefit of read_integer.
2320 Return -1 if the digit is out of range for the base, -2 if it is
2321 not a digit in any supported base. (Bug#8602)
2322
2323 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2324
2325 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2326 to match comment at start of function. This also removes a
2327 GCC warning about overflow in a 32+64-bit port.
2328
2329 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2330
2331 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2332 Reported by Stefan Monnier in
2333 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2334 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2335 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2336
2337 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2338 (EMACS_UINTPTR): Likewise, with uintptr_t.
2339
2340 * lisp.h: Prefer 64-bit EMACS_INT if available.
2341 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2342 on 32-bit hosts that have 64-bit int, so that they can access
2343 large files.
2344 However, temporarily disable this change unless the temporary
2345 symbol WIDE_EMACS_INT is defined.
2346
2347 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2348
2349 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2350 This removes an assumption that EMACS_INT and long are the same
2351 width as pointers. The assumption is true for Emacs porting targets
2352 now, but we want to make other targets possible.
2353 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2354 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2355 In the rest of the code, change types of integers that hold casted
2356 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2357 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2358 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2359 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2360 No need to cast type when ORing.
2361 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2362 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2363 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2364 assume EMACS_INT is the same width as char *.
2365 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2366 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2367 Remove no-longer-needed casts.
2368 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2369 (xg_tool_bar_help_callback, xg_make_tool_item):
2370 Use EMACS_INTPTR to hold an integer
2371 that will be cast to void *; this can avoid a GCC warning
2372 if EMACS_INT is not the same width as void *.
2373 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2374 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2375 (current_message_1, set_message_1):
2376 Use a local to convert to proper width without a cast.
2377 * xmenu.c (dialog_selection_callback): Likewise.
2378
2379 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2380 Also, don't assume VALBITS / RAND_BITS is less than 5,
2381 and don't rely on undefined behavior when shifting a 1 left into
2382 the sign bit.
2383 * lisp.h (get_random): Change signature to match.
2384
2385 * lread.c (hash_string): Use size_t, not int, for hash computation.
2386 Normally we prefer signed values; but hashing is special, because
2387 it's better to use unsigned division on hash table sizes so that
2388 the remainder is nonnegative. Also, size_t is the natural width
2389 for hashing into memory. The previous code used 'int', which doesn't
2390 retain enough info to hash well into very large tables.
2391 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2392
2393 * dbusbind.c: Don't possibly lose pointer info when converting.
2394 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2395 Use XPNTR rather than XHASH, so that the high-order bits of
2396 the pointer aren't lost when converting through void *.
2397
2398 * eval.c (Fautoload): Don't double-shift a pointer.
2399
2400 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2401
2402 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2403
2404 * gnutls.c (DEF_GNUTLS_FN):
2405 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2406
2407 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2408
2409 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2410 marker. (Bug#8610)
2411
2412 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2413
2414 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2415 New version that can reserve upto 2GB of heap space.
2416
2417 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2418
2419 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2420
2421 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2422
2423 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2424 `gnutls_certificate_set_x509_key_file'.
2425
2426 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2427
2428 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2429 Update dependencies.
2430
2431 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2432
2433 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2434 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2435 Remove unused parameter `fildes'.
2436 * process.c (read_process_output, send_process): Don't pass it.
2437
2438 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2439
2440 Fix previous change: the library cache is defined in w32.c.
2441 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2442 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2443
2444 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2445
2446 Implement dynamic loading of GnuTLS on Windows.
2447
2448 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2449 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2450 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2451 Declare.
2452
2453 * gnutls.c (Qgnutls_dll): Define.
2454 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2455 (gnutls_*): Declare function pointers.
2456 (init_gnutls_functions): New function to initialize function pointers.
2457 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2458 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2459 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2460 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2461 (emacs_gnutls_write, emacs_gnutls_read)
2462 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2463 (Fgnutls_available_p): New function.
2464 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2465 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2466 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2467
2468 * image.c: Include w32.h.
2469 (Vimage_type_cache): Delete.
2470 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2471 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2472 (w32_delayed_load): Move to w32.c.
2473
2474 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2475
2476 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2477 (w32_delayed_load): Move from image.c. When loading a library, record
2478 its filename in the :loaded-from property of the library id.
2479 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2480 Initialize and staticpro them.
2481 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2482
2483 * process.c: Include lisp.h before w32.h, not after.
2484 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2485 instead of gnutls_record_check_pending.
2486
2487 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2488
2489 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2490
2491 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2492 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2493 as passed in.
2494
2495 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2496
2497 * xterm.c (x_set_frame_alpha): Do not set property on anything
2498 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2499
2500 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2501
2502 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2503
2504 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2505
2506 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2507 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2508 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2509 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2510 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2511 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2512 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2513 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2514 (Qgnutls_bootprop_callbacks_verify): Make static.
2515
2516 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2517
2518 * callproc.c: Indentation fixup.
2519
2520 * sysdep.c (wait_for_termination_1): Make static.
2521 (wait_for_termination, interruptible_wait_for_termination):
2522 Move after wait_for_termination_1.
2523
2524 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2525
2526 * sysdep.c (interruptible_wait_for_termination): New function
2527 which is like wait_for_termination, but allows keyboard
2528 interruptions.
2529
2530 * callproc.c (Fcall_process): Add (:file "file") as an option for
2531 the STDOUT buffer.
2532 (Fcall_process_region): Ditto.
2533
2534 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2535
2536 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2537 rather than `XVECTOR (FOO)->size'.
2538
2539 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2540 inttypes.h, as a gnulib replacement is used if it not available in
2541 system headers.
2542
2543 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2544
2545 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2546 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2547 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2548
2549 * coding.c (coding_alloc_by_realloc): Error out if destination
2550 will grow beyond MOST_POSITIVE_FIXNUM.
2551 (decode_coding_emacs_mule): Abort if there isn't enough place in
2552 charbuf for the composition carryover bytes. Reserve an extra
2553 space for up to 2 characters produced in a loop.
2554 (decode_coding_iso_2022): Abort if there isn't enough place in
2555 charbuf for the composition carryover bytes.
2556
2557 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2558
2559 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2560 aborting when %lld or %lll format is passed.
2561 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2562 %llo or %llx format is passed. (Bug#8545)
2563
2564 * window.c (window_scroll_line_based): Use a marker instead of
2565 simple variables to record original value of point. (Bug#7952)
2566
2567 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2568 produced by %s or %c overflows available buffer space. (Bug#8545)
2569
2570 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2571
2572 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2573 (SIZE_MAX): Move defn after all includes, as they might #define it.
2574
2575 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2576
2577 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2578
2579 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2580
2581 * keyboard.c (Qdelayed_warnings_hook): Define.
2582 (command_loop_1): Run `delayed-warnings-hook'
2583 if Vdelayed_warnings_list is non-nil.
2584 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2585 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2586
2587 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2588
2589 * doprnt.c (doprnt): Don't return value smaller than the buffer
2590 size if the message was truncated. (Bug#8545).
2591
2592 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2593
2594 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2595 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2596
2597 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2598
2599 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2600
2601 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2602
2603 * makefile.w32-in: Update dependencies.
2604
2605 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2606
2607 Improve `doprnt' and its usage. (Bug#8545)
2608 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2609 `format_end'. Remove support for %l as a conversion specifier.
2610 Don't use xrealloc. Improve diagnostics when the %l size modifier
2611 is used. Update the commentary.
2612
2613 * eval.c (verror): Simplify calculation of size_t.
2614
2615 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2616 messages.
2617
2618 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2619
2620 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2621 change.
2622
2623 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2624
2625 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2626 This makes this file independent of the recent pseudovector change.
2627
2628 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2629
2630 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2631
2632 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2633 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2634 Remove unused local.
2635 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2636
2637 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2638 GCC 4.6.0 optimizes based on type-based alias analysis.
2639 For example, if b is of type struct buffer * and v of type struct
2640 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2641 != &v->size, and therefore "v->size = 1; b->size = 2; return
2642 v->size;" must therefore return 1. This assumption is incorrect
2643 for Emacs, since it type-puns struct Lisp_Vector * with many other
2644 types. To fix this problem, this patch adds a new type struct
2645 vectorlike_header that documents the constraints on layout of vectors
2646 and pseudovectors, and helps optimizing compilers not get fooled
2647 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2648 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2649 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2650 the size member.
2651 (XSETPVECTYPE): Rewrite in terms of new macro.
2652 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2653 This is a bit clearer, and further avoids the possibility of
2654 undesirable aliasing.
2655 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2656 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2657 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2658 since Lisp_Subr is a special case (no "next" field).
2659 (ASIZE): Now uses header.size rather than size.
2660 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2661 to avoid the hassle of writing XVECTOR (foo)->header.size.
2662 (struct vectorlike_header): New type.
2663 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2664 object, to help avoid aliasing.
2665 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2666 (SUBRP): Likewise, since Lisp_Subr is a special case.
2667 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2668 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2669 (struct Lisp_Hash_Table): Combine first two members into a single
2670 struct vectorlike_header member. All uses of "size" and "next" members
2671 changed to be "header.size" and "header.next".
2672 * buffer.h (struct buffer): Likewise.
2673 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2674 * frame.h (struct frame): Likewise.
2675 * process.h (struct Lisp_Process): Likewise.
2676 * termhooks.h (struct terminal): Likewise.
2677 * window.c (struct save_window_data, struct saved_window): Likewise.
2678 * window.h (struct window): Likewise.
2679 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2680 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2681 * buffer.c (init_buffer_once): Likewise.
2682 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2683 special case.
2684 * process.c (Fformat_network_address): Use local var for size,
2685 for brevity.
2686
2687 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2688
2689 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2690 * data.c (atof): Remove decl; no longer used or needed.
2691 (digit_to_number): Move to lread.c.
2692 (Fstring_to_number): Use new string_to_number function, to be
2693 consistent with how the Lisp reader treats infinities and NaNs.
2694 Do not assume that floating-point numbers represent EMACS_INT
2695 without losing information; this is not true on most 64-bit hosts.
2696 Avoid double-rounding errors, by insisting on integers when
2697 parsing non-base-10 numbers, as the documentation specifies.
2698 * lisp.h (string_to_number): New decl, replacing ...
2699 (isfloat_string): Remove.
2700 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2701 (read1): Do not accept +. and -. as integers; this
2702 appears to have been a coding error. Similarly, do not accept
2703 strings like +-1e0 as floating point numbers. Do not report
2704 overflow for integer overflows unless the base is not 10 which
2705 means we have no simple and reliable way to continue.
2706 Break out the floating-point parsing into a new
2707 function string_to_number, so that Fstring_to_number parses
2708 floating point numbers consistently with the Lisp reader.
2709 (digit_to_number): Move here from data.c. Make it static inline.
2710 (E_CHAR, EXP_INT): Remove, replacing with ...
2711 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2712 (string_to_number): New function, replacing isfloat_string.
2713 This function checks for valid syntax and produces the resulting
2714 Lisp float number too. Rework it so that string-to-number
2715 no longer mishandles examples like "1.0e+". Use strtoumax,
2716 so that overflow for non-base-10 numbers is reported only when
2717 there's no portable and simple way to convert to floating point.
2718
2719 * textprop.c (set_text_properties_1): Rewrite for clarity,
2720 and to avoid GCC warning about integer overflow.
2721
2722 * intervals.h (struct interval): Use EMACS_INT for members
2723 where EMACS_UINT might cause problems. See
2724 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2725 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2726 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2727 All uses changed.
2728 (offset_intervals): Tell GCC not to worry about length overflow
2729 when negating a negative length.
2730
2731 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2732 (overrun_check_free): Likewise.
2733
2734 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2735 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2736 word size.
2737
2738 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2739 (gnutls_make_error): Rename local to avoid shadowing.
2740 (gnutls_emacs_global_deinit): ifdef out; not used.
2741 (Fgnutls_boot): Use const for pointer to readonly storage.
2742 Comment out unused local. Fix pointer signedness problems.
2743
2744 * lread.c (openp): Don't stuff size_t into an 'int'.
2745 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2746 about possible signed overflow.
2747
2748 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2749 (GDK_KEY_g): Don't define if already defined.
2750 (xg_prepare_tooltip): Avoid pointer signedness problem.
2751 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2752
2753 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2754 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2755
2756 * xfns.c (Fx_window_property): Simplify a bit,
2757 to make a bit faster and to avoid GCC 4.6.0 warning.
2758 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2759
2760 * fns.c (internal_equal): Don't assume size_t fits in int.
2761
2762 * alloc.c (compact_small_strings): Tighten assertion a little.
2763
2764 Replace pEd with more-general pI, and fix some printf arg casts.
2765 * lisp.h (pI): New macro, generalizing old pEd macro to other
2766 conversion specifiers. For example, use "...%"pI"d..." rather
2767 than "...%"pEd"...".
2768 (pEd): Remove. All uses replaced with similar uses of pI.
2769 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2770 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2771 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2772 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2773 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2774 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2775 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2776 64-bit hosts.
2777 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2778 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2779 * print.c (safe_debug_print, print_object): Likewise.
2780 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2781 to int.
2782 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2783 avoiding the 0 flag, which is not portable.
2784 * process.c (Fmake_network_process): Use pI to avoid cast.
2785 * region-cache.c (pp_cache): Likewise.
2786 * xdisp.c (decode_mode_spec): Likewise.
2787 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2788 behavior on 64-bit hosts with printf arg.
2789 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2790 (x_stop_queuing_selection_requests): Likewise.
2791 (x_get_window_property): Don't truncate byte count to an 'int'
2792 when tracing.
2793
2794 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2795 here, since it parses constructs like leading '-' and spaces,
2796 which are not wanted; and it overflows with large numbers.
2797 Instead, simply match F[0-9]+, which is what is wanted anyway.
2798
2799 * alloc.c: Remove unportable assumptions about struct layout.
2800 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2801 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2802 (allocate_vectorlike, make_pure_vector): Use the new macros,
2803 plus offsetof, to remove unportable assumptions about struct layout.
2804 These assumptions hold on all porting targets that I know of, but
2805 they are not guaranteed, they're easy to remove, and removing them
2806 makes further changes easier.
2807
2808 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2809 This doesn't fix a bug but makes the code clearer.
2810 (string_overrun_cookie): Now const. Use initializers that
2811 don't formally overflow signed char, to avoid warnings.
2812 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2813 can cause Emacs to crash when string overrun checking is enabled.
2814 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2815 multiple of sizeof (EMACS_INT); it need not be, if
2816 alignof(EMACS_INT) < sizeof (EMACS_INT).
2817 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2818
2819 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2820
2821 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2822
2823 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2824
2825 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2826 supposed to be handshaking. (Bug#8556)
2827 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2828
2829 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2830
2831 * lisp.h (Qdebug): List symbol.
2832 * eval.c (Qdebug): Restore global linkage.
2833 * keyboard.c (debug-on-event): New variable.
2834 (handle_user_signal): Break into debugger when debug-on-event
2835 matches the current signal symbol.
2836
2837 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2838
2839 * alloc.c (check_sblock, check_string_bytes)
2840 (check_string_free_list): Convert to standard C.
2841
2842 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2843
2844 * w32.c (emacs_gnutls_push): Fix typo.
2845
2846 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2847
2848 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2849 "cast to pointer from integer of different size".
2850
2851 Improve doprnt and its use in verror. (Bug#8545)
2852 * doprnt.c (doprnt): Document the set of format control sequences
2853 supported by the function. Use SAFE_ALLOCA instead of always
2854 using `alloca'.
2855
2856 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2857 is one byte too soon. Don't use xrealloc; instead xfree and
2858 xmalloc anew.
2859
2860 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2861
2862 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2863 callbacks stage.
2864
2865 * gnutls.c: Renamed global_initialized to
2866 gnutls_global_initialized. Added internals for the
2867 :verify-hostname-error, :verify-error, and :verify-flags
2868 parameters of `gnutls-boot' and documented those parameters in the
2869 docstring. Start callback support.
2870 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2871 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2872 on error. Return error code.
2873 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2874 (emacs_gnutls_read): Likewise.
2875 (Fgnutls_boot): Return handshake error code.
2876 (emacs_gnutls_handle_error): New function.
2877 (wsaerror_to_errno): Likewise.
2878
2879 * w32.h (emacs_gnutls_pull): Add prototype.
2880 (emacs_gnutls_push): Likewise.
2881
2882 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2883 (emacs_gnutls_push): Likewise.
2884
2885 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2886
2887 * process.c (wait_reading_process_output): Check if GnuTLS
2888 buffered some data internally if no FDs are set for TLS
2889 connections.
2890
2891 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2892 (LIBS): Link to USER_LIBS.
2893 ($(BLD)/gnutls.$(0)): New target.
2894
2895 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2896
2897 * xdisp.c (handle_single_display_spec): Rename the
2898 display_replaced_before_p argument into display_replaced_p, to
2899 make it consistent with the commentary. Fix typos in the
2900 commentary.
2901
2902 * textprop.c (syms_of_textprop): Remove dead code.
2903 (copy_text_properties): Delete obsolete commentary about an
2904 interface that was deleted long ago. Fix typos in the description
2905 of arguments.
2906
2907 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2908 to changes in oldXMenu/XMenu.h from 2011-04-16.
2909 <menu_help_message, prev_menu_help_message>: Constify.
2910 (IT_menu_make_room): menu->help_text is now `const char **';
2911 adjust.
2912
2913 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2914 to changes in oldXMenu/XMenu.h from 2011-04-16.
2915 (struct XMenu): Declare `help_text' `const char **'.
2916
2917 * xfaces.c <Qunspecified>: Make extern again.
2918
2919 * syntax.c: Include sys/types.h before including regex.h, as
2920 required by Posix.
2921
2922 * doc.c (get_doc_string): Improve the format passed to `error'.
2923
2924 * doprnt.c (doprnt): Improve commentary.
2925
2926 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2927
2928 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2929 them with etags.
2930
2931 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2932 changes in globals.h immediately force recompilation.
2933 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2934 $(CURDIR)/s/ms-w32.h.
2935 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2936
2937 * character.c (Fchar_direction): Function deleted.
2938 (syms_of_character): Don't defsubr it.
2939 <char-direction-table>: Deleted.
2940
2941 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2942
2943 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2944 * doprnt.c: Include limits.h.
2945 (SIZE_MAX): New macro.
2946 (doprnt): Return a size_t value. 2nd arg is now size_t.
2947 Many local variables are now size_t instead of int or unsigned.
2948 Improve overflow protection. Support `l' modifier for integer
2949 conversions. Support %l conversion. Don't assume an EMACS_INT
2950 argument for integer conversions and for %c.
2951
2952 * lisp.h (doprnt): Restore prototype.
2953
2954 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2955 $(SRC)/character.h.
2956
2957 * Makefile.in (base_obj): Add back doprnt.o.
2958
2959 * deps.mk (doprnt.o): Add back prerequisites.
2960 (callint.o): Depend on character.h.
2961
2962 * eval.c (internal_lisp_condition_case): Include the handler
2963 representation in the error message.
2964 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2965 when breaking from the loop.
2966
2967 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2968
2969 * callint.c (Fcall_interactively): When displaying error message
2970 about invalid control letter, pass the character's codepoint, not
2971 a pointer to its multibyte form. Improve display of the character
2972 in octal and display also its hex code.
2973
2974 * character.c (char_string): Use %x to display the (unsigned)
2975 codepoint of an invalid character, to avoid displaying a bogus
2976 negative value.
2977
2978 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2979 `error', not SYMBOL_NAME itself.
2980
2981 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2982 character arguments to `error'.
2983
2984 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2985 to `error' in error message about FINAL_CHAR argument. Make sure
2986 FINAL_CHAR is a character, and use %c when it is passed as
2987 argument to `error'.
2988
2989 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2990
2991 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2992
2993 * w32.c: Include <time.h>.
2994 (sys_localtime): New function.
2995
2996 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2997
2998 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2999
3000 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3001
3002 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3003
3004 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3005 zombies (Bug#8467).
3006
3007 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3008
3009 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3010 gl_state.e_property when gl_state.object is Qt.
3011
3012 * insdel.c (make_gap_larger): Remove limitation of buffer size
3013 to <= INT_MAX.
3014
3015 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3016
3017 * xdisp.c (lookup_glyphless_char_display)
3018 (produce_glyphless_glyph): Handle cons cell entry in
3019 glyphless-char-display.
3020 (Vglyphless_char_display): Document it.
3021
3022 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3023 glyphless-char-display.
3024
3025 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3026
3027 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3028
3029 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3030
3031 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3032 definition for no-X builds.
3033
3034 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3035
3036 Static checks with GCC 4.6.0 and non-default toolkits.
3037
3038 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3039
3040 * process.c (keyboard_bit_set): Define only if SIGIO.
3041 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3042 (send_process): Repair possible setjmp clobbering.
3043
3044 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3045
3046 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3047
3048 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3049
3050 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3051 Define only if needed.
3052
3053 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3054 by pacifying GCC about it. Maybe it's time to retire it?
3055 * xfaces.c (USG, __TIMEVAL__): Likewise.
3056
3057 * dispextern.h (struct redisplay_interface): Rename param
3058 to avoid shadowing.
3059 * termhooks.h (struct terminal): Likewise.
3060 * xterm.c (xembed_send_message): Likewise.
3061
3062 * insdel.c (make_gap_smaller): Define only if
3063 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3064
3065 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3066 it.
3067
3068 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3069 so that we aren't warned about unused symbols.
3070
3071 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3072
3073 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3074
3075 * xfns.c (x_real_positions): Mark locals as initialized.
3076
3077 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3078
3079 * xterm.c: Fix problems found by static analysis with other toolkits.
3080 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3081 (x_dispatch_event): Declare static if USE_GTK, and
3082 define if USE_GTK || USE_X_TOOLKIT.
3083 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3084 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3085 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3086 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3087
3088 * xmenu.c (menu_help_callback): Pointer type fixes.
3089 Use const pointers when pointing at readonly data. Avoid pointer
3090 signedness clashes.
3091 (FALSE): Remove unused macro.
3092 (update_frame_menubar): Remove unused decl.
3093
3094 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3095
3096 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3097 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3098 (single_menu_item): Rename local to avoid shadowing.
3099
3100 * keyboard.c (make_lispy_event): Remove unused local var.
3101
3102 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3103 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3104
3105 * bitmaps: Change bitmaps from unsigned char back to the X11
3106 compatible char. Avoid the old compiler warnings about
3107 out-of-range initializers by using, for example, '\xab' rather
3108 than 0xab.
3109
3110 * xgselect.c (xgselect_initialize): Check vs interface
3111 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3112
3113 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3114
3115 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3116 to read-only memory.
3117
3118 * fns.c (vector): Remove; this old hack is no longer needed.
3119
3120 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3121 Remove unused var.
3122 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3123
3124 * xrdb.c (x_load_resources): Omit unused local.
3125
3126 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3127 (x_window): Rename locals to avoid shadowing.
3128 (USG): Use the kludged USG macro, to pacify gcc.
3129
3130 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3131 (x_term_init): Remove local to avoid shadowing.
3132
3133 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3134
3135 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3136 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3137
3138 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3139
3140 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3141
3142 Fix regex.c, syntax.c and friends for buffers > 2GB.
3143 * syntax.h (struct gl_state_s): Declare character position members
3144 EMACS_INT.
3145
3146 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3147
3148 * textprop.c (verify_interval_modification, interval_of):
3149 Declare arguments EMACS_INT.
3150
3151 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3152 EMACS_INT.
3153
3154 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3155
3156 * indent.c (Fvertical_motion): Local variable it_start is now
3157 EMACS_INT.
3158
3159 * regex.c (re_match, re_match_2, re_match_2_internal)
3160 (bcmp_translate, regcomp, regexec, print_double_string)
3161 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3162 (re_compile_pattern, re_exec): Declare arguments and local
3163 variables `size_t' and `ssize_t' and return values `regoff_t', as
3164 appropriate.
3165 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3166 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3167 <compile_stack_type>: `size' and `avail' are now `size_t'.
3168
3169 * regex.h <regoff_t>: Use ssize_t, not int.
3170 (re_search, re_search_2, re_match, re_match_2): Arguments that
3171 specify buffer/string position and length are now ssize_t and
3172 size_t. Return type is regoff_t.
3173
3174 2011-04-16 Ben Key <bkey76@gmail.com>
3175
3176 * nsfont.m: Fixed bugs in ns_get_family and
3177 ns_descriptor_to_entity that were caused by using free to
3178 deallocate memory blocks that were allocated by xmalloc (via
3179 xstrdup). This caused Emacs to crash when compiled with
3180 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3181 --enable-checking=xmallocoverrun). xfree is now used to
3182 deallocate these memory blocks.
3183
3184 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3185
3186 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3187
3188 emacs_write: Accept and return EMACS_INT for sizes.
3189 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3190 et seq.
3191 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3192 Accept and return EMACS_INT.
3193 (emacs_gnutls_write): Return the number of bytes written on
3194 partial writes.
3195 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3196 (emacs_read, emacs_write): Remove check for negative size, as the
3197 Emacs source code has been audited now.
3198 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3199 (emacs_read, emacs_write): Use it.
3200 * process.c (send_process): Adjust to the new signatures of
3201 emacs_write and emacs_gnutls_write. Do not attempt to store
3202 a byte offset into an 'int'; it might overflow.
3203 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3204
3205 * sound.c: Don't assume sizes fit in 'int'.
3206 (struct sound_device.period_size, alsa_period_size):
3207 Return EMACS_INT, not int.
3208 (struct sound_device.write, vox_write, alsa_write):
3209 Accept EMACS_INT, not int.
3210 (wav_play, au_play): Use EMACS_INT to store sizes and to
3211 record read return values.
3212
3213 2011-04-15 Ben Key <bkey76@gmail.com>
3214
3215 * keyboard.c (Qundefined): Don't declare static since it is used
3216 in nsfns.m.
3217 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3218 static since they are used in nsfont.m.
3219
3220 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3221
3222 * process.c (Qprocessp): Don't declare static.
3223 * lisp.h (Qprocessp): Declare again.
3224
3225 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3226
3227 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3228
3229 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3230
3231 Improve C-level modularity by making more things 'static'.
3232
3233 Don't publish debugger-only interfaces to other modules.
3234 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3235 (verify_bytepos, count_markers): Move decls to the only modules
3236 that need them.
3237 * region-cache.h (pp_cache): Likewise.
3238 * window.h (check_all_windows): Likewise.
3239 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3240
3241 * sysdep.c (croak): Now static, if
3242 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3243 * syssignal.h (croak): Declare only if not static.
3244
3245 * alloc.c (refill_memory_reserve): Now static if
3246 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3247 * lisp.h (refill_memory_reserve): Declare only if not static.
3248
3249 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3250 Define only if USE_LUCID.
3251
3252 * xrdb.c (x_customization_string, x_rm_string): Now static.
3253
3254 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3255 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3256
3257 * xdisp.c (draw_row_with_mouse_face): Now static.
3258 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3259
3260 * window.h (check_all_windows): Mark externally visible.
3261
3262 * window.c (window_deletion_count): Now static.
3263
3264 * undo.c: Make symbols static if they're not exported.
3265 (last_undo_buffer, last_boundary_position, pending_boundary):
3266 Now static.
3267
3268 * textprop.c (interval_insert_behind_hooks): Now static.
3269 (interval_insert_in_front_hooks): Likewise.
3270
3271 * term.c: Make symbols static if they're not exported.
3272 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3273 (max_frame_lines, tty_set_terminal_modes):
3274 (tty_reset_terminal_modes, tty_turn_off_highlight):
3275 (get_tty_terminal): Now static.
3276 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3277 * termhooks.h (term_mouse_moveto): Do not declare if
3278 HAVE_WINDOW_SYSTEM.
3279 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3280 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3281
3282 * sysdep.c: Make symbols static if they're not exported.
3283 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3284 Now static.
3285 (sigprocmask_set, full_mask): Remove; unused.
3286 (wait_debugging): Mark as visible.
3287 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3288 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3289
3290 * syntax.c (syntax_temp): Define only if !__GNUC__.
3291
3292 * sound.c (current_sound_device, current_sound): Now static.
3293
3294 * search.c (searchbufs, searchbuf_head): Now static.
3295
3296 * scroll.c (scroll_cost): Remove; unused.
3297 * dispextern.h (scroll_cost): Remove decl.
3298
3299 * region-cache.h (pp_cache): Mark as externally visible.
3300
3301 * process.c: Make symbols static if they're not exported.
3302 (process_tick, update_tick, create_process, chan_process):
3303 (Vprocess_alist, proc_buffered_char, datagram_access):
3304 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3305 (deactivate_process): Mark defn as static, as well as decl.
3306 * lisp.h (create_process): Remove decl.
3307 * process.h (chan_process, Vprocess_alist): Remove decls.
3308
3309 * print.c: Make symbols static if they're not exported.
3310 (print_depth, new_backquote_output, being_printed, print_buffer):
3311 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3312 (print_interval, print_number_index, initial_stderr_stream):
3313 Now static.
3314 * lisp.h (Fprinc): Remove decl.
3315 (debug_output_compilation_hack): Mark as externally visible.
3316
3317 * sysdep.c (croak): Move decl from here to syssignal.h.
3318 * syssignal.h (croak): Put it here, so the API can be checked when
3319 'croak' is called from dissociate_if_controlling_tty.
3320
3321 * minibuf.c: Make symbols static if they're not exported.
3322 (minibuf_save_list, choose_minibuf_frame): Now static.
3323 * lisp.h (choose_minibuf_frame): Remove decl.
3324
3325 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3326
3327 * lread.c: Make symbols static if they're not exported.
3328 (read_objects, initial_obarray, oblookup_last_bucket_number):
3329 Now static.
3330 (make_symbol): Remove; unused.
3331 * lisp.h (initial_obarray, make_symbol): Remove decls.
3332
3333 * keyboard.c: Make symbols static if they're not exported.
3334 (single_kboard, recent_keys_index, total_keys, recent_keys):
3335 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3336 (this_single_command_key_start, echoing, last_auto_save):
3337 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3338 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3339 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3340 (Vlispy_mouse_stem, double_click_count):
3341 Now static.
3342 (force_auto_save_soon): Define only if SIGDANGER.
3343 (ignore_mouse_drag_p): Now static if
3344 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3345 (print_help): Remove; unused.
3346 (stop_character, last_timer_event): Mark as externally visible.
3347 * keyboard.h (ignore_mouse_drag_p): Declare only if
3348 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3349 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3350 * lisp.h (echoing): Remove decl.
3351 (force_auto_save_soon): Declare only if SIGDANGER.
3352 * xdisp.c (redisplay_window): Simplify code, to make it more
3353 obvious that ignore_mouse_drag_p is not accessed if !defined
3354 USE_GTK && !defined HAVE_NS.
3355
3356 * intervals.c: Make symbols static if they're not exported.
3357 (merge_properties_sticky, merge_interval_right, delete_interval):
3358 Now static.
3359 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3360
3361 * insdel.c: Make symbols static if they're not exported.
3362 However, leave prepare_to_modify_buffer alone. It's never
3363 called from outside this function, but that appears to be a bug.
3364 (combine_after_change_list, combine_after_change_buffer):
3365 (adjust_after_replace, signal_before_change): Now static.
3366 (adjust_after_replace_noundo): Remove; unused.
3367 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3368 (signal_before_change): Remove decls.
3369
3370 * indent.c (val_compute_motion, val_vmotion): Now static.
3371
3372 * image.c: Make symbols static if they're not exported.
3373 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3374 if USE_GTK.
3375 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3376 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3377
3378 * fringe.c (standard_bitmaps): Now static.
3379 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3380
3381 * frame.c: Make symbols static if they're not exported.
3382 (x_report_frame_params, make_terminal_frame): Now static.
3383 (get_frame_param): Now static, unless HAVE_NS.
3384 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3385 (x_get_resource_string): Remove; not used.
3386 * frame.h (make_terminal_frame, x_report_frame_params):
3387 (x_get_resource_string); Remove decls.
3388 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3389 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3390
3391 * font.c, fontset.c: Make symbols static if they're not exported.
3392 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3393 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3394 * font.c (font_close_object): Now static.
3395 * font.h (font_close_object): Remove.
3396 * fontset.c (FONTSET_OBJLIST): Remove.
3397 (free_realized_fontset) #if-0 the body, which does nothing.
3398 (face_suitable_for_char_p): #if-0, as it's never called.
3399 * fontset.h (face_suitable_for_char_p): Remove decl.
3400 * xfaces.c (face_at_string_position):
3401 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3402 since 0 is always ASCII.
3403
3404 * fns.c (weak_hash_tables): Now static.
3405
3406 * fileio.c: Make symbols static if they're not exported.
3407 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3408 (Vwrite_region_annotation_buffers): Now static.
3409
3410 * eval.c: Make symbols static if they're not exported.
3411 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3412 * lisp.h (backtrace_list): Remove decl.
3413
3414 * emacs.c: Make symbols static if they're not exported.
3415 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3416 (fatal_error_code, fatal_error_signal_hook, standard_args):
3417 Now static.
3418 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3419 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3420 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3421 * lisp.h (fatal_error_signal_hook): Remove decl.
3422 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3423
3424 * editfns.c: Move a (normally-unused) function to its only use.
3425 * editfns.c, lisp.h (get_operating_system_release): Remove.
3426 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3427 worth the hassle of breaking this out.
3428
3429 * xterm.c: Make symbols static if they're not exported.
3430 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3431 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3432 (x_destroy_window, x_delete_display):
3433 Now static.
3434 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3435 (x_mouse_leave): Remove; unused.
3436 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3437 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3438 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3439 Remove decls.
3440 (x_mouse_leave): Declare only if WINDOWSNT.
3441 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3442 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3443 USE_X_TOOLKIT.
3444
3445 * ftxfont.c: Make symbols static if they're not exported.
3446 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3447 HAVE_FREETYPE.
3448 * font.h (ftxfont_driver): Likewise.
3449
3450 * xfns.c: Make symbols static if they're not exported.
3451 (x_last_font_name, x_display_info_for_name):
3452 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3453 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3454 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3455 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3456 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3457 (last_show_tip_args): Now static.
3458 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3459 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3460 (x_screen_planes): Remove; unused.
3461 * dispextern.h (x_screen_planes): Remove decl.
3462
3463 * dispnew.c: Make symbols static if they're not exported.
3464 * dispextern.h (redraw_garbaged_frames, scrolling):
3465 (increment_row_positions): Remove.
3466 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3467 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3468 Now static.
3469 (redraw_garbaged_frames): Remove; unused.
3470
3471 * xfaces.c: Make symbols static if they're not exported.
3472 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3473 Remove decls.
3474 * xterm.h (defined_color): Remove decls.
3475 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3476 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3477 (menu_face_changed_default, defined_color, free_realized_face):
3478 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3479 (ascii_face_of_lisp_face): Remove; unused.
3480
3481 * xdisp.c: Make symbols static if they're not exported.
3482 * dispextern.h (scratch_glyph_row, window_box_edges):
3483 (glyph_to_pixel_coords, set_cursor_from_row):
3484 (get_next_display_element, set_iterator_to_next):
3485 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3486 (show_mouse_face): Remove decls
3487 * frame.h (message_buf_print): Likewise.
3488 * lisp.h (pop_message, set_message, check_point_in_composition):
3489 Likewise.
3490 * xterm.h (set_vertical_scroll_bar): Likewise.
3491 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3492 (message_buf_print, scratch_glyph_row, displayed_buffer):
3493 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3494 (get_next_display_element, show_mouse_face, window_box_edges):
3495 (frame_to_window_pixel_xy, check_point_in_composition):
3496 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3497 (glyph_to_pixel_coords): Remove; unused.
3498
3499 * dired.c (file_name_completion): Now static.
3500
3501 * dbusbind.c (xd_in_read_queued_messages): Now static.
3502
3503 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3504 * data.c (circular_list_error): Remove.
3505
3506 * commands.h (last_point_position, last_point_position_buffer):
3507 (last_point_position_window): Remove decls.
3508 * keyboard.c: Make these variables static.
3509
3510 * coding.h (coding, code_convert_region, encode_coding_gap):
3511 Remove decls.
3512 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3513 (iso_code_class, detect_coding, code_convert_region): Now static.
3514 (encode_coding_gap): Remove; unused.
3515
3516 * chartab.c (chartab_chars, chartab_bits): Now static.
3517
3518 * charset.h (charset_iso_8859_1): Remove decl.
3519 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3520 Now static.
3521
3522 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3523 * ccl.c (Vccl_program_table): Now static.
3524 (check_ccl_update): Remove; unused.
3525
3526 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3527 * category.h: ... from here.
3528 * category.c (check_category_table, set_category_set): Now static.
3529
3530 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3531 * lisp.h: Remove these decls.
3532
3533 * buffer.c (buffer_count): Remove unused var.
3534
3535 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3536 so that it's not optimized away.
3537 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3538 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3539 exported only to the debugger.
3540
3541 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3542 * atimer.h (run_all_atimers): Remove; not exported.
3543
3544 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3545 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3546 was inaccessible from Lisp.
3547 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3548 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3549
3550 alloc.c: Import and export fewer symbols, and remove unused items.
3551 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3552 is defined.
3553 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3554 it's not optimized away by whole-program optimization.
3555 (message_enable_multibyte, free_misc): Remove.
3556 (catchlist, handlerlist, mark_backtrace):
3557 Declare only if BYTE_MARK_STACK.
3558 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3559 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3560 (message_enable_multibyte): Remove decl.
3561 (free_misc, interval_free_list, float_block, float_block_index):
3562 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3563 (cons_free_list, last_marked_index):
3564 Now static.
3565 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3566 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3567 (mark_backtrace): Define only if BYTE_MARK_STACK.
3568 * xdisp.c (message_enable_multibyte): Now static.
3569
3570 Declare Lisp_Object Q* variables to be 'static' if not exported.
3571 This makes it easier for human readers (and static analyzers)
3572 to see whether these variables are used from other modules.
3573 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3574 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3575 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3576 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3577 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3578 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3579 * xmenu.c, xselect.c:
3580 Declare Q* vars static if they are not used in other modules.
3581 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3582 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3583 Remove decls of unexported vars.
3584 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3585
3586 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3587
3588 Make Emacs functions such as Fatom 'static' by default.
3589 This makes it easier for human readers (and static analyzers)
3590 to see whether these functions can be called from other modules.
3591 DEFUN now defines a static function. To make the function external
3592 so that it can be used in other C modules, use the new macro DEFUE.
3593 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3594 (Finit_image_library):
3595 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3596 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3597 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3598 Remove decls, since these functions are now static.
3599 (Funintern, Fget_internal_run_time): New decls, since these functions
3600 were already external.
3601
3602 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3603 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3604 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3605 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3606 * keyboard.c, keymap.c, lread.c:
3607 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3608 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3609 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3610 Mark functions with DEFUE instead of DEFUN,
3611 if they are used in other modules.
3612 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3613 decls for now-static functions.
3614 * buffer.h (Fdelete_overlay): Remove decl.
3615 * callproc.c (Fgetenv_internal): Mark as internal.
3616 * composite.c (Fremove_list_of_text_properties): Remove decl.
3617 (Fcomposition_get_gstring): New forward static decl.
3618 * composite.h (Fcomposite_get_gstring): Remove decl.
3619 * dired.c (Ffile_attributes): New forward static decl.
3620 * doc.c (Fdocumntation_property): New forward static decl.
3621 * eval.c (Ffetch_bytecode): New forward static decl.
3622 (Funintern): Remove extern decl; now in .h file where it belongs.
3623 * fileio.c (Fmake_symbolic_link): New forward static decl.
3624 * image.c (Finit_image_library): New forward static decl.
3625 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3626 * intervals.h (Fprevious_property_change):
3627 (Fremove_list_of_text_properties): Remove decls.
3628 * keyboard.c (Fthis_command_keys): Remove decl.
3629 (Fcommand_execute): New forward static decl.
3630 * keymap.c (Flookup_key): New forward static decl.
3631 (Fcopy_keymap): Now static.
3632 * keymap.h (Flookup_key): Remove decl.
3633 * process.c (Fget_process): New forward static decl.
3634 (Fprocess_datagram_address): Mark as internal.
3635 * syntax.c (Fsyntax_table_p): New forward static decl.
3636 (skip_chars): Remove duplicate decl.
3637 * textprop.c (Fprevious_property_change): New forward static decl.
3638 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3639 Now internal.
3640 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3641 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3642
3643 * editfns.c (Fformat): Remove unreachable code.
3644
3645 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3646
3647 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3648 change. (Bug#8496)
3649
3650 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3651
3652 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3653 when at ZV. (Bug#8487)
3654
3655 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3656
3657 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3658 (Bug#8437)
3659 * keyboard.c (parse_tool_bar_item): Likewise.
3660 * sound.c (sound_cleanup, alsa_close): Likewise.
3661 * termcap.c (tgetent): Likewise.
3662 * xfns.c (x_default_font_parameter): Likewise.
3663 * xsettings.c (read_and_apply_settings): Likewise.
3664
3665 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3666 (overrun_check_free): Protoize.
3667
3668 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3669
3670 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3671 since callers should never pass a negative size.
3672 Change the signature to match that of plain 'read' and 'write'; see
3673 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3674 * lisp.h: Update prototypes of emacs_write and emacs_read.
3675
3676 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3677
3678 * xdisp.c (redisplay_window): Don't try to determine the character
3679 position of the scroll margin if the window start point w->startp
3680 is outside the buffer's accessible region. (Bug#8468)
3681
3682 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3683
3684 Fix write-region and its subroutines for buffers > 2GB.
3685 * fileio.c (a_write, e_write): Modify declaration of arguments and
3686 local variables to support buffers larger than 2GB.
3687 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3688
3689 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3690 argument, local variables, and return value.
3691
3692 * lisp.h: Update prototypes of emacs_write and emacs_read.
3693
3694 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3695
3696 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3697
3698 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3699
3700 Fix more problems found by GCC 4.6.0's static checks.
3701
3702 * xdisp.c (vmessage): Use a better test for character truncation.
3703
3704 * charset.c (load_charset_map): <, not <=, for optimization,
3705 and to avoid potential problems with integer overflow.
3706 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3707 * casetab.c (set_identity, shuffle): Likewise.
3708 * editfns.c (Fformat): Likewise.
3709 * syntax.c (skip_chars): Likewise.
3710
3711 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3712 This also lets GCC 4.6.0 generate slightly better loop code.
3713
3714 * callint.c (Fcall_interactively): <, not <=, for optimization.
3715 (Fcall_interactively): Count the number of arguments produced,
3716 not the number of arguments given. This is simpler and lets GCC
3717 4.6.0 generate slightly better code.
3718
3719 * ftfont.c: Distingish more carefully between FcChar8 and char.
3720 The previous code passed unsigned char * to a functions like
3721 strlen and xstrcasecmp that expect char *, which does not
3722 conform to the C standard.
3723 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3724 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3725 char * when the C standard requires it.
3726
3727 * keyboard.c (read_char): Remove unused var.
3728
3729 * eval.c: Port to Windows vsnprintf (Bug#8435).
3730 Include <limits.h>.
3731 (SIZE_MAX): Define if the headers do not.
3732 (verror): Do not give up if vsnprintf returns a negative count.
3733 Instead, grow the buffer. This ports to Windows vsnprintf, which
3734 does not conform to C99. Problem reported by Eli Zaretskii.
3735 Also, simplify the allocation scheme, by avoiding the need for
3736 calling realloc, and removing the ALLOCATED variable.
3737
3738 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3739
3740 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3741 But keep the doprint source code for now, as we might revamp it
3742 and use it again (Bug#8435).
3743 * lisp.h (doprnt): Remove.
3744 * Makefile.in (base_obj): Remove doprnt.o.
3745 * deps.mk (doprnt.o): Remove.
3746
3747 error: Print 32- and 64-bit integers portably (Bug#8435).
3748 Without this change, on typical 64-bit hosts error ("...%d...", N)
3749 was used to print both 32- and 64-bit integers N, which relied on
3750 undefined behavior.
3751 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3752 New macro.
3753 * lisp.h (error, verror): Mark as printf-like functions.
3754 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3755 Report overflow in size calculations when allocating printf buffer.
3756 Do not truncate output string at its first null byte.
3757 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3758 Truncate the output at a character boundary, since vsnprintf does not
3759 do that.
3760 * charset.c (check_iso_charset_parameter): Convert internal
3761 character to string before calling 'error', since %c now has the
3762 printf meaning.
3763 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3764 overflow when computing char to be passed to 'error'. Do not
3765 pass Lisp_Object to 'error'; pass the integer instead.
3766 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3767 formatted with plain %d.
3768
3769 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3770
3771 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3772
3773 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3774
3775 * xterm.c (x_catch_errors): Remove duplicate declaration.
3776
3777 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3778
3779 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3780
3781 2011-04-10 Jim Meyering <meyering@redhat.com>
3782
3783 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3784 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3785 return ssize_t not "int", and use size_t as the buffer length.
3786 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3787 * gnutls.h: Update declarations.
3788 * process.c (read_process_output): Use ssize_t, to match.
3789 (send_process): Likewise.
3790
3791 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3792
3793 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3794
3795 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3796
3797 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3798 Use unsigned char, to match FcChar8 type definition.
3799
3800 * xterm.c (handle_one_xevent):
3801 * xmenu.c (create_and_show_popup_menu):
3802 * xselect.c (x_decline_selection_request)
3803 (x_reply_selection_request): Avoid type-punned deref of X events.
3804
3805 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3806
3807 Fix some uses of `int' instead of EMACS_INT.
3808 * search.c (string_match_1, fast_string_match)
3809 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3810 (scan_buffer, find_next_newline_no_quit)
3811 (find_before_next_newline, search_command, Freplace_match)
3812 (Fmatch_data): Make some `int' variables be EMACS_INT.
3813
3814 * xdisp.c (display_count_lines): 3rd argument and return value now
3815 EMACS_INT. All callers changed.
3816 (pint2hrstr): Last argument is now EMACS_INT.
3817
3818 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3819 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3820 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3821 (decode_coding_utf_16, decode_coding_emacs_mule)
3822 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3823 (decode_coding_ccl, decode_coding_charset)
3824 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3825 (decode_coding_iso_2022, decode_coding_emacs_mule)
3826 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3827 <char_offset, last_offset>: Declare EMACS_INT.
3828 (encode_coding_utf_8, encode_coding_utf_16)
3829 (encode_coding_emacs_mule, encode_invocation_designation)
3830 (encode_designation_at_bol, encode_coding_iso_2022)
3831 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3832 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3833 Declare EMACS_INT.
3834 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3835 (encode_invocation_designation): Last argument P_NCHARS is now
3836 EMACS_INT.
3837 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3838 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3839
3840 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3841 All users changed.
3842
3843 * ccl.c (Fccl_execute_on_string): Declare some variables
3844 EMACS_INT.
3845
3846 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3847
3848 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3849
3850 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3851
3852 * process.c (Fformat_network_address): Doc fix.
3853
3854 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3855
3856 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3857
3858 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3859
3860 * keyboard.c (read_char): Call Lisp function help-form-show,
3861 instead of using internal_with_output_to_temp_buffer.
3862 (Qhelp_form_show): New var.
3863 (syms_of_keyboard): Use DEFSYM macro.
3864
3865 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3866
3867 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3868
3869 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3870
3871 * process.c (Flist_processes): Remove to Lisp.
3872 (list_processes_1): Delete.
3873
3874 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3875
3876 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3877
3878 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3879
3880 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3881
3882 Fix more problems found by GCC 4.6.0's static checks.
3883
3884 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3885
3886 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3887
3888 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3889
3890 * xdisp.c (vmessage): Mark as a printf-like function.
3891
3892 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3893
3894 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3895
3896 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3897 printf-like functions.
3898 (tiff_load): Add casts to remove these marks before passing them
3899 to system-supplied API.
3900
3901 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3902
3903 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3904 This avoids several warnings with gcc -Wstrict-overflow.
3905 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3906 directly, rather than having caller test rule sign. This avoids
3907 some unnecessary tests.
3908 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3909 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3910 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3911
3912 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3913 (xfont_open): Avoid unnecessary tests.
3914
3915 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3916
3917 * composite.h, composite.c (composition_gstring_put_cache):
3918 Use EMACS_INT, not int, for length.
3919
3920 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3921 breaking out part of COMPOSITION_DECODE_RULE.
3922 (COMPOSITION_DECODE_RULE): Use it.
3923 * composite.c (get_composition_id): Remove unused local vars,
3924 by using the new macro.
3925
3926 * textprop.c (set_text_properties_1): Change while to do-while,
3927 since the condition is always true at first.
3928
3929 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3930 (interval_deletion_adjustment): Return unsigned value.
3931 All uses changed.
3932
3933 * process.c (list_processes_1, create_pty, read_process_output):
3934 (exec_sentinel): Remove vars that were set but not used.
3935 (create_pty): Remove unnecessary "volatile"s.
3936 (Fnetwork_interface_info): Avoid possibility of int overflow.
3937 (read_process_output): Do adaptive read buffering even if carryover.
3938 (read_process_output): Simplify nbytes computation if buffered.
3939
3940 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3941
3942 * syntax.c (scan_words): Remove var that was set but not used.
3943 (update_syntax_table): Use unsigned instead of int.
3944
3945 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3946 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3947 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3948
3949 * print.c (print_error_message): Avoid int overflow.
3950
3951 * font.c (font_list_entities): Redo for clarity,
3952 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3953
3954 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3955 (font_score): Avoid potential overflow in diff calculation.
3956
3957 * fns.c (substring_both): Remove var that is set but not used.
3958 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3959
3960 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3961
3962 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3963 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3964 can always succeed if overflow has undefined behavior.
3965
3966 * search.c (boyer_moore, wordify): Remove vars set but not used.
3967 (wordify): Omit three unnecessary tests.
3968
3969 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3970 All callers changed. This avoids the need for an unused var.
3971
3972 * casefiddle.c (casify_region): Remove var that is set but not used.
3973
3974 * dired.c (file_name_completion): Remove var that is set but not used.
3975
3976 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3977
3978 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3979 (Finsert_file_contents): Remove unnecessary code checking fd.
3980
3981 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3982 Check for integer overflow on size calculations.
3983
3984 * buffer.c (Fprevious_overlay_change): Remove var that is set
3985 but not used.
3986
3987 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3988 Remove vars that are set but not used.
3989 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3990 (timer_check_2): Mark vars as initialized.
3991
3992 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3993
3994 * image.c (lookup_image): Remove var that is set but not used.
3995 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3996
3997 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3998 that are set but not used.
3999
4000 * xfns.c (make_invisible_cursor): Don't return garbage
4001 if XCreateBitmapFromData fails (Bug#8410).
4002
4003 * xselect.c (x_get_local_selection, x_handle_property_notify):
4004 Remove vars that are set but not used.
4005
4006 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4007 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4008
4009 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4010 Remove var that is set but not used.
4011 (scroll_bar_windows_size): Now size_t, not int.
4012 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4013 Check for overflow.
4014
4015 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4016 (map_tty_color) [!defined MSDOS]: Likewise.
4017
4018 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4019
4020 * coding.c: Remove vars that are set but not used.
4021 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4022 All callers changed.
4023 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4024 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4025 (decode_coding_charset): Remove vars that are set but not used.
4026
4027 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4028 that is set but not used.
4029
4030 * print.c (print_object): Remove var that is set but not used.
4031
4032 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4033 The gnulib version avoids calling malloc in the usual case,
4034 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4035 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4036 * filelock.c (current_lock_owner): Likewise.
4037 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4038 * sysdep.c: Include allocator.h, careadlinkat.h.
4039 (emacs_no_realloc_allocator): New static constant.
4040 (emacs_readlink): New function.
4041 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4042 ../lib/careadlinkat.h.
4043
4044 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4045
4046 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4047 first non-nil return value).
4048
4049 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4050
4051 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4052 if not defined (Bug#8403).
4053
4054 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4055
4056 * xdisp.c (display_count_lines): Remove parameter `start',
4057 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4058 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4059 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4060 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4061 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4062 and thereabouts. All callers changed.
4063 (get_per_char_metric): Remove parameter `f', unused since
4064 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4065
4066 2011-04-02 Jim Meyering <meyering@redhat.com>
4067
4068 do not dereference NULL upon failed strdup
4069 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4070 (ns_get_family): Likewise.
4071
4072 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4073
4074 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4075
4076 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4077
4078 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4079 later (Bug#8403).
4080
4081 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4082
4083 Add lexical binding.
4084
4085 * window.c (Ftemp_output_buffer_show): New fun.
4086 (Fsave_window_excursion):
4087 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4088
4089 * lread.c (lisp_file_lexically_bound_p): New function.
4090 (Fload): Bind Qlexical_binding.
4091 (readevalloop): Remove `evalfun' arg.
4092 Bind Qinternal_interpreter_environment.
4093 (Feval_buffer): Bind Qlexical_binding.
4094 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4095 Mark as dynamic.
4096 (syms_of_lread): Declare `lexical-binding'.
4097
4098 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4099
4100 * keyboard.c (eval_dyn): New fun.
4101 (menu_item_eval_property): Use it.
4102
4103 * image.c (parse_image_spec): Use Ffunctionp.
4104
4105 * fns.c (concat, mapcar1): Accept byte-code-functions.
4106
4107 * eval.c (Fsetq): Handle lexical vars.
4108 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4109 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4110 (FletX, Flet): Obey lexical binding.
4111 (Fcommandp): Handle closures.
4112 (Feval): New `lexical' arg.
4113 (eval_sub): New function extracted from Feval. Use it almost
4114 everywhere where Feval was used. Look up vars in lexical env.
4115 Handle closures.
4116 (Ffunctionp): Move from subr.el.
4117 (Ffuncall): Handle closures.
4118 (apply_lambda): Remove `eval_flags'.
4119 (funcall_lambda): Handle closures and new byte-code-functions.
4120 (Fspecial_variable_p): New function.
4121 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4122 but without exporting it to Lisp.
4123
4124 * doc.c (Fdocumentation, store_function_docstring):
4125 * data.c (Finteractive_form): Handle closures.
4126
4127 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4128 interactive spec.
4129
4130 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4131 New byte-codes.
4132 (exec_byte_code): New function extracted from Fbyte_code to handle new
4133 calling convention for byte-code-functions. Add new byte-codes.
4134
4135 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4136
4137 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4138
4139 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4140
4141 * xdisp.c (redisplay_internal): Fix prototype.
4142
4143 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4144
4145 * xdisp.c (SCROLL_LIMIT): New macro.
4146 (try_scrolling): Use it when setting scroll_limit.
4147 Limit scrolling to 100 screen lines.
4148 (redisplay_window): Even when falling back on "recentering",
4149 position point in the window according to scroll-conservatively,
4150 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4151
4152 (try_scrolling): When point is above the window, allow searching
4153 as far as scroll_max, or one screenful, to compute vertical
4154 distance from PT to the scroll margin position. This prevents
4155 try_scrolling from unnecessarily failing when
4156 scroll-conservatively is set to a value slightly larger than the
4157 window height. Clean up the case of PT below the margin at bottom
4158 of window: scroll_max can no longer be INT_MAX. When aggressive
4159 scrolling is in use, don't let point enter the opposite scroll
4160 margin as result of the scroll.
4161 (syms_of_xdisp) <scroll-conservatively>: Document the
4162 threshold of 100 lines for never-recentering scrolling.
4163
4164 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4165
4166 * dispextern.h (move_it_by_lines):
4167 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4168 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4169 (message_log_check_duplicate): Remove parameters `prev_bol' and
4170 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4171 (redisplay_internal): Remove parameter `preserve_echo_area',
4172 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4173
4174 * indent.c (Fvertical_motion):
4175 * window.c (window_scroll_pixel_based, Frecenter):
4176 Don't pass `need_y_p' to `move_it_by_lines'.
4177
4178 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4179
4180 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4181 steal a few bits to be more compact.
4182 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4183 Remove unneeded casts.
4184
4185 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4186
4187 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4188
4189 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4190 binding" message (bug#7967).
4191
4192 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4193
4194 Fix more problems found by GCC 4.6.0's static checks.
4195
4196 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4197 Remove unused local var.
4198
4199 * editfns.c (Fmessage_box): Remove unused local var.
4200
4201 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4202 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4203 Omit unused local vars.
4204 * window.c (shrink_windows): Omit unused local var.
4205 * menu.c (digest_single_submenu): Omit unused local var.
4206 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4207 Omit unused local var.
4208
4209 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4210 Don't assume string length fits in int.
4211 (keyremap_step, read_key_sequence): Use size_t for sizes.
4212 (read_key_sequence): Don't check last_real_key_start redundantly.
4213
4214 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4215 instead of alloca (Bug#8344).
4216
4217 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4218 (Fbacktrace_frame): Don't assume nframes fits in int.
4219
4220 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4221
4222 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4223 concerns.
4224
4225 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4226
4227 * cm.c (calccost): Turn while-do into do-while, for clarity.
4228
4229 * keyboard.c (syms_of_keyboard): Use the same style as later
4230 in this function when indexing through an array. This also
4231 works around GCC bug 48267.
4232
4233 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4234
4235 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4236
4237 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4238 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4239
4240 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4241 This avoids undefined behavior on integer overflow, and is a bit
4242 more convenient anyway since it is compared to a size_t variable.
4243
4244 Variadic C functions now count arguments with size_t, not int.
4245 This avoids an unnecessary limitation on 64-bit machines, which
4246 caused (substring ...) to crash on large vectors (Bug#8344).
4247 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4248 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4249 All variadic functions and their callers changed accordingly.
4250 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4251 * data.c (arith_driver, float_arith_driver): Likewise.
4252 * editfns.c (general_insert_function): Likewise.
4253 * eval.c (struct backtrace.nargs, interactive_p)
4254 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4255 (funcall_lambda, mark_backtrace): Likewise.
4256 * fns.c (concat): Likewise.
4257 * frame.c (x_set_frame_parameters): Likewise.
4258 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4259 0 if not found, not -1. All callers changed.
4260
4261 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4262 (stack_copy_size): Now size_t, not int.
4263 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4264
4265 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4266
4267 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4268 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4269 All callers changed.
4270
4271 * lisp.h (multibyte_char_to_unibyte):
4272 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4273 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4274 * character.h (CHAR_TO_BYTE8):
4275 * cmds.c (internal_self_insert):
4276 * editfns.c (general_insert_function):
4277 * keymap.c (push_key_description):
4278 * search.c (Freplace_match):
4279 * xdisp.c (message_dolog, set_message_1): All callers changed.
4280
4281 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4282
4283 * keyboard.c (safe_run_hook_funcall): New function.
4284 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4285 don't set the hook to nil, but remove the offending function instead.
4286 (Qcommand_hook_internal): Remove, unused.
4287 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4288 Vcommand_hook_internal.
4289
4290 * eval.c (enum run_hooks_condition): Remove.
4291 (funcall_nil, funcall_not): New functions.
4292 (run_hook_with_args): Call each function through a `funcall' argument.
4293 Remove `cond' argument, now redundant.
4294 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4295 (Frun_hook_with_args_until_failure): Adjust accordingly.
4296 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4297
4298 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4299
4300 * dispextern.h (string_buffer_position): Remove declaration.
4301
4302 * print.c (strout): Remove parameter `multibyte', unused since
4303 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4304
4305 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4306 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4307 All callers changed.
4308
4309 * w32.c (_wsa_errlist): Use braces for struct initializers.
4310
4311 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4312 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4313 All callers changed.
4314 (string_buffer_position): Likewise. Also, make static (it's never
4315 used outside xdisp.c).
4316 (cursor_row_p): Remove parameter `w', unused since
4317 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4318 (decode_mode_spec): Remove parameter `precision', introduced during
4319 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4320 All callers changed.
4321
4322 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4323
4324 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4325
4326 2011-03-27 Anders Lindgren <andlind@gmail.com>
4327
4328 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4329 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4330 (ns_update_auto_hide_menu_bar): New functions.
4331 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4332 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4333 ns_constrain_all_frames.
4334 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4335 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4336
4337 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4338
4339 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4340
4341 2011-03-27 Glenn Morris <rgm@gnu.org>
4342
4343 * syssignal.h: Replace RETSIGTYPE with void.
4344 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4345 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4346 Replace SIGTYPE with void everywhere.
4347 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4348 * s/template.h (SIGTYPE): Remove commented out definition.
4349
4350 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4351
4352 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4353 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4354
4355 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4356
4357 * w32.c (read_unc_volume): Use parameter `henum', instead of
4358 global variable `wget_enum_handle'.
4359
4360 * keymap.c (describe_vector): Remove parameters `indices' and
4361 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4362 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4363
4364 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4365
4366 * keyboard.c (timer_check): Remove parameter `do_it_now',
4367 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4368 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4369 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4370
4371 * keyboard.c (read_char):
4372 * w32menu.c (w32_menu_display_help):
4373 * xmenu.c (show_help_event, menu_help_callback):
4374 Adjust calls to `show_help_echo'.
4375
4376 * gtkutil.c (xg_maybe_add_timer):
4377 * keyboard.c (readable_events):
4378 * process.c (wait_reading_process_output):
4379 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4380
4381 * insdel.c (adjust_markers_gap_motion):
4382 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4383 (gap_left, gap_right): Don't call it.
4384
4385 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4386
4387 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4388 incurred during fontification.
4389
4390 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4391
4392 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4393 (DEFVAR_PER_BUFFER): Don't pass it.
4394
4395 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4396 (scrolling_window): Don't pass it.
4397
4398 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4399
4400 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4401
4402 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4403 and `suffix'.
4404 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4405 of variables specific to SELinux and computation of `encoded_absname'.
4406
4407 * image.c (XPutPixel): Remove unused variable `height'.
4408
4409 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4410
4411 * unexw32.c (get_section_info): Remove unused variable `section'.
4412
4413 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4414 (system_process_attributes): Remove unused variable `sess'.
4415 (sys_read): Remove unused variable `err'.
4416
4417 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4418 (w32_wnd_proc): Remove unused variable `isdead'.
4419 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4420 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4421 (x_create_tip_frame): Remove unused variable `tem'.
4422
4423 * w32inevt.c (w32_console_read_socket):
4424 Remove unused variable `no_events'.
4425
4426 * w32term.c (x_draw_composite_glyph_string_foreground):
4427 Remove unused variable `width'.
4428
4429 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4430
4431 * w32term.c (x_set_glyph_string_clipping):
4432 Don't pass uninitialized region to CombineRgn.
4433
4434 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4435
4436 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4437 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4438 (Fx_close_connection): Remove unused variable `i'.
4439
4440 * w32font.c (w32font_draw): Return number of glyphs.
4441 (w32font_open_internal): Remove unused variable `i'.
4442 (w32font_driver): Add missing initializer.
4443
4444 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4445 (fill_in_menu): Remove unused variable `items_added'.
4446
4447 * w32term.c (last_mouse_press_frame): Remove static global variable.
4448 (w32_clip_to_row): Remove unused variable `f'.
4449 (x_delete_terminal): Remove unused variable `i'.
4450
4451 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4452 (NOTHING): Remove unused static global variable.
4453 (uniscribe_check_otf): Remove unused variable `table'.
4454 (uniscribe_font_driver): Add missing initializers.
4455
4456 2011-03-23 Julien Danjou <julien@danjou.info>
4457
4458 * term.c (Fsuspend_tty, Fresume_tty):
4459 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4460 * window.c (temp_output_buffer_show):
4461 * insdel.c (signal_before_change):
4462 * frame.c (Fhandle_switch_frame):
4463 * fileio.c (Fdo_auto_save):
4464 * emacs.c (Fkill_emacs):
4465 * editfns.c (save_excursion_restore):
4466 * cmds.c (internal_self_insert):
4467 * callint.c (Fcall_interactively):
4468 * buffer.c (Fkill_all_local_variables):
4469 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4470 Use Frun_hooks.
4471 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4472 unconditionnaly since it does the check itself.
4473
4474 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4475
4476 Fix more problems found by GCC 4.5.2's static checks.
4477
4478 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4479 the first time through the loop, since we know p0 < p1 then.
4480 This also avoids a gcc -Wstrict-overflow warning.
4481
4482 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4483 leading to a memory leak, possible in functions like
4484 load_charset_map_from_file that can allocate an unbounded number
4485 of objects (Bug#8318).
4486
4487 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4488 that could (at least in theory) be that large.
4489
4490 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4491 This is less likely to overflow, and avoids undefined behavior if
4492 overflow does occur. All callers changed. Use strtoul to scan
4493 for the unsigned long integer.
4494 (pint2hrstr): Simplify and tune code slightly.
4495 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4496
4497 * scroll.c (do_scrolling): Work around GCC bug 48228.
4498 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4499
4500 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4501 This also avoids a warning with gcc -Wstrict-overflow.
4502 (validate_x_resource_name): Simplify count usage.
4503 This also avoids a warning with gcc -Wstrict-overflow.
4504
4505 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4506 fail (Bug#8306).
4507
4508 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4509
4510 * process.c (Fmake_network_process): Use socklen_t, not int,
4511 where POSIX says socklen_t is required in portable programs.
4512 This fixes a porting bug on hosts like 64-bit HP-UX, where
4513 socklen_t is wider than int (Bug#8277).
4514 (Fmake_network_process, server_accept_connection):
4515 (wait_reading_process_output, read_process_output):
4516 Likewise.
4517
4518 * process.c: Rename or move locals to avoid shadowing.
4519 (list_processes_1, Fmake_network_process):
4520 (read_process_output_error_handler, exec_sentinel_error_handler):
4521 Rename or move locals.
4522 (Fmake_network_process): Define label "retry_connect" only if needed.
4523 (Fnetwork_interface_info): Fix pointer signedness.
4524 (process_send_signal): Add cast to avoid pointer signedness problem.
4525 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4526 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4527
4528 Make tparam.h and terminfo.c consistent.
4529 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4530 Include tparam.h instead, since it declares them.
4531 * cm.h (PC): Remove extern decl; tparam.h now does this.
4532 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4533 * terminfo.c: Include tparam.h, to check interfaces.
4534 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4535 (tparam): Adjust signature to match interface in tparam.h;
4536 this removes some undefined behavior. Check that outstring and len
4537 are zero, which they always are with Emacs.
4538 * tparam.h (PC, BC, UP): New extern decls.
4539
4540 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4541 (xftfont_open): Rename locals to avoid shadowing.
4542
4543 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4544 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4545 (OTF_TAG_SYM): Omit macro if not needed.
4546 (ftfont_list): Remove unused local.
4547 (get_adstyle_property, ftfont_pattern_entity):
4548 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4549 Rename locals to avoid shadowing.
4550
4551 * xfont.c (xfont_list_family): Mark var as initialized.
4552
4553 * xml.c (make_dom): Now static.
4554
4555 * composite.c (composition_compute_stop_pos): Rename local to
4556 avoid shadowing.
4557 (composition_reseat_it): Remove unused locals.
4558 (find_automatic_composition, composition_adjust_point): Likewise.
4559 (composition_update_it): Mark var as initialized.
4560 (find_automatic_composition): Mark vars as initialized,
4561 with a FIXME (Bug#8290).
4562
4563 character.h: Rename locals to avoid shadowing.
4564 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4565 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4566 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4567 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4568 to avoid shadowing.
4569
4570 * textprop.c (property_change_between_p): Remove; unused.
4571
4572 * intervals.c (interval_start_pos): Now static.
4573
4574 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4575
4576 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4577 Rename locals to avoid shadowing.
4578
4579 * sound.c (wav_play, au_play, Fplay_sound_internal):
4580 Fix pointer signedness.
4581 (alsa_choose_format): Remove unused local var.
4582 (wav_play): Initialize a variable to 0, to prevent undefined
4583 behavior (Bug#8278).
4584
4585 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4586
4587 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4588
4589 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4590 clobbering (Bug#8298).
4591 * sysdep.c (sys_subshell): Likewise.
4592 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4593
4594 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4595 This should get cleaned up, so that child_setup has the
4596 same signature on all platforms.
4597
4598 * callproc.c (call_process_cleanup): Now static.
4599 (relocate_fd): Rename locals to avoid shadowing.
4600
4601 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4602
4603 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4604 not to be necessary, and produces flickering.
4605
4606 2011-03-20 Glenn Morris <rgm@gnu.org>
4607
4608 * config.in: Remove file.
4609
4610 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4611
4612 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4613 are now in src/globals.h.
4614 (syms_of_minibuf): Remove spurious & from previous change.
4615
4616 2011-03-20 Leo <sdl.web@gmail.com>
4617
4618 * minibuf.c (completing-read-function): New variable.
4619 (completing-read-default): Rename from completing-read.
4620 (completing-read): Call completing-read-function.
4621
4622 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4623
4624 * xfaces.c (Fx_load_color_file):
4625 Read color file from absolute filename (bug#8250).
4626
4627 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4628
4629 * makefile.w32-in: Update dependencies.
4630
4631 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4632
4633 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4634
4635 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4636
4637 Fix more problems found by GCC 4.5.2's static checks.
4638
4639 * process.c (make_serial_process_unwind, send_process_trap):
4640 (sigchld_handler): Now static.
4641
4642 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4643 That way, the code declares only the vars that it needs.
4644 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4645 * s/cygwin.h (PTY_ITERATION): Likewise.
4646 * s/darwin.h (PTY_ITERATION): Likewise.
4647 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4648
4649 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4650 * process.c (allocate_pty): Don't declare stb unless it's needed.
4651
4652 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4653 (CONSTANTLIM): Remove; unused.
4654 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4655 Define only if needed.
4656
4657 * unexelf.c (unexec): Name an expression,
4658 to avoid gcc -Wbad-function-cast warning.
4659 Use a different way to cause a compilation error if anyone uses
4660 n rather than nn, a way that does not involve shadowing.
4661 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4662
4663 * deps.mk (unexalpha.o): Remove; unused.
4664
4665 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4666 * unexec.h: New file.
4667 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4668 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4669 Depend on unexec.h.
4670 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4671 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4672 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4673 Change as necessary to match prototype in unexec.h.
4674
4675 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4676 shadowing.
4677 (back_comment, skip_chars): Mark vars as initialized.
4678
4679 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4680 Rename locals to avoid shadowing.
4681
4682 * lread.c (read1): Rewrite so as not to use empty "else".
4683 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4684
4685 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4686
4687 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4688 warning when compiling print.c.
4689
4690 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4691 instead of using an uninitialized var.
4692 (font_sort_entities): Mark var as initialized.
4693
4694 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4695
4696 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4697 pointers to constants.
4698 (font_parse_fcname): Remove unused vars.
4699 (font_delete_unmatched): Now static.
4700 (font_get_spec): Remove; unused.
4701 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4702 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4703 Rename or move locals to avoid shadowing.
4704
4705 * fns.c (require_nesting_list, require_unwind): Now static.
4706 (Ffillarray): Rename locals to avoid shadowing.
4707
4708 * floatfns.c (domain_error2): Define only if needed.
4709 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4710
4711 * alloc.c (mark_backtrace): Move decl from here ...
4712 * lisp.h: ... to here, so that it can be checked.
4713
4714 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4715 (Fdefvar): Rewrite so as not to use empty "else".
4716 (lisp_indirect_variable): Name an expression,
4717 to avoid gcc -Wbad-function-cast warning.
4718 (Fdefvar): Rename locals to avoid shadowing.
4719
4720 * callint.c (quotify_arg, quotify_args): Now static.
4721 (Fcall_interactively): Rename locals to avoid shadowing.
4722 Use const pointer when appropriate.
4723
4724 * lisp.h (get_system_name, get_operating_system_release):
4725 Move decls here, to check interfaces.
4726 * process.c (get_operating_system_release): Move decl to lisp.h.
4727 * xrdb.c (get_system_name): Likewise.
4728 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4729 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4730 some of which prompt warnings from gcc -Wbad-function-cast.
4731 (Fformat_time_string, Fencode_time, Finsert_char):
4732 (Ftranslate_region_internal, Fformat):
4733 Rename or remove local vars to avoid shadowing.
4734 (Ftranslate_region_internal): Mark var as initialized.
4735
4736 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4737 avoid shadowing.
4738
4739 * lisp.h (eassert): Check that the argument compiles, even if
4740 ENABLE_CHECKING is not defined.
4741
4742 * data.c (Findirect_variable): Name an expression, to avoid
4743 gcc -Wbad-function-cast warning.
4744 (default_value, arithcompare, arith_driver, arith_error): Now static.
4745 (store_symval_forwarding): Rename local to avoid shadowing.
4746 (Fmake_variable_buffer_local, Fmake_local_variable):
4747 Mark variables as initialized.
4748 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4749
4750 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4751 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4752 Rename locals to avoid shadowing.
4753 (mark_stack): Move local variables into the #ifdef region where
4754 they're used.
4755 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4756 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4757 needed otherwise.
4758 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4759 (GC_STRING_CHARS): Remove; not used.
4760 (Fmemory_limit): Cast sbrk's returned value to char *.
4761
4762 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4763 avoids undefined behavior in theory.
4764
4765 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4766
4767 Use functions, not macros, for up- and down-casing (Bug#8254).
4768 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4769 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4770 to use the following functions instead of these macros.
4771 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4772 EMACS_INT, since callers assume the returned value fits in int.
4773 (upcase1): Likewise, for UPCASE_TABLE.
4774 (uppercasep, lowercasep, upcase): New static inline functions.
4775 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4776 the race-condition problem in the old DOWNCASE.
4777
4778 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4779 Rename locals to avoid shadowing.
4780 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4781 (regex_compile, re_search_2, re_match_2_internal):
4782 Remove unused local vars.
4783 (FREE_VAR): Rewrite so as not to use empty "else",
4784 which gcc can warn about.
4785 (regex_compile, re_match_2_internal): Mark locals as initialized.
4786 (RETALLOC_IF): Define only if needed.
4787 (WORDCHAR_P): Likewise. This one is never needed, but is used
4788 only in a comment talking about a compiler bug, so put inside
4789 the #if 0 of that comment.
4790 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4791 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4792 Remove; unused.
4793
4794 * search.c (boyer_moore): Rename locals to avoid shadowing.
4795 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4796 (PREV_CHAR_BOUNDARY): Likewise.
4797
4798 * search.c (simple_search): Remove unused var.
4799
4800 * dired.c (compile_pattern): Move decl from here ...
4801 * lisp.h: ... to here, so that it can be checked.
4802 (struct re_registers): New forward decl.
4803
4804 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4805
4806 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4807 All uses changed.
4808 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4809 Rename locals to avoid shadowing.
4810 (Fvertical_motion): Mark locals as initialized.
4811
4812 * casefiddle.c (casify_object, casify_region): Now static.
4813 (casify_region): Mark local as initialized.
4814
4815 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4816
4817 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4818 New macros, so that the caller can use some names other than
4819 gcpro1, gcpro2, etc.
4820 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4821 of the new macros.
4822 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4823 argument, for consistency with GCPRO2_VAR, etc: it is now the
4824 prefix of the variable, not the variable itself. All uses
4825 changed.
4826 * dired.c (directory_files_internal, file_name_completion):
4827 Rename locals to avoid shadowing.
4828
4829 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4830 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4831 dired.c's scmp function, had undefined behavior.
4832 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4833 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4834 * buffer.h: ... to here, because these macros use current_buffer,
4835 and the new implementation with inline functions needs to have
4836 current_buffer in scope now, rather than later when the macros
4837 are used.
4838 (downcase, upcase1): New static inline functions.
4839 (DOWNCASE, UPCASE1): Reimplement using these functions.
4840 This avoids undefined behavior in expressions like
4841 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4842 from race conditions in accessing the global variables
4843 case_temp1 and case_temp2.
4844 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4845 * lisp.h (case_temp1, case_temp2): Remove their decls.
4846 * character.h (ASCII_CHAR_P): Move from here ...
4847 * lisp.h: ... to here, so that the inline functions mentioned
4848 above can use them.
4849
4850 * dired.c (directory_files_internal_unwind): Now static.
4851
4852 * fileio.c (file_name_as_directory, directory_file_name):
4853 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4854 Now static.
4855 (file_name_as_directory): Use const pointers when appropriate.
4856 (Fexpand_file_name): Likewise. In particular, newdir might
4857 point at constant storage, so make it a const pointer.
4858 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4859 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4860 signedness issues.
4861 (Fset_file_times, Finsert_file_contents, auto_save_error):
4862 Rename locals to avoid shadowing.
4863
4864 * minibuf.c (choose_minibuf_frame_1): Now static.
4865 (Ftry_completion, Fall_completions): Rename or remove locals
4866 to avoid shadowing.
4867
4868 * marker.c (bytepos_to_charpos): Remove; unused.
4869
4870 * lisp.h (verify_bytepos, count_markers): New decls,
4871 so that gcc does not warn that these functions aren't declared.
4872
4873 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4874 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4875 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4876 (copy_text): Remove unused local var.
4877
4878 * filelock.c (within_one_second): Now static.
4879 (lock_file_1): Rename local to avoid shadowing.
4880
4881 * buffer.c (fix_overlays_before): Mark locals as initialized.
4882 (fix_start_end_in_overlays): Likewise. This function should be
4883 simplified by using pointers-to-pointers, but that's a different
4884 matter.
4885 (switch_to_buffer_1): Now static.
4886 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4887 (report_overlay_modification): Rename locals to avoid shadowing.
4888
4889 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4890 Fix pointer signedness issue.
4891 (sys_subshell): Mark local as volatile if checking for lint,
4892 to suppress a gcc -Wclobbered warning that does not seem to be right.
4893 (MAXPATHLEN): Define only if needed.
4894
4895 * process.c (serial_open, serial_configure): Move decls from here ...
4896 * systty.h: ... to here, so that they can be checked.
4897
4898 * fns.c (get_random, seed_random): Move extern decls from here ...
4899 * lisp.h: ... to here, so that they can be checked.
4900
4901 * sysdep.c (reset_io): Now static.
4902 (wait_for_termination_signal): Remove; unused.
4903
4904 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4905 (copy_keymap_item, append_key, push_text_char_description):
4906 Now static.
4907 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4908 (DENSE_TABLE_SIZE): Remove; unused.
4909 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4910 (describe_map_tree):
4911 Rename locals to avoid shadowing.
4912
4913 * keyboard.c: Declare functions static if they are not used elsewhere.
4914 (echo_char, echo_dash, cmd_error, top_level_2):
4915 (poll_for_input, handle_async_input): Now static.
4916 (read_char, kbd_buffer_get_event, make_lispy_position):
4917 (make_lispy_event, make_lispy_movement, apply_modifiers):
4918 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4919 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4920 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4921 (read_key_sequence, read_char): Mark locals as initialized.
4922 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4923
4924 * keyboard.h (make_ctrl_char): New decl.
4925 (mark_kboards): Move decl here ...
4926 * alloc.c (mark_kboards): ... from here.
4927
4928 * lisp.h (force_auto_save_soon): New decl.
4929
4930 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4931 (DEFINE_DUMMY_FUNCTION): New macro.
4932 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4933 Use it.
4934 (main): Add casts to avoid warnings
4935 if GCC considers string literals to be constants.
4936
4937 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4938
4939 * dbusbind.c: Pointer signedness fixes.
4940 (xd_signature, xd_append_arg, xd_initialize):
4941 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4942 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4943 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4944 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4945
4946 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4947 if GCC considers string literals to be constants.
4948 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4949
4950 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4951
4952 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4953 (print_preprocess, print_object): New macro to fix last change.
4954
4955 * print.c (print_preprocess): Don't forget font objects.
4956
4957 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4958
4959 * emacs.c (USAGE3): Doc fixes.
4960
4961 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4962
4963 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4964 structure.
4965
4966 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4967
4968 * lisp.h (VWindow_system, Qfile_name_history):
4969 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4970 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4971 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4972
4973 * w32select.c: Don't #include "keyboard.h".
4974 (run_protected): Add extern declaration for waiting_for_input.
4975
4976 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4977 * w32console.c (detect_input_pending, read_input_pending)
4978 (encode_terminal_code):
4979 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4980 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4981 (w32_system_caret_y, Qfile_name_history):
4982 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4983 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4984 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4985 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4986 * w32proc.c (Qlocal, report_file_error):
4987 * w32term.c (Vwindow_system, updating_frame):
4988 * w32uniscribe.c (initialized, uniscribe_font_driver):
4989 Remove unneeded extern declarations.
4990
4991 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4992
4993 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4994
4995 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4996
4997 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4998 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4999 These macros can no longer be used for assignment.
5000
5001 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5002 Assign struct members directly, instead of using BUF_BEGV etc.
5003 (record_buffer_markers, fetch_buffer_markers): New functions for
5004 recording and fetching special buffer markers.
5005 (set_buffer_internal_1, set_buffer_temp): Use them.
5006
5007 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5008
5009 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5010
5011 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5012 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5013
5014 * xdisp.c (hscroll_window_tree):
5015 (reconsider_clip_changes): Use PT instead of BUF_PT.
5016
5017 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5018
5019 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5020 $(EMACS_ROOT)/lib/intprops.h.
5021
5022 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5023
5024 Fix more problems found by GCC 4.5.2's static checks.
5025
5026 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5027 to unsigned char * to avoid compiler diagnostic.
5028 (xg_free_frame_widgets): Make it clear that a local variable is
5029 needed only if USE_GTK_TOOLTIP.
5030 (gdk_window_get_screen): Make it clear that this macro is needed
5031 only if USE_GTK_TOOLTIP.
5032 (int_gtk_range_get_value): New function, which avoids a diagnostic
5033 from gcc -Wbad-function-cast.
5034 (xg_set_toolkit_scroll_bar_thumb): Use it.
5035 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5036 diagnostic from gcc -Wbad-function-cast.
5037 (get_utf8_string, xg_get_file_with_chooser):
5038 Rename locals to avoid shadowing.
5039 (create_dialog): Move locals to avoid shadowing.
5040
5041 * xgselect.c (xg_select): Remove unused var.
5042
5043 * image.c (four_corners_best): Mark locals as initialized.
5044 (gif_load): Initialize transparent_p to zero (Bug#8238).
5045 Mark another local as initialized.
5046 (my_png_error, my_error_exit): Mark with NO_RETURN.
5047
5048 * image.c (clear_image_cache): Now static.
5049 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5050 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5051 (x_edge_detection): Remove unnecessary cast that
5052 gcc -Wbad-function-cast diagnoses.
5053 (gif_load): Fix pointer signedness.
5054 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5055 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5056
5057 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5058
5059 Improve quality of tests for time stamp overflow.
5060 For example, without this patch (encode-time 0 0 0 1 1
5061 1152921504606846976) returns the obviously-bogus value (-948597
5062 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5063 reports time overflow. See
5064 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5065 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5066 * editfns.c: Include limits.h and intprops.h.
5067 (TIME_T_MIN, TIME_T_MAX): New macros.
5068 (time_overflow): Move earlier, to before first use.
5069 (hi_time, lo_time): New functions, for an accurate test for
5070 out-of-range times.
5071 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5072 (Fget_internal_run_time): Don't assume time_t fits in int.
5073 (make_time): Use list2 instead of Fcons twice.
5074 (Fdecode_time): More accurate test for out-of-range times.
5075 (check_tm_member): New function.
5076 (Fencode_time): Use it, to test for out-of-range times.
5077 (lisp_time_argument): Don't rely on undefined left-shift and
5078 right-shift behavior when checking for time stamp overflow.
5079
5080 * editfns.c (time_overflow): New function, refactoring common code.
5081 (Fformat_time_string, Fdecode_time, Fencode_time):
5082 (Fcurrent_time_string): Use it.
5083
5084 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5085 * dired.c (make_time): Move to ...
5086 * editfns.c (make_time): ... here.
5087 * systime.h: Note the move.
5088
5089 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5090
5091 * fringe.c (update_window_fringes): Remove unused variables.
5092
5093 * unexmacosx.c (copy_data_segment): Also copy __got section.
5094 (Bug#8223)
5095
5096 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5097
5098 * termcap.c [MSDOS]: Include "msdos.h".
5099 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5100 Constify `char *' arguments and their references according to
5101 prototypes in tparam.h.
5102
5103 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5104
5105 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5106 Adapt all references accordingly.
5107
5108 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5109
5110 2011-03-11 Tom Tromey <tromey@redhat.com>
5111
5112 * buffer.c (syms_of_buffer): Remove obsolete comment.
5113
5114 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5115
5116 * termhooks.h (encode_terminal_code): Declare prototype.
5117
5118 * msdos.c (encode_terminal_code): Don't declare prototype.
5119
5120 * term.c (encode_terminal_code): Now external again, used by
5121 w32console.c and msdos.c.
5122
5123 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5124 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5125
5126 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5127
5128 Fix some minor problems found by GCC 4.5.2's static checks.
5129
5130 * fringe.c (update_window_fringes): Mark locals as initialized
5131 (Bug#8227).
5132 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5133
5134 * alloc.c (mark_fringe_data): Move decl from here ...
5135 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5136 to check its interface.
5137 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5138
5139 * fontset.c (free_realized_fontset): Now static.
5140 (Fset_fontset_font): Rename local to avoid shadowing.
5141 (fontset_font): Mark local as initialized.
5142 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5143
5144 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5145
5146 * xselect.c (x_disown_buffer_selections): Remove; not used.
5147 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5148 (x_own_selection, Fx_disown_selection_internal): Rename locals
5149 to avoid shadowing.
5150 (x_handle_dnd_message): Remove local to avoid shadowing.
5151
5152 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5153 so that the caller can use some name other than gcpro1.
5154 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5155 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5156 (Fx_backspace_delete_keys_p):
5157 Use them to avoid shadowing, and rename vars to avoid shadowing.
5158 (x_decode_color, x_set_name, x_window): Now static.
5159 (Fx_create_frame): Add braces to silence GCC warning.
5160 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5161 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5162 Remove unused locals.
5163 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5164 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5165 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5166 macros.
5167
5168 * xterm.h (x_mouse_leave): New decl.
5169
5170 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5171 Remove unused functions.
5172 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5173 (x_calc_absolute_position): Now static.
5174 (XTread_socket): Don't define label "out" unless it's used.
5175 Don't declare local "event" unless it's used.
5176 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5177 unless they are used.
5178 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5179 (x_fatal_error_signal): Remove; not used.
5180 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5181 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5182 (x_error_catcher, x_connection_closed, x_error_handler):
5183 (x_error_quitter, xembed_send_message, x_iconify_frame):
5184 (my_log_handler): Rename locals to avoid shadowing.
5185 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5186 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5187
5188 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5189 Rename or move locals to avoid shadowing.
5190 (tty_defined_color, merge_face_heights): Now static.
5191 (free_realized_faces_for_fontset): Remove; not used.
5192 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5193 does not deduce is never used uninitialized.
5194 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5195 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5196
5197 * terminal.c (store_terminal_param): Now static.
5198
5199 * xmenu.c (menu_highlight_callback): Now static.
5200 (set_frame_menubar): Remove unused local.
5201 (xmenu_show): Rename parameter to avoid shadowing.
5202 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5203 since they might point to immutable storage.
5204 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5205 since it's unused otherwise.
5206
5207 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5208 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5209 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5210 avoids a gcc -Wuninitialized diagnostic.
5211 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5212 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5213 does not deduce are never used uninitialized.
5214
5215 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5216
5217 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5218 * window.c (window_loop, size_window):
5219 (run_window_configuration_change_hook, enlarge_window): Likewise.
5220
5221 * window.c (display_buffer): Now static.
5222 (size_window): Mark variables that gcc -Wuninitialized
5223 does not deduce are never used uninitialized.
5224 * window.h (check_all_windows): New decl, to forestall
5225 gcc -Wmissing-prototypes diagnostic.
5226 * dispextern.h (bidi_dump_cached_states): Likewise.
5227
5228 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5229 shadowing.
5230 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5231 Include <limits.h>.
5232 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5233 and to avoid gcc -Wuninitialized warning.
5234 (load_charset_map): Mark variables that gcc -Wuninitialized
5235 does not deduce are never used uninitialized.
5236 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5237
5238 * coding.c (coding_set_source, coding_set_destination):
5239 Use "else { /* comment */ }" rather than "else /* comment */;"
5240 for clarity, and to avoid gcc -Wempty-body warning.
5241 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5242 a block, when the outer 'i' will do.
5243 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5244 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5245 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5246 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5247 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5248 Rename locals to avoid shadowing.
5249 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5250 * coding.c (emacs_mule_char, encode_invocation_designation):
5251 Now static, since they're not used elsewhere.
5252 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5253 (decode_coding_object, encode_coding_object, detect_coding_system):
5254 (decode_coding_emacs_mule): Mark variables that gcc
5255 -Wuninitialized does not deduce are never used uninitialized.
5256 (detect_coding_iso_2022): Initialize a local variable that might
5257 be used uninitialized. Leave a FIXME because it's not clear that
5258 this initialization is needed. (Bug#8211)
5259 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5260 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5261 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5262 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5263 Remove unused macros.
5264
5265 * category.c (hash_get_category_set): Remove unused local var.
5266 (copy_category_table): Now static, since it's not used elsewhere.
5267 * character.c (string_count_byte8): Likewise.
5268
5269 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5270 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5271
5272 * chartab.c (copy_sub_char_table): Now static, since it's not used
5273 elsewhere.
5274 (sub_char_table_ref_and_range, char_table_ref_and_range):
5275 Rename locals to avoid shadowing.
5276 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5277
5278 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5279 (BIDI_BOB): Remove unused macro.
5280
5281 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5282 deduce are never used uninitialized.
5283 * term.c (encode_terminal_code): Likewise.
5284
5285 * term.c (encode_terminal_code): Now static. Remove unused local.
5286
5287 * tparam.h: New file.
5288 * term.c, tparam.h: Include it.
5289 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5290 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5291 Move these decls to tparam.h, and make them agree with what
5292 is actually in tparam.c. The previous trick of using incompatible
5293 decls in different modules does not conform to the C standard.
5294 All callers of tparam changed to use tparam's actual API.
5295 * tparam.c (tparam1, tparam, tgoto):
5296 Use const pointers where appropriate.
5297
5298 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5299 * cm.h (struct cm): Likewise.
5300 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5301 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5302 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5303 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5304 (turn_on_face, init_tty): Likewise.
5305 * termchar.h (struct tty_display_info): Likewise.
5306
5307 * term.c (term_mouse_position): Rename local to avoid shadowing.
5308
5309 * alloc.c (mark_ttys): Move decl from here ...
5310 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5311
5312 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5313
5314 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5315
5316 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5317
5318 * search.c (compile_pattern_1): Remove argument regp, unused since
5319 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5320 (compile_pattern): Don't pass it.
5321
5322 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5323
5324 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5325 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5326 for ! HAVE_GTK3.
5327 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5328
5329 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5330
5331 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5332 gdk_window_get_screen, gdk_window_get_geometry,
5333 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5334 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5335 (xg_get_pixbuf_from_pixmap): New function.
5336 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5337 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5338 Call xg_get_pixbuf_from_pixmap instead of
5339 gdk_pixbuf_get_from_drawable.
5340 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5341 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5342 (xg_check_special_colors): Use GtkStyleContext and its functions
5343 for HAVE_GTK3.
5344 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5345 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5346 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5347 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5348 Call gtk_widget_get_preferred_size.
5349 (xg_frame_resized): gdk_window_get_geometry only takes 5
5350 parameters.
5351 (xg_win_to_widget, xg_event_is_for_menubar):
5352 Call gdk_x11_window_lookup_for_display.
5353 (xg_set_widget_bg): New function.
5354 (delete_cb): New function.
5355 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5356 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5357 (xg_set_background_color): Call xg_set_widget_bg.
5358 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5359 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5360 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5361 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5362 if ! HAVE_GTK3.
5363 (update_frame_tool_bar): Call gtk_widget_hide.
5364 (xg_initialize): Use GDK_KEY_g.
5365
5366 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5367 if ! HAVE_GTK3
5368 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5369
5370 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5371 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5372 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5373
5374 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5375
5376 * w32xfns.c (select_palette): Check success of RealizePalette against
5377 GDI_ERROR, not zero.
5378
5379 See ChangeLog.11 for earlier changes.
5380
5381 ;; Local Variables:
5382 ;; coding: utf-8
5383 ;; End:
5384
5385 Copyright (C) 2011 Free Software Foundation, Inc.
5386
5387 This file is part of GNU Emacs.
5388
5389 GNU Emacs is free software: you can redistribute it and/or modify
5390 it under the terms of the GNU General Public License as published by
5391 the Free Software Foundation, either version 3 of the License, or
5392 (at your option) any later version.
5393
5394 GNU Emacs is distributed in the hope that it will be useful,
5395 but WITHOUT ANY WARRANTY; without even the implied warranty of
5396 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5397 GNU General Public License for more details.
5398
5399 You should have received a copy of the GNU General Public License
5400 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.