1 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
3 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
4 referenced (Bug#11583).
6 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
8 Implement wave-style variant of underlining.
9 * dispextern.h (face_underline_type): New enum.
10 (face): Add field for underline type.
11 * nsterm.m (ns_draw_underwave): New function.
12 (ns_draw_text_decoration): Use it.
13 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
15 (x_draw_glyph_string): Use them.
16 * xfaces.c (Qline, Qwave): New Lisp objects.
17 (check_lface_attrs, merge_face_ref)
18 (Finternal_set_lisp_face_attribute, realize_x_face): Handle
19 wave-style underline face attributes.
20 * xterm.c (x_draw_underwave): New function.
21 (x_draw_glyph_string): Use it.
23 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
25 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
26 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
27 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
28 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
29 ($(BLD)/w32select.$(O)): Update dependencies.
31 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
33 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
34 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
35 * character.c (_fetch_multibyte_char_p): Remove.
36 * alloc.c: Include "character.h" before "buffer.h".
39 * bytecode.c: Likewise.
40 * callint.c: Likewise.
41 * callproc.c: Likewise.
42 * casefiddle.c: Likewise.
43 * casetab.c: Likewise.
44 * category.c: Likewise.
47 * composite.c: Likewise.
49 * dispnew.c: Likewise.
52 * editfns.c: Likewise.
55 * filelock.c: Likewise.
57 * fontset.c: Likewise.
61 * intervals.c: Likewise.
62 * keyboard.c: Likewise.
67 * minibuf.c: Likewise.
71 * process.c: Likewise.
73 * region-cache.c: Likewise.
77 * textprop.c: Likewise.
79 * unexsol.c: Likewise.
80 * w16select.c: Likewise.
82 * w32menu.c: Likewise.
88 * xselect.c: Likewise.
90 2012-06-16 Eli Zaretskii <eliz@gnu.org>
92 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end. If
93 all the glyphs of the glyph row came from strings, and we have no
94 cursor positioning clues, put the cursor on the first glyph of the
96 (handle_face_prop): Use chunk-relative overlay string index when
97 indexing into it->string_overlays array. (Bug#11653)
98 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
99 the rightmost. (Bug#11720)
101 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
103 * category.h (CHAR_HAS_CATEGORY): Define as inline.
104 (CATEGORY_MEMBER): Enforce 1/0 value.
105 * category.c (_temp_category_set): Remove.
107 2012-06-16 Eli Zaretskii <eliz@gnu.org>
109 * window.c (Fdelete_other_windows_internal)
110 (Fdelete_window_internal): Don't access frame's mouse highlight
111 info of the initial frame. (Bug#11677)
113 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
115 * .gdbinit (xgetint): Fix recently-introduced paren typo.
116 Assume USE_2_TAGS_FOR_INTS.
117 (xreload): Adjust $tagmask width to match recent lisp.h change.
119 Simplify lisp.h in minor ways that should not affect code.
120 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
121 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
122 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
123 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
124 (INTTYPEBITS): New macro, for clarity.
125 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
126 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P): Simplify
127 now that USE_LSB_TAG is always defined.
128 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
129 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
131 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
133 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
135 2012-06-13 Glenn Morris <rgm@gnu.org>
137 * s/bsd-common.h (BSD4_3):
138 * s/usg5-4-common.h (USG5_4): No longer define; unused.
140 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
142 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
145 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG): Use
147 * emacs.c (gdb_use_struct): Renamed from gdb_use_union.
148 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
149 * alloc.c (widen_to_Lisp_Object): Removed.
150 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
151 * frame.c (delete_frame): Remove outdated comment.
152 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
154 (Fw32_unregister_hot_key): Likewise.
155 (Fw32_toggle_lock_key): Likewise.
156 * w32menu.c (add_menu_item): Likewise.
157 (w32_menu_display_help): Use XIL instead of checking
159 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
160 (init_heap): Likewise.
161 * w32term.c (w32_read_socket): Update comment.
163 2012-06-13 Glenn Morris <rgm@gnu.org>
165 * s/usg5-4-common.h, src/s/unixware.h:
166 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
168 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
170 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
172 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
173 * alloc.c (make_number) [!defined make_number]:
174 Remove, as lisp.h always defines this now.
175 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
176 (roundup_size): Verify that it is a power of 2.
177 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
178 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
179 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
180 -DUSE_LSB_TAG=0, to override the automatically-selected default.
181 USE_LSB_TAG now is always defined to be either 0 or 1.
183 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
184 code works fine either way, and efficiency is not a concern here,
185 as the union type is for debugging, not for production.
186 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
187 Use an inline function on all platforms when using the union type,
188 since this is simpler and 'static inline' can be used portably
190 (LISP_INITIALLY_ZERO): New macro.
191 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
192 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
194 2012-06-12 Glenn Morris <rgm@gnu.org>
196 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
198 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
200 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
201 Move BROKEN_SIGIO to configure.
203 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
204 Move NO_TERMIO to configure.
206 2012-06-12 Chong Yidong <cyd@gnu.org>
208 * image.c (imagemagick_load_image): Use MagickFlattenImage if
209 MagickMergeImageLayers is undefined. Use pixel pusher loop if
210 MagickExportImagePixels is undefined.
212 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
214 * image.c (imagemagick_load_image): Remove unused label.
216 2012-06-11 Glenn Morris <rgm@gnu.org>
218 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
219 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
220 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
221 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
223 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
225 * alloc.c (make_byte_code): New function.
226 (Fmake_byte_code): Use it. Don't purify here.
227 * lread.c (read1): Use it as well to avoid extra allocation.
229 2012-06-11 Chong Yidong <cyd@gnu.org>
231 * image.c (imagemagick_load_image): Implement transparency.
233 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
235 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
236 account for preceding backslashes. (Bug#11663)
238 2012-06-09 Chong Yidong <cyd@gnu.org>
240 * term.c: Support italics in capable terminals (Bug#9652).
241 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
242 (turn_on_face): Output using TS_enter_italic_mode if available.
243 Don't handle unused blinking and alt-charset cases.
244 (turn_off_face): Handle italic case; discard unused tty_blinking_p
245 and tty_alt_charset_p cases.
246 (tty_capable_p, init_tty): Support italics.
248 * termchar.h (struct tty_display_info): Add field for italics.
249 Remove unused blink field.
251 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
254 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
255 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
256 tty_alt_charset_p. Add tty_italic_p.
258 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
260 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
261 dbus_type_is_basic if available.
262 (xd_extract_signed, xd_extract_unsigned): Rename from
263 extract_signed and extract_unsigned, respectively. Adapt callers.
265 2012-06-09 Chong Yidong <cyd@gnu.org>
267 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
269 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
272 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
274 * xdisp.c (vmessage): Treat frame message as multibyte.
275 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
276 would generate the diagnostic "Making \302\247 buffer-local while
279 2012-06-08 Eli Zaretskii <eliz@gnu.org>
281 * dispnew.c (showing_window_margins_p): Undo last change, which
282 was done due to an inadvertent commit.
283 (adjust_frame_glyphs_for_frame_redisplay): Do call
284 showing_window_margins_p.
286 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
288 * eval.c (Fmake_var_non_special): New primitive.
289 (syms_of_eval): Defsubr it.
290 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
292 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
294 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
295 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
297 2012-06-08 Eli Zaretskii <eliz@gnu.org>
299 * alloc.c (allocate_vectorlike): Fix last change.
301 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
303 Block-based vector allocation of small vectors.
304 * lisp.h (struct vectorlike_header): New field `nbytes',
305 adjust comment accordingly.
306 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
307 to denote vector blocks. Adjust users (live_vector_p,
308 mark_maybe_pointer, valid_lisp_object_p) accordingly.
309 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
310 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
311 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
312 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
313 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
314 (roundup_size): New constant.
315 (struct vector_block): New data type.
316 (vector_blocks, vector_free_lists, zero_vector): New variables.
317 (all_vectors): Rename to `large_vectors'.
318 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
319 (sweep_vectors): New functions.
320 (allocate_vectorlike): Return `zero_vector' as the only vector of
321 0 items. Allocate new vector from block if vector size is less than
322 or equal to VBLOCK_BYTES_MAX.
323 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
324 (init_alloc_once): Add call to init_vectors.
326 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
328 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
330 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
332 * doprnt.c (doprnt): Truncate multibyte char correctly.
333 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
334 would mishandle a string argument "Xc" if X was a multibyte
335 character of length 2: it would truncate after X's first byte
336 rather than including all of X.
338 2012-06-06 Chong Yidong <cyd@gnu.org>
340 * buffer.c (word_wrap): Doc fix.
342 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
344 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
346 2012-06-03 Glenn Morris <rgm@gnu.org>
348 * xdisp.c (tool-bar-style): Doc fix.
350 2012-06-03 Ulrich Müller <ulm@gentoo.org>
352 * Makefile.in (PAXCTL): Define.
353 (temacs$(EXEEXT)): Disable memory randomization for the temacs
354 binary via PaX flags if the paxctl utility is available.
355 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
356 Restore PaX flags to their default. (Bug#11398)
358 2012-06-03 Chong Yidong <cyd@gnu.org>
360 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
363 2012-06-03 Chong Yidong <cyd@gnu.org>
365 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
366 (note_mode_line_or_margin_highlight): If there is no help echo,
367 use mode-line-default-help-echo. Handle the case where the mouse
368 position is past the end of the mode line string.
370 * buffer.c (buffer_local_value_1): New function, split from
371 Fbuffer_local_value; can return Qunbound.
372 (Fbuffer_local_value): Use it.
373 (Vmode_line_format): Docstring tweaks.
375 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
377 * sysdep.c (system_process_attributes): Improve comment.
379 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
381 * keyboard.c: Export real-this-command to Elisp.
382 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
383 and DEFVAR it. Update all users.
385 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
387 * minibuf.c (Fassoc_string): Remove duplicate declaration.
389 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
390 Convert pctcpu and pctmem to Lisp float properly.
391 Let the compiler fold better, as 100.0/0x8000 is exact.
393 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
395 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
398 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
400 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
402 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
404 For a 'struct window', replace some Lisp_Object fields to
405 bitfields where appropriate, remove unused fields.
406 * window.h (struct window): Remove unused 'last_mark_x' and
407 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
408 change it's type from Lisp_Object to bitfield.
409 Change type of 'force_start', 'optional_new_start',
410 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
411 fields from Lisp_Object to bitfield. Adjust users accordingly.
413 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
415 Pacify gcc -Wdouble-precision when using Xaw.
416 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
417 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
418 Use 'float' consistently, rather than 'float' in most places
419 and 'double' in a couple of places.
421 2012-05-31 Eli Zaretskii <eliz@gnu.org>
423 * xdisp.c (handle_stop): Detect whether we have overlay strings
424 loaded by testing it->current.overlay_string_index to be
425 non-negative, instead of checking whether n_overlay_strings is
426 positive. (Bug#11587)
428 2012-05-31 Chong Yidong <cyd@gnu.org>
430 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
432 * doc.c (Fsubstitute_command_keys): Doc fix.
434 2012-05-31 Eli Zaretskii <eliz@gnu.org>
436 * search.c (search_buffer): Remove calls to
437 r_alloc_inhibit_buffer_relocation, as it is now called by
438 maybe_unify_char, which was the cause of relocation of buffer text
441 2012-05-31 Eli Zaretskii <eliz@gnu.org>
443 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
444 for the duration of call to load_charset, to avoid problems with
445 callers of maybe_unify_char that access buffer text through C
448 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
449 decrement the inhibition flag, instead of just setting or
452 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
454 Remove obsolete '#define static' cruft.
455 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
456 This #undef was "temporary" in 2000; it is no longer needed
457 now that '#define static' has gone away.
458 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
459 (gray_bitmap_bits): Remove; no longer needed.
460 All uses replaced with definiens.
461 * xterm.c: Include "bitmaps/gray.xbm".
463 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
465 Clean up __executable_start, monstartup when --enable-profiling.
466 The following changes affect the code only when profiling.
467 * dispnew.c (__executable_start): Rename from safe_bcopy.
468 Define only on platforms that need it.
469 * emacs.c: Include <sys/gmon.h> when profiling.
470 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
471 (__executable_start): Remove decl, since lisp.h does it now.
472 (safe_bcopy): Remove decl; no longer has that name.
473 (main): Coalesce #if into single bit of code, for simplicity.
474 Cast pointers to uintptr_t, since standard libraries want integers
476 * lisp.h (__executable_start): New decl.
478 2012-05-31 Glenn Morris <rgm@gnu.org>
480 * image.c (Fimagemagick_types): Doc fix.
482 2012-05-30 Jim Meyering <meyering@redhat.com>
484 * callproc.c (Fcall_process_region): Include directory component
485 in mkstemp error message (Bug#11586).
487 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
489 * alloc.c, lisp.h (make_pure_vector): Now static.
491 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
493 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
495 (Fautoload): Do the hash-doc more carefully.
496 * data.c (Fdefalias): Purify definition, except for keymaps.
497 (Qdefun): Move from eval.c.
498 * lisp.h (Qdefun): Remove.
499 * lread.c (read1): Tiny simplification.
501 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
503 Do not create empty overlays with the evaporate property (Bug#9642).
504 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
505 Bug#9642, but explicitly check that the buffer the overlay would
506 be moved to is live and rearrange lines to make sure that errors
507 will not put the overlay in an inconsistent state.
508 (Fdelete_overlay): Cosmetics.
510 2012-05-28 Eli Zaretskii <eliz@gnu.org>
512 * w32term.c (my_bring_window_to_top): New function.
513 (x_raise_frame): Use handle returned by DeferWindowPos, which
514 could be different from the original one.
515 Call my_bring_window_to_top instead of my_set_foreground_window.
518 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
519 by calling BringWindowToTop.
521 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
522 (WM_EMACS_END): Increase by one.
524 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
526 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
527 This avoids undefined behavior that might cause the eassert
528 to not catch an out-of-range value.
530 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
532 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
535 2012-05-27 Eli Zaretskii <eliz@gnu.org>
537 * bidi.c (bidi_mirror_char): Fix last change.
539 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
541 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
542 when referring to sectname field in printf format.
544 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
546 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
547 Only r_alloc_inhibit_buffer_relocation needed to be added;
548 the others were already declared.
550 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
551 before checking whether it's out of range. Put the check inside
553 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
555 2012-05-27 Ken Brown <kbrown@cornell.edu>
557 * callproc.c (Fcall_process): Restore a line that was accidentally
558 commented out in the 2011-02-13 change (bug#11547).
560 2012-05-27 Eli Zaretskii <eliz@gnu.org>
562 * lisp.h [REL_ALLOC]: Add prototypes for external functions
565 * buffer.c [REL_ALLOC]: Remove prototypes of
566 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
567 they are now on lisp.h.
569 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
571 * search.c (search_buffer): Use it to inhibit relocation of buffer
572 text while re_search_2 is doing its job, because re_search_2 is
573 passed C pointers to buffer text. (Bug#11519)
575 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
578 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
579 state after an additional call to move_it_in_display_line_to, keep
580 the values of it->max_ascent and it->max_descent found for the
582 (pos_visible_p): Revert the comparison against bottom_y to what it
583 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
586 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
588 Fix coding-related core dumps with gcc -ftrapv.
589 The code was computing A - B, where A and B are pointers, and B is
590 random garbage. This can lead to core dumps on platforms that
591 have special pointer registers, and it also leads to core dumps on
592 x86-64 when compiled with gcc -ftrapv. The fix is to compute
593 A - B only when B is initialized properly.
594 * coding.c (coding_set_source, coding_set_destination): Return void.
595 (coding_change_source, coding_change_destinations): New functions,
596 with the old behaviors of coding_set_source and coding_set_destination.
597 All callers that need an offset changed to use these new functions.
599 2012-05-26 Glenn Morris <rgm@gnu.org>
601 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
603 2012-05-26 Eli Zaretskii <eliz@gnu.org>
605 Extend mouse support on W32 text-mode console.
606 * xdisp.c (draw_row_with_mouse_face):
607 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
609 * w32console.c: Include window.h.
610 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
612 (initialize_w32_display): Initialize mouse-highlight data.
614 * w32inevt.c: Include termchar.h and window.h.
615 (do_mouse_event): Support mouse-autoselect-window. When the mouse
616 moves, call note_mouse_highlight. If help_echo changed, call
617 gen_help_event to produce help-echo message in the echo area.
618 Call clear_mouse_face if mouse_face_hidden is set in the mouse
621 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
623 * lread.c (read1): Simplify slightly to avoid an overflow warning
624 with GCC 4.7.0 on x86-64.
626 2012-05-26 Eli Zaretskii <eliz@gnu.org>
628 * bidi.c (bidi_mirror_char): Revert last change: an int is
629 definitely wide enough here.
631 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
633 Fix integer width and related bugs (Bug#9874).
634 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
635 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
636 (string_bytes, check_sblock, allocate_string_data):
637 (compact_small_strings, Fmake_bool_vector, make_string)
638 (make_unibyte_string, make_multibyte_string)
639 (make_string_from_bytes, make_specified_string)
640 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
641 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
643 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
644 (allocate_pseudovector):
645 Use int, not EMACS_INT, where int is wide enough.
646 (inhibit_garbage_collection, Fgarbage_collect):
647 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
648 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
649 int might not be wide enough.
650 (bidi_cache_search, bidi_cache_find, bidi_init_it)
651 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
652 (bidi_at_paragraph_end, bidi_find_paragraph_start)
653 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
654 (bidi_level_of_next_char, bidi_move_to_visually_next):
655 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
656 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
657 (Fkill_buffer, Fset_buffer_major_mode)
658 (advance_to_char_boundary, Fbuffer_swap_text)
659 (Fset_buffer_multibyte, overlays_at, overlays_in)
660 (overlay_touches_p, struct sortvec, record_overlay_string)
661 (overlay_strings, recenter_overlay_lists)
662 (adjust_overlays_for_insert, adjust_overlays_for_delete)
663 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
664 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
665 (Foverlay_recenter, last_overlay_modification_hooks_used)
666 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
667 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
668 (validate_region): Omit unnecessary test for b <= e,
669 since that's guaranteed by the previous test.
670 (adjust_overlays_for_delete): Avoid pos + length overflow.
671 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
672 (report_overlay_modification):
673 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
674 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
675 Omit pointer cast, which isn't needed anyway, and doesn't work
676 after the EMACS_INT -> ptrdiff_t change.
677 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
678 * buffer.h: Adjust decls to match defn changes elsewhere.
679 (struct buffer_text, struct buffer):
680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
681 Use EMACS_INT, not int, where int might not be wide enough.
682 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
683 not int, to avoid needless 32-bit limit on 64-bit hosts.
684 (exec_byte_code): Use tighter memory-full test, one that checks
685 for alloca overflow. Don't compute the address of the object just
686 before an array, as that's not portable. Use EMACS_INT, not
687 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
688 * callint.c (Fcall_interactively):
689 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
690 * callproc.c (call_process_kill, Fcall_process):
691 Don't assume pid_t fits into an Emacs fixnum.
692 (call_process_cleanup, Fcall_process, child_setup):
693 Don't assume pid_t fits into int.
694 (call_process_cleanup, Fcall_process, delete_temp_file)
695 (Fcall_process_region):
696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
697 (Fcall_process): Simplify handling of volatile integers.
698 Use int, not EMACS_INT, where int will do.
699 * casefiddle.c (casify_object, casify_region, operate_on_word)
700 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
701 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
702 (casify_object): Avoid integer overflow when overallocating buffer.
703 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
704 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
705 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
706 * category.h (CATEGORYP): Don't assume arg is nonnegative.
707 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
708 integers are now checked earlier. All uses replaced with XINT.
710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
711 For CCL_MapSingle, check that content and value are in int range.
712 (ccl_driver, Fregister_code_conversion_map):
713 Check that Vcode_version_map_vector is a vector.
714 (resolve_symbol_ccl_program): Check that vector header is in range.
715 Always copy the vector, so that we can check its contents reliably
716 now rather than having to recheck each instruction as it's being
717 executed. Check that vector words fit in 'int'.
718 (ccl_get_compiled_code, Fregister_ccl_program)
719 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
720 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
721 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
722 contents are in range.
723 (Fccl_execute_on_string): Check that status is in range.
724 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
725 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
726 Accept and return EMACS_INT, not int, because callers can pass values
728 (c_string_width, strwidth, lisp_string_width, chars_in_text)
729 (multibyte_chars_in_text, parse_str_as_multibyte)
730 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
731 (str_as_unibyte, str_to_unibyte, string_count_byte8)
732 (string_escape_byte8, Fget_byte):
733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
734 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
735 avoid mishandling large integers.
736 * character.h: Adjust decls to match defn changes elsewhere.
737 * charset.c (load_charset_map_from_file, find_charsets_in_text)
738 (Ffind_charset_region):
739 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
740 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
741 (load_charset_map_from_vector, Fdefine_charset_internal):
742 Don't assume fixnum fits in int.
743 (load_charset_map_from_vector, Fmap_charset_chars):
744 Remove now-unnecessary CHECK_NATNUMs.
745 (Fdefine_charset_internal): Check ranges here, more carefully.
746 Don't rely on undefined behavior with signed left shift overflow.
747 Don't assume unsigned int fits into fixnum, or that fixnum fits
748 into unsigned int. Don't require max_code to be a valid fixnum;
749 that's not true for gb10830 4-byte on a 32-bit host. Allow
750 invalid_code to be a cons, for the same reason. Require code_offset
751 to be a character. Avoid int overflow if max_char is close
753 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
754 this is intended anyway and avoids some undefined behavior.
755 (load_charset_map): Pass unsigned, not int, as 2nd arg of
756 INDEX_TO_CODE_POINT, as that's what it expects.
757 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
758 * charset.h (DECODE_CHAR): Return int, not unsigned;
759 this is what was intended anyway, and it avoids undefined behavior.
760 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
761 integer-overflow issues.
762 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
763 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
764 where the argument is EMACS_INT, and this behavior is not intended.
765 * chartab.c (Fmake_char_table, Fset_char_table_range)
766 (uniprop_get_decoder, uniprop_get_encoder):
767 Don't assume fixnum fits in int.
768 * cmds.c (move_point): New function, that does the gist of
769 Fforward_char and Fbackward_char, but does so while checking
770 for integer overflow more accurately.
771 (Fforward_char, Fbackward_char): Use it.
772 (Fforward_line, Fend_of_line, internal_self_insert)
773 (internal_self_insert):
774 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
775 Fix a FIXME, by checking for integer overflow when calculating
776 target_clm and actual_clm.
777 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
778 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
779 (ASSURE_DESTINATION, coding_alloc_by_realloc)
780 (coding_alloc_by_making_gap, alloc_destination)
781 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
782 (encode_coding_utf_16, detect_coding_emacs_mule)
783 (decode_coding_emacs_mule, encode_coding_emacs_mule)
784 (detect_coding_iso_2022, decode_coding_iso_2022)
785 (encode_invocation_designation, encode_designation_at_bol)
786 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
787 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
788 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
789 (encode_coding_ccl, encode_coding_raw_text)
790 (detect_coding_charset, decode_coding_charset)
791 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
792 (produce_composition, produce_charset, produce_annotation)
793 (decode_coding, handle_composition_annotation)
794 (handle_charset_annotation, consume_chars, decode_coding_gap)
795 (decode_coding_object, encode_coding_object, detect_coding_system)
796 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
797 (code_convert_region, code_convert_string)
798 (Fdefine_coding_system_internal)
799 (coding_set_source, coding_set_destination):
800 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
801 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
802 (Fdefine_coding_system_internal):
803 Don't assume fixnums fit in int.
804 (decode_coding_gap, decode_coding_object, encode_coding_object)
805 (Fread_coding_system, Fdetect_coding_region)
806 (Funencodable_char_position, Fcheck_coding_systems_region)
807 (get_translation, handle_composition_annotation, consume_chars):
808 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
809 (consume_chars): Rewrite to not calculate an address outside buffer.
810 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
811 Don't access memory outside of the args array.
812 (Fdefine_coding_system_internal): Check for charset-id overflow.
813 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
814 result of ENCODE_CHAR.
815 * coding.h: Adjust decls to match defn changes elsewhere.
816 (struct coding_system):
817 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
818 * composite.c (get_composition_id, find_composition)
819 (run_composition_function, update_compositions)
820 (compose_text, composition_gstring_put_cache)
821 (composition_gstring_p, composition_gstring_width)
822 (fill_gstring_header, fill_gstring_body, autocmp_chars)
823 (composition_compute_stop_pos, composition_reseat_it)
824 (composition_update_it, struct position_record)
825 (find_automatic_composition, composition_adjust_point)
826 (Fcomposition_get_gstring, Ffind_composition_internal):
827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
828 (update_compositions):
829 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
830 * composite.h: Adjust decls to match defn changes elsewhere.
831 (struct composition):
832 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
833 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
834 Do not attempt to compute the address of the object just before a
835 buffer; this is not portable.
837 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
838 (Faset): Use int, not EMACS_INT, where int is wide enough.
839 (Fstring_to_number): Don't assume fixnums fit in int.
840 (Frem): Don't assume arg is nonnegative.
841 * dbusbind.c (xd_append_arg): Check for integers out of range.
842 (Fdbus_call_method): Don't overflow the timeout int.
843 (extract_signed, extract_unsigned): New functions.
844 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
845 (xd_get_connection_references): Return ptrdiff_t, not int.
847 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
849 Use int, not unsigned, where the dbus API uses int.
850 (Fdbus_message_internal): Don't overflow mtype.
851 (syms_of_dbusbind): Allocate right-sized buffer for integers.
852 * dired.c (directory_files_internal, file_name_completion, scmp)
853 (file_name_completion_stat):
854 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
855 (file_name_completion): Don't overflow matchcount.
856 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
857 * dispextern.h: Adjust decls to match defn changes elsewhere.
858 (struct text_pos, struct glyph, struct bidi_saved_info)
859 (struct bidi_string_data, struct bidi_it, struct composition_it)
861 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
862 (struct display_pos, struct composition_it, struct it):
863 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
864 * dispnew.c (increment_matrix_positions)
865 (increment_row_positions, mode_line_string)
866 (marginal_area_string):
867 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
868 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
869 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
870 (duration_to_sec_usec): New function, to check for overflow better.
871 (Fsleep_for, sit_for): Use it.
872 * doc.c (get_doc_string, store_function_docstring):
873 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
874 (get_doc_string, Fsnarf_documentation):
875 Use int, not EMACS_INT, where int is wide enough.
877 Use SAFE_ALLOCA, not alloca.
878 Check for overflow when converting EMACS_INT to off_t.
880 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
881 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
882 Don't assume uid_t fits into fixnum.
883 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
884 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
885 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
886 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
887 (general_insert_function)
888 (Finsert_char, make_buffer_string, make_buffer_string_both)
889 (update_buffer_properties, Fbuffer_substring)
890 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
891 (Fsubst_char_in_region, check_translation)
892 (Ftranslate_region_internal, save_restriction_restore, Fformat)
893 (transpose_markers, Ftranspose_regions):
894 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
895 (clip_to_bounds): Move to lisp.h as an inline function).
896 (Fconstrain_to_field): Don't assume integers are nonnegative.
897 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
898 (Fsubst_char_in_region, Fsave_restriction):
899 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
900 (Femacs_pid): Don't assume pid_t fits into fixnum.
901 (lo_time): Use int, not EMACS_INT, when int suffices.
902 (lisp_time_argument): Check for usec out of range.
903 (Fencode_time): Don't assume fixnum fits in int.
904 (Fuser_login_name, Fuser_full_name): Signal an error
905 if a uid argument is out of range, rather than relying on
907 (Fformat_time_string): Remove now-unnecessary check.
908 lisp_time_argument checks for out-of-range usec now.
909 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
910 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
911 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
912 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
913 (init_cmdargs, Fdump_emacs):
914 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
915 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
916 the bottom (typically) 32 bits of the fixnum.
917 * eval.c (specpdl_size, call_debugger):
918 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
919 (when_entered_debugger, Fbacktrace_debug):
920 Don't assume fixnum can fit in int.
921 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
922 the object just before a buffer; this is not portable.
923 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
924 (grow_specpdl, unbind_to):
925 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
926 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
927 (grow_specpdl): Simplify allocation by using xpalloc.
928 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
929 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
930 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
931 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
932 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
934 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
935 (Fcopy_file, non_regular_nbytes, read_non_regular)
936 (Finsert_file_contents):
937 Use int, not EMACS_INT, where int is wide enough.
938 (READ_BUF_SIZE): Verify that it fits in int.
939 (Finsert_file_contents): Check that counts are in proper range,
940 rather than assuming fixnums fit into ptrdiff_t etc.
941 Don't assume fixnums fit into int.
942 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
943 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
944 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
945 (string_char_to_byte, string_byte_to_char)
946 (string_make_multibyte, string_to_multibyte)
947 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
948 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
949 (substring_both, Fdelete, internal_equal, Ffillarray)
950 (Fclear_string, mapcar1)
951 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
952 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
953 (larger_vector, make_hash_table, maybe_resize_hash_table)
954 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
955 (Fmaphash, secure_hash):
956 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
957 (concat): Check for string index and length overflow.
958 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
960 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
961 (larger_vector): New API (vec, incr_min, size_max) replaces old
962 one (vec, new_size, init). This catches size overflow.
963 INIT was removed because it was always Qnil.
965 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
966 the upper bound on a hash table index size.
967 (make_hash_table, maybe_resize_hash_table): Use it.
968 (secure_hash): Computer start_byte and end_byte only after
969 they're known to be in ptrdiff_t range.
970 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
971 (Ffont_get_glyphs, Ffont_at):
972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
973 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
974 (Flist_fonts, Fopen_font):
975 Don't assume fixnum can fit in int.
976 (check_gstring): Don't assume index can fit in int.
977 (font_match_p): Check that fixnum is a character, not a nonnegative
978 fixnum, since the later code needs to stuff it into an int.
979 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
980 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
981 conversion overflow issues.
982 (Fopen_font): Check for integer out of range.
983 (Ffont_get_glyphs): Don't assume index can fit in int.
984 * font.h: Adjust decls to match defn changes elsewhere.
985 * fontset.c (reorder_font_vector): Redo score calculation to avoid
987 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
988 printmax_t, where ptrdiff_t is wide enough.
989 (Finternal_char_font):
990 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
991 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
992 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
993 (Fset_frame_position, x_set_frame_parameters)
994 (x_set_line_spacing, x_set_border_width)
995 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
996 Check that fixnums are in proper range for system types.
997 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
998 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
999 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1000 Use SAFE_ALLOCA_LISP, not alloca.
1001 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1002 intptr_t is wide enough.
1003 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1004 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1005 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1006 Check for fixnum out of range.
1007 * ftfont.c (ftfont_list): Don't assume index fits in int.
1008 Check that fixnums are in proper range for system types.
1009 (ftfont_shape_by_flt):
1010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1011 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1012 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1013 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1014 Check that fixnums are in proper range for system types.
1015 * gnutls.h: Adjust decls to match defn changes elsewhere.
1016 * gtkutil.c (xg_dialog_run):
1017 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1018 (update_frame_tool_bar):
1019 Check that fixnums are in proper range for system types.
1020 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1021 (lookup_image): Check that fixnums are in range for system types.
1022 * indent.c (last_known_column, last_known_column_point):
1023 (current_column_bol_cache):
1024 (skip_invisible, current_column, check_display_width):
1025 (check_display_width, scan_for_column, current_column_1)
1026 (Findent_to, Fcurrent_indentation, position_indentation)
1027 (indented_beyond_p, Fmove_to_column, compute_motion):
1028 (Fcompute_motion, Fvertical_motion):
1029 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1030 (last_known_column_modified): Use EMACS_INT, not int.
1031 (check_display_width):
1033 Check that fixnums and floats are in proper range for system types.
1034 (compute_motion): Don't assume index or fixnum fits in int.
1035 (compute_motion, Fcompute_motion):
1036 Use int, not EMACS_INT, when it is wide enough.
1037 (vmotion): Omit local var start_hpos that is always 0; that way
1038 we don't need to worry about overflow in expressions involving it.
1039 * indent.h: Adjust decls to match defn changes elsewhere.
1041 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1042 Use int, not EMACS_INT, where int is wide enough.
1043 Remove unused members ovstring_chars_done and tab_offset;
1045 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1046 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1047 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1048 (make_gap, copy_text, insert, insert_and_inherit)
1049 (insert_before_markers, insert_before_markers_and_inherit)
1050 (insert_1, count_combining_before, count_combining_after)
1051 (insert_1_both, insert_from_string)
1052 (insert_from_string_before_markers, insert_from_string_1)
1053 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1054 (adjust_after_replace, adjust_after_insert, replace_range)
1055 (replace_range_2, del_range, del_range_1, del_range_byte)
1056 (del_range_both, del_range_2, modify_region)
1057 (prepare_to_modify_buffer, signal_before_change)
1058 (signal_after_change, Fcombine_after_change_execute):
1059 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1060 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1061 (balance_an_interval, split_interval_right, split_interval_left)
1062 (find_interval, next_interval, update_interval)
1063 (adjust_intervals_for_insertion, delete_node, delete_interval)
1064 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1065 (static_offset_intervals, offset_intervals)
1066 (merge_interval_right, merge_interval_left, make_new_interval)
1067 (graft_intervals_into_buffer, temp_set_point_both)
1068 (temp_set_point, set_point, adjust_for_invis_intang)
1069 (set_point_both, move_if_not_intangible, get_property_and_range)
1070 (get_local_map, copy_intervals, copy_intervals_to_string)
1071 (compare_string_intervals, set_intervals_multibyte_1):
1072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1073 * intervals.h: Adjust decls to match defn changes elsewhere.
1075 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1076 * keyboard.c (this_command_key_count, this_single_command_key_start)
1077 (before_command_key_count, before_command_echo_length, echo_now)
1078 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1079 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1080 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1081 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1082 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1083 (last_non_minibuf_size, last_point_position, echo_truncate)
1084 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1085 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1086 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1087 (stuff_buffered_input):
1088 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1089 (last_auto_save, command_loop_1, read_char):
1090 Use EMACS_INT, not int, to avoid integer overflow.
1091 (record_char): Avoid overflow in total_keys computation.
1092 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1093 * keyboard.h: Adjust decls to match defn changes elsewhere.
1094 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1095 (Fkey_description, Fdescribe_vector, Flookup_key):
1096 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1097 (click_position): New function, to check that positions are in range.
1098 (Fcurrent_active_maps):
1100 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1101 (Faccessible_keymaps, Fkey_description):
1102 (preferred_sequence_p):
1103 Don't assume fixnum can fit into int.
1104 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1105 Check for integer overflow in size calculations.
1106 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1107 avoid mishandling large integers.
1108 * lisp.h: Adjust decls to match defn changes elsewhere.
1109 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1110 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1111 (struct Lisp_Marker):
1112 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1113 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1114 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1115 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1116 All callers changed.
1117 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1118 Assume the arg has valid form, since it always does.
1119 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1120 unsigned integer system type.
1121 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1122 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1123 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1124 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1125 (duration_to_sec_usec): New decl.
1126 * lread.c (read_from_string_index, read_from_string_index_byte)
1127 (read_from_string_limit, readchar, unreadchar, openp)
1128 (read_internal_start, read1, oblookup):
1129 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1130 (Fload, readevalloop, Feval_buffer, Feval_region):
1131 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1132 (openp): Check for out-of-range argument to 'access'.
1133 (read1): Use int, not EMACS_INT, where int is wide enough.
1134 Don't assume fixnum fits into int.
1135 Fix off-by-one error that can read outside a buffer.
1136 (read_filtered_event): Use duration_to_sec_usec
1137 to do proper overflow checking on durations.
1138 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1139 in size calculation.
1140 (Fexecute_kbd_macro):
1141 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1142 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1143 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1144 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1145 (set_marker_both, set_marker_restricted_both, marker_position)
1146 (marker_byte_position, Fbuffer_has_markers_at):
1147 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1148 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1149 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1150 It now merely ensures that the menu is large enough, without
1151 necessarily growing it, as this avoids some integer overflow issues.
1152 All callers changed.
1153 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1154 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1155 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1156 Use SAFE_ALLOCA_LISP, not alloca.
1157 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1158 to EMACS_INT. Check that fixnums are in proper range for system types.
1159 * minibuf.c (minibuf_prompt_width, string_to_object)
1160 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1161 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1162 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1163 (get_minibuffer, read_minibuf_unwind):
1164 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1165 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1166 this simplifies overflow checking. All callers changed.
1167 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1169 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1170 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1171 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1172 Check that fixnums are in proper range for system types.
1173 (Fx_create_frame, Fx_show_tip):
1174 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1175 * nsfont.m (ns_findfonts, nsfont_list_family):
1176 Don't assume fixnum fits in long.
1177 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1178 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1179 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1181 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1182 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1183 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1184 (PRINTDECLARE, PRINTPREPARE):
1185 (strout, print_string):
1186 (print, print_preprocess, print_check_string_charset_prop)
1188 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1190 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1191 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1192 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1193 (printchar, strout): Use xpalloc to catch size calculation overflow.
1194 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1195 (print_error_message): Use SAFE_ALLOCA, not alloca.
1196 (print_object): Use int, not EMACS_INT, where int is wide enough.
1197 (print_depth, new_backquote_output, print_number_index):
1198 Use ptrdiff_t, not int, where int might not be wide enough.
1199 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1200 (Fset_process_window_size, Fformat_network_address)
1201 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1203 Check that fixnums are in proper range for system types.
1204 (Fsignal_process): Simplify by avoiding a goto.
1205 Check for process-ids out of pid_t range rather than relying on
1207 (process_tick, update_tick): Use EMACS_INT, not int.
1208 (Fformat_network_address, read_process_output, send_process)
1209 (Fprocess_send_region, status_notify):
1210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1211 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1212 (wait_reading_process_output, read_process_output, exec_sentinel):
1213 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1214 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1215 (Faccept_process_output): Use duration_to_sec_usec to do proper
1216 overflow checking on durations.
1217 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1218 Don't assume pid_t fits in int.
1219 * process.h (struct Lisp_Process): Members tick and update_tick
1220 are now of type EMACS_INT, not int.
1221 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1222 configured --with-wide-int.
1223 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1224 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1225 * search.c (looking_at_1, string_match_1):
1226 (fast_string_match, fast_c_string_match_ignore_case)
1227 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1228 (scan_newline, find_before_next_newline, search_command)
1229 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1230 (set_search_regs, wordify):
1233 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1234 (string_match_1, search_buffer, set_search_regs):
1236 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1237 (wordify): Check for overflow in size calculation.
1238 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1239 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1240 Check that fixnums are in proper range for system types.
1241 * sound.c (struct sound_device)
1242 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1243 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1244 (Fplay_sound_internal):
1245 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1246 * syntax.c (struct lisp_parse_state, find_start_modiff)
1247 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1248 (Fparse_partial_sexp):
1249 Don't assume fixnums can fit in int.
1250 (struct lisp_parse_state, find_start_pos, find_start_value)
1251 (find_start_value_byte, find_start_begv)
1252 (update_syntax_table, char_quoted, dec_bytepos)
1253 (find_defun_start, prev_char_comend_first, back_comment):
1254 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1255 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1256 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1257 (Finternal_describe_syntax_value): Check that match_lisp is a
1258 character, not an integer, since the code stuffs it into int.
1259 (scan_words, scan_sexps_forward):
1260 Check that fixnums are in proper range for system types.
1262 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1263 (scan_sexps_forward):
1264 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1265 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1266 * syntax.h: Adjust decls to match defn changes elsewhere.
1267 (struct gl_state_s):
1268 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1269 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1270 MOST_POSITIVE_FIXNUM.
1271 * sysdep.c (wait_for_termination_1, wait_for_termination)
1272 (interruptible_wait_for_termination, mkdir):
1273 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1274 (emacs_read, emacs_write):
1275 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1276 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1277 and double all fit in int.
1278 * term.c (set_tty_color_mode):
1279 Check that fixnums are in proper range for system types.
1280 * termhooks.h (struct input_event):
1281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1282 * textprop.c (validate_interval_range, interval_of)
1283 (Fadd_text_properties, set_text_properties_1)
1284 (Fremove_text_properties, Fremove_list_of_text_properties)
1285 (Ftext_property_any, Ftext_property_not_all)
1286 (copy_text_properties, text_property_list, extend_property_ranges)
1287 (verify_interval_modification):
1288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1289 (Fnext_single_char_property_change)
1290 (Fprevious_single_char_property_change):
1291 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1292 (copy_text_properties):
1293 Check for integer overflow in index calculation.
1294 * undo.c (last_boundary_position, record_point, record_insert)
1295 (record_delete, record_marker_adjustment, record_change)
1296 (record_property_change):
1297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1298 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1299 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1300 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1301 (Fx_hide_tip, Fx_file_dialog):
1302 * w32menu.c (set_frame_menubar):
1303 Use ptrdiff_t, not int, for consistency with rest of code.
1304 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1305 (select_window, Fdelete_other_windows_internal)
1306 (window_scroll_pixel_based, window_scroll_line_based)
1307 (Frecenter, Fset_window_configuration):
1308 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1309 (Fset_window_hscroll, run_window_configuration_change_hook)
1310 (set_window_buffer, temp_output_buffer_show, scroll_command)
1311 (Fscroll_other_window, Frecenter):
1312 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1313 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1314 Don't assume fixnum fits in int.
1315 (Fset_window_scroll_bars):
1316 Check that fixnums are in proper range for system types.
1317 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1318 (string_pos, c_string_pos, number_of_chars, init_iterator)
1319 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1320 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1321 (compute_display_string_end, handle_face_prop)
1322 (face_before_or_after_it_pos, handle_invisible_prop)
1323 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1324 (display_prop_intangible_p, string_buffer_position_lim)
1325 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1326 (get_overlay_strings_1, get_overlay_strings)
1327 (iterate_out_of_display_property, forward_to_next_line_start)
1328 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1329 (get_next_display_element, set_iterator_to_next)
1330 (get_visually_first_element, compute_stop_pos_backwards)
1331 (handle_stop_backwards, next_element_from_buffer)
1332 (move_it_in_display_line_to, move_it_in_display_line)
1333 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1334 (add_to_log, message_dolog, message_log_check_duplicate)
1335 (message2, message2_nolog, message3, message3_nolog
1336 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1337 (current_message_1, truncate_echo_area, truncate_message_1)
1338 (set_message, set_message_1, store_mode_line_noprop)
1339 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1340 (text_outside_line_unchanged_p, check_point_in_composition)
1341 (reconsider_clip_changes)
1342 (redisplay_internal, set_cursor_from_row, try_scrolling)
1343 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1344 (redisplay_window, find_last_unchanged_at_beg_row)
1345 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1346 (trailing_whitespace_p, find_row_edges, display_line)
1347 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1348 (display_mode_element, store_mode_line_string)
1349 (pint2str, pint2hrstr, decode_mode_spec)
1350 (display_count_lines, display_string, draw_glyphs)
1351 (x_produce_glyphs, x_insert_glyphs)
1352 (rows_from_pos_range, mouse_face_from_buffer_pos)
1353 (fast_find_string_pos, mouse_face_from_string_pos)
1354 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1355 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1356 (safe_call, init_from_display_pos, handle_fontified_prop)
1357 (handle_single_display_spec, load_overlay_strings)
1358 (with_echo_area_buffer, setup_echo_area_for_printing)
1359 (display_echo_area, echo_area_display)
1360 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1361 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1362 (redisplay_window, dump_glyph_row, display_mode_line)
1363 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1364 (handle_display_spec, display_prop_string_p):
1365 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1366 (handle_single_display_spec, build_desired_tool_bar_string)
1367 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1368 (get_specified_cursor_type):
1369 Check that fixnums are in proper range for system types.
1370 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1371 (Flookup_image_map):
1372 Don't assume fixnums fit in int.
1373 (compare_overlay_entries):
1374 Avoid mishandling comparisons due to subtraction overflow.
1375 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1376 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1377 (handle_tool_bar_click):
1378 Use int, not unsigned, since we prefer signed and the signedness
1379 doesn't matter here.
1380 (get_next_display_element, next_element_from_display_vector):
1381 Use int, not EMACS_INT, when int is wide enough.
1382 (start_hourglass): Use duration_to_sec_usec to do proper
1383 overflow checking on durations.
1384 * xfaces.c (Fbitmap_spec_p):
1385 Check that fixnums are in proper range for system types.
1386 (compare_fonts_by_sort_order):
1387 Avoid mishandling comparisons due to subtraction overflow.
1388 (Fx_family_fonts, realize_basic_faces):
1389 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1391 Don't assume fixnum fits in int.
1392 Use SAFE_ALLOCA_LISP, not alloca.
1393 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1394 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1395 (face_at_buffer_position, face_for_overlay_string)
1396 (face_at_string_position):
1397 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1398 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1399 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1401 Check that fixnums are in proper range for system types.
1402 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1403 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1404 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1405 (Fx_change_window_property): Don't assume fixnums fit in int.
1406 * xfont.c (xfont_chars_supported):
1407 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1408 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1409 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1410 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1411 * xml.c (parse_region):
1412 * xrdb.c (magic_file_p):
1413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1414 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1415 (x_get_local_selection, x_reply_selection_request)
1416 (x_handle_selection_request, wait_for_property_change):
1417 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1418 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1419 short is wide enough.
1420 (x_send_client_event): Don't assume fixnum fits in int.
1421 * xterm.c (x_x_to_emacs_modifiers):
1422 Don't assume EMACS_INT overflows nicely into int.
1423 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1425 (handle_one_xevent): NATNUMP can eval its arg twice.
1426 (x_connection_closed):
1427 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1428 * xterm.h: Adjust decls to match defn changes elsewhere.
1429 (struct scroll_bar): Use struct vectorlike_header
1430 rather than rolling our own approximation.
1431 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1433 2012-05-25 Glenn Morris <rgm@gnu.org>
1435 * lisp.mk (lisp): Update for more files being compiled now.
1437 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1439 * lread.c: Remove `read_pure' which makes no difference.
1440 (read_pure): Remove var.
1441 (unreadpure): Remove function.
1442 (readevalloop): Don't call read_list with -1 flag.
1443 (read1, read_vector): Don't test read_pure any more.
1444 (read_list): Simplify.
1446 * fileio.c, character.h: Minor style tweaks.
1448 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1450 * window.h (clip_changed): Remove useless declaration.
1452 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1454 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1455 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1457 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1460 This directory predates autoconf and is no longer needed nowadays.
1461 Move its few remaining bits of functionality to where they're needed.
1462 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1463 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1464 * m/template.h: Remove.
1465 * Makefile.in (M_FILE): Remove. All uses removed.
1466 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1467 * lisp.h (USE_LSB_TAG):
1468 * mem-limits.h (EXCEEDS_LISP_PTR):
1469 Use VAL_MAX, not VALBITS, in #if.
1470 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1471 (EMACS_UINT): Define unconditionally now.
1472 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1473 (BITS_PER_EMACS_INT): New constants, replacing
1474 what used to be in config.h, but not useful in #if.
1475 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1476 define them any more.
1477 (VAL_MAX): New macro.
1479 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1480 BITS_PER_EMACS_INT, in #if.
1481 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1482 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1483 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1484 * s/ms-w32.h (DATA_START):
1485 Move here from removed file m/intel386.h.
1486 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1487 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1489 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1491 Assume C89 or later.
1492 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1493 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1495 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1496 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1497 * textprop.c, tparam.c (NULL): Remove.
1498 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1499 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1500 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1501 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1502 * xterm.c (input_signal_count): Assume volatile works.
1504 2012-05-21 Ken Brown <kbrown@cornell.edu>
1506 * xgselect.c (xg_select): Fix first argument in call to 'select'
1509 2012-05-20 Ken Brown <kbrown@cornell.edu>
1511 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1512 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1514 2012-05-19 Ken Brown <kbrown@cornell.edu>
1516 * xfns.c (x_in_use): Remove `static' qualifier.
1517 * xterm.h (x_in_use): Declare.
1518 * xgselect.c: Include xterm.h.
1519 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1520 and `display_arg' (bug#9754).
1522 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1524 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1526 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1527 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1529 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1531 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1533 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1534 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1536 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1537 reference to image_cache->refcount.
1538 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1540 2012-05-17 Juri Linkov <juri@jurta.org>
1542 * search.c (Fword_search_regexp, Fword_search_backward)
1543 (Fword_search_forward, Fword_search_backward_lax)
1544 (Fword_search_forward_lax): Move functions to isearch.el
1545 (bug#10145, bug#11381).
1547 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1549 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1551 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1553 * lread.c (init_obarray): Declare Qt and Qnil as special.
1555 2012-05-14 Glenn Morris <rgm@gnu.org>
1557 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1558 Put "libexec" before "bin", for the sake of init_callproc_1.
1560 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1562 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1564 * unexaix.c: Port to more-recent AIX compilers.
1565 (report_error, report_error_1, make_hdr, copy_sym)
1566 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1567 Make arguments const char *, not char *, to avoid violations of C
1568 standard and to fix some AIX warnings reported by Gilles Pion.
1570 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1572 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1573 already have overlays loaded.
1574 (handle_single_display_spec): Before returning without displaying
1575 fringe bitmap, synchronize the bidi iterator with the main display
1576 iterator, by calling iterate_out_of_display_property.
1577 (iterate_out_of_display_property): Detect buffer iteration by
1578 testing that it->string is a Lisp string.
1579 (get_next_display_element): When the current object is exhausted,
1580 and there's something on it->stack, call set_iterator_to_next to
1581 proceed with what's on the stack, instead of returning zero.
1582 (set_iterator_to_next): If called at the end of a Lisp string,
1583 proceed to consider_string_end without incrementing string
1584 position. Don't increment display vector index past the end of
1585 the display vector. (Bug#11417)
1586 (pos_visible_p): Don't report a position visible when move_it_to
1587 stopped at the last line of window, which happens to be scanned
1588 backwards by the bidi iteration. (Bug#11464)
1590 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1592 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1593 and right-margin display specs even if the spec is invalid or we
1594 are on a TTY, and thus unable to display on the fringes.
1595 That's because the text with the property will not be displayed anyway,
1596 so we need to signal to the caller that this is a "replacing"
1597 display spec. This fixes display when the spec is invalid or we
1600 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1602 * unexaix.c (make_hdr): Fix typo in prototype.
1603 This bug broke the build on AIX. Problem reported by Gilles Pion.
1605 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1607 * keyboard.c (kbd_buffer_get_event): Read special events also in
1608 batch mode. (Bug#11415)
1610 2012-05-12 Glenn Morris <rgm@gnu.org>
1612 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1614 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1616 * lisp.mk (lisp): Add newcomment.elc.
1618 2012-05-12 Glenn Morris <rgm@gnu.org>
1620 * Makefile.in (MKDIR_P): New, set by configure.
1621 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1623 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1625 Remove unused function hourglass_started.
1626 * dispextern.h (hourglass_started):
1627 * w32fns.c (hourglass_started):
1628 * xdisp.c (hourglass_started): Remove.
1630 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1632 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1633 Update dependencies.
1635 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1637 * xgselect.c (xg_select): Put maxfds+1 into a var.
1638 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1640 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1642 2012-05-10 Dave Abrahams <dave@boostpro.com>
1644 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1645 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1647 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1649 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1650 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1651 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1652 Initialize xd_registered_buses.
1654 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1656 Untag more efficiently if USE_LSB_TAG.
1657 This is based on a proposal by YAMAMOTO Mitsuharu in
1658 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1659 For an admittedly artificial (nth 8000 longlist) benchmark on
1660 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1661 Emacs's overall text size by 1%.
1662 * lisp.h (XUNTAG): New macro.
1663 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1664 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1665 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1666 * eval.c (Fautoload):
1667 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1668 * frame.h (XFRAME): Use XUNTAG.
1670 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1671 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1672 Remove unportable assumptions about print widths of types like
1674 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1675 intptr_t when converting between pointer and integer, to avoid GCC
1676 warnings about wrong width.
1678 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1680 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1681 stack for each reader_thread, instead of defaulting to 8MB
1682 determined by the linker. This avoids failures in creating
1683 subprocesses on Windows 7, see the discussion in this thread:
1684 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1686 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1688 Fix up display of the *Minibuf-0* buffer in the mini window.
1689 * keyboard.c (read_char): Don't clear the echo area if there's no
1691 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1692 contents of *Minibuf-0*) if there's no message displayed in its stead.
1694 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1696 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1699 2012-05-06 Chong Yidong <cyd@gnu.org>
1701 * lisp.mk (lisp): Update.
1703 2012-05-05 Jim Meyering <meyering@redhat.com>
1705 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1707 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1709 * data.c (PUT_ERROR): New macro.
1710 (syms_of_data): Use it. Add new error type `user-error'.
1711 * undo.c (user_error): New function.
1712 (Fprimitive_undo): Use it.
1713 * print.c (print_error_message): Adjust print style for `user-error'.
1714 * keyboard.c (user_error): New function.
1715 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1717 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1719 Do not limit current-time-string to years 1000..9999.
1720 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1721 (Fcurrent_time_string): Support any year that is supported by the
1722 underlying localtime representation. Don't use asctime, as it
1723 has undefined behavior for years outside the range -999..9999.
1725 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1727 Fix race conditions involving setenv, gmtime, localtime, asctime.
1728 Without this fix, interrupts could mess up code that uses these
1729 nonreentrant functions, since setting TZ invalidates existing
1730 tm_zone or tzname values, and since most of these functions return
1731 pointers to static storage.
1732 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1733 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1734 Grow the critical sections to include not just invoking
1735 localtime/gmtime, but also accessing these functions' results
1736 including their tm_zone values if any, and any related TZ setting.
1737 (format_time_string): Last arg is now struct tm *, not struct tm **,
1738 so that the struct tm is saved in the critical section.
1739 All callers changed. Simplify allocation of initial buffer, partly
1740 motivated by the fact that memory allocation needs to be outside
1741 the critical section.
1743 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1745 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1746 with RESET_INTERVAL.
1748 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1749 Remove duplicated buffer name initialization.
1751 2012-05-02 Jim Meyering <jim@meyering.net>
1753 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1755 * xfns.c (x_window): Use xstrdup (Bug#11375).
1757 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1759 * xdisp.c (pos_visible_p): If already at a newline from the
1760 display string before the 'while' loop, don't walk back the glyphs
1761 from it3.glyph_row. Solves assertion violation when the display
1762 string begins with a newline (egg.el). (Bug#11367)
1764 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1766 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1769 2012-05-01 Glenn Morris <rgm@gnu.org>
1771 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1772 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1773 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1774 All were removed before 23.1.
1776 * dispnew.c: Remove HAVE_LIBNCURSES test;
1777 it is always true on relevant platforms.
1779 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1780 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1782 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1784 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1786 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1787 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1790 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1792 Do not avoid creating empty evaporating overlays (Bug#9642).
1793 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1794 That is, do not delete an evaporating overlay if it becomes
1795 empty after its bounds are adjusted to fit within its buffer.
1796 This fix caused other problems, and I'm reverting it until we get
1797 to the bottom of them.
1799 2012-04-27 Chong Yidong <cyd@gnu.org>
1801 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1803 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1805 * xdisp.c (pos_visible_p): If the window start position is beyond
1806 ZV, start the display from buffer beginning. Prevents assertion
1807 violation in init_iterator when the minibuffer window is scrolled
1810 * window.c (window_scroll_pixel_based): Likewise.
1812 2012-04-27 Chong Yidong <cyd@gnu.org>
1814 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1816 2012-04-27 Glenn Morris <rgm@gnu.org>
1818 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1819 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1821 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1823 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1824 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1826 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1828 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1829 display element, check also the underlying string or buffer
1830 character. (Bug#11341)
1832 * w32menu.c: Include w32heap.h.
1833 (add_menu_item): If the call to AppendMenuW (via
1834 unicode_append_menu) fails, disable Unicode menus only if we are
1835 running on Windows 9X/Me.
1837 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1839 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1840 (xgetint): Add missing shift for LSB tags.
1842 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1844 * keyboard.c (read_char): Don't wipe echo area for select window
1845 events: These might get delayed via `mouse-autoselect-window'
1848 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1850 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1851 manipulation of :loaded-from data.
1853 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1855 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1856 now a cons (bug#11311).
1858 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1860 Do not create empty overlays with the evaporate property (Bug#9642).
1861 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1862 if it becomes empty after its bounds are adjusted to fit within
1863 its buffer. Without this fix, in a nonempty buffer (let ((o
1864 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1865 yields an empty overlay that has the evaporate property, which is
1866 not supposed to happen.
1868 Fix minor GTK3 problems found by static checking.
1869 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1870 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1871 (struct _EmacsFixedClass, emacs_fixed_get_type):
1872 Move decls here from emacsgtkfixed.h, since they needn't be public.
1873 (emacs_fixed_get_type): Now static.
1874 (emacs_fixed_class_init): Omit unused local.
1875 (emacs_fixed_child_type): Remove; unused.
1876 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1877 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1878 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1879 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1880 (EMACS_FIXED_GET_CLASS): Remove; unused.
1881 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1883 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1884 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1886 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1888 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1889 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1890 (__malloc_size_t, __malloc_ptrdiff_t):
1891 Remove. All uses removed, replaced by the definiens if needed,
1892 since we can assume C89 or better now.
1893 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1894 (protect_malloc_state, align, get_contiguous_space)
1895 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1896 (malloc_atfork_handler_child, malloc_enable_thread)
1897 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1898 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1899 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1900 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1901 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1902 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1903 Define using prototypes, not old style.
1904 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1905 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1906 (align): Don't assume that signed integer overflow wraps around.
1907 Omit unused local var.
1908 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1909 (_free_internal_nolock, memalign, mallochook, reallochook):
1910 Omit no-longer-needed casts.
1911 (valloc): Use getpagesize, not __getpagesize.
1912 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1913 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1915 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1917 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1919 Move functions from C to Lisp. Make non-blocking method calls
1920 the default. Implement further D-Bus standard interfaces.
1922 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1923 (QCdbus_request_name_allow_replacement)
1924 (QCdbus_request_name_replace_existing)
1925 (QCdbus_request_name_do_not_queue)
1926 (QCdbus_request_name_reply_primary_owner)
1927 (QCdbus_request_name_reply_in_queue)
1928 (QCdbus_request_name_reply_exists)
1929 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1930 (QCdbus_registered_serial, QCdbus_registered_method)
1931 (QCdbus_registered_signal): New Lisp objects.
1932 (XD_DEBUG_MESSAGE): Use sizeof.
1933 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1934 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1935 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1936 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1937 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1938 (xd_signature, xd_append_arg): Allow float for integer types.
1939 (xd_get_connection_references): New function.
1940 (xd_get_connection_address): Rename from xd_initialize.
1941 Return cached address.
1942 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1943 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1945 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1946 Return number of refcounts.
1947 (Fdbus_get_unique_name): Make stronger parameter check.
1948 (Fdbus_message_internal): New defun.
1949 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1950 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1951 (Fdbus_send_signal, Fdbus_register_service)
1952 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1953 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1954 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1955 (Vdbus_compiled_version, Vdbus_runtime_version)
1956 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1957 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1958 (Vdbus_message_type_signal): New defvars.
1959 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1962 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1964 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1965 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1966 Do not assume ptrdiff_t is the same width as 'int'.
1968 * alloc.c: Handle unusual debugging option combinations.
1969 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1970 since the two debugging options are incompatible.
1971 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1973 (mem_init, mem_insert, mem_insert_fixup):
1974 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1975 (NEED_MEM_INSERT): Remove; no longer needed.
1977 2012-04-22 Leo Liu <sdl.web@gmail.com>
1979 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1981 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1983 * sysdep.c [__FreeBSD__]: Minor cleanups.
1984 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1985 Use Emacs indenting style more consistently. Avoid some casts.
1986 Use 'double' consistently rather than mixing 'float' and 'double'.
1988 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1990 * sysdep.c (list_system_processes, system_process_attributes):
1991 Add implementation for FreeBSD (Bug#5243).
1993 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1995 * lisp.mk (lisp): Update.
1997 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1999 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2000 It is never used otherwise.
2002 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2004 * print.c (print_preprocess): Only check print_depth if print-circle
2006 (print_object): Check for cycles even when print-circle is nil and
2007 print-gensym is t, but only check print_depth if print-circle is nil.
2009 2012-04-20 Chong Yidong <cyd@gnu.org>
2011 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2012 set the status to "failed" and ensure that sentinel is run.
2014 2012-04-20 Glenn Morris <rgm@gnu.org>
2016 * process.c (Fset_process_inherit_coding_system_flag)
2017 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2018 (Fmake_network_process, Fmake_serial_process): Doc fix.
2020 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2022 * xdisp.c (string_buffer_position_lim): Limit starting position to
2024 (set_cursor_from_row): If called for a mode-line or header-line
2025 row, return zero immediately.
2026 (try_cursor_movement): If inside continuation line, don't back up
2027 farther than the first row after the header line, if any.
2028 Don't consider the header-line row as "partially visible", even if
2029 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2031 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2033 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2036 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2037 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2039 configure: new option --enable-gcc-warnings (Bug#11207)
2040 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2041 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2042 (ALL_CFLAGS): Use new macros rather than old.
2043 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2044 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2045 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2046 -Wunused-result, -Wunused-variable. This should go away once
2047 the Emacs and Gnulib regex code is merged.
2048 (xmalloc, xrealloc): Now static.
2050 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2052 * dired.c (Fsystem_groups): Remove unused local.
2054 2012-04-17 Glenn Morris <rgm@gnu.org>
2056 * dired.c (Fsystem_users): Doc fix.
2058 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2060 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2061 (syms_of_dired): Add them.
2063 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2065 Fix minor alloc.c problems found by static checking.
2066 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2067 New extern decls, to avoid calling undeclared functions.
2068 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2069 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2070 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2071 (NEED_MEM_INSERT): New macro.
2072 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2073 Remove one incorrect comment and fix another.
2075 Fix minor ralloc.c problems found by static checking.
2076 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2077 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2078 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2079 (r_alloc_sbrk): Now static.
2081 Improve ralloc.c interface checking.
2082 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2083 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2084 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2085 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2086 [REL_ALLOC]: ... to here, to check interface.
2087 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2088 Remove decls. This fixes an "It stinks!".
2090 * alloc.c (which_symbols): Fix alignment issue / type clash.
2092 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2094 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2095 (struct Lisp_Misc_Any): Likewise.
2096 (struct Lisp_Free): Likewise.
2097 * alloc.c (union aligned_Lisp_Symbol): Define.
2098 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2099 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2100 (union aligned_Lisp_Misc): Define.
2101 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2102 aligned_Lisp_Misc instead of union Lisp_Misc.
2103 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2105 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2107 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2108 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2109 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2110 * s/netbsd.h, s/sol2-6.h:
2111 Remove definition of GC_MARK_STACK, since the default now works.
2112 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2113 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2114 no longer the default.
2115 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2117 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2119 * lread.c (lisp_file_lexically_bound_p):
2120 Fix hang at ";-*-\n" (bug#11238).
2122 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2124 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2125 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2127 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2129 * nsterm.m (constrainFrameRect): Always constrain when there is only
2130 one screen (Bug#10962).
2132 2012-04-13 Ken Brown <kbrown@cornell.edu>
2134 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2136 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2138 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2140 2012-04-11 Daniel Colascione <dancol@dancol.org>
2142 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2143 against is gone. It's better to use vfork now so that when Cygwin
2144 gains a new, working vfork, we use it automatically (bug#10398).
2146 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2148 * window.c (save_window_save): Obey window-point-insertion-type.
2150 2012-04-11 Glenn Morris <rgm@gnu.org>
2152 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2154 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2156 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2158 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2160 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2161 (force_quit_count): New var.
2162 (handle_interrupt): Use it.
2164 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2166 * w32.c (w32_delayed_load): Record the full path of the library
2167 being loaded (bug#10424).
2169 2012-04-09 Glenn Morris <rgm@gnu.org>
2171 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2172 not just in the obarray, before snarfing them. (Bug#11036)
2174 * Makefile.in ($(leimdir)/leim-list.el):
2175 Pass EMACS rather than BUILT_EMACS.
2177 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2179 * process.c (make_process):
2180 * process.h: Add integer `gnutls_handshakes_tried' member to
2183 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2184 Add convenience `GNUTLS_LOG2i' macro.
2186 * gnutls.c (gnutls_log_function2i): Convenience log function.
2187 (emacs_gnutls_read): Use new log functions,
2188 `gnutls_handshakes_tried' process member, and
2189 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2190 attempts per process (connection).
2192 2012-04-09 Chong Yidong <cyd@gnu.org>
2194 * eval.c (Fuser_variable_p, user_variable_p_eh)
2195 (lisp_indirect_variable): Functions deleted.
2196 (Fdefvar): Caller changed.
2198 * callint.c (Finteractive, Fcall_interactively):
2199 * minibuf.c (Fread_variable): Callers changed.
2201 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2203 * xdisp.c (set_cursor_from_row): If the display string appears in
2204 the buffer at position that is closer to point than the position
2205 after the display string, display the cursor on the first glyph of
2206 the display string. Fixes cursor display when a 'display' text
2207 property immediately follows invisible text. (Bug#11094)
2209 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2211 composite.c: use 'double' consistently
2212 * composite.c (get_composition_id): Use 'double' consistently
2213 instead of converting 'float' to 'double' and vice versa; this is
2214 easier to understand and avoids a GCC warning.
2216 2012-04-09 Glenn Morris <rgm@gnu.org>
2218 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2219 preparation for dumping it with emacs. (Bug#4789)
2220 (leimdir): New variable.
2221 ($(leimdir)/leim-list.el): New rule.
2222 (emacs$(EXEEXT)): Depend on leim-list.el.
2224 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2225 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2226 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2228 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2230 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2233 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2235 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2236 Remove unused local variable.
2238 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2240 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2241 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2242 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2243 objects, as mark_maybe_pointer will catch them otherwise.
2244 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2245 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2247 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2249 Fix typo that broke non-Windows builds.
2250 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2252 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2254 Support building on MS-Windows with libxml2.
2256 * makefile.w32-in (OBJ2): Add xml.$(O).
2257 (GLOBAL_SOURCES): Add xml.c.
2258 ($(BLD)/xml.$(O)): New dependency list.
2260 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2261 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2262 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2263 [!WINDOWSNT]: New macros.
2264 (init_libxml2_functions, libxml2_loaded_p): New functions.
2265 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2266 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2267 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2268 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2270 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2271 Call init_libxml2_functions before calling libxml2 functions.
2272 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2274 * emacs.c: Don't include libxml/parser.h.
2275 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2276 xmlCleanupParser directly.
2278 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2280 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2282 * indent.c (Fvertical_motion): If there is a display string at
2283 point, use it.vpos to compute how many lines to backtrack after
2284 move_it_to point. (Bug#11133)
2286 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2288 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2289 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2290 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2291 macros related to unification of CJK characters. For the details,
2292 see the discussion following the message here:
2293 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2295 2012-04-04 Chong Yidong <cyd@gnu.org>
2297 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2299 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2301 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2302 instead of alloca. (Bug#11138)
2304 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2306 * w32menu.c (is_simple_dialog): Properly check lisp types.
2309 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2311 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2312 position we get to after a call to move_it_to fails the
2313 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2314 only if we wind up in a string from display property. (Bug#11063)
2316 * window.c (Fdelete_other_windows_internal): Invalidate the row
2317 and column information about mouse highlight, so that redisplay
2318 restores it after reallocating the glyph matrices. (Bug#7464)
2320 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2321 string comes from a `display' text property, use the buffer
2322 position of that property as if we actually saw that position in
2324 (move_it_by_lines): Remove the assertion that
2325 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2326 violated when there's a before-string at the beginning of a line.
2329 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2331 * xdisp.c (append_space_for_newline): If the default face was
2332 remapped, use the remapped face for the appended newline.
2333 (extend_face_to_end_of_line): Use the remapped default face for
2334 extending the face to the end of the line.
2335 (display_line): Call extend_face_to_end_of_line when the default
2336 face was remapped. (Bug#11068)
2338 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2340 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2342 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2344 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2346 2012-03-27 Glenn Morris <rgm@gnu.org>
2348 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2351 2012-03-26 Kenichi Handa <handa@m17n.org>
2353 * dispextern.h (struct glyph): Fix previous change. Change the
2354 bit length of glyphless.ch to 25 (Bug#11082).
2356 2012-03-26 Chong Yidong <cyd@gnu.org>
2358 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2359 (command_loop_1): Use it; inhibit selection update for
2360 handle-select-window too (Bug#8996).
2362 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2364 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2366 2012-03-25 Kenichi Handa <handa@m17n.org>
2368 * dispextern.h (struct glyph): Change the bit length of
2369 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2371 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2373 * s/ms-w32.h (tzname): Include time.h before redirecting to
2374 _tzname. Fixes the MSVC build. (Bug#9960)
2376 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2378 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2381 * xterm.c (XTread_socket): Only modify handling_signal if
2382 !SYNC_INPUT. (Bug#11080)
2384 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2386 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2387 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2388 when fetching a multibyte character consumes more bytes than
2389 CHAR_BYTES returns, due to unification of CJK characters in
2390 string_char. (Bug#11073)
2392 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2394 * process.c (wait_reading_process_output): Handle pty disconnect
2395 by refraining from sending oneself a SIGCHLD (bug#10933).
2397 2012-03-22 Chong Yidong <cyd@gnu.org>
2399 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2401 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2402 Mark string as coming from a prefix property.
2403 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2404 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2406 2012-03-21 Chong Yidong <cyd@gnu.org>
2408 * xfaces.c (Vface_remapping_alist): Doc fix.
2410 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2412 * w32proc.c (Fw32_set_console_codepage)
2413 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2416 2012-03-20 Chong Yidong <cyd@gnu.org>
2418 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2419 to reflect default non-nil value of redisplay-dont-pause.
2421 2012-03-19 Kenichi Handa <handa@m17n.org>
2423 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2424 it fit in a valid range (Bug#11003).
2426 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2428 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2429 that is not from display property, accept the row as a "cursor
2430 row" if one of the string's character has a non-nil `cursor'
2431 property. Fixes cursor positioning when there are newlines in
2432 overlay strings, e.g. in icomplete.el. (Bug#11035)
2434 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2436 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2438 2012-03-12 Chong Yidong <cyd@gnu.org>
2440 * eval.c (inhibit_lisp_code): Rename from
2441 inhibit_window_configuration_change_hook; move from window.c.
2443 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2444 * window.c (run_window_configuration_change_hook)
2445 (syms_of_window): Callers changed.
2447 2012-03-11 Chong Yidong <cyd@gnu.org>
2449 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2451 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2453 2012-03-10 Chong Yidong <cyd@gnu.org>
2455 * frame.c (other_visible_frames): Don't assume the selected frame
2456 is visible (Bug#10955).
2458 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2460 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2462 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2464 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2465 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2468 2012-03-03 Glenn Morris <rgm@gnu.org>
2470 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2472 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2474 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2475 position past the first glyph_row that ends at ZV. (Bug#10902)
2476 (redisplay_window, next_element_from_string): Fix typos in
2478 (redisplay_window): Pass to move_it_vertically the margin in
2479 pixels, not in screen lines.
2481 2012-03-02 Glenn Morris <rgm@gnu.org>
2483 * buffer.c (buffer-list-update-hook): Doc fix.
2485 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2487 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2488 push_it before setting up the iterator for the first overlay
2489 string, even if we have an empty string loaded.
2490 (next_overlay_string): If there's an empty string on the iterator
2491 stack, pop the stack. (Bug#10903)
2493 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2495 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2496 Suggested by Stefan Monnier in
2497 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2498 * alloc.c (widen_to_Lisp_Object): New static function.
2499 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2500 and widening them to Lisp_Objects. This would work even if
2501 USE_LSB_TAG is defined and wide integers are used, which might
2502 happen in a future version of Emacs.
2504 2012-02-25 Chong Yidong <cyd@gnu.org>
2506 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2509 * xselect.c (Fx_selection_exists_p): Doc fix.
2510 (x_clipboard_manager_save_all): Print an informative message
2511 before saving to clipboard manager.
2513 2012-02-24 Chong Yidong <cyd@gnu.org>
2515 * keyboard.c (process_special_events): Handle all X selection
2516 requests in kbd_buffer, not just the next one (Bug#8869).
2518 2012-02-23 Chong Yidong <cyd@gnu.org>
2520 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2521 call when setting menu-bar-lines and tool-bar-lines parameters.
2522 (unwind_create_frame_1): New helper function.
2524 * window.c (inhibit_window_configuration_change_hook): New var.
2525 (run_window_configuration_change_hook): Obey it.
2526 (syms_of_window): Initialize it.
2528 2012-02-22 Chong Yidong <cyd@gnu.org>
2530 * xterm.c (x_draw_image_relief): Add missing type check for
2531 Vtool_bar_button_margin (Bug#10743).
2533 2012-02-21 Chong Yidong <cyd@gnu.org>
2535 * fileio.c (Vfile_name_handler_alist): Doc fix.
2537 * buffer.c (Fget_file_buffer): Protect against invalid file
2538 handler return value.
2540 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2542 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2543 when computing $valmask.
2545 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2546 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2547 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2548 It's useless in that case, and it can cause problems on hosts
2549 that allocate halves of EMACS_INT values separately.
2550 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2551 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2552 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2553 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2554 it avoids undefined behavior on hosts where shifting right by more
2555 than the word width has undefined behavior.
2557 2012-02-19 Chong Yidong <cyd@gnu.org>
2559 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2560 (Funhandled_file_name_directory, Ffile_name_as_directory)
2561 (Fdirectory_file_name, Fexpand_file_name)
2562 (Fsubstitute_in_file_name): Protect against invalid file handler
2563 return values (Bug#10845).
2565 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2567 * .gdbinit (pitx): Fix incorrect references to fields of the
2570 2012-02-17 Chong Yidong <cyd@gnu.org>
2572 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2574 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2576 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2577 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2579 2012-02-15 Chong Yidong <cyd@gnu.org>
2581 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2582 marked as special. Also, starting docstrings with * is obsolete.
2584 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2586 * gnutls.c (emacs_gnutls_write): Fix last change.
2588 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2590 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2593 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2595 * keymap.c (Fsingle_key_description): Handle char ranges.
2597 2012-02-12 Chong Yidong <cyd@gnu.org>
2599 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2600 as that creates a dangerous corner case.
2602 * window.c (Fdelete_window_internal): Invalidate the mouse
2603 highlight (Bug#9904).
2605 2012-02-12 Glenn Morris <rgm@gnu.org>
2607 * xselect.c (Fx_own_selection_internal)
2608 (Fx_get_selection_internal, Fx_disown_selection_internal)
2609 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2610 * nsselect.m (Fx_own_selection_internal)
2611 (Fx_disown_selection_internal, Fx_selection_exists_p)
2612 (Fx_selection_owner_p, Fx_get_selection_internal):
2613 Sync docs and argument specs with the xselect.c versions.
2615 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2617 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2619 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2621 * w32select.c (Fx_selection_exists_p): Sync doc string and
2622 argument list with xselect.c. (Bug#10783)
2624 * w16select.c (Fx_selection_exists_p): Sync doc string and
2625 argument list with xselect.c. (Bug#10783)
2627 2012-02-10 Glenn Morris <rgm@gnu.org>
2629 * fns.c (Fsecure_hash): Doc fix.
2631 2012-02-09 Kenichi Handa <handa@m17n.org>
2633 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2635 2012-02-07 Chong Yidong <cyd@gnu.org>
2637 * buffer.c (Fbuffer_local_variables)
2638 (buffer_lisp_local_variables): Handle unbound vars correctly;
2639 don't let Qunbound leak into Lisp.
2641 2012-02-07 Glenn Morris <rgm@gnu.org>
2643 * image.c (Fimagemagick_types): Doc fix.
2645 * image.c (imagemagick-render-type): Change it from a lisp object
2646 to an integer. Move the doc here from the lisp manual.
2647 Treat all values not equal to 0 the same.
2649 2012-02-06 Chong Yidong <cyd@gnu.org>
2651 * doc.c (store_function_docstring): Avoid applying docstring of
2652 alias to base function (Bug#2603).
2654 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2656 * .gdbinit (pp1, pv1): Remove redundant defines.
2659 2012-02-04 Chong Yidong <cyd@gnu.org>
2661 * nsterm.m: Declare a global (Bug#10694).
2663 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2665 * w32.c (get_emacs_configuration_options):
2666 Include --enable-checking, if specified, in the return value.
2668 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2670 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2671 after rounding frame sizes. (Bug#9723)
2673 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2675 * keyboard.c (adjust_point_for_property): Don't position point
2676 before BEGV. (Bug#10696)
2678 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2680 Handle overflow when computing char display width (Bug#9496).
2681 * character.c (char_width): Return EMACS_INT, not int.
2682 (char_width, c_string_width): Check for overflow when
2683 computing the width; this is possible now that individual
2684 characters can have unbounded width. Problem introduced
2685 by merge from Emacs 23 on 2012-01-19.
2687 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2689 * dbusbind.c (Fdbus_register_method): Mention the return value
2690 :ignore in the docstring.
2692 2012-02-02 Glenn Morris <rgm@gnu.org>
2694 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2696 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2697 Unconditionally set to t. (Bug#10673)
2698 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2699 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2700 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2702 2012-02-02 Kenichi Handa <handa@m17n.org>
2704 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2705 0, do not call append_composite_glyph.
2707 2012-02-02 Kenichi Handa <handa@m17n.org>
2709 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2711 (x_produce_glyphs): If the component of a composition is a null
2712 string, set it->pixel_width to 1 to avoid zero-width glyph.
2714 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2716 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2717 first 2 arguments are identical. This makes inserting large
2718 output from a subprocess an order of magnitude faster on
2719 MS-Windows, where all sbrk'ed memory is always contiguous.
2721 2012-01-31 Glenn Morris <rgm@gnu.org>
2723 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2724 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2725 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2727 2012-01-29 Glenn Morris <rgm@gnu.org>
2729 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2731 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2733 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2735 2012-01-28 Chong Yidong <cyd@gnu.org>
2737 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2739 2012-01-26 Chong Yidong <cyd@gnu.org>
2741 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2743 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2744 repeat counts (Bug#10507).
2746 2012-01-26 Glenn Morris <rgm@gnu.org>
2748 * lread.c (syms_of_lread): Doc fix.
2750 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2752 * coding.c (encode_designation_at_bol): Change return value to
2755 2012-01-25 Chong Yidong <cyd@gnu.org>
2757 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2759 2012-01-21 Chong Yidong <cyd@gnu.org>
2761 * floatfns.c (Fcopysign): Make the second argument non-optional,
2762 since nil is not allowed anyway.
2764 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2766 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2767 (send_process): Likewise.
2769 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2771 * window.c (save_window_save, Fcurrent_window_configuration)
2772 (Vwindow_persistent_parameters): Do not use Qstate.
2773 Rewrite doc-strings.
2775 2012-01-19 Kenichi Handa <handa@m17n.org>
2777 * character.c (char_width): New function.
2778 (Fchar_width, c_string_width, lisp_string_width):
2779 Use char_width (Bug#9496).
2781 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2783 * window.c (Vwindow_persistent_parameters): New variable.
2784 (Fset_window_configuration, save_window_save): Handle persistent
2787 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2789 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2790 thrashing the stack of the thread. (Bug#9087)
2792 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2794 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2796 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2798 * xdisp.c (rows_from_pos_range): Handle the case where the
2799 highlight ends on a newline. (Bug#10464)
2800 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2801 he end column for display of highlight that ends on a newline
2804 2012-01-11 Glenn Morris <rgm@gnu.org>
2806 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2807 from load-path also when installation-directory is nil. (Bug#10208)
2809 2012-01-10 Glenn Morris <rgm@gnu.org>
2811 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2813 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2814 Update template values to be closer to their typical values these days.
2816 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2818 * xdisp.c (rows_from_pos_range): Accept additional argument
2819 DISP_STRING, and accept any glyph in a row whose object is that
2820 string as eligible for mouse highlight. Fixes mouse highlight of
2821 display strings from overlays. (Bug#10464)
2823 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2825 emacs: fix an auto-save permissions race condition (Bug#10400)
2826 * fileio.c (auto_saving_dir_umask): New static var.
2827 (Fmake_directory_internal): Use it.
2828 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2829 creating the directory. The old code temporarily assigns
2830 too-generous permissions to the directory.
2831 (do_auto_save_eh): Clear it.
2832 (Fdo_auto_save): Catch all errors, not just file errors, so
2833 that the var is always cleared.
2835 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2837 * search.c (scan_buffer): Pass character positions to
2838 know_region_cache, not byte positions. (Bug#6540)
2840 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2842 * w32.c (sys_rename): Report EXDEV when rename of a directory
2843 fails because the target is on another logical disk. (Bug#10284)
2845 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2847 * xterm.c (x_embed_request_focus): New function.
2849 * xterm.h: Add prototype.
2851 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2853 2012-01-05 Glenn Morris <rgm@gnu.org>
2855 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2857 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2859 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2860 Load gnutls_transport_set_lowat only if GnuTLS version is below
2862 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2863 GnuTLS versions below 2.11.1.
2865 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2867 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2868 to the doc string advising against its use for altering the way
2869 windows are scrolled.
2871 2011-12-28 Kenichi Handa <handa@m17n.org>
2873 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2874 coding-system ASCII compatible only when it does not produce BOM
2875 on encoding (Bug#10383).
2877 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2879 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2881 (create_and_show_popup_menu): Always use menu_position_func for
2884 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2886 * callint.c (Fcall_interactively): Don't truncate prompt string.
2888 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2890 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2891 property that ends at ZV, so that the bidi iteration could be
2892 resumed from there (after widening). (Bug#10360)
2894 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2896 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2898 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2900 * nsterm.m (x_free_frame_resources):
2901 Release f->output_data.ns->miniimage.
2902 (ns_index_color): Fix indentation. Do not retain
2903 color_table->colors[i].
2905 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2908 * nsfns.m (x_set_background_color): Assign return value from
2909 ns_index_color to face-background instead of NSColor*.
2910 (ns_implicitly_set_icon_type): Fix indentation.
2911 Change assignment in for loop to comparison.
2913 * emacs.c (ns_pool): New variable.
2914 (main): Assign ns_pool.
2915 (Fkill_emacs): Call ns_release_autorelease_pool.
2917 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2918 autorelease fdesc, release fdAttrs and tdict.
2919 (ns_get_covering_families): Release charset.
2920 (ns_findfonts): Release NSFontDescriptor created with new.
2921 (ns_uni_to_glyphs): Fix indentation.
2922 (setString): Release attrStr before assigning new value.
2924 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2926 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2928 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2929 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2931 2011-12-18 David Reitter <reitter@cmu.edu>
2933 * nsterm.m (ns_term_init): Subscribe for notifications
2934 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2935 to method trackingNotification in EmacsMenu.
2937 * nsmenu.m (trackingMenu): New variable.
2938 (trackingNotification): New method (from Aquamacs).
2939 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2940 from Aquamacs (Bug#7030).
2942 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2944 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2945 (symbol_to_nsstring): Fix indentation.
2946 (ns_symbol_to_pb): New function.
2947 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2948 (Fns_rotate_cut_buffers_internal): Remove.
2949 (Fns_store_selection_internal): Rename from
2950 Fns_store_cut_buffer_internal.
2951 (ns_get_foreign_selection, Fx_own_selection_internal)
2952 (Fx_disown_selection_internal, Fx_selection_exists_p)
2953 (Fns_get_selection_internal, Fns_store_selection_internal):
2954 Use ns_symbol_to_pb and check if return value is nil.
2955 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2956 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2957 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2958 renamed to Sns_store_selection_internal.
2959 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2960 and remove this function.
2961 (ns_handle_selection_clear): Remove, never used.
2962 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2965 2011-12-17 Ken Brown <kbrown@cornell.edu>
2967 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2968 GID is unknown (Bug#10257).
2970 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2972 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2973 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2974 which caused a build failure on GNU/Linux IA-64. This problem was
2975 introduced by my 2011-10-07 patch.
2977 2011-12-15 Juri Linkov <juri@jurta.org>
2979 * image.c (imagemagick_error): New function. (Bug#10112)
2980 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2981 Use `imagemagick_error' where ImageMagick functions return
2983 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2986 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2988 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2989 fill background (Bug#8992).
2991 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2993 * window.c (Vwindow_combination_resize)
2994 (Vwindow_combination_limit): Use t instead of non-nil in
2996 (Vrecenter_redisplay): Add first sentence of doc-string on
2998 (Frecenter): Fix doc-string typo.
3000 2011-12-11 Kenichi Handa <handa@m17n.org>
3002 * coding.c (Funencodable_char_position): Pay attention to the
3003 buffer text relocation (Bug#9389).
3005 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3007 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3008 gtk_init (Bug#10100).
3010 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3012 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3013 IT->string is nil. (Bug#10263)
3015 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3017 * nsterm.h (x_free_frame_resources): Declare.
3019 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3020 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3022 * nsterm.h (ns_get_defaults_value): Declare.
3024 * nsterm.m (ns_default): Call ns_get_defaults_value.
3026 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3028 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3031 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3033 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3034 that where the value of an _OBJC_* symbol points to is in the .bss
3035 section (Bug#10240).
3037 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3039 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3040 after the loop to call ccl_driver at least once (Bug#8619).
3042 2011-12-08 Kenichi Handa <handa@m17n.org>
3044 * ftfont.c (get_adstyle_property): Fix previous change
3047 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3049 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3050 dirs from the default value of EMACSLOADPATH (bug#10208).
3052 2011-12-07 Glenn Morris <rgm@gnu.org>
3054 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3055 installation and source directories as well. (Bug#10208)
3057 2011-12-06 Chong Yidong <cyd@gnu.org>
3059 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3061 2011-12-06 Glenn Morris <rgm@gnu.org>
3063 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3064 as an error, not just -1. (Bug#10217)
3066 2011-12-05 Chong Yidong <cyd@gnu.org>
3068 * keyboard.c (process_special_events): New function.
3069 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3071 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3073 * coding.c (encode_designation_at_bol): Don't use uninitialized
3074 local variable (Bug#9318).
3076 2011-12-05 Kenichi Handa <handa@m17n.org>
3078 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3079 return Qnil (Bug#8046, Bug#10193).
3081 2011-12-05 Kenichi Handa <handa@m17n.org>
3083 * coding.c (encode_designation_at_bol): New args charbuf_end and
3084 dst. Return the number of produced bytes. Callers changed.
3085 (coding_set_source): Return how many bytes coding->source was
3087 (coding_set_destination): Return how many bytes
3088 coding->destination was relocated.
3089 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3090 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3092 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3094 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3095 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3098 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3100 The following changes are to fix Bug#9318.
3102 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3103 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3104 (encode_coding_iso_2022, encode_coding_sjis)
3105 (encode_coding_big5, encode_coding_charset): Use the above macros.
3107 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3109 * lisp.h (process_quit_flag): Fix external declaration.
3111 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3113 Don't macro-inline non-performance-critical code.
3114 * eval.c (process_quit_flag): New function.
3115 * lisp.h (QUIT): Use it.
3117 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3119 * nsfns.m (get_geometry_from_preferences): New function.
3120 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3122 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3124 * emacs.c (Qkill_emacs): Define.
3125 (syms_of_emacs): Initialize it.
3126 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3127 Qquit_flag to `kill-emacs' instead.
3128 (quit_throw_to_read_char): Add parameter `from_signal'.
3129 All callers changed. Call Fkill_emacs if requested and safe.
3130 * lisp.h (QUIT): Call Fkill_emacs if requested.
3132 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3134 * widget.c (update_wm_hints): Return if wmshell is null.
3135 (widget_update_wm_size_hints): New function.
3137 * widget.h (widget_update_wm_size_hints): Declare.
3139 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3140 widget_update_wm_size_hints (Bug#10104).
3142 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3144 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3145 before a newline, prepare the bidi iterator for consuming the
3146 newline, and keep the current paragraph direction. (Bug#10183)
3147 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3149 2011-12-02 Juri Linkov <juri@jurta.org>
3151 * search.c (Fword_search_regexp): New Lisp function created from
3152 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3153 (Fword_search_backward, Fword_search_forward)
3154 (Fword_search_backward_lax, Fword_search_forward_lax):
3155 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3156 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3158 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3160 * fileio.c (Finsert_file_contents): Move after-change-function call
3161 to before the "handled:" label, since all "goto handled" appear in
3162 cases where the *-change-functions have already been properly called
3165 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3167 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3168 waiting for input. (Bug#10169)
3170 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3172 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3173 verifies glyph row's hash code--we have just reallocated the
3174 glyphs, so their contents can be complete garbage. (Bug#10164)
3176 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3178 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3180 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3182 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3183 attributes are tested _before_ calling verify_row_hash, to protect
3184 against GCC re-ordering of the tests. (Bug#10164)
3186 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3188 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3190 * xterm.c (handle_one_xevent): Only set async_visible and friends
3191 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3192 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3193 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3195 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3197 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3198 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3199 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3200 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3201 All uses changed to use GCPRO1 etc.
3202 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3203 Revert to old implementation (i.e., before 2011-03-11).
3205 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3207 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3208 of scroll runs so as to avoid assigning disabled bogus rows and
3209 unnecessary graphics copy operations.
3211 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3213 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3214 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3215 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3216 (malloc, free, realloc, calloc): Redirect to e_* only when
3219 * lisp.h (GCTYPEBITS): Move before first use.
3220 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3221 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3222 this macro definition.
3224 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3227 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3229 * gtkutil.c (xg_create_frame_widgets):
3230 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3231 present with Gtk+ 2.0.
3233 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3235 * fileio.c (Finsert_file_contents): Undo previous change; see
3236 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3238 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3240 Rename locals to avoid shadowing.
3241 * fileio.c (Finsert_file_contents):
3242 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3243 * process.c (wait_reading_process_output):
3244 Rename inner 'proc' to 'p' to avoid shadowing.
3245 Indent for consistency with usual Emacs style.
3247 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3249 * xdisp.c (redisplay_window): If cursor row is not fully visible
3250 after recentering, and scroll-conservatively is set to a large
3251 number, scroll window by a few more lines to make the cursor fully
3252 visible and out of scroll-margin. (Bug#10105)
3253 (start_display): Don't move to the next line if the display should
3254 start at a newline that is part of a display vector or an overlay
3257 2011-11-24 Juri Linkov <juri@jurta.org>
3259 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3260 after the `MagickPingImage' call. (Bug#10112)
3262 2011-11-23 Chong Yidong <cyd@gnu.org>
3264 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3266 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3268 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3269 making another buffer current. (Bug#10114)
3271 2011-11-23 Glenn Morris <rgm@gnu.org>
3273 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3275 2011-11-23 Chong Yidong <cyd@gnu.org>
3277 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3278 using it (Bug#5984).
3280 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3282 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3283 and header-lines, as they don't have one computed for them.
3286 * .gdbinit (prow): Make displayed values more self-explaining.
3287 Add row's hash code.
3289 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3291 * process.c (wait_reading_process_output): Fix asynchrounous
3292 GnuTLS socket handling on some versions of the GnuTLS library.
3293 (wait_reading_process_output): Add comment and URL.
3295 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3297 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3299 2011-11-21 Chong Yidong <cyd@gnu.org>
3301 * window.c (Fnext_window, Fprevious_window): Doc fix.
3303 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3305 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3307 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3309 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3311 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3313 * window.c (Fset_window_combination_limit): Rename argument
3315 (Vwindow_combination_limit): Remove "status" from doc-string.
3317 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3319 * m/ibms390.h: Remove.
3320 * m/ibms390x.h: Don't include "ibms390.h".
3322 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3324 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3325 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3327 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3329 * casetab.c (Fset_case_table):
3330 * charset.c (Fcharset_after): Fix typos.
3332 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3334 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3335 Otherwise, valgrind does not work on some platforms.
3336 Problem reported by Andreas Schwab in
3337 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3338 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3339 is set, removing the need for VIRT_ADDRESS_VARIES.
3340 (PURE_P): Use a more-efficient implementation that needs just one
3341 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3342 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3343 to 4 (xorl, subq, cmpq, setbe).
3344 * alloc.c (pure): Always extern now, since that's the
3345 VIRT_ADDR_VARIES behavior.
3346 (PURE_POINTER_P): Use a single comparison, not two, for
3347 consistency with the new puresize.h.
3348 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3349 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3350 Remove VIRT_ADDR_VARIES no longer needed.
3352 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3354 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3355 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3356 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3357 behave as if the cursor position were at the window margin.
3359 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3360 and the cursor position is out of bounds, behave as if the cursor
3361 position were at the window margin. (Bug#10075)
3363 2011-11-18 Chong Yidong <cyd@gnu.org>
3365 * window.c (Fwindow_combination_limit): Make first argument
3366 non-optional, since it is meaningless for live windows like the
3369 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3371 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3373 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3375 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3376 (graft_intervals_into_buffer): Simplify.
3378 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3380 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3381 hash values of the two rows.
3382 (copy_row_except_pointers): Preserve the used[] arrays and the
3383 hash values of the two rows. (Bug#10035)
3384 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3386 * xdisp.c (row_hash): New function, body extracted from
3387 compute_line_metrics.
3388 (compute_line_metrics): Call row_hash, instead of computing the
3391 * dispnew.c (verify_row_hash): Call row_hash for computing the
3392 hash code of a row, instead of duplicating code from xdisp.c.
3394 * dispextern.h (row_hash): Add prototype.
3396 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3398 * frame.c (delete_frame): Don't delete the terminal when the last
3399 X frame is closed if emacs is built with GTK toolkit.
3401 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3403 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3405 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3407 * window.c (Vwindow_splits): Rename to
3408 Vwindow_combination_resize. Suggested by Juri Linkov.
3409 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3412 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3414 * nsfns.m (Fns_font_name):
3415 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3417 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3419 * window.h (window): Rename slot "nest" to "combination_limit".
3420 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3421 (Fset_window_nest): Rename to Fset_window_combination_limit.
3422 (Vwindow_nest): Rename to Vwindow_combination_limit.
3423 (recombine_windows, make_parent_window, make_window)
3424 (Fsplit_window_internal, saved_window)
3425 (Fset_window_configuration, save_window_save): Rename all
3426 occurrences of window_nest to window_combination_limit.
3428 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3430 * image.c (imagemagick_load_image): Fix typo.
3432 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3434 * xdisp.c (display_line): Move the call to
3435 highlight_trailing_whitespace before the call to
3436 compute_line_metrics, since the latter needs to see the final
3437 faces of all the glyphs to compute ROW's hash value.
3438 Fixes assertion violations in row_equal_p. (Bug#10035)
3440 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3442 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3443 just return (bug#10044).
3445 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3447 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3448 with user-defined heap size. Bump the default size of the temacs
3449 heap to 27MB, to avoid memory warning when running temacs.
3450 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3452 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3453 current_matrix and desired_matrix. (Bug#9990)
3454 (verify_row_hash) [XASSERTS]: New function.
3455 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3456 that the hash value of glyph rows is correct.
3458 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3460 * window.h (window): Remove splits slot.
3461 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3462 (Fdelete_other_windows_internal, make_parent_window)
3463 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3464 (Fset_window_configuration, save_window_save): Don't deal with
3465 split status of windows.
3466 (saved_window): Remove splits slot.
3467 (Vwindow_splits): Rewrite doc-string.
3469 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3471 * xfns.c (unwind_create_frame):
3472 * nsfns.m (unwind_create_frame):
3473 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3474 Vframe_list (Bug#9999).
3476 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3478 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3480 2011-11-11 Kenichi Handa <handa@m17n.org>
3482 * callproc.c (Fcall_process): Set the member dst_multibyte of
3485 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3487 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3488 avoid a crash (bug#9496).
3490 2011-11-09 Chong Yidong <cyd@gnu.org>
3492 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3493 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3495 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3497 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3499 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3501 Avoid some portability problems by eschewing 'extern inline' functions.
3502 The trivial performance wins aren't worth the portability hassles; see
3503 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3505 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3506 (window_box_width, window_box_left, window_box_left_offset)
3507 (window_box_right, window_box_right_offset): Undo previous change,
3508 by removing the "extern"s.
3509 * intervals.c (adjust_intervals_for_insertion)
3510 (adjust_intervals_for_deletion): Undo previous change,
3511 making these static again.
3512 (offset_intervals, temp_set_point_both, temp_set_point)
3513 (copy_intervals_to_string): No longer inline.
3514 * xdisp.c (window_text_bottom_y, window_box_width)
3515 (window_box_height, window_box_left_offset)
3516 (window_box_right_offset, window_box_left, window_box_right)
3517 (window_box): No longer inline.
3519 2011-11-08 Chong Yidong <cyd@gnu.org>
3521 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3522 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3523 Signal an error if not a live window.
3524 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3525 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3527 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3529 * lisp.h (syms_of_abbrev): Remove declaration.
3530 Reported by CHENG Gao <chenggao@royau.me>.
3532 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3534 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3535 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3536 of temacs in GUI mode.
3538 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3540 * window.h: Declare delete_all_child_windows instead of
3541 delete_all_subwindows.
3542 * window.c (Fwindow_nest, Fset_window_nest)
3543 (Fset_window_new_total, Fset_window_new_normal)
3544 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3545 (delete_all_subwindows): Rename to delete_all_child_windows.
3546 (Fdelete_other_windows_internal, Fset_window_configuration):
3547 Call delete_all_child_windows instead of delete_all_subwindows.
3548 * frame.c (delete_frame): Call delete_all_child_windows instead
3549 of delete_all_subwindows.
3551 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3553 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3554 This is also needed for porting to any host where GC_MARK_STACK is
3555 not GC_MAKE_GCPROS_NOOPS.
3556 (which_symbols): Use it.
3558 2011-11-07 Kenichi Handa <handa@m17n.org>
3560 * coding.c (coding_set_destination): Check coding->src_pos only
3561 when coding->src_object is a buffer (bug#9910).
3563 * process.c (send_process): Set the member src_multibyte of coding
3564 to 0 (bug#9911) when sending a unibyte text.
3566 * callproc.c (Fcall_process): Set the member src_multibyte of
3567 process_coding to 0 (bug#9912).
3569 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3571 * xmenu.c (cleanup_widget_value_tree): New function.
3572 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3573 calling free_menubar_widget_value_tree directly (Bug#9830).
3575 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3577 Fix some portability problems with 'inline'.
3578 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3579 (window_box_width, window_box_left, window_box_left_offset)
3580 (window_box_right, window_box_right_offset): Declare extern.
3581 Otherwise, these inline functions do not conform to C99 and
3582 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3583 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3584 * intervals.c (adjust_intervals_for_insertion)
3585 (adjust_intervals_for_deletion): Now extern, because otherwise the
3586 extern inline functions 'offset_intervals' couldn't refer to it.
3587 (static_offset_intervals): Remove.
3588 (offset_intervals): Rewrite using the old contents of
3589 static_offset_intervals. The old version didn't conform to C99
3590 because an extern inline function contained a reference to an
3591 identifier with static linkage.
3593 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3595 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3598 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3600 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3601 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3602 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3603 return Qleft_to_right.
3605 2011-11-06 Chong Yidong <cyd@gnu.org>
3607 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3608 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3609 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3610 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3611 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3612 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3613 (Fwindow_vscroll): Doc fix.
3614 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3615 argument, since it makes no sense to pass a live window and for
3616 consistency with window-child.
3618 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3620 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3623 2011-11-05 Jason Rumney <jasonr@gnu.org>
3625 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3626 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3628 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3629 bitwise arithmetic preventing use of unicode-sip and non-truetype
3632 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3634 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3637 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3638 initialization code to keep similarity to xfns.c after changes
3641 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3643 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3644 (unwind_create_frame): New function (Bug#9943).
3645 (Fx_create_frame): Restructure code to be more similar to the one in
3646 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3647 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3648 Move terminal->reference_count++ just before making the frame official
3651 * nsterm.m (x_free_frame_resources): New function.
3652 (x_destroy_window): Move code to x_free_frame_resources.
3654 * xfns.c (unwind_create_frame): Fix comment.
3655 (Fx_create_frame, x_create_tip_frame):
3656 Move terminal->reference_count++ just before making the frame
3657 official. Move initialization of image_cache_refcount and
3658 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3660 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3662 Support MSVC build with newer versions of Visual Studio.
3663 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3664 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3667 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3668 which are not supported by MSVC.
3669 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3670 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3672 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3674 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3676 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3678 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3680 Support MSVC build with newer versions of Visual Studio.
3681 * w32.c: Don't include w32api.h for MSVC.
3682 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3684 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3685 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3686 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3687 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3689 (alloca) [_MSC_VER]: Define to _alloca.
3691 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3693 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3695 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3697 * xdisp.c (note_mouse_highlight): If either of
3698 previous/next-single-property-change returns nil, treat that as
3699 the beginning or the end of the buffer. (Bug#9955)
3701 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3703 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3704 label is not null (Bug#9951).
3705 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3708 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3710 * window.c (Fwindow_body_size): Mention in the doc string that the
3711 return value is in frame's canonical units. (Bug#9949)
3713 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3715 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3717 * w32fns.c (unwind_create_frame): If needed, free the glyph
3718 matrices of the partially constructed frame. (Bug#9943)
3719 * xfns.c (unwind_create_frame): Likewise.
3721 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3723 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3724 Don't stop backward scan on the continuation glyph, even though
3725 its CHARPOS is positive.
3726 (mouse_face_from_buffer_pos, note_mouse_highlight):
3727 Rename cover_string to disp_string.
3729 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3731 * window.c (temp_output_buffer_show): Don't use
3732 Vtemp_buffer_show_specifiers.
3733 (Vtemp_buffer_show_specifiers): Remove unused variable.
3735 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3737 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3738 past the beginning of the current glyph matrix.
3740 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3742 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3743 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3744 HAVE_GTK3 (Bug#9869).
3746 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3747 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3749 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3751 * xterm.c: Declare x_handle_net_wm_state to return int.
3752 (handle_one_xevent): Check if we are iconified but don't have
3753 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3754 (get_current_wm_state): Return non-zero if not hidden,
3755 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3756 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3757 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3758 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3760 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3762 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3763 so that this new function doesn't get optimized away by a
3764 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3766 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3768 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3770 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3772 Fix the `xbytecode' command.
3773 * .gdbinit (xprintbytestr): New command.
3774 (xwhichsymbols): Rename from `which'; all callers changed.
3775 (xbytecode): Print the byte-code string as well.
3777 2011-10-29 Kim Storm <storm@cua.dk>
3779 * alloc.c (which_symbols): New function.
3781 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3783 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3786 2011-10-29 Glenn Morris <rgm@gnu.org>
3788 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3789 Not clear what it was for, and it causes various bugs. (Bug#9839)
3791 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3793 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3794 possible random value that matches one of those tested as
3795 condition to clear the mouse face.
3797 2011-10-28 Chong Yidong <cyd@gnu.org>
3799 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3801 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3803 * window.c (make_window): Initialize phys_cursor_on_p.
3805 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3807 * lisp.h (struct Lisp_Symbol): Update comments.
3809 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3811 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3813 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3815 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3816 <oslsachem@gmail.com> for helping to debug this.
3818 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3819 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3820 (g_b_init_get_glyph_outline_w): New static variables.
3821 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3822 (GetGlyphOutlineW_Proc): New typedefs.
3823 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3824 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3826 (w32font_open_internal, compute_metrics):
3827 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3828 instead of calling the "wide" APIs directly.
3830 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3832 * w32.h (syms_of_w32font): Add prototype.
3834 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3836 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3837 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3838 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3839 (Fmove_to_window_line): Doc fix.
3841 2011-10-27 Chong Yidong <cyd@gnu.org>
3843 * process.c (make_process): Set gnutls_state to NULL.
3845 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3846 non-NULL, regardless of GNUTLS_INITSTAGE.
3847 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3848 an error. Set process slots as soon as we allocate them.
3850 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3852 2011-10-27 Chong Yidong <cyd@gnu.org>
3854 * gnutls.c (emacs_gnutls_deinit): New function.
3855 Deallocate credentials structures as well as calling gnutls_deinit.
3856 (Fgnutls_deinit, Fgnutls_boot): Use it.
3858 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3859 (deactivate_process): Call emacs_gnutls_deinit.
3861 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3863 * image.c (x_create_x_image_and_pixmap):
3864 * w32.c (sys_rename, w32_delayed_load):
3865 * w32font.c (fill_in_logfont):
3866 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3868 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3870 * w32fns.c (w32_default_color_map): New function,
3871 extracted from Fw32_default_color_map.
3872 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3874 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3876 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3878 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3880 * keyboard.c (test_undefined): New function (bug#9751).
3881 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3883 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3885 * sysdep.c (init_sys_modes): Fix the check for the controlling
3886 terminal (Bug#6649).
3888 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3890 * dispextern.h (struct bidi_it): New member next_en_type.
3892 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3893 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3894 current character, check also for next_en_type being WEAK_EN.
3895 (bidi_resolve_weak): Don't enter the expensive loop if the current
3896 position is before next_en_pos. Record the bidi type of the first
3897 non-ET, non-BN character we find, in addition to its position.
3898 (bidi_level_of_next_char): Invalidate next_en_type when
3899 next_en_pos is over-stepped.
3901 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3903 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3904 * editfns.c: Rewrite current-time-zone so that it invokes
3905 the equivalent of (format-time-string "%Z") to get the time zone name.
3906 This fixes a bug when the time zone name contains characters that
3907 need converting from the system time locale to Emacs internal format.
3908 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3909 that patch fixed format-time-string to do the conversion, but
3910 I forgot to fix current-time-zone.
3911 (format_time_string): New function, containing most of
3912 what Fformat_time_string used to contain.
3913 (Fformat_time_string): Rewrite in terms of format_time_string.
3914 This doesn't change this function's behavior.
3915 (current-time-zone): Rewrite to use format_time_string.
3916 This fixes the bug reported by Michael Schierl in
3917 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3918 Jason Rumney's 2007-06-07 change worked around this bug, but
3920 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3922 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3924 * xdisp.c (start_display): If the character at POS is displayed
3925 via a display vector, reset IT->current.dpvec_index to zero.
3926 (try_window_reusing_current_matrix): If a line ends in a display
3927 vector or the next line starts in a display vector, continue
3928 redrawing the window even though the character position of
3929 start_row was reached.
3932 2011-10-18 Chong Yidong <cyd@gnu.org>
3934 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3935 with nobreak-char-display too.
3937 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3939 Fix part 3 of bug#9771.
3940 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3941 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3942 non-neutral characters if the current character is a paragraph
3943 separator (a.k.a. Newline). This avoids running the same
3944 expensive loop twice, once when we consume the preceding newline
3945 and the other time when the line actually needs to be displayed.
3946 Avoid the loop when we see neutrals on the base embedding level
3947 following a character whose directionality is the same as the
3948 paragraph's. This avoids running the expensive loop when a line
3949 ends in a long sequence of neutrals, like control characters.
3950 Add assertion against STRONG_AL type. Slightly rearrange code
3951 that determines the type of a neutral given the first non-neutral
3953 (bidi_level_of_next_char): Set next_en_pos to zero when
3954 invalidating its info.
3956 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3958 * xdisp.c (push_display_prop): Determine whether to record string
3959 or buffer position by IT->string, not by IT->method. Allow
3960 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3961 (move_it_vertically_backward): Don't look for character position
3962 immediately after the newline when in a continuation line.
3965 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3967 * window.c (coordinates_in_window): Rewrite and delabelize
3968 vertical border check. (Bug#5357) (Bug#9618)
3970 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3972 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3973 errors in XSetWindowBorder (bug#9310).
3975 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3977 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3978 avoid crash when xmalloc overrun checking is enabled.
3980 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3982 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3983 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3984 cursor motion with <left> and <right> arrow keys.
3986 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3987 some callers set that themselves.
3989 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3991 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3992 display string and the previous row comes from the same string and
3993 is empty. (Bug#9739) (Bug#9738)
3995 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3997 * doc.c (get_doc_string): Encode file name (bug#9735).
3999 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4001 * bidi.c (bidi_level_of_next_char):
4002 * xdisp.c (get_visually_first_element): Remove old incorrect
4003 comments regarding the Unicode Line Separator character.
4005 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4007 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4009 * alloc.c (Fgc_status): Do not access beyond zombies array
4010 boundary if nzombies > MAX_ZOMBIES.
4011 * alloc.c (dump_zombies): Add missing format specifier.
4013 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4015 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4016 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4018 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4019 Some packages use them to denote characters with modifiers.
4021 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4023 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4024 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4025 matching a pp-number. Rename parameter var to var1.
4027 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4029 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4031 2011-10-08 Glenn Morris <rgm@gnu.org>
4033 * callint.c (Fcall_interactively): Give a more explicit error for the
4034 'c' case with a non-character input. (Bug#8479)
4036 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4038 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4040 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4041 lines that are hscrolled on the left.
4043 * dispnew.c (buffer_posn_from_coords): Account for a possible
4044 presence of header-line. (Bug#4426)
4046 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4048 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4049 Don't advertise functionality which we discourage or doesn't work.
4051 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4053 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4054 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4055 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4056 this makes Emacs dump core during garbage collection on rare
4057 occasions. sizeof is obviously inferior to offsetof here, so
4058 stick with offsetof.
4059 (GC_POINTER_ALIGNMENT): New macro.
4060 (mark_memory): Omit 3rd (offset) arg; caller changed.
4061 Don't assume EMACS_INT alignment is the same as pointer alignment.
4063 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4065 * keyboard.c (read_key_sequence_remapped): New var.
4066 (read_key_sequence): Compute remapping in the right buffer.
4067 (command_loop_1): Use read_key_sequence's remapping directly.
4069 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4071 * dired.c (file_name_completion): Don't expand file name.
4072 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4073 before checking file name handler.
4075 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4076 they've been requested explicitly (bug#9591).
4078 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4080 * keymap.c (Fsingle_key_description): Use make_specified_string
4081 instead of build_string to build string from push_key_description.
4084 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4086 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4087 This fixes a Y2038 bug on 64-bit hosts.
4088 * buffer.c (reset_buffer):
4089 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4090 (Fclear_buffer_auto_save_failure):
4091 Use 0, not -1, to represent an unset failure time, since time_t
4092 might not be signed.
4094 Remove dependency on glibc malloc internals.
4095 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4096 Move back here from lisp.h, but with their new implementations.
4097 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4098 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4099 * charset.c (charset_table_init): New static var.
4100 (syms_of_charset): Use it instead of xmalloc. This removes a
4101 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4102 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4103 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4104 Move back to alloc.c.
4105 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4106 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4108 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4110 * nsterm.m (windowDidResize): Call x_set_window_size only when
4111 ns_in_resize is true. Otherwise set pixelwidth/height and
4112 call change_frame_size (Bug#9628).
4114 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4116 Port --enable-checking=all to Fedora 14 x86-64.
4117 * charset.c (syms_of_charset): Also account for glibc malloc's
4118 internal overhead when calculating the initial malloc maximum.
4120 Port --enable-checking=all to Fedora 14 x86.
4121 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4123 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4124 (overrun_check_realloc, overrun_check_free):
4125 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4126 That way, xmalloc returns a properly-aligned pointer even if
4127 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4128 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4129 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4130 into account when calculating the initial malloc maximum.
4131 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4132 Move here from alloc.c, so that charset.c can use it too.
4133 Properly align; the old code wasn't right for common 32-bit hosts
4134 when configured with --enable-checking=all.
4135 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4136 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4138 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4140 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4143 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4145 * xdisp.c (compute_display_string_end): If there's no display
4146 string at CHARPOS, return -1.
4148 * bidi.c (bidi_fetch_char): When compute_display_string_end
4149 returns a negative value, treat the character as a normal
4150 character not covered by a display string. (Bug#9624)
4152 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4154 * lread.c (Fread_from_string): Fix typo in docstring.
4156 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4158 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4159 newline, reseat the iterator instead of bidi-iterating there one
4160 character at a time. (Bug#9610)
4161 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4162 TO_CHARPOS if the bidi iterator is at base embedding level.
4164 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4166 * lread.c (readevalloop): Use correct code for NBSP.
4167 (read1): Likewise. (Bug#9608)
4169 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4171 * dbusbind.c (Fdbus_register_signal): When service is not
4172 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4174 2011-09-25 Glenn Morris <rgm@gnu.org>
4176 * buffer.c (truncate-lines): Doc fix.
4178 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4180 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4181 (Fset_window_next_buffers): Doc fix.
4183 2011-09-24 Glenn Morris <rgm@gnu.org>
4185 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4187 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4189 Fix minor problems found by static checking.
4190 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4191 * indent.c (Fvertical_motion): Fix == vs = typo.
4193 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4195 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4196 Default value is now t. Doc fix.
4198 * indent.c (Fvertical_motion): Compute and apply the overshoot
4199 logic when moving up, not only when moving down. Fix the
4200 confusing name and values of the it_overshoot_expected variable;
4201 logic changes accordingly. (Bug#9254) (Bug#9549)
4203 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4204 CHARPOS is covered by a display string which includes newlines.
4205 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4206 is covered by a display string with embedded newlines.
4208 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4210 * dbusbind.c (Fdbus_register_signal): Add match rule to
4211 Vdbus_registered_objects_table. (Bug#9581)
4212 (Fdbus_register_method, Vdbus_registered_objects_table):
4215 2011-09-24 Jim Meyering <meyering@redhat.com>
4217 do not ignore write error for any output size
4218 The previous change was incomplete.
4219 While it makes emacs --batch detect the vast majority of stdout
4220 write failures, errors were still ignored whenever the output size is
4221 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4222 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4223 && echo FAIL: ignored write error
4224 FAIL: ignored write error
4225 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4226 && echo FAIL: ignored write error
4227 FAIL: ignored write error
4228 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4230 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4232 * emacs.c (Fkill_emacs): In noninteractive mode exit
4233 non-successfully if a write error occurred on stdout. (Bug#9574)
4235 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4237 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4240 * dispextern.h (struct it): Update the comment documenting what
4243 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4245 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4246 a display string, extend search for cursor position to end of row.
4247 (find_row_edges): If the row ends in a newline from a display
4248 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4249 Handle the case of a display string with multiple newlines.
4250 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4251 non-empty line. Fixes confusing cursor motion with arrow keys at
4252 the beginning of a line that starts with whitespace.
4254 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4256 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4259 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4261 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4264 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4266 * xdisp.c (display_line): Record maximum and minimum buffer
4267 positions even if no glyphs were produced (e.g., by a zero-width
4268 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4269 buffer positions that will be removed from the glyph row because
4271 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4272 column is beyond frame width: don't subtract 1 "pixel" when
4273 computing width of the stretch.
4274 (reseat_at_next_visible_line_start): Undo the change made on
4275 2011-09-17 that saved paragraph information and restored it after
4276 the call to `reseat'. (Bug#9545)
4278 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4280 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4281 and turn window cursor on if cleared (Bug#9415).
4283 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4285 * search.c (boyer_moore): Take unibyte characters from pattern
4286 literally. (Bug#9458)
4288 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4290 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4292 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4294 Fix minor problem found by static checking.
4295 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4296 initialized, to pacify gcc -Wuninitialized.
4298 * fileio.c: Report proper errno when syscall falls.
4299 (Finsert_file_contents): Save and restore errno,
4300 so that report_file_error outputs the correct diagnostic.
4301 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4303 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4305 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4307 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4309 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4310 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4312 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4314 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4315 about the current paragraph and restore it after the call to reseat.
4317 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4318 (bidi_find_paragraph_start): Search back for paragraph beginning
4319 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4320 (bidi_move_to_visually_next): Only trigger paragraph-related
4321 computations when the last character is a newline or at EOB, not
4322 just any NEUTRAL_B. (Bug#9470)
4324 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4325 truncated lines if point is covered by a display string. (Bug#9524)
4327 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4329 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4330 (cons_to_x_long): New function.
4331 (lisp_data_to_selection_data): Use it. Correct the test for
4332 short-versus-long data; it was negated. Break out of vector
4333 loop, for efficiency, when a long datum is discovered.
4335 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4337 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4339 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4341 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4342 GCC PR/17406) by declaring this function with external scope.
4344 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4346 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4347 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4349 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4351 * editfns.c (Fformat): Correctly handle text properties on "%%".
4353 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4355 * xterm.c (x_draw_composite_glyph_string_foreground):
4356 * w32term.c (x_draw_composite_glyph_string_foreground):
4357 * term.c (encode_terminal_code):
4358 * composite.c (composition_update_it, get_composition_id):
4359 * xdisp.c (get_next_display_element)
4360 (fill_composite_glyph_string): Add comments about special meaning
4361 of TAB characters in a composition.
4363 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4365 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4366 This occurs when processing a multibyte format.
4367 Problem reported by Wolfgang Jenker.
4369 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4371 * xdisp.c (try_cursor_movement): Only check for exact match if
4372 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4374 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4376 Remove unused external symbols.
4377 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4378 * xdisp.c (calc_pixel_width_or_height): Now static.
4379 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4380 * indent.c (check_display_width):
4381 * w32term.c: Fix comment to match code.
4382 * xterm.c, xterm.h (x_catching_errors): Remove.
4384 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4386 * xselect.c: Use signed conversions more consistently (Bug#9498).
4387 (selection_data_to_lisp_data): Assume incoming selection data are
4388 signed integers, not unsigned. This is to be consistent with
4389 outgoing selection data, which was modified to use signed integers
4390 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4391 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4392 expects long, not unsigned long.
4394 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4396 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4397 computation of loop end. Reported by Johan Bockgård
4400 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4402 * frame.c (Fother_visible_frames_p): Function deleted.
4404 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4406 * indent.c (compute_motion): Process display vector front to back
4407 rather than the other way around. (Bug#2496)
4409 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4411 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4413 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4415 * minibuf.c (Fread_from_minibuffer): Doc fix.
4417 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4419 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4420 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4422 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4424 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4425 value for non-existent files.
4427 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4429 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4430 set its "size" to -1. This will set the modtime_size field of
4431 the corresponding buffer to -1, which is what
4432 verify-visited-file-modtime expects for files that do not exist.
4435 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4437 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4439 * lisp.h: ... from here. push_key_description is no longer
4440 defined in keyboard.c, so its declaration should not be in
4441 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4442 logically belongs with push_key_description.
4444 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4446 * buffer.h: Include <sys/types.h> instead of <time.h>.
4447 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4448 Problem reported by Herbert J. Skuhra.
4450 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4452 * xml.c (parse_region): Make the parsing work for
4453 non-comment-starting XML files again (bug#9144).
4455 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4457 * image.c (gif_load): Fix calculation of bottom and right corner.
4460 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4462 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4463 redisplay in small windows.
4465 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4467 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4469 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4471 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4472 Operate on live windows only.
4474 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4476 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4478 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4480 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4481 only under bidi iteration.
4483 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4485 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4487 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4489 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4490 Without this fix, the command to link temacs failed due to an
4491 undefined symbol __builtin_isnan. This is because
4492 /usr/include/iso/math_c99.h #defines isnan(x) to
4493 __builtin_isnan(x), but the bundled gcc, which identifies itself
4494 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4496 * floatfns.c (isnan): #undef, and then #define to a clone of
4498 (Fisnan): Always define, since it's always available now.
4499 (syms_of_floatfns): Always define isnan at the Lisp level.
4501 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4503 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4505 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4507 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4508 The previous code assumed that file offsets (off_t values) fit in
4509 EMACS_INT variables, which is not true on typical 32-bit hosts.
4510 The code messed up by falsely reporting buffer overflow in cases
4511 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4512 when "big" contains more than 2**29 bytes, even though this
4513 inserts just one byte and does not overflow the buffer.
4514 (Finsert_file_contents): Store file offsets as off_t
4515 values, not as EMACS_INT values. Check for overflow when
4516 converting between EMACS_INT and off_t. When checking for
4517 buffer overflow or for overlap, take the offsets into account.
4518 Don't use EMACS_INT for small values where int suffices.
4519 When checking for overlap, fix a typo: ZV was used where
4520 ZV_BYTE was intended.
4521 (Fwrite_region): Don't assume off_t fits into 'long'.
4522 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4524 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4526 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4528 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4530 sprintf-related integer and memory overflow issues (Bug#9412).
4532 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4533 (esprintf, exprintf, evxprintf): New functions.
4534 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4535 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4536 (modify_event_symbol): Do not assume that the length of
4537 name_alist_or_stem is safe to alloca and fits in int.
4538 (Fexecute_extended_command): Likewise for function name and binding.
4539 (Frecursion_depth): Wrap around reliably on integer overflow.
4540 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4541 since some callers pass EMACS_INT values.
4542 (Fsingle_key_description): Don't crash if symbol name contains more
4543 than MAX_ALLOCA bytes.
4544 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4545 (get_minibuffer): Arg is now EMACS_INT, not int.
4546 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4547 (esprintf, exprintf, evxprintf): New decls.
4548 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4550 * dbusbind.c (signature_cat): New function.
4551 (xd_signature, Fdbus_register_signal):
4552 Do not overrun buffer; instead, report string overflow.
4554 * dispnew.c (add_window_display_history): Don't overrun buffer.
4555 Truncate instead; this is OK since it's just a log.
4557 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4558 even if the time zone offset is outlandishly large.
4559 Don't mishandle offset == INT_MIN.
4561 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4562 when creating daemon; the previous buffer-overflow check was incorrect.
4564 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4565 which has the guts of the old verror function.
4567 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4568 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4570 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4571 (font_unparse_xlfd): Don't blindly alloca long strings.
4572 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4573 fits in int, when using sprintf. Use single snprintf to count
4574 length of string rather than counting it via multiple sprintfs;
4575 that's simpler and more reliable.
4576 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4577 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4578 sprintf, in case result does not fit in int.
4580 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4581 (fontset_from_font): Print it.
4583 * frame.c (tty_frame_count): Now printmax_t, not int.
4584 (make_terminal_frame, set_term_frame_name): Print it.
4585 (x_report_frame_params): In X, window IDs are unsigned long,
4586 not signed long, so print them as unsigned.
4587 (validate_x_resource_name): Check for implausibly long names,
4588 and don't assume name length fits in 'int'.
4589 (x_get_resource_string): Don't blindly alloca invocation name;
4590 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4593 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4594 (xg_check_special_colors, xg_set_geometry):
4595 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4597 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4598 Use esprintf, not sprintf, in case result does not fit in int.
4600 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4601 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4602 it as a large positive number.
4603 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4604 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4606 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4607 in case result does not fit in int.
4609 * print.c (float_to_string): Detect width overflow more reliably.
4610 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4611 buffer overrun. Don't assume list length fits in 'int'. Treat
4612 print length of 0 as 0, not as infinity; to be consistent with other
4613 uses of print length in this function. Don't overflow print length
4614 index. Don't assume hash table size fits in 'long', or that
4615 vectorlike size fits in 'unsigned long'.
4617 * process.c (make_process): Use printmax_t, not int, to format
4618 process-name gensyms.
4620 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4622 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4623 to avoid potential buffer overrun.
4625 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4626 if X resource line is longer than 512 bytes.
4628 * xfns.c (x_window): Make sprintf buffer a bit bigger
4629 to avoid potential buffer overrun.
4631 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4633 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4635 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4637 Integer overflow fixes for scrolling, etc.
4638 Without these, Emacs silently mishandles large integers sometimes.
4639 For example, "C-u 4294967297 M-x recenter" was treated as if
4640 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4642 * xdisp.c (try_window_id): Check Emacs fixnum range before
4643 converting to 'int'.
4645 * window.c (window_scroll_line_based, Frecenter):
4646 Check that an Emacs fixnum is in range before assigning it to 'int'.
4647 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4648 values converted from Emacs fixnums.
4649 (Frecenter): Don't wrap around a line count if it is out of 'int'
4650 range; instead, treat it as an extreme value.
4651 (Fset_window_configuration, compare_window_configurations):
4652 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4654 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4655 that can exceed INT_MAX. Check that EMACS_INT value is in range
4656 before assigning it to the (possibly-narrower) index.
4657 (match_limit): Don't assume that a fixnum can fit in 'int'.
4659 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4662 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4663 (Fvertical_motion): Don't wrap around LINES values that don't fit
4664 in 'int'. Instead, treat them as extreme values. This is good
4665 enough for windows, which can't have more than INT_MAX lines anyway.
4667 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4669 * Require libxml/parser.h to avoid compilation warning.
4671 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4673 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4674 since this reportedly can destroy thread storage.
4676 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4678 * syntax.c (find_defun_start): Update all cache variables if
4679 exiting early (Bug#9401).
4681 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4683 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4685 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4686 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4687 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4689 * term.c (tty_append_glyph): New function.
4690 (produce_stretch_glyph): Static function and its prototype deleted.
4692 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4695 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4697 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4698 when checking :margin (Bug#9390).
4699 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4700 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4701 so that the name doesn't mislead. All uses changed.
4703 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4705 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4708 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4710 * xdisp.c (move_it_to): Don't bail out early when reaching
4711 position beyond to_charpos, if we are scanning backwards.
4712 (move_it_vertically_backward): When DY == 0, make sure we get to
4713 the first character in the line after the newline.
4715 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4717 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4718 (ccl_driver): Do not generate an out-of-range pointer.
4719 (Fccl_execute_on_string): Remove unnecessary check for
4720 integer overflow, noted by Stefan Monnier in
4721 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4722 Remove a FIXME that didn't need fixing.
4723 Simplify the newly-introduced buffer reallocation code.
4725 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4727 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4729 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4731 Integer and memory overflow issues (Bug#9196).
4733 * doc.c (get_doc_string): Rework so that
4734 get_doc_string_buffer_size is the actual buffer size, rather than
4735 being 1 less than the actual buffer size; this makes xpalloc more
4738 * image.c (x_allocate_bitmap_record, cache_image):
4739 * xselect.c (Fx_register_dnd_atom):
4740 Simplify previous changes by using xpalloc.
4742 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4743 since either will do and ptrdiff_t is convenient with xpalloc.
4745 * charset.c (charset_table_size)
4746 (struct charset_sort_data.priority): Now ptrdiff_t.
4747 (charset_compare): Don't overflow if priorities differ greatly.
4748 (Fsort_charsets): Don't assume list length fits in int.
4749 Check for size-calculation overflow when allocating sort data.
4750 (syms_of_charset): Allocate an initial charset table that is
4751 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4753 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4755 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4756 The actual value is always <= INT_MAX, and leaving it unsigned made
4757 overflow checking harder.
4759 * dispextern.h (struct glyph_matrix.rows_allocated)
4760 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4761 with xpalloc. The values are still always <= INT_MAX.
4763 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4765 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4766 (SAFE_NALLOCA): New macro.
4768 * region-cache.c (struct boundary.pos, find_cache_boundary)
4769 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4770 (set_cache_region, invalidate_region_cache)
4771 (revalidate_region_cache, know_region_cache, region_cache_forward)
4772 (region_cache_backward, pp_cache):
4773 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4774 so that ptrdiff_t * can be passed to xpalloc.
4775 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4776 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4777 (pp_cache): Don't assume cache_len fits in int.
4778 * region-cache.h: Adjust extern decls to match.
4780 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4781 EMACS_INT, since either will do, for xpalloc.
4783 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4784 (xnmalloc, xnrealloc, xpalloc): New functions.
4786 * bidi.c (bidi_shelve_header_size): New constant.
4787 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4788 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4790 * bidi.c (bidi_cache_shrink):
4791 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4793 Don't update size of array until after memory allocation succeeds,
4794 because xmalloc/xrealloc may not return.
4795 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4796 now that we have proper integer overflow checking.
4797 (record_overlay_string, overlay_strings): Catch overflows when
4798 calculating size of overlay_str_buf.
4800 * callproc.c (Fcall_process): Check for size overflow when
4801 calculating size of args2.
4802 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4803 Normally we prefer signed values, but sticking with ptrdiff_t would
4804 require adding more-complicated checks.
4806 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4807 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4808 Redo buffer-overflow calculations to avoid integer overflow.
4809 Add a FIXME comment where memory seems to be over-allocated.
4811 * character.c (Fstring): Check for size-calculation overflow.
4813 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4814 unnecessary integer overflow. Check for size overflow.
4815 (encode_coding_object): Don't update size until xmalloc succeeds.
4817 * composite.c (get_composition_id): Check for overflow in glyph
4818 length calculations.
4820 Integer and memory overflow fixes for display code.
4821 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4822 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4823 (scrolling_window): Check for overflow in size calculations.
4824 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4825 Don't assume glyph table len fits in int.
4826 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4827 (row_table_size): Now ptrdiff_t, not int.
4828 (scrolling_window): Avoid overflow in size calculations.
4829 Don't update size until allocation succeeds.
4830 * fns.c (concat): Check for overflow in size calculations.
4831 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4832 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4833 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4835 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4836 (get_doc_string): Check for size calculation overflow.
4837 Don't update size until allocation succeeds.
4838 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4839 EMACS_INT, where ptrdiff_t will do.
4840 (Fsubstitute_command_keys): Check for string overflow.
4842 * editfns.c (set_time_zone_rule): Don't assume environment length
4844 (message_length): Now ptrdiff_t, not int.
4845 (Fmessage_box): Don't update size until allocation succeeds.
4846 Don't assume message length fits in int.
4847 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4849 * emacs.c (main): Do not reallocate argv, since there is a null at
4850 the end that can be overwritten, and this way there's no need to
4851 worry about size-calculation overflow.
4852 (sort_args): Check for size-calculation overflow.
4854 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4856 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4858 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4859 (x_set_scroll_bar_width, x_figure_window_size):
4860 Check for integer overflow.
4861 (x_set_alpha): Do not assume XINT fits in int.
4863 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4864 This is for the members text_lines, text_cols, total_lines, total_cols,
4865 where the system imposes an 'int' limit.
4867 * fringe.c (Fdefine_fringe_bitmap):
4868 Don't update size until alloc works.
4870 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4871 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4873 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4874 Check for size-calculation overflow.
4875 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4876 do, as we prefer signed integers.
4877 (id_to_widget.max_size, id_to_widget.used)
4878 (xg_store_widget_in_map, xg_remove_widget_from_map)
4879 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4880 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4881 Use and return ptrdiff_t, not int.
4882 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4883 * gtkutil.h: Change prototypes to match the above.
4885 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4886 are duplicate now that they've been promoted to lisp.h.
4887 (x_allocate_bitmap_record, x_alloc_image_color)
4888 (make_image_cache, cache_image, xpm_load):
4889 Don't update size until alloc is done.
4890 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4892 Check for size calculation overflow.
4893 (ct_colors_allocated_max): New constant.
4894 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4897 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4898 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4899 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4900 Use ptrdiff_t, not int, to count maps.
4901 (read_char_minibuf_menu_prompt): Check for overflow in size
4902 calculations. Don't update size until allocation succeeds.
4903 Redo calculations to avoid overflow.
4904 * keyboard.h: Change prototypes to match the above.
4906 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4908 (current_minor_maps): Check for size calculation overflow.
4909 * keymap.h: Change prototypes to match the above.
4911 * lread.c (read1, init_obarray): Don't update size until alloc done.
4913 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4914 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4916 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4917 Now ptrdiff_t, not int.
4918 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4919 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4921 * process.c (Fnetwork_interface_list): Check for overflow
4922 in size calculation.
4924 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4926 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4927 overflow. Don't bother calling xmalloc when xrealloc will do.
4929 * search.c (Freplace_match): Check for size calculation overflow.
4930 (Fset_match_data): Don't assume list lengths fit in 'int'.
4932 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4933 for command line length. Do not attempt to address one before the
4934 beginning of an array, as that's not portable.
4936 * term.c (max_frame_lines): Remove; unused.
4937 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4939 (encode_terminal_code, calculate_costs): Check for size
4940 calculation overflow.
4941 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4942 table lengths and related sizes. Don't update size until alloc
4943 done. Redo calculations to avoid overflow.
4944 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4946 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4947 subtracting pointers.
4948 (gobble_line): Check for overflow more carefully. Don't update size
4951 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4952 Don't update size until alloc done.
4953 Redo size calculations to avoid overflow.
4954 Check for size calculation overflow.
4955 (main) [DEBUG]: Fix typo in invoking tparam1.
4957 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4958 Use ptrdiff_t, not int, for sizes.
4959 (store_mode_line_noprop_char): Don't update size until alloc done.
4961 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4962 Use ptrdiff_t, not int, for sizes.
4963 (Finternal_make_lisp_face, cache_face):
4964 Check for size calculation overflow.
4965 (cache_face): Treat size calculation overflows as if they were
4966 memory exhaustion (the usual treatment), rather than aborting.
4968 * xfns.c (x_encode_text, x_set_name_internal)
4969 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4970 sizes, since they can exceed INT_MAX in size. Check for size
4971 calculation overflow.
4973 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4974 (xg_select): Check for size calculation overflow.
4975 Don't update size until alloc done.
4977 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4978 as sprintf is limited to int lengths.
4980 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4981 (X_LONG_MIN): New macros.
4982 Use them to make the following changes clearer.
4983 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4984 This change doesn't affect the value now, but it may help remind
4985 future maintainers not to raise the value too much later.
4986 (SELECTION_QUANTUM): Remove, replacing with ...
4987 (selection_quantum): ... new function, which avoids overflow.
4989 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4990 assumption that selection length fits in 'int'.
4991 (x_reply_selection_request, x_handle_selection_request)
4992 (x_get_window_property, receive_incremental_selection)
4993 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4994 (lisp_data_to_selection_data, clean_local_selection_data):
4995 Use ptrdiff_t, not int, to record length of selection.
4996 (x_reply_selection_request, x_get_window_property)
4997 (receive_incremental_selection, x_property_data_to_lisp):
4998 Redo calculations to avoid overflow.
4999 (x_reply_selection_request): When sending hint, ceiling it at
5000 X_LONG_MAX rather than relying on wraparound overflow to send
5002 (x_get_window_property, receive_incremental_selection)
5003 (lisp_data_to_selection_data, x_property_data_to_lisp):
5004 Check for size-calculation overflow.
5005 (x_get_window_property, receive_incremental_selection)
5006 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5007 Don't store size until memory allocation succeeds.
5008 (x_get_window_property): Plug memory leak on memory exhaustion.
5009 Don't double-block input; malloc is safe here. Don't assume 2**34
5010 - 4 fits in unsigned long. Add an xassert to check
5011 XGetWindowProperty overflow. Be more careful about overflow
5012 calculations, and distinguish size from memory overflow better.
5013 (receive_incremental_selection): When tracing, don't assume
5014 unsigned int is less than INT_MAX.
5015 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5016 harmful) conversions of unsigned short to int.
5017 (lisp_data_to_selection_data): Don't assume that integers
5018 in the range -65535 through -1 fit in an X unsigned short.
5019 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5020 result parameters unless successful. Rely on cons_to_unsigned
5021 to report problems with elements; the old code wasn't right anyway.
5022 (x_check_property_data): Check for int overflow; we cannot use
5023 a wider type due to X limits.
5024 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5026 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5028 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5029 (x_term_init): Check for size calculation overflow.
5030 (x_color_cells): Don't store size until memory allocation succeeds.
5031 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5032 Don't assume alloca size is less than MAX_ALLOCA.
5033 (x_term_init): Don't assume length fits in int (sprintf is limited
5036 Use ptrdiff_t for composition IDs.
5037 * character.c (lisp_string_width):
5038 * composite.c (composition_table_size, n_compositions)
5039 (get_composition_id, composition_gstring_from_id):
5040 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5041 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5042 * window.c (Frecenter):
5043 Use ptrdiff_t, not int, for composition IDs.
5044 * composite.c (get_composition_id): Check for integer overflow.
5045 * composite.h: Adjust prototypes to match the above changes.
5047 Use ptrdiff_t for hash table indexes.
5048 * category.c (hash_get_category_set):
5049 * ccl.c (ccl_driver):
5050 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5051 * coding.c (coding_system_charset_list, detect_coding_system):
5052 * coding.h (struct coding_system.id):
5053 * composite.c (get_composition_id, gstring_lookup_cache):
5054 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5055 * image.c (xpm_get_color_table_h):
5056 * lisp.h (hash_lookup, hash_put):
5057 * minibuf.c (Ftest_completion):
5058 Use ptrdiff_t for hash table indexes, not int (which is too
5059 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5060 32-bit --with-wide-int hosts).
5062 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5063 Add a FIXME comment about memory leaks.
5064 (syms_of_charset): Don't assume xmalloc returns.
5066 Don't assume that stated character widths fit in int.
5067 * character.c (Fchar_width, c_string_width, lisp_string_width):
5068 * character.h (CHAR_WIDTH):
5069 * indent.c (MULTIBYTE_BYTES_WIDTH):
5070 Use sanitize_char_width to avoid undefined and/or bad behavior
5071 with outlandish widths.
5072 * character.h (sanitize_tab_width): Rename from sanitize_width,
5073 now that we have two such functions. All uses changed.
5074 (sanitize_char_width): New inline function.
5076 Don't assume that tab-width fits in int.
5077 * character.h (sanitize_width): New inline function.
5078 (SANE_TAB_WIDTH): New macro.
5079 (ASCII_CHAR_WIDTH): Use it.
5080 * indent.c (sane_tab_width): Remove. All uses replaced by
5081 SANE_TAB_WIDTH (current_buffer).
5082 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5084 * fileio.c: Integer overflow issues with file modes.
5085 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5087 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5088 Remove unreachable code.
5089 (read_hex, load_charset_map_from_file): Check for integer overflow.
5091 * xterm.c: Don't go over XClientMessageEvent limit.
5092 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5093 (x_send_scroll_bar_event): Likewise. Check that the size does not
5094 exceed limits imposed by XClientMessageEvent, as well as the usual
5095 ptrdiff_t and size_t limits.
5097 * keyboard.c: Overflow, signedness and related fixes.
5098 (make_lispy_movement): Use same integer type in forward decl
5099 that is used in the definition.
5100 (read_key_sequence, keyremap_step):
5101 Change bufsize argument back to int, undoing my 2011-03-30 change.
5102 We prefer signed types, and int is wide enough here.
5103 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5104 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5105 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5106 length, not size_t. Use ptrdiff_t for index, not int.
5107 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5108 possibility of integer overflow.
5110 Overflow, signedness and related fixes for images.
5112 * dispextern.h (struct it.stack[0].u.image.image_id)
5113 (struct_it.image_id, struct image.id, struct image_cache.size)
5114 (struct image_cache.used, struct image_cache.ref_count):
5115 * gtkutil.c (update_frame_tool_bar):
5116 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5117 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5118 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5119 * nsmenu.m (update_frame_tool_bar):
5120 * xdisp.c (calc_pixel_width_or_height):
5121 * xfns.c (image_cache_refcount):
5122 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5123 on typical 64-bit hosts.
5125 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5126 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5127 Omit unnecessary casts to int.
5128 (parse_image_spec): Check that integers fall into 'int' range
5129 when the callers expect that.
5130 (image_ascent): Redo ascent calculation to avoid int overflow.
5131 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5132 (lookup_image): Remove unnecessary tests.
5133 (xbm_image_p): Locals are now of int, not EMACS_INT,
5134 since parse_image_check makes sure they fit into int.
5135 (png_load, gif_load, svg_load_image):
5136 Prefer int to unsigned where either will do.
5137 (tiff_handler): New function, combining the cores of the
5138 old tiff_error_handler and tiff_warning_handler.
5139 This function is rewritten to use vsnprintf and thereby avoid
5140 stack buffer overflows. It uses only the features of vsnprintf
5141 that are common to both POSIX and native Microsoft.
5142 (tiff_error_handler, tiff_warning_handler): Use it.
5143 (tiff_load, gif_load, imagemagick_load_image):
5144 Don't assume :index value fits in 'int'.
5145 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5146 (imagemagick_load_image): Check that crop parameters fit into
5147 the integer types that MagickCropImage accepts. Don't assume
5148 Vimagemagick_render_type has a nonnegative value. Don't assume
5149 size_t fits in 'long'.
5150 (gs_load): Use printmax_t to print the widest integers possible.
5151 Check for integer overflow when computing image height and width.
5153 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5155 * xdisp.c (redisplay_window): Don't force window start if point
5156 will be invisible in the resulting window. (Bug#9324)
5158 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5160 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5161 the display spec is of the form `(space ...)'.
5162 (handle_display_spec): Return the value returned by
5163 handle_single_display_spec, not just 1 or zero.
5164 (handle_single_display_spec): If the display spec is of the form
5165 `(space ...)', and specifies display in the text area, return 2
5167 (try_cursor_movement): Check for the need to scroll more
5168 accurately, and prefer exact match for point under bidi.
5169 Don't advance `row' beyond the last row of the window.
5171 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5172 into disp_prop; all users changed.
5174 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5175 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5176 for the text covered by the display property.
5178 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5180 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5181 Change return value to nil.
5182 (Frecord_buffer): Delete unused function.
5184 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5186 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5187 buffers, return left-to-right.
5188 (set_cursor_from_row): Consider candidate row a win if its glyph
5189 represents a newline and point is on that newline. Fixes cursor
5190 positioning on the newline at EOL of R2L text within L2R
5191 paragraph, and vice versa.
5192 (try_cursor_movement): Check continued rows, in addition to
5193 continuation rows. Fixes unwarranted scroll when point enters a
5194 continued line of R2L text within an L2R paragraph, or vice versa.
5195 (cursor_row_p): Consider the case of point being equal to
5196 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5197 from the end of a short line to the beginning of a continued line
5198 of R2L text within L2R paragraph.
5199 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5200 composed characters.
5202 * bidi.c (bidi_check_type): Use xassert.
5203 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5206 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5208 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5211 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5213 * nsfont.m (ns_otf_to_script): Fix typo.
5215 2011-08-22 Kenichi Handa <handa@m17n.org>
5217 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5218 extra slot even if the purpose is char-code-property-table.
5220 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5222 * xdisp.c (redisplay_window): When computing centering_position,
5223 account for the height of the header line. (Bug#8874)
5225 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5226 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5227 candidate is selected by the mouse, and that candidate has a
5228 composed character under the mouse.
5230 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5231 coordinates reported by pos-visible-in-window-p for a composed
5232 character in column zero.
5234 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5236 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5238 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5240 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5241 consider it a hit if to_charpos is anywhere in the range of the
5242 composed buffer positions.
5244 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5246 * image.c (gif_load): Don't assume that each subimage has the same
5247 dimensions as the base image. Handle disposal method that is
5248 "undefined" by the gif spec (Bug#9335).
5250 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5252 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5253 (Fcondition_case): Document `debug' symbol in error handler.
5255 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5257 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5258 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5259 from an Org mode buffer to a Speedbar frame.
5261 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5262 a composition, take its buffer position from IT->cmp_it.charpos.
5263 Fixes cursor positioning at the beginning of a line that begins
5264 with a composed character.
5266 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5268 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5269 character bidirectional type, use STRONG_L instead. Fixes crashes
5270 in a buffer produced by `describe-categories'.
5272 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5273 members before the level stack, so they would be saved and
5274 restored when copying iterator state. Fixes incorrect reordering
5275 around TABs covered by display properties.
5277 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5279 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5281 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5283 * eval.c (internal_condition_case, internal_condition_case_1)
5284 (internal_condition_case_2, internal_condition_case_n):
5285 Remove unnecessary aborts (Bug#9081).
5287 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5289 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5290 has no `load' handler, try opening the file locally. (Bug#9311)
5292 2011-08-16 Ken Brown <kbrown@cornell.edu>
5294 * gmalloc.c: Expand comment.
5296 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5298 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5299 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5301 2011-08-16 Ken Brown <kbrown@cornell.edu>
5303 Fix memory allocation problems in Cygwin build (Bug#9273).
5305 * unexcw.c ( __malloc_initialized): Declare external variable.
5306 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5308 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5310 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5312 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5314 [CYGWIN] (special_realloc): New function.
5315 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5316 requests to realloc storage in the static heap.
5318 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5320 * bidi.c (bidi_initialize): Remove unused local.
5322 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5325 * biditype.h: Remove file.
5326 * makefile.w32-in ($(BLD)/bidi.$(O)):
5327 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5329 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5331 * chartab.c: Improve commentary for the uniprop_table API.
5333 * bidi.c (bidi_paragraph_init): Support zero value of
5334 bidi_ignore_explicit_marks_for_paragraph_level.
5335 (bidi_initialize): Use uniprop_table instead of including
5336 biditype.h and bidimirror.h.
5338 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5339 coordinates of the iterator when restoring from ppos_it.
5342 2011-08-14 Kenichi Handa <handa@m17n.org>
5344 * process.c (create_process): Call setup_process_coding_systems
5345 after the pid of the process is set to -1 (Bug#8162).
5347 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5349 * xdisp.c (move_it_in_display_line_to): Don't invoke
5350 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5351 ppos_it. Fixes vertical cursor motion when line beginning is
5352 covered by an image. (Bug#9296)
5354 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5356 * nsterm.h (ns_run_ascript): Declare.
5357 (NSAPP_DATA2_RUNASSCRIPT): Define.
5359 * nsfns.m (as_script, as_result, as_status): New static variables.
5360 (ns_run_ascript): New function.
5361 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5362 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5363 the event loop. Get status from as_status (Bug#7276).
5365 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5366 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5367 the event loop (Bug#7276).
5369 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5371 * gnutls.c (QCgnutls_bootprop_priority)
5372 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5373 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5374 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5375 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5376 (QCgnutls_bootprop_verify_hostname_error)
5377 (QCgnutls_bootprop_callbacks_verify): Rename from
5378 Qgnutls_bootprop_..., all uses changed.
5380 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5383 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5385 * xfaces.c (Qframe_set_background_mode): Now static.
5386 * dispextern.h (Qframe_set_background_mode): Remove decl.
5388 * process.c (Fnetwork_interface_info): Declare local only if needed.
5390 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5392 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5393 (Fnetwork_interface_list): Allocate in increments of bytes instead
5394 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5395 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5397 (struct ifflag_def): notrailers is smart on OSX.
5398 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5399 Get hardware address with getifaddrs if available.
5401 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5403 * xdisp.c (iterate_out_of_display_property): xassert that
5404 IT->position is set to within IT->object's boundaries. Break from
5405 the loop as soon as EOB is reached; avoids infloops in redisplay
5406 when IT->position is set up wrongly due to some bug.
5407 Set IT->current to match the bidi iterator unconditionally.
5408 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5409 entry. Force push_it to save on the stack the current
5410 buffer/string position, to be restored by pop_it. Fix flags in
5411 the iterator structure wrt the object coming from a display
5412 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5413 properties. (Bug#9284)
5415 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5417 * fontset.c (fontset_get_font_group): Add proper type checks.
5420 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5422 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5423 and LC_VERSION_MIN_MACOSX.
5424 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5425 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5427 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5429 * xdisp.c (forward_to_next_line_start): Allow to use the
5430 no-display-properties-and-no-overlays under bidi display.
5431 Set disp_pos in the bidi iterator to avoid searches for display
5432 properties and overlays.
5434 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5436 * editfns.c (Fset_time_zone_rule): Document relationship with the
5439 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5440 the font entity extracted from the cache (Bug#8109).
5442 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5444 * composite.c (autocmp_chars): Don't reset point. That is done by
5445 restore_point_unwind (Bug#5984).
5447 2011-08-07 Juri Linkov <juri@jurta.org>
5449 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5450 to show the arg `TIME' instead of `TIMEVAL'.
5452 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5454 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5455 display property strides EOL and includes a newline, as in
5456 longlines-mode. (Bug#9254)
5457 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5458 word-wrap under bidirectional display. (Bug#9224)
5460 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5461 is non-zero, even if the data buffer is NULL. Fixes a crash in
5462 vertical-motion with longlines-mode. (Bug#9254)
5464 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5466 * bidi.c <bidi_cache_total_alloc>: Now static.
5467 (bidi_initialize): Initialize bidi_cache_total_alloc.
5469 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5472 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5473 amount allocated this far in `bidi_cache_total_alloc'.
5474 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5475 non-zero, only free the data buffer without restoring the cache
5476 contents. All callers changed.
5478 * dispextern.h (bidi_unshelve_cache): Update prototype.
5480 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5481 (move_it_in_display_line, move_it_to)
5482 (move_it_vertically_backward, move_it_by_lines): Replace the call
5483 to xfree to an equivalent call to bidi_unshelve_cache.
5484 (move_it_in_display_line_to): Fix logic of returning
5485 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5487 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5489 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5490 came from a string character with a `cursor' property. (Bug#9229)
5492 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5494 * Makefile.in (LIB_PTHREAD): New variable.
5495 (LIBES): Add LIB_PTHREAD (Bug#9216).
5497 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5498 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5500 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5502 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5504 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5506 * xterm.c (x_find_topmost_parent): New function.
5507 (x_set_frame_alpha): Find topmost parent window with
5508 x_find_topmost_parent and set the property there also (bug#9181).
5509 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5511 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5513 * callproc.c (Fcall_process): Avoid vfork clobbering
5514 the local vars buffer, coding_systems, current_dir.
5516 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5518 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5520 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5522 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5523 so that it is not optimized away.
5525 * xdisp.c (compute_display_string_pos): Remove unused local.
5527 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5529 Fix slow cursor motion and scrolling in large buffers with
5530 selective display, like Org Mode buffers. (Bug#9218)
5532 * dispextern.h (struct bidi_it): New member disp_prop_p.
5534 * xdisp.c: Remove one-slot cache of display string positions.
5535 (compute_display_string_pos): Accept an additional argument
5536 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5537 for a display string or property. If found, set DISP_PROP_P
5540 * bidi.c (bidi_fetch_char): Accept an additional argument
5541 DISP_PROP_P, and pass it to compute_display_string_pos.
5542 Only handle text covered by a display string if DISP_PROP_P is returned
5543 non-zero. All callers of bidi_fetch_char changed.
5545 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5547 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5549 2010-12-03 Don March <don@ohspite.net>
5551 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5552 last character M-[char] is translated to ESC [char] (bug#7541).
5554 2011-08-02 Kenichi Handa <handa@m17n.org>
5556 * lisp.h (uniprop_table): Extern it.
5558 * chartab.c (uniprop_table): Make it non-static.
5560 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5562 * xdisp.c (forward_to_next_line_start): Accept additional argument
5563 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5565 (reseat_at_next_visible_line_start): Use the bidi iterator state
5566 returned by forward_to_next_line_start to restore the state of
5567 it->bidi_it after backing up to previous newline. (Bug#9212)
5569 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5571 * regex.c (re_comp): Protoize.
5572 (re_exec): Fix return type.
5573 (regexec): Fix type of `ret'. (Bug#9203)
5575 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5577 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5578 This is needed if max-image-size is a floating-point number.
5580 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5582 * print.c (print_object): Print empty symbol as ##.
5584 * lread.c (read1): Read ## as empty symbol.
5586 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5588 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5589 setting frame foreground color (Bug#9175).
5590 (x_set_background_color): Likewise.
5592 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5593 contents (Bug#9176).
5594 (EmacsTooltip -init): Remove bezels and add shadows to
5597 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5598 or scroll bar (Bug#8470).
5600 * nsfont.m (nsfont_open): Remove assignment to voffset and
5601 unnecessary vars hshink, expand, hd, full_height, min_height.
5602 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5604 * nsterm.h (nsfont_info): Remove voffset field.
5606 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5608 Implement strike-through and overline on NextStep (Bug#8863).
5610 * nsfont.m (nsfont_open): Use underline position provided by font,
5611 instead of hard-coded value of 2.
5612 (nsfont_draw): Call ns_draw_text_decoration instead.
5614 * nsterm.h: Add declaration for ns_draw_text_decoration.
5616 * nsterm.m (ns_draw_text_decoration): New function for drawing
5617 underline, overline, and strike-through.
5618 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5619 ns_draw_text_decoration. Change treatment of cursor drawing to
5620 accommodate underlining, etc.
5622 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5624 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5627 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5629 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5630 Without this fix, if a signal arrives just after memory fills up,
5631 'malloc' might be invoked reentrantly.
5633 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5634 In other words, assume that every image size is allowed, on non-X
5635 hosts. This assumption is probably wrong, but it lets Emacs compile.
5637 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5639 * regex.c (re_iswctype): Convert return values to boolean.
5641 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5643 * xdisp.c (compute_display_string_pos): Don't use cached display
5644 string position if the buffer had its restriction changed.
5647 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5649 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5651 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5653 Integer signedness and overflow and related fixes. (Bug#9079)
5655 * bidi.c: Integer size and overflow fixes.
5656 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5657 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5658 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5659 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5660 (bidi_find_other_level_edge):
5661 Use ptrdiff_t instead of EMACS_INT where either will do.
5662 This works better on 32-bit hosts configured --with-wide-int.
5663 (bidi_cache_ensure_space): Check for size-calculation overflow.
5664 Use % rather than repeated addition, for better worst-case speed.
5665 Don't set bidi_cache_size until after xrealloc returns, because it
5667 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5668 (bidi_cache_ensure_space): Also check that the bidi cache size
5669 does not exceed that of the largest Lisp string or buffer. See Eli
5670 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5672 * alloc.c (__malloc_size_t): Remove.
5673 All uses replaced by size_t. See Andreas Schwab's note
5674 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5676 * image.c: Improve checking for integer overflow.
5677 (check_image_size): Assume that f is nonnull, since
5678 it is always nonnull in practice. This is one less thing to
5679 worry about when checking for integer overflow later.
5680 (x_check_image_size): New function, which checks for integer
5681 overflow issues inside X.
5682 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5683 This removes the need for a memory_full check.
5684 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5685 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5686 (xbm_read_bitmap_data): Change locals back to 'int', since
5687 their values must fit in 'int'.
5688 (xpm_load_image, png_load, tiff_load):
5689 Invoke x_create_x_image_and_pixmap earlier,
5690 to avoid much needless work if the image is too large.
5691 (tiff_load): Treat overly large images as if
5692 x_create_x_image_and_pixmap failed, not as malloc failures.
5693 (gs_load): Use x_check_image_size.
5695 * gtkutil.c: Omit integer casts.
5696 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5697 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5699 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5701 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5702 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5703 would wrongly return t on a 64-bit host.
5705 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5706 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5707 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5708 and therefore cause GCC to emit a bogus diagnostic in some cases.
5710 * image.c: Integer signedness and overflow and related fixes.
5711 This is not an exhaustive set of fixes, but it's time to
5712 record what I've got.
5713 (lookup_pixel_color, check_image_size): Remove redundant decls.
5714 (check_image_size): Don't assume that arbitrary EMACS_INT values
5715 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5716 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5717 (tiff_load, imagemagick_load_image):
5718 Check for overflow in size calculations.
5719 (x_create_x_image_and_pixmap): Remove unnecessary test for
5720 xmalloc returning NULL; that can't happen.
5721 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5722 (xpm_color_bucket): Use better integer hashing function.
5723 (xpm_cache_color): Don't possibly over-allocate memory.
5724 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5725 (gif_memory_source):
5726 Use ptrdiff_t, not int or size_t, to record sizes.
5727 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5728 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5729 either works, as we prefer signed integers.
5730 (tiff_read_from_memory, tiff_write_from_memory):
5731 Return tsize_t, not size_t, since that's what the TIFF API wants.
5732 (tiff_read_from_memory): Don't fail simply because the read would
5733 go past EOF; instead, return a short read.
5734 (tiff_load): Omit no-longer-needed casts.
5735 (Fimagemagick_types): Don't assume size fits into 'int'.
5737 Improve hashing quality when configured --with-wide-int.
5738 * fns.c (hash_string): New function, taken from sxhash_string.
5739 Do not discard information about ASCII character case; this
5740 discarding is no longer needed.
5741 (sxhash-string): Use it. Change sig to match it. Caller changed.
5742 * lisp.h: Declare it.
5743 * lread.c (hash_string): Remove, since we now use fns.c's version.
5744 The fns.c version returns a wider integer if --with-wide-int is
5745 specified, so this should help the quality of the hashing a bit.
5747 * emacs.c: Integer overflow minor fix.
5748 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5749 Define only if GNU_LINUX.
5750 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5752 * dispnew.c: Integer signedness and overflow fixes.
5753 Remove unnecessary forward decls, that were a maintenance hassle.
5754 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5756 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5757 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5758 (prepare_desired_row, line_draw_cost):
5759 Use int, not unsigned, where either works.
5760 (save_current_matrix, restore_current_matrix):
5761 Use ptrdiff_t, not size_t, where either works.
5762 (init_display): Check for overflow more accurately, and without
5763 relying on undefined behavior.
5765 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5766 Remove, replacing with the new symbols in lisp.h. All uses changed.
5767 * fileio.c (make_temp_name):
5768 * filelock.c (lock_file_1, lock_file):
5769 * xdisp.c (message_dolog):
5770 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5771 Use pMd etc. instead.
5772 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5773 replacing the pWIDE etc. symbols removed from editfns.c.
5775 * keyboard.h (num_input_events): Now uintmax_t.
5776 This is (very slightly) less likely to mess up due to wraparound.
5779 * buffer.c: Integer signedness fixes.
5780 (alloc_buffer_text, enlarge_buffer_text):
5781 Use ptrdiff_t rather than size_t when either will do, as we prefer
5784 * alloc.c: Integer signedness and overflow fixes.
5785 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5786 (__malloc_size_t): Default to size_t, not to int.
5787 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5788 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5789 Prefer ptrdiff_t to size_t when either would do, as we prefer
5791 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5792 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5793 Now const. Initialize with values that are in range even if char
5795 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5796 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5797 These functions do the right thing with sizes > 2**32.
5798 (check_depth): Now ptrdiff_t, not int.
5799 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5800 Adjust to new way of storing sizes. Check for size overflow bugs
5802 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5803 slightly wrong anyway, as it missed one instance of
5804 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5805 (refill_memory_reserve): Omit needless cast to size_t.
5806 (mark_object_loop_halt): Mark as externally visible.
5808 * xselect.c: Integer signedness and overflow fixes.
5809 (Fx_register_dnd_atom, x_handle_dnd_message):
5810 Use ptrdiff_t, not size_t, since we prefer signed.
5811 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5812 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5813 x_dnd_atoms_size and x_dnd_atoms_length.
5815 * doprnt.c: Prefer signed to unsigned when either works.
5817 * doprnt.c (doprnt):
5819 * xdisp.c (vmessage):
5820 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5821 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5822 prefer signed arithmetic to avoid comparison confusion.
5823 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5824 but is a bit tricky.
5826 Assume freestanding C89 headers, string.h, stdlib.h.
5827 * data.c, doprnt.c, floatfns.c, print.c:
5828 Include float.h unconditionally.
5829 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5830 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5831 * regex.c: Likewise for stddef.h, string.h.
5832 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5833 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5834 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5835 (STDC_HEADERS): Remove obsolete defines.
5836 * sysdep.c: Include limits.h unconditionally.
5838 Assume support for memcmp, memcpy, memmove, memset.
5839 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5840 * regex.c (memcmp, memcpy):
5841 Remove; we assume C89 now.
5843 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5844 (__malloc_safe_bcopy): Remove; no longer needed.
5846 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5847 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5848 well either way, and we prefer signed to unsigned.
5850 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5852 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5853 closes the connection while we're reading (bug#9182).
5855 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5857 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5858 are specified (Bug#9168).
5860 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5862 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5863 Found by GCC static checking and --with-wide-int on a 32-bit host.
5865 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5867 * xdisp.c (compute_display_string_pos): Fix logic of caching
5868 previous display string position. Initialize cached_prev_pos to
5869 -1. Fixes slow-down at the beginning of a buffer.
5871 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5873 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5874 for attrs[LFACE_FONTSET_INDEX].
5876 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5878 * xml.c (parse_region): Remove unused local
5879 that was recently introduced.
5881 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5883 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5884 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5886 * xdisp.c (move_it_in_display_line_to): Record the best matching
5887 position for TO_CHARPOS while scanning the line, and restore it on
5888 exit if none of the characters scanned was an exact match.
5889 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5890 when exact match is impossible due to invisible text, and the
5891 lines are truncated.
5893 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5895 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5898 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5900 Fix a significant slow-down of cursor motion with C-n, C-p,
5901 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5902 auto-repeat under bidi redisplay in fontified buffers.
5903 * xdisp.c (compute_stop_pos_backwards): New function.
5904 (next_element_from_buffer): Call compute_stop_pos_backwards to
5905 find a suitable prev_stop when we find ourselves before
5907 (reseat): Don't look for prev_stop, as that could mean a very long
5909 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5910 <cached_disp_overlay_modiff>: Cache for last found display string
5912 (compute_display_string_pos): Return the cached position if asked
5913 about the same buffer in the same area of character positions, and
5914 the buffer wasn't changed since the time the display string
5915 position was cached.
5917 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5919 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5920 is an integer, which is important for empty lines. (Bug#9149)
5922 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5924 * frame.c (Fmodify_frame_parameters): In tty case, update the
5925 default face if necessary (Bug#4238).
5927 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5929 * editfns.c (Fstring_to_char): No need to explain what a character
5930 is in the docstring (Bug#6576).
5932 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5934 * xml.c (parse_region): Make sure we always return a tree.
5936 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5938 * xml.c (parse_region): If a document contains only comments,
5941 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5943 * xml.c (make_dom): Return comments, too.
5945 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5948 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5949 and the surrounding thread.
5950 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5951 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5952 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5954 * s/openbsd.h (BROKEN_SIGIO): Define.
5955 * unexelf.c (unexec) [__OpenBSD__]:
5956 Don't update the .mdebug section of the Alpha COFF symbol table.
5958 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5960 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5963 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5965 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5966 This fixes some race conditions on the permissions of any newly
5969 * alloc.c (valid_pointer_p): Use pipe, not open.
5970 This fixes some permissions issues when debugging.
5972 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5973 If fchown fails to set both uid and gid, try to set just gid,
5974 as that is sometimes allowed. Adjust the file's mode to eliminate
5975 setuid or setgid bits that are inappropriate if fchown fails.
5977 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5979 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5980 to compare Lisp_Objects.
5981 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5982 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5983 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5985 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5987 * lread.c (read_integer): Unread even EOF character.
5988 (read1): Likewise. Properly record start position of symbol.
5990 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5991 symbol character follows.
5993 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5995 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5996 This works around a problem with the previous change to Fcopy_file.
5997 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5998 and without this change, GCC might complain about discarding
5999 fchown's return value.
6001 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6003 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6005 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6007 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6009 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6011 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6012 it's used from the C level.
6014 * process.c: Use the same condition for POLL_FOR_INPUT in both
6015 keyboard.c and process.c (bug#1858).
6017 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6019 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6020 (Fgnutls_boot): Use it.
6022 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6024 * doc.c (Fsubstitute_command_keys): Revert last change.
6026 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6028 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6029 quotes the next character, and doesn't affect other longer
6030 sequences (bug#8935).
6032 * lread.c (syms_of_lread): Clarify that is isn't only
6033 `eval-buffer' and `eval-defun' that's affected by
6034 `lexical-binding' (bug#8460).
6036 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6038 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6039 bidi redisplay when a line includes both an image and is truncated.
6041 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6043 Fix minor problems found by static checking.
6044 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6045 (elsz): Now a signed constant, not a size_t var. We prefer signed
6046 types to unsigned, to avoid integer comparison confusion. Without
6047 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6048 "cannot optimize loop, the loop counter may overflow", a symptom
6050 * indent.c (Fvertical_motion): Mark locals as initialized.
6051 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6053 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6055 * search.c (Fre_search_backward): Mention `case-fold-search' in
6056 all the re_search_* functions (bug#8138).
6058 * keyboard.c (Fopen_dribble_file): Document when the file is
6061 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6063 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6066 Support bidi reordering of display and overlay strings.
6067 * xdisp.c (compute_display_string_pos)
6068 (compute_display_string_end): Accept additional argument STRING.
6069 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6070 (reseat_to_string): Initialize bidi_it->string.s and
6071 bidi_it->string.schars.
6072 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6073 NULL (avoids a crash in bidi_paragraph_init).
6074 Initialize itb.string.lstring.
6075 (init_iterator): Call bidi_init_it only of a valid
6076 buffer position was specified. Initialize paragraph_embedding to
6078 (reseat_to_string): Initialize the bidi iterator.
6079 (display_string): If we need to ignore text properties of
6080 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6081 original value of -1 will not work with bidi.)
6082 (compute_display_string_pos): First arg is now struct
6083 `text_pos *'; all callers changed. Support display properties on
6085 (compute_display_string_end): Support display properties on Lisp
6087 (init_iterator, reseat_1, reseat_to_string): Initialize the
6088 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6089 when iterating on a string not from display properties).
6090 (compute_display_string_pos, compute_display_string_end):
6091 Fix calculation of the object to scan. Fixes an error when using
6093 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6094 base_level_stop; instead, set base_level_stop to BEGV.
6095 Fixes crashes in vertical-motion.
6096 (next_element_from_buffer): Improve commentary for when
6097 the iterator is before prev_stop.
6098 (init_iterator): Initialize bidi_p from the default value of
6099 bidi-display-reordering, not from buffer-local value. Use the
6100 buffer-local value only if initializing for buffer iteration.
6101 (handle_invisible_prop): Support invisible properties on strings
6102 that are being bidi-reordered.
6103 (set_iterator_to_next): Support bidi reordering of C strings and
6105 (next_element_from_string): Support bidi reordering of Lisp
6107 (handle_stop_backwards): Support Lisp strings as well.
6108 (display_string): Support display of R2L glyph rows.
6109 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6110 (init_iterator): Don't initialize it->bidi_p for strings
6112 (reseat_to_string): Initialize it->bidi_p for strings here.
6113 (next_element_from_string, next_element_from_c_string)
6114 (next_element_from_buffer): Add xassert's for correspondence
6115 between IT's object being iterated and it->bidi_it.string
6117 (face_before_or_after_it_pos): Support bidi iteration.
6118 (next_element_from_c_string): Handle the case of the first string
6119 character that is not the first one in the visual order.
6120 (get_visually_first_element): New function, refactored from common
6121 parts of next_element_from_buffer, next_element_from_string, and
6122 next_element_from_c_string.
6123 (tool_bar_lines_needed, redisplay_tool_bar)
6124 (display_menu_bar): Force left-to-right direction. Add a FIXME
6125 comment for making that be controlled by a user option.
6126 (push_it, pop_it): Save and restore the state of the
6127 bidi iterator. Save and restore the bidi_p flag.
6128 (pop_it): Iterate out of display property for string iteration as
6130 (iterate_out_of_display_property): Support iteration over strings.
6131 (handle_single_display_spec): Set up it->bidi_it for iteration
6132 over a display string, and call bidi_init_it.
6133 (handle_single_display_spec, next_overlay_string)
6134 (get_overlay_strings_1, push_display_prop): Set up the bidi
6135 iterator for displaying display or overlay strings.
6136 (forward_to_next_line_start): Don't use the shortcut if
6138 (back_to_previous_visible_line_start): If handle_display_prop
6139 pushed the iterator stack, restore the internal state of the bidi
6140 iterator by calling bidi_pop_it same number of times.
6141 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6142 and we are bidi-iterating, don't decrement the iterator position;
6143 instead, set the first_elt flag in the bidi iterator, to produce
6145 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6146 (push_display_prop): xassert that we are iterating a buffer.
6147 (push_it, pop_it): Save and restore paragraph_embedding member.
6148 (handle_single_display_spec, next_overlay_string)
6149 (get_overlay_strings_1, reseat_1, reseat_to_string)
6150 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6151 correctly. Don't assume unibyte strings are not bidi-reordered.
6152 (compute_display_string_pos)
6153 (compute_display_string_end): Fix handling the case of C string.
6154 (push_it, pop_it): Save and restore from_disp_prop_p.
6155 (handle_single_display_spec, push_display_prop): Set the
6156 from_disp_prop_p flag.
6157 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6158 (pop_it): Call iterate_out_of_display_property only if we are
6159 popping after iteration over a string that came from a display
6160 property. Fix a typo in popping stretch info. Add an assertion
6161 for verifying that the iterator position is in sync with the bidi
6163 (handle_single_display_spec, get_overlay_strings_1)
6164 (push_display_prop): Fix initialization of paragraph direction for
6165 string when that of the parent object is not yet determined.
6166 (reseat_1): Call bidi_init_it to resync the bidi
6167 iterator with IT's position. (Bug#7616)
6168 (find_row_edges): If ROW->start.pos gives position
6169 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6170 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6171 Reset the from_disp_prop_p flag.
6172 (SAVE_IT, RESTORE_IT): New macros.
6173 (pos_visible_p, face_before_or_after_it_pos)
6174 (back_to_previous_visible_line_start)
6175 (move_it_in_display_line_to, move_it_in_display_line)
6176 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6177 (try_scrolling, redisplay_window, display_line): Use them when
6178 saving a temporary copy of the iterator and restoring it back.
6179 (back_to_previous_visible_line_start, reseat_1)
6180 (init_iterator): Empty the bidi cache "stack".
6181 (move_it_in_display_line_to): If iterator ended up at
6182 EOL, but we never saw any buffer positions smaller than
6183 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6184 motion in bidi-reordered lines.
6185 (move_it_in_display_line_to): Record prev_method and prev_pos
6186 immediately before the call to set_iterator_to_next. Fixes cursor
6187 motion in bidi-reordered lines with stretch glyphs and strings
6188 displayed in margins. (Bug#8133) (Bug#8867)
6189 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6191 (pos_visible_p): Support positions in bidi-reordered lines.
6192 Save and restore bidi cache.
6194 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6195 (bidi_paragraph_info): Delete unused struct.
6196 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6197 (bidi_cache_start): New variable.
6198 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6200 (bidi_cache_fetch_state, bidi_cache_search)
6201 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6202 (bidi_cache_find, bidi_peek_at_next_level)
6203 (bidi_level_of_next_char, bidi_find_other_level_edge)
6204 (bidi_move_to_visually_next): Compare cache index with
6205 bidi_cache_start rather than with zero.
6206 (bidi_fetch_char): Accept new argument STRING; all callers
6207 changed. Support iteration over a string. Support strings with
6208 display properties. Support unibyte strings. Fix the type of
6209 `len' according to what STRING_CHAR_AND_LENGTH expects.
6210 (bidi_paragraph_init, bidi_resolve_explicit_1)
6211 (bidi_resolve_explicit, bidi_resolve_weak)
6212 (bidi_level_of_next_char, bidi_move_to_visually_next):
6213 Support iteration over a string.
6214 (bidi_set_sor_type, bidi_resolve_explicit_1)
6215 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6216 can now be zero (for strings); special values 0 and -1 were
6217 changed to -1 and -2, respectively.
6218 (bidi_char_at_pos): New function.
6219 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6220 Call it instead of FETCH_MULTIBYTE_CHAR.
6221 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6222 initialized to valid values.
6223 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6225 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6226 the test for valid cached positions. Fix the logic for looking up
6227 the sentinel state in the cache. GCPRO the Lisp string we are
6229 (bidi_push_it, bidi_pop_it): New functions.
6230 (bidi_initialize): Initialize the bidi cache start stack pointer.
6231 (bidi_cache_ensure_space): New function, refactored from part of
6232 bidi_cache_iterator_state. Don't assume the required size is just
6233 one BIDI_CACHE_CHUNK away.
6234 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6235 (bidi_count_bytes, bidi_char_at_pos): New functions.
6236 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6237 always valid if bidi_cache_idx is valid.
6238 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6239 is valid if it's going to be used.
6240 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6241 (bidi_cache_fetch_state, bidi_cache_search)
6242 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6243 (bidi_cache_iterator_state, bidi_cache_find)
6244 (bidi_find_other_level_edge, bidi_cache_start_stack):
6245 All variables related to cache indices are now EMACS_INT.
6247 * dispextern.h (struct bidi_string_data): New structure.
6248 (struct bidi_it): New member `string'. Make flag members be 1-bit
6249 fields, and put them last in the struct.
6250 (compute_display_string_pos, compute_display_string_end):
6252 (bidi_push_it, bidi_pop_it): Add prototypes.
6253 (struct iterator_stack_entry): New members bidi_p,
6254 paragraph_embedding, and from_disp_prop_p.
6255 (struct it): Member bidi_p is now a bit field 1 bit wide.
6256 (bidi_shelve_cache, bidi_unshelve_cache):
6259 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6260 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6261 and vector-like objects.
6263 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6264 cache around display iteration.
6266 * window.c (Fwindow_end, window_scroll_pixel_based)
6267 (displayed_window_lines, Frecenter): Save and restore the bidi
6268 cache around display iteration.
6270 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6272 * editfns.c (Fdelete_region): Clarify the use of the named
6273 parameters (bug#6788).
6275 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6277 * indent.c (Fvertical_motion): Set and restore w->pointm when
6278 saving and restoring the window's buffer (Bug#9006).
6280 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6282 * editfns.c (Fstring_to_char): Clarify just what is returned
6283 (bug#6576). Text by Eli Zaretskii.
6285 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6287 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6289 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6291 * buffer.c (mmap_find): Fix a typo.
6293 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6295 Fix execution of x selection hooks.
6296 * xselect.c (Qx_lost_selection_functions)
6297 (Qx_sent_selection_functions): New vars.
6298 (syms_of_xselect): DEFSYM them.
6299 (x_handle_selection_request): Pass Qx_sent_selection_functions
6300 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6301 (x_handle_selection_clear,x_clear_frame_selections):
6302 Pass Qx_lost_selection_functions rather than
6303 Vx_lost_selection_functions to Frun_hook_with_args.
6305 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6307 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6308 The old code sometimes used this field without initializing it.
6310 * alloc.c (gc_sweep): Don't read past end of array.
6311 In theory, the old code could also have corrupted Emacs internals,
6312 though it'd be very unlikely.
6314 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6316 * character.c (Fcharacterp): Don't advertise optional ignored
6317 argument. (Bug#4026)
6319 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6321 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6324 * window.c (Fset_window_start): Doc fix (bug#4199).
6325 (Fset_window_hscroll): Ditto.
6327 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6329 Fix minor new problems caught by GCC 4.6.1.
6330 * term.c (init_tty): Remove unused local.
6331 * xsettings.c (store_monospaced_changed): Define this function only
6332 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6335 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6337 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6339 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6341 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6342 are the mini-buffer and the echo area (bug#3320).
6344 * term.c (init_tty): Remove support for supdup, c10 and perq
6345 terminals, which are no longer supported (bug#1482).
6347 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6349 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6351 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6353 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6354 for non-popups (Bug#3642).
6356 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6358 * alloc.c (reset_malloc_hooks): Protoize.
6359 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6360 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6361 * cm.c (losecursor): Likewise.
6362 * data.c (fmod): Likewise.
6363 * dispnew.c (swap_glyphs_in_rows): Likewise.
6364 * emacs.c (memory_warning_signal): Likewise.
6365 * floatfns.c (float_error): Likewise.
6366 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6367 (otf_open, font_otf_capability, generate_otf_features)
6368 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6370 * image.c (pbm_read_file): Likewise.
6371 * indent.c (string_display_width): Likewise.
6372 * intervals.c (check_for_interval, search_for_interval)
6373 (inc_interval_count, count_intervals, root_interval)
6374 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6375 * lread.c (defalias): Likewise.
6376 * ralloc.c (r_alloc_check): Likewise.
6377 * regex.c (set_image_of_range_1, set_image_of_range)
6378 (regex_grow_registers): Likewise.
6379 * sysdep.c (strerror): Likewise.
6380 * termcap.c (valid_filename_p, tprint, main): Likewise.
6381 * tparam.c (main): Likewise.
6382 * unexhp9k800.c (run_time_remap, save_data_space)
6383 (update_file_ptrs, read_header, write_header, calculate_checksum)
6384 (copy_file, copy_rest, display_header): Likewise.
6385 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6387 * xdisp.c (check_it): Likewise.
6388 * xfaces.c (register_color, unregister_color, unregister_colors):
6390 * xfns.c (print_fontset_result): Likewise.
6391 * xrdb.c (member, fatal, main): Likewise.
6393 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6395 Fix minor problems found by static checking (Bug#9031).
6396 * chartab.c (char_table_set_range, map_sub_char_table):
6397 Remove unused locals.
6398 (uniprop_table): Now static.
6399 * composite.c (_work_char): Remove unused static var.
6401 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6403 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6405 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6407 * gtkutil.c (qttip_cb): Remove code without function.
6409 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6411 * w32.c (pthread_sigmask): New stub.
6413 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6415 Use pthread_sigmask, not sigprocmask (Bug#9010).
6416 sigprocmask is portable only for single-threaded applications, and
6417 Emacs can be multi-threaded when it uses GTK.
6418 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6420 * callproc.c (Fcall_process):
6421 * process.c (create_process):
6422 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6423 Use pthread_sigmask, not sigprocmask.
6425 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6427 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6428 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6431 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6433 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6434 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6435 (xg_hide_tooltip): Fix comment.
6437 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6438 in registerServicesMenuSendTypes.
6439 (validRequestorForSendType): Don't check ns_return_types.
6441 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6444 2011-07-08 Jason Rumney <jasonr@gnu.org>
6446 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6447 SH_SHOW for hidden windows (Bug#5482).
6449 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6450 frame struct members of non-existent frames (Bug#6284).
6452 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6454 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6455 variable firstTime not needed on OSX >= 10.6.
6456 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6457 >= 10.5. Use setKnobProportion, setDoubleValue.
6459 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6460 (MAC_OS_X_VERSION_10_5): Define if not defined.
6461 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6462 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6463 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6465 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6466 cString and lossyCString on OSX >= 10.4
6468 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6469 sizeToFit on OSX >= 10.2.
6471 * nsimage.m (allocInitFromFile): Don't use deprecated method
6472 bestRepresentationForDevice on OSX >= 10.6.
6474 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6477 * emacs.c: Declare unexec_init_emacs_zone.
6479 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6481 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6483 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6484 on svcsMenu (Bug#8842).
6486 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6488 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6490 * nsterm.m (QUTF8_STRING): Declare.
6491 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6492 (validRequestorForSendType): Return type is (id).
6493 Change indexOfObjectIdenticalTo to indexOfObject.
6494 Check if we have local selection before returning self (Bug#8842).
6495 (writeSelectionToPasteboard): Put local selection into paste board
6496 if we have a local selection (Bug#8842).
6497 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6499 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6500 (ns_get_local_selection): Declare.
6502 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6504 * keymap.c (describe_map_tree): Don't insert a double newline at
6505 the end of the buffer (bug#1169) and return whether we inserted
6508 * callint.c (Fcall_interactively): Change "reading args" to
6509 "providing args" to try to clarify what it does (bug#1010).
6511 2011-07-07 Kenichi Handa <handa@m17n.org>
6513 * composite.c (composition_compute_stop_pos): Ignore a static
6514 composition starting before CHARPOS (Bug#8915).
6516 * xdisp.c (handle_composition_prop): Likewise.
6518 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6520 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6523 2011-07-07 Kenichi Handa <handa@m17n.org>
6525 * character.h (unicode_category_t): New enum type.
6527 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6528 (Qchar_code_property_table): New variable.
6529 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6530 (UNIPROP_COMPRESSED_FORM_P): New macros.
6531 (char_table_ascii): Uncompress the compressed values.
6532 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6533 Uncompress the compressed values.
6534 (sub_char_table_ref_and_range): Likewise.
6535 (char_table_ref_and_range): Uncompress the compressed values.
6536 (sub_char_table_set): New arg is_uniprop. Callers changed.
6537 Uncompress the compressed values.
6538 (sub_char_table_set_range): Args changed. Callers changed.
6539 (char_table_set_range): Adjuted for the above change.
6540 (map_sub_char_table): Delete args default_val and parent. Add arg
6541 top. Give decoded values to a Lisp function.
6542 (map_char_table): Adjust for the above change. Give decoded
6543 values to a Lisp function. Gcpro more variables.
6544 (uniprop_table_uncompress)
6545 (uniprop_decode_value_run_length): New functions.
6546 (uniprop_decoder, uniprop_decoder_count): New variables.
6547 (uniprop_get_decoder, uniprop_encode_value_character)
6548 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6550 (uniprop_encoder, uniprop_encoder_count): New variables.
6551 (uniprop_get_encoder, uniprop_table)
6552 (Funicode_property_table_internal, Fget_unicode_property_internal)
6553 (Fput_unicode_property_internal): New functions.
6554 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6555 Sunicode_property_table_internal, Sget_unicode_property_internal,
6556 and Sput_unicode_property_internal. Defvar_lisp
6557 char-code-property-alist.
6559 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6560 Vunicode_category_table.
6562 * font.c (font_range): Adjust for the change of
6563 Vunicode_category_table.
6565 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6567 * m/iris4d.h: Remove file, move contents ...
6568 * s/irix6-5.h: ... here.
6570 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6572 Remove unportable assumption about struct layout (Bug#8884).
6573 * alloc.c (mark_buffer):
6574 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6575 (clone_per_buffer_values): Don't assume that
6576 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6577 This isn't true in general, and it's particularly not true
6578 if Emacs is configured with --with-wide-int.
6579 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6580 New macros, used in the buffer.c change.
6582 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6584 * xsettings.c: Use both GConf and GSettings if both are available.
6585 (store_config_changed_event): Add comment.
6586 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6587 (store_tool_bar_style_changed): New functions.
6588 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6589 (struct xsettings): Move font inside HAVE_XFT.
6590 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6591 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6592 Move inside HAVE_XFT.
6593 (something_changed_gsettingsCB): Rename from something_changedCB.
6594 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6596 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6597 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6598 (something_changed_gconfCB): Rename from something_changedCB.
6599 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6600 (parse_settings): Move check for font inside HAVE_XFT.
6601 (read_settings, apply_xft_settings): Add comment.
6602 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6603 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6604 call store_font_name_changed.
6605 (xft_settings_event): Add comment.
6606 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6607 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6608 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6609 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6610 (xsettings_initialize): Call init_gsettings last.
6611 (xsettings_get_system_font, xsettings_get_system_normal_font):
6614 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6616 Random fixes. E.g., (random) never returned negative values.
6617 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6618 subseconds part to the entropy, as that's a bit more random.
6619 Prefer signed to unsigned, since the signedness doesn't matter and
6620 in general we prefer signed. When given a limit, use a
6621 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6622 latter isn't right if USE_2_TAGS_FOR_INTS.
6623 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6624 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6626 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6628 * textprop.c (text_property_stickiness):
6629 Obey Vtext_property_default_nonsticky.
6630 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6631 * w32fns.c (syms_of_w32fns):
6632 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6634 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6636 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6637 This is more efficient than Ffile_directory_p and avoids a minor race.
6639 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6641 * buffer.c (Foverlay_put): Say what the return value is
6644 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6645 is a directory before asking whether to use the file name
6647 (barf_or_query_if_file_exists): Make the "File is a directory"
6648 error be more correct.
6650 * fns.c (Frequire): Remove the mention of the .gz files, since
6651 that's installation-specific, but keep the mention of
6652 `get-load-suffixes'.
6654 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6656 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6657 Report string overflow if the output is too long.
6659 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6661 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6662 (syms_of_gnutls): Remove duplicate DEFSYM for
6663 Qgnutls_bootprop_verify_hostname_error, an error for
6664 Qgnutls_bootprop_verify_error (which is no longer used).
6666 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6667 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6668 Also (re)move comments that are misplaced or no longer relevant.
6670 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6672 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6674 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6676 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6677 and background color parameters if they have been changed.
6679 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6681 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6683 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6685 * xsettings.c (SYSTEM_FONT): Define only when used.
6686 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6688 * keymap.c (access_keymap_1): Now static.
6690 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6692 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6693 leave any prefix arg for the up event (Bug#1586).
6695 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6697 * lread.c (syms_of_lread): Mention single symbols defined by
6698 `defvar' or `defconst' (bug#7154).
6700 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6701 (Frequire): Mention get-load-suffixes.
6703 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6705 * window.h (window): Remove clone_number slot.
6706 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6708 (make_parent_window, make_window, saved_window)
6709 (Fset_window_configuration, save_window_save): Don't deal with
6711 * buffer.c (Qclone_number): Remove declaration.
6712 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6714 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6716 Add multiple inheritance to keymaps.
6717 * keymap.c (Fmake_composed_keymap): New function.
6718 (Fset_keymap_parent): Simplify.
6719 (fix_submap_inheritance): Remove.
6720 (access_keymap_1): New function extracted from access_keymap to handle
6721 embedded parents and handle lists of maps.
6722 (access_keymap): Use it.
6723 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6724 (Fcopy_keymap): Handle embedded parents.
6725 (Fcommand_remapping, define_as_prefix): Simplify.
6726 (Fkey_binding): Simplify.
6727 (syms_of_keymap): Move minibuffer-local-completion-map,
6728 minibuffer-local-filename-completion-map,
6729 minibuffer-local-must-match-map, and
6730 minibuffer-local-filename-must-match-map to Elisp.
6731 (syms_of_keymap): Defsubr make-composed-keymap.
6732 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6733 (parse_menu_item): Trivial simplification.
6735 2011-07-01 Glenn Morris <rgm@gnu.org>
6737 * Makefile.in (SETTINGS_LIBS): Fix typo.
6739 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6741 * coding.c (Fencode_coding_string): Record the last coding system
6742 used, as the function doc string says (bug#8738).
6744 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6746 * xsettings.c (store_monospaced_changed): Take new font as arg and
6747 check for change against current_mono_font.
6748 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6749 (emacs_settings_constructor, emacs_settings_get_property)
6750 (emacs_settings_set_property, emacs_settings_class_init)
6751 (emacs_settings_init, gsettings_obj): Remove.
6752 (something_changedCB): New function for HAVE_GSETTINGS.
6753 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6754 with value as argument.
6755 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6756 g_settings_new (Bug#8967). Do not create gsettings_obj.
6757 Remove calls to g_settings_bind. Connect something_changedCB to
6760 * xgselect.c: Add defined (HAVE_GSETTINGS).
6761 (xgselect_initialize): Ditto.
6763 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6764 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6767 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6769 * eval.c (struct backtrace): Simplify and port the data structure.
6770 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6771 signed bit field, as this assumption is not portable and it makes
6772 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6773 "char debug_on_exit : 1" as this is not portable either; instead,
6774 use the portable "unsigned int debug_on_exit : 1". Remove unused
6775 member evalargs. Remove obsolete comments about cc bombing out.
6777 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6779 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6780 Let HAVE_GSETTINGS override HAVE_GCONF.
6781 (store_monospaced_changed): New function.
6782 (EMACS_SETTINGS): A new type derived from GObject to handle
6783 GSettings notifications.
6784 (emacs_settings_constructor, emacs_settings_get_property)
6785 (emacs_settings_set_property, emacs_settings_class_init):
6787 (gsettings_client, gsettings_obj): New variables.
6788 (GSETTINGS_SCHEMA): New define.
6789 (something_changedCB): Call store_monospaced_changed.
6790 (init_gsettings): New function.
6791 (xsettings_initialize): Call init_gsettings.
6792 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6795 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6798 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6800 * window.c (resize_root_window, grow_mini_window)
6801 (shrink_mini_window): Rename Qresize_root_window to
6802 Qwindow_resize_root_window and Qresize_root_window_vertically to
6803 Qwindow_resize_root_window_vertically.
6805 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6807 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6809 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6811 * makefile.w32-in: Redesign dependencies so they reflect more
6812 clearly which files are directly included by each source file,
6813 and not through other includes.
6815 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6817 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6818 (sort_overlays, overlay_strings): When an overlay's clone number
6819 matches the window's clone number process the overlay even if
6820 the overlay's window property doesn't match the current window.
6822 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6823 (Fwindow_hchild): Rename to Fwindow_left_child.
6824 (Fwindow_next): Rename to Fwindow_next_sibling.
6825 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6826 (resize_window_check): Rename to window_resize_check.
6827 (resize_window_apply): Rename to window_resize_apply.
6828 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6829 (Fdelete_other_windows_internal, resize_frame_windows)
6830 (Fsplit_window_internal, Fdelete_window_internal)
6831 (grow_mini_window, shrink_mini_window)
6832 (Fresize_mini_window_internal): Fix callers accordingly.
6834 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6836 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6837 (emacs_fixed_set_min_size): Remove.
6838 (emacs_fixed_new): Take frame as argument.
6840 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6841 (_EmacsFixedPrivate): Remove minwidth/height.
6842 Add struct frame *f.
6843 (emacs_fixed_init): Initialize priv->f.
6844 (get_parent_class, emacs_fixed_set_min_size): Remove.
6845 (emacs_fixed_new): Set priv->f to argument.
6846 (emacs_fixed_get_preferred_width)
6847 (emacs_fixed_get_preferred_height): Use min_width/height from
6848 frames size_hint to set minimum and natural (Bug#8919).
6849 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6850 and use min_width/height from frames size_hint to set
6851 min_width/height (Bug#8919).
6853 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6854 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6857 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6859 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6860 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6863 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6865 * process.c (wait_reading_process_output): Bypass select if
6866 waiting for a cell while ignoring keyboard input, and input is
6867 pending. Suggested by Jan Djärv (Bug#8869).
6869 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6871 Use gnulib's dup2 module instead of rolling our own.
6872 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6874 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6876 * dispnew.c (scrolling_window): Before scrolling, turn off a
6877 mouse-highlight in the window being scrolled.
6879 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6881 Move DEFSYM to lisp.h and use everywhere.
6883 * character.h (DEFSYM): Move declaration...
6884 * lisp.h (DEFSYM): ...here.
6890 * w32select.c: Don't include character.h.
6892 * alloc.c (syms_of_alloc):
6893 * buffer.c (syms_of_buffer):
6894 * bytecode.c (syms_of_bytecode):
6895 * callint.c (syms_of_callint):
6896 * casefiddle.c (syms_of_casefiddle):
6897 * casetab.c (init_casetab_once):
6898 * category.c (init_category_once, syms_of_category):
6899 * ccl.c (syms_of_ccl):
6900 * cmds.c (syms_of_cmds):
6901 * composite.c (syms_of_composite):
6902 * dbusbind.c (syms_of_dbusbind):
6903 * dired.c (syms_of_dired):
6904 * dispnew.c (syms_of_display):
6905 * doc.c (syms_of_doc):
6906 * editfns.c (syms_of_editfns):
6907 * emacs.c (syms_of_emacs):
6908 * eval.c (syms_of_eval):
6909 * fileio.c (syms_of_fileio):
6910 * fns.c (syms_of_fns):
6911 * frame.c (syms_of_frame):
6912 * fringe.c (syms_of_fringe):
6913 * insdel.c (syms_of_insdel):
6914 * keymap.c (syms_of_keymap):
6915 * lread.c (init_obarray, syms_of_lread):
6916 * macros.c (syms_of_macros):
6917 * msdos.c (syms_of_msdos):
6918 * print.c (syms_of_print):
6919 * process.c (syms_of_process):
6920 * search.c (syms_of_search):
6921 * sound.c (syms_of_sound):
6922 * syntax.c (init_syntax_once, syms_of_syntax):
6923 * terminal.c (syms_of_terminal):
6924 * textprop.c (syms_of_textprop):
6925 * undo.c (syms_of_undo):
6926 * w32.c (globals_of_w32):
6927 * window.c (syms_of_window):
6928 * xdisp.c (syms_of_xdisp):
6929 * xfaces.c (syms_of_xfaces):
6930 * xfns.c (syms_of_xfns):
6931 * xmenu.c (syms_of_xmenu):
6932 * xsettings.c (syms_of_xsettings):
6933 * xterm.c (syms_of_xterm): Use DEFSYM.
6935 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6937 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6939 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6941 Integer and buffer overflow fixes (Bug#8873).
6943 * print.c (printchar, strout): Check for string overflow.
6944 (PRINTPREPARE, printchar, strout):
6945 Don't set size unless allocation succeeds.
6947 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6948 for sizes. Check for string overflow more accurately.
6949 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6951 * macros.c: Integer and buffer overflow fixes.
6952 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6953 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6954 Use ptrdiff_t, not int, for sizes.
6955 Don't increment bufsize until after realloc succeeds.
6956 Check for size-calculation overflow.
6957 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6959 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6961 * lread.c: Integer overflow fixes.
6962 (read_integer): Radix is now EMACS_INT, not int,
6963 to improve quality of diagnostics for out-of-range radices.
6964 Calculate buffer size correctly for out-of-range radices.
6965 (read1): Check for integer overflow in radices, and in
6966 read-circle numbers.
6967 (read_escape): Avoid int overflow.
6968 (Fload, openp, read_buffer_size, read1)
6969 (substitute_object_recurse, read_vector, read_list, map_obarray):
6970 Use ptrdiff_t, not int, for sizes.
6971 (read1): Use EMACS_INT, not int, for sizes.
6972 Check for size overflow.
6974 * image.c (cache_image): Check for size arithmetic overflow.
6976 * lread.c: Integer overflow issues.
6977 (saved_doc_string_size, saved_doc_string_length)
6978 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6979 Now ptrdiff_t, not int.
6980 (read1): Don't assume doc string length fits in int. Check for
6981 out-of-range doc string lengths.
6982 (read_list): Don't assume file position fits in int.
6983 (read_escape): Check for hex character overflow.
6985 2011-06-22 Leo Liu <sdl.web@gmail.com>
6987 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6988 Move to minibuffer.el.
6990 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6992 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6993 The following patches are for when GLYPH_DEBUG && !XASSERT.
6994 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6995 * dispnew.c (flush_stdout):
6996 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6997 Mark as externally visible.
6998 * dispnew.c (check_window_matrix_pointers): Now static.
6999 * dispnew.c (window_to_frame_vpos):
7000 * xfns.c (unwind_create_frame):
7001 * xterm.c (x_check_font): Remove unused local.
7002 * scroll.c (CHECK_BOUNDS):
7003 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7004 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7005 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7006 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7007 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7009 (debug_method_add): Use va_list and vsprintf rather than relying
7010 on undefined behavior with wrong number of arguments.
7011 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7012 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7013 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7014 since we're not interested in debugging glyphs with old libraries.
7015 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7016 GCC 4.6.0's static checking.
7018 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7020 Integer overflow and signedness fixes (Bug#8873).
7021 A few related buffer overrun fixes, too.
7023 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7025 * dispextern.h (struct face.stipple):
7026 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7027 (x_bitmap_mask, x_allocate_bitmap_record)
7028 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7029 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7030 (x_create_bitmap_from_xpm_data):
7031 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7032 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7034 * xfaces.c (load_pixmap):
7035 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7036 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7037 (.bitmaps_last, struct x_output.icon_bitmap):
7038 Use ptrdiff_t, not int, for bitmap indexes.
7039 (x_allocate_bitmap_record): Check for size overflow.
7040 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7042 Use ptrdiff_t, not int, for overlay counts.
7043 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7044 * editfns.c (overlays_around, get_pos_property):
7045 * textprop.c (get_char_property_and_overlay):
7046 * xdisp.c (next_overlay_change, note_mouse_highlight):
7047 * xfaces.c (face_at_buffer_position):
7048 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7049 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7050 (Fnext_overlay_change, Fprevious_overlay_change)
7051 (mouse_face_overlay_overlaps, Foverlays_in):
7052 Use ptrdiff_t, not int, for sizes.
7053 (overlays_at, overlays_in): Check for size-calculation overflow.
7055 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7057 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7058 (x_session_initialize): Do not assume string length fits in int.
7060 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7061 This is unlikely, but can occur if DPI is outlandish.
7063 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7064 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7066 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7067 * xrdb.c (magic_file_p, search_magic_path):
7068 Omit last arg SUFFIX; it was always 0. All callers changed.
7069 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7071 * xfont.c (xfont_match): Avoid need for strlen.
7073 * xfns.c: Don't assume strlen fits in int.
7074 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7076 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7077 not unsigned long, as we prefer signed integers. All callers changed.
7078 Detect integer overflow in repeat count.
7079 (message_dolog): Don't assume print length fits in 39 bytes.
7080 (display_mode_element): Don't assume strlen fits in int.
7082 * termcap.c: Don't assume sizes fit in int and never overflow.
7083 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7084 (gobble_line): Check for size-calculation overflow.
7086 * minibuf.c (Fread_buffer):
7087 * lread.c (intern, intern_c_string):
7088 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7089 Don't assume string length fits in int.
7091 * keyboard.c (parse_tool_bar_item):
7092 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7094 * font.c: Don't assume string length fits in int.
7095 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7096 Use ptrdiff_t, not int.
7097 (font_intern_prop): Don't assume string length fits in int.
7098 Don't assume integer property fits in fixnum.
7099 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7101 * filelock.c: Fix some buffer overrun and integer overflow issues.
7102 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7103 Reformulate so as not to need the command string.
7104 Invoke gzip -cd rather than gunzip, as it's more portable.
7105 (lock_info_type, lock_file_1, lock_file):
7106 Don't assume pid_t and time_t fit in unsigned long.
7107 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7108 (current_lock_owner): Prefer signed type for sizes.
7109 Use memcpy, not strncpy, where memcpy is what is really wanted.
7110 Don't assume (via atoi) that time_t and pid_t fit in int.
7111 Check for time_t and/or pid_t out of range, e.g., via a network share.
7112 Don't alloca where an auto var works fine.
7114 * fileio.c: Fix some integer overflow issues.
7115 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7116 Don't assume string length fits in int.
7117 (directory_file_name): Don't assume string length fits in long.
7118 (make_temp_name): Don't assume pid fits in int, or that its print
7119 length is less than 20.
7121 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7123 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7125 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7127 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7128 We prefer signed integers, even for size calculations.
7130 * emacs.c: Don't assume string length fits in 'int'.
7131 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7132 (main): Don't invoke strlen when not needed.
7134 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7135 (XD_DEBUG_MESSAGE): Don't waste a byte.
7137 * callproc.c (getenv_internal_1, getenv_internal)
7139 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7141 * lread.c (invalid_syntax): Omit length argument.
7142 All uses changed. This doesn't fix a bug, but it simplifies the
7143 code away from its former Hollerith-constant appearance, and it's
7144 one less 'int' to worry about when looking at integer-overflow issues.
7145 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7147 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7148 This didn't break anything, but it didn't help either.
7149 It's confusing to put a bogus integer in a place where the actual
7150 value does not matter.
7151 (LIST_END_P): Remove unused macro and its bogus comment.
7152 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7154 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7155 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7157 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7158 We prefer signed types, and the value cannot exceed the EMACS_INT
7159 range anyway (because otherwise the length would not be representable).
7160 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7161 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7162 This avoids a GCC warning when WIDE_EMACS_INT.
7164 * indent.c (sane_tab_width): New function.
7165 (current_column, scan_for_column, Findent_to, position_indentation)
7166 (compute_motion): Use it. This is just for clarity.
7167 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7169 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7171 * lisp.h (lint_assume): New macro.
7172 * composite.c (composition_gstring_put_cache):
7173 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7175 * editfns.c, insdel.c:
7176 Omit unnecessary forward decls, to simplify future changes.
7178 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7180 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7182 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7183 Use much-faster test for byte-length change.
7184 Don't assume string byte-length fits in 'int'.
7185 Check that character arg fits in 'int'.
7186 (mapcar1): Declare byte as byte, for clarity.
7188 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7190 * fns.c (concat): Catch string overflow earlier.
7191 Do not rely on integer wraparound.
7193 * dispextern.h (struct it.overlay_strings_charpos)
7194 (struct it.selective): Now EMACS_INT, not int.
7195 * xdisp.c (forward_to_next_line_start)
7196 (back_to_previous_visible_line_start)
7197 (reseat_at_next_visible_line_start, next_element_from_buffer):
7198 Don't arbitrarily truncate the value of 'selective' to int.
7200 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7202 * composite.c: Don't truncate sizes to 'int'.
7203 (composition_gstring_p, composition_reseat_it)
7204 (composition_adjust_point): Use EMACS_INT, not int.
7205 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7206 not EMACS_UINT, for indexes.
7208 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7210 * buffer.c: Include <verify.h>.
7211 (struct sortvec.priority, struct sortstr.priority):
7212 Now EMACS_INT, not int.
7213 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7214 (struct sortstr.size, record_overlay_string)
7215 (struct sortstrlist.size, struct sortlist.used):
7216 Don't truncate size to int.
7217 (record_overlay_string): Check for size-calculation overflow.
7218 (init_buffer_once): Check at compile-time, not run-time.
7220 2011-06-22 Jim Meyering <meyering@redhat.com>
7222 Don't leak an XBM-image-sized buffer
7223 * image.c (xbm_load): Free the image buffer after using it.
7225 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7228 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7229 that Sun C diagnosed.
7230 * fns.c (secure_hash): Fix pointer signedness issue.
7231 * intervals.c (static_offset_intervals): New function.
7232 (offset_intervals): Use it.
7234 2011-06-21 Leo Liu <sdl.web@gmail.com>
7237 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7240 * fns.c (secure_hash): Rename from crypto_hash_function and change
7241 the first arg to accept symbols.
7242 (Fsecure_hash): New primitive.
7243 (syms_of_fns): New symbols.
7245 2011-06-20 Deniz Dogan <deniz@dogan.se>
7247 * process.c (Fset_process_buffer): Clarify return value in
7250 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7252 * dispnew.c (add_window_display_history): Use BVAR.
7254 * xdisp.c (debug_method_add): Use BVAR.
7255 (check_window_end, dump_glyph_matrix, dump_glyph)
7256 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7258 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7261 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7262 check till after the cache is created in init_frame_faces.
7264 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7266 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7268 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7270 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7271 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7272 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7274 Improve buffer-overflow checking (Bug#8873).
7275 * fileio.c (Finsert_file_contents):
7276 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7277 Remove the old (too-loose) buffer overflow checks.
7278 They weren't needed, since make_gap checks for buffer overflow.
7279 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7280 The old code merely checked for Emacs fixnum overflow, and relied
7281 on undefined (wraparound) behavior. The new code avoids undefined
7282 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7284 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7285 Tune. Don't use wider integers than needed. Don't use alloca.
7286 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7288 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7290 * insdel.c, lisp.h (buffer_overflow): New function.
7291 (insert_from_buffer_1, replace_range, replace_range_2):
7292 * insdel.c (make_gap_larger):
7293 * editfns.c (Finsert_char):
7294 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7296 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7298 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7300 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7302 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7303 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7305 * fileio.c: Don't assume EMACS_INT fits in off_t.
7306 (emacs_lseek): New static function.
7307 (Finsert_file_contents, Fwrite_region): Use it.
7308 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7310 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7312 * fns.c: Don't overflow int when computing a list length.
7313 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7314 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7315 truncation on 64-bit hosts. Check for QUIT every
7316 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7317 faster and is responsive enough.
7318 (Flength): Report an error instead of overflowing an integer.
7319 (Fsafe_length): Return a float if the value is not representable
7320 as a fixnum. This shouldn't happen except in contrived situations.
7321 (Fnthcdr, Fsort): Don't assume list length fits in int.
7322 (Fcopy_sequence): Don't assume vector length fits in int.
7324 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7325 (header_size, word_size): New constants.
7326 (allocate_vectorlike): Don't check size overflow here.
7327 (allocate_vector): Check it here instead, since this is the only
7328 caller of allocate_vectorlike that could cause overflow.
7329 Check that the new vector's length is representable as a fixnum.
7331 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7332 The previous code was bogus. For example, next_almost_prime (32)
7333 returned 39, which is undesirable as it is a multiple of 3; and
7334 next_almost_prime (24) returned 25, which is a multiple of 5 so
7335 why was the code bothering to check for multiples of 7?
7337 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7339 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7341 Variadic C functions now count arguments with ptrdiff_t.
7342 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7343 Back then I didn't know that the Emacs coding style prefers signed int.
7344 Also, in the meantime I found a few more instances where arguments
7345 were being counted with int, which may truncate counts on 64-bit
7346 machines, or EMACS_INT, which may be unnecessarily wide.
7347 * lisp.h (struct Lisp_Subr.function.aMANY)
7348 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7349 Arg counts are now ptrdiff_t, not size_t.
7350 All variadic functions and their callers changed accordingly.
7351 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7352 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7353 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7354 * callint.c (Fcall_interactively): Check arg count for overflow,
7355 to avoid potential buffer overrun. Use signed char, not 'int',
7356 for 'varies' array, so that we needn't bother to check its size
7357 calculation for overflow.
7358 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7359 * eval.c (apply_lambda):
7360 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7361 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7362 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7364 * callint.c (Fcall_interactively): Don't use index var as event count.
7366 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7367 * mem-limits.h (SIZE): Remove; no longer used.
7369 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7371 Remove unnecessary casts.
7372 * xterm.c (x_term_init):
7373 * xfns.c (x_set_border_pixel):
7374 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7375 These aren't needed now that we assume ANSI C.
7377 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7378 It's more likely to cause problems (due to unsigned overflow)
7381 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7383 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7385 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7387 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7389 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7391 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7393 GLYPH_CODE_FACE returns EMACS_INT, not int.
7394 * dispextern.h (merge_faces):
7395 * xfaces.c (merge_faces):
7396 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7397 Don't assume EMACS_INT fits in int.
7399 * character.h (CHAR_VALID_P): Remove unused parameter.
7400 * fontset.c, lisp.h, xdisp.c: All uses changed.
7402 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7404 * fns.c (concat): Minor tuning based on overflow analysis.
7405 This doesn't fix any bugs. Use int to hold character, instead
7406 of constantly refetching from Emacs object. Use XFASTINT, not
7407 XINT, for value known to be a character. Don't bother comparing
7408 a single byte to 0400, as it's always less.
7410 * floatfns.c (Fexpt):
7411 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7413 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7416 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7418 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7419 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7420 incorrectly succeed when S was a string, because 4294967386 was
7421 truncated before it was used.
7423 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7424 Otherwise, an out-of-range integer could cause undefined behavior
7427 * composite.c: Use int, not EMACS_INT, for characters.
7428 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7429 EMACS_INT, for values that are known to be in character range.
7430 This doesn't fix any bugs but is the usual style inside Emacs and
7431 may generate better code on 32-bit machines.
7433 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7434 This is for reasons similar to the recent CHAR_STRING fix.
7435 * charset.c (Fencode_char): Check that character arg is actually
7436 a character. Pass an int to ENCODE_CHAR.
7437 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7438 wider than 'int', as a compile-time check to prevent future regressions
7441 * character.c (char_string): Remove unnecessary casts.
7443 Make sure a 64-bit char is never passed to CHAR_STRING.
7444 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7445 by silently ignoring the top 32 bits, allowing some values
7446 that were far too large to be valid characters.
7447 * character.h: Include <verify.h>.
7448 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7449 arguments are no wider than unsigned, as a compile-time check
7450 to prevent future regressions in this area.
7452 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7453 (Fsubst_char_in_region):
7455 * xdisp.c (decode_mode_spec_coding):
7456 Adjust to CHAR_STRING's new requirement.
7457 * editfns.c (Finsert_char, Fsubst_char_in_region):
7458 * fns.c (concat): Check that character args are actually
7459 characters. Without this test, these functions did the wrong
7460 thing with wildly out-of-range values on 64-bit hosts.
7462 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7463 These casts should not be needed on 32-bit hosts, either.
7464 * keyboard.c (read_char):
7465 * lread.c (Fload): Remove casts to unsigned.
7467 * lisp.h (UNSIGNED_CMP): New macro.
7468 This fixes comparison bugs on 64-bit hosts.
7469 (ASCII_CHAR_P): Use it.
7470 * casefiddle.c (casify_object):
7471 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7472 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7473 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7474 * dispextern.h (FACE_FROM_ID):
7475 * keyboard.c (read_char): Use UNSIGNED_CMP.
7477 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7478 not to EMACS_INT, to avoid GCC warning.
7480 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7482 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7483 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7484 isn't needed on 32-bit machines.
7486 * buffer.c (Fgenerate_new_buffer_name):
7487 Use EMACS_INT for count, not int.
7488 (advance_to_char_boundary): Return EMACS_INT, not int.
7490 * data.c (Qcompiled_function): Now static.
7492 * window.c (window_body_lines): Now static.
7494 * image.c (gif_load): Rename local to avoid shadowing.
7496 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7497 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7498 * alloc.c (make_save_value): Integer argument is now of type
7500 (mark_object): Use ptrdiff_t, not int.
7501 * lisp.h (pD): New macro.
7502 * print.c (print_object): Use it.
7504 * alloc.c: Use EMACS_INT, not int, to count objects.
7505 (total_conses, total_markers, total_symbols, total_vector_size)
7506 (total_free_conses, total_free_markers, total_free_symbols)
7507 (total_free_floats, total_floats, total_free_intervals)
7508 (total_intervals, total_strings, total_free_strings):
7509 Now EMACS_INT, not int. All uses changed.
7510 (Fgarbage_collect): Compute overall total using a double, so that
7511 integer overflow is less likely to be a problem. Check for overflow
7512 when converting back to an integer.
7513 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7514 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7515 These were 'int' variables that could overflow on 64-bit hosts;
7516 they were never used, so remove them instead of repairing them.
7517 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7518 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7519 Previously, this ceilinged at INT_MAX, but that doesn't work on
7521 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7523 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7524 (allocate_vectorlike): Check for ptrdiff_t overflow.
7525 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7526 when a (possibly-narrower) signed value would do just as well.
7527 We prefer using signed arithmetic, to avoid comparison confusion.
7529 * alloc.c: Catch some string size overflows that we were missing.
7530 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7531 for convenience in STRING_BYTES_MAX.
7532 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7533 The definition here is exact; the one in lisp.h was approximate.
7534 (allocate_string_data): Check for string overflow. This catches
7535 some instances we weren't catching before. Also, it catches
7536 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7537 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7538 and ptrdiff_t and EMACS_INT are both 64 bits.
7540 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7541 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7542 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7544 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7546 * alloc.c (Fmake_string): Check for out-of-range init.
7548 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7550 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7552 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7554 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7555 xg_get_default_scrollbar_width.
7557 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7558 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7559 (style_changed_cb): Call update_theme_scrollbar_width and call
7560 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7561 all frames (Bug#8505).
7562 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7563 Call gtk_window_set_resizable if HAVE_GTK3.
7564 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7565 and height if HAVE_GTK3 (Bug#8505).
7566 (scroll_bar_width_for_theme): New variable.
7567 (update_theme_scrollbar_width): New function.
7568 (xg_get_default_scrollbar_width): Move code to
7569 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7570 (xg_initialize): Call update_theme_scrollbar_width.
7572 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7574 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7576 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7578 * frame.c (make_frame): Call other_buffer_safely instead of
7581 * window.c (temp_output_buffer_show): Call display_buffer with
7582 second argument Vtemp_buffer_show_specifiers and reset latter
7583 immediately after the call.
7584 (Vtemp_buffer_show_specifiers): New variable.
7585 (auto_window_vscroll_p, next_screen_context_lines)
7586 (Vscroll_preserve_screen_position): Remove leading asterisks from
7589 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7591 Fix minor problems found by GCC 4.6.0 static checking.
7592 * buffer.c (Qclone_number): Remove for now, as it's unused.
7593 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7594 (record_buffer): Remove unused local.
7595 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7596 (set_frame_buffer_list): Remove; unused.
7597 * frame.h (other_visible_frames): Remove decl.
7598 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7599 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7600 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7602 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7603 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7604 Define only if HAVE_GPM.
7605 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7606 (update_hints_inhibit): Remove; never set. All uses removed.
7607 * widgetprv.h (emacsFrameClassRec): Remove decl.
7608 * window.c (delete_deletable_window): Now returns void, since it
7609 wasn't returning anything.
7610 (compare_window_configurations): Remove unused locals.
7611 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7612 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7613 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7614 the same widths as pointers. This follows up on the 2011-05-06 patch.
7615 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7616 * xterm.h: Likewise.
7617 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7619 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7621 * makefile.w32-in: Update dependencies.
7622 (LISP_H): Add lib/intprops.h.
7624 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7626 * image.c (gif_load): Add animation frame delay to the metadata.
7627 (syms_of_image): Use DEFSYM. New symbol `delay'.
7629 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7631 * window.c (delete_deletable_window): Re-add.
7632 (Fset_window_configuration): Rewrite to handle dead buffers and
7633 consequently deletable windows.
7634 (window_tree, Fwindow_tree): Remove. Supply functionality in
7636 (compare_window_configurations): Simplify code.
7638 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7640 * image.c (imagemagick_load_image): Fix type mismatch.
7641 (Fimagemagick_types): Likewise.
7643 * window.h (replace_buffer_in_windows): Declare.
7645 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7647 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7648 Qclone_number. Remove external declaration of Qdelete_window.
7649 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7651 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7652 Run Qbuffer_list_update_hook if allowed.
7653 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7654 buffer list implementation.
7655 (other_buffer_safely): New function.
7656 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7657 calls to replace_buffer_in_windows and
7658 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7660 (record_buffer): Inhibit quitting and rewrite using quittable
7661 functions. Run Qbuffer_list_update_hook if allowed.
7662 (Frecord_buffer, Funrecord_buffer): New functions.
7663 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7664 Move switch-to-buffer to window.el.
7665 (bury-buffer): Move to window.el.
7666 (Vbuffer_list_update_hook): New variable.
7668 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7671 * window.h (resize_frame_windows): Move up in code.
7672 (Fwindow_frame): Remove EXFUN.
7673 (replace_buffer_in_all_windows): Remove prototype.
7674 (replace_buffer_in_windows_safely): Add prototype.
7676 * window.c: Declare Qdelete_window static again. Move down
7677 declaration of select_count.
7678 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7679 (Fother_window): Move to window.el.
7680 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7681 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7682 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7684 (replace_buffer_in_windows): Implement by calling
7685 Qreplace_buffer_in_windows.
7686 (replace_buffer_in_all_windows): Remove with some functionality
7687 moved into replace_buffer_in_windows_safely.
7688 (replace_buffer_in_windows_safely): New function.
7689 (select_window_norecord, select_frame_norecord): Move in front
7690 of run_window_configuration_change_hook. Remove now obsolete
7692 (Fset_window_buffer): Rewrite doc-string.
7693 Call Qrecord_window_buffer.
7694 (keys_of_window): Move binding for other-window to window.el.
7696 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7698 * dispextern.h (struct image): Replace data member, whose int_val
7699 and ptr_val fields were not used by anything, with a single
7702 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7703 (gif_clear_image, gif_load, imagemagick_load_image)
7704 (gs_clear_image, gs_load): Callers changed.
7706 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7708 * buffer.h: Include <time.h>, for time_t.
7709 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7711 Fix minor problems found by static checking.
7713 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7715 Make identifiers static if they are not used in other modules.
7716 * data.c (Qcompiled_function, Qframe, Qvector):
7717 * image.c (QimageMagick, Qsvg):
7718 * minibuf.c (Qmetadata):
7719 * window.c (resize_window_check, resize_root_window): Now static.
7720 * window.h (resize_window_check, resize_root_window): Remove decls.
7722 * window.c (window_deletion_count, delete_deletable_window):
7724 (window_body_lines): Now static.
7725 (Fdelete_other_windows_internal): Mark vars as initialized.
7726 Make sure 'resize_failed' is initialized.
7727 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7728 (resize_window_apply): Remove unused local.
7729 * window.h (delete_deletable_window): Remove decl.
7731 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7732 (imagemagick_load_image): Fix pointer signedness problem by changing
7733 last arg from unsigned char * to char *. All uses changed.
7734 Also, fix a local for similar reasons.
7735 Remove unused locals. Remove locals to avoid shadowing.
7736 (fn_rsvg_handle_free): Remove; unused.
7737 (svg_load, svg_load_image): Fix pointer signedness problem.
7738 (imagemagick_load_image): Don't use garbage pointer image_wand.
7740 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7742 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7744 * image.c (gif_load): Fix omitted cast error introduced by
7747 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7749 * window.h (resize_proportionally, orig_total_lines)
7750 (orig_top_line): Remove from window structure.
7751 (set_window_height, set_window_width, change_window_heights)
7752 (Fdelete_window): Remove prototypes.
7753 (resize_frame_windows): Remove duplicate declaration.
7755 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7757 * window.h (resize_frame_windows, resize_window_check)
7758 (delete_deletable_window, resize_root_window)
7759 (resize_frame_windows): Declare prototypes.
7761 * window.c (resize_window_apply): Make definition be "static" to
7762 match the prototype.
7764 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7766 * window.c: Remove declarations of Qwindow_size_fixed,
7767 window_min_size_1, window_min_size_2, window_min_size,
7768 size_window, window_fixed_size_p, enlarge_window, delete_window.
7769 Remove static from declaration of Qdelete_window, it's
7770 temporarily needed by Fbury_buffer.
7771 (replace_window): Don't assign orig_top_line and
7773 (Fdelete_window, delete_window): Remove. Window deletion is
7774 handled by window.el.
7775 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7776 Replace Fdelete_window calls with calls to Qdelete_window.
7777 (Fdelete_other_windows): Remove. Deleting other windows is
7778 handled by window.el.
7779 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7780 handled in window.el.
7781 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7782 Window minimum sizes are handled in window.el.
7783 (shrink_windows, size_window, set_window_height)
7784 (set_window_width, change_window_heights, window_height)
7785 (window_width, CURBEG, CURSIZE, enlarge_window)
7786 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7787 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7788 handled in window.el.
7789 (make_dummy_parent): Rename to make_parent_window and give it a
7790 second argument horflag.
7791 (make_window): Don't set resize_proportionally any more.
7792 (Fsplit_window): Remove. Windows are split in window.el.
7793 (save_restore_action, save_restore_orig_size)
7794 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7795 Resize mini windows in window.el.
7796 (grow_mini_window, shrink_mini_window): Implement by calling
7797 Qresize_root_window_vertically, resize_window_check and
7798 resize_window_apply.
7799 (saved_window, Fset_window_configuration, save_window_save):
7800 Do not handle orig_top_line, orig_total_lines, and
7801 resize_proportionally.
7802 (window_min_height, window_min_width): Move to window.el.
7803 (keys_of_window): Move bindings for delete-other-windows,
7804 split-window, delete-window and enlarge-window to window.el.
7806 * buffer.c: Temporarily extern Qdelete_window.
7807 (Fbury_buffer): Temporarily call Qdelete_window instead of
7808 Fdelete_window (Fbury_buffer will move to window.el soon).
7810 * frame.c (set_menu_bar_lines_1): Remove code handling
7811 orig_top_line and orig_total_lines.
7813 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7814 set_window_height but set heights directly.
7815 (change_frame_size_1): Use resize_frame_windows.
7817 * xdisp.c (init_xdisp): Don't use set_window_height but set
7820 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7821 Use resize_frame_windows instead of change_window_heights and run
7822 run_window_configuration_change_hook.
7824 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7825 instead of change_window_heights and run
7826 run_window_configuration_change_hook.
7828 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7830 * window.c (replace_window): Rename second argument REPLACEMENT to
7831 NEW. New third argument SETFLAG. Rewrite.
7832 (delete_window, make_dummy_parent): Call replace_window with
7834 (window_list_1): Move down in code.
7835 (run_window_configuration_change_hook): Move set_buffer part
7836 before select_frame_norecord part in order to unwind correctly.
7837 Rename count1 to count.
7838 (recombine_windows, delete_deletable_window, resize_root_window)
7839 (Fdelete_other_windows_internal)
7840 (Frun_window_configuration_change_hook, make_parent_window)
7841 (resize_window_check, resize_window_apply, Fresize_window_apply)
7842 (resize_frame_windows, Fsplit_window_internal)
7843 (Fdelete_window_internal, Fresize_mini_window_internal):
7845 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7847 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7849 * window.h (window): Add some new members to window structure -
7850 normal_lines, normal_cols, new_total, new_normal, clone_number,
7851 splits, nest, prev_buffers, next_buffers.
7852 (WINDOW_TOTAL_SIZE): Move here from window.c.
7853 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7855 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7857 (make_dummy_parent): Set new members of windows structure.
7858 (make_window): Move down in code. Handle new members of window
7860 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7861 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7862 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7863 (Fset_window_prev_buffers, Fwindow_next_buffers)
7864 (Fset_window_next_buffers, Fset_window_clone_number):
7866 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7867 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7869 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7870 Argument WINDOW can be now internal window too.
7871 (Fwindow_use_time): Move up in code.
7872 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7874 (Fset_window_configuration, saved_window)
7875 (Fcurrent_window_configuration, save_window_save): Handle new
7876 members of window structure.
7877 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7878 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7879 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7880 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7881 Qget_mru_window, Qresize_root_window,
7882 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7883 Qauto_buffer_name; staticpro them.
7885 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7887 * window.c (Fwindow_total_size, Fwindow_left_column)
7888 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7889 (Fwindow_list_1): New functions.
7890 (window_box_text_cols): Replace with window_body_cols.
7891 (Fwindow_width, Fscroll_left, Fscroll_right):
7892 Use window_body_cols instead of window_box_text_cols.
7893 (delete_window, Fset_window_configuration):
7894 Call delete_all_subwindows with window as argument.
7895 (delete_all_subwindows): Take a window as argument and not a
7897 (window_loop): Remove handling of GET_LRU_WINDOW and
7899 (Fget_lru_window, Fget_largest_window): Move to window.el.
7901 * window.h: Extern window_body_cols instead of
7902 window_box_text_cols. delete_all_subwindows now takes a
7903 Lisp_Object as argument.
7905 * indent.c (compute_motion, Fcompute_motion):
7906 Use window_body_cols instead of window_box_text_cols.
7908 * frame.c (delete_frame): Call delete_all_subwindows with root
7911 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7913 * fns.c (Fputhash): Document return value.
7915 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7917 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7919 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7921 Cons<->int and similar integer overflow fixes (Bug#8794).
7923 Check for overflow when converting integer to cons and back.
7924 * charset.c (Fdefine_charset_internal, Fdecode_char):
7925 Use cons_to_unsigned to catch overflow.
7926 (Fencode_char): Use INTEGER_TO_CONS.
7927 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7928 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7929 * data.c (long_to_cons, cons_to_long): Remove.
7930 (cons_to_unsigned, cons_to_signed): New functions.
7931 These signal an error for invalid or out-of-range values.
7932 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7933 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7934 * font.c (Ffont_variation_glyphs):
7935 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7936 * lisp.h: Include <intprops.h>.
7937 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7938 (cons_to_signed, cons_to_unsigned): New decls.
7939 (long_to_cons, cons_to_long): Remove decls.
7940 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7941 (Fprimitive_undo): Use CONS_TO_INTEGER.
7942 * xfns.c (Fx_window_property): Likewise.
7943 * xselect.c: Include <limits.h>.
7944 (x_own_selection, selection_data_to_lisp_data):
7945 Use INTEGER_TO_CONS.
7946 (x_handle_selection_request, x_handle_selection_clear)
7947 (x_get_foreign_selection, Fx_disown_selection_internal)
7948 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7949 (lisp_data_to_selection_data): Use cons_to_unsigned.
7950 (x_fill_property_data): Use cons_to_signed.
7951 Report values out of range.
7953 Check for buffer and string overflow more precisely.
7954 * buffer.h (BUF_BYTES_MAX): New macro.
7955 * lisp.h (STRING_BYTES_MAX): New macro.
7956 * alloc.c (Fmake_string):
7957 * character.c (string_escape_byte8):
7958 * coding.c (coding_alloc_by_realloc):
7959 * doprnt.c (doprnt):
7960 * editfns.c (Fformat):
7962 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7963 since they may not be the same number.
7964 * editfns.c (Finsert_char):
7965 * fileio.c (Finsert_file_contents):
7966 Likewise for BUF_BYTES_MAX.
7968 * image.c: Use ptrdiff_t, not int, for sizes.
7969 (slurp_file): Switch from int to ptrdiff_t.
7971 (slurp_file): Check that file size fits in both size_t (for
7972 malloc) and ptrdiff_t (for sanity and safety).
7974 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7975 if b->modtime has its maximal value.
7977 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7979 Don't assume time_t can fit into int.
7980 * buffer.h (struct buffer.modtime): Now time_t, not int.
7981 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7982 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7984 Minor fixes for signed vs unsigned integers.
7985 * character.h (MAYBE_UNIFY_CHAR):
7986 * charset.c (maybe_unify_char):
7987 * keyboard.c (read_char, reorder_modifiers):
7988 XINT -> XFASTINT, since the integer must be nonnegative.
7989 * ftfont.c (ftfont_spec_pattern):
7990 * keymap.c (access_keymap, silly_event_symbol_error):
7991 XUINT -> XFASTINT, since the integer must be nonnegative.
7992 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7993 since it makes no difference and we prefer signed.
7994 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7995 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7998 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8000 * window.h (Fwindow_frame): Declare.
8002 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8004 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8005 (SPARE_MEMORY): Always define.
8006 (LARGE_REQUEST): Remove.
8007 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8009 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8011 * lisp.h: Move EXFUNS for Fframe_root_window,
8012 Fframe_first_window and Fset_frame_selected_window to window.h.
8014 * window.h: Move EXFUNS for Fframe_root_window,
8015 Fframe_first_window and Fset_frame_selected_window here from
8018 * frame.c (Fwindow_frame, Fframe_first_window)
8019 (Fframe_root_window, Fframe_selected_window)
8020 (Fset_frame_selected_window): Move to window.c.
8021 (Factive_minibuffer_window): Move to minibuf.c.
8022 (Fother_visible_frames_p): New function.
8024 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8026 * window.c (decode_window, decode_any_window): Move up in code.
8027 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8028 (inhibit_frame_unsplittable): Remove unused variable.
8029 (Fwindow_buffer): Move up and rewrite doc-string.
8030 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8031 (Fwindow_prev): New functions.
8032 (Fwindow_frame): Move here from frame.c. Accept any window as
8034 (Fframe_root_window, Fframe_first_window)
8035 (Fframe_selected_window): Move here from frame.c. Accept frame
8036 or arbitrary window as argument. Update doc-strings.
8037 (Fminibuffer_window): Move up in code.
8038 (Fwindow_minibuffer_p): Move up in code and simplify.
8039 (Fset_frame_selected_window): Move here from frame.c.
8041 (Fselected_window, select_window, Fselect_window): Move up in
8042 code. Minor doc-string fixes.
8044 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8046 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8047 Do not assume that spare memory exists; that assumption is valid
8048 only if SYSTEM_MALLOC.
8049 (LARGE_REQUEST): New macro, so that the issue of large requests
8050 is separated from the issue of spare memory.
8052 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8054 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8057 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8059 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8062 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8064 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8066 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8068 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8069 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8071 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8073 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8075 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8077 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8078 (x_clipboard_manager_save): Add return value.
8079 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8081 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8082 Obey Vx_select_enable_clipboard_manager. Catch errors in
8083 x_clipboard_manager_save (Bug#8779).
8084 (Vx_select_enable_clipboard_manager): New variable.
8085 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8087 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8089 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8091 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8093 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8094 in the current matrix if keep_current_p is non-zero.
8096 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8098 * bidi.c (bidi_level_of_next_char): Fix last change.
8100 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8102 Support bidi reordering of text covered by display properties.
8104 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8105 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8106 (bidi_cache_search, bidi_cache_iterator_state)
8107 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8108 (bidi_level_of_next_char, bidi_move_to_visually_next):
8109 Support character positions inside a run of characters covered by a
8111 (bidi_paragraph_init, bidi_resolve_explicit_1)
8112 (bidi_level_of_next_char): Call bidi_fetch_char and
8113 bidi_fetch_char_advance instead of FETCH_CHAR and
8115 (bidi_init_it): Initialize new members.
8116 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8118 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8119 instead of using explicit *_CHAR codes.
8120 (bidi_resolve_explicit, bidi_resolve_weak):
8121 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8122 bidirectional text is supported only in multibyte buffers.
8123 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8124 it to initialize the frame_window_p member of struct bidi_it.
8125 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8126 (bidi_resolve_explicit, bidi_resolve_weak)
8127 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8128 bidi_it->nchars is non-positive.
8129 (bidi_level_of_next_char): Don't try to lookup the cache for the
8130 next/previous character if nothing is cached there yet, or if we
8131 were just reseat()'ed to a new position.
8133 * xdisp.c (set_cursor_from_row): Set start and stop points
8134 according to the row's direction when priming the loop that looks
8135 for the glyph on which to display cursor.
8136 (single_display_spec_intangible_p): Function deleted.
8137 (display_prop_intangible_p): Reimplement to call
8138 handle_display_spec instead of single_display_spec_intangible_p.
8139 Accept 3 additional arguments needed by handle_display_spec.
8140 This fixes incorrect cursor motion across display property with complex
8141 values: lists, `(when COND...)' forms, etc.
8142 (single_display_spec_string_p): Support property values that are
8143 lists with the argument STRING its top-level element.
8144 (display_prop_string_p): Fix the condition for processing a
8145 property that is a list to be consistent with handle_display_spec.
8146 (handle_display_spec): New function, refactored from the
8147 last portion of handle_display_prop.
8148 (compute_display_string_pos): Accept additional argument
8149 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8150 value of a `display' property is a "replacing spec".
8151 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8152 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8153 the display property, but just return a value indicating whether
8154 the display property will replace the characters it covers.
8155 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8156 frame_window_p members of struct bidi_it.
8157 (compute_display_string_pos, compute_display_string_end):
8159 (push_it): Accept second argument POSITION, where pop_it should
8160 jump to continue iteration.
8161 (reseat_1): Initialize bidi_it.disp_pos.
8163 * keyboard.c (adjust_point_for_property): Adjust the call to
8164 display_prop_intangible_p to its new signature.
8166 * dispextern.h (struct bidi_it): New member frame_window_p.
8167 (bidi_init_it): Update prototypes.
8168 (display_prop_intangible_p): Update prototype.
8169 (compute_display_string_pos, compute_display_string_end):
8171 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8174 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8176 Malloc failure behavior now depends on size of allocation.
8177 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8178 * lisp.h: Change signatures accordingly.
8179 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8180 All callers changed. (Bug#8762)
8182 * gnutls.c: Use Emacs's memory allocators.
8183 Without this change, the gnutls library would invoke malloc etc.
8184 directly, which causes problems on non-SYNC_INPUT hosts, and which
8185 runs afoul of improving memory_full behavior. (Bug#8761)
8186 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8187 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8188 xfree instead of the default malloc, realloc, free.
8189 (Fgnutls_boot): No need to check for memory allocation failure,
8190 since xmalloc does that for us.
8192 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8193 * category.c (hash_get_category_set):
8194 * ccl.c (ccl_driver):
8195 * charset.c (Fdefine_charset_internal):
8196 * charset.h (struct charset.hash_index):
8197 * composite.c (get_composition_id, gstring_lookup_cache)
8198 (composition_gstring_put_cache):
8199 * composite.h (struct composition.hash_index):
8200 * dispextern.h (struct image.hash):
8201 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8202 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8203 (hashfn_equal, hashfn_user_defined, make_hash_table)
8204 (maybe_resize_hash_table, hash_lookup, hash_put)
8205 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8206 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8207 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8208 * image.c (make_image, search_image_cache, lookup_image)
8209 (xpm_put_color_table_h):
8210 * lisp.h (struct Lisp_Hash_Table):
8211 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8212 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8213 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8214 * alloc.c (allocate_vectorlike):
8215 Check for overflow in vector size calculations.
8216 * ccl.c (ccl_driver):
8217 Check for overflow when converting EMACS_INT to int.
8218 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8219 need to be updated by these changes.
8220 * fns.c (make_hash_table, maybe_resize_hash_table):
8221 Check for integer overflow with large hash tables.
8222 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8223 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8224 (SXHASH_REDUCE): New macro.
8225 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8226 Use it instead of discarding useful hash info with large hash values.
8227 (sxhash_float): New function.
8228 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8229 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8230 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8231 Rewrite to use FIXNUM_BITS, as this simplifies things.
8232 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8233 Adjust signatures to match updated version of code.
8234 (consing_since_gc): Now EMACS_INT, since a single hash table can
8235 use more than INT_MAX bytes.
8237 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8239 Make it possible to build with GCC-4.6+ -O2 -flto.
8241 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8243 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8245 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8246 Call minibuffer-inactive-mode.
8248 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8250 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8251 Update dependencies.
8253 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8255 * data.c (init_data): Remove code for UTS, this system is not
8258 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8260 Don't force ./temacs to start in terminal mode.
8262 * frame.c (make_initial_frame): Initialize faces in all cases, not
8263 only when CANNOT_DUMP is defined.
8264 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8266 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8268 * dispnew.c (add_window_display_history): Use const for the string
8269 pointer. Remove declaration, not needed.
8271 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8273 Use 'inline', not 'INLINE'.
8274 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8275 * alloc.c, fontset.c (INLINE): Remove.
8276 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8277 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8278 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8279 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8280 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8282 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8284 Make it possible to run ./temacs.
8286 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8287 syms_of_callproc does the same thing. Remove test for
8288 "initialized", do it in the caller.
8289 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8291 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8293 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8294 (read_minibuf): Use get_minibuffer.
8295 (syms_of_minibuf): Use DEFSYM.
8296 (Qmetadata): New var.
8297 * data.c (Qbuffer): Don't make it static.
8298 (syms_of_data): Use DEFSYM.
8300 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8302 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8303 (CCL_CODE_MIN): New macro.
8305 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8307 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8309 * eval.c (Qdebug): Now static.
8310 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8311 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8312 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8314 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8316 * image.c: Various fixes to ImageMagick code comments.
8317 (Fimagemagick_types): Doc fix.
8319 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8321 Minor fixes prompted by GCC 4.6.0 warnings.
8323 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8325 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8326 (x_clipboard_manager_save_all): Move extern decl to ...
8327 * xterm.h: ... here, so that it can be checked for consistency.
8329 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8331 * xselect.c (x_clipboard_manager_save_frame)
8332 (x_clipboard_manager_save_all): New functions.
8333 (Fx_clipboard_manager_save): Lisp function deleted.
8335 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8336 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8338 * xterm.h: Update prototype.
8340 2011-05-28 William Xu <william.xwl@gmail.com>
8342 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8345 2011-05-28 Jim Meyering <meyering@redhat.com>
8347 Avoid a sign-extension bug in crypto_hash_function.
8348 * fns.c (to_uchar): Define.
8349 (crypto_hash_function): Use it to convert some newly-signed
8350 variables to unsigned, to avoid sign-extension bugs. For example,
8351 without this change, (md5 "truc") would evaluate to
8352 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8353 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8354 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8356 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8358 Integer overflow fixes.
8360 * dbusbind.c: Serial number integer overflow fixes.
8361 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8362 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8363 to hold a serial number that is too large for a fixnum.
8364 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8365 Check for serial numbers out of range. Decode any serial number
8366 that was so large that it became a float. (Bug#8722)
8368 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8369 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8370 Use XFASTINT rather than XUINT when numbers are nonnegative.
8371 (xd_append_arg, Fdbus_method_return_internal):
8372 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8373 arguments, check that Lisp number is nonnegative, rather than
8374 silently wrapping negative numbers around. (Bug#8722)
8375 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8378 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8380 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8382 ccl: Add integer overflow checks.
8383 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8384 (IN_INT_RANGE): New macros.
8385 (ccl_driver): Use them to check for integer overflow when
8386 decoding a CCL program. Many of the new checks are whether XINT (x)
8387 fits in int; it doesn't always, on 64-bit hosts. The new version
8388 doesn't catch all possible integer overflows, but it's an
8389 improvement. (Bug#8719)
8391 * alloc.c (make_event_array): Use XINT, not XUINT.
8392 There's no need for unsigned here.
8394 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8395 This follows up to the 2011-05-06 change that substituted uintptr_t
8396 for EMACS_INT. This case wasn't caught back then.
8398 Rework Fformat to avoid integer overflow issues.
8399 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8400 now (part of C89). Include <verify.h>.
8401 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8402 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8403 (Fformat): Avoid the prepass trying to compute sizes; it was only
8404 approximate and thus did not catch overflow reliably. Instead, walk
8405 through the format just once, formatting and computing sizes as we go,
8406 checking for integer overflow at every step, and allocating a larger
8407 buffer as needed. Keep track separately whether the format is
8408 multibyte. Keep only the most-recently calculated precision, rather
8409 than them all. Record whether each argument has been converted to
8410 string. Use EMACS_INT, not int, for byte and char and arg counts.
8411 Support field widths and precisions larger than INT_MAX. Avoid
8412 sprintf's undefined behavior with conversion specifications such as %#d
8413 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8414 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8415 formatting out-of-range floating point numbers with int
8418 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8420 * data.c: Avoid integer truncation in expressions involving floats.
8421 * data.c: Include <intprops.h>.
8422 (arith_driver): When there's an integer overflow in an expression
8423 involving floating point, convert the integers to floating point
8424 so that the resulting value does not suffer from catastrophic
8425 integer truncation. For example, on a 64-bit host (* 4
8426 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8427 Do not rely on undefined behavior after integer overflow.
8429 merge count_size_as_multibyte, parse_str_to_multibyte
8430 * character.c, character.h (count_size_as_multibyte):
8431 Rename from parse_str_to_multibyte; all uses changed.
8432 Check for integer overflow.
8433 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8434 since it's now a duplicate of the other. This is more of
8435 a character than a buffer op, so better that it's in character.c.
8436 * fns.c, print.c: Adjust to above changes.
8438 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8440 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8442 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8444 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8445 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8446 (x_clipboard_manager_save): Now static.
8447 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8449 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8450 (crypto_hash_function): Now static.
8451 Fix pointer signedness problems. Avoid unnecessary initializations.
8453 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8455 * termhooks.h (Vselection_alist): Make it terminal-local.
8457 * terminal.c (create_terminal): Initialize it.
8459 * xselect.c: Support for clipboard managers.
8460 (Vselection_alist): Move to termhooks.h as terminal-local var.
8461 (LOCAL_SELECTION): New macro.
8462 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8463 (symbol_to_x_atom): Remove gratuitous arg.
8464 (x_handle_selection_request, lisp_data_to_selection_data)
8465 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8466 (x_own_selection, x_get_local_selection, x_convert_selection):
8467 New arg, specifying work frame. Use terminal-local Vselection_alist.
8468 (some_frame_on_display): Delete unused function.
8469 (Fx_own_selection_internal, Fx_get_selection_internal)
8470 (Fx_disown_selection_internal, Fx_selection_owner_p)
8471 (Fx_selection_exists_p): New optional frame arg.
8472 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8473 (x_handle_selection_clear): Don't treat other terminals with the
8474 same keyboard specially. Use the terminal-local Vselection_alist.
8475 (x_clear_frame_selections): Use Frun_hook_with_args.
8477 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8479 * xterm.h: Add support for those atoms.
8481 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8483 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8484 (converted_selections, conversion_fail_tag): New global variables.
8485 (x_selection_request_lisp_error): Free the above.
8486 (x_get_local_selection): Remove unnecessary code.
8487 (x_reply_selection_request): Args changed; handle arbitrary array
8488 of converted selections stored in converted_selections.
8489 Separate the XChangeProperty and SelectionNotify steps.
8490 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8491 (x_convert_selection): New function.
8492 (x_handle_selection_event): Simplify.
8493 (x_get_foreign_selection): Don't ignore incoming requests while
8494 waiting for an answer; this will fail when we implement
8495 SAVE_TARGETS, and seems unnecessary anyway.
8496 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8497 (Vx_sent_selection_functions): Doc fix.
8499 2011-05-26 Leo Liu <sdl.web@gmail.com>
8501 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8503 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8505 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8507 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8508 for fringe update if it has periodic bitmap.
8509 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8510 and fringe_bitmap_periodic_p.
8512 * fringe.c (get_fringe_bitmap_data): New function.
8513 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8514 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8515 row. Mark glyph row for fringe update if periodicity changed.
8517 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8518 for fringe update unless it has periodic bitmap.
8520 2011-05-25 Kenichi Handa <handa@m17n.org>
8522 * xdisp.c (get_next_display_element): Set correct it->face_id for
8523 a static composition.
8525 2011-05-24 Leo Liu <sdl.web@gmail.com>
8528 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8530 * fns.c (crypto_hash_function, Fsha1): New function.
8531 (Fmd5): Use crypto_hash_function.
8532 (syms_of_fns): Add Ssha1.
8534 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8536 * gnutls.c: Remove unused macros.
8537 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8538 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8539 Remove macros that are defined and never used.
8540 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8542 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8544 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8545 (Fx_get_selection_internal): Minor cleanup.
8546 (Fx_own_selection_internal): Rename arguments for consistency with
8549 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8551 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8553 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8555 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8557 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8559 * dispnew.c (scrolling_window): Don't exclude the case that the
8560 last enabled row in the desired matrix touches the bottom boundary.
8562 2011-05-21 Glenn Morris <rgm@gnu.org>
8564 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8565 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8566 and add some more files.
8568 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8570 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8571 report_file_error introduced by the change from 2011-05-07.
8573 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8575 * systime.h (Time): Define only if emacs is defined.
8576 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8577 where the include path doesn't have X11/X.h by default. See
8578 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8580 2011-05-20 Kenichi Handa <handa@m17n.org>
8582 * composite.c (find_automatic_composition): Fix previous change.
8584 2011-05-20 Glenn Morris <rgm@gnu.org>
8586 * lisp.mk: New file, split from Makefile.in.
8587 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8588 (shortlisp): Remove.
8589 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8591 2011-05-19 Glenn Morris <rgm@gnu.org>
8593 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8594 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8595 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8596 (lisp): Set the order to that of loadup.el.
8597 (shortlisp): Make it a copy of $lisp.
8598 (SOME_MACHINE_LISP): Remove.
8599 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8600 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8602 2011-05-18 Kenichi Handa <handa@m17n.org>
8604 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8605 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8606 (find_automatic_composition): Mostly rewrite for efficiency.
8608 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8610 * makefile.w32-in: Update dependencies.
8612 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8614 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8615 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8617 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8619 Fix some integer overflow issues, such as string length overflow.
8621 * insdel.c (count_size_as_multibyte): Check for string overflow.
8623 * character.c (lisp_string_width): Check for string overflow.
8624 Use EMACS_INT, not int, for string indexes and lengths; in
8625 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8626 the resulting string length overflows an EMACS_INT; instead,
8627 report a string overflow if no precision given. When checking for
8628 precision exhaustion, use a check that cannot possibly have
8629 integer overflow. (Bug#8675)
8630 * character.h (lisp_string_width): Adjust to new signature.
8632 * alloc.c (string_overflow): New function.
8633 (Fmake_string): Use it. This doesn't change behavior, but saves
8634 a few bytes and will simplify future changes.
8635 * character.c (string_escape_byte8): Likewise.
8636 * lisp.h (string_overflow): New decl.
8638 Fixups, following up to the user-interface timestamp change.
8639 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8640 for UI timestamps, instead of unsigned long.
8641 * msdos.c (mouse_get_pos): Likewise.
8642 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8643 * w32gui.h (Time): Define by including "systime.h" rather than by
8644 declaring it ourselves. (Bug#8664)
8646 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8647 * image.c (clear_image_cache): Likewise.
8649 * term.c (term_mouse_position): Don't assume time_t wraparound.
8651 Be more systematic about user-interface timestamps.
8652 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8653 and sometimes 'EMACS_UINT', to represent these timestamps.
8654 This change causes it to use 'Time' uniformly, as that's what X uses.
8655 This makes the code easier to follow, and makes it easier to catch
8656 integer overflow bugs such as Bug#8664.
8657 * frame.c (Fmouse_position, Fmouse_pixel_position):
8658 Use Time, not unsigned long, for user-interface timestamps.
8659 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8660 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8661 * keyboard.h (last_event_timestamp): Likewise.
8662 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8663 * menu.h (xmenu_show): Likewise.
8664 * term.c (term_mouse_position): Likewise.
8665 * termhooks.h (struct input_event.timestamp): Likewise.
8666 (struct terminal.mouse_position_hook): Likewise.
8667 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8668 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8669 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8670 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8672 * menu.h, termhooks.h: Include "systime.h", for Time.
8674 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8675 Don't assume that the difference between two unsigned long values
8676 can fit into an integer. At this point, we know button_down_time
8677 <= event->timestamp, so the difference must be nonnegative, so
8678 there's no need to cast the result if double-click-time is
8679 nonnegative, as it should be; check that it's nonnegative, just in
8680 case. This bug is triggered when events are more than 2**31 ms
8681 apart (about 25 days). (Bug#8664)
8683 * xselect.c (last_event_timestamp): Remove duplicate decl.
8684 (x_own_selection): Remove needless cast to unsigned long.
8686 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8687 that always fit in int. Use a sentinel instead of a counter, to
8688 avoid a temp and to allay GCC's concerns about possible int overflow.
8689 * frame.h (struct frame): Use int for menu_bar_items_used
8690 instead of EMACS_INT, since it always fits in int.
8692 * menu.c (grow_menu_items): Check for int overflow.
8694 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8696 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8697 Before, the code was not consistent. These values cannot exceed
8698 2**31 - 1 so there's no need to make them unsigned.
8699 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8700 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8701 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8703 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8705 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8706 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8707 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8708 presumably because the widths might not match.
8710 * window.c (size_window): Avoid needless test at loop start.
8712 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8714 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8716 2011-05-12 Drew Adams <drew.adams@oracle.com>
8718 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8720 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8722 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8723 `width' to `bar_area_x' and `bar_area_width', respectively.
8724 (x_scroll_run): Take account of fringe background extension.
8726 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8727 Rename local vars `left' and `width' to `bar_area_x' and
8728 `bar_area_width', respectively.
8729 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8730 background extension.
8732 2011-05-10 Jim Meyering <meyering@redhat.com>
8734 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8736 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8738 * image.c (Finit_image_library): Return t for built-in image types,
8739 like pbm and xbm. (Bug#8640)
8741 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8743 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8745 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8747 * w32console.c (Fset_screen_color): Doc fix.
8748 (Fget_screen_color): New function.
8749 (syms_of_ntterm): Defsubr it.
8751 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8752 unlink the temporary file if Fcall_process didn't create it in the
8754 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8755 child process will be redirected to a file specified with `:file'.
8756 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8757 cue to call_process_cleanup not to close that handle.
8759 2011-05-07 Ben Key <bkey76@gmail.com>
8761 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8762 one of two shell specific rules, either bootstrap-temacs-CMD or
8763 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8764 to the previous implementation of the bootstrap-temacs rule.
8765 The bootstrap-temacs-CMD rule is similar to the previous
8766 implementation of the bootstrap-temacs rule except that it
8767 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8770 These changes, along with some changes to nt/configure.bat,
8771 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8772 earlier fix to add support for --cflags and --ldflags options
8773 that include quotes so that it works whether make uses cmd or
8776 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8778 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8779 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8781 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8782 a string. Handle both cases.
8783 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8784 (Fdbus_register_method): Use Qinvalid_function.
8786 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8788 * makefile.w32-in: Update dependencies.
8789 (LISP_H): Add inttypes.h and stdin.h.
8790 (PROCESS_H): Add unistd.h.
8792 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8794 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8795 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8797 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8799 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8801 * term.c (vfatal): Remove stray call to va_end.
8802 It's not needed and the C Standard doesn't allow it here anyway.
8804 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8805 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8807 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8810 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8812 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8814 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8816 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8818 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8820 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8821 * charset.c (Fdefine_charset_internal): Don't initialize
8822 charset.code_space[15]. The value was garbage, on hosts with
8823 32-bit int (Bug#8600).
8825 * lread.c (read_integer): Be more consistent with string-to-number.
8826 Use string_to_number to do the actual conversion; this avoids
8827 rounding errors and fixes some other screwups. Without this fix,
8828 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8829 (digit_to_number): Move earlier, for benefit of read_integer.
8830 Return -1 if the digit is out of range for the base, -2 if it is
8831 not a digit in any supported base. (Bug#8602)
8833 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8835 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8836 to match comment at start of function. This also removes a
8837 GCC warning about overflow in a 32+64-bit port.
8839 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8841 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8842 Reported by Stefan Monnier in
8843 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8844 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8845 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8847 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8848 (EMACS_UINTPTR): Likewise, with uintptr_t.
8850 * lisp.h: Prefer 64-bit EMACS_INT if available.
8851 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8852 on 32-bit hosts that have 64-bit int, so that they can access
8854 However, temporarily disable this change unless the temporary
8855 symbol WIDE_EMACS_INT is defined.
8857 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8859 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8860 This removes an assumption that EMACS_INT and long are the same
8861 width as pointers. The assumption is true for Emacs porting targets
8862 now, but we want to make other targets possible.
8863 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8864 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8865 In the rest of the code, change types of integers that hold casted
8866 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8867 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8868 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8869 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8870 No need to cast type when ORing.
8871 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8872 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8873 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8874 assume EMACS_INT is the same width as char *.
8875 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8876 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8877 Remove no-longer-needed casts.
8878 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8879 (xg_tool_bar_help_callback, xg_make_tool_item):
8880 Use EMACS_INTPTR to hold an integer
8881 that will be cast to void *; this can avoid a GCC warning
8882 if EMACS_INT is not the same width as void *.
8883 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8884 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8885 (current_message_1, set_message_1):
8886 Use a local to convert to proper width without a cast.
8887 * xmenu.c (dialog_selection_callback): Likewise.
8889 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8890 Also, don't assume VALBITS / RAND_BITS is less than 5,
8891 and don't rely on undefined behavior when shifting a 1 left into
8893 * lisp.h (get_random): Change signature to match.
8895 * lread.c (hash_string): Use size_t, not int, for hash computation.
8896 Normally we prefer signed values; but hashing is special, because
8897 it's better to use unsigned division on hash table sizes so that
8898 the remainder is nonnegative. Also, size_t is the natural width
8899 for hashing into memory. The previous code used 'int', which doesn't
8900 retain enough info to hash well into very large tables.
8901 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8903 * dbusbind.c: Don't possibly lose pointer info when converting.
8904 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8905 Use XPNTR rather than XHASH, so that the high-order bits of
8906 the pointer aren't lost when converting through void *.
8908 * eval.c (Fautoload): Don't double-shift a pointer.
8910 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8912 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8914 * gnutls.c (DEF_GNUTLS_FN):
8915 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8917 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8919 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8922 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8924 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8925 New version that can reserve upto 2GB of heap space.
8927 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8929 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8931 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8933 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8934 `gnutls_certificate_set_x509_key_file'.
8936 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8938 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8939 Update dependencies.
8941 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8943 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8944 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8945 Remove unused parameter `fildes'.
8946 * process.c (read_process_output, send_process): Don't pass it.
8948 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8950 Fix previous change: the library cache is defined in w32.c.
8951 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8952 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8954 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8956 Implement dynamic loading of GnuTLS on Windows.
8958 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8959 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8960 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8963 * gnutls.c (Qgnutls_dll): Define.
8964 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8965 (gnutls_*): Declare function pointers.
8966 (init_gnutls_functions): New function to initialize function pointers.
8967 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8968 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8969 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8970 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8971 (emacs_gnutls_write, emacs_gnutls_read)
8972 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8973 (Fgnutls_available_p): New function.
8974 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8975 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8976 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8978 * image.c: Include w32.h.
8979 (Vimage_type_cache): Delete.
8980 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8981 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8982 (w32_delayed_load): Move to w32.c.
8984 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8986 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8987 (w32_delayed_load): Move from image.c. When loading a library, record
8988 its filename in the :loaded-from property of the library id.
8989 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8990 Initialize and staticpro them.
8991 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8993 * process.c: Include lisp.h before w32.h, not after.
8994 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8995 instead of gnutls_record_check_pending.
8997 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8999 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9001 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9002 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9005 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9007 * xterm.c (x_set_frame_alpha): Do not set property on anything
9008 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9010 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9012 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9014 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9016 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9017 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9018 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9019 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9020 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9021 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9022 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9023 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9024 (Qgnutls_bootprop_callbacks_verify): Make static.
9026 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9028 * callproc.c: Indentation fixup.
9030 * sysdep.c (wait_for_termination_1): Make static.
9031 (wait_for_termination, interruptible_wait_for_termination):
9032 Move after wait_for_termination_1.
9034 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9036 * sysdep.c (interruptible_wait_for_termination): New function
9037 which is like wait_for_termination, but allows keyboard
9040 * callproc.c (Fcall_process): Add (:file "file") as an option for
9042 (Fcall_process_region): Ditto.
9044 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9046 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9047 rather than `XVECTOR (FOO)->size'.
9049 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9050 inttypes.h, as a gnulib replacement is used if it not available in
9053 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9055 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9056 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9057 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9059 * coding.c (coding_alloc_by_realloc): Error out if destination
9060 will grow beyond MOST_POSITIVE_FIXNUM.
9061 (decode_coding_emacs_mule): Abort if there isn't enough place in
9062 charbuf for the composition carryover bytes. Reserve an extra
9063 space for up to 2 characters produced in a loop.
9064 (decode_coding_iso_2022): Abort if there isn't enough place in
9065 charbuf for the composition carryover bytes.
9067 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9069 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9070 aborting when %lld or %lll format is passed.
9071 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9072 %llo or %llx format is passed. (Bug#8545)
9074 * window.c (window_scroll_line_based): Use a marker instead of
9075 simple variables to record original value of point. (Bug#7952)
9077 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9078 produced by %s or %c overflows available buffer space. (Bug#8545)
9080 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9082 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9083 (SIZE_MAX): Move defn after all includes, as they might #define it.
9085 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9087 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9089 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9091 * keyboard.c (Qdelayed_warnings_hook): Define.
9092 (command_loop_1): Run `delayed-warnings-hook'
9093 if Vdelayed_warnings_list is non-nil.
9094 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9095 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9097 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9099 * doprnt.c (doprnt): Don't return value smaller than the buffer
9100 size if the message was truncated. (Bug#8545).
9102 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9104 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9105 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9107 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9109 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9111 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9113 * makefile.w32-in: Update dependencies.
9115 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9117 Improve `doprnt' and its usage. (Bug#8545)
9118 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9119 `format_end'. Remove support for %l as a conversion specifier.
9120 Don't use xrealloc. Improve diagnostics when the %l size modifier
9121 is used. Update the commentary.
9123 * eval.c (verror): Simplify calculation of size_t.
9125 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9128 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9130 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9133 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9135 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9136 This makes this file independent of the recent pseudovector change.
9138 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9140 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9142 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9143 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9144 Remove unused local.
9145 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9147 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9148 GCC 4.6.0 optimizes based on type-based alias analysis.
9149 For example, if b is of type struct buffer * and v of type struct
9150 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9151 != &v->size, and therefore "v->size = 1; b->size = 2; return
9152 v->size;" must therefore return 1. This assumption is incorrect
9153 for Emacs, since it type-puns struct Lisp_Vector * with many other
9154 types. To fix this problem, this patch adds a new type struct
9155 vectorlike_header that documents the constraints on layout of vectors
9156 and pseudovectors, and helps optimizing compilers not get fooled
9157 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9158 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9159 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9161 (XSETPVECTYPE): Rewrite in terms of new macro.
9162 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9163 This is a bit clearer, and further avoids the possibility of
9164 undesirable aliasing.
9165 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9166 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9167 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9168 since Lisp_Subr is a special case (no "next" field).
9169 (ASIZE): Now uses header.size rather than size.
9170 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9171 to avoid the hassle of writing XVECTOR (foo)->header.size.
9172 (struct vectorlike_header): New type.
9173 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9174 object, to help avoid aliasing.
9175 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9176 (SUBRP): Likewise, since Lisp_Subr is a special case.
9177 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9178 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9179 (struct Lisp_Hash_Table): Combine first two members into a single
9180 struct vectorlike_header member. All uses of "size" and "next" members
9181 changed to be "header.size" and "header.next".
9182 * buffer.h (struct buffer): Likewise.
9183 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9184 * frame.h (struct frame): Likewise.
9185 * process.h (struct Lisp_Process): Likewise.
9186 * termhooks.h (struct terminal): Likewise.
9187 * window.c (struct save_window_data, struct saved_window): Likewise.
9188 * window.h (struct window): Likewise.
9189 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9190 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9191 * buffer.c (init_buffer_once): Likewise.
9192 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9194 * process.c (Fformat_network_address): Use local var for size,
9197 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9199 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9200 * data.c (atof): Remove decl; no longer used or needed.
9201 (digit_to_number): Move to lread.c.
9202 (Fstring_to_number): Use new string_to_number function, to be
9203 consistent with how the Lisp reader treats infinities and NaNs.
9204 Do not assume that floating-point numbers represent EMACS_INT
9205 without losing information; this is not true on most 64-bit hosts.
9206 Avoid double-rounding errors, by insisting on integers when
9207 parsing non-base-10 numbers, as the documentation specifies.
9208 * lisp.h (string_to_number): New decl, replacing ...
9209 (isfloat_string): Remove.
9210 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9211 (read1): Do not accept +. and -. as integers; this
9212 appears to have been a coding error. Similarly, do not accept
9213 strings like +-1e0 as floating point numbers. Do not report
9214 overflow for integer overflows unless the base is not 10 which
9215 means we have no simple and reliable way to continue.
9216 Break out the floating-point parsing into a new
9217 function string_to_number, so that Fstring_to_number parses
9218 floating point numbers consistently with the Lisp reader.
9219 (digit_to_number): Move here from data.c. Make it static inline.
9220 (E_CHAR, EXP_INT): Remove, replacing with ...
9221 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9222 (string_to_number): New function, replacing isfloat_string.
9223 This function checks for valid syntax and produces the resulting
9224 Lisp float number too. Rework it so that string-to-number
9225 no longer mishandles examples like "1.0e+". Use strtoumax,
9226 so that overflow for non-base-10 numbers is reported only when
9227 there's no portable and simple way to convert to floating point.
9229 * textprop.c (set_text_properties_1): Rewrite for clarity,
9230 and to avoid GCC warning about integer overflow.
9232 * intervals.h (struct interval): Use EMACS_INT for members
9233 where EMACS_UINT might cause problems. See
9234 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9235 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9236 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9238 (offset_intervals): Tell GCC not to worry about length overflow
9239 when negating a negative length.
9241 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9242 (overrun_check_free): Likewise.
9244 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9245 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9248 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9249 (gnutls_make_error): Rename local to avoid shadowing.
9250 (gnutls_emacs_global_deinit): ifdef out; not used.
9251 (Fgnutls_boot): Use const for pointer to readonly storage.
9252 Comment out unused local. Fix pointer signedness problems.
9254 * lread.c (openp): Don't stuff size_t into an 'int'.
9255 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9256 about possible signed overflow.
9258 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9259 (GDK_KEY_g): Don't define if already defined.
9260 (xg_prepare_tooltip): Avoid pointer signedness problem.
9261 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9263 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9264 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9266 * xfns.c (Fx_window_property): Simplify a bit,
9267 to make a bit faster and to avoid GCC 4.6.0 warning.
9268 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9270 * fns.c (internal_equal): Don't assume size_t fits in int.
9272 * alloc.c (compact_small_strings): Tighten assertion a little.
9274 Replace pEd with more-general pI, and fix some printf arg casts.
9275 * lisp.h (pI): New macro, generalizing old pEd macro to other
9276 conversion specifiers. For example, use "...%"pI"d..." rather
9277 than "...%"pEd"...".
9278 (pEd): Remove. All uses replaced with similar uses of pI.
9279 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9280 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9281 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9282 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9283 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9284 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9285 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9287 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9288 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9289 * print.c (safe_debug_print, print_object): Likewise.
9290 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9292 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9293 avoiding the 0 flag, which is not portable.
9294 * process.c (Fmake_network_process): Use pI to avoid cast.
9295 * region-cache.c (pp_cache): Likewise.
9296 * xdisp.c (decode_mode_spec): Likewise.
9297 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9298 behavior on 64-bit hosts with printf arg.
9299 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9300 (x_stop_queuing_selection_requests): Likewise.
9301 (x_get_window_property): Don't truncate byte count to an 'int'
9304 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9305 here, since it parses constructs like leading '-' and spaces,
9306 which are not wanted; and it overflows with large numbers.
9307 Instead, simply match F[0-9]+, which is what is wanted anyway.
9309 * alloc.c: Remove unportable assumptions about struct layout.
9310 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9311 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9312 (allocate_vectorlike, make_pure_vector): Use the new macros,
9313 plus offsetof, to remove unportable assumptions about struct layout.
9314 These assumptions hold on all porting targets that I know of, but
9315 they are not guaranteed, they're easy to remove, and removing them
9316 makes further changes easier.
9318 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9319 This doesn't fix a bug but makes the code clearer.
9320 (string_overrun_cookie): Now const. Use initializers that
9321 don't formally overflow signed char, to avoid warnings.
9322 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9323 can cause Emacs to crash when string overrun checking is enabled.
9324 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9325 multiple of sizeof (EMACS_INT); it need not be, if
9326 alignof(EMACS_INT) < sizeof (EMACS_INT).
9327 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9329 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9331 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9333 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9335 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9336 supposed to be handshaking. (Bug#8556)
9337 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9339 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9341 * lisp.h (Qdebug): List symbol.
9342 * eval.c (Qdebug): Restore global linkage.
9343 * keyboard.c (debug-on-event): New variable.
9344 (handle_user_signal): Break into debugger when debug-on-event
9345 matches the current signal symbol.
9347 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9349 * alloc.c (check_sblock, check_string_bytes)
9350 (check_string_free_list): Convert to standard C.
9352 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9354 * w32.c (emacs_gnutls_push): Fix typo.
9356 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9358 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9359 "cast to pointer from integer of different size".
9361 Improve doprnt and its use in verror. (Bug#8545)
9362 * doprnt.c (doprnt): Document the set of format control sequences
9363 supported by the function. Use SAFE_ALLOCA instead of always
9366 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9367 is one byte too soon. Don't use xrealloc; instead xfree and
9370 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9372 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9375 * gnutls.c: Renamed global_initialized to
9376 gnutls_global_initialized. Added internals for the
9377 :verify-hostname-error, :verify-error, and :verify-flags
9378 parameters of `gnutls-boot' and documented those parameters in the
9379 docstring. Start callback support.
9380 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9381 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9382 on error. Return error code.
9383 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9384 (emacs_gnutls_read): Likewise.
9385 (Fgnutls_boot): Return handshake error code.
9386 (emacs_gnutls_handle_error): New function.
9387 (wsaerror_to_errno): Likewise.
9389 * w32.h (emacs_gnutls_pull): Add prototype.
9390 (emacs_gnutls_push): Likewise.
9392 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9393 (emacs_gnutls_push): Likewise.
9395 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9397 * process.c (wait_reading_process_output): Check if GnuTLS
9398 buffered some data internally if no FDs are set for TLS
9401 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9402 (LIBS): Link to USER_LIBS.
9403 ($(BLD)/gnutls.$(0)): New target.
9405 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9407 * xdisp.c (handle_single_display_spec): Rename the
9408 display_replaced_before_p argument into display_replaced_p, to
9409 make it consistent with the commentary. Fix typos in the
9412 * textprop.c (syms_of_textprop): Remove dead code.
9413 (copy_text_properties): Delete obsolete commentary about an
9414 interface that was deleted long ago. Fix typos in the description
9417 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9418 to changes in oldXMenu/XMenu.h from 2011-04-16.
9419 <menu_help_message, prev_menu_help_message>: Constify.
9420 (IT_menu_make_room): menu->help_text is now `const char **';
9423 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9424 to changes in oldXMenu/XMenu.h from 2011-04-16.
9425 (struct XMenu): Declare `help_text' `const char **'.
9427 * xfaces.c <Qunspecified>: Make extern again.
9429 * syntax.c: Include sys/types.h before including regex.h, as
9432 * doc.c (get_doc_string): Improve the format passed to `error'.
9434 * doprnt.c (doprnt): Improve commentary.
9436 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9438 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9441 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9442 changes in globals.h immediately force recompilation.
9443 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9444 $(CURDIR)/s/ms-w32.h.
9445 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9447 * character.c (Fchar_direction): Function deleted.
9448 (syms_of_character): Don't defsubr it.
9449 <char-direction-table>: Deleted.
9451 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9453 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9454 * doprnt.c: Include limits.h.
9455 (SIZE_MAX): New macro.
9456 (doprnt): Return a size_t value. 2nd arg is now size_t.
9457 Many local variables are now size_t instead of int or unsigned.
9458 Improve overflow protection. Support `l' modifier for integer
9459 conversions. Support %l conversion. Don't assume an EMACS_INT
9460 argument for integer conversions and for %c.
9462 * lisp.h (doprnt): Restore prototype.
9464 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9467 * Makefile.in (base_obj): Add back doprnt.o.
9469 * deps.mk (doprnt.o): Add back prerequisites.
9470 (callint.o): Depend on character.h.
9472 * eval.c (internal_lisp_condition_case): Include the handler
9473 representation in the error message.
9474 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9475 when breaking from the loop.
9477 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9479 * callint.c (Fcall_interactively): When displaying error message
9480 about invalid control letter, pass the character's codepoint, not
9481 a pointer to its multibyte form. Improve display of the character
9482 in octal and display also its hex code.
9484 * character.c (char_string): Use %x to display the (unsigned)
9485 codepoint of an invalid character, to avoid displaying a bogus
9488 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9489 `error', not SYMBOL_NAME itself.
9491 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9492 character arguments to `error'.
9494 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9495 to `error' in error message about FINAL_CHAR argument. Make sure
9496 FINAL_CHAR is a character, and use %c when it is passed as
9497 argument to `error'.
9499 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9501 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9503 * w32.c: Include <time.h>.
9504 (sys_localtime): New function.
9506 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9508 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9510 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9512 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9514 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9517 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9519 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9520 gl_state.e_property when gl_state.object is Qt.
9522 * insdel.c (make_gap_larger): Remove limitation of buffer size
9525 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9527 * xdisp.c (lookup_glyphless_char_display)
9528 (produce_glyphless_glyph): Handle cons cell entry in
9529 glyphless-char-display.
9530 (Vglyphless_char_display): Document it.
9532 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9533 glyphless-char-display.
9535 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9537 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9539 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9541 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9542 definition for no-X builds.
9544 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9546 Static checks with GCC 4.6.0 and non-default toolkits.
9548 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9550 * process.c (keyboard_bit_set): Define only if SIGIO.
9551 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9552 (send_process): Repair possible setjmp clobbering.
9554 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9556 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9558 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9560 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9561 Define only if needed.
9563 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9564 by pacifying GCC about it. Maybe it's time to retire it?
9565 * xfaces.c (USG, __TIMEVAL__): Likewise.
9567 * dispextern.h (struct redisplay_interface): Rename param
9569 * termhooks.h (struct terminal): Likewise.
9570 * xterm.c (xembed_send_message): Likewise.
9572 * insdel.c (make_gap_smaller): Define only if
9573 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9575 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9578 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9579 so that we aren't warned about unused symbols.
9581 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9583 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9585 * xfns.c (x_real_positions): Mark locals as initialized.
9587 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9589 * xterm.c: Fix problems found by static analysis with other toolkits.
9590 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9591 (x_dispatch_event): Declare static if USE_GTK, and
9592 define if USE_GTK || USE_X_TOOLKIT.
9593 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9594 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9595 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9596 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9598 * xmenu.c (menu_help_callback): Pointer type fixes.
9599 Use const pointers when pointing at readonly data. Avoid pointer
9601 (FALSE): Remove unused macro.
9602 (update_frame_menubar): Remove unused decl.
9604 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9606 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9607 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9608 (single_menu_item): Rename local to avoid shadowing.
9610 * keyboard.c (make_lispy_event): Remove unused local var.
9612 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9613 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9615 * bitmaps: Change bitmaps from unsigned char back to the X11
9616 compatible char. Avoid the old compiler warnings about
9617 out-of-range initializers by using, for example, '\xab' rather
9620 * xgselect.c (xgselect_initialize): Check vs interface
9621 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9623 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9625 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9626 to read-only memory.
9628 * fns.c (vector): Remove; this old hack is no longer needed.
9630 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9632 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9634 * xrdb.c (x_load_resources): Omit unused local.
9636 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9637 (x_window): Rename locals to avoid shadowing.
9638 (USG): Use the kludged USG macro, to pacify gcc.
9640 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9641 (x_term_init): Remove local to avoid shadowing.
9643 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9645 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9646 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9648 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9650 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9652 Fix regex.c, syntax.c and friends for buffers > 2GB.
9653 * syntax.h (struct gl_state_s): Declare character position members
9656 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9658 * textprop.c (verify_interval_modification, interval_of):
9659 Declare arguments EMACS_INT.
9661 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9664 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9666 * indent.c (Fvertical_motion): Local variable it_start is now
9669 * regex.c (re_match, re_match_2, re_match_2_internal)
9670 (bcmp_translate, regcomp, regexec, print_double_string)
9671 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9672 (re_compile_pattern, re_exec): Declare arguments and local
9673 variables `size_t' and `ssize_t' and return values `regoff_t', as
9675 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9676 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9677 <compile_stack_type>: `size' and `avail' are now `size_t'.
9679 * regex.h <regoff_t>: Use ssize_t, not int.
9680 (re_search, re_search_2, re_match, re_match_2): Arguments that
9681 specify buffer/string position and length are now ssize_t and
9682 size_t. Return type is regoff_t.
9684 2011-04-16 Ben Key <bkey76@gmail.com>
9686 * nsfont.m: Fixed bugs in ns_get_family and
9687 ns_descriptor_to_entity that were caused by using free to
9688 deallocate memory blocks that were allocated by xmalloc (via
9689 xstrdup). This caused Emacs to crash when compiled with
9690 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9691 --enable-checking=xmallocoverrun). xfree is now used to
9692 deallocate these memory blocks.
9694 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9696 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9698 emacs_write: Accept and return EMACS_INT for sizes.
9699 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9701 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9702 Accept and return EMACS_INT.
9703 (emacs_gnutls_write): Return the number of bytes written on
9705 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9706 (emacs_read, emacs_write): Remove check for negative size, as the
9707 Emacs source code has been audited now.
9708 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9709 (emacs_read, emacs_write): Use it.
9710 * process.c (send_process): Adjust to the new signatures of
9711 emacs_write and emacs_gnutls_write. Do not attempt to store
9712 a byte offset into an 'int'; it might overflow.
9713 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9715 * sound.c: Don't assume sizes fit in 'int'.
9716 (struct sound_device.period_size, alsa_period_size):
9717 Return EMACS_INT, not int.
9718 (struct sound_device.write, vox_write, alsa_write):
9719 Accept EMACS_INT, not int.
9720 (wav_play, au_play): Use EMACS_INT to store sizes and to
9721 record read return values.
9723 2011-04-15 Ben Key <bkey76@gmail.com>
9725 * keyboard.c (Qundefined): Don't declare static since it is used
9727 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9728 static since they are used in nsfont.m.
9730 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9732 * process.c (Qprocessp): Don't declare static.
9733 * lisp.h (Qprocessp): Declare again.
9735 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9737 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9739 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9741 Improve C-level modularity by making more things 'static'.
9743 Don't publish debugger-only interfaces to other modules.
9744 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9745 (verify_bytepos, count_markers): Move decls to the only modules
9747 * region-cache.h (pp_cache): Likewise.
9748 * window.h (check_all_windows): Likewise.
9749 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9751 * sysdep.c (croak): Now static, if
9752 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9753 * syssignal.h (croak): Declare only if not static.
9755 * alloc.c (refill_memory_reserve): Now static if
9756 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9757 * lisp.h (refill_memory_reserve): Declare only if not static.
9759 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9760 Define only if USE_LUCID.
9762 * xrdb.c (x_customization_string, x_rm_string): Now static.
9764 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9765 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9767 * xdisp.c (draw_row_with_mouse_face): Now static.
9768 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9770 * window.h (check_all_windows): Mark externally visible.
9772 * window.c (window_deletion_count): Now static.
9774 * undo.c: Make symbols static if they're not exported.
9775 (last_undo_buffer, last_boundary_position, pending_boundary):
9778 * textprop.c (interval_insert_behind_hooks): Now static.
9779 (interval_insert_in_front_hooks): Likewise.
9781 * term.c: Make symbols static if they're not exported.
9782 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9783 (max_frame_lines, tty_set_terminal_modes):
9784 (tty_reset_terminal_modes, tty_turn_off_highlight):
9785 (get_tty_terminal): Now static.
9786 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9787 * termhooks.h (term_mouse_moveto): Do not declare if
9789 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9790 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9792 * sysdep.c: Make symbols static if they're not exported.
9793 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9795 (sigprocmask_set, full_mask): Remove; unused.
9796 (wait_debugging): Mark as visible.
9797 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9798 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9800 * syntax.c (syntax_temp): Define only if !__GNUC__.
9802 * sound.c (current_sound_device, current_sound): Now static.
9804 * search.c (searchbufs, searchbuf_head): Now static.
9806 * scroll.c (scroll_cost): Remove; unused.
9807 * dispextern.h (scroll_cost): Remove decl.
9809 * region-cache.h (pp_cache): Mark as externally visible.
9811 * process.c: Make symbols static if they're not exported.
9812 (process_tick, update_tick, create_process, chan_process):
9813 (Vprocess_alist, proc_buffered_char, datagram_access):
9814 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9815 (deactivate_process): Mark defn as static, as well as decl.
9816 * lisp.h (create_process): Remove decl.
9817 * process.h (chan_process, Vprocess_alist): Remove decls.
9819 * print.c: Make symbols static if they're not exported.
9820 (print_depth, new_backquote_output, being_printed, print_buffer):
9821 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9822 (print_interval, print_number_index, initial_stderr_stream):
9824 * lisp.h (Fprinc): Remove decl.
9825 (debug_output_compilation_hack): Mark as externally visible.
9827 * sysdep.c (croak): Move decl from here to syssignal.h.
9828 * syssignal.h (croak): Put it here, so the API can be checked when
9829 'croak' is called from dissociate_if_controlling_tty.
9831 * minibuf.c: Make symbols static if they're not exported.
9832 (minibuf_save_list, choose_minibuf_frame): Now static.
9833 * lisp.h (choose_minibuf_frame): Remove decl.
9835 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9837 * lread.c: Make symbols static if they're not exported.
9838 (read_objects, initial_obarray, oblookup_last_bucket_number):
9840 (make_symbol): Remove; unused.
9841 * lisp.h (initial_obarray, make_symbol): Remove decls.
9843 * keyboard.c: Make symbols static if they're not exported.
9844 (single_kboard, recent_keys_index, total_keys, recent_keys):
9845 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9846 (this_single_command_key_start, echoing, last_auto_save):
9847 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9848 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9849 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9850 (Vlispy_mouse_stem, double_click_count):
9852 (force_auto_save_soon): Define only if SIGDANGER.
9853 (ignore_mouse_drag_p): Now static if
9854 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9855 (print_help): Remove; unused.
9856 (stop_character, last_timer_event): Mark as externally visible.
9857 * keyboard.h (ignore_mouse_drag_p): Declare only if
9858 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9859 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9860 * lisp.h (echoing): Remove decl.
9861 (force_auto_save_soon): Declare only if SIGDANGER.
9862 * xdisp.c (redisplay_window): Simplify code, to make it more
9863 obvious that ignore_mouse_drag_p is not accessed if !defined
9864 USE_GTK && !defined HAVE_NS.
9866 * intervals.c: Make symbols static if they're not exported.
9867 (merge_properties_sticky, merge_interval_right, delete_interval):
9869 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9871 * insdel.c: Make symbols static if they're not exported.
9872 However, leave prepare_to_modify_buffer alone. It's never
9873 called from outside this function, but that appears to be a bug.
9874 (combine_after_change_list, combine_after_change_buffer):
9875 (adjust_after_replace, signal_before_change): Now static.
9876 (adjust_after_replace_noundo): Remove; unused.
9877 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9878 (signal_before_change): Remove decls.
9880 * indent.c (val_compute_motion, val_vmotion): Now static.
9882 * image.c: Make symbols static if they're not exported.
9883 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9885 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9886 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9888 * fringe.c (standard_bitmaps): Now static.
9889 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9891 * frame.c: Make symbols static if they're not exported.
9892 (x_report_frame_params, make_terminal_frame): Now static.
9893 (get_frame_param): Now static, unless HAVE_NS.
9894 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9895 (x_get_resource_string): Remove; not used.
9896 * frame.h (make_terminal_frame, x_report_frame_params):
9897 (x_get_resource_string); Remove decls.
9898 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9899 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9901 * font.c, fontset.c: Make symbols static if they're not exported.
9902 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9903 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9904 * font.c (font_close_object): Now static.
9905 * font.h (font_close_object): Remove.
9906 * fontset.c (FONTSET_OBJLIST): Remove.
9907 (free_realized_fontset) #if-0 the body, which does nothing.
9908 (face_suitable_for_char_p): #if-0, as it's never called.
9909 * fontset.h (face_suitable_for_char_p): Remove decl.
9910 * xfaces.c (face_at_string_position):
9911 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9912 since 0 is always ASCII.
9914 * fns.c (weak_hash_tables): Now static.
9916 * fileio.c: Make symbols static if they're not exported.
9917 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9918 (Vwrite_region_annotation_buffers): Now static.
9920 * eval.c: Make symbols static if they're not exported.
9921 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9922 * lisp.h (backtrace_list): Remove decl.
9924 * emacs.c: Make symbols static if they're not exported.
9925 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9926 (fatal_error_code, fatal_error_signal_hook, standard_args):
9928 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9929 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9930 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9931 * lisp.h (fatal_error_signal_hook): Remove decl.
9932 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9934 * editfns.c: Move a (normally-unused) function to its only use.
9935 * editfns.c, lisp.h (get_operating_system_release): Remove.
9936 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9937 worth the hassle of breaking this out.
9939 * xterm.c: Make symbols static if they're not exported.
9940 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9941 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9942 (x_destroy_window, x_delete_display):
9944 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9945 (x_mouse_leave): Remove; unused.
9946 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9947 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9948 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9950 (x_mouse_leave): Declare only if WINDOWSNT.
9951 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9952 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9955 * ftxfont.c: Make symbols static if they're not exported.
9956 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9958 * font.h (ftxfont_driver): Likewise.
9960 * xfns.c: Make symbols static if they're not exported.
9961 (x_last_font_name, x_display_info_for_name):
9962 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9963 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9964 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9965 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9966 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9967 (last_show_tip_args): Now static.
9968 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9969 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9970 (x_screen_planes): Remove; unused.
9971 * dispextern.h (x_screen_planes): Remove decl.
9973 * dispnew.c: Make symbols static if they're not exported.
9974 * dispextern.h (redraw_garbaged_frames, scrolling):
9975 (increment_row_positions): Remove.
9976 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9977 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9979 (redraw_garbaged_frames): Remove; unused.
9981 * xfaces.c: Make symbols static if they're not exported.
9982 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9984 * xterm.h (defined_color): Remove decls.
9985 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9986 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9987 (menu_face_changed_default, defined_color, free_realized_face):
9988 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9989 (ascii_face_of_lisp_face): Remove; unused.
9991 * xdisp.c: Make symbols static if they're not exported.
9992 * dispextern.h (scratch_glyph_row, window_box_edges):
9993 (glyph_to_pixel_coords, set_cursor_from_row):
9994 (get_next_display_element, set_iterator_to_next):
9995 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9996 (show_mouse_face): Remove decls
9997 * frame.h (message_buf_print): Likewise.
9998 * lisp.h (pop_message, set_message, check_point_in_composition):
10000 * xterm.h (set_vertical_scroll_bar): Likewise.
10001 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10002 (message_buf_print, scratch_glyph_row, displayed_buffer):
10003 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10004 (get_next_display_element, show_mouse_face, window_box_edges):
10005 (frame_to_window_pixel_xy, check_point_in_composition):
10006 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10007 (glyph_to_pixel_coords): Remove; unused.
10009 * dired.c (file_name_completion): Now static.
10011 * dbusbind.c (xd_in_read_queued_messages): Now static.
10013 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10014 * data.c (circular_list_error): Remove.
10016 * commands.h (last_point_position, last_point_position_buffer):
10017 (last_point_position_window): Remove decls.
10018 * keyboard.c: Make these variables static.
10020 * coding.h (coding, code_convert_region, encode_coding_gap):
10022 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10023 (iso_code_class, detect_coding, code_convert_region): Now static.
10024 (encode_coding_gap): Remove; unused.
10026 * chartab.c (chartab_chars, chartab_bits): Now static.
10028 * charset.h (charset_iso_8859_1): Remove decl.
10029 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10032 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10033 * ccl.c (Vccl_program_table): Now static.
10034 (check_ccl_update): Remove; unused.
10036 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10037 * category.h: ... from here.
10038 * category.c (check_category_table, set_category_set): Now static.
10040 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10041 * lisp.h: Remove these decls.
10043 * buffer.c (buffer_count): Remove unused var.
10045 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10046 so that it's not optimized away.
10047 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10048 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10049 exported only to the debugger.
10051 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10052 * atimer.h (run_all_atimers): Remove; not exported.
10054 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10055 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10056 was inaccessible from Lisp.
10057 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10058 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10060 alloc.c: Import and export fewer symbols, and remove unused items.
10061 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10063 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10064 it's not optimized away by whole-program optimization.
10065 (message_enable_multibyte, free_misc): Remove.
10066 (catchlist, handlerlist, mark_backtrace):
10067 Declare only if BYTE_MARK_STACK.
10068 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10069 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10070 (message_enable_multibyte): Remove decl.
10071 (free_misc, interval_free_list, float_block, float_block_index):
10072 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10073 (cons_free_list, last_marked_index):
10075 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10076 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10077 (mark_backtrace): Define only if BYTE_MARK_STACK.
10078 * xdisp.c (message_enable_multibyte): Now static.
10080 Declare Lisp_Object Q* variables to be 'static' if not exported.
10081 This makes it easier for human readers (and static analyzers)
10082 to see whether these variables are used from other modules.
10083 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10084 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10085 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10086 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10087 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10088 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10089 * xmenu.c, xselect.c:
10090 Declare Q* vars static if they are not used in other modules.
10091 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10092 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10093 Remove decls of unexported vars.
10094 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10096 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10098 Make Emacs functions such as Fatom 'static' by default.
10099 This makes it easier for human readers (and static analyzers)
10100 to see whether these functions can be called from other modules.
10101 DEFUN now defines a static function. To make the function external
10102 so that it can be used in other C modules, use the new macro DEFUE.
10103 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10104 (Finit_image_library):
10105 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10106 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10107 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10108 Remove decls, since these functions are now static.
10109 (Funintern, Fget_internal_run_time): New decls, since these functions
10110 were already external.
10112 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10113 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10114 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10115 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10116 * keyboard.c, keymap.c, lread.c:
10117 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10118 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10119 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10120 Mark functions with DEFUE instead of DEFUN,
10121 if they are used in other modules.
10122 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10123 decls for now-static functions.
10124 * buffer.h (Fdelete_overlay): Remove decl.
10125 * callproc.c (Fgetenv_internal): Mark as internal.
10126 * composite.c (Fremove_list_of_text_properties): Remove decl.
10127 (Fcomposition_get_gstring): New forward static decl.
10128 * composite.h (Fcomposite_get_gstring): Remove decl.
10129 * dired.c (Ffile_attributes): New forward static decl.
10130 * doc.c (Fdocumntation_property): New forward static decl.
10131 * eval.c (Ffetch_bytecode): New forward static decl.
10132 (Funintern): Remove extern decl; now in .h file where it belongs.
10133 * fileio.c (Fmake_symbolic_link): New forward static decl.
10134 * image.c (Finit_image_library): New forward static decl.
10135 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10136 * intervals.h (Fprevious_property_change):
10137 (Fremove_list_of_text_properties): Remove decls.
10138 * keyboard.c (Fthis_command_keys): Remove decl.
10139 (Fcommand_execute): New forward static decl.
10140 * keymap.c (Flookup_key): New forward static decl.
10141 (Fcopy_keymap): Now static.
10142 * keymap.h (Flookup_key): Remove decl.
10143 * process.c (Fget_process): New forward static decl.
10144 (Fprocess_datagram_address): Mark as internal.
10145 * syntax.c (Fsyntax_table_p): New forward static decl.
10146 (skip_chars): Remove duplicate decl.
10147 * textprop.c (Fprevious_property_change): New forward static decl.
10148 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10150 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10151 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10153 * editfns.c (Fformat): Remove unreachable code.
10155 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10157 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10160 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10162 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10163 when at ZV. (Bug#8487)
10165 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10167 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10169 * keyboard.c (parse_tool_bar_item): Likewise.
10170 * sound.c (sound_cleanup, alsa_close): Likewise.
10171 * termcap.c (tgetent): Likewise.
10172 * xfns.c (x_default_font_parameter): Likewise.
10173 * xsettings.c (read_and_apply_settings): Likewise.
10175 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10176 (overrun_check_free): Protoize.
10178 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10180 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10181 since callers should never pass a negative size.
10182 Change the signature to match that of plain 'read' and 'write'; see
10183 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10184 * lisp.h: Update prototypes of emacs_write and emacs_read.
10186 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10188 * xdisp.c (redisplay_window): Don't try to determine the character
10189 position of the scroll margin if the window start point w->startp
10190 is outside the buffer's accessible region. (Bug#8468)
10192 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10194 Fix write-region and its subroutines for buffers > 2GB.
10195 * fileio.c (a_write, e_write): Modify declaration of arguments and
10196 local variables to support buffers larger than 2GB.
10197 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10199 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10200 argument, local variables, and return value.
10202 * lisp.h: Update prototypes of emacs_write and emacs_read.
10204 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10206 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10208 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10210 Fix more problems found by GCC 4.6.0's static checks.
10212 * xdisp.c (vmessage): Use a better test for character truncation.
10214 * charset.c (load_charset_map): <, not <=, for optimization,
10215 and to avoid potential problems with integer overflow.
10216 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10217 * casetab.c (set_identity, shuffle): Likewise.
10218 * editfns.c (Fformat): Likewise.
10219 * syntax.c (skip_chars): Likewise.
10221 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10222 This also lets GCC 4.6.0 generate slightly better loop code.
10224 * callint.c (Fcall_interactively): <, not <=, for optimization.
10225 (Fcall_interactively): Count the number of arguments produced,
10226 not the number of arguments given. This is simpler and lets GCC
10227 4.6.0 generate slightly better code.
10229 * ftfont.c: Distingish more carefully between FcChar8 and char.
10230 The previous code passed unsigned char * to a functions like
10231 strlen and xstrcasecmp that expect char *, which does not
10232 conform to the C standard.
10233 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10234 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10235 char * when the C standard requires it.
10237 * keyboard.c (read_char): Remove unused var.
10239 * eval.c: Port to Windows vsnprintf (Bug#8435).
10240 Include <limits.h>.
10241 (SIZE_MAX): Define if the headers do not.
10242 (verror): Do not give up if vsnprintf returns a negative count.
10243 Instead, grow the buffer. This ports to Windows vsnprintf, which
10244 does not conform to C99. Problem reported by Eli Zaretskii.
10245 Also, simplify the allocation scheme, by avoiding the need for
10246 calling realloc, and removing the ALLOCATED variable.
10248 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10250 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10251 But keep the doprint source code for now, as we might revamp it
10252 and use it again (Bug#8435).
10253 * lisp.h (doprnt): Remove.
10254 * Makefile.in (base_obj): Remove doprnt.o.
10255 * deps.mk (doprnt.o): Remove.
10257 error: Print 32- and 64-bit integers portably (Bug#8435).
10258 Without this change, on typical 64-bit hosts error ("...%d...", N)
10259 was used to print both 32- and 64-bit integers N, which relied on
10260 undefined behavior.
10261 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10262 * lisp.h (error, verror): Mark as printf-like functions.
10263 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10264 Report overflow in size calculations when allocating printf buffer.
10265 Do not truncate output string at its first null byte.
10266 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10267 Truncate the output at a character boundary, since vsnprintf does not
10269 * charset.c (check_iso_charset_parameter): Convert internal
10270 character to string before calling 'error', since %c now has the
10272 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10273 overflow when computing char to be passed to 'error'. Do not
10274 pass Lisp_Object to 'error'; pass the integer instead.
10275 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10276 formatted with plain %d.
10278 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10280 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10282 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10284 * xterm.c (x_catch_errors): Remove duplicate declaration.
10286 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10288 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10290 2011-04-10 Jim Meyering <meyering@redhat.com>
10292 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10293 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10294 return ssize_t not "int", and use size_t as the buffer length.
10295 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10296 * gnutls.h: Update declarations.
10297 * process.c (read_process_output): Use ssize_t, to match.
10298 (send_process): Likewise.
10300 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10302 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10304 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10306 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10307 Use unsigned char, to match FcChar8 type definition.
10309 * xterm.c (handle_one_xevent):
10310 * xmenu.c (create_and_show_popup_menu):
10311 * xselect.c (x_decline_selection_request)
10312 (x_reply_selection_request): Avoid type-punned deref of X events.
10314 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10316 Fix some uses of `int' instead of EMACS_INT.
10317 * search.c (string_match_1, fast_string_match)
10318 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10319 (scan_buffer, find_next_newline_no_quit)
10320 (find_before_next_newline, search_command, Freplace_match)
10321 (Fmatch_data): Make some `int' variables be EMACS_INT.
10323 * xdisp.c (display_count_lines): 3rd argument and return value now
10324 EMACS_INT. All callers changed.
10325 (pint2hrstr): Last argument is now EMACS_INT.
10327 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10328 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10329 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10330 (decode_coding_utf_16, decode_coding_emacs_mule)
10331 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10332 (decode_coding_ccl, decode_coding_charset)
10333 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10334 (decode_coding_iso_2022, decode_coding_emacs_mule)
10335 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10336 <char_offset, last_offset>: Declare EMACS_INT.
10337 (encode_coding_utf_8, encode_coding_utf_16)
10338 (encode_coding_emacs_mule, encode_invocation_designation)
10339 (encode_designation_at_bol, encode_coding_iso_2022)
10340 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10341 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10343 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10344 (encode_invocation_designation): Last argument P_NCHARS is now
10346 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10347 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10349 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10352 * ccl.c (Fccl_execute_on_string): Declare some variables
10355 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10357 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10359 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10361 * process.c (Fformat_network_address): Doc fix.
10363 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10365 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10367 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10369 * keyboard.c (read_char): Call Lisp function help-form-show,
10370 instead of using internal_with_output_to_temp_buffer.
10371 (Qhelp_form_show): New var.
10372 (syms_of_keyboard): Use DEFSYM macro.
10374 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10376 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10378 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10380 * process.c (Flist_processes): Remove to Lisp.
10381 (list_processes_1): Delete.
10383 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10385 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10387 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10389 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10391 Fix more problems found by GCC 4.6.0's static checks.
10393 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10395 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10397 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10399 * xdisp.c (vmessage): Mark as a printf-like function.
10401 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10403 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10405 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10406 printf-like functions.
10407 (tiff_load): Add casts to remove these marks before passing them
10408 to system-supplied API.
10410 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10412 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10413 This avoids several warnings with gcc -Wstrict-overflow.
10414 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10415 directly, rather than having caller test rule sign. This avoids
10416 some unnecessary tests.
10417 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10418 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10419 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10421 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10422 (xfont_open): Avoid unnecessary tests.
10424 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10426 * composite.h, composite.c (composition_gstring_put_cache):
10427 Use EMACS_INT, not int, for length.
10429 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10430 breaking out part of COMPOSITION_DECODE_RULE.
10431 (COMPOSITION_DECODE_RULE): Use it.
10432 * composite.c (get_composition_id): Remove unused local vars,
10433 by using the new macro.
10435 * textprop.c (set_text_properties_1): Change while to do-while,
10436 since the condition is always true at first.
10438 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10439 (interval_deletion_adjustment): Return unsigned value.
10442 * process.c (list_processes_1, create_pty, read_process_output):
10443 (exec_sentinel): Remove vars that were set but not used.
10444 (create_pty): Remove unnecessary "volatile"s.
10445 (Fnetwork_interface_info): Avoid possibility of int overflow.
10446 (read_process_output): Do adaptive read buffering even if carryover.
10447 (read_process_output): Simplify nbytes computation if buffered.
10449 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10451 * syntax.c (scan_words): Remove var that was set but not used.
10452 (update_syntax_table): Use unsigned instead of int.
10454 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10455 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10456 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10458 * print.c (print_error_message): Avoid int overflow.
10460 * font.c (font_list_entities): Redo for clarity,
10461 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10463 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10464 (font_score): Avoid potential overflow in diff calculation.
10466 * fns.c (substring_both): Remove var that is set but not used.
10467 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10469 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10471 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10472 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10473 can always succeed if overflow has undefined behavior.
10475 * search.c (boyer_moore, wordify): Remove vars set but not used.
10476 (wordify): Omit three unnecessary tests.
10478 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10479 All callers changed. This avoids the need for an unused var.
10481 * casefiddle.c (casify_region): Remove var that is set but not used.
10483 * dired.c (file_name_completion): Remove var that is set but not used.
10485 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10487 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10488 (Finsert_file_contents): Remove unnecessary code checking fd.
10490 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10491 Check for integer overflow on size calculations.
10493 * buffer.c (Fprevious_overlay_change): Remove var that is set
10496 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10497 Remove vars that are set but not used.
10498 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10499 (timer_check_2): Mark vars as initialized.
10501 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10503 * image.c (lookup_image): Remove var that is set but not used.
10504 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10506 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10507 that are set but not used.
10509 * xfns.c (make_invisible_cursor): Don't return garbage
10510 if XCreateBitmapFromData fails (Bug#8410).
10512 * xselect.c (x_get_local_selection, x_handle_property_notify):
10513 Remove vars that are set but not used.
10515 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10516 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10518 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10519 Remove var that is set but not used.
10520 (scroll_bar_windows_size): Now size_t, not int.
10521 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10522 Check for overflow.
10524 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10525 (map_tty_color) [!defined MSDOS]: Likewise.
10527 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10529 * coding.c: Remove vars that are set but not used.
10530 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10531 All callers changed.
10532 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10533 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10534 (decode_coding_charset): Remove vars that are set but not used.
10536 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10537 that is set but not used.
10539 * print.c (print_object): Remove var that is set but not used.
10541 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10542 The gnulib version avoids calling malloc in the usual case,
10543 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10544 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10545 * filelock.c (current_lock_owner): Likewise.
10546 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10547 * sysdep.c: Include allocator.h, careadlinkat.h.
10548 (emacs_no_realloc_allocator): New static constant.
10549 (emacs_readlink): New function.
10550 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10551 ../lib/careadlinkat.h.
10553 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10555 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10556 first non-nil return value).
10558 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10560 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10561 if not defined (Bug#8403).
10563 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10565 * xdisp.c (display_count_lines): Remove parameter `start',
10566 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10567 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10568 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10569 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10570 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10571 and thereabouts. All callers changed.
10572 (get_per_char_metric): Remove parameter `f', unused since
10573 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10575 2011-04-02 Jim Meyering <meyering@redhat.com>
10577 do not dereference NULL upon failed strdup
10578 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10579 (ns_get_family): Likewise.
10581 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10583 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10585 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10587 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10590 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10592 Add lexical binding.
10594 * window.c (Ftemp_output_buffer_show): New fun.
10595 (Fsave_window_excursion):
10596 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10598 * lread.c (lisp_file_lexically_bound_p): New function.
10599 (Fload): Bind Qlexical_binding.
10600 (readevalloop): Remove `evalfun' arg.
10601 Bind Qinternal_interpreter_environment.
10602 (Feval_buffer): Bind Qlexical_binding.
10603 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10605 (syms_of_lread): Declare `lexical-binding'.
10607 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10609 * keyboard.c (eval_dyn): New fun.
10610 (menu_item_eval_property): Use it.
10612 * image.c (parse_image_spec): Use Ffunctionp.
10614 * fns.c (concat, mapcar1): Accept byte-code-functions.
10616 * eval.c (Fsetq): Handle lexical vars.
10617 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10618 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10619 (FletX, Flet): Obey lexical binding.
10620 (Fcommandp): Handle closures.
10621 (Feval): New `lexical' arg.
10622 (eval_sub): New function extracted from Feval. Use it almost
10623 everywhere where Feval was used. Look up vars in lexical env.
10625 (Ffunctionp): Move from subr.el.
10626 (Ffuncall): Handle closures.
10627 (apply_lambda): Remove `eval_flags'.
10628 (funcall_lambda): Handle closures and new byte-code-functions.
10629 (Fspecial_variable_p): New function.
10630 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10631 but without exporting it to Lisp.
10633 * doc.c (Fdocumentation, store_function_docstring):
10634 * data.c (Finteractive_form): Handle closures.
10636 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10639 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10641 (exec_byte_code): New function extracted from Fbyte_code to handle new
10642 calling convention for byte-code-functions. Add new byte-codes.
10644 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10646 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10648 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10650 * xdisp.c (redisplay_internal): Fix prototype.
10652 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10654 * xdisp.c (SCROLL_LIMIT): New macro.
10655 (try_scrolling): Use it when setting scroll_limit.
10656 Limit scrolling to 100 screen lines.
10657 (redisplay_window): Even when falling back on "recentering",
10658 position point in the window according to scroll-conservatively,
10659 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10661 (try_scrolling): When point is above the window, allow searching
10662 as far as scroll_max, or one screenful, to compute vertical
10663 distance from PT to the scroll margin position. This prevents
10664 try_scrolling from unnecessarily failing when
10665 scroll-conservatively is set to a value slightly larger than the
10666 window height. Clean up the case of PT below the margin at bottom
10667 of window: scroll_max can no longer be INT_MAX. When aggressive
10668 scrolling is in use, don't let point enter the opposite scroll
10669 margin as result of the scroll.
10670 (syms_of_xdisp) <scroll-conservatively>: Document the
10671 threshold of 100 lines for never-recentering scrolling.
10673 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10675 * dispextern.h (move_it_by_lines):
10676 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10677 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10678 (message_log_check_duplicate): Remove parameters `prev_bol' and
10679 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10680 (redisplay_internal): Remove parameter `preserve_echo_area',
10681 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10683 * indent.c (Fvertical_motion):
10684 * window.c (window_scroll_pixel_based, Frecenter):
10685 Don't pass `need_y_p' to `move_it_by_lines'.
10687 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10689 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10690 steal a few bits to be more compact.
10691 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10692 Remove unneeded casts.
10694 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10696 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10698 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10699 binding" message (bug#7967).
10701 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10703 Fix more problems found by GCC 4.6.0's static checks.
10705 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10706 Remove unused local var.
10708 * editfns.c (Fmessage_box): Remove unused local var.
10710 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10711 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10712 Omit unused local vars.
10713 * window.c (shrink_windows): Omit unused local var.
10714 * menu.c (digest_single_submenu): Omit unused local var.
10715 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10716 Omit unused local var.
10718 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10719 Don't assume string length fits in int.
10720 (keyremap_step, read_key_sequence): Use size_t for sizes.
10721 (read_key_sequence): Don't check last_real_key_start redundantly.
10723 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10724 instead of alloca (Bug#8344).
10726 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10727 (Fbacktrace_frame): Don't assume nframes fits in int.
10729 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10731 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10734 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10736 * cm.c (calccost): Turn while-do into do-while, for clarity.
10738 * keyboard.c (syms_of_keyboard): Use the same style as later
10739 in this function when indexing through an array. This also
10740 works around GCC bug 48267.
10742 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10744 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10746 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10747 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10749 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10750 This avoids undefined behavior on integer overflow, and is a bit
10751 more convenient anyway since it is compared to a size_t variable.
10753 Variadic C functions now count arguments with size_t, not int.
10754 This avoids an unnecessary limitation on 64-bit machines, which
10755 caused (substring ...) to crash on large vectors (Bug#8344).
10756 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10757 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10758 All variadic functions and their callers changed accordingly.
10759 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10760 * data.c (arith_driver, float_arith_driver): Likewise.
10761 * editfns.c (general_insert_function): Likewise.
10762 * eval.c (struct backtrace.nargs, interactive_p)
10763 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10764 (funcall_lambda, mark_backtrace): Likewise.
10765 * fns.c (concat): Likewise.
10766 * frame.c (x_set_frame_parameters): Likewise.
10767 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10768 0 if not found, not -1. All callers changed.
10770 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10771 (stack_copy_size): Now size_t, not int.
10772 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10774 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10776 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10777 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10778 All callers changed.
10780 * lisp.h (multibyte_char_to_unibyte):
10781 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10782 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10783 * character.h (CHAR_TO_BYTE8):
10784 * cmds.c (internal_self_insert):
10785 * editfns.c (general_insert_function):
10786 * keymap.c (push_key_description):
10787 * search.c (Freplace_match):
10788 * xdisp.c (message_dolog, set_message_1): All callers changed.
10790 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10792 * keyboard.c (safe_run_hook_funcall): New function.
10793 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10794 don't set the hook to nil, but remove the offending function instead.
10795 (Qcommand_hook_internal): Remove, unused.
10796 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10797 Vcommand_hook_internal.
10799 * eval.c (enum run_hooks_condition): Remove.
10800 (funcall_nil, funcall_not): New functions.
10801 (run_hook_with_args): Call each function through a `funcall' argument.
10802 Remove `cond' argument, now redundant.
10803 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10804 (Frun_hook_with_args_until_failure): Adjust accordingly.
10805 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10807 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10809 * dispextern.h (string_buffer_position): Remove declaration.
10811 * print.c (strout): Remove parameter `multibyte', unused since
10812 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10814 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10815 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10816 All callers changed.
10818 * w32.c (_wsa_errlist): Use braces for struct initializers.
10820 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10821 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10822 All callers changed.
10823 (string_buffer_position): Likewise. Also, make static (it's never
10824 used outside xdisp.c).
10825 (cursor_row_p): Remove parameter `w', unused since
10826 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10827 (decode_mode_spec): Remove parameter `precision', introduced during
10828 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10829 All callers changed.
10831 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10833 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10835 2011-03-27 Anders Lindgren <andlind@gmail.com>
10837 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10838 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10839 (ns_update_auto_hide_menu_bar): New functions.
10840 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10841 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10842 ns_constrain_all_frames.
10843 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10844 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10846 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10848 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10850 2011-03-27 Glenn Morris <rgm@gnu.org>
10852 * syssignal.h: Replace RETSIGTYPE with void.
10853 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10854 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10855 Replace SIGTYPE with void everywhere.
10856 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10857 * s/template.h (SIGTYPE): Remove commented out definition.
10859 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10861 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10862 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10864 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10866 * w32.c (read_unc_volume): Use parameter `henum', instead of
10867 global variable `wget_enum_handle'.
10869 * keymap.c (describe_vector): Remove parameters `indices' and
10870 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10871 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10873 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10875 * keyboard.c (timer_check): Remove parameter `do_it_now',
10876 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10877 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10878 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10880 * keyboard.c (read_char):
10881 * w32menu.c (w32_menu_display_help):
10882 * xmenu.c (show_help_event, menu_help_callback):
10883 Adjust calls to `show_help_echo'.
10885 * gtkutil.c (xg_maybe_add_timer):
10886 * keyboard.c (readable_events):
10887 * process.c (wait_reading_process_output):
10888 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10890 * insdel.c (adjust_markers_gap_motion):
10891 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10892 (gap_left, gap_right): Don't call it.
10894 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10896 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10897 incurred during fontification.
10899 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10901 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10902 (DEFVAR_PER_BUFFER): Don't pass it.
10904 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10905 (scrolling_window): Don't pass it.
10907 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10909 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10911 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10913 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10914 of variables specific to SELinux and computation of `encoded_absname'.
10916 * image.c (XPutPixel): Remove unused variable `height'.
10918 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10920 * unexw32.c (get_section_info): Remove unused variable `section'.
10922 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10923 (system_process_attributes): Remove unused variable `sess'.
10924 (sys_read): Remove unused variable `err'.
10926 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10927 (w32_wnd_proc): Remove unused variable `isdead'.
10928 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10929 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10930 (x_create_tip_frame): Remove unused variable `tem'.
10932 * w32inevt.c (w32_console_read_socket):
10933 Remove unused variable `no_events'.
10935 * w32term.c (x_draw_composite_glyph_string_foreground):
10936 Remove unused variable `width'.
10938 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10940 * w32term.c (x_set_glyph_string_clipping):
10941 Don't pass uninitialized region to CombineRgn.
10943 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10945 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10946 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10947 (Fx_close_connection): Remove unused variable `i'.
10949 * w32font.c (w32font_draw): Return number of glyphs.
10950 (w32font_open_internal): Remove unused variable `i'.
10951 (w32font_driver): Add missing initializer.
10953 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10954 (fill_in_menu): Remove unused variable `items_added'.
10956 * w32term.c (last_mouse_press_frame): Remove static global variable.
10957 (w32_clip_to_row): Remove unused variable `f'.
10958 (x_delete_terminal): Remove unused variable `i'.
10960 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10961 (NOTHING): Remove unused static global variable.
10962 (uniscribe_check_otf): Remove unused variable `table'.
10963 (uniscribe_font_driver): Add missing initializers.
10965 2011-03-23 Julien Danjou <julien@danjou.info>
10967 * term.c (Fsuspend_tty, Fresume_tty):
10968 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10969 * window.c (temp_output_buffer_show):
10970 * insdel.c (signal_before_change):
10971 * frame.c (Fhandle_switch_frame):
10972 * fileio.c (Fdo_auto_save):
10973 * emacs.c (Fkill_emacs):
10974 * editfns.c (save_excursion_restore):
10975 * cmds.c (internal_self_insert):
10976 * callint.c (Fcall_interactively):
10977 * buffer.c (Fkill_all_local_variables):
10978 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10980 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10981 unconditionally since it does the check itself.
10983 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10985 Fix more problems found by GCC 4.5.2's static checks.
10987 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10988 the first time through the loop, since we know p0 < p1 then.
10989 This also avoids a gcc -Wstrict-overflow warning.
10991 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10992 leading to a memory leak, possible in functions like
10993 load_charset_map_from_file that can allocate an unbounded number
10994 of objects (Bug#8318).
10996 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10997 that could (at least in theory) be that large.
10999 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11000 This is less likely to overflow, and avoids undefined behavior if
11001 overflow does occur. All callers changed. Use strtoul to scan
11002 for the unsigned long integer.
11003 (pint2hrstr): Simplify and tune code slightly.
11004 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11006 * scroll.c (do_scrolling): Work around GCC bug 48228.
11007 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11009 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11010 This also avoids a warning with gcc -Wstrict-overflow.
11011 (validate_x_resource_name): Simplify count usage.
11012 This also avoids a warning with gcc -Wstrict-overflow.
11014 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11017 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11019 * process.c (Fmake_network_process): Use socklen_t, not int,
11020 where POSIX says socklen_t is required in portable programs.
11021 This fixes a porting bug on hosts like 64-bit HP-UX, where
11022 socklen_t is wider than int (Bug#8277).
11023 (Fmake_network_process, server_accept_connection):
11024 (wait_reading_process_output, read_process_output):
11027 * process.c: Rename or move locals to avoid shadowing.
11028 (list_processes_1, Fmake_network_process):
11029 (read_process_output_error_handler, exec_sentinel_error_handler):
11030 Rename or move locals.
11031 (Fmake_network_process): Define label "retry_connect" only if needed.
11032 (Fnetwork_interface_info): Fix pointer signedness.
11033 (process_send_signal): Add cast to avoid pointer signedness problem.
11034 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11035 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11037 Make tparam.h and terminfo.c consistent.
11038 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11039 Include tparam.h instead, since it declares them.
11040 * cm.h (PC): Remove extern decl; tparam.h now does this.
11041 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11042 * terminfo.c: Include tparam.h, to check interfaces.
11043 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11044 (tparam): Adjust signature to match interface in tparam.h;
11045 this removes some undefined behavior. Check that outstring and len
11046 are zero, which they always are with Emacs.
11047 * tparam.h (PC, BC, UP): New extern decls.
11049 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11050 (xftfont_open): Rename locals to avoid shadowing.
11052 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11053 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11054 (OTF_TAG_SYM): Omit macro if not needed.
11055 (ftfont_list): Remove unused local.
11056 (get_adstyle_property, ftfont_pattern_entity):
11057 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11058 Rename locals to avoid shadowing.
11060 * xfont.c (xfont_list_family): Mark var as initialized.
11062 * xml.c (make_dom): Now static.
11064 * composite.c (composition_compute_stop_pos): Rename local to
11066 (composition_reseat_it): Remove unused locals.
11067 (find_automatic_composition, composition_adjust_point): Likewise.
11068 (composition_update_it): Mark var as initialized.
11069 (find_automatic_composition): Mark vars as initialized,
11070 with a FIXME (Bug#8290).
11072 character.h: Rename locals to avoid shadowing.
11073 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11074 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11075 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11076 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11077 to avoid shadowing.
11079 * textprop.c (property_change_between_p): Remove; unused.
11081 * intervals.c (interval_start_pos): Now static.
11083 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11085 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11086 Rename locals to avoid shadowing.
11088 * sound.c (wav_play, au_play, Fplay_sound_internal):
11089 Fix pointer signedness.
11090 (alsa_choose_format): Remove unused local var.
11091 (wav_play): Initialize a variable to 0, to prevent undefined
11092 behavior (Bug#8278).
11094 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11096 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11098 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11099 clobbering (Bug#8298).
11100 * sysdep.c (sys_subshell): Likewise.
11101 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11103 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11104 This should get cleaned up, so that child_setup has the
11105 same signature on all platforms.
11107 * callproc.c (call_process_cleanup): Now static.
11108 (relocate_fd): Rename locals to avoid shadowing.
11110 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11112 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11113 not to be necessary, and produces flickering.
11115 2011-03-20 Glenn Morris <rgm@gnu.org>
11117 * config.in: Remove file.
11119 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11121 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11122 are now in src/globals.h.
11123 (syms_of_minibuf): Remove spurious & from previous change.
11125 2011-03-20 Leo Liu <sdl.web@gmail.com>
11127 * minibuf.c (completing-read-function): New variable.
11128 (completing-read-default): Rename from completing-read.
11129 (completing-read): Call completing-read-function.
11131 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11133 * xfaces.c (Fx_load_color_file):
11134 Read color file from absolute filename (bug#8250).
11136 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11138 * makefile.w32-in: Update dependencies.
11140 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11142 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11144 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11146 Fix more problems found by GCC 4.5.2's static checks.
11148 * process.c (make_serial_process_unwind, send_process_trap):
11149 (sigchld_handler): Now static.
11151 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11152 That way, the code declares only the vars that it needs.
11153 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11154 * s/cygwin.h (PTY_ITERATION): Likewise.
11155 * s/darwin.h (PTY_ITERATION): Likewise.
11156 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11158 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11159 * process.c (allocate_pty): Don't declare stb unless it's needed.
11161 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11162 (CONSTANTLIM): Remove; unused.
11163 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11164 Define only if needed.
11166 * unexelf.c (unexec): Name an expression,
11167 to avoid gcc -Wbad-function-cast warning.
11168 Use a different way to cause a compilation error if anyone uses
11169 n rather than nn, a way that does not involve shadowing.
11170 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11172 * deps.mk (unexalpha.o): Remove; unused.
11174 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11175 * unexec.h: New file.
11176 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11177 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11178 Depend on unexec.h.
11179 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11180 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11181 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11182 Change as necessary to match prototype in unexec.h.
11184 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11186 (back_comment, skip_chars): Mark vars as initialized.
11188 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11189 Rename locals to avoid shadowing.
11191 * lread.c (read1): Rewrite so as not to use empty "else".
11192 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11194 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11196 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11197 warning when compiling print.c.
11199 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11200 instead of using an uninitialized var.
11201 (font_sort_entities): Mark var as initialized.
11203 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11205 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11206 pointers to constants.
11207 (font_parse_fcname): Remove unused vars.
11208 (font_delete_unmatched): Now static.
11209 (font_get_spec): Remove; unused.
11210 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11211 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11212 Rename or move locals to avoid shadowing.
11214 * fns.c (require_nesting_list, require_unwind): Now static.
11215 (Ffillarray): Rename locals to avoid shadowing.
11217 * floatfns.c (domain_error2): Define only if needed.
11218 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11220 * alloc.c (mark_backtrace): Move decl from here ...
11221 * lisp.h: ... to here, so that it can be checked.
11223 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11224 (Fdefvar): Rewrite so as not to use empty "else".
11225 (lisp_indirect_variable): Name an expression,
11226 to avoid gcc -Wbad-function-cast warning.
11227 (Fdefvar): Rename locals to avoid shadowing.
11229 * callint.c (quotify_arg, quotify_args): Now static.
11230 (Fcall_interactively): Rename locals to avoid shadowing.
11231 Use const pointer when appropriate.
11233 * lisp.h (get_system_name, get_operating_system_release):
11234 Move decls here, to check interfaces.
11235 * process.c (get_operating_system_release): Move decl to lisp.h.
11236 * xrdb.c (get_system_name): Likewise.
11237 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11238 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11239 some of which prompt warnings from gcc -Wbad-function-cast.
11240 (Fformat_time_string, Fencode_time, Finsert_char):
11241 (Ftranslate_region_internal, Fformat):
11242 Rename or remove local vars to avoid shadowing.
11243 (Ftranslate_region_internal): Mark var as initialized.
11245 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11248 * lisp.h (eassert): Check that the argument compiles, even if
11249 ENABLE_CHECKING is not defined.
11251 * data.c (Findirect_variable): Name an expression, to avoid
11252 gcc -Wbad-function-cast warning.
11253 (default_value, arithcompare, arith_driver, arith_error): Now static.
11254 (store_symval_forwarding): Rename local to avoid shadowing.
11255 (Fmake_variable_buffer_local, Fmake_local_variable):
11256 Mark variables as initialized.
11257 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11259 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11260 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11261 Rename locals to avoid shadowing.
11262 (mark_stack): Move local variables into the #ifdef region where
11264 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11265 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11267 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11268 (GC_STRING_CHARS): Remove; not used.
11269 (Fmemory_limit): Cast sbrk's returned value to char *.
11271 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11272 avoids undefined behavior in theory.
11274 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11276 Use functions, not macros, for up- and down-casing (Bug#8254).
11277 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11278 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11279 to use the following functions instead of these macros.
11280 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11281 EMACS_INT, since callers assume the returned value fits in int.
11282 (upcase1): Likewise, for UPCASE_TABLE.
11283 (uppercasep, lowercasep, upcase): New static inline functions.
11284 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11285 the race-condition problem in the old DOWNCASE.
11287 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11288 Rename locals to avoid shadowing.
11289 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11290 (regex_compile, re_search_2, re_match_2_internal):
11291 Remove unused local vars.
11292 (FREE_VAR): Rewrite so as not to use empty "else",
11293 which gcc can warn about.
11294 (regex_compile, re_match_2_internal): Mark locals as initialized.
11295 (RETALLOC_IF): Define only if needed.
11296 (WORDCHAR_P): Likewise. This one is never needed, but is used
11297 only in a comment talking about a compiler bug, so put inside
11298 the #if 0 of that comment.
11299 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11300 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11303 * search.c (boyer_moore): Rename locals to avoid shadowing.
11304 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11305 (PREV_CHAR_BOUNDARY): Likewise.
11307 * search.c (simple_search): Remove unused var.
11309 * dired.c (compile_pattern): Move decl from here ...
11310 * lisp.h: ... to here, so that it can be checked.
11311 (struct re_registers): New forward decl.
11313 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11315 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11317 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11318 Rename locals to avoid shadowing.
11319 (Fvertical_motion): Mark locals as initialized.
11321 * casefiddle.c (casify_object, casify_region): Now static.
11322 (casify_region): Mark local as initialized.
11324 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11326 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11327 New macros, so that the caller can use some names other than
11328 gcpro1, gcpro2, etc.
11329 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11331 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11332 argument, for consistency with GCPRO2_VAR, etc: it is now the
11333 prefix of the variable, not the variable itself. All uses
11335 * dired.c (directory_files_internal, file_name_completion):
11336 Rename locals to avoid shadowing.
11338 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11339 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11340 dired.c's scmp function, had undefined behavior.
11341 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11342 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11343 * buffer.h: ... to here, because these macros use current_buffer,
11344 and the new implementation with inline functions needs to have
11345 current_buffer in scope now, rather than later when the macros
11347 (downcase, upcase1): New static inline functions.
11348 (DOWNCASE, UPCASE1): Reimplement using these functions.
11349 This avoids undefined behavior in expressions like
11350 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11351 from race conditions in accessing the global variables
11352 case_temp1 and case_temp2.
11353 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11354 * lisp.h (case_temp1, case_temp2): Remove their decls.
11355 * character.h (ASCII_CHAR_P): Move from here ...
11356 * lisp.h: ... to here, so that the inline functions mentioned
11357 above can use them.
11359 * dired.c (directory_files_internal_unwind): Now static.
11361 * fileio.c (file_name_as_directory, directory_file_name):
11362 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11364 (file_name_as_directory): Use const pointers when appropriate.
11365 (Fexpand_file_name): Likewise. In particular, newdir might
11366 point at constant storage, so make it a const pointer.
11367 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11368 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11370 (Fset_file_times, Finsert_file_contents, auto_save_error):
11371 Rename locals to avoid shadowing.
11373 * minibuf.c (choose_minibuf_frame_1): Now static.
11374 (Ftry_completion, Fall_completions): Rename or remove locals
11375 to avoid shadowing.
11377 * marker.c (bytepos_to_charpos): Remove; unused.
11379 * lisp.h (verify_bytepos, count_markers): New decls,
11380 so that gcc does not warn that these functions aren't declared.
11382 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11383 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11384 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11385 (copy_text): Remove unused local var.
11387 * filelock.c (within_one_second): Now static.
11388 (lock_file_1): Rename local to avoid shadowing.
11390 * buffer.c (fix_overlays_before): Mark locals as initialized.
11391 (fix_start_end_in_overlays): Likewise. This function should be
11392 simplified by using pointers-to-pointers, but that's a different
11394 (switch_to_buffer_1): Now static.
11395 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11396 (report_overlay_modification): Rename locals to avoid shadowing.
11398 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11399 Fix pointer signedness issue.
11400 (sys_subshell): Mark local as volatile if checking for lint,
11401 to suppress a gcc -Wclobbered warning that does not seem to be right.
11402 (MAXPATHLEN): Define only if needed.
11404 * process.c (serial_open, serial_configure): Move decls from here ...
11405 * systty.h: ... to here, so that they can be checked.
11407 * fns.c (get_random, seed_random): Move extern decls from here ...
11408 * lisp.h: ... to here, so that they can be checked.
11410 * sysdep.c (reset_io): Now static.
11411 (wait_for_termination_signal): Remove; unused.
11413 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11414 (copy_keymap_item, append_key, push_text_char_description):
11416 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11417 (DENSE_TABLE_SIZE): Remove; unused.
11418 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11419 (describe_map_tree):
11420 Rename locals to avoid shadowing.
11422 * keyboard.c: Declare functions static if they are not used elsewhere.
11423 (echo_char, echo_dash, cmd_error, top_level_2):
11424 (poll_for_input, handle_async_input): Now static.
11425 (read_char, kbd_buffer_get_event, make_lispy_position):
11426 (make_lispy_event, make_lispy_movement, apply_modifiers):
11427 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11428 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11429 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11430 (read_key_sequence, read_char): Mark locals as initialized.
11431 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11433 * keyboard.h (make_ctrl_char): New decl.
11434 (mark_kboards): Move decl here ...
11435 * alloc.c (mark_kboards): ... from here.
11437 * lisp.h (force_auto_save_soon): New decl.
11439 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11440 (DEFINE_DUMMY_FUNCTION): New macro.
11441 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11443 (main): Add casts to avoid warnings
11444 if GCC considers string literals to be constants.
11446 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11448 * dbusbind.c: Pointer signedness fixes.
11449 (xd_signature, xd_append_arg, xd_initialize):
11450 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11451 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11452 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11453 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11455 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11456 if GCC considers string literals to be constants.
11457 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11459 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11461 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11462 (print_preprocess, print_object): New macro to fix last change.
11464 * print.c (print_preprocess): Don't forget font objects.
11466 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11468 * emacs.c (USAGE3): Doc fixes.
11470 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11472 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11475 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11477 * lisp.h (VWindow_system, Qfile_name_history):
11478 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11479 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11480 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11482 * w32select.c: Don't #include "keyboard.h".
11483 (run_protected): Add extern declaration for waiting_for_input.
11485 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11486 * w32console.c (detect_input_pending, read_input_pending)
11487 (encode_terminal_code):
11488 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11489 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11490 (w32_system_caret_y, Qfile_name_history):
11491 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11492 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11493 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11494 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11495 * w32proc.c (Qlocal, report_file_error):
11496 * w32term.c (Vwindow_system, updating_frame):
11497 * w32uniscribe.c (initialized, uniscribe_font_driver):
11498 Remove unneeded extern declarations.
11500 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11502 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11504 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11506 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11507 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11508 These macros can no longer be used for assignment.
11510 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11511 Assign struct members directly, instead of using BUF_BEGV etc.
11512 (record_buffer_markers, fetch_buffer_markers): New functions for
11513 recording and fetching special buffer markers.
11514 (set_buffer_internal_1, set_buffer_temp): Use them.
11516 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11518 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11520 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11521 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11523 * xdisp.c (hscroll_window_tree):
11524 (reconsider_clip_changes): Use PT instead of BUF_PT.
11526 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11528 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11529 $(EMACS_ROOT)/lib/intprops.h.
11531 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11533 Fix more problems found by GCC 4.5.2's static checks.
11535 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11536 to unsigned char * to avoid compiler diagnostic.
11537 (xg_free_frame_widgets): Make it clear that a local variable is
11538 needed only if USE_GTK_TOOLTIP.
11539 (gdk_window_get_screen): Make it clear that this macro is needed
11540 only if USE_GTK_TOOLTIP.
11541 (int_gtk_range_get_value): New function, which avoids a diagnostic
11542 from gcc -Wbad-function-cast.
11543 (xg_set_toolkit_scroll_bar_thumb): Use it.
11544 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11545 diagnostic from gcc -Wbad-function-cast.
11546 (get_utf8_string, xg_get_file_with_chooser):
11547 Rename locals to avoid shadowing.
11548 (create_dialog): Move locals to avoid shadowing.
11550 * xgselect.c (xg_select): Remove unused var.
11552 * image.c (four_corners_best): Mark locals as initialized.
11553 (gif_load): Initialize transparent_p to zero (Bug#8238).
11554 Mark another local as initialized.
11555 (my_png_error, my_error_exit): Mark with NO_RETURN.
11557 * image.c (clear_image_cache): Now static.
11558 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11559 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11560 (x_edge_detection): Remove unnecessary cast that
11561 gcc -Wbad-function-cast diagnoses.
11562 (gif_load): Fix pointer signedness.
11563 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11564 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11566 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11568 Improve quality of tests for time stamp overflow.
11569 For example, without this patch (encode-time 0 0 0 1 1
11570 1152921504606846976) returns the obviously-bogus value (-948597
11571 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11572 reports time overflow. See
11573 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11574 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11575 * editfns.c: Include limits.h and intprops.h.
11576 (TIME_T_MIN, TIME_T_MAX): New macros.
11577 (time_overflow): Move earlier, to before first use.
11578 (hi_time, lo_time): New functions, for an accurate test for
11579 out-of-range times.
11580 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11581 (Fget_internal_run_time): Don't assume time_t fits in int.
11582 (make_time): Use list2 instead of Fcons twice.
11583 (Fdecode_time): More accurate test for out-of-range times.
11584 (check_tm_member): New function.
11585 (Fencode_time): Use it, to test for out-of-range times.
11586 (lisp_time_argument): Don't rely on undefined left-shift and
11587 right-shift behavior when checking for time stamp overflow.
11589 * editfns.c (time_overflow): New function, refactoring common code.
11590 (Fformat_time_string, Fdecode_time, Fencode_time):
11591 (Fcurrent_time_string): Use it.
11593 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11594 * dired.c (make_time): Move to ...
11595 * editfns.c (make_time): ... here.
11596 * systime.h: Note the move.
11598 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11600 * fringe.c (update_window_fringes): Remove unused variables.
11602 * unexmacosx.c (copy_data_segment): Also copy __got section.
11605 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11607 * termcap.c [MSDOS]: Include "msdos.h".
11608 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11609 Constify `char *' arguments and their references according to
11610 prototypes in tparam.h.
11612 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11614 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11615 Adapt all references accordingly.
11617 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11619 2011-03-11 Tom Tromey <tromey@redhat.com>
11621 * buffer.c (syms_of_buffer): Remove obsolete comment.
11623 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11625 * termhooks.h (encode_terminal_code): Declare prototype.
11627 * msdos.c (encode_terminal_code): Don't declare prototype.
11629 * term.c (encode_terminal_code): Now external again, used by
11630 w32console.c and msdos.c.
11632 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11633 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11635 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11637 Fix some minor problems found by GCC 4.5.2's static checks.
11639 * fringe.c (update_window_fringes): Mark locals as initialized
11641 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11643 * alloc.c (mark_fringe_data): Move decl from here ...
11644 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11645 to check its interface.
11646 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11648 * fontset.c (free_realized_fontset): Now static.
11649 (Fset_fontset_font): Rename local to avoid shadowing.
11650 (fontset_font): Mark local as initialized.
11651 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11653 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11655 * xselect.c (x_disown_buffer_selections): Remove; not used.
11656 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11657 (x_own_selection, Fx_disown_selection_internal): Rename locals
11658 to avoid shadowing.
11659 (x_handle_dnd_message): Remove local to avoid shadowing.
11661 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11662 so that the caller can use some name other than gcpro1.
11663 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11664 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11665 (Fx_backspace_delete_keys_p):
11666 Use them to avoid shadowing, and rename vars to avoid shadowing.
11667 (x_decode_color, x_set_name, x_window): Now static.
11668 (Fx_create_frame): Add braces to silence GCC warning.
11669 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11670 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11671 Remove unused locals.
11672 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11673 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11674 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11677 * xterm.h (x_mouse_leave): New decl.
11679 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11680 Remove unused functions.
11681 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11682 (x_calc_absolute_position): Now static.
11683 (XTread_socket): Don't define label "out" unless it's used.
11684 Don't declare local "event" unless it's used.
11685 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11686 unless they are used.
11687 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11688 (x_fatal_error_signal): Remove; not used.
11689 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11690 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11691 (x_error_catcher, x_connection_closed, x_error_handler):
11692 (x_error_quitter, xembed_send_message, x_iconify_frame):
11693 (my_log_handler): Rename locals to avoid shadowing.
11694 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11695 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11697 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11698 Rename or move locals to avoid shadowing.
11699 (tty_defined_color, merge_face_heights): Now static.
11700 (free_realized_faces_for_fontset): Remove; not used.
11701 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11702 does not deduce is never used uninitialized.
11703 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11704 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11706 * terminal.c (store_terminal_param): Now static.
11708 * xmenu.c (menu_highlight_callback): Now static.
11709 (set_frame_menubar): Remove unused local.
11710 (xmenu_show): Rename parameter to avoid shadowing.
11711 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11712 since they might point to immutable storage.
11713 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11714 since it's unused otherwise.
11716 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11717 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11718 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11719 avoids a gcc -Wuninitialized diagnostic.
11720 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11721 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11722 does not deduce are never used uninitialized.
11724 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11726 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11727 * window.c (window_loop, size_window):
11728 (run_window_configuration_change_hook, enlarge_window): Likewise.
11730 * window.c (display_buffer): Now static.
11731 (size_window): Mark variables that gcc -Wuninitialized
11732 does not deduce are never used uninitialized.
11733 * window.h (check_all_windows): New decl, to forestall
11734 gcc -Wmissing-prototypes diagnostic.
11735 * dispextern.h (bidi_dump_cached_states): Likewise.
11737 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11739 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11740 Include <limits.h>.
11741 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11742 and to avoid gcc -Wuninitialized warning.
11743 (load_charset_map): Mark variables that gcc -Wuninitialized
11744 does not deduce are never used uninitialized.
11745 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11747 * coding.c (coding_set_source, coding_set_destination):
11748 Use "else { /* comment */ }" rather than "else /* comment */;"
11749 for clarity, and to avoid gcc -Wempty-body warning.
11750 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11751 a block, when the outer 'i' will do.
11752 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11753 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11754 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11755 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11756 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11757 Rename locals to avoid shadowing.
11758 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11759 * coding.c (emacs_mule_char, encode_invocation_designation):
11760 Now static, since they're not used elsewhere.
11761 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11762 (decode_coding_object, encode_coding_object, detect_coding_system):
11763 (decode_coding_emacs_mule): Mark variables that gcc
11764 -Wuninitialized does not deduce are never used uninitialized.
11765 (detect_coding_iso_2022): Initialize a local variable that might
11766 be used uninitialized. Leave a FIXME because it's not clear that
11767 this initialization is needed. (Bug#8211)
11768 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11769 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11770 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11771 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11772 Remove unused macros.
11774 * category.c (hash_get_category_set): Remove unused local var.
11775 (copy_category_table): Now static, since it's not used elsewhere.
11776 * character.c (string_count_byte8): Likewise.
11778 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11779 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11781 * chartab.c (copy_sub_char_table): Now static, since it's not used
11783 (sub_char_table_ref_and_range, char_table_ref_and_range):
11784 Rename locals to avoid shadowing.
11785 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11787 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11788 (BIDI_BOB): Remove unused macro.
11790 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11791 deduce are never used uninitialized.
11792 * term.c (encode_terminal_code): Likewise.
11794 * term.c (encode_terminal_code): Now static. Remove unused local.
11796 * tparam.h: New file.
11797 * term.c, tparam.h: Include it.
11798 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11799 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11800 Move these decls to tparam.h, and make them agree with what
11801 is actually in tparam.c. The previous trick of using incompatible
11802 decls in different modules does not conform to the C standard.
11803 All callers of tparam changed to use tparam's actual API.
11804 * tparam.c (tparam1, tparam, tgoto):
11805 Use const pointers where appropriate.
11807 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11808 * cm.h (struct cm): Likewise.
11809 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11810 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11811 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11812 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11813 (turn_on_face, init_tty): Likewise.
11814 * termchar.h (struct tty_display_info): Likewise.
11816 * term.c (term_mouse_position): Rename local to avoid shadowing.
11818 * alloc.c (mark_ttys): Move decl from here ...
11819 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11821 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11823 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11825 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11827 * search.c (compile_pattern_1): Remove argument regp, unused since
11828 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11829 (compile_pattern): Don't pass it.
11831 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11833 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11834 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11836 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11838 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11840 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11841 gdk_window_get_screen, gdk_window_get_geometry,
11842 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11843 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11844 (xg_get_pixbuf_from_pixmap): New function.
11845 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11846 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11847 Call xg_get_pixbuf_from_pixmap instead of
11848 gdk_pixbuf_get_from_drawable.
11849 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11850 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11851 (xg_check_special_colors): Use GtkStyleContext and its functions
11853 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11854 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11855 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11856 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11857 Call gtk_widget_get_preferred_size.
11858 (xg_frame_resized): gdk_window_get_geometry only takes 5
11860 (xg_win_to_widget, xg_event_is_for_menubar):
11861 Call gdk_x11_window_lookup_for_display.
11862 (xg_set_widget_bg): New function.
11863 (delete_cb): New function.
11864 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11865 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11866 (xg_set_background_color): Call xg_set_widget_bg.
11867 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11868 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11869 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11870 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11872 (update_frame_tool_bar): Call gtk_widget_hide.
11873 (xg_initialize): Use GDK_KEY_g.
11875 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11877 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11879 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11880 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11881 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11883 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11885 * w32xfns.c (select_palette): Check success of RealizePalette against
11886 GDI_ERROR, not zero.
11888 See ChangeLog.11 for earlier changes.
11890 ;; Local Variables:
11894 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11896 This file is part of GNU Emacs.
11898 GNU Emacs is free software: you can redistribute it and/or modify
11899 it under the terms of the GNU General Public License as published by
11900 the Free Software Foundation, either version 3 of the License, or
11901 (at your option) any later version.
11903 GNU Emacs is distributed in the hope that it will be useful,
11904 but WITHOUT ANY WARRANTY; without even the implied warranty of
11905 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11906 GNU General Public License for more details.
11908 You should have received a copy of the GNU General Public License
11909 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.