1 2011-09-21 Paul Eggert <eggert@cs.ucla.edu>
3 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
4 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
5 (string_bytes, check_sblock, allocate_string_data):
6 (compact_small_strings, Fmake_bool_vector, make_string)
7 (make_unibyte_string, make_multibyte_string)
8 (make_string_from_bytes, make_specified_string)
9 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
10 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
12 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
13 (allocate_pseudovector):
14 Use int, not EMACS_INT, where int is wide enough.
15 (inhibit_garbage_collection, Fgarbage_collect):
16 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
17 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
18 int might not be wide enough.
19 (bidi_cache_search, bidi_cache_find, bidi_init_it)
20 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
21 (bidi_at_paragraph_end, bidi_find_paragraph_start)
22 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
23 (bidi_level_of_next_char, bidi_move_to_visually_next):
24 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
25 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
26 (Fkill_buffer, Fset_buffer_major_mode)
27 (advance_to_char_boundary, Fbuffer_swap_text)
28 (Fset_buffer_multibyte, overlays_at, overlays_in)
29 (overlay_touches_p, struct sortvec, record_overlay_string)
30 (overlay_strings, recenter_overlay_lists)
31 (adjust_overlays_for_insert, adjust_overlays_for_delete)
32 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
33 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
34 (Foverlay_recenter, last_overlay_modification_hooks_used)
35 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
36 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
37 (validate_region): Omit unnecessary test for b <= e, since
38 that's guaranteed by the previous test.
39 (adjust_overlays_for_delete): Avoid pos + length overflow.
40 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
41 (report_overlay_modification):
42 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
43 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
44 Omit pointer cast, which isn't needed anyway, and doesn't work
45 after the EMACS_INT -> ptrdiff_t change.
46 * buffer.h: Adjust decls to match defn changes elsewhere.
47 (struct buffer_text, struct buffer):
48 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
49 Use EMACS_INT, not int, where int might not be wide enough.
50 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, to avoid
51 needless 32-bit limit on 64-bit hosts. Remove unnecessary
52 memory-full test. Use EMACS_INT, not ptrdiff_t or int, where
53 ptrdiff_t or int might not be wide enough.
54 * callint.c (Fcall_interactively):
55 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
56 * callproc.c (call_process_kill, Fcall_process):
57 Don't assume pid_t fits into an Emacs fixnum.
58 (call_process_cleanup, Fcall_process, child_setup):
59 Don't assume pid_t fits into int.
60 (call_process_cleanup, Fcall_process, delete_temp_file)
61 (Fcall_process_region):
62 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
63 (Fcall_process): Simplify handling of volatile integers.
64 Use int, not EMACS_INT, where int will do.
65 * casefiddle.c (casify_object, casify_region, operate_on_word)
66 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
67 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
68 (casify_object): Avoid integer overflow when overallocating buffer.
69 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
71 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
72 * category.h (CATEGORYP): Don't assume arg is nonnegative.
73 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
74 integers are now checked earlier. All uses replaced with XINT.
76 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
77 For CCL_MapSingle, check that content and value are in int range.
78 (resolve_symbol_ccl_program): Check that vector header is in range.
79 Always copy the vector, so that we can check its contents reliably
80 now rather than having to recheck each instruction as it's being
81 executed. Check that vector words fit in 'int'.
82 (ccl_get_compiled_code, Fregister_ccl_program)
83 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
84 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
85 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
86 contents are in range.
87 (Fccl_execute_on_string): Check that status is in range.
88 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
89 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
90 Accept and return EMACS_INT, not int, because callers can pass values
92 (c_string_width, strwidth, lisp_string_width, chars_in_text)
93 (multibyte_chars_in_text, parse_str_as_multibyte)
94 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
95 (str_as_unibyte, str_to_unibyte, string_count_byte8)
96 (string_escape_byte8, Fget_byte):
97 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
98 (Funibyte_string): Use CHECK_CHARACTER, not CHECK_NATNUM, to
99 avoid mishandling large integers.
100 * character.h: Adjust decls to match defn changes elsewhere.
101 * charset.c (load_charset_map_from_file, find_charsets_in_text)
102 (Ffind_charset_region):
103 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
104 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
105 (load_charset_map_from_vector, Fdefine_charset_internal):
106 Don't assume fixnum fits in int or unsigned int.
107 (load_charset_map_from_vector, Fmap_charset_chars):
108 Remove now-unnecessary CHECK_NATNUMs.
109 (Fdefine_charset_internal): Check ranges here, more carefully.
110 * chartab.c (Fmake_char_table, Fset_char_table_range)
111 (uniprop_get_decoder, uniprop_get_encoder):
112 Don't assume fixnum fits in int.
113 * cmds.c (move_point): New function, that does the gist of
114 Fforward_char and Fbackward_char, but does so while checking
115 for integer overflow more accurately.
116 (Fforward_char, Fbackward_char, internal_self_insert): Use it.
117 (Fforward_line, Fend_of_line, internal_self_insert)
118 (internal_self_insert):
119 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
120 Fix a FIXME, by checking for integer overflow when calculating
121 target_clm and actual_clm.
122 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
123 (ASSURE_DESTINATION, coding_alloc_by_realloc)
124 (coding_alloc_by_making_gap, alloc_destination)
125 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
126 (encode_coding_utf_16, detect_coding_emacs_mule)
127 (decode_coding_emacs_mule, encode_coding_emacs_mule)
128 (detect_coding_iso_2022, decode_coding_iso_2022)
129 (encode_invocation_designation, encode_designation_at_bol)
130 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
131 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
132 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
133 (encode_coding_ccl, encode_coding_raw_text)
134 (detect_coding_charset, decode_coding_charset)
135 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
136 (produce_composition, produce_charset, produce_annotation)
137 (decode_coding, handle_composition_annotation)
138 (handle_charset_annotation, consume_chars, decode_coding_gap)
139 (decode_coding_object, encode_coding_object, detect_coding_system)
140 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
141 (code_convert_region, code_convert_string)
142 (Fdefine_coding_system_internal):
143 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
144 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
145 (Fdefine_coding_system_internal):
146 Don't assume fixnums fit in int.
147 (decode_coding_gap, decode_coding_object, encode_coding_object)
148 (Fread_coding_system, Fdetect_coding_region, Funencodable_char_position)
149 (Fcheck_coding_systems_region):
150 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
151 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
152 (Fdefine_coding_system_internal): Check for charset-id overflow.
153 * coding.h: Adjust decls to match defn changes elsewhere.
154 (struct coding_system):
155 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
156 * composite.c (get_composition_id, find_composition)
157 (run_composition_function, update_compositions)
158 (compose_text, composition_gstring_put_cache)
159 (composition_gstring_p, composition_gstring_width)
160 (fill_gstring_header, fill_gstring_body, autocmp_chars)
161 (composition_compute_stop_pos, composition_reseat_it)
162 (composition_update_it, struct position_record)
163 (find_automatic_composition, composition_adjust_point)
164 (Fcomposition_get_gstring, Ffind_composition_internal):
165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
166 (update_compositions):
167 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
168 * composite.h: Adjust decls to match defn changes elsewhere.
169 (struct composition):
170 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
171 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
172 Do not attempt to compute the address of the object just before a
173 buffer; this is not portable.
175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
176 (Faset): Use int, not EMACS_INT, where int is wide enough.
177 (Fstring_to_number): Don't assume fixnums fit in int.
178 (Frem): Don't assume arg is nonnegative.
179 * dbusbind.c (xd_append_arg): Check for integers out of range.
180 (Fdbus_call_method): Don't overflow the timeout int.
181 * dired.c (directory_files_internal, file_name_completion, scmp)
182 (file_name_completion_stat):
183 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
184 (file_name_completion): Don't overflow matchcount.
185 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
186 * dispextern.h: Adjust decls to match defn changes elsewhere.
187 (struct text_pos, struct glyph, struct bidi_saved_info)
188 (struct bidi_string_data, struct bidi_it, struct composition_it)
190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
191 (struct display_pos, struct composition_it, struct it):
192 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
193 * dispnew.c (increment_matrix_positions)
194 (increment_row_positions, mode_line_string)
195 (marginal_area_string):
196 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
197 (change_frame_size_1, Fredisplay):
198 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
199 (duration_to_sec_usec): New function, to check for overflow better.
200 (Fsleep_for, sit_for): Use it.
201 * doc.c (get_doc_string, store_function_docstring):
202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
203 (get_doc_string, Fsnarf_documentation):
204 Use int, not EMACS_INT, where int is wide enough.
206 Use SAFE_ALLOCA, not alloca.
207 Check for overflow when converting EMACS_INT to off_t.
209 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
210 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
211 Don't assume uid_t fits into fixnum.
212 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
213 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
214 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
215 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
216 (general_insert_function)
217 (Finsert_char, make_buffer_string, make_buffer_string_both)
218 (update_buffer_properties, Fbuffer_substring)
219 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
220 (Fsubst_char_in_region, check_translation)
221 (Ftranslate_region_internal, save_restriction_restore, Fformat)
222 (transpose_markers, Ftranspose_regions):
223 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
224 (clip_to_bounds): Move to lisp.h as an inline function).
225 (Fconstrain_to_field): Don't assume integers are nonnegative.
226 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
227 (Fsubst_char_in_region, Fsave_restriction):
228 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
229 (Femacs_pid): Don't assume pid_t fits into fixnum.
230 (lo_time): Use int, not EMACS_INT, when int suffices.
231 (lisp_time_argument): Check for usec out of range.
232 (Fencode_time): Don't assume fixnum fits in int.
233 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
234 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
235 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
236 (init_cmdargs, Fdump_emacs):
237 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
238 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
239 the bottom (typically) 32 bits of the fixnum.
240 * eval.c (specpdl_size, call_debugger):
241 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
242 (when_entered_debugger, Fbacktrace_debug):
243 Don't assume fixnum can fit in int.
244 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
245 the object just before a buffer; this is not portable.
246 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
247 (grow_specpdl, unbind_to):
248 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
249 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
250 (grow_specpdl): Simplify allocation by using xpalloc.
251 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
252 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
253 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
254 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
256 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
257 (Fcopy_file, non_regular_nbytes, read_non_regular)
258 (Finsert_file_contents):
259 Use int, not EMACS_INT, where int is wide enough.
260 (READ_BUF_SIZE): Verify that it fits in int.
261 (Finsert_file_contents): Check that counts are in proper range,
262 rather than assuming fixnums fit into ptrdiff_t etc.
263 Don't assume fixnums fit into int.
264 (Fdo_auto_save, Fset_buffer_auto_saved)
265 (Fclear_buffer_auto_save_failure):
266 Don't assume time_t is signed, or that it fits in int.
267 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec)
268 (concat, string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
269 (string_char_to_byte, string_byte_to_char)
270 (string_make_multibyte, string_to_multibyte)
271 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
272 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
273 (substring_both, Fdelete, internal_equal, Ffillarray)
274 (Fclear_string, mapcar1)
275 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
276 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
277 (larger_vector, make_hash_table, maybe_resize_hash_table)
278 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
279 (Fmaphash, secure_hash):
280 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
281 (concat): Check for string index and length overflow.
282 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
284 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
285 (larger_vector): New API (vec, incr_min, size_max) replaces old
286 one (vec, new_size, init). This catches size overflow.
287 INIT was removed because it was always Qnil.
289 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
290 the upper bound on a hash table index size.
291 (make_hash_table, maybe_resize_hash_table): Use it.
292 (secure_hash): Computer start_byte and end_byte only after
293 they're known to be in ptrdiff_t range.
294 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
295 (Ffont_get_glyphs, Ffont_at):
296 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
297 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
298 (Flist_fonts, Fopen_font):
299 Don't assume fixnum can fit in int.
300 (check_gstring): Don't assume index can fit in int.
301 (font_match_p): Check that fixnum is a character, not a nonnegative
302 fixnum, since the later code needs to stuff it into an int.
303 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
304 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
305 conversion overflow issues.
306 (Fopen_font): Check for integer out of range.
307 (Ffont_get_glyphs): Don't assume index can fit in int.
308 * font.h: Adjust decls to match defn changes elsewhere.
309 * fontset.c (reorder_font_vector): Redo score calculation to avoid
311 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
312 printmax_t, where ptrdiff_t is wide enough.
313 (Finternal_char_font):
314 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
315 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
316 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
317 (Fset_frame_position, x_set_frame_parameters)
318 (x_set_line_spacing, x_set_border_width)
319 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
320 Check that fixnums are in proper range for system types.
321 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
322 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
323 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
324 Use SAFE_ALLOCA_LISP, not alloca.
325 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
326 intptr_t is wide enough.
327 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
328 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
329 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
330 Check for fixnum out of range.
331 * ftfont.c (ftfont_list): Don't assume index fits in int.
332 Check that fixnums are in proper range for system types.
333 (ftfont_shape_by_flt):
334 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
335 Remove no-longer-needed lint_assume.
336 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
337 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
338 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
339 Check that fixnums are in proper range for system types.
340 * gnutls.h: Adjust decls to match defn changes elsewhere.
341 * gtkutil.c (xg_dialog_run):
342 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
343 (update_frame_tool_bar):
344 Check that fixnums are in proper range for system types.
345 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
346 (lookup_image): Check that fixnums are in proper range for system types.
347 * indent.c (last_known_column, last_known_column_point):
348 (current_column_bol_cache):
349 (skip_invisible, current_column, check_display_width):
350 (check_display_width, scan_for_column, current_column_1)
351 (Findent_to, Fcurrent_indentation, position_indentation)
352 (indented_beyond_p, Fmove_to_column, compute_motion):
353 (Fcompute_motion, Fvertical_motion):
354 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
355 (last_known_column_modified): Use EMACS_INT, not int.
356 (check_display_width):
358 Check that fixnums and floats are in proper range for system types.
359 (compute_motion): Don't assume index or fixnum fits in int.
360 (compute_motion, Fcompute_motion):
361 Use int, not EMACS_INT, when it is wide enough.
362 (vmotion): Omit local var start_hpos that is always 0; that way
363 we don't need to worry about overflow in expressions involving it.
364 * indent.h: Adjust decls to match defn changes elsewhere.
366 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
367 Use int, not EMACS_INT, where int is wide enough.
368 Remove unused members ovstring_chars_done and tab_offset;
370 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
371 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
372 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
373 (make_gap, copy_text, insert, insert_and_inherit)
374 (insert_before_markers, insert_before_markers_and_inherit)
375 (insert_1, count_combining_before, count_combining_after)
376 (insert_1_both, insert_from_string)
377 (insert_from_string_before_markers, insert_from_string_1)
378 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
379 (adjust_after_replace, adjust_after_insert, replace_range)
380 (replace_range_2, del_range, del_range_1, del_range_byte)
381 (del_range_both, del_range_2, modify_region)
382 (prepare_to_modify_buffer, signal_before_change)
383 (signal_after_change, Fcombine_after_change_execute):
384 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
385 * intervals.c (traverse_intervals, rotate_right, rotate_left)
386 (balance_an_interval, split_interval_right, split_interval_left)
387 (find_interval, next_interval, update_interval)
388 (adjust_intervals_for_insertion, delete_node, delete_interval)
389 (interval_deletion_adjustment, adjust_intervals_for_deletion)
390 (static_offset_intervals, offset_intervals)
391 (merge_interval_right, merge_interval_left, make_new_interval)
392 (graft_intervals_into_buffer, temp_set_point_both)
393 (temp_set_point, set_point, adjust_for_invis_intang)
394 (set_point_both, move_if_not_intangible, get_property_and_range)
395 (get_local_map, copy_intervals, copy_intervals_to_string)
396 (compare_string_intervals, set_intervals_multibyte_1):
397 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
398 * intervals.h: Adjust decls to match defn changes elsewhere.
400 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
401 * keyboard.c (this_command_key_count, this_single_command_key_start)
402 (before_command_key_count, before_command_echo_length, echo_now)
403 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
404 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
405 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
406 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
407 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
408 (last_non_minibuf_size, last_point_position, echo_truncate)
409 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
410 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
411 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
412 (stuff_buffered_input):
413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
414 (last_auto_save, command_loop_1, read_char):
415 Use EMACS_INT, not int, to avoid integer overflow.
416 (record_char): Avoid overflow in total_keys computation.
417 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
418 * keyboard.h: Adjust decls to match defn changes elsewhere.
419 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
420 (Fkey_description, Fdescribe_vector, Flookup_key):
421 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
422 (click_position): New function, to check that positions are in range.
423 (Fcurrent_active_maps):
425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
426 (Faccessible_keymaps, Fkey_description):
427 (preferred_sequence_p):
428 Don't assume fixnum can fit into int.
429 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
430 Check for integer overflow in size calculations.
431 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
432 avoid mishandling large integers.
433 * lisp.h: Adjust decls to match defn changes elsewhere.
434 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
435 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
436 (struct Lisp_Marker):
437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
438 (clip_to_bounds): Now an inline function, moved here from editfns.c.
439 (XSETSUBR): Use size of 0 since the actual size doesn't matter,
440 and using 0 avoids overflow.
441 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
442 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
444 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
445 Assume the arg has valid form, since it always does.
446 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
447 unsigned integer system type.
448 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
449 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
450 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
451 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
452 (duration_to_sec_usec): New decl.
453 * lread.c (read_from_string_index, read_from_string_index_byte)
454 (read_from_string_limit, readchar, unreadchar, openp)
455 (read_internal_start, read1, oblookup):
456 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
457 (Fload, readevalloop, Feval_buffer, Feval_region):
458 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
459 (openp): Check for out-of-range argument to 'access'.
460 (read1): Use int, not EMACS_INT, where int is wide enough.
461 Don't assume fixnum fits into int.
462 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
464 (Fexecute_kbd_macro):
465 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
466 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
467 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
468 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
469 (set_marker_both, set_marker_restricted_both, marker_position)
470 (marker_byte_position, Fbuffer_has_markers_at):
471 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
472 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
473 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
474 It now merely ensures that the menu is large enough, without
475 necessarily growing it, as this avoids some integer overflow issues.
477 (keymap_panes, parse_single_submenu, Fx_popup_menu):
478 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
479 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
480 Use SAFE_ALLOCA_LISP, not alloca.
481 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
482 to EMACS_INT. Check that fixnums are in proper range for system types.
483 * minibuf.c (minibuf_prompt_width, string_to_object)
484 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
485 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
486 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
487 (get_minibuffer, read_minibuf_unwind):
488 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
489 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
490 this simplifies overflow checking. All callers changed.
491 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
493 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
494 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
495 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
496 Check that fixnums are in proper range for system types.
497 (Fx_create_frame, Fx_show_tip):
498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
499 * nsfont.m (ns_findfonts, nsfont_list_family):
500 Don't assume fixnum fits in long.
501 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
503 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
505 * nsselect.m (ns_get_local_selection):
506 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
507 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
508 (PRINTDECLARE, PRINTPREPARE):
509 (strout, print_string):
510 (print, print_preprocess, print_check_string_charset_prop)
512 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
514 (temp_output_buffer_setup, Fprin1_to_string, print_object):
515 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
516 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
517 (PRINTFINISH): Use SAFE_ALLOCA, not alloca.
518 (printchar, strout): Use xpalloc to catch size calculation overflow.
519 (Fexternal_debugging_output): Use CHECK_CHARACTER, not CHECK_NUMBER,
520 to avoid mishandling large integers.
521 (print_error_message): Use SAFE_ALLOCA, not alloca.
522 (print_object): Use int, not EMACS_INT, where int is wide enough.
523 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
524 (Fset_process_window_size, Fformat_network_address)
525 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
526 (Fsignal_process, sigchld_handler):
527 Check that fixnums are in proper range for system types.
528 (Fformat_network_address, read_process_output, send_process)
529 (Fprocess_send_region, status_notify):
530 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
531 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
532 (wait_reading_process_output, read_process_output, exec_sentinel):
533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
534 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
535 (Faccept_process_output): Use duration_to_sec_usec to do proper
536 overflow checking on durations.
537 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
538 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
539 * search.c (looking_at_1, string_match_1):
540 (fast_string_match, fast_c_string_match_ignore_case)
541 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
542 (scan_newline, find_before_next_newline, search_command)
543 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
544 (set_search_regs, wordify):
547 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
548 (string_match_1, search_buffer, set_search_regs):
550 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
551 (wordify): Check for overflow in size calculation.
552 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
553 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
554 Check that fixnums are in proper range for system types.
555 * sound.c (struct sound_device)
556 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
557 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
558 (Fplay_sound_internal):
559 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
560 * syntax.c (ST_COMMENT_STYLE, ST_STRING_STYLE):
561 In definitions, make it clearer that these values must be out of range
562 for the respective integer ranges. This fixes a bug with ST_STRING_STYLE
563 and non-ASCII characters.
564 (struct lisp_parse_state, find_start_modiff)
565 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
566 (Fparse_partial_sexp):
567 Don't assume fixnums can fit in int.
568 (struct lisp_parse_state, find_start_pos, find_start_value)
569 (find_start_value_byte, find_start_begv)
570 (update_syntax_table, char_quoted, dec_bytepos)
571 (find_defun_start, prev_char_comend_first, back_comment):
572 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
573 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
574 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
575 (Finternal_describe_syntax_value): Check that match_lisp is a
576 character, not an integer, since the code stuffs it into int.
577 (scan_words, scan_sexps_forward):
578 Check that fixnums are in proper range for system types.
580 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
581 (scan_sexps_forward):
582 Use CHARACTERP, not INTEGERP, since the value must fit into int.
583 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
584 * syntax.h: Adjust decls to match defn changes elsewhere.
586 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
587 * sysdep.c (wait_for_termination_1, wait_for_termination)
588 (interruptible_wait_for_termination, mkdir):
589 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
590 (emacs_read, emacs_write):
591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
592 (system_process_attributes): Don't assume uid_t, gid_t, and
593 double all fit in int or even EMACS_INT.
594 * term.c (set_tty_color_mode):
595 Check that fixnums are in proper range for system types.
596 * termhooks.h (struct input_event):
597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
598 * textprop.c (validate_interval_range, interval_of)
599 (Fadd_text_properties, set_text_properties_1)
600 (Fremove_text_properties, Fremove_list_of_text_properties)
601 (Ftext_property_any, Ftext_property_not_all)
602 (copy_text_properties, text_property_list, extend_property_ranges)
603 (verify_interval_modification):
604 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
605 (Fnext_single_char_property_change)
606 (Fprevious_single_char_property_change):
607 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
608 (copy_text_properties): Check for integer overflow in index calculation.
609 * undo.c (last_boundary_position, record_point, record_insert)
610 (record_delete, record_marker_adjustment, record_change)
611 (record_property_change):
612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
613 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
614 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
615 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
616 (Fx_hide_tip, Fx_file_dialog):
617 * w32menu.c (set_frame_menubar):
618 Use ptrdiff_t, not int, for consistency with rest of code.
619 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
620 (select_window, Fdelete_other_windows_internal)
621 (window_scroll_pixel_based, window_scroll_line_based)
622 (Frecenter, Fset_window_configuration):
623 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
624 (Fset_window_hscroll, run_window_configuration_change_hook)
625 (set_window_buffer, temp_output_buffer_show, scroll_command)
626 (Fscroll_other_window):
627 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
628 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
629 Don't assume fixnum fits in int.
630 (Fset_window_scroll_bars):
631 Check that fixnums are in proper range for system types.
632 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
633 (string_pos, c_string_pos, number_of_chars, init_iterator)
634 (in_ellipses_for_invisible_text_p, init_from_display_pos)
635 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
636 (compute_display_string_end, handle_face_prop)
637 (face_before_or_after_it_pos, handle_invisible_prop, handle_display_prop)
638 (handle_display_spec, handle_single_display_spec)
639 (display_prop_intangible_p, string_buffer_position_lim)
640 (string_buffer_position, handle_composition_prop, load_overlay_strings)
641 (get_overlay_strings_1, get_overlay_strings)
642 (iterate_out_of_display_property, forward_to_next_line_start)
643 (back_to_previous_visible_line_start, reseat, reseat_to_string)
644 (get_next_display_element, set_iterator_to_next)
645 (get_visually_first_element, compute_stop_pos_backwards)
646 (handle_stop_backwards, next_element_from_buffer)
647 (move_it_in_display_line_to, move_it_in_display_line)
648 (move_it_to, move_it_vertically_backward, move_it_by_lines)
649 (add_to_log, message_dolog, message_log_check_duplicate)
650 (message2, message2_nolog, message3, message3_nolog
651 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
652 (current_message_1, truncate_echo_area, truncate_message_1)
653 (set_message, set_message_1, store_mode_line_noprop)
654 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
655 (text_outside_line_unchanged_p, check_point_in_composition)
656 (reconsider_clip_changes)
657 (redisplay_internal, set_cursor_from_row, try_scrolling)
658 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
659 (redisplay_window, find_last_unchanged_at_beg_row)
660 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
661 (trailing_whitespace_p, find_row_edges, display_line)
662 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
663 (display_mode_element, store_mode_line_string)
664 (pint2str, pint2hrstr, decode_mode_spec)
665 (display_count_lines, display_string, draw_glyphs)
666 (x_produce_glyphs, x_insert_glyphs)
667 (rows_from_pos_range, mouse_face_from_buffer_pos)
668 (fast_find_string_pos, mouse_face_from_string_pos)
669 (note_mode_line_or_margin_highlight, note_mouse_highlight):
670 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
671 (safe_call, init_from_display_pos, handle_fontified_prop)
672 (handle_single_display_spec, load_overlay_strings)
673 (with_echo_area_buffer, setup_echo_area_for_printing)
674 (display_echo_area, echo_area_display)
675 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
676 (update_tool_bar, hscroll_window_tree, redisplay_internal)
677 (redisplay_window, dump_glyph_row, display_mode_line, Fformat_mode_line)
678 (decode_mode_spec, on_hot_spot_p):
679 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
680 (handle_single_display_spec, build_desired_tool_bar_string)
681 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
682 (get_specified_cursor_type):
683 Check that fixnums are in proper range for system types.
684 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
686 Don't assume fixnums fit in int.
687 (compare_overlay_entries):
688 Avoid mishandling comparisons due to subtraction overflow.
689 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
690 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
691 (handle_tool_bar_click):
692 Use int, not unsigned, since we prefer signed and the signedness
694 (get_next_display_element, next_element_from_display_vector):
695 Use int, not EMACS_INT, when int is wide enough.
696 (start_hourglass): Use duration_to_sec_usec to do proper
697 overflow checking on durations.
698 * xfaces.c (Fbitmap_spec_p):
699 Check that fixnums are in proper range for system types.
700 (compare_fonts_by_sort_order):
701 Avoid mishandling comparisons due to subtraction overflow.
702 (Fx_family_fonts, realize_basic_faces):
703 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
705 Don't assume fixnum fits in int.
706 Use SAFE_ALLOCA_LISP, not alloca.
707 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
708 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
709 (face_at_buffer_position, face_for_overlay_string)
710 (face_at_string_position):
711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
712 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
713 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
715 Check that fixnums are in proper range for system types.
716 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
717 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
718 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
719 (Fx_change_window_property): Don't assume fixnums fit in int.
720 * xfont.c (xfont_chars_supported):
721 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
722 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
723 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
724 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
725 * xml.c (parse_region):
726 * xrdb.c (magic_file_p):
727 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
728 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
729 (x_get_local_selection, x_reply_selection_request)
730 (x_handle_selection_request, wait_for_property_change):
731 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
732 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
733 short is wide enough.
734 (x_send_client_event): Don't assume fixnum fits in int.
735 * xterm.c (x_x_to_emacs_modifiers):
736 Don't assume EMACS_INT overflows nicely into int.
737 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
739 (handle_one_xevent): NATNUMP can eval its arg twice.
740 (x_connection_closed):
741 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
742 * xterm.h: Adjust decls to match defn changes elsewhere.
743 (struct scroll_bar): Use struct vectorlike_header
744 rather than rolling our own approximation.
745 (SCROLL_BAR_VEC_SIZE): Remove; not used.
747 2011-09-21 Eli Zaretskii <eliz@gnu.org>
749 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
752 * dispextern.h (struct it): Update the comment documenting what
755 2011-09-20 Eli Zaretskii <eliz@gnu.org>
757 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
758 a display string, extend search for cursor position to end of row.
759 (find_row_edges): If the row ends in a newline from a display
760 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
761 Handle the case of a display string with multiple newlines.
762 (Fcurrent_bidi_paragraph_direction): Fix search for previous
763 non-empty line. Fixes confusing cursor motion with arrow keys at
764 the beginning of a line that starts with whitespace.
766 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
768 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
771 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
773 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
776 2011-09-18 Eli Zaretskii <eliz@gnu.org>
778 * xdisp.c (display_line): Record maximum and minimum buffer
779 positions even if no glyphs were produced (e.g., by a zero-width
780 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
781 buffer positions that will be removed from the glyph row because
783 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
784 column is beyond frame width: don't subtract 1 "pixel" when
785 computing width of the stretch.
786 (reseat_at_next_visible_line_start): Undo the change made on
787 2011-09-17 that saved paragraph information and restored it after
788 the call to `reseat'. (Bug#9545)
790 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
792 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
793 and turn window cursor on if cleared (Bug#9415).
795 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
797 * search.c (boyer_moore): Take unibyte characters from pattern
798 literally. (Bug#9458)
800 2011-09-18 Eli Zaretskii <eliz@gnu.org>
802 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
804 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
806 Fix minor problem found by static checking.
807 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
808 initialized, to pacify gcc -Wuninitialized.
810 * fileio.c: Report proper errno when syscall falls.
811 (Finsert_file_contents): Save and restore errno,
812 so that report_file_error outputs the correct diagnostic.
813 (Fwrite_region) [CLASH_DETECTION]: Likewise.
815 2011-09-18 Eli Zaretskii <eliz@gnu.org>
817 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
819 2011-09-17 Eli Zaretskii <eliz@gnu.org>
821 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
822 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
824 2011-09-17 Eli Zaretskii <eliz@gnu.org>
826 * xdisp.c (reseat_at_next_visible_line_start): Keep information
827 about the current paragraph and restore it after the call to
830 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
831 (bidi_find_paragraph_start): Search back for paragraph beginning
832 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
833 (bidi_move_to_visually_next): Only trigger paragraph-related
834 computations when the last character is a newline or at EOB, not
835 just any NEUTRAL_B. (Bug#9470)
837 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
838 truncated lines if point is covered by a display string. (Bug#9524)
840 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
842 * xselect.c: Relax test for outgoing X longs (Bug#9498).
843 (cons_to_x_long): New function.
844 (lisp_data_to_selection_data): Use it. Correct the test for
845 short-versus-long data; it was negated. Break out of vector
846 loop, for efficiency, when a long datum is discovered.
848 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
850 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
852 2011-09-16 Eli Zaretskii <eliz@gnu.org>
854 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
855 GCC PR/17406) by declaring this function with external scope.
857 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
859 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
860 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
862 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
864 * editfns.c (Fformat): Correctly handle text properties on "%%".
866 2011-09-15 Eli Zaretskii <eliz@gnu.org>
868 * xterm.c (x_draw_composite_glyph_string_foreground):
869 * w32term.c (x_draw_composite_glyph_string_foreground):
870 * term.c (encode_terminal_code):
871 * composite.c (composition_update_it, get_composition_id):
872 * xdisp.c (get_next_display_element)
873 (fill_composite_glyph_string): Add comments about special meaning
874 of TAB characters in a composition.
876 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
878 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
879 This occurs when processing a multibyte format.
880 Problem reported by Wolfgang Jenker.
882 2011-09-15 Johan Bockgård <bojohan@gnu.org>
884 * xdisp.c (try_cursor_movement): Only check for exact match if
885 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
887 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
889 Remove unused external symbols.
890 * dispextern.h (calc_pixel_width_or_height): Remove decl.
891 * xdisp.c (calc_pixel_width_or_height): Now static.
892 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
893 * indent.c (check_display_width):
894 * w32term.c: Fix comment to match code.
895 * xterm.c, xterm.h (x_catching_errors): Remove.
897 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
899 * xselect.c: Use signed conversions more consistently (Bug#9498).
900 (selection_data_to_lisp_data): Assume incoming selection data are
901 signed integers, not unsigned. This is to be consistent with
902 outgoing selection data, which was modified to use signed integers
903 in as part of the fix to Bug#9196 in response to Jan D.'s comment
904 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
905 expects long, not unsigned long.
907 2011-09-14 Eli Zaretskii <eliz@gnu.org>
909 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
910 computation of loop end. Reported by Johan Bockgård
913 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
915 * frame.c (Fother_visible_frames_p): Function deleted.
917 2011-09-12 Eli Zaretskii <eliz@gnu.org>
919 * indent.c (compute_motion): Process display vector front to back
920 rather than the other way around. (Bug#2496)
922 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
924 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
926 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
928 * minibuf.c (Fread_from_minibuffer): Doc fix.
930 2011-09-11 Eli Zaretskii <eliz@gnu.org>
932 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
933 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
935 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
937 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
938 value for non-existent files.
940 2011-09-11 Eli Zaretskii <eliz@gnu.org>
942 * fileio.c (Finsert_file_contents): If the file cannot be opened,
943 set its "size" to -1. This will set the modtime_size field of
944 the corresponding buffer to -1, which is what
945 verify-visited-file-modtime expects for files that do not exist.
948 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
950 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
952 * lisp.h: ... from here. push_key_description is no longer
953 defined in keyboard.c, so its declaration should not be in
954 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
955 logically belongs with push_key_description.
957 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
959 * buffer.h: Include <sys/types.h> instead of <time.h>.
960 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
961 Problem reported by Herbert J. Skuhra.
963 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
965 * xml.c (parse_region): Make the parsing work for
966 non-comment-starting XML files again (bug#9144).
968 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
970 * image.c (gif_load): Fix calculation of bottom and right corner.
973 2011-09-10 Eli Zaretskii <eliz@gnu.org>
975 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
976 redisplay in small windows.
978 2011-09-09 Eli Zaretskii <eliz@gnu.org>
980 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
982 2011-09-08 Martin Rudalics <rudalics@gmx.at>
984 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
985 Operate on live windows only.
987 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
989 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
991 2011-09-07 Eli Zaretskii <eliz@gnu.org>
993 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
994 only under bidi iteration.
996 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
998 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1000 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1002 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1003 Without this fix, the command to link temacs failed due to an
1004 undefined symbol __builtin_isnan. This is because
1005 /usr/include/iso/math_c99.h #defines isnan(x) to
1006 __builtin_isnan(x), but the bundled gcc, which identifies itself
1007 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1009 * floatfns.c (isnan): #undef, and then #define to a clone of
1011 (Fisnan): Always define, since it's always available now.
1012 (syms_of_floatfns): Always define isnan at the Lisp level.
1014 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1016 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1018 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1020 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1021 The previous code assumed that file offsets (off_t values) fit in
1022 EMACS_INT variables, which is not true on typical 32-bit hosts.
1023 The code messed up by falsely reporting buffer overflow in cases
1024 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1025 when "big" contains more than 2**29 bytes, even though this
1026 inserts just one byte and does not overflow the buffer.
1027 (Finsert_file_contents): Store file offsets as off_t
1028 values, not as EMACS_INT values. Check for overflow when
1029 converting between EMACS_INT and off_t. When checking for
1030 buffer overflow or for overlap, take the offsets into account.
1031 Don't use EMACS_INT for small values where int suffices.
1032 When checking for overlap, fix a typo: ZV was used where
1033 ZV_BYTE was intended.
1034 (Fwrite_region): Don't assume off_t fits into 'long'.
1035 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1037 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1039 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1041 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1043 sprintf-related integer and memory overflow issues (Bug#9412).
1045 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1046 (esprintf, exprintf, evxprintf): New functions.
1047 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1048 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
1049 (modify_event_symbol): Do not assume that the length of
1050 name_alist_or_stem is safe to alloca and fits in int.
1051 (Fexecute_extended_command): Likewise for function name and binding.
1052 (Frecursion_depth): Wrap around reliably on integer overflow.
1053 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1054 since some callers pass EMACS_INT values.
1055 (Fsingle_key_description): Don't crash if symbol name contains more
1056 than MAX_ALLOCA bytes.
1057 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1058 (get_minibuffer): Arg is now EMACS_INT, not int.
1059 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1060 (esprintf, exprintf, evxprintf): New decls.
1061 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1063 * dbusbind.c (signature_cat): New function.
1064 (xd_signature, Fdbus_register_signal):
1065 Do not overrun buffer; instead, report string overflow.
1067 * dispnew.c (add_window_display_history): Don't overrun buffer.
1068 Truncate instead; this is OK since it's just a log.
1070 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1071 even if the time zone offset is outlandishly large.
1072 Don't mishandle offset == INT_MIN.
1074 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1075 when creating daemon; the previous buffer-overflow check was incorrect.
1077 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1078 which has the guts of the old verror function.
1080 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1081 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1083 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1084 (font_unparse_xlfd): Don't blindly alloca long strings.
1085 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1086 fits in int, when using sprintf. Use single snprintf to count
1087 length of string rather than counting it via multiple sprintfs;
1088 that's simpler and more reliable.
1089 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1090 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1091 sprintf, in case result does not fit in int.
1093 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1094 (fontset_from_font): Print it.
1096 * frame.c (tty_frame_count): Now printmax_t, not int.
1097 (make_terminal_frame, set_term_frame_name): Print it.
1098 (x_report_frame_params): In X, window IDs are unsigned long,
1099 not signed long, so print them as unsigned.
1100 (validate_x_resource_name): Check for implausibly long names,
1101 and don't assume name length fits in 'int'.
1102 (x_get_resource_string): Don't blindly alloca invocation name;
1103 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1106 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1107 (xg_check_special_colors, xg_set_geometry):
1108 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1110 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1111 Use esprintf, not sprintf, in case result does not fit in int.
1113 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1114 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1115 it as a large positive number.
1116 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1117 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1119 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1120 in case result does not fit in int.
1122 * print.c (float_to_string): Detect width overflow more reliably.
1123 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1124 buffer overrun. Don't assume list length fits in 'int'. Treat
1125 print length of 0 as 0, not as infinity; to be consistent with other
1126 uses of print length in this function. Don't overflow print length
1127 index. Don't assume hash table size fits in 'long', or that
1128 vectorlike size fits in 'unsigned long'.
1130 * process.c (make_process): Use printmax_t, not int, to format
1131 process-name gensyms.
1133 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1135 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1136 to avoid potential buffer overrun.
1138 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1139 if X resource line is longer than 512 bytes.
1141 * xfns.c (x_window): Make sprintf buffer a bit bigger
1142 to avoid potential buffer overrun.
1144 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1146 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1148 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1150 Integer overflow fixes for scrolling, etc.
1151 Without these, Emacs silently mishandles large integers sometimes.
1152 For example, "C-u 4294967297 M-x recenter" was treated as if
1153 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1155 * xdisp.c (try_window_id): Check Emacs fixnum range before
1156 converting to 'int'.
1158 * window.c (window_scroll_line_based, Frecenter):
1159 Check that an Emacs fixnum is in range before assigning it to 'int'.
1160 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1161 values converted from Emacs fixnums.
1162 (Frecenter): Don't wrap around a line count if it is out of 'int'
1163 range; instead, treat it as an extreme value.
1164 (Fset_window_configuration, compare_window_configurations):
1165 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1167 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1168 that can exceed INT_MAX. Check that EMACS_INT value is in range
1169 before assigning it to the (possibly-narrower) index.
1170 (match_limit): Don't assume that a fixnum can fit in 'int'.
1172 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1175 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1176 (Fvertical_motion): Don't wrap around LINES values that don't fit
1177 in 'int'. Instead, treat them as extreme values. This is good
1178 enough for windows, which can't have more than INT_MAX lines anyway.
1180 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1182 * Require libxml/parser.h to avoid compilation warning.
1184 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1186 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1187 since this reportedly can destroy thread storage.
1189 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1191 * syntax.c (find_defun_start): Update all cache variables if
1192 exiting early (Bug#9401).
1194 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1196 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1198 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1199 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1200 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1202 * term.c (tty_append_glyph): New function.
1203 (produce_stretch_glyph): Static function and its prototype deleted.
1205 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
1208 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1210 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1211 when checking :margin (Bug#9390).
1212 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1213 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1214 so that the name doesn't mislead. All uses changed.
1216 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1218 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1221 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1223 * xdisp.c (move_it_to): Don't bail out early when reaching
1224 position beyond to_charpos, if we are scanning backwards.
1225 (move_it_vertically_backward): When DY == 0, make sure we get to
1226 the first character in the line after the newline.
1228 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1230 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1231 (ccl_driver): Do not generate an out-of-range pointer.
1232 (Fccl_execute_on_string): Remove unnecessary check for
1233 integer overflow, noted by Stefan Monnier in
1234 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1235 Remove a FIXME that didn't need fixing.
1236 Simplify the newly-introduced buffer reallocation code.
1238 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1240 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1242 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1244 Integer and memory overflow issues (Bug#9196).
1246 * doc.c (get_doc_string): Rework so that
1247 get_doc_string_buffer_size is the actual buffer size, rather than
1248 being 1 less than the actual buffer size; this makes xpalloc more
1251 * image.c (x_allocate_bitmap_record, cache_image):
1252 * xselect.c (Fx_register_dnd_atom):
1253 Simplify previous changes by using xpalloc.
1255 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1256 since either will do and ptrdiff_t is convenient with xpalloc.
1258 * charset.c (charset_table_size)
1259 (struct charset_sort_data.priority): Now ptrdiff_t.
1260 (charset_compare): Don't overflow if priorities differ greatly.
1261 (Fsort_charsets): Don't assume list length fits in int.
1262 Check for size-calculation overflow when allocating sort data.
1263 (syms_of_charset): Allocate an initial charset table that is
1264 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1266 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1268 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1269 The actual value is always <= INT_MAX, and leaving it unsigned made
1270 overflow checking harder.
1272 * dispextern.h (struct glyph_matrix.rows_allocated)
1273 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1274 with xpalloc. The values are still always <= INT_MAX.
1276 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1278 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1279 (SAFE_NALLOCA): New macro.
1281 * region-cache.c (struct boundary.pos, find_cache_boundary)
1282 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1283 (set_cache_region, invalidate_region_cache)
1284 (revalidate_region_cache, know_region_cache, region_cache_forward)
1285 (region_cache_backward, pp_cache):
1286 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1287 so that ptrdiff_t * can be passed to xpalloc.
1288 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1289 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1290 (pp_cache): Don't assume cache_len fits in int.
1291 * region-cache.h: Adjust extern decls to match.
1293 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1294 EMACS_INT, since either will do, for xpalloc.
1296 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1297 (xnmalloc, xnrealloc, xpalloc): New functions.
1299 * bidi.c (bidi_shelve_header_size): New constant.
1300 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1301 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1303 * bidi.c (bidi_cache_shrink):
1304 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1306 Don't update size of array until after memory allocation succeeds,
1307 because xmalloc/xrealloc may not return.
1308 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1309 now that we have proper integer overflow checking.
1310 (record_overlay_string, overlay_strings): Catch overflows when
1311 calculating size of overlay_str_buf.
1313 * callproc.c (Fcall_process): Check for size overflow when
1314 calculating size of args2.
1315 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1316 Normally we prefer signed values, but sticking with ptrdiff_t would
1317 require adding more-complicated checks.
1319 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1320 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1321 Redo buffer-overflow calculations to avoid integer overflow.
1322 Add a FIXME comment where memory seems to be over-allocated.
1324 * character.c (Fstring): Check for size-calculation overflow.
1326 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1327 unnecessary integer overflow. Check for size overflow.
1328 (encode_coding_object): Don't update size until xmalloc succeeds.
1330 * composite.c (get_composition_id): Check for overflow in glyph
1331 length calculations.
1333 Integer and memory overflow fixes for display code.
1334 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1335 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1336 (scrolling_window): Check for overflow in size calculations.
1337 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1338 Don't assume glyph table len fits in int.
1339 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1340 (row_table_size): Now ptrdiff_t, not int.
1341 (scrolling_window): Avoid overflow in size calculations.
1342 Don't update size until allocation succeeds.
1343 * fns.c (concat): Check for overflow in size calculations.
1344 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1345 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1346 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1348 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1349 (get_doc_string): Check for size calculation overflow.
1350 Don't update size until allocation succeeds.
1351 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1352 EMACS_INT, where ptrdiff_t will do.
1353 (Fsubstitute_command_keys): Check for string overflow.
1355 * editfns.c (set_time_zone_rule): Don't assume environment length
1357 (message_length): Now ptrdiff_t, not int.
1358 (Fmessage_box): Don't update size until allocation succeeds.
1359 Don't assume message length fits in int.
1360 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1362 * emacs.c (main): Do not reallocate argv, since there is a null at
1363 the end that can be overwritten, and this way there's no need to
1364 worry about size-calculation overflow.
1365 (sort_args): Check for size-calculation overflow.
1367 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1369 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1371 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1372 (x_set_scroll_bar_width, x_figure_window_size):
1373 Check for integer overflow.
1374 (x_set_alpha): Do not assume XINT fits in int.
1376 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1377 This is for the members text_lines, text_cols, total_lines, total_cols,
1378 where the system imposes an 'int' limit.
1380 * fringe.c (Fdefine_fringe_bitmap):
1381 Don't update size until alloc works.
1383 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1384 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1386 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1387 Check for size-calculation overflow.
1388 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1389 do, as we prefer signed integers.
1390 (id_to_widget.max_size, id_to_widget.used)
1391 (xg_store_widget_in_map, xg_remove_widget_from_map)
1392 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1393 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1394 Use and return ptrdiff_t, not int.
1395 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1396 * gtkutil.h: Change prototypes to match the above.
1398 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1399 are duplicate now that they've been promoted to lisp.h.
1400 (x_allocate_bitmap_record, x_alloc_image_color)
1401 (make_image_cache, cache_image, xpm_load):
1402 Don't update size until alloc is done.
1403 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1405 Check for size calculation overflow.
1406 (ct_colors_allocated_max): New constant.
1407 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1410 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1411 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1412 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1413 Use ptrdiff_t, not int, to count maps.
1414 (read_char_minibuf_menu_prompt): Check for overflow in size
1415 calculations. Don't update size until allocation succeeds. Redo
1416 calculations to avoid overflow.
1417 * keyboard.h: Change prototypes to match the above.
1419 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1421 (current_minor_maps): Check for size calculation overflow.
1422 * keymap.h: Change prototypes to match the above.
1424 * lread.c (read1, init_obarray): Don't update size until alloc done.
1426 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1427 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1429 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1430 Now ptrdiff_t, not int.
1431 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1432 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1434 * process.c (Fnetwork_interface_list): Check for overflow
1435 in size calculation.
1437 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1439 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1440 overflow. Don't bother calling xmalloc when xrealloc will do.
1442 * search.c (Freplace_match): Check for size calculation overflow.
1443 (Fset_match_data): Don't assume list lengths fit in 'int'.
1445 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1446 for command line length. Do not attempt to address one before the
1447 beginning of an array, as that's not portable.
1449 * term.c (max_frame_lines): Remove; unused.
1450 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1452 (encode_terminal_code, calculate_costs): Check for size
1453 calculation overflow.
1454 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1455 table lengths and related sizes. Don't update size until alloc
1456 done. Redo calculations to avoid overflow.
1457 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1459 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1460 subtracting pointers.
1461 (gobble_line): Check for overflow more carefully. Don't update size
1464 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1465 Don't update size until alloc done.
1466 Redo size calculations to avoid overflow.
1467 Check for size calculation overflow.
1468 (main) [DEBUG]: Fix typo in invoking tparam1.
1470 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1471 Use ptrdiff_t, not int, for sizes.
1472 (store_mode_line_noprop_char): Don't update size until alloc done.
1474 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1475 Use ptrdiff_t, not int, for sizes.
1476 (Finternal_make_lisp_face, cache_face):
1477 Check for size calculation overflow.
1478 (cache_face): Treat size calculation overflows as if they were
1479 memory exhaustion (the usual treatment), rather than aborting.
1481 * xfns.c (x_encode_text, x_set_name_internal)
1482 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1483 sizes, since they can exceed INT_MAX in size. Check for size
1484 calculation overflow.
1486 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1487 (xg_select): Check for size calculation overflow.
1488 Don't update size until alloc done.
1490 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1491 as sprintf is limited to int lengths.
1493 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1494 (X_LONG_MIN): New macros.
1495 Use them to make the following changes clearer.
1496 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1497 This change doesn't affect the value now, but it may help remind
1498 future maintainers not to raise the value too much later.
1499 (SELECTION_QUANTUM): Remove, replacing with ...
1500 (selection_quantum): ... new function, which avoids overflow.
1502 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1503 assumption that selection length fits in 'int'.
1504 (x_reply_selection_request, x_handle_selection_request)
1505 (x_get_window_property, receive_incremental_selection)
1506 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1507 (lisp_data_to_selection_data, clean_local_selection_data):
1508 Use ptrdiff_t, not int, to record length of selection.
1509 (x_reply_selection_request, x_get_window_property)
1510 (receive_incremental_selection, x_property_data_to_lisp):
1511 Redo calculations to avoid overflow.
1512 (x_reply_selection_request): When sending hint, ceiling it at
1513 X_LONG_MAX rather than relying on wraparound overflow to send
1515 (x_get_window_property, receive_incremental_selection)
1516 (lisp_data_to_selection_data, x_property_data_to_lisp):
1517 Check for size-calculation overflow.
1518 (x_get_window_property, receive_incremental_selection)
1519 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1520 Don't store size until memory allocation succeeds.
1521 (x_get_window_property): Plug memory leak on memory exhaustion.
1522 Don't double-block input; malloc is safe here. Don't assume 2**34
1523 - 4 fits in unsigned long. Add an xassert to check
1524 XGetWindowProperty overflow. Be more careful about overflow
1525 calculations, and distinguish size from memory overflow better.
1526 (receive_incremental_selection): When tracing, don't assume
1527 unsigned int is less than INT_MAX.
1528 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1529 harmful) conversions of unsigned short to int.
1530 (lisp_data_to_selection_data): Don't assume that integers
1531 in the range -65535 through -1 fit in an X unsigned short.
1532 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1533 result parameters unless successful. Rely on cons_to_unsigned
1534 to report problems with elements; the old code wasn't right anyway.
1535 (x_check_property_data): Check for int overflow; we cannot use
1536 a wider type due to X limits.
1537 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1539 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1541 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1542 (x_term_init): Check for size calculation overflow.
1543 (x_color_cells): Don't store size until memory allocation succeeds.
1544 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1545 Don't assume alloca size is less than MAX_ALLOCA.
1546 (x_term_init): Don't assume length fits in int (sprintf is limited
1549 Use ptrdiff_t for composition IDs.
1550 * character.c (lisp_string_width):
1551 * composite.c (composition_table_size, n_compositions)
1552 (get_composition_id, composition_gstring_from_id):
1553 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1554 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1555 * window.c (Frecenter):
1556 Use ptrdiff_t, not int, for composition IDs.
1557 * composite.c (get_composition_id): Check for integer overflow.
1558 * composite.h: Adjust prototypes to match the above changes.
1560 Use ptrdiff_t for hash table indexes.
1561 * category.c (hash_get_category_set):
1562 * ccl.c (ccl_driver):
1563 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1564 * coding.c (coding_system_charset_list, detect_coding_system):
1565 * coding.h (struct coding_system.id):
1566 * composite.c (get_composition_id, gstring_lookup_cache):
1567 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1568 * image.c (xpm_get_color_table_h):
1569 * lisp.h (hash_lookup, hash_put):
1570 * minibuf.c (Ftest_completion):
1571 Use ptrdiff_t for hash table indexes, not int (which is too
1572 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1573 32-bit --with-wide-int hosts).
1575 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1576 Add a FIXME comment about memory leaks.
1577 (syms_of_charset): Don't assume xmalloc returns.
1579 Don't assume that stated character widths fit in int.
1580 * character.c (Fchar_width, c_string_width, lisp_string_width):
1581 * character.h (CHAR_WIDTH):
1582 * indent.c (MULTIBYTE_BYTES_WIDTH):
1583 Use sanitize_char_width to avoid undefined and/or bad behavior
1584 with outlandish widths.
1585 * character.h (sanitize_tab_width): Renamed from sanitize_width,
1586 now that we have two such functions. All uses changed.
1587 (sanitize_char_width): New inline function.
1589 Don't assume that tab-width fits in int.
1590 * character.h (sanitize_width): New inline function.
1591 (SANE_TAB_WIDTH): New macro.
1592 (ASCII_CHAR_WIDTH): Use it.
1593 * indent.c (sane_tab_width): Remove. All uses replaced by
1594 SANE_TAB_WIDTH (current_buffer).
1595 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1597 * fileio.c: Integer overflow issues with file modes.
1598 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1600 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1601 Remove unreachable code.
1602 (read_hex, load_charset_map_from_file): Check for integer overflow.
1604 * xterm.c: don't go over XClientMessageEvent limit
1605 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1606 (x_send_scroll_bar_event): Likewise. Check that the size does not
1607 exceed limits imposed by XClientMessageEvent, as well as the usual
1608 ptrdiff_t and size_t limits.
1610 * keyboard.c: Overflow, signedness and related fixes.
1611 (make_lispy_movement): Use same integer type in forward decl
1612 that is used in the definition.
1613 (read_key_sequence, keyremap_step):
1614 Change bufsize argument back to int, undoing my 2011-03-30 change.
1615 We prefer signed types, and int is wide enough here.
1616 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1617 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1618 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1619 length, not size_t. Use ptrdiff_t for index, not int.
1620 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1621 possibility of integer overflow.
1623 Overflow, signedness and related fixes for images.
1625 * dispextern.h (struct it.stack[0].u.image.image_id)
1626 (struct_it.image_id, struct image.id, struct image_cache.size)
1627 (struct image_cache.used, struct image_cache.ref_count):
1628 * gtkutil.c (update_frame_tool_bar):
1629 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1630 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1631 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1632 * nsmenu.m (update_frame_tool_bar):
1633 * xdisp.c (calc_pixel_width_or_height):
1634 * xfns.c (image_cache_refcount):
1635 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1636 on typical 64-bit hosts.
1638 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1639 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1640 Omit unnecessary casts to int.
1641 (parse_image_spec): Check that integers fall into 'int' range
1642 when the callers expect that.
1643 (image_ascent): Redo ascent calculation to avoid int overflow.
1644 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1645 (lookup_image): Remove unnecessary tests.
1646 (xbm_image_p): Locals are now of int, not EMACS_INT,
1647 since parse_image_check makes sure they fit into int.
1648 (png_load, gif_load, svg_load_image):
1649 Prefer int to unsigned where either will do.
1650 (tiff_handler): New function, combining the cores of the
1651 old tiff_error_handler and tiff_warning_handler. This
1652 function is rewritten to use vsnprintf and thereby avoid
1653 stack buffer overflows. It uses only the features of vsnprintf
1654 that are common to both POSIX and native Microsoft.
1655 (tiff_error_handler, tiff_warning_handler): Use it.
1656 (tiff_load, gif_load, imagemagick_load_image):
1657 Don't assume :index value fits in 'int'.
1658 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1659 (imagemagick_load_image): Check that crop parameters fit into
1660 the integer types that MagickCropImage accepts. Don't assume
1661 Vimagemagick_render_type has a nonnegative value. Don't assume
1662 size_t fits in 'long'.
1663 (gs_load): Use printmax_t to print the widest integers possible.
1664 Check for integer overflow when computing image height and width.
1666 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1668 * xdisp.c (redisplay_window): Don't force window start if point
1669 will be invisible in the resulting window. (Bug#9324)
1671 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1673 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1674 the display spec is of the form `(space ...)'.
1675 (handle_display_spec): Return the value returned by
1676 handle_single_display_spec, not just 1 or zero.
1677 (handle_single_display_spec): If the display spec is of the form
1678 `(space ...)', and specifies display in the text area, return 2
1680 (try_cursor_movement): Check for the need to scroll more
1681 accurately, and prefer exact match for point under bidi. Don't
1682 advance `row' beyond the last row of the window.
1684 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1685 into disp_prop; all users changed.
1687 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1688 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1689 for the text covered by the display property.
1691 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1693 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1694 Change return value to nil.
1695 (Frecord_buffer): Delete unused function.
1697 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1699 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1700 buffers, return left-to-right.
1701 (set_cursor_from_row): Consider candidate row a win if its glyph
1702 represents a newline and point is on that newline. Fixes cursor
1703 positioning on the newline at EOL of R2L text within L2R
1704 paragraph, and vice versa.
1705 (try_cursor_movement): Check continued rows, in addition to
1706 continuation rows. Fixes unwarranted scroll when point enters a
1707 continued line of R2L text within an L2R paragraph, or vice versa.
1708 (cursor_row_p): Consider the case of point being equal to
1709 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1710 from the end of a short line to the beginning of a continued line
1711 of R2L text within L2R paragraph.
1712 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1713 composed characters.
1715 * bidi.c (bidi_check_type): Use xassert.
1716 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1719 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1721 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1724 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1726 * nsfont.m (ns_otf_to_script): Fix typo.
1728 2011-08-22 Kenichi Handa <handa@m17n.org>
1730 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1731 extra slot even if the purpose is char-code-property-table.
1733 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1735 * xdisp.c (redisplay_window): When computing centering_position,
1736 account for the height of the header line. (Bug#8874)
1738 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1739 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1740 candidate is selected by the mouse, and that candidate has a
1741 composed character under the mouse.
1743 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1744 coordinates reported by pos-visible-in-window-p for a composed
1745 character in column zero.
1747 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1749 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1751 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1753 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1754 consider it a hit if to_charpos is anywhere in the range of the
1755 composed buffer positions.
1757 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1759 * image.c (gif_load): Don't assume that each subimage has the same
1760 dimensions as the base image. Handle disposal method that is
1761 "undefined" by the gif spec (Bug#9335).
1763 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1765 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1766 (Fcondition_case): Document `debug' symbol in error handler.
1768 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1770 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1771 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1772 from an Org mode buffer to a Speedbar frame.
1774 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1775 a composition, take its buffer position from IT->cmp_it.charpos.
1776 Fixes cursor positioning at the beginning of a line that begins
1777 with a composed character.
1779 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1781 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1782 character bidirectional type, use STRONG_L instead. Fixes crashes
1783 in a buffer produced by `describe-categories'.
1785 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1786 members before the level stack, so they would be saved and
1787 restored when copying iterator state. Fixes incorrect reordering
1788 around TABs covered by display properties.
1790 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1792 * process.c (Fnetwork_interface_list): Correctly determine buffer
1795 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1797 * eval.c (internal_condition_case, internal_condition_case_1)
1798 (internal_condition_case_2, internal_condition_case_n):
1799 Remove unnecessary aborts (Bug#9081).
1801 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1803 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1804 has no `load' handler, try opening the file locally. (Bug#9311)
1806 2011-08-16 Ken Brown <kbrown@cornell.edu>
1808 * gmalloc.c: Expand comment.
1810 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1812 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1813 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1815 2011-08-16 Ken Brown <kbrown@cornell.edu>
1817 Fix memory allocation problems in Cygwin build (Bug#9273).
1819 * unexcw.c ( __malloc_initialized): Declare external variable.
1820 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1822 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1824 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1826 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1828 [CYGWIN] (special_realloc): New function.
1829 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1830 requests to realloc storage in the static heap.
1832 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1834 * bidi.c (bidi_initialize): Remove unused local.
1836 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1838 * biditype.h: File removed.
1840 * bidimirror.h: File removed.
1842 * deps.mk (bidi.o): Remove biditype.h and
1845 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1848 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1850 * chartab.c: Improve commentary for the uniprop_table API.
1852 * bidi.c (bidi_paragraph_init): Support zero value of
1853 bidi_ignore_explicit_marks_for_paragraph_level.
1854 (bidi_initialize): Use uniprop_table instead of including
1855 biditype.h and bidimirror.h.
1857 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1858 coordinates of the iterator when restoring from ppos_it.
1861 2011-08-14 Kenichi Handa <handa@m17n.org>
1863 * process.c (create_process): Call setup_process_coding_systems
1864 after the pid of the process is set to -1 (Bug#8162).
1866 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1868 * xdisp.c (move_it_in_display_line_to): Don't invoke
1869 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1870 ppos_it. Fixes vertical cursor motion when line beginning is
1871 covered by an image. (Bug#9296)
1873 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1875 * nsterm.h (ns_run_ascript): Declare.
1876 (NSAPP_DATA2_RUNASSCRIPT): Define.
1878 * nsfns.m (as_script, as_result, as_status): New static variables.
1879 (ns_run_ascript): New function.
1880 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1881 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1882 the event loop. Get status from as_status (Bug#7276).
1884 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1885 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1886 the event loop (Bug#7276).
1888 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1890 * gnutls.c (QCgnutls_bootprop_priority)
1891 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1892 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1893 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1894 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1895 (QCgnutls_bootprop_verify_hostname_error)
1896 (QCgnutls_bootprop_callbacks_verify): Rename from
1897 Qgnutls_bootprop_..., all uses changed.
1899 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1902 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1904 * xfaces.c (Qframe_set_background_mode): Now static.
1905 * dispextern.h (Qframe_set_background_mode): Remove decl.
1907 * process.c (Fnetwork_interface_info): Declare local only if needed.
1909 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1911 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1912 (Fnetwork_interface_list): Allocate in increments of bytes instead
1913 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1914 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1916 (struct ifflag_def): notrailers is smart on OSX.
1917 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1918 Get hardware address with getifaddrs if available.
1920 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1922 * xdisp.c (iterate_out_of_display_property): xassert that
1923 IT->position is set to within IT->object's boundaries. Break from
1924 the loop as soon as EOB is reached; avoids infloops in redisplay
1925 when IT->position is set up wrongly due to some bug.
1926 Set IT->current to match the bidi iterator unconditionally.
1927 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1928 entry. Force push_it to save on the stack the current
1929 buffer/string position, to be restored by pop_it. Fix flags in
1930 the iterator structure wrt the object coming from a display
1931 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1932 properties. (Bug#9284)
1934 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1936 * fontset.c (fontset_get_font_group): Add proper type checks.
1939 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1941 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1942 and LC_VERSION_MIN_MACOSX.
1943 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1944 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1946 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1948 * xdisp.c (forward_to_next_line_start): Allow to use the
1949 no-display-properties-and-no-overlays under bidi display.
1950 Set disp_pos in the bidi iterator to avoid searches for display
1951 properties and overlays.
1953 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1955 * editfns.c (Fset_time_zone_rule): Document relationship with the
1958 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1959 the font entity extracted from the cache (Bug#8109).
1961 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1963 * composite.c (autocmp_chars): Don't reset point. That is done by
1964 restore_point_unwind (Bug#5984).
1966 2011-08-07 Juri Linkov <juri@jurta.org>
1968 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1969 to show the arg `TIME' instead of `TIMEVAL'.
1971 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1973 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1974 display property strides EOL and includes a newline, as in
1975 longlines-mode. (Bug#9254)
1976 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1977 word-wrap under bidirectional display. (Bug#9224)
1979 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1980 is non-zero, even if the data buffer is NULL. Fixes a crash in
1981 vertical-motion with longlines-mode. (Bug#9254)
1983 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1985 * bidi.c <bidi_cache_total_alloc>: Now static.
1986 (bidi_initialize): Initialize bidi_cache_total_alloc.
1988 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1991 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1992 amount allocated this far in `bidi_cache_total_alloc'.
1993 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1994 non-zero, only free the data buffer without restoring the cache
1995 contents. All callers changed.
1997 * dispextern.h (bidi_unshelve_cache): Update prototype.
1999 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2000 (move_it_in_display_line, move_it_to)
2001 (move_it_vertically_backward, move_it_by_lines): Replace the call
2002 to xfree to an equivalent call to bidi_unshelve_cache.
2003 (move_it_in_display_line_to): Fix logic of returning
2004 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2006 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2008 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2009 came from a string character with a `cursor' property. (Bug#9229)
2011 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2013 * Makefile.in (LIB_PTHREAD): New variable.
2014 (LIBES): Add LIB_PTHREAD (Bug#9216).
2016 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2017 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2019 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2021 * regex.c (re_iswctype): Remove some redundant boolean
2024 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2026 * xterm.c (x_find_topmost_parent): New function.
2027 (x_set_frame_alpha): Find topmost parent window with
2028 x_find_topmost_parent and set the property there also (bug#9181).
2029 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2031 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2033 * callproc.c (Fcall_process): Avoid vfork clobbering
2034 the local vars buffer, coding_systems, current_dir.
2036 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2038 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2040 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2042 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2043 so that it is not optimized away.
2045 * xdisp.c (compute_display_string_pos): Remove unused local.
2047 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2049 Fix slow cursor motion and scrolling in large buffers with
2050 selective display, like Org Mode buffers. (Bug#9218)
2052 * dispextern.h (struct bidi_it): New member disp_prop_p.
2054 * xdisp.c: Remove one-slot cache of display string positions.
2055 (compute_display_string_pos): Accept an additional argument
2056 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2057 for a display string or property. If found, set DISP_PROP_P
2060 * bidi.c (bidi_fetch_char): Accept an additional argument
2061 DISP_PROP_P, and pass it to compute_display_string_pos.
2062 Only handle text covered by a display string if DISP_PROP_P is returned
2063 non-zero. All callers of bidi_fetch_char changed.
2065 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2067 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2069 2010-12-03 Don March <don@ohspite.net>
2071 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2072 last character M-[char] is translated to ESC [char] (bug#7541).
2074 2011-08-02 Kenichi Handa <handa@m17n.org>
2076 * lisp.h (uniprop_table): Extern it.
2078 * chartab.c (uniprop_table): Make it non-static.
2080 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2082 * xdisp.c (forward_to_next_line_start): Accept additional argument
2083 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2085 (reseat_at_next_visible_line_start): Use the bidi iterator state
2086 returned by forward_to_next_line_start to restore the state of
2087 it->bidi_it after backing up to previous newline. (Bug#9212)
2089 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2091 * regex.c (re_comp): Protoize.
2092 (re_exec): Fix return type.
2093 (regexec): Fix type of `ret'. (Bug#9203)
2095 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2097 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2098 This is needed if max-image-size is a floating-point number.
2100 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2102 * print.c (print_object): Print empty symbol as ##.
2104 * lread.c (read1): Read ## as empty symbol.
2106 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2108 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2109 setting frame foreground color (Bug#9175).
2110 (x_set_background_color): Likewise.
2112 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2113 contents (Bug#9176).
2114 (EmacsTooltip -init): Remove bezels and add shadows to
2117 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2118 or scroll bar (Bug#8470).
2120 * nsfont.m (nsfont_open): Remove assignment to voffset and
2121 unnecessary vars hshink, expand, hd, full_height, min_height.
2122 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2124 * nsterm.h (nsfont_info): Remove voffset field.
2126 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2128 Implement strike-through and overline on NextStep (Bug#8863).
2130 * nsfont.m (nsfont_open): Use underline position provided by font,
2131 instead of hard-coded value of 2.
2132 (nsfont_draw): Call ns_draw_text_decoration instead.
2134 * nsterm.h: Add declaration for ns_draw_text_decoration.
2136 * nsterm.m (ns_draw_text_decoration): New function for drawing
2137 underline, overline, and strike-through.
2138 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2139 ns_draw_text_decoration. Change treatment of cursor drawing to
2140 accommodate underlining, etc.
2142 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2144 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2147 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2149 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2150 Without this fix, if a signal arrives just after memory fills up,
2151 'malloc' might be invoked reentrantly.
2153 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2154 In other words, assume that every image size is allowed, on non-X
2155 hosts. This assumption is probably wrong, but it lets Emacs compile.
2157 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2159 * regex.c (re_iswctype): Convert return values to boolean.
2161 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2163 * xdisp.c (compute_display_string_pos): Don't use cached display
2164 string position if the buffer had its restriction changed.
2167 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2169 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2171 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2173 Integer signedness and overflow and related fixes. (Bug#9079)
2175 * bidi.c: Integer size and overflow fixes.
2176 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2177 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2178 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2179 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2180 (bidi_find_other_level_edge):
2181 Use ptrdiff_t instead of EMACS_INT where either will do.
2182 This works better on 32-bit hosts configured --with-wide-int.
2183 (bidi_cache_ensure_space): Check for size-calculation overflow.
2184 Use % rather than repeated addition, for better worst-case speed.
2185 Don't set bidi_cache_size until after xrealloc returns, because it
2187 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2188 (bidi_cache_ensure_space): Also check that the bidi cache size
2189 does not exceed that of the largest Lisp string or buffer. See Eli
2190 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2192 * alloc.c (__malloc_size_t): Remove.
2193 All uses replaced by size_t. See Andreas Schwab's note
2194 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2196 * image.c: Improve checking for integer overflow.
2197 (check_image_size): Assume that f is nonnull, since
2198 it is always nonnull in practice. This is one less thing to
2199 worry about when checking for integer overflow later.
2200 (x_check_image_size): New function, which checks for integer
2201 overflow issues inside X.
2202 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2203 This removes the need for a memory_full check.
2204 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2205 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2206 (xbm_read_bitmap_data): Change locals back to 'int', since
2207 their values must fit in 'int'.
2208 (xpm_load_image, png_load, tiff_load):
2209 Invoke x_create_x_image_and_pixmap earlier,
2210 to avoid much needless work if the image is too large.
2211 (tiff_load): Treat overly large images as if
2212 x_create_x_image_and_pixmap failed, not as malloc failures.
2213 (gs_load): Use x_check_image_size.
2215 * gtkutil.c: Omit integer casts.
2216 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2217 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2219 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2221 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2222 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2223 would wrongly return t on a 64-bit host.
2225 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2226 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2227 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2228 and therefore cause GCC to emit a bogus diagnostic in some cases.
2230 * image.c: Integer signedness and overflow and related fixes.
2231 This is not an exhaustive set of fixes, but it's time to
2232 record what I've got.
2233 (lookup_pixel_color, check_image_size): Remove redundant decls.
2234 (check_image_size): Don't assume that arbitrary EMACS_INT values
2235 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2236 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2237 (tiff_load, imagemagick_load_image):
2238 Check for overflow in size calculations.
2239 (x_create_x_image_and_pixmap): Remove unnecessary test for
2240 xmalloc returning NULL; that can't happen.
2241 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2242 (xpm_color_bucket): Use better integer hashing function.
2243 (xpm_cache_color): Don't possibly over-allocate memory.
2244 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2245 (gif_memory_source):
2246 Use ptrdiff_t, not int or size_t, to record sizes.
2247 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2248 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2249 either works, as we prefer signed integers.
2250 (tiff_read_from_memory, tiff_write_from_memory):
2251 Return tsize_t, not size_t, since that's what the TIFF API wants.
2252 (tiff_read_from_memory): Don't fail simply because the read would
2253 go past EOF; instead, return a short read.
2254 (tiff_load): Omit no-longer-needed casts.
2255 (Fimagemagick_types): Don't assume size fits into 'int'.
2257 Improve hashing quality when configured --with-wide-int.
2258 * fns.c (hash_string): New function, taken from sxhash_string.
2259 Do not discard information about ASCII character case; this
2260 discarding is no longer needed.
2261 (sxhash-string): Use it. Change sig to match it. Caller changed.
2262 * lisp.h: Declare it.
2263 * lread.c (hash_string): Remove, since we now use fns.c's version.
2264 The fns.c version returns a wider integer if --with-wide-int is
2265 specified, so this should help the quality of the hashing a bit.
2267 * emacs.c: Integer overflow minor fix.
2268 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2269 Define only if GNU_LINUX.
2270 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2272 * dispnew.c: Integer signedness and overflow fixes.
2273 Remove unnecessary forward decls, that were a maintenance hassle.
2274 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2276 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2277 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2278 (prepare_desired_row, line_draw_cost):
2279 Use int, not unsigned, where either works.
2280 (save_current_matrix, restore_current_matrix):
2281 Use ptrdiff_t, not size_t, where either works.
2282 (init_display): Check for overflow more accurately, and without
2283 relying on undefined behavior.
2285 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2286 Remove, replacing with the new symbols in lisp.h. All uses changed.
2287 * fileio.c (make_temp_name):
2288 * filelock.c (lock_file_1, lock_file):
2289 * xdisp.c (message_dolog):
2290 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2291 Use pMd etc. instead.
2292 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2293 replacing the pWIDE etc. symbols removed from editfns.c.
2295 * keyboard.h (num_input_events): Now uintmax_t.
2296 This is (very slightly) less likely to mess up due to wraparound.
2299 * buffer.c: Integer signedness fixes.
2300 (alloc_buffer_text, enlarge_buffer_text):
2301 Use ptrdiff_t rather than size_t when either will do, as we prefer
2304 * alloc.c: Integer signedness and overflow fixes.
2305 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2306 (__malloc_size_t): Default to size_t, not to int.
2307 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2308 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2309 Prefer ptrdiff_t to size_t when either would do, as we prefer
2311 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2312 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2313 Now const. Initialize with values that are in range even if char
2315 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2316 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2317 These functions do the right thing with sizes > 2**32.
2318 (check_depth): Now ptrdiff_t, not int.
2319 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2320 Adjust to new way of storing sizes. Check for size overflow bugs
2322 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2323 slightly wrong anyway, as it missed one instance of
2324 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2325 (refill_memory_reserve): Omit needless cast to size_t.
2326 (mark_object_loop_halt): Mark as externally visible.
2328 * xselect.c: Integer signedness and overflow fixes.
2329 (Fx_register_dnd_atom, x_handle_dnd_message):
2330 Use ptrdiff_t, not size_t, since we prefer signed.
2331 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2332 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2333 x_dnd_atoms_size and x_dnd_atoms_length.
2335 * doprnt.c: Prefer signed to unsigned when either works.
2337 * doprnt.c (doprnt):
2339 * xdisp.c (vmessage):
2340 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2341 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2342 prefer signed arithmetic to avoid comparison confusion.
2343 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2344 but is a bit tricky.
2346 Assume freestanding C89 headers, string.h, stdlib.h.
2347 * data.c, doprnt.c, floatfns.c, print.c:
2348 Include float.h unconditionally.
2349 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2350 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2351 * regex.c: Likewise for stddef.h, string.h.
2352 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2353 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2354 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2355 (STDC_HEADERS): Remove obsolete defines.
2356 * sysdep.c: Include limits.h unconditionally.
2358 Assume support for memcmp, memcpy, memmove, memset.
2359 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2360 * regex.c (memcmp, memcpy):
2361 Remove; we assume C89 now.
2363 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2364 (__malloc_safe_bcopy): Remove; no longer needed.
2366 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2367 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2368 well either way, and we prefer signed to unsigned.
2370 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2372 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2373 closes the connection while we're reading (bug#9182).
2375 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2377 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2378 are specified (Bug#9168).
2380 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2382 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2383 Found by GCC static checking and --with-wide-int on a 32-bit host.
2385 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2387 * xdisp.c (compute_display_string_pos): Fix logic of caching
2388 previous display string position. Initialize cached_prev_pos to
2389 -1. Fixes slow-down at the beginning of a buffer.
2391 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2393 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2394 for attrs[LFACE_FONTSET_INDEX].
2396 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2398 * xml.c (parse_region): Remove unused local
2399 that was recently introduced.
2401 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2403 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2404 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2406 * xdisp.c (move_it_in_display_line_to): Record the best matching
2407 position for TO_CHARPOS while scanning the line, and restore it on
2408 exit if none of the characters scanned was an exact match.
2409 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2410 when exact match is impossible due to invisible text, and the
2411 lines are truncated.
2413 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2415 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2418 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2420 Fix a significant slow-down of cursor motion with C-n, C-p,
2421 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2422 auto-repeat under bidi redisplay in fontified buffers.
2423 * xdisp.c (compute_stop_pos_backwards): New function.
2424 (next_element_from_buffer): Call compute_stop_pos_backwards to
2425 find a suitable prev_stop when we find ourselves before
2427 (reseat): Don't look for prev_stop, as that could mean a very long
2429 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2430 <cached_disp_overlay_modiff>: Cache for last found display string
2432 (compute_display_string_pos): Return the cached position if asked
2433 about the same buffer in the same area of character positions, and
2434 the buffer wasn't changed since the time the display string
2435 position was cached.
2437 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2439 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2440 is an integer, which is important for empty lines. (Bug#9149)
2442 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2444 * frame.c (Fmodify_frame_parameters): In tty case, update the
2445 default face if necessary (Bug#4238).
2447 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2449 * editfns.c (Fstring_to_char): No need to explain what a character
2450 is in the docstring (Bug#6576).
2452 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2454 * xml.c (parse_region): Make sure we always return a tree.
2456 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2458 * xml.c (parse_region): If a document contains only comments,
2461 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2463 * xml.c (make_dom): Return comments, too.
2465 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2468 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2469 and the surrounding thread.
2470 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2471 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2472 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2474 * s/openbsd.h (BROKEN_SIGIO): Define.
2475 * unexelf.c (unexec) [__OpenBSD__]:
2476 Don't update the .mdebug section of the Alpha COFF symbol table.
2478 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2480 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2483 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2485 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2486 This fixes some race conditions on the permissions of any newly
2489 * alloc.c (valid_pointer_p): Use pipe, not open.
2490 This fixes some permissions issues when debugging.
2492 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2493 If fchown fails to set both uid and gid, try to set just gid,
2494 as that is sometimes allowed. Adjust the file's mode to eliminate
2495 setuid or setgid bits that are inappropriate if fchown fails.
2497 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2499 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2500 to compare Lisp_Objects.
2501 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2502 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2503 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2505 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2507 * lread.c (read_integer): Unread even EOF character.
2508 (read1): Likewise. Properly record start position of symbol.
2510 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2511 symbol character follows.
2513 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2515 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2516 This works around a problem with the previous change to Fcopy_file.
2517 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2518 and without this change, GCC might complain about discarding
2519 fchown's return value.
2521 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2523 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2525 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2527 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2529 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2531 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2532 it's used from the C level.
2534 * process.c: Use the same condition for POLL_FOR_INPUT in both
2535 keyboard.c and process.c (bug#1858).
2537 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2539 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2540 (Fgnutls_boot): Use it.
2542 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2544 * doc.c (Fsubstitute_command_keys): Revert last change.
2546 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2548 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2549 quotes the next character, and doesn't affect other longer
2550 sequences (bug#8935).
2552 * lread.c (syms_of_lread): Clarify that is isn't only
2553 `eval-buffer' and `eval-defun' that's affected by
2554 `lexical-binding' (bug#8460).
2556 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2558 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2559 bidi redisplay when a line includes both an image and is
2562 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2564 Fix minor problems found by static checking.
2565 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2566 (elsz): Now a signed constant, not a size_t var. We prefer signed
2567 types to unsigned, to avoid integer comparison confusion. Without
2568 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2569 "cannot optimize loop, the loop counter may overflow", a symptom
2571 * indent.c (Fvertical_motion): Mark locals as initialized.
2572 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2574 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2576 * search.c (Fre_search_backward): Mention `case-fold-search' in
2577 all the re_search_* functions (bug#8138).
2579 * keyboard.c (Fopen_dribble_file): Document when the file is
2582 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2584 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2587 Support bidi reordering of display and overlay strings.
2588 * xdisp.c (compute_display_string_pos)
2589 (compute_display_string_end): Accept additional argument STRING.
2590 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2591 (reseat_to_string): Initialize bidi_it->string.s and
2592 bidi_it->string.schars.
2593 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2594 NULL (avoids a crash in bidi_paragraph_init).
2595 Initialize itb.string.lstring.
2596 (init_iterator): Call bidi_init_it only of a valid
2597 buffer position was specified. Initialize paragraph_embedding to
2599 (reseat_to_string): Initialize the bidi iterator.
2600 (display_string): If we need to ignore text properties of
2601 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2602 original value of -1 will not work with bidi.)
2603 (compute_display_string_pos): First arg is now struct
2604 `text_pos *'; all callers changed. Support display properties on
2606 (compute_display_string_end): Support display properties on Lisp
2608 (init_iterator, reseat_1, reseat_to_string): Initialize the
2609 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2610 when iterating on a string not from display properties).
2611 (compute_display_string_pos, compute_display_string_end):
2612 Fix calculation of the object to scan. Fixes an error when using
2614 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2615 base_level_stop; instead, set base_level_stop to BEGV.
2616 Fixes crashes in vertical-motion.
2617 (next_element_from_buffer): Improve commentary for when
2618 the iterator is before prev_stop.
2619 (init_iterator): Initialize bidi_p from the default value of
2620 bidi-display-reordering, not from buffer-local value. Use the
2621 buffer-local value only if initializing for buffer iteration.
2622 (handle_invisible_prop): Support invisible properties on strings
2623 that are being bidi-reordered.
2624 (set_iterator_to_next): Support bidi reordering of C strings and
2626 (next_element_from_string): Support bidi reordering of Lisp
2628 (handle_stop_backwards): Support Lisp strings as well.
2629 (display_string): Support display of R2L glyph rows.
2630 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2631 (init_iterator): Don't initialize it->bidi_p for strings
2633 (reseat_to_string): Initialize it->bidi_p for strings here.
2634 (next_element_from_string, next_element_from_c_string)
2635 (next_element_from_buffer): Add xassert's for correspondence
2636 between IT's object being iterated and it->bidi_it.string
2638 (face_before_or_after_it_pos): Support bidi iteration.
2639 (next_element_from_c_string): Handle the case of the first string
2640 character that is not the first one in the visual order.
2641 (get_visually_first_element): New function, refactored from common
2642 parts of next_element_from_buffer, next_element_from_string, and
2643 next_element_from_c_string.
2644 (tool_bar_lines_needed, redisplay_tool_bar)
2645 (display_menu_bar): Force left-to-right direction. Add a FIXME
2646 comment for making that be controlled by a user option.
2647 (push_it, pop_it): Save and restore the state of the
2648 bidi iterator. Save and restore the bidi_p flag.
2649 (pop_it): Iterate out of display property for string iteration as
2651 (iterate_out_of_display_property): Support iteration over strings.
2652 (handle_single_display_spec): Set up it->bidi_it for iteration
2653 over a display string, and call bidi_init_it.
2654 (handle_single_display_spec, next_overlay_string)
2655 (get_overlay_strings_1, push_display_prop): Set up the bidi
2656 iterator for displaying display or overlay strings.
2657 (forward_to_next_line_start): Don't use the shortcut if
2659 (back_to_previous_visible_line_start): If handle_display_prop
2660 pushed the iterator stack, restore the internal state of the bidi
2661 iterator by calling bidi_pop_it same number of times.
2662 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2663 and we are bidi-iterating, don't decrement the iterator position;
2664 instead, set the first_elt flag in the bidi iterator, to produce
2666 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2667 (push_display_prop): xassert that we are iterating a buffer.
2668 (push_it, pop_it): Save and restore paragraph_embedding member.
2669 (handle_single_display_spec, next_overlay_string)
2670 (get_overlay_strings_1, reseat_1, reseat_to_string)
2671 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2672 correctly. Don't assume unibyte strings are not bidi-reordered.
2673 (compute_display_string_pos)
2674 (compute_display_string_end): Fix handling the case of C string.
2675 (push_it, pop_it): Save and restore from_disp_prop_p.
2676 (handle_single_display_spec, push_display_prop): Set the
2677 from_disp_prop_p flag.
2678 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2679 (pop_it): Call iterate_out_of_display_property only if we are
2680 popping after iteration over a string that came from a display
2681 property. Fix a typo in popping stretch info. Add an assertion
2682 for verifying that the iterator position is in sync with the bidi
2684 (handle_single_display_spec, get_overlay_strings_1)
2685 (push_display_prop): Fix initialization of paragraph direction for
2686 string when that of the parent object is not yet determined.
2687 (reseat_1): Call bidi_init_it to resync the bidi
2688 iterator with IT's position. (Bug#7616)
2689 (find_row_edges): If ROW->start.pos gives position
2690 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2691 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2692 Reset the from_disp_prop_p flag.
2693 (SAVE_IT, RESTORE_IT): New macros.
2694 (pos_visible_p, face_before_or_after_it_pos)
2695 (back_to_previous_visible_line_start)
2696 (move_it_in_display_line_to, move_it_in_display_line)
2697 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2698 (try_scrolling, redisplay_window, display_line): Use them when
2699 saving a temporary copy of the iterator and restoring it back.
2700 (back_to_previous_visible_line_start, reseat_1)
2701 (init_iterator): Empty the bidi cache "stack".
2702 (move_it_in_display_line_to): If iterator ended up at
2703 EOL, but we never saw any buffer positions smaller than
2704 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2705 motion in bidi-reordered lines.
2706 (move_it_in_display_line_to): Record prev_method and prev_pos
2707 immediately before the call to set_iterator_to_next. Fixes cursor
2708 motion in bidi-reordered lines with stretch glyphs and strings
2709 displayed in margins. (Bug#8133) (Bug#8867)
2710 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2712 (pos_visible_p): Support positions in bidi-reordered lines.
2713 Save and restore bidi cache.
2715 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2716 (bidi_paragraph_info): Delete unused struct.
2717 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2718 (bidi_cache_start): New variable.
2719 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2721 (bidi_cache_fetch_state, bidi_cache_search)
2722 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2723 (bidi_cache_find, bidi_peek_at_next_level)
2724 (bidi_level_of_next_char, bidi_find_other_level_edge)
2725 (bidi_move_to_visually_next): Compare cache index with
2726 bidi_cache_start rather than with zero.
2727 (bidi_fetch_char): Accept new argument STRING; all callers
2728 changed. Support iteration over a string. Support strings with
2729 display properties. Support unibyte strings. Fix the type of
2730 `len' according to what STRING_CHAR_AND_LENGTH expects.
2731 (bidi_paragraph_init, bidi_resolve_explicit_1)
2732 (bidi_resolve_explicit, bidi_resolve_weak)
2733 (bidi_level_of_next_char, bidi_move_to_visually_next):
2734 Support iteration over a string.
2735 (bidi_set_sor_type, bidi_resolve_explicit_1)
2736 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2737 can now be zero (for strings); special values 0 and -1 were
2738 changed to -1 and -2, respectively.
2739 (bidi_char_at_pos): New function.
2740 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2741 Call it instead of FETCH_MULTIBYTE_CHAR.
2742 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2743 initialized to valid values.
2744 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2746 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2747 the test for valid cached positions. Fix the logic for looking up
2748 the sentinel state in the cache. GCPRO the Lisp string we are
2750 (bidi_push_it, bidi_pop_it): New functions.
2751 (bidi_initialize): Initialize the bidi cache start stack pointer.
2752 (bidi_cache_ensure_space): New function, refactored from part of
2753 bidi_cache_iterator_state. Don't assume the required size is just
2754 one BIDI_CACHE_CHUNK away.
2755 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2756 (bidi_count_bytes, bidi_char_at_pos): New functions.
2757 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2758 always valid if bidi_cache_idx is valid.
2759 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2760 is valid if it's going to be used.
2761 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2762 (bidi_cache_fetch_state, bidi_cache_search)
2763 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2764 (bidi_cache_iterator_state, bidi_cache_find)
2765 (bidi_find_other_level_edge, bidi_cache_start_stack):
2766 All variables related to cache indices are now EMACS_INT.
2768 * dispextern.h (struct bidi_string_data): New structure.
2769 (struct bidi_it): New member `string'. Make flag members be 1-bit
2770 fields, and put them last in the struct.
2771 (compute_display_string_pos, compute_display_string_end):
2773 (bidi_push_it, bidi_pop_it): Add prototypes.
2774 (struct iterator_stack_entry): New members bidi_p,
2775 paragraph_embedding, and from_disp_prop_p.
2776 (struct it): Member bidi_p is now a bit field 1 bit wide.
2777 (bidi_shelve_cache, bidi_unshelve_cache):
2780 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2781 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2782 and vector-like objects.
2784 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2785 cache around display iteration.
2787 * window.c (Fwindow_end, window_scroll_pixel_based)
2788 (displayed_window_lines, Frecenter): Save and restore the bidi
2789 cache around display iteration.
2791 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2793 * editfns.c (Fdelete_region): Clarify the use of the named
2794 parameters (bug#6788).
2796 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2798 * indent.c (Fvertical_motion): Set and restore w->pointm when
2799 saving and restoring the window's buffer (Bug#9006).
2801 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2803 * editfns.c (Fstring_to_char): Clarify just what is returned
2804 (bug#6576). Text by Eli Zaretskii.
2806 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2808 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2810 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2812 * buffer.c (mmap_find): Fix a typo.
2814 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2816 Fix execution of x selection hooks.
2817 * xselect.c (Qx_lost_selection_functions)
2818 (Qx_sent_selection_functions): New vars.
2819 (syms_of_xselect): DEFSYM them.
2820 (x_handle_selection_request): Pass Qx_sent_selection_functions
2821 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2822 (x_handle_selection_clear,x_clear_frame_selections):
2823 Pass Qx_lost_selection_functions rather than
2824 Vx_lost_selection_functions to Frun_hook_with_args.
2826 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2828 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2829 The old code sometimes used this field without initializing it.
2831 * alloc.c (gc_sweep): Don't read past end of array.
2832 In theory, the old code could also have corrupted Emacs internals,
2833 though it'd be very unlikely.
2835 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2837 * character.c (Fcharacterp): Don't advertise optional ignored
2838 argument. (Bug#4026)
2840 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2842 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2845 * window.c (Fset_window_start): Doc fix (bug#4199).
2846 (Fset_window_hscroll): Ditto.
2848 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2850 Fix minor new problems caught by GCC 4.6.1.
2851 * term.c (init_tty): Remove unused local.
2852 * xsettings.c (store_monospaced_changed): Define this function only
2853 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2856 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2858 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2860 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2862 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2863 are the mini-buffer and the echo area (bug#3320).
2865 * term.c (init_tty): Remove support for supdup, c10 and perq
2866 terminals, which are no longer supported (bug#1482).
2868 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2870 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2872 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2874 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2875 for non-popups (Bug#3642).
2877 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2879 * alloc.c (reset_malloc_hooks): Protoize.
2880 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2881 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2882 * cm.c (losecursor): Likewise.
2883 * data.c (fmod): Likewise.
2884 * dispnew.c (swap_glyphs_in_rows): Likewise.
2885 * emacs.c (memory_warning_signal): Likewise.
2886 * floatfns.c (float_error): Likewise.
2887 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2888 (otf_open, font_otf_capability, generate_otf_features)
2889 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2891 * image.c (pbm_read_file): Likewise.
2892 * indent.c (string_display_width): Likewise.
2893 * intervals.c (check_for_interval, search_for_interval)
2894 (inc_interval_count, count_intervals, root_interval)
2895 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2896 * lread.c (defalias): Likewise.
2897 * ralloc.c (r_alloc_check): Likewise.
2898 * regex.c (set_image_of_range_1, set_image_of_range)
2899 (regex_grow_registers): Likewise.
2900 * sysdep.c (strerror): Likewise.
2901 * termcap.c (valid_filename_p, tprint, main): Likewise.
2902 * tparam.c (main): Likewise.
2903 * unexhp9k800.c (run_time_remap, save_data_space)
2904 (update_file_ptrs, read_header, write_header, calculate_checksum)
2905 (copy_file, copy_rest, display_header): Likewise.
2906 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2908 * xdisp.c (check_it): Likewise.
2909 * xfaces.c (register_color, unregister_color, unregister_colors):
2911 * xfns.c (print_fontset_result): Likewise.
2912 * xrdb.c (member, fatal, main): Likewise.
2914 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2916 Fix minor problems found by static checking (Bug#9031).
2917 * chartab.c (char_table_set_range, map_sub_char_table):
2918 Remove unused locals.
2919 (uniprop_table): Now static.
2920 * composite.c (_work_char): Remove unused static var.
2922 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2924 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2926 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2928 * gtkutil.c (qttip_cb): Remove code without function.
2930 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2932 * w32.c (pthread_sigmask): New stub.
2934 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2936 Use pthread_sigmask, not sigprocmask (Bug#9010).
2937 sigprocmask is portable only for single-threaded applications, and
2938 Emacs can be multi-threaded when it uses GTK.
2939 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2941 * callproc.c (Fcall_process):
2942 * process.c (create_process):
2943 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2944 Use pthread_sigmask, not sigprocmask.
2946 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2948 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2949 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2952 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2954 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2955 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2956 (xg_hide_tooltip): Fix comment.
2958 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2959 in registerServicesMenuSendTypes.
2960 (validRequestorForSendType): Don't check ns_return_types.
2962 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2965 2011-07-08 Jason Rumney <jasonr@gnu.org>
2967 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2968 frame struct members of non-existent frames (Bug#6284).
2970 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2972 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2973 variable firstTime not needed on OSX >= 10.6.
2974 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2975 >= 10.5. Use setKnobProportion, setDoubleValue.
2977 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2978 (MAC_OS_X_VERSION_10_5): Define if not defined.
2979 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2980 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2981 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2983 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2984 cString and lossyCString on OSX >= 10.4
2986 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2987 sizeToFit on OSX >= 10.2.
2989 * nsimage.m (allocInitFromFile): Don't use deprecated method
2990 bestRepresentationForDevice on OSX >= 10.6.
2992 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2995 * emacs.c: Declare unexec_init_emacs_zone.
2997 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2999 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3001 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3002 on svcsMenu (Bug#8842).
3004 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3006 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3008 * nsterm.m (QUTF8_STRING): Declare.
3009 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3010 (validRequestorForSendType): Return type is (id).
3011 Change indexOfObjectIdenticalTo to indexOfObject.
3012 Check if we have local selection before returning self (Bug#8842).
3013 (writeSelectionToPasteboard): Put local selection into paste board
3014 if we have a local selection (Bug#8842).
3015 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3017 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3018 (ns_get_local_selection): Declare.
3020 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3022 * keymap.c (describe_map_tree): Don't insert a double newline at
3023 the end of the buffer (bug#1169) and return whether we inserted
3026 * callint.c (Fcall_interactively): Change "reading args" to
3027 "providing args" to try to clarify what it does (bug#1010).
3029 2011-07-07 Kenichi Handa <handa@m17n.org>
3031 * composite.c (composition_compute_stop_pos): Ignore a static
3032 composition starting before CHARPOS (Bug#8915).
3034 * xdisp.c (handle_composition_prop): Likewise.
3036 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3038 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3041 2011-07-07 Kenichi Handa <handa@m17n.org>
3043 * character.h (unicode_category_t): New enum type.
3045 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3046 (Qchar_code_property_table): New variable.
3047 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3048 (UNIPROP_COMPRESSED_FORM_P): New macros.
3049 (char_table_ascii): Uncompress the compressed values.
3050 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3051 Uncompress the compressed values.
3052 (sub_char_table_ref_and_range): Likewise.
3053 (char_table_ref_and_range): Uncompress the compressed values.
3054 (sub_char_table_set): New arg is_uniprop. Callers changed.
3055 Uncompress the compressed values.
3056 (sub_char_table_set_range): Args changed. Callers changed.
3057 (char_table_set_range): Adjuted for the above change.
3058 (map_sub_char_table): Delete args default_val and parent. Add arg
3059 top. Give decoded values to a Lisp function.
3060 (map_char_table): Adjust for the above change. Give decoded
3061 values to a Lisp function. Gcpro more variables.
3062 (uniprop_table_uncompress)
3063 (uniprop_decode_value_run_length): New functions.
3064 (uniprop_decoder, uniprop_decoder_count): New variables.
3065 (uniprop_get_decoder, uniprop_encode_value_character)
3066 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3068 (uniprop_encoder, uniprop_encoder_count): New variables.
3069 (uniprop_get_encoder, uniprop_table)
3070 (Funicode_property_table_internal, Fget_unicode_property_internal)
3071 (Fput_unicode_property_internal): New functions.
3072 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3073 Sunicode_property_table_internal, Sget_unicode_property_internal,
3074 and Sput_unicode_property_internal. Defvar_lisp
3075 char-code-property-alist.
3077 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3078 Vunicode_category_table.
3080 * font.c (font_range): Adjust for the change of
3081 Vunicode_category_table.
3083 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3085 * m/iris4d.h: Remove file, move contents ...
3086 * s/irix6-5.h: ... here.
3088 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3090 Remove unportable assumption about struct layout (Bug#8884).
3091 * alloc.c (mark_buffer):
3092 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3093 (clone_per_buffer_values): Don't assume that
3094 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3095 This isn't true in general, and it's particularly not true
3096 if Emacs is configured with --with-wide-int.
3097 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3098 New macros, used in the buffer.c change.
3100 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3102 * xsettings.c: Use both GConf and GSettings if both are available.
3103 (store_config_changed_event): Add comment.
3104 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3105 (store_tool_bar_style_changed): New functions.
3106 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3107 (struct xsettings): Move font inside HAVE_XFT.
3108 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3109 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3110 Move inside HAVE_XFT.
3111 (something_changed_gsettingsCB): Rename from something_changedCB.
3112 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3114 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3115 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3116 (something_changed_gconfCB): Rename from something_changedCB.
3117 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3118 (parse_settings): Move check for font inside HAVE_XFT.
3119 (read_settings, apply_xft_settings): Add comment.
3120 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3121 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3122 call store_font_name_changed.
3123 (xft_settings_event): Add comment.
3124 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3125 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3126 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3127 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3128 (xsettings_initialize): Call init_gsettings last.
3129 (xsettings_get_system_font, xsettings_get_system_normal_font):
3132 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3134 Random fixes. E.g., (random) never returned negative values.
3135 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3136 subseconds part to the entropy, as that's a bit more random.
3137 Prefer signed to unsigned, since the signedness doesn't matter and
3138 in general we prefer signed. When given a limit, use a
3139 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3140 latter isn't right if USE_2_TAGS_FOR_INTS.
3141 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3142 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3144 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3146 * textprop.c (text_property_stickiness):
3147 Obey Vtext_property_default_nonsticky.
3148 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3149 * w32fns.c (syms_of_w32fns):
3150 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3152 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3154 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3155 This is more efficient than Ffile_directory_p and avoids a minor race.
3157 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3159 * buffer.c (Foverlay_put): Say what the return value is
3162 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3163 is a directory before asking whether to use the file name
3165 (barf_or_query_if_file_exists): Make the "File is a directory"
3166 error be more correct.
3168 * fns.c (Frequire): Remove the mention of the .gz files, since
3169 that's installation-specific, but keep the mention of
3170 `get-load-suffixes'.
3172 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3174 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3175 Report string overflow if the output is too long.
3177 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3179 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3180 (syms_of_gnutls): Remove duplicate DEFSYM for
3181 Qgnutls_bootprop_verify_hostname_error, an error for
3182 Qgnutls_bootprop_verify_error (which is no longer used).
3184 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3185 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3186 Also (re)move comments that are misplaced or no longer relevant.
3188 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3190 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3192 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3194 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3195 and background color parameters if they have been changed.
3197 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3199 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3201 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3203 * xsettings.c (SYSTEM_FONT): Define only when used.
3204 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3206 * keymap.c (access_keymap_1): Now static.
3208 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3210 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3211 leave any prefix arg for the up event (Bug#1586).
3213 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3215 * lread.c (syms_of_lread): Mention single symbols defined by
3216 `defvar' or `defconst' (bug#7154).
3218 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3219 (Frequire): Mention get-load-suffixes.
3221 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3223 * window.h (window): Remove clone_number slot.
3224 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3226 (make_parent_window, make_window, saved_window)
3227 (Fset_window_configuration, save_window_save): Don't deal with
3229 * buffer.c (Qclone_number): Remove declaration.
3230 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3232 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3234 Add multiple inheritance to keymaps.
3235 * keymap.c (Fmake_composed_keymap): New function.
3236 (Fset_keymap_parent): Simplify.
3237 (fix_submap_inheritance): Remove.
3238 (access_keymap_1): New function extracted from access_keymap to handle
3239 embedded parents and handle lists of maps.
3240 (access_keymap): Use it.
3241 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3242 (Fcopy_keymap): Handle embedded parents.
3243 (Fcommand_remapping, define_as_prefix): Simplify.
3244 (Fkey_binding): Simplify.
3245 (syms_of_keymap): Move minibuffer-local-completion-map,
3246 minibuffer-local-filename-completion-map,
3247 minibuffer-local-must-match-map, and
3248 minibuffer-local-filename-must-match-map to Elisp.
3249 (syms_of_keymap): Defsubr make-composed-keymap.
3250 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3251 (parse_menu_item): Trivial simplification.
3253 2011-07-01 Glenn Morris <rgm@gnu.org>
3255 * Makefile.in (SETTINGS_LIBS): Fix typo.
3257 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3259 * coding.c (Fencode_coding_string): Record the last coding system
3260 used, as the function doc string says (bug#8738).
3262 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3264 * xsettings.c (store_monospaced_changed): Take new font as arg and
3265 check for change against current_mono_font.
3266 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3267 (emacs_settings_constructor, emacs_settings_get_property)
3268 (emacs_settings_set_property, emacs_settings_class_init)
3269 (emacs_settings_init, gsettings_obj): Remove.
3270 (something_changedCB): New function for HAVE_GSETTINGS.
3271 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3272 with value as argument.
3273 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3274 g_settings_new (Bug#8967). Do not create gsettings_obj.
3275 Remove calls to g_settings_bind. Connect something_changedCB to
3278 * xgselect.c: Add defined (HAVE_GSETTINGS).
3279 (xgselect_initialize): Ditto.
3281 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3282 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3285 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3287 * eval.c (struct backtrace): Simplify and port the data structure.
3288 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3289 signed bit field, as this assumption is not portable and it makes
3290 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3291 "char debug_on_exit : 1" as this is not portable either; instead,
3292 use the portable "unsigned int debug_on_exit : 1". Remove unused
3293 member evalargs. Remove obsolete comments about cc bombing out.
3295 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3297 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3298 Let HAVE_GSETTINGS override HAVE_GCONF.
3299 (store_monospaced_changed): New function.
3300 (EMACS_SETTINGS): A new type derived from GObject to handle
3301 GSettings notifications.
3302 (emacs_settings_constructor, emacs_settings_get_property)
3303 (emacs_settings_set_property, emacs_settings_class_init):
3305 (gsettings_client, gsettings_obj): New variables.
3306 (GSETTINGS_SCHEMA): New define.
3307 (something_changedCB): Call store_monospaced_changed.
3308 (init_gsettings): New function.
3309 (xsettings_initialize): Call init_gsettings.
3310 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3313 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3316 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3318 * window.c (resize_root_window, grow_mini_window)
3319 (shrink_mini_window): Rename Qresize_root_window to
3320 Qwindow_resize_root_window and Qresize_root_window_vertically to
3321 Qwindow_resize_root_window_vertically.
3323 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3325 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3327 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3329 * makefile.w32-in: Redesign dependencies so they reflect more
3330 clearly which files are directly included by each source file,
3331 and not through other includes.
3333 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3335 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3336 (sort_overlays, overlay_strings): When an overlay's clone number
3337 matches the window's clone number process the overlay even if
3338 the overlay's window property doesn't match the current window.
3340 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3341 (Fwindow_hchild): Rename to Fwindow_left_child.
3342 (Fwindow_next): Rename to Fwindow_next_sibling.
3343 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3344 (resize_window_check): Rename to window_resize_check.
3345 (resize_window_apply): Rename to window_resize_apply.
3346 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3347 (Fdelete_other_windows_internal, resize_frame_windows)
3348 (Fsplit_window_internal, Fdelete_window_internal)
3349 (grow_mini_window, shrink_mini_window)
3350 (Fresize_mini_window_internal): Fix callers accordingly.
3352 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3354 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3355 (emacs_fixed_set_min_size): Remove.
3356 (emacs_fixed_new): Take frame as argument.
3358 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3359 (_EmacsFixedPrivate): Remove minwidth/height.
3360 Add struct frame *f.
3361 (emacs_fixed_init): Initialize priv->f.
3362 (get_parent_class, emacs_fixed_set_min_size): Remove.
3363 (emacs_fixed_new): Set priv->f to argument.
3364 (emacs_fixed_get_preferred_width)
3365 (emacs_fixed_get_preferred_height): Use min_width/height from
3366 frames size_hint to set minimum and natural (Bug#8919).
3367 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3368 and use min_width/height from frames size_hint to set
3369 min_width/height (Bug#8919).
3371 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3372 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3375 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3377 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3378 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3381 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3383 * process.c (wait_reading_process_output): Bypass select if
3384 waiting for a cell while ignoring keyboard input, and input is
3385 pending. Suggested by Jan Djärv (Bug#8869).
3387 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3389 Use gnulib's dup2 module instead of rolling our own.
3390 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3392 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3394 * dispnew.c (scrolling_window): Before scrolling, turn off a
3395 mouse-highlight in the window being scrolled.
3397 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3399 Move DEFSYM to lisp.h and use everywhere.
3401 * character.h (DEFSYM): Move declaration...
3402 * lisp.h (DEFSYM): ...here.
3408 * w32select.c: Don't include character.h.
3410 * alloc.c (syms_of_alloc):
3411 * buffer.c (syms_of_buffer):
3412 * bytecode.c (syms_of_bytecode):
3413 * callint.c (syms_of_callint):
3414 * casefiddle.c (syms_of_casefiddle):
3415 * casetab.c (init_casetab_once):
3416 * category.c (init_category_once, syms_of_category):
3417 * ccl.c (syms_of_ccl):
3418 * cmds.c (syms_of_cmds):
3419 * composite.c (syms_of_composite):
3420 * dbusbind.c (syms_of_dbusbind):
3421 * dired.c (syms_of_dired):
3422 * dispnew.c (syms_of_display):
3423 * doc.c (syms_of_doc):
3424 * editfns.c (syms_of_editfns):
3425 * emacs.c (syms_of_emacs):
3426 * eval.c (syms_of_eval):
3427 * fileio.c (syms_of_fileio):
3428 * fns.c (syms_of_fns):
3429 * frame.c (syms_of_frame):
3430 * fringe.c (syms_of_fringe):
3431 * insdel.c (syms_of_insdel):
3432 * keymap.c (syms_of_keymap):
3433 * lread.c (init_obarray, syms_of_lread):
3434 * macros.c (syms_of_macros):
3435 * msdos.c (syms_of_msdos):
3436 * print.c (syms_of_print):
3437 * process.c (syms_of_process):
3438 * search.c (syms_of_search):
3439 * sound.c (syms_of_sound):
3440 * syntax.c (init_syntax_once, syms_of_syntax):
3441 * terminal.c (syms_of_terminal):
3442 * textprop.c (syms_of_textprop):
3443 * undo.c (syms_of_undo):
3444 * w32.c (globals_of_w32):
3445 * window.c (syms_of_window):
3446 * xdisp.c (syms_of_xdisp):
3447 * xfaces.c (syms_of_xfaces):
3448 * xfns.c (syms_of_xfns):
3449 * xmenu.c (syms_of_xmenu):
3450 * xsettings.c (syms_of_xsettings):
3451 * xterm.c (syms_of_xterm): Use DEFSYM.
3453 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3455 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3457 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3459 Integer and buffer overflow fixes (Bug#8873).
3461 * print.c (printchar, strout): Check for string overflow.
3462 (PRINTPREPARE, printchar, strout):
3463 Don't set size unless allocation succeeds.
3465 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3466 for sizes. Check for string overflow more accurately.
3467 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3469 * macros.c: Integer and buffer overflow fixes.
3470 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3471 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3472 Use ptrdiff_t, not int, for sizes.
3473 Don't increment bufsize until after realloc succeeds.
3474 Check for size-calculation overflow.
3475 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3477 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3479 * lread.c: Integer overflow fixes.
3480 (read_integer): Radix is now EMACS_INT, not int,
3481 to improve quality of diagnostics for out-of-range radices.
3482 Calculate buffer size correctly for out-of-range radices.
3483 (read1): Check for integer overflow in radices, and in
3484 read-circle numbers.
3485 (read_escape): Avoid int overflow.
3486 (Fload, openp, read_buffer_size, read1)
3487 (substitute_object_recurse, read_vector, read_list, map_obarray):
3488 Use ptrdiff_t, not int, for sizes.
3489 (read1): Use EMACS_INT, not int, for sizes.
3490 Check for size overflow.
3492 * image.c (cache_image): Check for size arithmetic overflow.
3494 * lread.c: Integer overflow issues.
3495 (saved_doc_string_size, saved_doc_string_length)
3496 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3497 Now ptrdiff_t, not int.
3498 (read1): Don't assume doc string length fits in int. Check for
3499 out-of-range doc string lengths.
3500 (read_list): Don't assume file position fits in int.
3501 (read_escape): Check for hex character overflow.
3503 2011-06-22 Leo Liu <sdl.web@gmail.com>
3505 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3506 Move to minibuffer.el.
3508 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3510 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3511 The following patches are for when GLYPH_DEBUG && !XASSERT.
3512 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3513 * dispnew.c (flush_stdout):
3514 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3515 Mark as externally visible.
3516 * dispnew.c (check_window_matrix_pointers): Now static.
3517 * dispnew.c (window_to_frame_vpos):
3518 * xfns.c (unwind_create_frame):
3519 * xterm.c (x_check_font): Remove unused local.
3520 * scroll.c (CHECK_BOUNDS):
3521 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3522 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3523 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3524 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3525 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3527 (debug_method_add): Use va_list and vsprintf rather than relying
3528 on undefined behavior with wrong number of arguments.
3529 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3530 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3531 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3532 since we're not interested in debugging glyphs with old libraries.
3533 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3534 GCC 4.6.0's static checking.
3536 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3538 Integer overflow and signedness fixes (Bug#8873).
3539 A few related buffer overrun fixes, too.
3541 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3543 * dispextern.h (struct face.stipple):
3544 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3545 (x_bitmap_mask, x_allocate_bitmap_record)
3546 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3547 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3548 (x_create_bitmap_from_xpm_data):
3549 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3550 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3552 * xfaces.c (load_pixmap):
3553 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3554 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3555 (.bitmaps_last, struct x_output.icon_bitmap):
3556 Use ptrdiff_t, not int, for bitmap indexes.
3557 (x_allocate_bitmap_record): Check for size overflow.
3558 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3560 Use ptrdiff_t, not int, for overlay counts.
3561 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3562 * editfns.c (overlays_around, get_pos_property):
3563 * textprop.c (get_char_property_and_overlay):
3564 * xdisp.c (next_overlay_change, note_mouse_highlight):
3565 * xfaces.c (face_at_buffer_position):
3566 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3567 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3568 (Fnext_overlay_change, Fprevious_overlay_change)
3569 (mouse_face_overlay_overlaps, Foverlays_in):
3570 Use ptrdiff_t, not int, for sizes.
3571 (overlays_at, overlays_in): Check for size-calculation overflow.
3573 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3575 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3576 (x_session_initialize): Do not assume string length fits in int.
3578 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3579 This is unlikely, but can occur if DPI is outlandish.
3581 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3582 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3584 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3585 * xrdb.c (magic_file_p, search_magic_path):
3586 Omit last arg SUFFIX; it was always 0. All callers changed.
3587 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3589 * xfont.c (xfont_match): Avoid need for strlen.
3591 * xfns.c: Don't assume strlen fits in int.
3592 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3594 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3595 not unsigned long, as we prefer signed integers. All callers changed.
3596 Detect integer overflow in repeat count.
3597 (message_dolog): Don't assume print length fits in 39 bytes.
3598 (display_mode_element): Don't assume strlen fits in int.
3600 * termcap.c: Don't assume sizes fit in int and never overflow.
3601 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3602 (gobble_line): Check for size-calculation overflow.
3604 * minibuf.c (Fread_buffer):
3605 * lread.c (intern, intern_c_string):
3606 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3607 Don't assume string length fits in int.
3609 * keyboard.c (parse_tool_bar_item):
3610 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3612 * font.c: Don't assume string length fits in int.
3613 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3614 Use ptrdiff_t, not int.
3615 (font_intern_prop): Don't assume string length fits in int.
3616 Don't assume integer property fits in fixnum.
3617 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3619 * filelock.c: Fix some buffer overrun and integer overflow issues.
3620 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3621 Reformulate so as not to need the command string.
3622 Invoke gzip -cd rather than gunzip, as it's more portable.
3623 (lock_info_type, lock_file_1, lock_file):
3624 Don't assume pid_t and time_t fit in unsigned long.
3625 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3626 (current_lock_owner): Prefer signed type for sizes.
3627 Use memcpy, not strncpy, where memcpy is what is really wanted.
3628 Don't assume (via atoi) that time_t and pid_t fit in int.
3629 Check for time_t and/or pid_t out of range, e.g., via a network share.
3630 Don't alloca where an auto var works fine.
3632 * fileio.c: Fix some integer overflow issues.
3633 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3634 Don't assume string length fits in int.
3635 (directory_file_name): Don't assume string length fits in long.
3636 (make_temp_name): Don't assume pid fits in int, or that its print
3637 length is less than 20.
3639 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3641 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3643 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3645 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3646 We prefer signed integers, even for size calculations.
3648 * emacs.c: Don't assume string length fits in 'int'.
3649 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3650 (main): Don't invoke strlen when not needed.
3652 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3653 (XD_DEBUG_MESSAGE): Don't waste a byte.
3655 * callproc.c (getenv_internal_1, getenv_internal)
3657 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3659 * lread.c (invalid_syntax): Omit length argument.
3660 All uses changed. This doesn't fix a bug, but it simplifies the
3661 code away from its former Hollerith-constant appearance, and it's
3662 one less 'int' to worry about when looking at integer-overflow issues.
3663 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3665 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3666 This didn't break anything, but it didn't help either.
3667 It's confusing to put a bogus integer in a place where the actual
3668 value does not matter.
3669 (LIST_END_P): Remove unused macro and its bogus comment.
3670 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3672 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3673 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3675 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3676 We prefer signed types, and the value cannot exceed the EMACS_INT
3677 range anyway (because otherwise the length would not be representable).
3678 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3679 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3680 This avoids a GCC warning when WIDE_EMACS_INT.
3682 * indent.c (sane_tab_width): New function.
3683 (current_column, scan_for_column, Findent_to, position_indentation)
3684 (compute_motion): Use it. This is just for clarity.
3685 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3687 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3689 * lisp.h (lint_assume): New macro.
3690 * composite.c (composition_gstring_put_cache):
3691 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3693 * editfns.c, insdel.c:
3694 Omit unnecessary forward decls, to simplify future changes.
3696 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3698 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3700 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3701 Use much-faster test for byte-length change.
3702 Don't assume string byte-length fits in 'int'.
3703 Check that character arg fits in 'int'.
3704 (mapcar1): Declare byte as byte, for clarity.
3706 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3708 * fns.c (concat): Catch string overflow earlier.
3709 Do not rely on integer wraparound.
3711 * dispextern.h (struct it.overlay_strings_charpos)
3712 (struct it.selective): Now EMACS_INT, not int.
3713 * xdisp.c (forward_to_next_line_start)
3714 (back_to_previous_visible_line_start)
3715 (reseat_at_next_visible_line_start, next_element_from_buffer):
3716 Don't arbitrarily truncate the value of 'selective' to int.
3718 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3720 * composite.c: Don't truncate sizes to 'int'.
3721 (composition_gstring_p, composition_reseat_it)
3722 (composition_adjust_point): Use EMACS_INT, not int.
3723 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3724 not EMACS_UINT, for indexes.
3726 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3728 * buffer.c: Include <verify.h>.
3729 (struct sortvec.priority, struct sortstr.priority):
3730 Now EMACS_INT, not int.
3731 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3732 (struct sortstr.size, record_overlay_string)
3733 (struct sortstrlist.size, struct sortlist.used):
3734 Don't truncate size to int.
3735 (record_overlay_string): Check for size-calculation overflow.
3736 (init_buffer_once): Check at compile-time, not run-time.
3738 2011-06-22 Jim Meyering <meyering@redhat.com>
3740 Don't leak an XBM-image-sized buffer
3741 * image.c (xbm_load): Free the image buffer after using it.
3743 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3746 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3747 that Sun C diagnosed.
3748 * fns.c (secure_hash): Fix pointer signedness issue.
3749 * intervals.c (static_offset_intervals): New function.
3750 (offset_intervals): Use it.
3752 2011-06-21 Leo Liu <sdl.web@gmail.com>
3755 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3758 * fns.c (secure_hash): Rename from crypto_hash_function and change
3759 the first arg to accept symbols.
3760 (Fsecure_hash): New primitive.
3761 (syms_of_fns): New symbols.
3763 2011-06-20 Deniz Dogan <deniz@dogan.se>
3765 * process.c (Fset_process_buffer): Clarify return value in
3768 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3770 * dispnew.c (add_window_display_history): Use BVAR.
3772 * xdisp.c (debug_method_add): Use BVAR.
3773 (check_window_end, dump_glyph_matrix, dump_glyph)
3774 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3776 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3779 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3780 check till after the cache is created in init_frame_faces.
3782 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3784 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3786 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3788 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3789 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3790 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3792 Improve buffer-overflow checking (Bug#8873).
3793 * fileio.c (Finsert_file_contents):
3794 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3795 Remove the old (too-loose) buffer overflow checks.
3796 They weren't needed, since make_gap checks for buffer overflow.
3797 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3798 The old code merely checked for Emacs fixnum overflow, and relied
3799 on undefined (wraparound) behavior. The new code avoids undefined
3800 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3802 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3803 Tune. Don't use wider integers than needed. Don't use alloca.
3804 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3806 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3808 * insdel.c, lisp.h (buffer_overflow): New function.
3809 (insert_from_buffer_1, replace_range, replace_range_2):
3810 * insdel.c (make_gap_larger):
3811 * editfns.c (Finsert_char):
3812 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3814 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3816 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3818 Integer overflow and signedness fixes (Bug#8873).
3820 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3821 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3823 * fileio.c: Don't assume EMACS_INT fits in off_t.
3824 (emacs_lseek): New static function.
3825 (Finsert_file_contents, Fwrite_region): Use it.
3826 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3828 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3830 * fns.c: Don't overflow int when computing a list length.
3831 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3832 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3833 truncation on 64-bit hosts. Check for QUIT every
3834 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3835 faster and is responsive enough.
3836 (Flength): Report an error instead of overflowing an integer.
3837 (Fsafe_length): Return a float if the value is not representable
3838 as a fixnum. This shouldn't happen except in contrived situations.
3839 (Fnthcdr, Fsort): Don't assume list length fits in int.
3840 (Fcopy_sequence): Don't assume vector length fits in int.
3842 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3843 (header_size, word_size): New constants.
3844 (allocate_vectorlike): Don't check size overflow here.
3845 (allocate_vector): Check it here instead, since this is the only
3846 caller of allocate_vectorlike that could cause overflow.
3847 Check that the new vector's length is representable as a fixnum.
3849 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3850 The previous code was bogus. For example, next_almost_prime (32)
3851 returned 39, which is undesirable as it is a multiple of 3; and
3852 next_almost_prime (24) returned 25, which is a multiple of 5 so
3853 why was the code bothering to check for multiples of 7?
3855 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3857 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3859 Variadic C functions now count arguments with ptrdiff_t.
3860 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3861 Back then I didn't know that the Emacs coding style prefers signed int.
3862 Also, in the meantime I found a few more instances where arguments
3863 were being counted with int, which may truncate counts on 64-bit
3864 machines, or EMACS_INT, which may be unnecessarily wide.
3865 * lisp.h (struct Lisp_Subr.function.aMANY)
3866 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3867 Arg counts are now ptrdiff_t, not size_t.
3868 All variadic functions and their callers changed accordingly.
3869 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3870 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3871 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3872 * callint.c (Fcall_interactively): Check arg count for overflow,
3873 to avoid potential buffer overrun. Use signed char, not 'int',
3874 for 'varies' array, so that we needn't bother to check its size
3875 calculation for overflow.
3876 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3877 * eval.c (apply_lambda):
3878 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3879 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3880 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3882 * callint.c (Fcall_interactively): Don't use index var as event count.
3884 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3885 * mem-limits.h (SIZE): Remove; no longer used.
3887 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3889 Remove unnecessary casts.
3890 * xterm.c (x_term_init):
3891 * xfns.c (x_set_border_pixel):
3892 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3893 These aren't needed now that we assume ANSI C.
3895 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3896 It's more likely to cause problems (due to unsigned overflow)
3899 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3901 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3903 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3905 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3907 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3909 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3911 GLYPH_CODE_FACE returns EMACS_INT, not int.
3912 * dispextern.h (merge_faces):
3913 * xfaces.c (merge_faces):
3914 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3915 Don't assume EMACS_INT fits in int.
3917 * character.h (CHAR_VALID_P): Remove unused parameter.
3918 * fontset.c, lisp.h, xdisp.c: All uses changed.
3920 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3922 * fns.c (concat): Minor tuning based on overflow analysis.
3923 This doesn't fix any bugs. Use int to hold character, instead
3924 of constantly refetching from Emacs object. Use XFASTINT, not
3925 XINT, for value known to be a character. Don't bother comparing
3926 a single byte to 0400, as it's always less.
3928 * floatfns.c (Fexpt):
3929 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3931 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3934 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3936 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3937 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3938 incorrectly succeed when S was a string, because 4294967386 was
3939 truncated before it was used.
3941 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3942 Otherwise, an out-of-range integer could cause undefined behavior
3945 * composite.c: Use int, not EMACS_INT, for characters.
3946 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3947 EMACS_INT, for values that are known to be in character range.
3948 This doesn't fix any bugs but is the usual style inside Emacs and
3949 may generate better code on 32-bit machines.
3951 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3952 This is for reasons similar to the recent CHAR_STRING fix.
3953 * charset.c (Fencode_char): Check that character arg is actually
3954 a character. Pass an int to ENCODE_CHAR.
3955 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3956 wider than 'int', as a compile-time check to prevent future regressions
3959 * character.c (char_string): Remove unnecessary casts.
3961 Make sure a 64-bit char is never passed to CHAR_STRING.
3962 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3963 by silently ignoring the top 32 bits, allowing some values
3964 that were far too large to be valid characters.
3965 * character.h: Include <verify.h>.
3966 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3967 arguments are no wider than unsigned, as a compile-time check
3968 to prevent future regressions in this area.
3970 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3971 (Fsubst_char_in_region):
3973 * xdisp.c (decode_mode_spec_coding):
3974 Adjust to CHAR_STRING's new requirement.
3975 * editfns.c (Finsert_char, Fsubst_char_in_region):
3976 * fns.c (concat): Check that character args are actually
3977 characters. Without this test, these functions did the wrong
3978 thing with wildly out-of-range values on 64-bit hosts.
3980 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3981 These casts should not be needed on 32-bit hosts, either.
3982 * keyboard.c (read_char):
3983 * lread.c (Fload): Remove casts to unsigned.
3985 * lisp.h (UNSIGNED_CMP): New macro.
3986 This fixes comparison bugs on 64-bit hosts.
3987 (ASCII_CHAR_P): Use it.
3988 * casefiddle.c (casify_object):
3989 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3990 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3991 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3992 * dispextern.h (FACE_FROM_ID):
3993 * keyboard.c (read_char): Use UNSIGNED_CMP.
3995 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3996 not to EMACS_INT, to avoid GCC warning.
3998 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4000 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4001 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4002 isn't needed on 32-bit machines.
4004 * buffer.c (Fgenerate_new_buffer_name):
4005 Use EMACS_INT for count, not int.
4006 (advance_to_char_boundary): Return EMACS_INT, not int.
4008 * data.c (Qcompiled_function): Now static.
4010 * window.c (window_body_lines): Now static.
4012 * image.c (gif_load): Rename local to avoid shadowing.
4014 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4015 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4016 * alloc.c (make_save_value): Integer argument is now of type
4018 (mark_object): Use ptrdiff_t, not int.
4019 * lisp.h (pD): New macro.
4020 * print.c (print_object): Use it.
4022 * alloc.c: Use EMACS_INT, not int, to count objects.
4023 (total_conses, total_markers, total_symbols, total_vector_size)
4024 (total_free_conses, total_free_markers, total_free_symbols)
4025 (total_free_floats, total_floats, total_free_intervals)
4026 (total_intervals, total_strings, total_free_strings):
4027 Now EMACS_INT, not int. All uses changed.
4028 (Fgarbage_collect): Compute overall total using a double, so that
4029 integer overflow is less likely to be a problem. Check for overflow
4030 when converting back to an integer.
4031 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4032 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4033 These were 'int' variables that could overflow on 64-bit hosts;
4034 they were never used, so remove them instead of repairing them.
4035 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4036 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4037 Previously, this ceilinged at INT_MAX, but that doesn't work on
4039 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4041 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4042 (allocate_vectorlike): Check for ptrdiff_t overflow.
4043 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4044 when a (possibly-narrower) signed value would do just as well.
4045 We prefer using signed arithmetic, to avoid comparison confusion.
4047 * alloc.c: Catch some string size overflows that we were missing.
4048 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4049 for convenience in STRING_BYTES_MAX.
4050 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4051 The definition here is exact; the one in lisp.h was approximate.
4052 (allocate_string_data): Check for string overflow. This catches
4053 some instances we weren't catching before. Also, it catches
4054 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4055 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4056 and ptrdiff_t and EMACS_INT are both 64 bits.
4058 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4059 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4060 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4062 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4064 * alloc.c (Fmake_string): Check for out-of-range init.
4066 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4068 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4070 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4072 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4073 xg_get_default_scrollbar_width.
4075 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4076 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4077 (style_changed_cb): Call update_theme_scrollbar_width and call
4078 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4079 all frames (Bug#8505).
4080 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4081 Call gtk_window_set_resizable if HAVE_GTK3.
4082 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4083 and height if HAVE_GTK3 (Bug#8505).
4084 (scroll_bar_width_for_theme): New variable.
4085 (update_theme_scrollbar_width): New function.
4086 (xg_get_default_scrollbar_width): Move code to
4087 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4088 (xg_initialize): Call update_theme_scrollbar_width.
4090 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4092 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4094 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4096 * frame.c (make_frame): Call other_buffer_safely instead of
4099 * window.c (temp_output_buffer_show): Call display_buffer with
4100 second argument Vtemp_buffer_show_specifiers and reset latter
4101 immediately after the call.
4102 (Vtemp_buffer_show_specifiers): New variable.
4103 (auto_window_vscroll_p, next_screen_context_lines)
4104 (Vscroll_preserve_screen_position): Remove leading asterisks from
4107 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4109 Fix minor problems found by GCC 4.6.0 static checking.
4110 * buffer.c (Qclone_number): Remove for now, as it's unused.
4111 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4112 (record_buffer): Remove unused local.
4113 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4114 (set_frame_buffer_list): Remove; unused.
4115 * frame.h (other_visible_frames): Remove decl.
4116 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4117 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4118 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4120 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4121 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4122 Define only if HAVE_GPM.
4123 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4124 (update_hints_inhibit): Remove; never set. All uses removed.
4125 * widgetprv.h (emacsFrameClassRec): Remove decl.
4126 * window.c (delete_deletable_window): Now returns void, since it
4127 wasn't returning anything.
4128 (compare_window_configurations): Remove unused locals.
4129 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4130 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4131 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4132 the same widths as pointers. This follows up on the 2011-05-06 patch.
4133 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4134 * xterm.h: Likewise.
4135 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4137 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4139 * makefile.w32-in: Update dependencies.
4140 (LISP_H): Add lib/intprops.h.
4142 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4144 * image.c (gif_load): Add animation frame delay to the metadata.
4145 (syms_of_image): Use DEFSYM. New symbol `delay'.
4147 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4149 * window.c (delete_deletable_window): Re-add.
4150 (Fset_window_configuration): Rewrite to handle dead buffers and
4151 consequently deletable windows.
4152 (window_tree, Fwindow_tree): Remove. Supply functionality in
4154 (compare_window_configurations): Simplify code.
4156 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4158 * image.c (imagemagick_load_image): Fix type mismatch.
4159 (Fimagemagick_types): Likewise.
4161 * window.h (replace_buffer_in_windows): Declare.
4163 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4165 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4166 Qclone_number. Remove external declaration of Qdelete_window.
4167 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4169 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4170 Run Qbuffer_list_update_hook if allowed.
4171 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4172 buffer list implementation.
4173 (other_buffer_safely): New function.
4174 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4175 calls to replace_buffer_in_windows and
4176 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4178 (record_buffer): Inhibit quitting and rewrite using quittable
4179 functions. Run Qbuffer_list_update_hook if allowed.
4180 (Frecord_buffer, Funrecord_buffer): New functions.
4181 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4182 Move switch-to-buffer to window.el.
4183 (bury-buffer): Move to window.el.
4184 (Vbuffer_list_update_hook): New variable.
4186 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4189 * window.h (resize_frame_windows): Move up in code.
4190 (Fwindow_frame): Remove EXFUN.
4191 (replace_buffer_in_all_windows): Remove prototype.
4192 (replace_buffer_in_windows_safely): Add prototype.
4194 * window.c: Declare Qdelete_window static again. Move down
4195 declaration of select_count.
4196 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4197 (Fother_window): Move to window.el.
4198 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4199 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4200 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4202 (replace_buffer_in_windows): Implement by calling
4203 Qreplace_buffer_in_windows.
4204 (replace_buffer_in_all_windows): Remove with some functionality
4205 moved into replace_buffer_in_windows_safely.
4206 (replace_buffer_in_windows_safely): New function.
4207 (select_window_norecord, select_frame_norecord): Move in front
4208 of run_window_configuration_change_hook. Remove now obsolete
4210 (Fset_window_buffer): Rewrite doc-string.
4211 Call Qrecord_window_buffer.
4212 (keys_of_window): Move binding for other-window to window.el.
4214 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4216 * dispextern.h (struct image): Replace data member, whose int_val
4217 and ptr_val fields were not used by anything, with a single
4220 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4221 (gif_clear_image, gif_load, imagemagick_load_image)
4222 (gs_clear_image, gs_load): Callers changed.
4224 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4226 * buffer.h: Include <time.h>, for time_t.
4227 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4229 Fix minor problems found by static checking.
4231 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4233 Make identifiers static if they are not used in other modules.
4234 * data.c (Qcompiled_function, Qframe, Qvector):
4235 * image.c (QimageMagick, Qsvg):
4236 * minibuf.c (Qmetadata):
4237 * window.c (resize_window_check, resize_root_window): Now static.
4238 * window.h (resize_window_check, resize_root_window): Remove decls.
4240 * window.c (window_deletion_count, delete_deletable_window):
4242 (window_body_lines): Now static.
4243 (Fdelete_other_windows_internal): Mark vars as initialized.
4244 Make sure 'resize_failed' is initialized.
4245 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4246 (resize_window_apply): Remove unused local.
4247 * window.h (delete_deletable_window): Remove decl.
4249 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4250 (imagemagick_load_image): Fix pointer signedness problem by changing
4251 last arg from unsigned char * to char *. All uses changed.
4252 Also, fix a local for similar reasons.
4253 Remove unused locals. Remove locals to avoid shadowing.
4254 (fn_rsvg_handle_free): Remove; unused.
4255 (svg_load, svg_load_image): Fix pointer signedness problem.
4256 (imagemagick_load_image): Don't use garbage pointer image_wand.
4258 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4260 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4262 * image.c (gif_load): Fix omitted cast error introduced by
4265 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4267 * window.h (resize_proportionally, orig_total_lines)
4268 (orig_top_line): Remove from window structure.
4269 (set_window_height, set_window_width, change_window_heights)
4270 (Fdelete_window): Remove prototypes.
4271 (resize_frame_windows): Remove duplicate declaration.
4273 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4275 * window.h (resize_frame_windows, resize_window_check)
4276 (delete_deletable_window, resize_root_window)
4277 (resize_frame_windows): Declare prototypes.
4279 * window.c (resize_window_apply): Make definition be "static" to
4280 match the prototype.
4282 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4284 * window.c: Remove declarations of Qwindow_size_fixed,
4285 window_min_size_1, window_min_size_2, window_min_size,
4286 size_window, window_fixed_size_p, enlarge_window, delete_window.
4287 Remove static from declaration of Qdelete_window, it's
4288 temporarily needed by Fbury_buffer.
4289 (replace_window): Don't assign orig_top_line and
4291 (Fdelete_window, delete_window): Remove. Window deletion is
4292 handled by window.el.
4293 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4294 Replace Fdelete_window calls with calls to Qdelete_window.
4295 (Fdelete_other_windows): Remove. Deleting other windows is
4296 handled by window.el.
4297 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4298 handled in window.el.
4299 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4300 Window minimum sizes are handled in window.el.
4301 (shrink_windows, size_window, set_window_height)
4302 (set_window_width, change_window_heights, window_height)
4303 (window_width, CURBEG, CURSIZE, enlarge_window)
4304 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4305 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4306 handled in window.el.
4307 (make_dummy_parent): Rename to make_parent_window and give it a
4308 second argument horflag.
4309 (make_window): Don't set resize_proportionally any more.
4310 (Fsplit_window): Remove. Windows are split in window.el.
4311 (save_restore_action, save_restore_orig_size)
4312 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4313 Resize mini windows in window.el.
4314 (grow_mini_window, shrink_mini_window): Implement by calling
4315 Qresize_root_window_vertically, resize_window_check and
4316 resize_window_apply.
4317 (saved_window, Fset_window_configuration, save_window_save):
4318 Do not handle orig_top_line, orig_total_lines, and
4319 resize_proportionally.
4320 (window_min_height, window_min_width): Move to window.el.
4321 (keys_of_window): Move bindings for delete-other-windows,
4322 split-window, delete-window and enlarge-window to window.el.
4324 * buffer.c: Temporarily extern Qdelete_window.
4325 (Fbury_buffer): Temporarily call Qdelete_window instead of
4326 Fdelete_window (Fbury_buffer will move to window.el soon).
4328 * frame.c (set_menu_bar_lines_1): Remove code handling
4329 orig_top_line and orig_total_lines.
4331 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4332 set_window_height but set heights directly.
4333 (change_frame_size_1): Use resize_frame_windows.
4335 * xdisp.c (init_xdisp): Don't use set_window_height but set
4338 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4339 Use resize_frame_windows instead of change_window_heights and run
4340 run_window_configuration_change_hook.
4342 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4343 instead of change_window_heights and run
4344 run_window_configuration_change_hook.
4346 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4348 * window.c (replace_window): Rename second argument REPLACEMENT to
4349 NEW. New third argument SETFLAG. Rewrite.
4350 (delete_window, make_dummy_parent): Call replace_window with
4352 (window_list_1): Move down in code.
4353 (run_window_configuration_change_hook): Move set_buffer part
4354 before select_frame_norecord part in order to unwind correctly.
4355 Rename count1 to count.
4356 (recombine_windows, delete_deletable_window, resize_root_window)
4357 (Fdelete_other_windows_internal)
4358 (Frun_window_configuration_change_hook, make_parent_window)
4359 (resize_window_check, resize_window_apply, Fresize_window_apply)
4360 (resize_frame_windows, Fsplit_window_internal)
4361 (Fdelete_window_internal, Fresize_mini_window_internal):
4363 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4365 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4367 * window.h (window): Add some new members to window structure -
4368 normal_lines, normal_cols, new_total, new_normal, clone_number,
4369 splits, nest, prev_buffers, next_buffers.
4370 (WINDOW_TOTAL_SIZE): Move here from window.c.
4371 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4373 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4375 (make_dummy_parent): Set new members of windows structure.
4376 (make_window): Move down in code. Handle new members of window
4378 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4379 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4380 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4381 (Fset_window_prev_buffers, Fwindow_next_buffers)
4382 (Fset_window_next_buffers, Fset_window_clone_number):
4384 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4385 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4387 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4388 Argument WINDOW can be now internal window too.
4389 (Fwindow_use_time): Move up in code.
4390 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4392 (Fset_window_configuration, saved_window)
4393 (Fcurrent_window_configuration, save_window_save): Handle new
4394 members of window structure.
4395 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4396 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4397 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4398 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4399 Qget_mru_window, Qresize_root_window,
4400 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4401 Qauto_buffer_name; staticpro them.
4403 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4405 * window.c (Fwindow_total_size, Fwindow_left_column)
4406 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4407 (Fwindow_list_1): New functions.
4408 (window_box_text_cols): Replace with window_body_cols.
4409 (Fwindow_width, Fscroll_left, Fscroll_right):
4410 Use window_body_cols instead of window_box_text_cols.
4411 (delete_window, Fset_window_configuration):
4412 Call delete_all_subwindows with window as argument.
4413 (delete_all_subwindows): Take a window as argument and not a
4415 (window_loop): Remove handling of GET_LRU_WINDOW and
4417 (Fget_lru_window, Fget_largest_window): Move to window.el.
4419 * window.h: Extern window_body_cols instead of
4420 window_box_text_cols. delete_all_subwindows now takes a
4421 Lisp_Object as argument.
4423 * indent.c (compute_motion, Fcompute_motion):
4424 Use window_body_cols instead of window_box_text_cols.
4426 * frame.c (delete_frame): Call delete_all_subwindows with root
4429 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4431 * fns.c (Fputhash): Document return value.
4433 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4435 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4437 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4439 Cons<->int and similar integer overflow fixes (Bug#8794).
4441 Check for overflow when converting integer to cons and back.
4442 * charset.c (Fdefine_charset_internal, Fdecode_char):
4443 Use cons_to_unsigned to catch overflow.
4444 (Fencode_char): Use INTEGER_TO_CONS.
4445 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4446 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4447 * data.c (long_to_cons, cons_to_long): Remove.
4448 (cons_to_unsigned, cons_to_signed): New functions.
4449 These signal an error for invalid or out-of-range values.
4450 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4451 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4452 * font.c (Ffont_variation_glyphs):
4453 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4454 * lisp.h: Include <intprops.h>.
4455 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4456 (cons_to_signed, cons_to_unsigned): New decls.
4457 (long_to_cons, cons_to_long): Remove decls.
4458 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4459 (Fprimitive_undo): Use CONS_TO_INTEGER.
4460 * xfns.c (Fx_window_property): Likewise.
4461 * xselect.c: Include <limits.h>.
4462 (x_own_selection, selection_data_to_lisp_data):
4463 Use INTEGER_TO_CONS.
4464 (x_handle_selection_request, x_handle_selection_clear)
4465 (x_get_foreign_selection, Fx_disown_selection_internal)
4466 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4467 (lisp_data_to_selection_data): Use cons_to_unsigned.
4468 (x_fill_property_data): Use cons_to_signed.
4469 Report values out of range.
4471 Check for buffer and string overflow more precisely.
4472 * buffer.h (BUF_BYTES_MAX): New macro.
4473 * lisp.h (STRING_BYTES_MAX): New macro.
4474 * alloc.c (Fmake_string):
4475 * character.c (string_escape_byte8):
4476 * coding.c (coding_alloc_by_realloc):
4477 * doprnt.c (doprnt):
4478 * editfns.c (Fformat):
4480 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4481 since they may not be the same number.
4482 * editfns.c (Finsert_char):
4483 * fileio.c (Finsert_file_contents):
4484 Likewise for BUF_BYTES_MAX.
4486 * image.c: Use ptrdiff_t, not int, for sizes.
4487 (slurp_file): Switch from int to ptrdiff_t.
4489 (slurp_file): Check that file size fits in both size_t (for
4490 malloc) and ptrdiff_t (for sanity and safety).
4492 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4493 if b->modtime has its maximal value.
4495 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4497 Don't assume time_t can fit into int.
4498 * buffer.h (struct buffer.modtime): Now time_t, not int.
4499 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4500 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4502 Minor fixes for signed vs unsigned integers.
4503 * character.h (MAYBE_UNIFY_CHAR):
4504 * charset.c (maybe_unify_char):
4505 * keyboard.c (read_char, reorder_modifiers):
4506 XINT -> XFASTINT, since the integer must be nonnegative.
4507 * ftfont.c (ftfont_spec_pattern):
4508 * keymap.c (access_keymap, silly_event_symbol_error):
4509 XUINT -> XFASTINT, since the integer must be nonnegative.
4510 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4511 since it makes no difference and we prefer signed.
4512 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4513 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4516 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4518 * window.h (Fwindow_frame): Declare.
4520 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4522 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4523 (SPARE_MEMORY): Always define.
4524 (LARGE_REQUEST): Remove.
4525 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4527 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4529 * lisp.h: Move EXFUNS for Fframe_root_window,
4530 Fframe_first_window and Fset_frame_selected_window to window.h.
4532 * window.h: Move EXFUNS for Fframe_root_window,
4533 Fframe_first_window and Fset_frame_selected_window here from
4536 * frame.c (Fwindow_frame, Fframe_first_window)
4537 (Fframe_root_window, Fframe_selected_window)
4538 (Fset_frame_selected_window): Move to window.c.
4539 (Factive_minibuffer_window): Move to minibuf.c.
4540 (Fother_visible_frames_p): New function.
4542 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4544 * window.c (decode_window, decode_any_window): Move up in code.
4545 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4546 (inhibit_frame_unsplittable): Remove unused variable.
4547 (Fwindow_buffer): Move up and rewrite doc-string.
4548 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4549 (Fwindow_prev): New functions.
4550 (Fwindow_frame): Move here from frame.c. Accept any window as
4552 (Fframe_root_window, Fframe_first_window)
4553 (Fframe_selected_window): Move here from frame.c. Accept frame
4554 or arbitrary window as argument. Update doc-strings.
4555 (Fminibuffer_window): Move up in code.
4556 (Fwindow_minibuffer_p): Move up in code and simplify.
4557 (Fset_frame_selected_window): Move here from frame.c.
4559 (Fselected_window, select_window, Fselect_window): Move up in
4560 code. Minor doc-string fixes.
4562 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4564 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4565 Do not assume that spare memory exists; that assumption is valid
4566 only if SYSTEM_MALLOC.
4567 (LARGE_REQUEST): New macro, so that the issue of large requests
4568 is separated from the issue of spare memory.
4570 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4572 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4575 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4577 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4580 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4582 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4584 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4586 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4587 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4589 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4591 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4593 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4595 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4596 (x_clipboard_manager_save): Add return value.
4597 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4599 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4600 Obey Vx_select_enable_clipboard_manager. Catch errors in
4601 x_clipboard_manager_save (Bug#8779).
4602 (Vx_select_enable_clipboard_manager): New variable.
4603 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4605 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4607 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4609 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4611 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4612 in the current matrix if keep_current_p is non-zero.
4614 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4616 * bidi.c (bidi_level_of_next_char): Fix last change.
4618 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4620 Support bidi reordering of text covered by display properties.
4622 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4623 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4624 (bidi_cache_search, bidi_cache_iterator_state)
4625 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4626 (bidi_level_of_next_char, bidi_move_to_visually_next):
4627 Support character positions inside a run of characters covered by a
4629 (bidi_paragraph_init, bidi_resolve_explicit_1)
4630 (bidi_level_of_next_char): Call bidi_fetch_char and
4631 bidi_fetch_char_advance instead of FETCH_CHAR and
4633 (bidi_init_it): Initialize new members.
4634 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4636 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4637 instead of using explicit *_CHAR codes.
4638 (bidi_resolve_explicit, bidi_resolve_weak):
4639 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4640 bidirectional text is supported only in multibyte buffers.
4641 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4642 it to initialize the frame_window_p member of struct bidi_it.
4643 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4644 (bidi_resolve_explicit, bidi_resolve_weak)
4645 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4646 bidi_it->nchars is non-positive.
4647 (bidi_level_of_next_char): Don't try to lookup the cache for the
4648 next/previous character if nothing is cached there yet, or if we
4649 were just reseat()'ed to a new position.
4651 * xdisp.c (set_cursor_from_row): Set start and stop points
4652 according to the row's direction when priming the loop that looks
4653 for the glyph on which to display cursor.
4654 (single_display_spec_intangible_p): Function deleted.
4655 (display_prop_intangible_p): Reimplement to call
4656 handle_display_spec instead of single_display_spec_intangible_p.
4657 Accept 3 additional arguments needed by handle_display_spec.
4658 This fixes incorrect cursor motion across display property with complex
4659 values: lists, `(when COND...)' forms, etc.
4660 (single_display_spec_string_p): Support property values that are
4661 lists with the argument STRING its top-level element.
4662 (display_prop_string_p): Fix the condition for processing a
4663 property that is a list to be consistent with handle_display_spec.
4664 (handle_display_spec): New function, refactored from the
4665 last portion of handle_display_prop.
4666 (compute_display_string_pos): Accept additional argument
4667 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4668 value of a `display' property is a "replacing spec".
4669 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4670 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4671 the display property, but just return a value indicating whether
4672 the display property will replace the characters it covers.
4673 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4674 frame_window_p members of struct bidi_it.
4675 (compute_display_string_pos, compute_display_string_end):
4677 (push_it): Accept second argument POSITION, where pop_it should
4678 jump to continue iteration.
4679 (reseat_1): Initialize bidi_it.disp_pos.
4681 * keyboard.c (adjust_point_for_property): Adjust the call to
4682 display_prop_intangible_p to its new signature.
4684 * dispextern.h (struct bidi_it): New member frame_window_p.
4685 (bidi_init_it): Update prototypes.
4686 (display_prop_intangible_p): Update prototype.
4687 (compute_display_string_pos, compute_display_string_end):
4689 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4692 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4694 Malloc failure behavior now depends on size of allocation.
4695 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4696 * lisp.h: Change signatures accordingly.
4697 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4698 All callers changed. (Bug#8762)
4700 * gnutls.c: Use Emacs's memory allocators.
4701 Without this change, the gnutls library would invoke malloc etc.
4702 directly, which causes problems on non-SYNC_INPUT hosts, and which
4703 runs afoul of improving memory_full behavior. (Bug#8761)
4704 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4705 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4706 xfree instead of the default malloc, realloc, free.
4707 (Fgnutls_boot): No need to check for memory allocation failure,
4708 since xmalloc does that for us.
4710 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4711 * category.c (hash_get_category_set):
4712 * ccl.c (ccl_driver):
4713 * charset.c (Fdefine_charset_internal):
4714 * charset.h (struct charset.hash_index):
4715 * composite.c (get_composition_id, gstring_lookup_cache)
4716 (composition_gstring_put_cache):
4717 * composite.h (struct composition.hash_index):
4718 * dispextern.h (struct image.hash):
4719 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4720 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4721 (hashfn_equal, hashfn_user_defined, make_hash_table)
4722 (maybe_resize_hash_table, hash_lookup, hash_put)
4723 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4724 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4725 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4726 * image.c (make_image, search_image_cache, lookup_image)
4727 (xpm_put_color_table_h):
4728 * lisp.h (struct Lisp_Hash_Table):
4729 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4730 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4731 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4732 * alloc.c (allocate_vectorlike):
4733 Check for overflow in vector size calculations.
4734 * ccl.c (ccl_driver):
4735 Check for overflow when converting EMACS_INT to int.
4736 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4737 need to be updated by these changes.
4738 * fns.c (make_hash_table, maybe_resize_hash_table):
4739 Check for integer overflow with large hash tables.
4740 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4741 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4742 (SXHASH_REDUCE): New macro.
4743 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4744 Use it instead of discarding useful hash info with large hash values.
4745 (sxhash_float): New function.
4746 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4747 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4748 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4749 Rewrite to use FIXNUM_BITS, as this simplifies things.
4750 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4751 Adjust signatures to match updated version of code.
4752 (consing_since_gc): Now EMACS_INT, since a single hash table can
4753 use more than INT_MAX bytes.
4755 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4757 Make it possible to build with GCC-4.6+ -O2 -flto.
4759 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4761 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4763 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4764 Call minibuffer-inactive-mode.
4766 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4768 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4769 Update dependencies.
4771 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4773 * data.c (init_data): Remove code for UTS, this system is not
4776 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4778 Don't force ./temacs to start in terminal mode.
4780 * frame.c (make_initial_frame): Initialize faces in all cases, not
4781 only when CANNOT_DUMP is defined.
4782 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4784 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4786 * dispnew.c (add_window_display_history): Use const for the string
4787 pointer. Remove declaration, not needed.
4789 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4791 Use 'inline', not 'INLINE'.
4792 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4793 * alloc.c, fontset.c (INLINE): Remove.
4794 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4795 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4796 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4797 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4798 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4800 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4802 Make it possible to run ./temacs.
4804 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4805 syms_of_callproc does the same thing. Remove test for
4806 "initialized", do it in the caller.
4807 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4809 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4811 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4812 (read_minibuf): Use get_minibuffer.
4813 (syms_of_minibuf): Use DEFSYM.
4814 (Qmetadata): New var.
4815 * data.c (Qbuffer): Don't make it static.
4816 (syms_of_data): Use DEFSYM.
4818 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4820 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4821 (CCL_CODE_MIN): New macro.
4823 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4825 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4827 * eval.c (Qdebug): Now static.
4828 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4829 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4830 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4832 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4834 * image.c: Various fixes to ImageMagick code comments.
4835 (Fimagemagick_types): Doc fix.
4837 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4839 Minor fixes prompted by GCC 4.6.0 warnings.
4841 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4843 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4844 (x_clipboard_manager_save_all): Move extern decl to ...
4845 * xterm.h: ... here, so that it can be checked for consistency.
4847 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4849 * xselect.c (x_clipboard_manager_save_frame)
4850 (x_clipboard_manager_save_all): New functions.
4851 (Fx_clipboard_manager_save): Lisp function deleted.
4853 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4854 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4856 * xterm.h: Update prototype.
4858 2011-05-28 William Xu <william.xwl@gmail.com>
4860 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4863 2011-05-28 Jim Meyering <meyering@redhat.com>
4865 Avoid a sign-extension bug in crypto_hash_function.
4866 * fns.c (to_uchar): Define.
4867 (crypto_hash_function): Use it to convert some newly-signed
4868 variables to unsigned, to avoid sign-extension bugs. For example,
4869 without this change, (md5 "truc") would evaluate to
4870 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4871 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4872 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4874 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4876 Integer overflow fixes.
4878 * dbusbind.c: Serial number integer overflow fixes.
4879 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4880 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4881 to hold a serial number that is too large for a fixnum.
4882 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4883 Check for serial numbers out of range. Decode any serial number
4884 that was so large that it became a float. (Bug#8722)
4886 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4887 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4888 Use XFASTINT rather than XUINT when numbers are nonnegative.
4889 (xd_append_arg, Fdbus_method_return_internal):
4890 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4891 arguments, check that Lisp number is nonnegative, rather than
4892 silently wrapping negative numbers around. (Bug#8722)
4893 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4896 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4898 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4900 ccl: add integer overflow checks
4901 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4902 (IN_INT_RANGE): New macros.
4903 (ccl_driver): Use them to check for integer overflow when
4904 decoding a CCL program. Many of the new checks are whether XINT (x)
4905 fits in int; it doesn't always, on 64-bit hosts. The new version
4906 doesn't catch all possible integer overflows, but it's an
4907 improvement. (Bug#8719)
4909 * alloc.c (make_event_array): Use XINT, not XUINT.
4910 There's no need for unsigned here.
4912 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4913 This follows up to the 2011-05-06 change that substituted uintptr_t
4914 for EMACS_INT. This case wasn't caught back then.
4916 Rework Fformat to avoid integer overflow issues.
4917 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4918 now (part of C89). Include <verify.h>.
4919 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4920 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4921 (Fformat): Avoid the prepass trying to compute sizes; it was only
4922 approximate and thus did not catch overflow reliably. Instead, walk
4923 through the format just once, formatting and computing sizes as we go,
4924 checking for integer overflow at every step, and allocating a larger
4925 buffer as needed. Keep track separately whether the format is
4926 multibyte. Keep only the most-recently calculated precision, rather
4927 than them all. Record whether each argument has been converted to
4928 string. Use EMACS_INT, not int, for byte and char and arg counts.
4929 Support field widths and precisions larger than INT_MAX. Avoid
4930 sprintf's undefined behavior with conversion specifications such as %#d
4931 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4932 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4933 formatting out-of-range floating point numbers with int
4936 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4938 * data.c: Avoid integer truncation in expressions involving floats.
4939 * data.c: Include <intprops.h>.
4940 (arith_driver): When there's an integer overflow in an expression
4941 involving floating point, convert the integers to floating point
4942 so that the resulting value does not suffer from catastrophic
4943 integer truncation. For example, on a 64-bit host (* 4
4944 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4945 Do not rely on undefined behavior after integer overflow.
4947 merge count_size_as_multibyte, parse_str_to_multibyte
4948 * character.c, character.h (count_size_as_multibyte):
4949 Rename from parse_str_to_multibyte; all uses changed.
4950 Check for integer overflow.
4951 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4952 since it's now a duplicate of the other. This is more of
4953 a character than a buffer op, so better that it's in character.c.
4954 * fns.c, print.c: Adjust to above changes.
4956 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4958 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4960 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4962 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4963 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4964 (x_clipboard_manager_save): Now static.
4965 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4967 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4968 (crypto_hash_function): Now static.
4969 Fix pointer signedness problems. Avoid unnecessary initializations.
4971 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4973 * termhooks.h (Vselection_alist): Make it terminal-local.
4975 * terminal.c (create_terminal): Initialize it.
4977 * xselect.c: Support for clipboard managers.
4978 (Vselection_alist): Move to termhooks.h as terminal-local var.
4979 (LOCAL_SELECTION): New macro.
4980 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4981 (symbol_to_x_atom): Remove gratuitous arg.
4982 (x_handle_selection_request, lisp_data_to_selection_data)
4983 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4984 (x_own_selection, x_get_local_selection, x_convert_selection):
4985 New arg, specifying work frame. Use terminal-local Vselection_alist.
4986 (some_frame_on_display): Delete unused function.
4987 (Fx_own_selection_internal, Fx_get_selection_internal)
4988 (Fx_disown_selection_internal, Fx_selection_owner_p)
4989 (Fx_selection_exists_p): New optional frame arg.
4990 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4991 (x_handle_selection_clear): Don't treat other terminals with the
4992 same keyboard specially. Use the terminal-local Vselection_alist.
4993 (x_clear_frame_selections): Use Frun_hook_with_args.
4995 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4997 * xterm.h: Add support for those atoms.
4999 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5001 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5002 (converted_selections, conversion_fail_tag): New global variables.
5003 (x_selection_request_lisp_error): Free the above.
5004 (x_get_local_selection): Remove unnecessary code.
5005 (x_reply_selection_request): Args changed; handle arbitrary array
5006 of converted selections stored in converted_selections.
5007 Separate the XChangeProperty and SelectionNotify steps.
5008 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5009 (x_convert_selection): New function.
5010 (x_handle_selection_event): Simplify.
5011 (x_get_foreign_selection): Don't ignore incoming requests while
5012 waiting for an answer; this will fail when we implement
5013 SAVE_TARGETS, and seems unnecessary anyway.
5014 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5015 (Vx_sent_selection_functions): Doc fix.
5017 2011-05-26 Leo Liu <sdl.web@gmail.com>
5019 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5021 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5023 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5025 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5026 for fringe update if it has periodic bitmap.
5027 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5028 and fringe_bitmap_periodic_p.
5030 * fringe.c (get_fringe_bitmap_data): New function.
5031 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5032 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5033 row. Mark glyph row for fringe update if periodicity changed.
5035 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5036 for fringe update unless it has periodic bitmap.
5038 2011-05-25 Kenichi Handa <handa@m17n.org>
5040 * xdisp.c (get_next_display_element): Set correct it->face_id for
5041 a static composition.
5043 2011-05-24 Leo Liu <sdl.web@gmail.com>
5046 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5048 * fns.c (crypto_hash_function, Fsha1): New function.
5049 (Fmd5): Use crypto_hash_function.
5050 (syms_of_fns): Add Ssha1.
5052 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5054 * gnutls.c: Remove unused macros.
5055 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5056 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5057 Remove macros that are defined and never used.
5058 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5060 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5062 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5063 (Fx_get_selection_internal): Minor cleanup.
5064 (Fx_own_selection_internal): Rename arguments for consistency with
5067 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5069 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5071 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5073 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5075 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5077 * dispnew.c (scrolling_window): Don't exclude the case that the
5078 last enabled row in the desired matrix touches the bottom boundary.
5080 2011-05-21 Glenn Morris <rgm@gnu.org>
5082 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5083 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5084 and add some more files.
5086 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5088 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5089 report_file_error introduced by the change from 2011-05-07.
5091 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5093 * systime.h (Time): Define only if emacs is defined.
5094 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5095 where the include path doesn't have X11/X.h by default. See
5096 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5098 2011-05-20 Kenichi Handa <handa@m17n.org>
5100 * composite.c (find_automatic_composition): Fix previous change.
5102 2011-05-20 Glenn Morris <rgm@gnu.org>
5104 * lisp.mk: New file, split from Makefile.in.
5105 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5106 (shortlisp): Remove.
5107 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5109 2011-05-19 Glenn Morris <rgm@gnu.org>
5111 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5112 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5113 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5114 (lisp): Set the order to that of loadup.el.
5115 (shortlisp): Make it a copy of $lisp.
5116 (SOME_MACHINE_LISP): Remove.
5117 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5118 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5120 2011-05-18 Kenichi Handa <handa@m17n.org>
5122 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5123 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5124 (find_automatic_composition): Mostly rewrite for efficiency.
5126 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5128 * makefile.w32-in: Update dependencies.
5130 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5132 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5133 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5135 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5137 Fix some integer overflow issues, such as string length overflow.
5139 * insdel.c (count_size_as_multibyte): Check for string overflow.
5141 * character.c (lisp_string_width): Check for string overflow.
5142 Use EMACS_INT, not int, for string indexes and lengths; in
5143 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5144 the resulting string length overflows an EMACS_INT; instead,
5145 report a string overflow if no precision given. When checking for
5146 precision exhaustion, use a check that cannot possibly have
5147 integer overflow. (Bug#8675)
5148 * character.h (lisp_string_width): Adjust to new signature.
5150 * alloc.c (string_overflow): New function.
5151 (Fmake_string): Use it. This doesn't change behavior, but saves
5152 a few bytes and will simplify future changes.
5153 * character.c (string_escape_byte8): Likewise.
5154 * lisp.h (string_overflow): New decl.
5156 Fixups, following up to the user-interface timestamp change.
5157 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5158 for UI timestamps, instead of unsigned long.
5159 * msdos.c (mouse_get_pos): Likewise.
5160 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5161 * w32gui.h (Time): Define by including "systime.h" rather than by
5162 declaring it ourselves. (Bug#8664)
5164 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5165 * image.c (clear_image_cache): Likewise.
5167 * term.c (term_mouse_position): Don't assume time_t wraparound.
5169 Be more systematic about user-interface timestamps.
5170 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5171 and sometimes 'EMACS_UINT', to represent these timestamps.
5172 This change causes it to use 'Time' uniformly, as that's what X uses.
5173 This makes the code easier to follow, and makes it easier to catch
5174 integer overflow bugs such as Bug#8664.
5175 * frame.c (Fmouse_position, Fmouse_pixel_position):
5176 Use Time, not unsigned long, for user-interface timestamps.
5177 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5178 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5179 * keyboard.h (last_event_timestamp): Likewise.
5180 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5181 * menu.h (xmenu_show): Likewise.
5182 * term.c (term_mouse_position): Likewise.
5183 * termhooks.h (struct input_event.timestamp): Likewise.
5184 (struct terminal.mouse_position_hook): Likewise.
5185 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5186 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5187 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5188 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5190 * menu.h, termhooks.h: Include "systime.h", for Time.
5192 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5193 Don't assume that the difference between two unsigned long values
5194 can fit into an integer. At this point, we know button_down_time
5195 <= event->timestamp, so the difference must be nonnegative, so
5196 there's no need to cast the result if double-click-time is
5197 nonnegative, as it should be; check that it's nonnegative, just in
5198 case. This bug is triggered when events are more than 2**31 ms
5199 apart (about 25 days). (Bug#8664)
5201 * xselect.c (last_event_timestamp): Remove duplicate decl.
5202 (x_own_selection): Remove needless cast to unsigned long.
5204 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5205 that always fit in int. Use a sentinel instead of a counter, to
5206 avoid a temp and to allay GCC's concerns about possible int overflow.
5207 * frame.h (struct frame): Use int for menu_bar_items_used
5208 instead of EMACS_INT, since it always fits in int.
5210 * menu.c (grow_menu_items): Check for int overflow.
5212 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5214 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5215 Before, the code was not consistent. These values cannot exceed
5216 2**31 - 1 so there's no need to make them unsigned.
5217 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5218 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5219 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5221 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5223 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5224 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5225 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5226 presumably because the widths might not match.
5228 * window.c (size_window): Avoid needless test at loop start.
5230 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5232 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5234 2011-05-12 Drew Adams <drew.adams@oracle.com>
5236 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5238 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5240 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5241 `width' to `bar_area_x' and `bar_area_width', respectively.
5242 (x_scroll_run): Take account of fringe background extension.
5244 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5245 Rename local vars `left' and `width' to `bar_area_x' and
5246 `bar_area_width', respectively.
5247 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5248 background extension.
5250 2011-05-10 Jim Meyering <meyering@redhat.com>
5252 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5254 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5256 * image.c (Finit_image_library): Return t for built-in image types,
5257 like pbm and xbm. (Bug#8640)
5259 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5261 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5263 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5265 * w32console.c (Fset_screen_color): Doc fix.
5266 (Fget_screen_color): New function.
5267 (syms_of_ntterm): Defsubr it.
5269 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5270 unlink the temporary file if Fcall_process didn't create it in the
5272 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5273 child process will be redirected to a file specified with `:file'.
5274 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5275 cue to call_process_cleanup not to close that handle.
5277 2011-05-07 Ben Key <bkey76@gmail.com>
5279 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5280 one of two shell specific rules, either bootstrap-temacs-CMD or
5281 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5282 to the previous implementation of the bootstrap-temacs rule.
5283 The bootstrap-temacs-CMD rule is similar to the previous
5284 implementation of the bootstrap-temacs rule except that it
5285 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5288 These changes, along with some changes to nt/configure.bat,
5289 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5290 earlier fix to add support for --cflags and --ldflags options
5291 that include quotes so that it works whether make uses cmd or
5294 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5296 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5297 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5299 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5300 a string. Handle both cases.
5301 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5302 (Fdbus_register_method): Use Qinvalid_function.
5304 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5306 * makefile.w32-in: Update dependencies.
5307 (LISP_H): Add inttypes.h and stdin.h.
5308 (PROCESS_H): Add unistd.h.
5310 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5312 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5313 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5315 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5317 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5319 * term.c (vfatal): Remove stray call to va_end.
5320 It's not needed and the C Standard doesn't allow it here anyway.
5322 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5323 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5325 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5328 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5330 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5332 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5334 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5336 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5338 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5339 * charset.c (Fdefine_charset_internal): Don't initialize
5340 charset.code_space[15]. The value was garbage, on hosts with
5341 32-bit int (Bug#8600).
5343 * lread.c (read_integer): Be more consistent with string-to-number.
5344 Use string_to_number to do the actual conversion; this avoids
5345 rounding errors and fixes some other screwups. Without this fix,
5346 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5347 (digit_to_number): Move earlier, for benefit of read_integer.
5348 Return -1 if the digit is out of range for the base, -2 if it is
5349 not a digit in any supported base. (Bug#8602)
5351 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5353 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5354 to match comment at start of function. This also removes a
5355 GCC warning about overflow in a 32+64-bit port.
5357 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5359 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5360 Reported by Stefan Monnier in
5361 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5362 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5363 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5365 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5366 (EMACS_UINTPTR): Likewise, with uintptr_t.
5368 * lisp.h: Prefer 64-bit EMACS_INT if available.
5369 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5370 on 32-bit hosts that have 64-bit int, so that they can access
5372 However, temporarily disable this change unless the temporary
5373 symbol WIDE_EMACS_INT is defined.
5375 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5377 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5378 This removes an assumption that EMACS_INT and long are the same
5379 width as pointers. The assumption is true for Emacs porting targets
5380 now, but we want to make other targets possible.
5381 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5382 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5383 In the rest of the code, change types of integers that hold casted
5384 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5385 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5386 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5387 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5388 No need to cast type when ORing.
5389 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5390 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5391 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5392 assume EMACS_INT is the same width as char *.
5393 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5394 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5395 Remove no-longer-needed casts.
5396 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5397 (xg_tool_bar_help_callback, xg_make_tool_item):
5398 Use EMACS_INTPTR to hold an integer
5399 that will be cast to void *; this can avoid a GCC warning
5400 if EMACS_INT is not the same width as void *.
5401 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5402 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5403 (current_message_1, set_message_1):
5404 Use a local to convert to proper width without a cast.
5405 * xmenu.c (dialog_selection_callback): Likewise.
5407 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5408 Also, don't assume VALBITS / RAND_BITS is less than 5,
5409 and don't rely on undefined behavior when shifting a 1 left into
5411 * lisp.h (get_random): Change signature to match.
5413 * lread.c (hash_string): Use size_t, not int, for hash computation.
5414 Normally we prefer signed values; but hashing is special, because
5415 it's better to use unsigned division on hash table sizes so that
5416 the remainder is nonnegative. Also, size_t is the natural width
5417 for hashing into memory. The previous code used 'int', which doesn't
5418 retain enough info to hash well into very large tables.
5419 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5421 * dbusbind.c: Don't possibly lose pointer info when converting.
5422 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5423 Use XPNTR rather than XHASH, so that the high-order bits of
5424 the pointer aren't lost when converting through void *.
5426 * eval.c (Fautoload): Don't double-shift a pointer.
5428 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5430 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5432 * gnutls.c (DEF_GNUTLS_FN):
5433 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5435 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5437 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5440 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5442 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5443 New version that can reserve upto 2GB of heap space.
5445 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5447 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5449 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5451 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5452 `gnutls_certificate_set_x509_key_file'.
5454 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5456 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5457 Update dependencies.
5459 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5461 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5462 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5463 Remove unused parameter `fildes'.
5464 * process.c (read_process_output, send_process): Don't pass it.
5466 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5468 Fix previous change: the library cache is defined in w32.c.
5469 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5470 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5472 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5474 Implement dynamic loading of GnuTLS on Windows.
5476 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5477 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5478 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5481 * gnutls.c (Qgnutls_dll): Define.
5482 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5483 (gnutls_*): Declare function pointers.
5484 (init_gnutls_functions): New function to initialize function pointers.
5485 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5486 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5487 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5488 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5489 (emacs_gnutls_write, emacs_gnutls_read)
5490 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5491 (Fgnutls_available_p): New function.
5492 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5493 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5494 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5496 * image.c: Include w32.h.
5497 (Vimage_type_cache): Delete.
5498 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5499 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5500 (w32_delayed_load): Move to w32.c.
5502 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5504 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5505 (w32_delayed_load): Move from image.c. When loading a library, record
5506 its filename in the :loaded-from property of the library id.
5507 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5508 Initialize and staticpro them.
5509 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5511 * process.c: Include lisp.h before w32.h, not after.
5512 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5513 instead of gnutls_record_check_pending.
5515 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5517 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5519 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5520 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5523 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5525 * xterm.c (x_set_frame_alpha): Do not set property on anything
5526 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5528 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5530 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5532 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5534 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5535 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5536 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5537 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5538 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5539 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5540 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5541 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5542 (Qgnutls_bootprop_callbacks_verify): Make static.
5544 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5546 * callproc.c: Indentation fixup.
5548 * sysdep.c (wait_for_termination_1): Make static.
5549 (wait_for_termination, interruptible_wait_for_termination):
5550 Move after wait_for_termination_1.
5552 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5554 * sysdep.c (interruptible_wait_for_termination): New function
5555 which is like wait_for_termination, but allows keyboard
5558 * callproc.c (Fcall_process): Add (:file "file") as an option for
5560 (Fcall_process_region): Ditto.
5562 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5564 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5565 rather than `XVECTOR (FOO)->size'.
5567 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5568 inttypes.h, as a gnulib replacement is used if it not available in
5571 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5573 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5574 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5575 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5577 * coding.c (coding_alloc_by_realloc): Error out if destination
5578 will grow beyond MOST_POSITIVE_FIXNUM.
5579 (decode_coding_emacs_mule): Abort if there isn't enough place in
5580 charbuf for the composition carryover bytes. Reserve an extra
5581 space for up to 2 characters produced in a loop.
5582 (decode_coding_iso_2022): Abort if there isn't enough place in
5583 charbuf for the composition carryover bytes.
5585 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5587 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5588 aborting when %lld or %lll format is passed.
5589 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5590 %llo or %llx format is passed. (Bug#8545)
5592 * window.c (window_scroll_line_based): Use a marker instead of
5593 simple variables to record original value of point. (Bug#7952)
5595 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5596 produced by %s or %c overflows available buffer space. (Bug#8545)
5598 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5600 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5601 (SIZE_MAX): Move defn after all includes, as they might #define it.
5603 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5605 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5607 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5609 * keyboard.c (Qdelayed_warnings_hook): Define.
5610 (command_loop_1): Run `delayed-warnings-hook'
5611 if Vdelayed_warnings_list is non-nil.
5612 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5613 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5615 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5617 * doprnt.c (doprnt): Don't return value smaller than the buffer
5618 size if the message was truncated. (Bug#8545).
5620 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5622 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5623 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5625 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5627 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5629 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5631 * makefile.w32-in: Update dependencies.
5633 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5635 Improve `doprnt' and its usage. (Bug#8545)
5636 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5637 `format_end'. Remove support for %l as a conversion specifier.
5638 Don't use xrealloc. Improve diagnostics when the %l size modifier
5639 is used. Update the commentary.
5641 * eval.c (verror): Simplify calculation of size_t.
5643 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5646 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5648 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5651 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5653 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5654 This makes this file independent of the recent pseudovector change.
5656 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5658 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5660 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5661 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5662 Remove unused local.
5663 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5665 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5666 GCC 4.6.0 optimizes based on type-based alias analysis.
5667 For example, if b is of type struct buffer * and v of type struct
5668 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5669 != &v->size, and therefore "v->size = 1; b->size = 2; return
5670 v->size;" must therefore return 1. This assumption is incorrect
5671 for Emacs, since it type-puns struct Lisp_Vector * with many other
5672 types. To fix this problem, this patch adds a new type struct
5673 vectorlike_header that documents the constraints on layout of vectors
5674 and pseudovectors, and helps optimizing compilers not get fooled
5675 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5676 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5677 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5679 (XSETPVECTYPE): Rewrite in terms of new macro.
5680 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5681 This is a bit clearer, and further avoids the possibility of
5682 undesirable aliasing.
5683 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5684 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5685 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5686 since Lisp_Subr is a special case (no "next" field).
5687 (ASIZE): Now uses header.size rather than size.
5688 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5689 to avoid the hassle of writing XVECTOR (foo)->header.size.
5690 (struct vectorlike_header): New type.
5691 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5692 object, to help avoid aliasing.
5693 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5694 (SUBRP): Likewise, since Lisp_Subr is a special case.
5695 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5696 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5697 (struct Lisp_Hash_Table): Combine first two members into a single
5698 struct vectorlike_header member. All uses of "size" and "next" members
5699 changed to be "header.size" and "header.next".
5700 * buffer.h (struct buffer): Likewise.
5701 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5702 * frame.h (struct frame): Likewise.
5703 * process.h (struct Lisp_Process): Likewise.
5704 * termhooks.h (struct terminal): Likewise.
5705 * window.c (struct save_window_data, struct saved_window): Likewise.
5706 * window.h (struct window): Likewise.
5707 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5708 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5709 * buffer.c (init_buffer_once): Likewise.
5710 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5712 * process.c (Fformat_network_address): Use local var for size,
5715 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5717 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5718 * data.c (atof): Remove decl; no longer used or needed.
5719 (digit_to_number): Move to lread.c.
5720 (Fstring_to_number): Use new string_to_number function, to be
5721 consistent with how the Lisp reader treats infinities and NaNs.
5722 Do not assume that floating-point numbers represent EMACS_INT
5723 without losing information; this is not true on most 64-bit hosts.
5724 Avoid double-rounding errors, by insisting on integers when
5725 parsing non-base-10 numbers, as the documentation specifies.
5726 * lisp.h (string_to_number): New decl, replacing ...
5727 (isfloat_string): Remove.
5728 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5729 (read1): Do not accept +. and -. as integers; this
5730 appears to have been a coding error. Similarly, do not accept
5731 strings like +-1e0 as floating point numbers. Do not report
5732 overflow for integer overflows unless the base is not 10 which
5733 means we have no simple and reliable way to continue.
5734 Break out the floating-point parsing into a new
5735 function string_to_number, so that Fstring_to_number parses
5736 floating point numbers consistently with the Lisp reader.
5737 (digit_to_number): Move here from data.c. Make it static inline.
5738 (E_CHAR, EXP_INT): Remove, replacing with ...
5739 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5740 (string_to_number): New function, replacing isfloat_string.
5741 This function checks for valid syntax and produces the resulting
5742 Lisp float number too. Rework it so that string-to-number
5743 no longer mishandles examples like "1.0e+". Use strtoumax,
5744 so that overflow for non-base-10 numbers is reported only when
5745 there's no portable and simple way to convert to floating point.
5747 * textprop.c (set_text_properties_1): Rewrite for clarity,
5748 and to avoid GCC warning about integer overflow.
5750 * intervals.h (struct interval): Use EMACS_INT for members
5751 where EMACS_UINT might cause problems. See
5752 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5753 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5754 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5756 (offset_intervals): Tell GCC not to worry about length overflow
5757 when negating a negative length.
5759 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5760 (overrun_check_free): Likewise.
5762 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5763 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5766 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5767 (gnutls_make_error): Rename local to avoid shadowing.
5768 (gnutls_emacs_global_deinit): ifdef out; not used.
5769 (Fgnutls_boot): Use const for pointer to readonly storage.
5770 Comment out unused local. Fix pointer signedness problems.
5772 * lread.c (openp): Don't stuff size_t into an 'int'.
5773 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5774 about possible signed overflow.
5776 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5777 (GDK_KEY_g): Don't define if already defined.
5778 (xg_prepare_tooltip): Avoid pointer signedness problem.
5779 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5781 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5782 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5784 * xfns.c (Fx_window_property): Simplify a bit,
5785 to make a bit faster and to avoid GCC 4.6.0 warning.
5786 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5788 * fns.c (internal_equal): Don't assume size_t fits in int.
5790 * alloc.c (compact_small_strings): Tighten assertion a little.
5792 Replace pEd with more-general pI, and fix some printf arg casts.
5793 * lisp.h (pI): New macro, generalizing old pEd macro to other
5794 conversion specifiers. For example, use "...%"pI"d..." rather
5795 than "...%"pEd"...".
5796 (pEd): Remove. All uses replaced with similar uses of pI.
5797 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5798 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5799 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5800 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5801 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5802 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5803 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5805 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5806 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5807 * print.c (safe_debug_print, print_object): Likewise.
5808 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5810 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5811 avoiding the 0 flag, which is not portable.
5812 * process.c (Fmake_network_process): Use pI to avoid cast.
5813 * region-cache.c (pp_cache): Likewise.
5814 * xdisp.c (decode_mode_spec): Likewise.
5815 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5816 behavior on 64-bit hosts with printf arg.
5817 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5818 (x_stop_queuing_selection_requests): Likewise.
5819 (x_get_window_property): Don't truncate byte count to an 'int'
5822 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5823 here, since it parses constructs like leading '-' and spaces,
5824 which are not wanted; and it overflows with large numbers.
5825 Instead, simply match F[0-9]+, which is what is wanted anyway.
5827 * alloc.c: Remove unportable assumptions about struct layout.
5828 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5829 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5830 (allocate_vectorlike, make_pure_vector): Use the new macros,
5831 plus offsetof, to remove unportable assumptions about struct layout.
5832 These assumptions hold on all porting targets that I know of, but
5833 they are not guaranteed, they're easy to remove, and removing them
5834 makes further changes easier.
5836 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5837 This doesn't fix a bug but makes the code clearer.
5838 (string_overrun_cookie): Now const. Use initializers that
5839 don't formally overflow signed char, to avoid warnings.
5840 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5841 can cause Emacs to crash when string overrun checking is enabled.
5842 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5843 multiple of sizeof (EMACS_INT); it need not be, if
5844 alignof(EMACS_INT) < sizeof (EMACS_INT).
5845 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5847 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5849 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5851 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5853 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5854 supposed to be handshaking. (Bug#8556)
5855 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5857 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5859 * lisp.h (Qdebug): List symbol.
5860 * eval.c (Qdebug): Restore global linkage.
5861 * keyboard.c (debug-on-event): New variable.
5862 (handle_user_signal): Break into debugger when debug-on-event
5863 matches the current signal symbol.
5865 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5867 * alloc.c (check_sblock, check_string_bytes)
5868 (check_string_free_list): Convert to standard C.
5870 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5872 * w32.c (emacs_gnutls_push): Fix typo.
5874 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5876 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5877 "cast to pointer from integer of different size".
5879 Improve doprnt and its use in verror. (Bug#8545)
5880 * doprnt.c (doprnt): Document the set of format control sequences
5881 supported by the function. Use SAFE_ALLOCA instead of always
5884 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5885 is one byte too soon. Don't use xrealloc; instead xfree and
5888 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5890 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5893 * gnutls.c: Renamed global_initialized to
5894 gnutls_global_initialized. Added internals for the
5895 :verify-hostname-error, :verify-error, and :verify-flags
5896 parameters of `gnutls-boot' and documented those parameters in the
5897 docstring. Start callback support.
5898 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5899 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5900 on error. Return error code.
5901 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5902 (emacs_gnutls_read): Likewise.
5903 (Fgnutls_boot): Return handshake error code.
5904 (emacs_gnutls_handle_error): New function.
5905 (wsaerror_to_errno): Likewise.
5907 * w32.h (emacs_gnutls_pull): Add prototype.
5908 (emacs_gnutls_push): Likewise.
5910 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5911 (emacs_gnutls_push): Likewise.
5913 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5915 * process.c (wait_reading_process_output): Check if GnuTLS
5916 buffered some data internally if no FDs are set for TLS
5919 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5920 (LIBS): Link to USER_LIBS.
5921 ($(BLD)/gnutls.$(0)): New target.
5923 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5925 * xdisp.c (handle_single_display_spec): Rename the
5926 display_replaced_before_p argument into display_replaced_p, to
5927 make it consistent with the commentary. Fix typos in the
5930 * textprop.c (syms_of_textprop): Remove dead code.
5931 (copy_text_properties): Delete obsolete commentary about an
5932 interface that was deleted long ago. Fix typos in the description
5935 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5936 to changes in oldXMenu/XMenu.h from 2011-04-16.
5937 <menu_help_message, prev_menu_help_message>: Constify.
5938 (IT_menu_make_room): menu->help_text is now `const char **';
5941 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5942 to changes in oldXMenu/XMenu.h from 2011-04-16.
5943 (struct XMenu): Declare `help_text' `const char **'.
5945 * xfaces.c <Qunspecified>: Make extern again.
5947 * syntax.c: Include sys/types.h before including regex.h, as
5950 * doc.c (get_doc_string): Improve the format passed to `error'.
5952 * doprnt.c (doprnt): Improve commentary.
5954 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5956 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5959 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5960 changes in globals.h immediately force recompilation.
5961 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5962 $(CURDIR)/s/ms-w32.h.
5963 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5965 * character.c (Fchar_direction): Function deleted.
5966 (syms_of_character): Don't defsubr it.
5967 <char-direction-table>: Deleted.
5969 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5971 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5972 * doprnt.c: Include limits.h.
5973 (SIZE_MAX): New macro.
5974 (doprnt): Return a size_t value. 2nd arg is now size_t.
5975 Many local variables are now size_t instead of int or unsigned.
5976 Improve overflow protection. Support `l' modifier for integer
5977 conversions. Support %l conversion. Don't assume an EMACS_INT
5978 argument for integer conversions and for %c.
5980 * lisp.h (doprnt): Restore prototype.
5982 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5985 * Makefile.in (base_obj): Add back doprnt.o.
5987 * deps.mk (doprnt.o): Add back prerequisites.
5988 (callint.o): Depend on character.h.
5990 * eval.c (internal_lisp_condition_case): Include the handler
5991 representation in the error message.
5992 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5993 when breaking from the loop.
5995 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5997 * callint.c (Fcall_interactively): When displaying error message
5998 about invalid control letter, pass the character's codepoint, not
5999 a pointer to its multibyte form. Improve display of the character
6000 in octal and display also its hex code.
6002 * character.c (char_string): Use %x to display the (unsigned)
6003 codepoint of an invalid character, to avoid displaying a bogus
6006 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6007 `error', not SYMBOL_NAME itself.
6009 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6010 character arguments to `error'.
6012 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6013 to `error' in error message about FINAL_CHAR argument. Make sure
6014 FINAL_CHAR is a character, and use %c when it is passed as
6015 argument to `error'.
6017 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6019 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6021 * w32.c: Include <time.h>.
6022 (sys_localtime): New function.
6024 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6026 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6028 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6030 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6032 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6035 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6037 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6038 gl_state.e_property when gl_state.object is Qt.
6040 * insdel.c (make_gap_larger): Remove limitation of buffer size
6043 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6045 * xdisp.c (lookup_glyphless_char_display)
6046 (produce_glyphless_glyph): Handle cons cell entry in
6047 glyphless-char-display.
6048 (Vglyphless_char_display): Document it.
6050 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6051 glyphless-char-display.
6053 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6055 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6057 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6059 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6060 definition for no-X builds.
6062 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6064 Static checks with GCC 4.6.0 and non-default toolkits.
6066 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6068 * process.c (keyboard_bit_set): Define only if SIGIO.
6069 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6070 (send_process): Repair possible setjmp clobbering.
6072 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6074 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6076 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6078 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6079 Define only if needed.
6081 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6082 by pacifying GCC about it. Maybe it's time to retire it?
6083 * xfaces.c (USG, __TIMEVAL__): Likewise.
6085 * dispextern.h (struct redisplay_interface): Rename param
6087 * termhooks.h (struct terminal): Likewise.
6088 * xterm.c (xembed_send_message): Likewise.
6090 * insdel.c (make_gap_smaller): Define only if
6091 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6093 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6096 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6097 so that we aren't warned about unused symbols.
6099 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6101 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6103 * xfns.c (x_real_positions): Mark locals as initialized.
6105 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6107 * xterm.c: Fix problems found by static analysis with other toolkits.
6108 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6109 (x_dispatch_event): Declare static if USE_GTK, and
6110 define if USE_GTK || USE_X_TOOLKIT.
6111 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6112 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6113 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6114 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6116 * xmenu.c (menu_help_callback): Pointer type fixes.
6117 Use const pointers when pointing at readonly data. Avoid pointer
6119 (FALSE): Remove unused macro.
6120 (update_frame_menubar): Remove unused decl.
6122 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6124 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6125 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6126 (single_menu_item): Rename local to avoid shadowing.
6128 * keyboard.c (make_lispy_event): Remove unused local var.
6130 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6131 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6133 * bitmaps: Change bitmaps from unsigned char back to the X11
6134 compatible char. Avoid the old compiler warnings about
6135 out-of-range initializers by using, for example, '\xab' rather
6138 * xgselect.c (xgselect_initialize): Check vs interface
6139 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6141 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6143 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6144 to read-only memory.
6146 * fns.c (vector): Remove; this old hack is no longer needed.
6148 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6150 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6152 * xrdb.c (x_load_resources): Omit unused local.
6154 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6155 (x_window): Rename locals to avoid shadowing.
6156 (USG): Use the kludged USG macro, to pacify gcc.
6158 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6159 (x_term_init): Remove local to avoid shadowing.
6161 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6163 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6164 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6166 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6168 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6170 Fix regex.c, syntax.c and friends for buffers > 2GB.
6171 * syntax.h (struct gl_state_s): Declare character position members
6174 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6176 * textprop.c (verify_interval_modification, interval_of):
6177 Declare arguments EMACS_INT.
6179 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6182 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6184 * indent.c (Fvertical_motion): Local variable it_start is now
6187 * regex.c (re_match, re_match_2, re_match_2_internal)
6188 (bcmp_translate, regcomp, regexec, print_double_string)
6189 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6190 (re_compile_pattern, re_exec): Declare arguments and local
6191 variables `size_t' and `ssize_t' and return values `regoff_t', as
6193 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6194 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6195 <compile_stack_type>: `size' and `avail' are now `size_t'.
6197 * regex.h <regoff_t>: Use ssize_t, not int.
6198 (re_search, re_search_2, re_match, re_match_2): Arguments that
6199 specify buffer/string position and length are now ssize_t and
6200 size_t. Return type is regoff_t.
6202 2011-04-16 Ben Key <bkey76@gmail.com>
6204 * nsfont.m: Fixed bugs in ns_get_family and
6205 ns_descriptor_to_entity that were caused by using free to
6206 deallocate memory blocks that were allocated by xmalloc (via
6207 xstrdup). This caused Emacs to crash when compiled with
6208 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6209 --enable-checking=xmallocoverrun). xfree is now used to
6210 deallocate these memory blocks.
6212 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6214 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6216 emacs_write: Accept and return EMACS_INT for sizes.
6217 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6219 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6220 Accept and return EMACS_INT.
6221 (emacs_gnutls_write): Return the number of bytes written on
6223 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6224 (emacs_read, emacs_write): Remove check for negative size, as the
6225 Emacs source code has been audited now.
6226 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6227 (emacs_read, emacs_write): Use it.
6228 * process.c (send_process): Adjust to the new signatures of
6229 emacs_write and emacs_gnutls_write. Do not attempt to store
6230 a byte offset into an 'int'; it might overflow.
6231 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6233 * sound.c: Don't assume sizes fit in 'int'.
6234 (struct sound_device.period_size, alsa_period_size):
6235 Return EMACS_INT, not int.
6236 (struct sound_device.write, vox_write, alsa_write):
6237 Accept EMACS_INT, not int.
6238 (wav_play, au_play): Use EMACS_INT to store sizes and to
6239 record read return values.
6241 2011-04-15 Ben Key <bkey76@gmail.com>
6243 * keyboard.c (Qundefined): Don't declare static since it is used
6245 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6246 static since they are used in nsfont.m.
6248 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6250 * process.c (Qprocessp): Don't declare static.
6251 * lisp.h (Qprocessp): Declare again.
6253 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6255 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6257 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6259 Improve C-level modularity by making more things 'static'.
6261 Don't publish debugger-only interfaces to other modules.
6262 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6263 (verify_bytepos, count_markers): Move decls to the only modules
6265 * region-cache.h (pp_cache): Likewise.
6266 * window.h (check_all_windows): Likewise.
6267 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6269 * sysdep.c (croak): Now static, if
6270 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6271 * syssignal.h (croak): Declare only if not static.
6273 * alloc.c (refill_memory_reserve): Now static if
6274 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6275 * lisp.h (refill_memory_reserve): Declare only if not static.
6277 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6278 Define only if USE_LUCID.
6280 * xrdb.c (x_customization_string, x_rm_string): Now static.
6282 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6283 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6285 * xdisp.c (draw_row_with_mouse_face): Now static.
6286 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6288 * window.h (check_all_windows): Mark externally visible.
6290 * window.c (window_deletion_count): Now static.
6292 * undo.c: Make symbols static if they're not exported.
6293 (last_undo_buffer, last_boundary_position, pending_boundary):
6296 * textprop.c (interval_insert_behind_hooks): Now static.
6297 (interval_insert_in_front_hooks): Likewise.
6299 * term.c: Make symbols static if they're not exported.
6300 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6301 (max_frame_lines, tty_set_terminal_modes):
6302 (tty_reset_terminal_modes, tty_turn_off_highlight):
6303 (get_tty_terminal): Now static.
6304 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6305 * termhooks.h (term_mouse_moveto): Do not declare if
6307 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6308 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6310 * sysdep.c: Make symbols static if they're not exported.
6311 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6313 (sigprocmask_set, full_mask): Remove; unused.
6314 (wait_debugging): Mark as visible.
6315 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6316 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6318 * syntax.c (syntax_temp): Define only if !__GNUC__.
6320 * sound.c (current_sound_device, current_sound): Now static.
6322 * search.c (searchbufs, searchbuf_head): Now static.
6324 * scroll.c (scroll_cost): Remove; unused.
6325 * dispextern.h (scroll_cost): Remove decl.
6327 * region-cache.h (pp_cache): Mark as externally visible.
6329 * process.c: Make symbols static if they're not exported.
6330 (process_tick, update_tick, create_process, chan_process):
6331 (Vprocess_alist, proc_buffered_char, datagram_access):
6332 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6333 (deactivate_process): Mark defn as static, as well as decl.
6334 * lisp.h (create_process): Remove decl.
6335 * process.h (chan_process, Vprocess_alist): Remove decls.
6337 * print.c: Make symbols static if they're not exported.
6338 (print_depth, new_backquote_output, being_printed, print_buffer):
6339 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6340 (print_interval, print_number_index, initial_stderr_stream):
6342 * lisp.h (Fprinc): Remove decl.
6343 (debug_output_compilation_hack): Mark as externally visible.
6345 * sysdep.c (croak): Move decl from here to syssignal.h.
6346 * syssignal.h (croak): Put it here, so the API can be checked when
6347 'croak' is called from dissociate_if_controlling_tty.
6349 * minibuf.c: Make symbols static if they're not exported.
6350 (minibuf_save_list, choose_minibuf_frame): Now static.
6351 * lisp.h (choose_minibuf_frame): Remove decl.
6353 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6355 * lread.c: Make symbols static if they're not exported.
6356 (read_objects, initial_obarray, oblookup_last_bucket_number):
6358 (make_symbol): Remove; unused.
6359 * lisp.h (initial_obarray, make_symbol): Remove decls.
6361 * keyboard.c: Make symbols static if they're not exported.
6362 (single_kboard, recent_keys_index, total_keys, recent_keys):
6363 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6364 (this_single_command_key_start, echoing, last_auto_save):
6365 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6366 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6367 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6368 (Vlispy_mouse_stem, double_click_count):
6370 (force_auto_save_soon): Define only if SIGDANGER.
6371 (ignore_mouse_drag_p): Now static if
6372 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6373 (print_help): Remove; unused.
6374 (stop_character, last_timer_event): Mark as externally visible.
6375 * keyboard.h (ignore_mouse_drag_p): Declare only if
6376 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6377 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6378 * lisp.h (echoing): Remove decl.
6379 (force_auto_save_soon): Declare only if SIGDANGER.
6380 * xdisp.c (redisplay_window): Simplify code, to make it more
6381 obvious that ignore_mouse_drag_p is not accessed if !defined
6382 USE_GTK && !defined HAVE_NS.
6384 * intervals.c: Make symbols static if they're not exported.
6385 (merge_properties_sticky, merge_interval_right, delete_interval):
6387 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6389 * insdel.c: Make symbols static if they're not exported.
6390 However, leave prepare_to_modify_buffer alone. It's never
6391 called from outside this function, but that appears to be a bug.
6392 (combine_after_change_list, combine_after_change_buffer):
6393 (adjust_after_replace, signal_before_change): Now static.
6394 (adjust_after_replace_noundo): Remove; unused.
6395 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6396 (signal_before_change): Remove decls.
6398 * indent.c (val_compute_motion, val_vmotion): Now static.
6400 * image.c: Make symbols static if they're not exported.
6401 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6403 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6404 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6406 * fringe.c (standard_bitmaps): Now static.
6407 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6409 * frame.c: Make symbols static if they're not exported.
6410 (x_report_frame_params, make_terminal_frame): Now static.
6411 (get_frame_param): Now static, unless HAVE_NS.
6412 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6413 (x_get_resource_string): Remove; not used.
6414 * frame.h (make_terminal_frame, x_report_frame_params):
6415 (x_get_resource_string); Remove decls.
6416 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6417 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6419 * font.c, fontset.c: Make symbols static if they're not exported.
6420 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6421 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6422 * font.c (font_close_object): Now static.
6423 * font.h (font_close_object): Remove.
6424 * fontset.c (FONTSET_OBJLIST): Remove.
6425 (free_realized_fontset) #if-0 the body, which does nothing.
6426 (face_suitable_for_char_p): #if-0, as it's never called.
6427 * fontset.h (face_suitable_for_char_p): Remove decl.
6428 * xfaces.c (face_at_string_position):
6429 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6430 since 0 is always ASCII.
6432 * fns.c (weak_hash_tables): Now static.
6434 * fileio.c: Make symbols static if they're not exported.
6435 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6436 (Vwrite_region_annotation_buffers): Now static.
6438 * eval.c: Make symbols static if they're not exported.
6439 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6440 * lisp.h (backtrace_list): Remove decl.
6442 * emacs.c: Make symbols static if they're not exported.
6443 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6444 (fatal_error_code, fatal_error_signal_hook, standard_args):
6446 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6447 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6448 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6449 * lisp.h (fatal_error_signal_hook): Remove decl.
6450 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6452 * editfns.c: Move a (normally-unused) function to its only use.
6453 * editfns.c, lisp.h (get_operating_system_release): Remove.
6454 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6455 worth the hassle of breaking this out.
6457 * xterm.c: Make symbols static if they're not exported.
6458 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6459 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6460 (x_destroy_window, x_delete_display):
6462 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6463 (x_mouse_leave): Remove; unused.
6464 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6465 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6466 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6468 (x_mouse_leave): Declare only if WINDOWSNT.
6469 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6470 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6473 * ftxfont.c: Make symbols static if they're not exported.
6474 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6476 * font.h (ftxfont_driver): Likewise.
6478 * xfns.c: Make symbols static if they're not exported.
6479 (x_last_font_name, x_display_info_for_name):
6480 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6481 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6482 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6483 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6484 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6485 (last_show_tip_args): Now static.
6486 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6487 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6488 (x_screen_planes): Remove; unused.
6489 * dispextern.h (x_screen_planes): Remove decl.
6491 * dispnew.c: Make symbols static if they're not exported.
6492 * dispextern.h (redraw_garbaged_frames, scrolling):
6493 (increment_row_positions): Remove.
6494 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6495 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6497 (redraw_garbaged_frames): Remove; unused.
6499 * xfaces.c: Make symbols static if they're not exported.
6500 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6502 * xterm.h (defined_color): Remove decls.
6503 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6504 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6505 (menu_face_changed_default, defined_color, free_realized_face):
6506 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6507 (ascii_face_of_lisp_face): Remove; unused.
6509 * xdisp.c: Make symbols static if they're not exported.
6510 * dispextern.h (scratch_glyph_row, window_box_edges):
6511 (glyph_to_pixel_coords, set_cursor_from_row):
6512 (get_next_display_element, set_iterator_to_next):
6513 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6514 (show_mouse_face): Remove decls
6515 * frame.h (message_buf_print): Likewise.
6516 * lisp.h (pop_message, set_message, check_point_in_composition):
6518 * xterm.h (set_vertical_scroll_bar): Likewise.
6519 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6520 (message_buf_print, scratch_glyph_row, displayed_buffer):
6521 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6522 (get_next_display_element, show_mouse_face, window_box_edges):
6523 (frame_to_window_pixel_xy, check_point_in_composition):
6524 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6525 (glyph_to_pixel_coords): Remove; unused.
6527 * dired.c (file_name_completion): Now static.
6529 * dbusbind.c (xd_in_read_queued_messages): Now static.
6531 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6532 * data.c (circular_list_error): Remove.
6534 * commands.h (last_point_position, last_point_position_buffer):
6535 (last_point_position_window): Remove decls.
6536 * keyboard.c: Make these variables static.
6538 * coding.h (coding, code_convert_region, encode_coding_gap):
6540 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6541 (iso_code_class, detect_coding, code_convert_region): Now static.
6542 (encode_coding_gap): Remove; unused.
6544 * chartab.c (chartab_chars, chartab_bits): Now static.
6546 * charset.h (charset_iso_8859_1): Remove decl.
6547 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6550 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6551 * ccl.c (Vccl_program_table): Now static.
6552 (check_ccl_update): Remove; unused.
6554 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6555 * category.h: ... from here.
6556 * category.c (check_category_table, set_category_set): Now static.
6558 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6559 * lisp.h: Remove these decls.
6561 * buffer.c (buffer_count): Remove unused var.
6563 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6564 so that it's not optimized away.
6565 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6566 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6567 exported only to the debugger.
6569 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6570 * atimer.h (run_all_atimers): Remove; not exported.
6572 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6573 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6574 was inaccessible from Lisp.
6575 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6576 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6578 alloc.c: Import and export fewer symbols, and remove unused items.
6579 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6581 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6582 it's not optimized away by whole-program optimization.
6583 (message_enable_multibyte, free_misc): Remove.
6584 (catchlist, handlerlist, mark_backtrace):
6585 Declare only if BYTE_MARK_STACK.
6586 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6587 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6588 (message_enable_multibyte): Remove decl.
6589 (free_misc, interval_free_list, float_block, float_block_index):
6590 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6591 (cons_free_list, last_marked_index):
6593 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6594 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6595 (mark_backtrace): Define only if BYTE_MARK_STACK.
6596 * xdisp.c (message_enable_multibyte): Now static.
6598 Declare Lisp_Object Q* variables to be 'static' if not exported.
6599 This makes it easier for human readers (and static analyzers)
6600 to see whether these variables are used from other modules.
6601 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6602 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6603 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6604 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6605 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6606 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6607 * xmenu.c, xselect.c:
6608 Declare Q* vars static if they are not used in other modules.
6609 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6610 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6611 Remove decls of unexported vars.
6612 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6614 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6616 Make Emacs functions such as Fatom 'static' by default.
6617 This makes it easier for human readers (and static analyzers)
6618 to see whether these functions can be called from other modules.
6619 DEFUN now defines a static function. To make the function external
6620 so that it can be used in other C modules, use the new macro DEFUE.
6621 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6622 (Finit_image_library):
6623 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6624 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6625 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6626 Remove decls, since these functions are now static.
6627 (Funintern, Fget_internal_run_time): New decls, since these functions
6628 were already external.
6630 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6631 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6632 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6633 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6634 * keyboard.c, keymap.c, lread.c:
6635 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6636 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6637 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6638 Mark functions with DEFUE instead of DEFUN,
6639 if they are used in other modules.
6640 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6641 decls for now-static functions.
6642 * buffer.h (Fdelete_overlay): Remove decl.
6643 * callproc.c (Fgetenv_internal): Mark as internal.
6644 * composite.c (Fremove_list_of_text_properties): Remove decl.
6645 (Fcomposition_get_gstring): New forward static decl.
6646 * composite.h (Fcomposite_get_gstring): Remove decl.
6647 * dired.c (Ffile_attributes): New forward static decl.
6648 * doc.c (Fdocumntation_property): New forward static decl.
6649 * eval.c (Ffetch_bytecode): New forward static decl.
6650 (Funintern): Remove extern decl; now in .h file where it belongs.
6651 * fileio.c (Fmake_symbolic_link): New forward static decl.
6652 * image.c (Finit_image_library): New forward static decl.
6653 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6654 * intervals.h (Fprevious_property_change):
6655 (Fremove_list_of_text_properties): Remove decls.
6656 * keyboard.c (Fthis_command_keys): Remove decl.
6657 (Fcommand_execute): New forward static decl.
6658 * keymap.c (Flookup_key): New forward static decl.
6659 (Fcopy_keymap): Now static.
6660 * keymap.h (Flookup_key): Remove decl.
6661 * process.c (Fget_process): New forward static decl.
6662 (Fprocess_datagram_address): Mark as internal.
6663 * syntax.c (Fsyntax_table_p): New forward static decl.
6664 (skip_chars): Remove duplicate decl.
6665 * textprop.c (Fprevious_property_change): New forward static decl.
6666 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6668 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6669 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6671 * editfns.c (Fformat): Remove unreachable code.
6673 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6675 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6678 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6680 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6681 when at ZV. (Bug#8487)
6683 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6685 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6687 * keyboard.c (parse_tool_bar_item): Likewise.
6688 * sound.c (sound_cleanup, alsa_close): Likewise.
6689 * termcap.c (tgetent): Likewise.
6690 * xfns.c (x_default_font_parameter): Likewise.
6691 * xsettings.c (read_and_apply_settings): Likewise.
6693 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6694 (overrun_check_free): Protoize.
6696 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6698 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6699 since callers should never pass a negative size.
6700 Change the signature to match that of plain 'read' and 'write'; see
6701 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6702 * lisp.h: Update prototypes of emacs_write and emacs_read.
6704 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6706 * xdisp.c (redisplay_window): Don't try to determine the character
6707 position of the scroll margin if the window start point w->startp
6708 is outside the buffer's accessible region. (Bug#8468)
6710 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6712 Fix write-region and its subroutines for buffers > 2GB.
6713 * fileio.c (a_write, e_write): Modify declaration of arguments and
6714 local variables to support buffers larger than 2GB.
6715 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6717 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6718 argument, local variables, and return value.
6720 * lisp.h: Update prototypes of emacs_write and emacs_read.
6722 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6724 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6726 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6728 Fix more problems found by GCC 4.6.0's static checks.
6730 * xdisp.c (vmessage): Use a better test for character truncation.
6732 * charset.c (load_charset_map): <, not <=, for optimization,
6733 and to avoid potential problems with integer overflow.
6734 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6735 * casetab.c (set_identity, shuffle): Likewise.
6736 * editfns.c (Fformat): Likewise.
6737 * syntax.c (skip_chars): Likewise.
6739 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6740 This also lets GCC 4.6.0 generate slightly better loop code.
6742 * callint.c (Fcall_interactively): <, not <=, for optimization.
6743 (Fcall_interactively): Count the number of arguments produced,
6744 not the number of arguments given. This is simpler and lets GCC
6745 4.6.0 generate slightly better code.
6747 * ftfont.c: Distingish more carefully between FcChar8 and char.
6748 The previous code passed unsigned char * to a functions like
6749 strlen and xstrcasecmp that expect char *, which does not
6750 conform to the C standard.
6751 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6752 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6753 char * when the C standard requires it.
6755 * keyboard.c (read_char): Remove unused var.
6757 * eval.c: Port to Windows vsnprintf (Bug#8435).
6759 (SIZE_MAX): Define if the headers do not.
6760 (verror): Do not give up if vsnprintf returns a negative count.
6761 Instead, grow the buffer. This ports to Windows vsnprintf, which
6762 does not conform to C99. Problem reported by Eli Zaretskii.
6763 Also, simplify the allocation scheme, by avoiding the need for
6764 calling realloc, and removing the ALLOCATED variable.
6766 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6768 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6769 But keep the doprint source code for now, as we might revamp it
6770 and use it again (Bug#8435).
6771 * lisp.h (doprnt): Remove.
6772 * Makefile.in (base_obj): Remove doprnt.o.
6773 * deps.mk (doprnt.o): Remove.
6775 error: Print 32- and 64-bit integers portably (Bug#8435).
6776 Without this change, on typical 64-bit hosts error ("...%d...", N)
6777 was used to print both 32- and 64-bit integers N, which relied on
6779 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6781 * lisp.h (error, verror): Mark as printf-like functions.
6782 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6783 Report overflow in size calculations when allocating printf buffer.
6784 Do not truncate output string at its first null byte.
6785 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6786 Truncate the output at a character boundary, since vsnprintf does not
6788 * charset.c (check_iso_charset_parameter): Convert internal
6789 character to string before calling 'error', since %c now has the
6791 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6792 overflow when computing char to be passed to 'error'. Do not
6793 pass Lisp_Object to 'error'; pass the integer instead.
6794 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6795 formatted with plain %d.
6797 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6799 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6801 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6803 * xterm.c (x_catch_errors): Remove duplicate declaration.
6805 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6807 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6809 2011-04-10 Jim Meyering <meyering@redhat.com>
6811 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6812 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6813 return ssize_t not "int", and use size_t as the buffer length.
6814 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6815 * gnutls.h: Update declarations.
6816 * process.c (read_process_output): Use ssize_t, to match.
6817 (send_process): Likewise.
6819 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6821 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6823 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6825 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6826 Use unsigned char, to match FcChar8 type definition.
6828 * xterm.c (handle_one_xevent):
6829 * xmenu.c (create_and_show_popup_menu):
6830 * xselect.c (x_decline_selection_request)
6831 (x_reply_selection_request): Avoid type-punned deref of X events.
6833 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6835 Fix some uses of `int' instead of EMACS_INT.
6836 * search.c (string_match_1, fast_string_match)
6837 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6838 (scan_buffer, find_next_newline_no_quit)
6839 (find_before_next_newline, search_command, Freplace_match)
6840 (Fmatch_data): Make some `int' variables be EMACS_INT.
6842 * xdisp.c (display_count_lines): 3rd argument and return value now
6843 EMACS_INT. All callers changed.
6844 (pint2hrstr): Last argument is now EMACS_INT.
6846 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6847 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6848 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6849 (decode_coding_utf_16, decode_coding_emacs_mule)
6850 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6851 (decode_coding_ccl, decode_coding_charset)
6852 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6853 (decode_coding_iso_2022, decode_coding_emacs_mule)
6854 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6855 <char_offset, last_offset>: Declare EMACS_INT.
6856 (encode_coding_utf_8, encode_coding_utf_16)
6857 (encode_coding_emacs_mule, encode_invocation_designation)
6858 (encode_designation_at_bol, encode_coding_iso_2022)
6859 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6860 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6862 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6863 (encode_invocation_designation): Last argument P_NCHARS is now
6865 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6866 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6868 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6871 * ccl.c (Fccl_execute_on_string): Declare some variables
6874 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6876 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6878 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6880 * process.c (Fformat_network_address): Doc fix.
6882 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6884 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6886 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6888 * keyboard.c (read_char): Call Lisp function help-form-show,
6889 instead of using internal_with_output_to_temp_buffer.
6890 (Qhelp_form_show): New var.
6891 (syms_of_keyboard): Use DEFSYM macro.
6893 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6895 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6897 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6899 * process.c (Flist_processes): Remove to Lisp.
6900 (list_processes_1): Delete.
6902 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6904 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6906 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6908 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6910 Fix more problems found by GCC 4.6.0's static checks.
6912 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6914 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6916 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6918 * xdisp.c (vmessage): Mark as a printf-like function.
6920 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6922 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6924 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6925 printf-like functions.
6926 (tiff_load): Add casts to remove these marks before passing them
6927 to system-supplied API.
6929 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6931 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6932 This avoids several warnings with gcc -Wstrict-overflow.
6933 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6934 directly, rather than having caller test rule sign. This avoids
6935 some unnecessary tests.
6936 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6937 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6938 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6940 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6941 (xfont_open): Avoid unnecessary tests.
6943 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6945 * composite.h, composite.c (composition_gstring_put_cache):
6946 Use EMACS_INT, not int, for length.
6948 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6949 breaking out part of COMPOSITION_DECODE_RULE.
6950 (COMPOSITION_DECODE_RULE): Use it.
6951 * composite.c (get_composition_id): Remove unused local vars,
6952 by using the new macro.
6954 * textprop.c (set_text_properties_1): Change while to do-while,
6955 since the condition is always true at first.
6957 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6958 (interval_deletion_adjustment): Return unsigned value.
6961 * process.c (list_processes_1, create_pty, read_process_output):
6962 (exec_sentinel): Remove vars that were set but not used.
6963 (create_pty): Remove unnecessary "volatile"s.
6964 (Fnetwork_interface_info): Avoid possibility of int overflow.
6965 (read_process_output): Do adaptive read buffering even if carryover.
6966 (read_process_output): Simplify nbytes computation if buffered.
6968 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6970 * syntax.c (scan_words): Remove var that was set but not used.
6971 (update_syntax_table): Use unsigned instead of int.
6973 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6974 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6975 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6977 * print.c (print_error_message): Avoid int overflow.
6979 * font.c (font_list_entities): Redo for clarity,
6980 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6982 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6983 (font_score): Avoid potential overflow in diff calculation.
6985 * fns.c (substring_both): Remove var that is set but not used.
6986 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6988 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6990 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6991 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6992 can always succeed if overflow has undefined behavior.
6994 * search.c (boyer_moore, wordify): Remove vars set but not used.
6995 (wordify): Omit three unnecessary tests.
6997 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6998 All callers changed. This avoids the need for an unused var.
7000 * casefiddle.c (casify_region): Remove var that is set but not used.
7002 * dired.c (file_name_completion): Remove var that is set but not used.
7004 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7006 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7007 (Finsert_file_contents): Remove unnecessary code checking fd.
7009 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7010 Check for integer overflow on size calculations.
7012 * buffer.c (Fprevious_overlay_change): Remove var that is set
7015 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7016 Remove vars that are set but not used.
7017 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7018 (timer_check_2): Mark vars as initialized.
7020 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7022 * image.c (lookup_image): Remove var that is set but not used.
7023 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7025 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7026 that are set but not used.
7028 * xfns.c (make_invisible_cursor): Don't return garbage
7029 if XCreateBitmapFromData fails (Bug#8410).
7031 * xselect.c (x_get_local_selection, x_handle_property_notify):
7032 Remove vars that are set but not used.
7034 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7035 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7037 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7038 Remove var that is set but not used.
7039 (scroll_bar_windows_size): Now size_t, not int.
7040 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7043 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7044 (map_tty_color) [!defined MSDOS]: Likewise.
7046 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7048 * coding.c: Remove vars that are set but not used.
7049 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7050 All callers changed.
7051 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7052 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7053 (decode_coding_charset): Remove vars that are set but not used.
7055 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7056 that is set but not used.
7058 * print.c (print_object): Remove var that is set but not used.
7060 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7061 The gnulib version avoids calling malloc in the usual case,
7062 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7063 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7064 * filelock.c (current_lock_owner): Likewise.
7065 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7066 * sysdep.c: Include allocator.h, careadlinkat.h.
7067 (emacs_no_realloc_allocator): New static constant.
7068 (emacs_readlink): New function.
7069 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7070 ../lib/careadlinkat.h.
7072 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7074 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7075 first non-nil return value).
7077 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7079 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7080 if not defined (Bug#8403).
7082 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7084 * xdisp.c (display_count_lines): Remove parameter `start',
7085 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7086 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7087 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7088 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7089 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7090 and thereabouts. All callers changed.
7091 (get_per_char_metric): Remove parameter `f', unused since
7092 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7094 2011-04-02 Jim Meyering <meyering@redhat.com>
7096 do not dereference NULL upon failed strdup
7097 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7098 (ns_get_family): Likewise.
7100 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7102 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7104 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7106 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7109 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7111 Add lexical binding.
7113 * window.c (Ftemp_output_buffer_show): New fun.
7114 (Fsave_window_excursion):
7115 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7117 * lread.c (lisp_file_lexically_bound_p): New function.
7118 (Fload): Bind Qlexical_binding.
7119 (readevalloop): Remove `evalfun' arg.
7120 Bind Qinternal_interpreter_environment.
7121 (Feval_buffer): Bind Qlexical_binding.
7122 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7124 (syms_of_lread): Declare `lexical-binding'.
7126 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7128 * keyboard.c (eval_dyn): New fun.
7129 (menu_item_eval_property): Use it.
7131 * image.c (parse_image_spec): Use Ffunctionp.
7133 * fns.c (concat, mapcar1): Accept byte-code-functions.
7135 * eval.c (Fsetq): Handle lexical vars.
7136 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7137 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7138 (FletX, Flet): Obey lexical binding.
7139 (Fcommandp): Handle closures.
7140 (Feval): New `lexical' arg.
7141 (eval_sub): New function extracted from Feval. Use it almost
7142 everywhere where Feval was used. Look up vars in lexical env.
7144 (Ffunctionp): Move from subr.el.
7145 (Ffuncall): Handle closures.
7146 (apply_lambda): Remove `eval_flags'.
7147 (funcall_lambda): Handle closures and new byte-code-functions.
7148 (Fspecial_variable_p): New function.
7149 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7150 but without exporting it to Lisp.
7152 * doc.c (Fdocumentation, store_function_docstring):
7153 * data.c (Finteractive_form): Handle closures.
7155 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7158 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7160 (exec_byte_code): New function extracted from Fbyte_code to handle new
7161 calling convention for byte-code-functions. Add new byte-codes.
7163 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7165 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7167 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7169 * xdisp.c (redisplay_internal): Fix prototype.
7171 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7173 * xdisp.c (SCROLL_LIMIT): New macro.
7174 (try_scrolling): Use it when setting scroll_limit.
7175 Limit scrolling to 100 screen lines.
7176 (redisplay_window): Even when falling back on "recentering",
7177 position point in the window according to scroll-conservatively,
7178 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7180 (try_scrolling): When point is above the window, allow searching
7181 as far as scroll_max, or one screenful, to compute vertical
7182 distance from PT to the scroll margin position. This prevents
7183 try_scrolling from unnecessarily failing when
7184 scroll-conservatively is set to a value slightly larger than the
7185 window height. Clean up the case of PT below the margin at bottom
7186 of window: scroll_max can no longer be INT_MAX. When aggressive
7187 scrolling is in use, don't let point enter the opposite scroll
7188 margin as result of the scroll.
7189 (syms_of_xdisp) <scroll-conservatively>: Document the
7190 threshold of 100 lines for never-recentering scrolling.
7192 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7194 * dispextern.h (move_it_by_lines):
7195 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7196 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7197 (message_log_check_duplicate): Remove parameters `prev_bol' and
7198 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7199 (redisplay_internal): Remove parameter `preserve_echo_area',
7200 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7202 * indent.c (Fvertical_motion):
7203 * window.c (window_scroll_pixel_based, Frecenter):
7204 Don't pass `need_y_p' to `move_it_by_lines'.
7206 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7208 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7209 steal a few bits to be more compact.
7210 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7211 Remove unneeded casts.
7213 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7215 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7217 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7218 binding" message (bug#7967).
7220 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7222 Fix more problems found by GCC 4.6.0's static checks.
7224 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7225 Remove unused local var.
7227 * editfns.c (Fmessage_box): Remove unused local var.
7229 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7230 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7231 Omit unused local vars.
7232 * window.c (shrink_windows): Omit unused local var.
7233 * menu.c (digest_single_submenu): Omit unused local var.
7234 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7235 Omit unused local var.
7237 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7238 Don't assume string length fits in int.
7239 (keyremap_step, read_key_sequence): Use size_t for sizes.
7240 (read_key_sequence): Don't check last_real_key_start redundantly.
7242 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7243 instead of alloca (Bug#8344).
7245 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7246 (Fbacktrace_frame): Don't assume nframes fits in int.
7248 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7250 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7253 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7255 * cm.c (calccost): Turn while-do into do-while, for clarity.
7257 * keyboard.c (syms_of_keyboard): Use the same style as later
7258 in this function when indexing through an array. This also
7259 works around GCC bug 48267.
7261 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7263 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7265 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7266 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7268 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7269 This avoids undefined behavior on integer overflow, and is a bit
7270 more convenient anyway since it is compared to a size_t variable.
7272 Variadic C functions now count arguments with size_t, not int.
7273 This avoids an unnecessary limitation on 64-bit machines, which
7274 caused (substring ...) to crash on large vectors (Bug#8344).
7275 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7276 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7277 All variadic functions and their callers changed accordingly.
7278 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7279 * data.c (arith_driver, float_arith_driver): Likewise.
7280 * editfns.c (general_insert_function): Likewise.
7281 * eval.c (struct backtrace.nargs, interactive_p)
7282 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7283 (funcall_lambda, mark_backtrace): Likewise.
7284 * fns.c (concat): Likewise.
7285 * frame.c (x_set_frame_parameters): Likewise.
7286 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7287 0 if not found, not -1. All callers changed.
7289 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7290 (stack_copy_size): Now size_t, not int.
7291 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7293 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7295 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7296 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7297 All callers changed.
7299 * lisp.h (multibyte_char_to_unibyte):
7300 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7301 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7302 * character.h (CHAR_TO_BYTE8):
7303 * cmds.c (internal_self_insert):
7304 * editfns.c (general_insert_function):
7305 * keymap.c (push_key_description):
7306 * search.c (Freplace_match):
7307 * xdisp.c (message_dolog, set_message_1): All callers changed.
7309 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7311 * keyboard.c (safe_run_hook_funcall): New function.
7312 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7313 don't set the hook to nil, but remove the offending function instead.
7314 (Qcommand_hook_internal): Remove, unused.
7315 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7316 Vcommand_hook_internal.
7318 * eval.c (enum run_hooks_condition): Remove.
7319 (funcall_nil, funcall_not): New functions.
7320 (run_hook_with_args): Call each function through a `funcall' argument.
7321 Remove `cond' argument, now redundant.
7322 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7323 (Frun_hook_with_args_until_failure): Adjust accordingly.
7324 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7326 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7328 * dispextern.h (string_buffer_position): Remove declaration.
7330 * print.c (strout): Remove parameter `multibyte', unused since
7331 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7333 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7334 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7335 All callers changed.
7337 * w32.c (_wsa_errlist): Use braces for struct initializers.
7339 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7340 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7341 All callers changed.
7342 (string_buffer_position): Likewise. Also, make static (it's never
7343 used outside xdisp.c).
7344 (cursor_row_p): Remove parameter `w', unused since
7345 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7346 (decode_mode_spec): Remove parameter `precision', introduced during
7347 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7348 All callers changed.
7350 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7352 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7354 2011-03-27 Anders Lindgren <andlind@gmail.com>
7356 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7357 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7358 (ns_update_auto_hide_menu_bar): New functions.
7359 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7360 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7361 ns_constrain_all_frames.
7362 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7363 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7365 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7367 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7369 2011-03-27 Glenn Morris <rgm@gnu.org>
7371 * syssignal.h: Replace RETSIGTYPE with void.
7372 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7373 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7374 Replace SIGTYPE with void everywhere.
7375 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7376 * s/template.h (SIGTYPE): Remove commented out definition.
7378 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7380 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7381 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7383 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7385 * w32.c (read_unc_volume): Use parameter `henum', instead of
7386 global variable `wget_enum_handle'.
7388 * keymap.c (describe_vector): Remove parameters `indices' and
7389 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7390 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7392 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7394 * keyboard.c (timer_check): Remove parameter `do_it_now',
7395 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7396 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7397 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7399 * keyboard.c (read_char):
7400 * w32menu.c (w32_menu_display_help):
7401 * xmenu.c (show_help_event, menu_help_callback):
7402 Adjust calls to `show_help_echo'.
7404 * gtkutil.c (xg_maybe_add_timer):
7405 * keyboard.c (readable_events):
7406 * process.c (wait_reading_process_output):
7407 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7409 * insdel.c (adjust_markers_gap_motion):
7410 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7411 (gap_left, gap_right): Don't call it.
7413 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7415 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7416 incurred during fontification.
7418 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7420 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7421 (DEFVAR_PER_BUFFER): Don't pass it.
7423 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7424 (scrolling_window): Don't pass it.
7426 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7428 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7430 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7432 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7433 of variables specific to SELinux and computation of `encoded_absname'.
7435 * image.c (XPutPixel): Remove unused variable `height'.
7437 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7439 * unexw32.c (get_section_info): Remove unused variable `section'.
7441 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7442 (system_process_attributes): Remove unused variable `sess'.
7443 (sys_read): Remove unused variable `err'.
7445 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7446 (w32_wnd_proc): Remove unused variable `isdead'.
7447 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7448 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7449 (x_create_tip_frame): Remove unused variable `tem'.
7451 * w32inevt.c (w32_console_read_socket):
7452 Remove unused variable `no_events'.
7454 * w32term.c (x_draw_composite_glyph_string_foreground):
7455 Remove unused variable `width'.
7457 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7459 * w32term.c (x_set_glyph_string_clipping):
7460 Don't pass uninitialized region to CombineRgn.
7462 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7464 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7465 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7466 (Fx_close_connection): Remove unused variable `i'.
7468 * w32font.c (w32font_draw): Return number of glyphs.
7469 (w32font_open_internal): Remove unused variable `i'.
7470 (w32font_driver): Add missing initializer.
7472 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7473 (fill_in_menu): Remove unused variable `items_added'.
7475 * w32term.c (last_mouse_press_frame): Remove static global variable.
7476 (w32_clip_to_row): Remove unused variable `f'.
7477 (x_delete_terminal): Remove unused variable `i'.
7479 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7480 (NOTHING): Remove unused static global variable.
7481 (uniscribe_check_otf): Remove unused variable `table'.
7482 (uniscribe_font_driver): Add missing initializers.
7484 2011-03-23 Julien Danjou <julien@danjou.info>
7486 * term.c (Fsuspend_tty, Fresume_tty):
7487 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7488 * window.c (temp_output_buffer_show):
7489 * insdel.c (signal_before_change):
7490 * frame.c (Fhandle_switch_frame):
7491 * fileio.c (Fdo_auto_save):
7492 * emacs.c (Fkill_emacs):
7493 * editfns.c (save_excursion_restore):
7494 * cmds.c (internal_self_insert):
7495 * callint.c (Fcall_interactively):
7496 * buffer.c (Fkill_all_local_variables):
7497 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7499 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7500 unconditionnaly since it does the check itself.
7502 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7504 Fix more problems found by GCC 4.5.2's static checks.
7506 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7507 the first time through the loop, since we know p0 < p1 then.
7508 This also avoids a gcc -Wstrict-overflow warning.
7510 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7511 leading to a memory leak, possible in functions like
7512 load_charset_map_from_file that can allocate an unbounded number
7513 of objects (Bug#8318).
7515 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7516 that could (at least in theory) be that large.
7518 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7519 This is less likely to overflow, and avoids undefined behavior if
7520 overflow does occur. All callers changed. Use strtoul to scan
7521 for the unsigned long integer.
7522 (pint2hrstr): Simplify and tune code slightly.
7523 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7525 * scroll.c (do_scrolling): Work around GCC bug 48228.
7526 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7528 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7529 This also avoids a warning with gcc -Wstrict-overflow.
7530 (validate_x_resource_name): Simplify count usage.
7531 This also avoids a warning with gcc -Wstrict-overflow.
7533 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7536 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7538 * process.c (Fmake_network_process): Use socklen_t, not int,
7539 where POSIX says socklen_t is required in portable programs.
7540 This fixes a porting bug on hosts like 64-bit HP-UX, where
7541 socklen_t is wider than int (Bug#8277).
7542 (Fmake_network_process, server_accept_connection):
7543 (wait_reading_process_output, read_process_output):
7546 * process.c: Rename or move locals to avoid shadowing.
7547 (list_processes_1, Fmake_network_process):
7548 (read_process_output_error_handler, exec_sentinel_error_handler):
7549 Rename or move locals.
7550 (Fmake_network_process): Define label "retry_connect" only if needed.
7551 (Fnetwork_interface_info): Fix pointer signedness.
7552 (process_send_signal): Add cast to avoid pointer signedness problem.
7553 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7554 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7556 Make tparam.h and terminfo.c consistent.
7557 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7558 Include tparam.h instead, since it declares them.
7559 * cm.h (PC): Remove extern decl; tparam.h now does this.
7560 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7561 * terminfo.c: Include tparam.h, to check interfaces.
7562 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7563 (tparam): Adjust signature to match interface in tparam.h;
7564 this removes some undefined behavior. Check that outstring and len
7565 are zero, which they always are with Emacs.
7566 * tparam.h (PC, BC, UP): New extern decls.
7568 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7569 (xftfont_open): Rename locals to avoid shadowing.
7571 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7572 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7573 (OTF_TAG_SYM): Omit macro if not needed.
7574 (ftfont_list): Remove unused local.
7575 (get_adstyle_property, ftfont_pattern_entity):
7576 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7577 Rename locals to avoid shadowing.
7579 * xfont.c (xfont_list_family): Mark var as initialized.
7581 * xml.c (make_dom): Now static.
7583 * composite.c (composition_compute_stop_pos): Rename local to
7585 (composition_reseat_it): Remove unused locals.
7586 (find_automatic_composition, composition_adjust_point): Likewise.
7587 (composition_update_it): Mark var as initialized.
7588 (find_automatic_composition): Mark vars as initialized,
7589 with a FIXME (Bug#8290).
7591 character.h: Rename locals to avoid shadowing.
7592 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7593 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7594 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7595 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7598 * textprop.c (property_change_between_p): Remove; unused.
7600 * intervals.c (interval_start_pos): Now static.
7602 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7604 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7605 Rename locals to avoid shadowing.
7607 * sound.c (wav_play, au_play, Fplay_sound_internal):
7608 Fix pointer signedness.
7609 (alsa_choose_format): Remove unused local var.
7610 (wav_play): Initialize a variable to 0, to prevent undefined
7611 behavior (Bug#8278).
7613 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7615 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7617 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7618 clobbering (Bug#8298).
7619 * sysdep.c (sys_subshell): Likewise.
7620 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7622 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7623 This should get cleaned up, so that child_setup has the
7624 same signature on all platforms.
7626 * callproc.c (call_process_cleanup): Now static.
7627 (relocate_fd): Rename locals to avoid shadowing.
7629 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7631 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7632 not to be necessary, and produces flickering.
7634 2011-03-20 Glenn Morris <rgm@gnu.org>
7636 * config.in: Remove file.
7638 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7640 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7641 are now in src/globals.h.
7642 (syms_of_minibuf): Remove spurious & from previous change.
7644 2011-03-20 Leo <sdl.web@gmail.com>
7646 * minibuf.c (completing-read-function): New variable.
7647 (completing-read-default): Rename from completing-read.
7648 (completing-read): Call completing-read-function.
7650 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7652 * xfaces.c (Fx_load_color_file):
7653 Read color file from absolute filename (bug#8250).
7655 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7657 * makefile.w32-in: Update dependencies.
7659 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7661 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7663 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7665 Fix more problems found by GCC 4.5.2's static checks.
7667 * process.c (make_serial_process_unwind, send_process_trap):
7668 (sigchld_handler): Now static.
7670 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7671 That way, the code declares only the vars that it needs.
7672 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7673 * s/cygwin.h (PTY_ITERATION): Likewise.
7674 * s/darwin.h (PTY_ITERATION): Likewise.
7675 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7677 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7678 * process.c (allocate_pty): Don't declare stb unless it's needed.
7680 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7681 (CONSTANTLIM): Remove; unused.
7682 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7683 Define only if needed.
7685 * unexelf.c (unexec): Name an expression,
7686 to avoid gcc -Wbad-function-cast warning.
7687 Use a different way to cause a compilation error if anyone uses
7688 n rather than nn, a way that does not involve shadowing.
7689 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7691 * deps.mk (unexalpha.o): Remove; unused.
7693 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7694 * unexec.h: New file.
7695 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7696 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7698 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7699 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7700 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7701 Change as necessary to match prototype in unexec.h.
7703 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7705 (back_comment, skip_chars): Mark vars as initialized.
7707 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7708 Rename locals to avoid shadowing.
7710 * lread.c (read1): Rewrite so as not to use empty "else".
7711 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7713 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7715 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7716 warning when compiling print.c.
7718 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7719 instead of using an uninitialized var.
7720 (font_sort_entities): Mark var as initialized.
7722 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7724 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7725 pointers to constants.
7726 (font_parse_fcname): Remove unused vars.
7727 (font_delete_unmatched): Now static.
7728 (font_get_spec): Remove; unused.
7729 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7730 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7731 Rename or move locals to avoid shadowing.
7733 * fns.c (require_nesting_list, require_unwind): Now static.
7734 (Ffillarray): Rename locals to avoid shadowing.
7736 * floatfns.c (domain_error2): Define only if needed.
7737 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7739 * alloc.c (mark_backtrace): Move decl from here ...
7740 * lisp.h: ... to here, so that it can be checked.
7742 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7743 (Fdefvar): Rewrite so as not to use empty "else".
7744 (lisp_indirect_variable): Name an expression,
7745 to avoid gcc -Wbad-function-cast warning.
7746 (Fdefvar): Rename locals to avoid shadowing.
7748 * callint.c (quotify_arg, quotify_args): Now static.
7749 (Fcall_interactively): Rename locals to avoid shadowing.
7750 Use const pointer when appropriate.
7752 * lisp.h (get_system_name, get_operating_system_release):
7753 Move decls here, to check interfaces.
7754 * process.c (get_operating_system_release): Move decl to lisp.h.
7755 * xrdb.c (get_system_name): Likewise.
7756 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7757 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7758 some of which prompt warnings from gcc -Wbad-function-cast.
7759 (Fformat_time_string, Fencode_time, Finsert_char):
7760 (Ftranslate_region_internal, Fformat):
7761 Rename or remove local vars to avoid shadowing.
7762 (Ftranslate_region_internal): Mark var as initialized.
7764 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7767 * lisp.h (eassert): Check that the argument compiles, even if
7768 ENABLE_CHECKING is not defined.
7770 * data.c (Findirect_variable): Name an expression, to avoid
7771 gcc -Wbad-function-cast warning.
7772 (default_value, arithcompare, arith_driver, arith_error): Now static.
7773 (store_symval_forwarding): Rename local to avoid shadowing.
7774 (Fmake_variable_buffer_local, Fmake_local_variable):
7775 Mark variables as initialized.
7776 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7778 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7779 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7780 Rename locals to avoid shadowing.
7781 (mark_stack): Move local variables into the #ifdef region where
7783 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7784 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7786 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7787 (GC_STRING_CHARS): Remove; not used.
7788 (Fmemory_limit): Cast sbrk's returned value to char *.
7790 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7791 avoids undefined behavior in theory.
7793 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7795 Use functions, not macros, for up- and down-casing (Bug#8254).
7796 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7797 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7798 to use the following functions instead of these macros.
7799 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7800 EMACS_INT, since callers assume the returned value fits in int.
7801 (upcase1): Likewise, for UPCASE_TABLE.
7802 (uppercasep, lowercasep, upcase): New static inline functions.
7803 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7804 the race-condition problem in the old DOWNCASE.
7806 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7807 Rename locals to avoid shadowing.
7808 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7809 (regex_compile, re_search_2, re_match_2_internal):
7810 Remove unused local vars.
7811 (FREE_VAR): Rewrite so as not to use empty "else",
7812 which gcc can warn about.
7813 (regex_compile, re_match_2_internal): Mark locals as initialized.
7814 (RETALLOC_IF): Define only if needed.
7815 (WORDCHAR_P): Likewise. This one is never needed, but is used
7816 only in a comment talking about a compiler bug, so put inside
7817 the #if 0 of that comment.
7818 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7819 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7822 * search.c (boyer_moore): Rename locals to avoid shadowing.
7823 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7824 (PREV_CHAR_BOUNDARY): Likewise.
7826 * search.c (simple_search): Remove unused var.
7828 * dired.c (compile_pattern): Move decl from here ...
7829 * lisp.h: ... to here, so that it can be checked.
7830 (struct re_registers): New forward decl.
7832 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7834 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7836 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7837 Rename locals to avoid shadowing.
7838 (Fvertical_motion): Mark locals as initialized.
7840 * casefiddle.c (casify_object, casify_region): Now static.
7841 (casify_region): Mark local as initialized.
7843 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7845 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7846 New macros, so that the caller can use some names other than
7847 gcpro1, gcpro2, etc.
7848 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7850 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7851 argument, for consistency with GCPRO2_VAR, etc: it is now the
7852 prefix of the variable, not the variable itself. All uses
7854 * dired.c (directory_files_internal, file_name_completion):
7855 Rename locals to avoid shadowing.
7857 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7858 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7859 dired.c's scmp function, had undefined behavior.
7860 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7861 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7862 * buffer.h: ... to here, because these macros use current_buffer,
7863 and the new implementation with inline functions needs to have
7864 current_buffer in scope now, rather than later when the macros
7866 (downcase, upcase1): New static inline functions.
7867 (DOWNCASE, UPCASE1): Reimplement using these functions.
7868 This avoids undefined behavior in expressions like
7869 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7870 from race conditions in accessing the global variables
7871 case_temp1 and case_temp2.
7872 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7873 * lisp.h (case_temp1, case_temp2): Remove their decls.
7874 * character.h (ASCII_CHAR_P): Move from here ...
7875 * lisp.h: ... to here, so that the inline functions mentioned
7878 * dired.c (directory_files_internal_unwind): Now static.
7880 * fileio.c (file_name_as_directory, directory_file_name):
7881 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7883 (file_name_as_directory): Use const pointers when appropriate.
7884 (Fexpand_file_name): Likewise. In particular, newdir might
7885 point at constant storage, so make it a const pointer.
7886 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7887 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7889 (Fset_file_times, Finsert_file_contents, auto_save_error):
7890 Rename locals to avoid shadowing.
7892 * minibuf.c (choose_minibuf_frame_1): Now static.
7893 (Ftry_completion, Fall_completions): Rename or remove locals
7896 * marker.c (bytepos_to_charpos): Remove; unused.
7898 * lisp.h (verify_bytepos, count_markers): New decls,
7899 so that gcc does not warn that these functions aren't declared.
7901 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7902 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7903 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7904 (copy_text): Remove unused local var.
7906 * filelock.c (within_one_second): Now static.
7907 (lock_file_1): Rename local to avoid shadowing.
7909 * buffer.c (fix_overlays_before): Mark locals as initialized.
7910 (fix_start_end_in_overlays): Likewise. This function should be
7911 simplified by using pointers-to-pointers, but that's a different
7913 (switch_to_buffer_1): Now static.
7914 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7915 (report_overlay_modification): Rename locals to avoid shadowing.
7917 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7918 Fix pointer signedness issue.
7919 (sys_subshell): Mark local as volatile if checking for lint,
7920 to suppress a gcc -Wclobbered warning that does not seem to be right.
7921 (MAXPATHLEN): Define only if needed.
7923 * process.c (serial_open, serial_configure): Move decls from here ...
7924 * systty.h: ... to here, so that they can be checked.
7926 * fns.c (get_random, seed_random): Move extern decls from here ...
7927 * lisp.h: ... to here, so that they can be checked.
7929 * sysdep.c (reset_io): Now static.
7930 (wait_for_termination_signal): Remove; unused.
7932 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7933 (copy_keymap_item, append_key, push_text_char_description):
7935 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7936 (DENSE_TABLE_SIZE): Remove; unused.
7937 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7938 (describe_map_tree):
7939 Rename locals to avoid shadowing.
7941 * keyboard.c: Declare functions static if they are not used elsewhere.
7942 (echo_char, echo_dash, cmd_error, top_level_2):
7943 (poll_for_input, handle_async_input): Now static.
7944 (read_char, kbd_buffer_get_event, make_lispy_position):
7945 (make_lispy_event, make_lispy_movement, apply_modifiers):
7946 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7947 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7948 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7949 (read_key_sequence, read_char): Mark locals as initialized.
7950 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7952 * keyboard.h (make_ctrl_char): New decl.
7953 (mark_kboards): Move decl here ...
7954 * alloc.c (mark_kboards): ... from here.
7956 * lisp.h (force_auto_save_soon): New decl.
7958 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7959 (DEFINE_DUMMY_FUNCTION): New macro.
7960 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7962 (main): Add casts to avoid warnings
7963 if GCC considers string literals to be constants.
7965 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7967 * dbusbind.c: Pointer signedness fixes.
7968 (xd_signature, xd_append_arg, xd_initialize):
7969 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7970 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7971 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7972 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7974 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7975 if GCC considers string literals to be constants.
7976 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7978 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7980 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7981 (print_preprocess, print_object): New macro to fix last change.
7983 * print.c (print_preprocess): Don't forget font objects.
7985 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7987 * emacs.c (USAGE3): Doc fixes.
7989 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7991 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7994 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7996 * lisp.h (VWindow_system, Qfile_name_history):
7997 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7998 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7999 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8001 * w32select.c: Don't #include "keyboard.h".
8002 (run_protected): Add extern declaration for waiting_for_input.
8004 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8005 * w32console.c (detect_input_pending, read_input_pending)
8006 (encode_terminal_code):
8007 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8008 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8009 (w32_system_caret_y, Qfile_name_history):
8010 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8011 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8012 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8013 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8014 * w32proc.c (Qlocal, report_file_error):
8015 * w32term.c (Vwindow_system, updating_frame):
8016 * w32uniscribe.c (initialized, uniscribe_font_driver):
8017 Remove unneeded extern declarations.
8019 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8021 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8023 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8025 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8026 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8027 These macros can no longer be used for assignment.
8029 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8030 Assign struct members directly, instead of using BUF_BEGV etc.
8031 (record_buffer_markers, fetch_buffer_markers): New functions for
8032 recording and fetching special buffer markers.
8033 (set_buffer_internal_1, set_buffer_temp): Use them.
8035 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8037 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8039 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8040 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8042 * xdisp.c (hscroll_window_tree):
8043 (reconsider_clip_changes): Use PT instead of BUF_PT.
8045 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8047 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8048 $(EMACS_ROOT)/lib/intprops.h.
8050 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8052 Fix more problems found by GCC 4.5.2's static checks.
8054 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8055 to unsigned char * to avoid compiler diagnostic.
8056 (xg_free_frame_widgets): Make it clear that a local variable is
8057 needed only if USE_GTK_TOOLTIP.
8058 (gdk_window_get_screen): Make it clear that this macro is needed
8059 only if USE_GTK_TOOLTIP.
8060 (int_gtk_range_get_value): New function, which avoids a diagnostic
8061 from gcc -Wbad-function-cast.
8062 (xg_set_toolkit_scroll_bar_thumb): Use it.
8063 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8064 diagnostic from gcc -Wbad-function-cast.
8065 (get_utf8_string, xg_get_file_with_chooser):
8066 Rename locals to avoid shadowing.
8067 (create_dialog): Move locals to avoid shadowing.
8069 * xgselect.c (xg_select): Remove unused var.
8071 * image.c (four_corners_best): Mark locals as initialized.
8072 (gif_load): Initialize transparent_p to zero (Bug#8238).
8073 Mark another local as initialized.
8074 (my_png_error, my_error_exit): Mark with NO_RETURN.
8076 * image.c (clear_image_cache): Now static.
8077 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8078 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8079 (x_edge_detection): Remove unnecessary cast that
8080 gcc -Wbad-function-cast diagnoses.
8081 (gif_load): Fix pointer signedness.
8082 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8083 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8085 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8087 Improve quality of tests for time stamp overflow.
8088 For example, without this patch (encode-time 0 0 0 1 1
8089 1152921504606846976) returns the obviously-bogus value (-948597
8090 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8091 reports time overflow. See
8092 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8093 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8094 * editfns.c: Include limits.h and intprops.h.
8095 (TIME_T_MIN, TIME_T_MAX): New macros.
8096 (time_overflow): Move earlier, to before first use.
8097 (hi_time, lo_time): New functions, for an accurate test for
8099 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8100 (Fget_internal_run_time): Don't assume time_t fits in int.
8101 (make_time): Use list2 instead of Fcons twice.
8102 (Fdecode_time): More accurate test for out-of-range times.
8103 (check_tm_member): New function.
8104 (Fencode_time): Use it, to test for out-of-range times.
8105 (lisp_time_argument): Don't rely on undefined left-shift and
8106 right-shift behavior when checking for time stamp overflow.
8108 * editfns.c (time_overflow): New function, refactoring common code.
8109 (Fformat_time_string, Fdecode_time, Fencode_time):
8110 (Fcurrent_time_string): Use it.
8112 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8113 * dired.c (make_time): Move to ...
8114 * editfns.c (make_time): ... here.
8115 * systime.h: Note the move.
8117 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8119 * fringe.c (update_window_fringes): Remove unused variables.
8121 * unexmacosx.c (copy_data_segment): Also copy __got section.
8124 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8126 * termcap.c [MSDOS]: Include "msdos.h".
8127 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8128 Constify `char *' arguments and their references according to
8129 prototypes in tparam.h.
8131 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8133 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8134 Adapt all references accordingly.
8136 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8138 2011-03-11 Tom Tromey <tromey@redhat.com>
8140 * buffer.c (syms_of_buffer): Remove obsolete comment.
8142 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8144 * termhooks.h (encode_terminal_code): Declare prototype.
8146 * msdos.c (encode_terminal_code): Don't declare prototype.
8148 * term.c (encode_terminal_code): Now external again, used by
8149 w32console.c and msdos.c.
8151 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8152 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8154 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8156 Fix some minor problems found by GCC 4.5.2's static checks.
8158 * fringe.c (update_window_fringes): Mark locals as initialized
8160 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8162 * alloc.c (mark_fringe_data): Move decl from here ...
8163 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8164 to check its interface.
8165 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8167 * fontset.c (free_realized_fontset): Now static.
8168 (Fset_fontset_font): Rename local to avoid shadowing.
8169 (fontset_font): Mark local as initialized.
8170 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8172 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8174 * xselect.c (x_disown_buffer_selections): Remove; not used.
8175 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8176 (x_own_selection, Fx_disown_selection_internal): Rename locals
8178 (x_handle_dnd_message): Remove local to avoid shadowing.
8180 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8181 so that the caller can use some name other than gcpro1.
8182 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8183 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8184 (Fx_backspace_delete_keys_p):
8185 Use them to avoid shadowing, and rename vars to avoid shadowing.
8186 (x_decode_color, x_set_name, x_window): Now static.
8187 (Fx_create_frame): Add braces to silence GCC warning.
8188 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8189 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8190 Remove unused locals.
8191 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8192 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8193 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8196 * xterm.h (x_mouse_leave): New decl.
8198 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8199 Remove unused functions.
8200 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8201 (x_calc_absolute_position): Now static.
8202 (XTread_socket): Don't define label "out" unless it's used.
8203 Don't declare local "event" unless it's used.
8204 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8205 unless they are used.
8206 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8207 (x_fatal_error_signal): Remove; not used.
8208 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8209 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8210 (x_error_catcher, x_connection_closed, x_error_handler):
8211 (x_error_quitter, xembed_send_message, x_iconify_frame):
8212 (my_log_handler): Rename locals to avoid shadowing.
8213 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8214 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8216 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8217 Rename or move locals to avoid shadowing.
8218 (tty_defined_color, merge_face_heights): Now static.
8219 (free_realized_faces_for_fontset): Remove; not used.
8220 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8221 does not deduce is never used uninitialized.
8222 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8223 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8225 * terminal.c (store_terminal_param): Now static.
8227 * xmenu.c (menu_highlight_callback): Now static.
8228 (set_frame_menubar): Remove unused local.
8229 (xmenu_show): Rename parameter to avoid shadowing.
8230 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8231 since they might point to immutable storage.
8232 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8233 since it's unused otherwise.
8235 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8236 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8237 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8238 avoids a gcc -Wuninitialized diagnostic.
8239 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8240 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8241 does not deduce are never used uninitialized.
8243 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8245 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8246 * window.c (window_loop, size_window):
8247 (run_window_configuration_change_hook, enlarge_window): Likewise.
8249 * window.c (display_buffer): Now static.
8250 (size_window): Mark variables that gcc -Wuninitialized
8251 does not deduce are never used uninitialized.
8252 * window.h (check_all_windows): New decl, to forestall
8253 gcc -Wmissing-prototypes diagnostic.
8254 * dispextern.h (bidi_dump_cached_states): Likewise.
8256 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8258 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8260 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8261 and to avoid gcc -Wuninitialized warning.
8262 (load_charset_map): Mark variables that gcc -Wuninitialized
8263 does not deduce are never used uninitialized.
8264 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8266 * coding.c (coding_set_source, coding_set_destination):
8267 Use "else { /* comment */ }" rather than "else /* comment */;"
8268 for clarity, and to avoid gcc -Wempty-body warning.
8269 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8270 a block, when the outer 'i' will do.
8271 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8272 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8273 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8274 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8275 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8276 Rename locals to avoid shadowing.
8277 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8278 * coding.c (emacs_mule_char, encode_invocation_designation):
8279 Now static, since they're not used elsewhere.
8280 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8281 (decode_coding_object, encode_coding_object, detect_coding_system):
8282 (decode_coding_emacs_mule): Mark variables that gcc
8283 -Wuninitialized does not deduce are never used uninitialized.
8284 (detect_coding_iso_2022): Initialize a local variable that might
8285 be used uninitialized. Leave a FIXME because it's not clear that
8286 this initialization is needed. (Bug#8211)
8287 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8288 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8289 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8290 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8291 Remove unused macros.
8293 * category.c (hash_get_category_set): Remove unused local var.
8294 (copy_category_table): Now static, since it's not used elsewhere.
8295 * character.c (string_count_byte8): Likewise.
8297 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8298 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8300 * chartab.c (copy_sub_char_table): Now static, since it's not used
8302 (sub_char_table_ref_and_range, char_table_ref_and_range):
8303 Rename locals to avoid shadowing.
8304 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8306 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8307 (BIDI_BOB): Remove unused macro.
8309 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8310 deduce are never used uninitialized.
8311 * term.c (encode_terminal_code): Likewise.
8313 * term.c (encode_terminal_code): Now static. Remove unused local.
8315 * tparam.h: New file.
8316 * term.c, tparam.h: Include it.
8317 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8318 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8319 Move these decls to tparam.h, and make them agree with what
8320 is actually in tparam.c. The previous trick of using incompatible
8321 decls in different modules does not conform to the C standard.
8322 All callers of tparam changed to use tparam's actual API.
8323 * tparam.c (tparam1, tparam, tgoto):
8324 Use const pointers where appropriate.
8326 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8327 * cm.h (struct cm): Likewise.
8328 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8329 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8330 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8331 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8332 (turn_on_face, init_tty): Likewise.
8333 * termchar.h (struct tty_display_info): Likewise.
8335 * term.c (term_mouse_position): Rename local to avoid shadowing.
8337 * alloc.c (mark_ttys): Move decl from here ...
8338 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8340 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8342 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8344 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8346 * search.c (compile_pattern_1): Remove argument regp, unused since
8347 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8348 (compile_pattern): Don't pass it.
8350 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8352 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8353 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8355 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8357 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8359 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8360 gdk_window_get_screen, gdk_window_get_geometry,
8361 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8362 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8363 (xg_get_pixbuf_from_pixmap): New function.
8364 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8365 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8366 Call xg_get_pixbuf_from_pixmap instead of
8367 gdk_pixbuf_get_from_drawable.
8368 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8369 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8370 (xg_check_special_colors): Use GtkStyleContext and its functions
8372 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8373 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8374 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8375 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8376 Call gtk_widget_get_preferred_size.
8377 (xg_frame_resized): gdk_window_get_geometry only takes 5
8379 (xg_win_to_widget, xg_event_is_for_menubar):
8380 Call gdk_x11_window_lookup_for_display.
8381 (xg_set_widget_bg): New function.
8382 (delete_cb): New function.
8383 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8384 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8385 (xg_set_background_color): Call xg_set_widget_bg.
8386 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8387 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8388 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8389 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8391 (update_frame_tool_bar): Call gtk_widget_hide.
8392 (xg_initialize): Use GDK_KEY_g.
8394 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8396 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8398 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8399 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8400 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8402 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8404 * w32xfns.c (select_palette): Check success of RealizePalette against
8405 GDI_ERROR, not zero.
8407 See ChangeLog.11 for earlier changes.
8413 Copyright (C) 2011 Free Software Foundation, Inc.
8415 This file is part of GNU Emacs.
8417 GNU Emacs is free software: you can redistribute it and/or modify
8418 it under the terms of the GNU General Public License as published by
8419 the Free Software Foundation, either version 3 of the License, or
8420 (at your option) any later version.
8422 GNU Emacs is distributed in the hope that it will be useful,
8423 but WITHOUT ANY WARRANTY; without even the implied warranty of
8424 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8425 GNU General Public License for more details.
8427 You should have received a copy of the GNU General Public License
8428 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.