1 2011-04-08 Svante Signell <svante.signell@telia.com> (tiny change)
3 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7 * process.c (Fformat_network_address): Doc fix.
9 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
13 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
15 * keyboard.c (read_char): Call Lisp function help-form-show,
16 instead of using internal_with_output_to_temp_buffer.
17 (Qhelp_form_show): New var.
18 (syms_of_keyboard): Use DEFSYM macro.
20 * print.c (internal_with_output_to_temp_buffer): Function deleted.
22 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
24 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
26 * process.c (Flist_processes): Removed to Lisp.
27 (list_processes_1): Deleted.
29 2011-04-06 Eli Zaretskii <eliz@gnu.org>
31 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
33 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
35 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
37 Fix more problems found by GCC 4.6.0's static checks.
39 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
41 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
43 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
45 * xdisp.c (vmessage): Mark as a printf-like function.
47 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
49 * sound.c (sound_warning): Don't crash if arg contains a printf format.
51 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
52 printf-like functions.
53 (tiff_load): Add casts to remove these marks before passing them
54 to system-supplied API.
56 * eval.c (Fsignal): Remove excess argument to 'fatal'.
58 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
59 This avoids several warnings with gcc -Wstrict-overflow.
60 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
61 directly, rather than having caller test rule sign. This avoids
62 some unnecessary tests.
63 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
64 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
65 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
67 * xfont.c (xfont_text_extents): Remove var that was set but not used.
68 (xfont_open): Avoid unnecessary tests.
70 * composite.c (composition_gstring_put_cache): Use unsigned integer.
72 * composite.h, composite.c (composition_gstring_put_cache):
73 Use EMACS_INT, not int, for length.
75 * composite.h (COMPOSITION_DECODE_REFS): New macro,
76 breaking out part of COMPOSITION_DECODE_RULE.
77 (COMPOSITION_DECODE_RULE): Use it.
78 * composite.c (get_composition_id): Remove unused local vars,
79 by using the new macro.
81 * textprop.c (set_text_properties_1): Change while to do-while,
82 since the condition is always true at first.
84 * intervals.c (graft_intervals_into_buffer): Mark var as used.
85 (interval_deletion_adjustment): Return unsigned value.
88 * process.c (list_processes_1, create_pty, read_process_output):
89 (exec_sentinel): Remove vars that were set but not used.
90 (create_pty): Remove unnecessary "volatile"s.
91 (Fnetwork_interface_info): Avoid possibility of int overflow.
92 (read_process_output): Do adaptive read buffering even if carryover.
93 (read_process_output): Simplify nbytes computation if buffered.
95 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
97 * syntax.c (scan_words): Remove var that was set but not used.
98 (update_syntax_table): Use unsigned instead of int.
100 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
101 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
102 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
104 * print.c (print_error_message): Avoid int overflow.
106 * font.c (font_list_entities): Redo for clarity,
107 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
109 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
110 (font_score): Avoid potential overflow in diff calculation.
112 * fns.c (substring_both): Remove var that is set but not used.
113 (sxhash): Redo loop for clarity and to avoid wraparound warning.
115 * eval.c (funcall_lambda): Rename local to avoid shadowing.
117 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
118 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
119 can always succeed if overflow has undefined behavior.
121 * search.c (boyer_moore, wordify): Remove vars set but not used.
122 (wordify): Omit three unnecessary tests.
124 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
125 All callers changed. This avoids the need for an unused var.
127 * casefiddle.c (casify_region): Remove var that is set but not used.
129 * dired.c (file_name_completion): Remove var that is set but not used.
131 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
133 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
134 (Finsert_file_contents): Remove unnecessary code checking fd.
136 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
137 Check for integer overflow on size calculations.
139 * buffer.c (Fprevious_overlay_change): Remove var that is set
142 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
143 Remove vars that are set but not used.
144 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
145 (timer_check_2): Mark vars as initialized.
147 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
149 * image.c (lookup_image): Remove var that is set but not used.
150 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
152 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
153 that are set but not used.
155 * xfns.c (make_invisible_cursor): Don't return garbage
156 if XCreateBitmapFromData fails (Bug#8410).
158 * xselect.c (x_get_local_selection, x_handle_property_notify):
159 Remove vars that are set but not used.
161 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
162 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
164 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
165 Remove var that is set but not used.
166 (scroll_bar_windows_size): Now size_t, not int.
167 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
170 * xfaces.c (realize_named_face): Remove vars that are set but not used.
171 (map_tty_color) [!defined MSDOS]: Likewise.
173 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
175 * coding.c: Remove vars that are set but not used.
176 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
178 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
179 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
180 (decode_coding_charset): Remove vars that are set but not used.
182 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
183 that is set but not used.
185 * print.c (print_object): Remove var that is set but not used.
187 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
188 The gnulib version avoids calling malloc in the usual case,
189 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
190 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
191 * filelock.c (current_lock_owner): Likewise.
192 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
193 * sysdep.c: Include allocator.h, careadlinkat.h.
194 (emacs_no_realloc_allocator): New static constant.
195 (emacs_readlink): New function.
196 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
197 ../lib/careadlinkat.h.
199 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
201 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
202 first non-nil return value).
204 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
206 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
207 if not defined (Bug#8403).
209 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
211 * xdisp.c (display_count_lines): Remove parameter `start',
212 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
213 (get_char_face_and_encoding): Remove parameter `multibyte_p',
214 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
215 (fill_stretch_glyph_string): Remove parameters `row' and `area',
216 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
217 and thereabouts. All callers changed.
218 (get_per_char_metric): Remove parameter `f', unused since
219 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
221 2011-04-02 Jim Meyering <meyering@redhat.com>
223 do not dereference NULL upon failed strdup
224 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
225 (ns_get_family): Likewise.
227 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
229 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
231 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
233 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
236 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
240 * window.c (Ftemp_output_buffer_show): New fun.
241 (Fsave_window_excursion):
242 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
244 * lread.c (lisp_file_lexically_bound_p): New function.
245 (Fload): Bind Qlexical_binding.
246 (readevalloop): Remove `evalfun' arg.
247 Bind Qinternal_interpreter_environment.
248 (Feval_buffer): Bind Qlexical_binding.
249 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
251 (syms_of_lread): Declare `lexical-binding'.
253 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
255 * keyboard.c (eval_dyn): New fun.
256 (menu_item_eval_property): Use it.
258 * image.c (parse_image_spec): Use Ffunctionp.
260 * fns.c (concat, mapcar1): Accept byte-code-functions.
262 * eval.c (Fsetq): Handle lexical vars.
263 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
264 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
265 (FletX, Flet): Obey lexical binding.
266 (Fcommandp): Handle closures.
267 (Feval): New `lexical' arg.
268 (eval_sub): New function extracted from Feval. Use it almost
269 everywhere where Feval was used. Look up vars in lexical env.
271 (Ffunctionp): Move from subr.el.
272 (Ffuncall): Handle closures.
273 (apply_lambda): Remove `eval_flags'.
274 (funcall_lambda): Handle closures and new byte-code-functions.
275 (Fspecial_variable_p): New function.
276 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
277 but without exporting it to Lisp.
279 * doc.c (Fdocumentation, store_function_docstring):
280 * data.c (Finteractive_form): Handle closures.
282 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
285 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
287 (exec_byte_code): New function extracted from Fbyte_code to handle new
288 calling convention for byte-code-functions. Add new byte-codes.
290 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
292 * alloc.c (Fmake_symbol): Init new `declared_special' field.
294 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
296 * xdisp.c (redisplay_internal): Fix prototype.
298 2011-03-31 Eli Zaretskii <eliz@gnu.org>
300 * xdisp.c (SCROLL_LIMIT): New macro.
301 (try_scrolling): Use it when setting scroll_limit. Limit
302 scrolling to 100 screen lines.
303 (redisplay_window): Even when falling back on "recentering",
304 position point in the window according to scroll-conservatively,
305 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
307 (try_scrolling): When point is above the window, allow searching
308 as far as scroll_max, or one screenful, to compute vertical
309 distance from PT to the scroll margin position. This prevents
310 try_scrolling from unnecessarily failing when
311 scroll-conservatively is set to a value slightly larger than the
312 window height. Clean up the case of PT below the margin at bottom
313 of window: scroll_max can no longer be INT_MAX. When aggressive
314 scrolling is in use, don't let point enter the opposite scroll
315 margin as result of the scroll.
316 (syms_of_xdisp) <scroll-conservatively>: Document the
317 threshold of 100 lines for never-recentering scrolling.
319 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
321 * dispextern.h (move_it_by_lines):
322 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
323 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
324 (message_log_check_duplicate): Remove parameters `prev_bol' and
325 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
326 (redisplay_internal): Remove parameter `preserve_echo_area',
327 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
329 * indent.c (Fvertical_motion):
330 * window.c (window_scroll_pixel_based, Frecenter):
331 Don't pass `need_y_p' to `move_it_by_lines'.
333 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
335 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
336 steal a few bits to be more compact.
337 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
338 Remove unneeded casts.
340 * bytecode.c (Fbyte_code): CAR and CDR can GC.
342 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
344 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
345 binding" message (bug#7967).
347 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
349 Fix more problems found by GCC 4.6.0's static checks.
351 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
352 Remove unused local var.
354 * editfns.c (Fmessage_box): Remove unused local var.
356 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
357 (note_mode_line_or_margin_highlight, note_mouse_highlight):
358 Omit unused local vars.
359 * window.c (shrink_windows): Omit unused local var.
360 * menu.c (digest_single_submenu): Omit unused local var.
361 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
362 Omit unused local var.
364 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
365 Don't assume string length fits in int.
366 (keyremap_step, read_key_sequence): Use size_t for sizes.
367 (read_key_sequence): Don't check last_real_key_start redundantly.
369 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
370 instead of alloca (Bug#8344).
372 * eval.c (Fbacktrace): Don't assume nargs fits in int.
373 (Fbacktrace_frame): Don't assume nframes fits in int.
375 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
377 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
380 * term.c (produce_glyphless_glyph): Remove unnecessary test.
382 * cm.c (calccost): Turn while-do into do-while, for clarity.
384 * keyboard.c (syms_of_keyboard): Use the same style as later
385 in this function when indexing through an array. This also
386 works around GCC bug 48267.
388 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
390 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
392 * chartab.c (sub_char_table_ref_and_range): Redo for slight
393 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
395 * keyboard.c, keyboard.h (num_input_events): Now size_t.
396 This avoids undefined behavior on integer overflow, and is a bit
397 more convenient anyway since it is compared to a size_t variable.
399 Variadic C functions now count arguments with size_t, not int.
400 This avoids an unnecessary limitation on 64-bit machines, which
401 caused (substring ...) to crash on large vectors (Bug#8344).
402 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
403 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
404 All variadic functions and their callers changed accordingly.
405 (struct gcpro.nvars): Now size_t, not int. All uses changed.
406 * data.c (arith_driver, float_arith_driver): Likewise.
407 * editfns.c (general_insert_function): Likewise.
408 * eval.c (struct backtrace.nargs, interactive_p)
409 (internal_condition_case_n, run_hook_with_args, apply_lambda)
410 (funcall_lambda, mark_backtrace): Likewise.
411 * fns.c (concat): Likewise.
412 * frame.c (x_set_frame_parameters): Likewise.
413 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
414 0 if not found, not -1. All callers changed.
416 * alloc.c (garbage_collect): Don't assume stack size fits in int.
417 (stack_copy_size): Now size_t, not int.
418 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
420 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
422 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
423 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
426 * lisp.h (multibyte_char_to_unibyte):
427 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
428 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
429 * character.h (CHAR_TO_BYTE8):
430 * cmds.c (internal_self_insert):
431 * editfns.c (general_insert_function):
432 * keymap.c (push_key_description):
433 * search.c (Freplace_match):
434 * xdisp.c (message_dolog, set_message_1): All callers changed.
436 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
438 * keyboard.c (safe_run_hook_funcall): New function.
439 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
440 don't set the hook to nil, but remove the offending function instead.
441 (Qcommand_hook_internal): Remove, unused.
442 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
443 Vcommand_hook_internal.
445 * eval.c (enum run_hooks_condition): Remove.
446 (funcall_nil, funcall_not): New functions.
447 (run_hook_with_args): Call each function through a `funcall' argument.
448 Remove `cond' argument, now redundant.
449 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
450 (Frun_hook_with_args_until_failure): Adjust accordingly.
451 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
453 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
455 * dispextern.h (string_buffer_position): Remove declaration.
457 * print.c (strout): Remove parameter `multibyte', unused since
458 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
460 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
461 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
464 * w32.c (_wsa_errlist): Use braces for struct initializers.
466 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
467 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
469 (string_buffer_position): Likewise. Also, make static (it's never
470 used outside xdisp.c).
471 (cursor_row_p): Remove parameter `w', unused since
472 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
473 (decode_mode_spec): Remove parameter `precision', introduced during
474 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
477 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
479 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
481 2011-03-27 Anders Lindgren <andlind@gmail.com>
483 * nsterm.m (ns_menu_bar_is_hidden): New variable.
484 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
485 (ns_update_auto_hide_menu_bar): New functions.
486 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
487 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
488 ns_constrain_all_frames.
489 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
490 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
492 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
494 * nsmenu.m (runDialogAt): Remove argument to timer_check.
496 2011-03-27 Glenn Morris <rgm@gnu.org>
498 * syssignal.h: Replace RETSIGTYPE with void.
499 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
500 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
501 Replace SIGTYPE with void everywhere.
502 * s/usg5-4-common.h (SIGTYPE): Remove definition.
503 * s/template.h (SIGTYPE): Remove commented out definition.
505 2011-03-26 Eli Zaretskii <eliz@gnu.org>
507 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
508 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
510 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
512 * w32.c (read_unc_volume): Use parameter `henum', instead of
513 global variable `wget_enum_handle'.
515 * keymap.c (describe_vector): Remove parameters `indices' and
516 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
517 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
519 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
521 * keyboard.c (timer_check): Remove parameter `do_it_now',
522 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
523 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
524 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
526 * keyboard.c (read_char):
527 * w32menu.c (w32_menu_display_help):
528 * xmenu.c (show_help_event, menu_help_callback):
529 Adjust calls to `show_help_echo'.
531 * gtkutil.c (xg_maybe_add_timer):
532 * keyboard.c (readable_events):
533 * process.c (wait_reading_process_output):
534 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
536 * insdel.c (adjust_markers_gap_motion):
537 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
538 (gap_left, gap_right): Don't call it.
540 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
542 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
543 incurred during fontification.
545 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
547 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
548 (DEFVAR_PER_BUFFER): Don't pass it.
550 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
551 (scrolling_window): Don't pass it.
553 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
555 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
557 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
559 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
560 of variables specific to SELinux and computation of `encoded_absname'.
562 * image.c (XPutPixel): Remove unused variable `height'.
564 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
566 * unexw32.c (get_section_info): Remove unused variable `section'.
568 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
569 (system_process_attributes): Remove unused variable `sess'.
570 (sys_read): Remove unused variable `err'.
572 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
573 (w32_wnd_proc): Remove unused variable `isdead'.
574 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
575 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
576 (x_create_tip_frame): Remove unused variable `tem'.
578 * w32inevt.c (w32_console_read_socket):
579 Remove unused variable `no_events'.
581 * w32term.c (x_draw_composite_glyph_string_foreground):
582 Remove unused variable `width'.
584 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
586 * w32term.c (x_set_glyph_string_clipping):
587 Don't pass uninitialized region to CombineRgn.
589 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
591 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
592 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
593 (Fx_close_connection): Remove unused variable `i'.
595 * w32font.c (w32font_draw): Return number of glyphs.
596 (w32font_open_internal): Remove unused variable `i'.
597 (w32font_driver): Add missing initializer.
599 * w32menu.c (utf8to16): Remove unused variable `utf16'.
600 (fill_in_menu): Remove unused variable `items_added'.
602 * w32term.c (last_mouse_press_frame): Remove static global variable.
603 (w32_clip_to_row): Remove unused variable `f'.
604 (x_delete_terminal): Remove unused variable `i'.
606 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
607 (NOTHING): Remove unused static global variable.
608 (uniscribe_check_otf): Remove unused variable `table'.
609 (uniscribe_font_driver): Add missing initializers.
611 2011-03-23 Julien Danjou <julien@danjou.info>
613 * term.c (Fsuspend_tty, Fresume_tty):
614 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
615 * window.c (temp_output_buffer_show):
616 * insdel.c (signal_before_change):
617 * frame.c (Fhandle_switch_frame):
618 * fileio.c (Fdo_auto_save):
619 * emacs.c (Fkill_emacs):
620 * editfns.c (save_excursion_restore):
621 * cmds.c (internal_self_insert):
622 * callint.c (Fcall_interactively):
623 * buffer.c (Fkill_all_local_variables):
624 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
626 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
627 unconditionnaly since it does the check itself.
629 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
631 Fix more problems found by GCC 4.5.2's static checks.
633 * coding.c (encode_coding_raw_text): Avoid unnecessary test
634 the first time through the loop, since we know p0 < p1 then.
635 This also avoids a gcc -Wstrict-overflow warning.
637 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
638 leading to a memory leak, possible in functions like
639 load_charset_map_from_file that can allocate an unbounded number
640 of objects (Bug#8318).
642 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
643 that could (at least in theory) be that large.
645 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
646 This is less likely to overflow, and avoids undefined behavior if
647 overflow does occur. All callers changed. Use strtoul to scan
648 for the unsigned long integer.
649 (pint2hrstr): Simplify and tune code slightly.
650 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
652 * scroll.c (do_scrolling): Work around GCC bug 48228.
653 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
655 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
656 This also avoids a warning with gcc -Wstrict-overflow.
657 (validate_x_resource_name): Simplify count usage.
658 This also avoids a warning with gcc -Wstrict-overflow.
660 * fileio.c (Fcopy_file): Report error if fchown or fchmod
663 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
665 * process.c (Fmake_network_process): Use socklen_t, not int,
666 where POSIX says socklen_t is required in portable programs.
667 This fixes a porting bug on hosts like 64-bit HP-UX, where
668 socklen_t is wider than int (Bug#8277).
669 (Fmake_network_process, server_accept_connection):
670 (wait_reading_process_output, read_process_output):
673 * process.c: Rename or move locals to avoid shadowing.
674 (list_processes_1, Fmake_network_process):
675 (read_process_output_error_handler, exec_sentinel_error_handler):
676 Rename or move locals.
677 (Fmake_network_process): Define label "retry_connect" only if needed.
678 (Fnetwork_interface_info): Fix pointer signedness.
679 (process_send_signal): Add cast to avoid pointer signedness problem.
680 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
681 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
683 Make tparam.h and terminfo.c consistent.
684 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
685 Include tparam.h instead, since it declares them.
686 * cm.h (PC): Remove extern decl; tparam.h now does this.
687 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
688 * terminfo.c: Include tparam.h, to check interfaces.
689 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
690 (tparam): Adjust signature to match interface in tparam.h;
691 this removes some undefined behavior. Check that outstring and len
692 are zero, which they always are with Emacs.
693 * tparam.h (PC, BC, UP): New extern decls.
695 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
696 (xftfont_open): Rename locals to avoid shadowing.
698 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
699 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
700 (OTF_TAG_SYM): Omit macro if not needed.
701 (ftfont_list): Remove unused local.
702 (get_adstyle_property, ftfont_pattern_entity):
703 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
704 Rename locals to avoid shadowing.
706 * xfont.c (xfont_list_family): Mark var as initialized.
708 * xml.c (make_dom): Now static.
710 * composite.c (composition_compute_stop_pos): Rename local to
712 (composition_reseat_it): Remove unused locals.
713 (find_automatic_composition, composition_adjust_point): Likewise.
714 (composition_update_it): Mark var as initialized.
715 (find_automatic_composition): Mark vars as initialized,
716 with a FIXME (Bug#8290).
718 character.h: Rename locals to avoid shadowing.
719 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
720 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
721 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
722 (BUF_DEC_POS): Be more systematic about renaming local temporaries
725 * textprop.c (property_change_between_p): Remove; unused.
727 * intervals.c (interval_start_pos): Now static.
729 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
731 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
732 Rename locals to avoid shadowing.
734 * sound.c (wav_play, au_play, Fplay_sound_internal):
735 Fix pointer signedness.
736 (alsa_choose_format): Remove unused local var.
737 (wav_play): Initialize a variable to 0, to prevent undefined
740 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
742 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
744 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
745 clobbering (Bug#8298).
746 * sysdep.c (sys_subshell): Likewise.
747 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
749 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
750 This should get cleaned up, so that child_setup has the
751 same signature on all platforms.
753 * callproc.c (call_process_cleanup): Now static.
754 (relocate_fd): Rename locals to avoid shadowing.
756 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
758 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
759 not to be necessary, and produces flickering.
761 2011-03-20 Glenn Morris <rgm@gnu.org>
763 * config.in: Remove file.
765 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
767 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
768 are now in src/globals.h.
769 (syms_of_minibuf): Remove spurious & from previous change.
771 2011-03-20 Leo <sdl.web@gmail.com>
773 * minibuf.c (completing-read-function): New variable.
774 (completing-read-default): Rename from completing-read.
775 (completing-read): Call completing-read-function.
777 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
779 * xfaces.c (Fx_load_color_file):
780 Read color file from absolute filename (bug#8250).
782 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
784 * makefile.w32-in: Update dependencies.
786 2011-03-17 Eli Zaretskii <eliz@gnu.org>
788 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
790 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
792 Fix more problems found by GCC 4.5.2's static checks.
794 * process.c (make_serial_process_unwind, send_process_trap):
795 (sigchld_handler): Now static.
797 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
798 That way, the code declares only the vars that it needs.
799 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
800 * s/cygwin.h (PTY_ITERATION): Likewise.
801 * s/darwin.h (PTY_ITERATION): Likewise.
802 * s/gnu-linux.h (PTY_ITERATION): Likewise.
804 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
805 * process.c (allocate_pty): Don't declare stb unless it's needed.
807 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
808 (CONSTANTLIM): Remove; unused.
809 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
810 Define only if needed.
812 * unexelf.c (unexec): Name an expression,
813 to avoid gcc -Wbad-function-cast warning.
814 Use a different way to cause a compilation error if anyone uses
815 n rather than nn, a way that does not involve shadowing.
816 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
818 * deps.mk (unexalpha.o): Remove; unused.
820 New file unexec.h, the (simple) interface for unexec (Bug#8267).
821 * unexec.h: New file.
822 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
823 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
825 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
826 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
827 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
828 Change as necessary to match prototype in unexec.h.
830 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
832 (back_comment, skip_chars): Mark vars as initialized.
834 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
835 Rename locals to avoid shadowing.
837 * lread.c (read1): Rewrite so as not to use empty "else".
838 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
840 * print.c (Fredirect_debugging_output): Fix pointer signedess.
842 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
843 warning when compiling print.c.
845 * font.c (font_unparse_fcname): Abort in an "impossible" situation
846 instead of using an uninitialized var.
847 (font_sort_entities): Mark var as initialized.
849 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
851 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
852 pointers to constants.
853 (font_parse_fcname): Remove unused vars.
854 (font_delete_unmatched): Now static.
855 (font_get_spec): Remove; unused.
856 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
857 (font_update_drivers, Ffont_get_glyphs, font_add_log):
858 Rename or move locals to avoid shadowing.
860 * fns.c (require_nesting_list, require_unwind): Now static.
861 (Ffillarray): Rename locals to avoid shadowing.
863 * floatfns.c (domain_error2): Define only if needed.
864 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
866 * alloc.c (mark_backtrace): Move decl from here ...
867 * lisp.h: ... to here, so that it can be checked.
869 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
870 (Fdefvar): Rewrite so as not to use empty "else".
871 (lisp_indirect_variable): Name an expression,
872 to avoid gcc -Wbad-function-cast warning.
873 (Fdefvar): Rename locals to avoid shadowing.
875 * callint.c (quotify_arg, quotify_args): Now static.
876 (Fcall_interactively): Rename locals to avoid shadowing.
877 Use const pointer when appropriate.
879 * lisp.h (get_system_name, get_operating_system_release):
880 Move decls here, to check interfaces.
881 * process.c (get_operating_system_release): Move decl to lisp.h.
882 * xrdb.c (get_system_name): Likewise.
883 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
884 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
885 some of which prompt warnings from gcc -Wbad-function-cast.
886 (Fformat_time_string, Fencode_time, Finsert_char):
887 (Ftranslate_region_internal, Fformat):
888 Rename or remove local vars to avoid shadowing.
889 (Ftranslate_region_internal): Mark var as initialized.
891 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
894 * lisp.h (eassert): Check that the argument compiles, even if
895 ENABLE_CHECKING is not defined.
897 * data.c (Findirect_variable): Name an expression, to avoid
898 gcc -Wbad-function-cast warning.
899 (default_value, arithcompare, arith_driver, arith_error): Now static.
900 (store_symval_forwarding): Rename local to avoid shadowing.
901 (Fmake_variable_buffer_local, Fmake_local_variable):
902 Mark variables as initialized.
903 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
905 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
906 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
907 Rename locals to avoid shadowing.
908 (mark_stack): Move local variables into the #ifdef region where
910 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
911 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
913 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
914 (GC_STRING_CHARS): Remove; not used.
915 (Fmemory_limit): Cast sbrk's returned value to char *.
917 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
918 avoids undefined behavior in theory.
920 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
922 Use functions, not macros, for up- and down-casing (Bug#8254).
923 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
924 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
925 to use the following functions instead of these macros.
926 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
927 EMACS_INT, since callers assume the returned value fits in int.
928 (upcase1): Likewise, for UPCASE_TABLE.
929 (uppercasep, lowercasep, upcase): New static inline functions.
930 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
931 the race-condition problem in the old DOWNCASE.
933 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
934 Rename locals to avoid shadowing.
935 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
936 (regex_compile, re_search_2, re_match_2_internal):
937 Remove unused local vars.
938 (FREE_VAR): Rewrite so as not to use empty "else",
939 which gcc can warn about.
940 (regex_compile, re_match_2_internal): Mark locals as initialized.
941 (RETALLOC_IF): Define only if needed.
942 (WORDCHAR_P): Likewise. This one is never needed, but is used
943 only in a comment talking about a compiler bug, so put inside
944 the #if 0 of that comment.
945 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
946 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
949 * search.c (boyer_moore): Rename locals to avoid shadowing.
950 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
951 (PREV_CHAR_BOUNDARY): Likewise.
953 * search.c (simple_search): Remove unused var.
955 * dired.c (compile_pattern): Move decl from here ...
956 * lisp.h: ... to here, so that it can be checked.
957 (struct re_registers): New forward decl.
959 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
961 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
963 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
964 Rename locals to avoid shadowing.
965 (Fvertical_motion): Mark locals as initialized.
967 * casefiddle.c (casify_object, casify_region): Now static.
968 (casify_region): Mark local as initialized.
970 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
972 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
973 New macros, so that the caller can use some names other than
975 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
977 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
978 argument, for consistency with GCPRO2_VAR, etc: it is now the
979 prefix of the variable, not the variable itself. All uses
981 * dired.c (directory_files_internal, file_name_completion):
982 Rename locals to avoid shadowing.
984 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
985 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
986 dired.c's scmp function, had undefined behavior.
987 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
988 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
989 * buffer.h: ... to here, because these macros use current_buffer,
990 and the new implementation with inline functions needs to have
991 current_buffer in scope now, rather than later when the macros
993 (downcase, upcase1): New static inline functions.
994 (DOWNCASE, UPCASE1): Reimplement using these functions.
995 This avoids undefined behavior in expressions like
996 DOWNCASE (x) == DOWNCASE (y), which previously suffered
997 from race conditions in accessing the global variables
998 case_temp1 and case_temp2.
999 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1000 * lisp.h (case_temp1, case_temp2): Remove their decls.
1001 * character.h (ASCII_CHAR_P): Move from here ...
1002 * lisp.h: ... to here, so that the inline functions mentioned
1005 * dired.c (directory_files_internal_unwind): Now static.
1007 * fileio.c (file_name_as_directory, directory_file_name):
1008 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1010 (file_name_as_directory): Use const pointers when appropriate.
1011 (Fexpand_file_name): Likewise. In particular, newdir might
1012 point at constant storage, so make it a const pointer.
1013 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1014 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1016 (Fset_file_times, Finsert_file_contents, auto_save_error):
1017 Rename locals to avoid shadowing.
1019 * minibuf.c (choose_minibuf_frame_1): Now static.
1020 (Ftry_completion, Fall_completions): Rename or remove locals
1023 * marker.c (bytepos_to_charpos): Remove; unused.
1025 * lisp.h (verify_bytepos, count_markers): New decls,
1026 so that gcc does not warn that these functions aren't declared.
1028 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1029 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1030 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1031 (copy_text): Remove unused local var.
1033 * filelock.c (within_one_second): Now static.
1034 (lock_file_1): Rename local to avoid shadowing.
1036 * buffer.c (fix_overlays_before): Mark locals as initialized.
1037 (fix_start_end_in_overlays): Likewise. This function should be
1038 simplified by using pointers-to-pointers, but that's a different
1040 (switch_to_buffer_1): Now static.
1041 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1042 (report_overlay_modification): Rename locals to avoid shadowing.
1044 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1045 Fix pointer signedness issue.
1046 (sys_subshell): Mark local as volatile if checking for lint,
1047 to suppress a gcc -Wclobbered warning that does not seem to be right.
1048 (MAXPATHLEN): Define only if needed.
1050 * process.c (serial_open, serial_configure): Move decls from here ...
1051 * systty.h: ... to here, so that they can be checked.
1053 * fns.c (get_random, seed_random): Move extern decls from here ...
1054 * lisp.h: ... to here, so that they can be checked.
1056 * sysdep.c (reset_io): Now static.
1057 (wait_for_termination_signal): Remove; unused.
1059 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1060 (copy_keymap_item, append_key, push_text_char_description):
1062 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1063 (DENSE_TABLE_SIZE): Remove; unused.
1064 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1065 (describe_map_tree):
1066 Rename locals to avoid shadowing.
1068 * keyboard.c: Declare functions static if they are not used elsewhere.
1069 (echo_char, echo_dash, cmd_error, top_level_2):
1070 (poll_for_input, handle_async_input): Now static.
1071 (read_char, kbd_buffer_get_event, make_lispy_position):
1072 (make_lispy_event, make_lispy_movement, apply_modifiers):
1073 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1074 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1075 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1076 (read_key_sequence, read_char): Mark locals as initialized.
1077 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1079 * keyboard.h (make_ctrl_char): New decl.
1080 (mark_kboards): Move decl here ...
1081 * alloc.c (mark_kboards): ... from here.
1083 * lisp.h (force_auto_save_soon): New decl.
1085 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1086 (DEFINE_DUMMY_FUNCTION): New macro.
1087 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1089 (main): Add casts to avoid warnings
1090 if GCC considers string literals to be constants.
1092 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1094 * dbusbind.c: Pointer signedness fixes.
1095 (xd_signature, xd_append_arg, xd_initialize):
1096 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1097 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1098 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1099 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1101 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1102 if GCC considers string literals to be constants.
1103 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1105 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1107 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1108 (print_preprocess, print_object): New macro to fix last change.
1110 * print.c (print_preprocess): Don't forget font objects.
1112 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
1114 * emacs.c (USAGE3): Doc fixes.
1116 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1118 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1121 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
1123 * lisp.h (VWindow_system, Qfile_name_history):
1124 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1125 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1126 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1128 * w32select.c: Don't #include "keyboard.h".
1129 (run_protected): Add extern declaration for waiting_for_input.
1131 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1132 * w32console.c (detect_input_pending, read_input_pending)
1133 (encode_terminal_code):
1134 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1135 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1136 (w32_system_caret_y, Qfile_name_history):
1137 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1138 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1139 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1140 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1141 * w32proc.c (Qlocal, report_file_error):
1142 * w32term.c (Vwindow_system, updating_frame):
1143 * w32uniscribe.c (initialized, uniscribe_font_driver):
1144 Remove unneeded extern declarations.
1146 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
1148 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
1150 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
1152 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1153 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1154 These macros can no longer be used for assignment.
1156 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1157 Assign struct members directly, instead of using BUF_BEGV etc.
1158 (record_buffer_markers, fetch_buffer_markers): New functions for
1159 recording and fetching special buffer markers.
1160 (set_buffer_internal_1, set_buffer_temp): Use them.
1162 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1164 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1166 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1167 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1169 * xdisp.c (hscroll_window_tree):
1170 (reconsider_clip_changes): Use PT instead of BUF_PT.
1172 2011-03-13 Eli Zaretskii <eliz@gnu.org>
1174 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1175 $(EMACS_ROOT)/lib/intprops.h.
1177 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1179 Fix more problems found by GCC 4.5.2's static checks.
1181 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1182 to unsigned char * to avoid compiler diagnostic.
1183 (xg_free_frame_widgets): Make it clear that a local variable is
1184 needed only if USE_GTK_TOOLTIP.
1185 (gdk_window_get_screen): Make it clear that this macro is needed
1186 only if USE_GTK_TOOLTIP.
1187 (int_gtk_range_get_value): New function, which avoids a diagnostic
1188 from gcc -Wbad-function-cast.
1189 (xg_set_toolkit_scroll_bar_thumb): Use it.
1190 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1191 diagnostic from gcc -Wbad-function-cast.
1192 (get_utf8_string, xg_get_file_with_chooser):
1193 Rename locals to avoid shadowing.
1194 (create_dialog): Move locals to avoid shadowing.
1196 * xgselect.c (xg_select): Remove unused var.
1198 * image.c (four_corners_best): Mark locals as initialized.
1199 (gif_load): Initialize transparent_p to zero (Bug#8238).
1200 Mark another local as initialized.
1201 (my_png_error, my_error_exit): Mark with NO_RETURN.
1203 * image.c (clear_image_cache): Now static.
1204 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
1205 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
1206 (x_edge_detection): Remove unnecessary cast that
1207 gcc -Wbad-function-cast diagnoses.
1208 (gif_load): Fix pointer signedness.
1209 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1210 (jpeg_load, gif_load): Rename locals to avoid shadowing.
1212 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
1214 Improve quality of tests for time stamp overflow.
1215 For example, without this patch (encode-time 0 0 0 1 1
1216 1152921504606846976) returns the obviously-bogus value (-948597
1217 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1218 reports time overflow. See
1219 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
1220 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1221 * editfns.c: Include limits.h and intprops.h.
1222 (TIME_T_MIN, TIME_T_MAX): New macros.
1223 (time_overflow): Move earlier, to before first use.
1224 (hi_time, lo_time): New functions, for an accurate test for
1226 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1227 (Fget_internal_run_time): Don't assume time_t fits in int.
1228 (make_time): Use list2 instead of Fcons twice.
1229 (Fdecode_time): More accurate test for out-of-range times.
1230 (check_tm_member): New function.
1231 (Fencode_time): Use it, to test for out-of-range times.
1232 (lisp_time_argument): Don't rely on undefined left-shift and
1233 right-shift behavior when checking for time stamp overflow.
1235 * editfns.c (time_overflow): New function, refactoring common code.
1236 (Fformat_time_string, Fdecode_time, Fencode_time):
1237 (Fcurrent_time_string): Use it.
1239 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1240 * dired.c (make_time): Move to ...
1241 * editfns.c (make_time): ... here.
1242 * systime.h: Note the move.
1244 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1246 * fringe.c (update_window_fringes): Remove unused variables.
1248 * unexmacosx.c (copy_data_segment): Also copy __got section.
1251 2011-03-12 Eli Zaretskii <eliz@gnu.org>
1253 * termcap.c [MSDOS]: Include "msdos.h".
1254 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1255 Constify `char *' arguments and their references according to
1256 prototypes in tparam.h.
1258 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
1260 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1261 Adapt all references accordingly.
1263 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1265 2011-03-11 Tom Tromey <tromey@redhat.com>
1267 * buffer.c (syms_of_buffer): Remove obsolete comment.
1269 2011-03-11 Eli Zaretskii <eliz@gnu.org>
1271 * termhooks.h (encode_terminal_code): Declare prototype.
1273 * msdos.c (encode_terminal_code): Don't declare prototype.
1275 * term.c (encode_terminal_code): Now external again, used by
1276 w32console.c and msdos.c.
1278 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1279 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
1281 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
1283 Fix some minor problems found by GCC 4.5.2's static checks.
1285 * fringe.c (update_window_fringes): Mark locals as initialized
1287 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
1289 * alloc.c (mark_fringe_data): Move decl from here ...
1290 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1291 to check its interface.
1292 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1294 * fontset.c (free_realized_fontset): Now static.
1295 (Fset_fontset_font): Rename local to avoid shadowing.
1296 (fontset_font): Mark local as initialized.
1297 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
1299 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1301 * xselect.c (x_disown_buffer_selections): Remove; not used.
1302 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
1303 (x_own_selection, Fx_disown_selection_internal): Rename locals
1305 (x_handle_dnd_message): Remove local to avoid shadowing.
1307 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1308 so that the caller can use some name other than gcpro1.
1309 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
1310 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1311 (Fx_backspace_delete_keys_p):
1312 Use them to avoid shadowing, and rename vars to avoid shadowing.
1313 (x_decode_color, x_set_name, x_window): Now static.
1314 (Fx_create_frame): Add braces to silence GCC warning.
1315 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
1316 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1317 Remove unused locals.
1318 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1319 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1320 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1323 * xterm.h (x_mouse_leave): New decl.
1325 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1326 Remove unused functions.
1327 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1328 (x_calc_absolute_position): Now static.
1329 (XTread_socket): Don't define label "out" unless it's used.
1330 Don't declare local "event" unless it's used.
1331 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1332 unless they are used.
1333 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1334 (x_fatal_error_signal): Remove; not used.
1335 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1336 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1337 (x_error_catcher, x_connection_closed, x_error_handler):
1338 (x_error_quitter, xembed_send_message, x_iconify_frame):
1339 (my_log_handler): Rename locals to avoid shadowing.
1340 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
1341 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
1343 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1344 Rename or move locals to avoid shadowing.
1345 (tty_defined_color, merge_face_heights): Now static.
1346 (free_realized_faces_for_fontset): Remove; not used.
1347 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1348 does not deduce is never used uninitialized.
1349 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1350 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
1352 * terminal.c (store_terminal_param): Now static.
1354 * xmenu.c (menu_highlight_callback): Now static.
1355 (set_frame_menubar): Remove unused local.
1356 (xmenu_show): Rename parameter to avoid shadowing.
1357 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1358 since they might point to immutable storage.
1359 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1360 since it's unused otherwise.
1362 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
1363 Add a FIXME, since the code still doesn't look right. (Bug#8215)
1364 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1365 avoids a gcc -Wuninitialized diagnostic.
1366 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
1367 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1368 does not deduce are never used uninitialized.
1370 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1372 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
1373 * window.c (window_loop, size_window):
1374 (run_window_configuration_change_hook, enlarge_window): Likewise.
1376 * window.c (display_buffer): Now static.
1377 (size_window): Mark variables that gcc -Wuninitialized
1378 does not deduce are never used uninitialized.
1379 * window.h (check_all_windows): New decl, to forestall
1380 gcc -Wmissing-prototypes diagnostic.
1381 * dispextern.h (bidi_dump_cached_states): Likewise.
1383 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1385 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
1387 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1388 and to avoid gcc -Wuninitialized warning.
1389 (load_charset_map): Mark variables that gcc -Wuninitialized
1390 does not deduce are never used uninitialized.
1391 (load_charset): Abort instead of using uninitialized var (Bug#8229).
1393 * coding.c (coding_set_source, coding_set_destination):
1394 Use "else { /* comment */ }" rather than "else /* comment */;"
1395 for clarity, and to avoid gcc -Wempty-body warning.
1396 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1397 a block, when the outer 'i' will do.
1398 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1399 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1400 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1401 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1402 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1403 Rename locals to avoid shadowing.
1404 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
1405 * coding.c (emacs_mule_char, encode_invocation_designation):
1406 Now static, since they're not used elsewhere.
1407 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
1408 (decode_coding_object, encode_coding_object, detect_coding_system):
1409 (decode_coding_emacs_mule): Mark variables that gcc
1410 -Wuninitialized does not deduce are never used uninitialized.
1411 (detect_coding_iso_2022): Initialize a local variable that might
1412 be used uninitialized. Leave a FIXME because it's not clear that
1413 this initialization is needed. (Bug#8211)
1414 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1415 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1416 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1417 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1418 Remove unused macros.
1420 * category.c (hash_get_category_set): Remove unused local var.
1421 (copy_category_table): Now static, since it's not used elsewhere.
1422 * character.c (string_count_byte8): Likewise.
1424 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1425 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1427 * chartab.c (copy_sub_char_table): Now static, since it's not used
1429 (sub_char_table_ref_and_range, char_table_ref_and_range):
1430 Rename locals to avoid shadowing.
1431 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
1433 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
1434 (BIDI_BOB): Remove unused macro.
1436 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1437 deduce are never used uninitialized.
1438 * term.c (encode_terminal_code): Likewise.
1440 * term.c (encode_terminal_code): Now static. Remove unused local.
1442 * tparam.h: New file.
1443 * term.c, tparam.h: Include it.
1444 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1445 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1446 Move these decls to tparam.h, and make them agree with what
1447 is actually in tparam.c. The previous trick of using incompatible
1448 decls in different modules does not conform to the C standard.
1449 All callers of tparam changed to use tparam's actual API.
1450 * tparam.c (tparam1, tparam, tgoto):
1451 Use const pointers where appropriate.
1453 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1454 * cm.h (struct cm): Likewise.
1455 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1456 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1457 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1458 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1459 (turn_on_face, init_tty): Likewise.
1460 * termchar.h (struct tty_display_info): Likewise.
1462 * term.c (term_mouse_position): Rename local to avoid shadowing.
1464 * alloc.c (mark_ttys): Move decl from here ...
1465 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1467 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1469 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1471 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
1473 * search.c (compile_pattern_1): Remove argument regp, unused since
1474 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1475 (compile_pattern): Don't pass it.
1477 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1479 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1480 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1482 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1484 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1486 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1487 gdk_window_get_screen, gdk_window_get_geometry,
1488 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1489 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1490 (xg_get_pixbuf_from_pixmap): New function.
1491 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1492 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1493 Call xg_get_pixbuf_from_pixmap instead of
1494 gdk_pixbuf_get_from_drawable.
1495 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1496 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1497 (xg_check_special_colors): Use GtkStyleContext and its functions
1499 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1500 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1501 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
1502 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1503 Call gtk_widget_get_preferred_size.
1504 (xg_frame_resized): gdk_window_get_geometry only takes 5
1506 (xg_win_to_widget, xg_event_is_for_menubar):
1507 Call gdk_x11_window_lookup_for_display.
1508 (xg_set_widget_bg): New function.
1509 (delete_cb): New function.
1510 (xg_create_frame_widgets): connect delete-event to delete_cb.
1511 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1512 (xg_set_background_color): Call xg_set_widget_bg.
1513 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1514 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1515 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1516 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1518 (update_frame_tool_bar): Call gtk_widget_hide.
1519 (xg_initialize): Use GDK_KEY_g.
1521 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1523 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1525 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1526 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1527 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1529 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
1531 * w32xfns.c (select_palette): Check success of RealizePalette against
1532 GDI_ERROR, not zero.
1534 See ChangeLog.11 for earlier changes.
1540 Copyright (C) 2011 Free Software Foundation, Inc.
1542 This file is part of GNU Emacs.
1544 GNU Emacs is free software: you can redistribute it and/or modify
1545 it under the terms of the GNU General Public License as published by
1546 the Free Software Foundation, either version 3 of the License, or
1547 (at your option) any later version.
1549 GNU Emacs is distributed in the hope that it will be useful,
1550 but WITHOUT ANY WARRANTY; without even the implied warranty of
1551 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1552 GNU General Public License for more details.
1554 You should have received a copy of the GNU General Public License
1555 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.