1 2012-09-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3 * unexmacosx.c: Define LC_DATA_IN_CODE if not defined.
4 (print_load_command_name): Add case LC_DATA_IN_CODE.
5 (dump_it) [LC_DATA_IN_CODE]: Call copy_linkedit_data.
7 2012-09-18 Glenn Morris <rgm@gnu.org>
9 * eval.c (Frun_hook_with_args_until_success)
10 (Frun_hook_with_args_until_failure): Doc fixes. (Bug#12393)
12 2012-09-14 Andreas Schwab <schwab@linux-m68k.org>
14 * fileio.c (Ffile_selinux_context): Only call freecon when
15 lgetfilecon succeeded.
16 (Fset_file_selinux_context): Likewise. (Bug#12444)
18 2012-09-12 Eli Zaretskii <eliz@gnu.org>
20 * xdisp.c (try_window_reusing_current_matrix): Under bidi
21 reordering, locate the cursor by calling set_cursor_from_row; if
22 that fails, clear the desired glyph matrix before returning a
23 failure indication to the caller. Fixes leaving garbled display
24 when fast scrolling with a down-key. (Bug#12403)
25 (compute_stop_pos_backwards): Fix a typo that caused crashes while
26 scrolling through multibyte text.
28 2012-09-12 Jan Djärv <jan.h.d@swipnet.se>
30 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
31 does not become zero (Bug#12234). Backport from trunk.
33 2012-08-24 Chong Yidong <cyd@gnu.org>
35 * Version 24.2 released.
37 2012-08-24 Eli Zaretskii <eliz@gnu.org>
39 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
40 is not one of the heaps we manage. (Bug#12242)
42 2012-08-14 Glenn Morris <rgm@gnu.org>
44 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
46 2012-08-14 Ulrich Mueller <ulm@gentoo.org>
48 * systime.h (EMACS_TIME_CMP): Don't cast time_t values to long
51 2012-08-13 Eli Zaretskii <eliz@gnu.org>
53 * w32menu.c: Include w32heap.h.
54 (add_menu_item): If the call to AppendMenuW (via
55 unicode_append_menu) fails, disable Unicode menus only if we are
56 running on Windows 9X/Me.
58 * makefile.w32-in ($(BLD)/w32menu.$(O)): Depend on w32heap.h.
60 * window.c (Fdelete_other_windows_internal)
61 (Fdelete_window_internal): Don't access frame's mouse highlight
62 info of the initial frame. (Bug#11677)
64 2012-08-12 Jan Djärv <jan.h.d@swipnet.se>
66 * nsterm.m (ns_read_socket): Return early if there is a modal
69 * nsmenu.m (Popdown_data): New struct.
70 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
72 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
73 (initWithContentRect): Make imgView and contentView non-static
74 and autorelease them. Also autorelease img and matrix (Bug#12005).
75 (dealloc): Remove (Bug#12005).
77 * nsterm.m (keyDown:): Interpret flags without left/right bits
78 as the left key (Bug#11670).
80 * nsmenu.m (ns_update_menubar): Add braces to ambigous if-else.
82 2012-08-08 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
84 * unexmacosx.c (copy_data_segment): Copy initialized data in
85 statically linked libraries from input file rather than memory.
87 2012-08-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
89 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
90 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
91 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
93 2012-07-19 Chong Yidong <cyd@gnu.org>
95 * window.c (Fwindow_absolute_pixel_edges)
96 (Fdelete_other_windows_internal): Signal an error if the window is
97 on a dead frame (Bug#11984).
99 2012-07-14 Eli Zaretskii <eliz@gnu.org>
101 Remove FILE_SYSTEM_CASE.
102 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
104 * fileio.c (FILE_SYSTEM_CASE): Don't define.
105 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
106 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
107 call-process-region passes it through expand-file-name.
109 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
111 2012-07-12 Andreas Schwab <schwab@linux-m68k.org>
113 Fix crash when creating indirect buffer (Bug#11917)
114 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
115 Don't handle unbound variables specially if non-zero.
116 (Fbuffer_local_variables): Pass zero.
117 (clone_per_buffer_values): Pass non-zero.
119 2012-06-28 Andreas Schwab <schwab@linux-m68k.org>
121 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
122 to make the loop interruptible.
124 2012-06-26 Andreas Schwab <schwab@linux-m68k.org>
126 * gnutls.c (emacs_gnutls_handshake): Only retry if
127 GNUTLS_E_INTERRUPTED.
129 2012-06-23 Eli Zaretskii <eliz@gnu.org>
131 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
132 in the logic of incrementing and decrementing the value of
133 use_relocatable_buffers.
135 2012-06-21 Glenn Morris <rgm@gnu.org>
137 * charset.c (init_charset): Make lack of etc/charsets fatal.
139 2012-06-11 Jan Djärv <jan.h.d@swipnet.se>
141 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
142 referenced (Bug#11583).
144 2012-06-01 Chong Yidong <cyd@gnu.org>
146 * Version 24.1 released.
148 2012-05-30 Eli Zaretskii <eliz@gnu.org>
150 * xdisp.c (handle_stop): Detect whether we have overlay strings
151 loaded by testing it->current.overlay_string_index to be
152 non-negative, instead of checking whether n_overlay_strings is
153 positive. (Bug#11587)
155 2012-05-30 Chong Yidong <cyd@gnu.org>
157 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
159 * doc.c (Fsubstitute_command_keys): Doc fix.
161 2012-05-29 Eli Zaretskii <eliz@gnu.org>
163 * search.c (search_buffer): Remove calls to
164 r_alloc_inhibit_buffer_relocation, as it is now called by
165 maybe_unify_char, which was the cause of relocation of buffer text
168 2012-05-23 Eli Zaretskii <eliz@gnu.org>
170 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
171 for the duration of call to load_charset, to avoid problems with
172 callers of maybe_unify_char that access buffer text through C
175 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
176 decrement the inhibition flag, instead of just setting or
179 2012-05-24 Ken Brown <kbrown@cornell.edu>
181 * callproc.c (Fcall_process): Restore a line that was accidentally
182 commented out in the 2011-02-13 change (bug#11547).
184 2012-05-23 Eli Zaretskii <eliz@gnu.org>
186 * lisp.h [REL_ALLOC]: Add prototypes for external functions
189 * buffer.c [REL_ALLOC]: Remove prototypes of
190 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
191 they are now on lisp.h.
193 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
195 * search.c (search_buffer): Use it to inhibit relocation of buffer
196 text while re_search_2 is doing its job, because re_search_2 is
197 passed C pointers to buffer text. (Bug#11519)
199 2012-05-21 Eli Zaretskii <eliz@gnu.org>
201 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
204 2012-05-19 Eli Zaretskii <eliz@gnu.org>
206 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
207 state after an additional call to move_it_in_display_line_to, keep
208 the values of it->max_ascent and it->max_descent found for the
210 (pos_visible_p): Revert the comparison against bottom_y to what it
211 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
214 2012-05-15 Eli Zaretskii <eliz@gnu.org>
216 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
218 2012-05-13 Eli Zaretskii <eliz@gnu.org>
220 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
221 already have overlays loaded.
222 (handle_single_display_spec): Before returning without displaying
223 fringe bitmap, synchronize the bidi iterator with the main display
224 iterator, by calling iterate_out_of_display_property.
225 (iterate_out_of_display_property): Detect buffer iteration by
226 testing that it->string is a Lisp string.
227 (get_next_display_element): When the current object is exhausted,
228 and there's something on it->stack, call set_iterator_to_next to
229 proceed with what's on the stack, instead of returning zero.
230 (set_iterator_to_next): If called at the end of a Lisp string,
231 proceed to consider_string_end without incrementing string
232 position. Don't increment display vector index past the end of
233 the display vector. (Bug#11417)
234 (pos_visible_p): Don't report a position visible when move_it_to
235 stopped at the last line of window, which happens to be scanned
236 backwards by the bidi iteration. (Bug#11464)
238 2012-05-11 Eli Zaretskii <eliz@gnu.org>
240 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
241 and right-margin display specs even if the spec is invalid or we
242 are on a TTY, and thus unable to display on the fringes. That's
243 because the text with the property will not be displayed anyway,
244 so we need to signal to the caller that this is a "replacing"
245 display spec. This fixes display when the spec is invalid or we
248 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
250 * unexaix.c (make_hdr): Fix typo in prototype.
251 This bug broke the build on AIX. Problem reported by Gilles Pion.
253 2012-05-05 Eli Zaretskii <eliz@gnu.org>
255 * w32proc.c (new_child): Force Windows to reserve only 64KB of
256 stack for each reader_thread, instead of defaulting to 8MB
257 determined by the linker. This avoids failures in creating
258 subprocesses on Windows 7, see the discussion in this thread:
259 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
261 2012-05-02 Jim Meyering <meyering@redhat.com>
263 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
265 2012-04-29 Eli Zaretskii <eliz@gnu.org>
267 * xdisp.c (pos_visible_p): If already at a newline from the
268 display string before the 'while' loop, don't walk back the glyphs
269 from it3.glyph_row. Solves assertion violation when the display
270 string begins with a newline (egg.el). (Bug#11367)
272 2012-04-24 Chong Yidong <cyd@gnu.org>
274 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
276 2012-04-23 Eli Zaretskii <eliz@gnu.org>
278 * xdisp.c (pos_visible_p): If the window start position is beyond
279 ZV, start the display from buffer beginning. Prevents assertion
280 violation in init_iterator when the minibuffer window is scrolled
283 * window.c (window_scroll_pixel_based): Likewise.
285 2012-04-23 Chong Yidong <cyd@gnu.org>
287 * keymap.c (where_is_internal): Doc fix (Bug#10872).
289 2012-04-20 Glenn Morris <rgm@gnu.org>
291 * fileio.c (Fcopy_file, Fset_file_selinux_context):
292 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
294 2012-04-20 Eli Zaretskii <eliz@gnu.org>
296 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
297 overrun array limits of glyph row's used[] array. (Bug#11288)
299 2012-04-20 Chong Yidong <cyd@gnu.org>
301 * process.c (wait_reading_process_output): If EIO occurs on a pty,
302 set the status to "failed" and ensure that sentinel is run.
304 2012-04-18 Glenn Morris <rgm@gnu.org>
306 * process.c (Fset_process_inherit_coding_system_flag)
307 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
308 (Fmake_network_process, Fmake_serial_process): Doc fix.
310 2012-04-17 Eli Zaretskii <eliz@gnu.org>
312 * xdisp.c (string_buffer_position_lim): Limit starting position to
314 (set_cursor_from_row): If called for a mode-line or header-line
315 row, return zero immediately.
316 (try_cursor_movement): If inside continuation line, don't back up
317 farther than the first row after the header line, if any. Don't
318 consider the header-line row as "partially visible", even if
319 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
321 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
323 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
325 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
327 * process.c (make_process):
328 * process.h: Add integer `gnutls_handshakes_tried' member to
331 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
332 Add convenience `GNUTLS_LOG2i' macro.
334 * gnutls.c (gnutls_log_function2i): Convenience log function.
335 (emacs_gnutls_read): Use new log functions,
336 `gnutls_handshakes_tried' process member, and
337 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
338 attempts per process (connection).
340 2012-04-09 Eli Zaretskii <eliz@gnu.org>
342 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
343 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
345 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
347 * nsterm.m (constrainFrameRect): Always constrain when there is only
348 one screen (Bug#10962).
350 2012-04-06 Eli Zaretskii <eliz@gnu.org>
352 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
353 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
354 about subtle differences between FETCH_CHAR* and STRING_CHAR*
355 macros related to unification of CJK characters. For the details,
356 see the discussion following the message here:
357 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
359 2012-04-04 Chong Yidong <cyd@gnu.org>
361 * keyboard.c (Vdelayed_warnings_list): Doc fix.
363 2012-04-01 Eli Zaretskii <eliz@gnu.org>
365 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
366 instead of alloca. (Bug#11138)
368 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
370 * w32menu.c (is_simple_dialog): Properly check lisp types.
373 2012-03-31 Eli Zaretskii <eliz@gnu.org>
375 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
376 position we get to after a call to move_it_to fails the
377 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
378 only if we wind up in a string from display property. (Bug#11063)
380 * window.c (Fdelete_other_windows_internal): Invalidate the row
381 and column information about mouse highlight, so that redisplay
382 restores it after reallocating the glyph matrices. (Bug#7464)
384 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
385 string comes from a `display' text property, use the buffer
386 position of that property as if we actually saw that position in
388 (move_it_by_lines): Remove the assertion that
389 "it->current_x == 0 && it->hpos == 0" which can be legitimately
390 violated when there's a before-string at the beginning of a line.
393 2012-03-30 Eli Zaretskii <eliz@gnu.org>
395 * xdisp.c (append_space_for_newline): If the default face was
396 remapped, use the remapped face for the appended newline.
397 (extend_face_to_end_of_line): Use the remapped default face for
398 extending the face to the end of the line.
399 (display_line): Call extend_face_to_end_of_line when the default
400 face was remapped. (Bug#11068)
402 2012-03-29 Eli Zaretskii <eliz@gnu.org>
404 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
406 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
408 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
410 2012-03-27 Glenn Morris <rgm@gnu.org>
412 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
415 2012-03-26 Kenichi Handa <handa@m17n.org>
417 * dispextern.h (struct glyph): Fix previous change. Change the
418 bit length of glyphless.ch to 25 (Bug#11082).
420 2012-03-26 Chong Yidong <cyd@gnu.org>
422 * keyboard.c (Vselection_inhibit_update_commands): New variable.
423 (command_loop_1): Use it; inhibit selection update for
424 handle-select-window too (Bug#8996).
426 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
428 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
430 2012-03-25 Kenichi Handa <handa@m17n.org>
432 * dispextern.h (struct glyph): Change the bit length of
433 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
435 2012-03-24 Eli Zaretskii <eliz@gnu.org>
437 * s/ms-w32.h (tzname): Include time.h before redirecting to
438 _tzname. Fixes the MSVC build. (Bug#9960)
440 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
442 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
445 * xterm.c (XTread_socket): Only modify handling_signal if
446 !SYNC_INPUT. (Bug#11080)
448 2012-03-23 Eli Zaretskii <eliz@gnu.org>
450 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
451 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
452 when fetching a multibyte character consumes more bytes than
453 CHAR_BYTES returns, due to unification of CJK characters in
454 string_char. (Bug#11073)
456 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
458 * process.c (wait_reading_process_output): Handle pty disconnect
459 by refraining from sending oneself a SIGCHLD (bug#10933).
461 2012-03-22 Chong Yidong <cyd@gnu.org>
463 * dispextern.h (struct it): New member string_from_prefix_prop_p.
465 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
466 Mark string as coming from a prefix property.
467 (handle_face_prop): Use default face for prefix strings (Bug#4281).
468 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
470 2012-03-21 Chong Yidong <cyd@gnu.org>
472 * xfaces.c (Vface_remapping_alist): Doc fix.
474 2012-03-20 Eli Zaretskii <eliz@gnu.org>
476 * w32proc.c (Fw32_set_console_codepage)
477 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
480 2012-03-20 Chong Yidong <cyd@gnu.org>
482 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
483 to reflect default non-nil value of redisplay-dont-pause.
485 2012-03-19 Kenichi Handa <handa@m17n.org>
487 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
488 it fit in a valid range (Bug#11003).
490 2012-03-18 Eli Zaretskii <eliz@gnu.org>
492 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
493 that is not from display property, accept the row as a "cursor
494 row" if one of the string's character has a non-nil `cursor'
495 property. Fixes cursor positioning when there are newlines in
496 overlay strings, e.g. in icomplete.el. (Bug#11035)
498 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
500 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
502 2012-03-12 Chong Yidong <cyd@gnu.org>
504 * eval.c (inhibit_lisp_code): Rename from
505 inhibit_window_configuration_change_hook; move from window.c.
507 * xfns.c (unwind_create_frame_1, Fx_create_frame):
508 * window.c (run_window_configuration_change_hook)
509 (syms_of_window): Callers changed.
511 2012-03-11 Chong Yidong <cyd@gnu.org>
513 * keymap.c (Fkey_description): Doc fix (Bug#9700).
515 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
517 2012-03-10 Chong Yidong <cyd@gnu.org>
519 * frame.c (other_visible_frames): Don't assume the selected frame
520 is visible (Bug#10955).
522 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
524 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
526 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
528 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
529 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
532 2012-03-03 Glenn Morris <rgm@gnu.org>
534 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
536 2012-03-02 Eli Zaretskii <eliz@gnu.org>
538 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
539 position past the first glyph_row that ends at ZV. (Bug#10902)
540 (redisplay_window, next_element_from_string): Fix typos in
542 (redisplay_window): Pass to move_it_vertically the margin in
543 pixels, not in screen lines.
545 2012-03-02 Glenn Morris <rgm@gnu.org>
547 * buffer.c (buffer-list-update-hook): Doc fix.
549 2012-02-29 Eli Zaretskii <eliz@gnu.org>
551 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
552 push_it before setting up the iterator for the first overlay
553 string, even if we have an empty string loaded.
554 (next_overlay_string): If there's an empty string on the iterator
555 stack, pop the stack. (Bug#10903)
557 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
559 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
560 Suggested by Stefan Monnier in
561 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
562 * alloc.c (widen_to_Lisp_Object): New static function.
563 (mark_memory): Also mark Lisp_Objects by fetching pointer words
564 and widening them to Lisp_Objects. This would work even if
565 USE_LSB_TAG is defined and wide integers are used, which might
566 happen in a future version of Emacs.
568 2012-02-25 Chong Yidong <cyd@gnu.org>
570 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
573 * xselect.c (Fx_selection_exists_p): Doc fix.
574 (x_clipboard_manager_save_all): Print an informative message
575 before saving to clipboard manager.
577 2012-02-24 Chong Yidong <cyd@gnu.org>
579 * keyboard.c (process_special_events): Handle all X selection
580 requests in kbd_buffer, not just the next one (Bug#8869).
582 2012-02-23 Chong Yidong <cyd@gnu.org>
584 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
585 call when setting menu-bar-lines and tool-bar-lines parameters.
586 (unwind_create_frame_1): New helper function.
588 * window.c (inhibit_window_configuration_change_hook): New var.
589 (run_window_configuration_change_hook): Obey it.
590 (syms_of_window): Initialize it.
592 2012-02-22 Chong Yidong <cyd@gnu.org>
594 * xterm.c (x_draw_image_relief): Add missing type check for
595 Vtool_bar_button_margin (Bug#10743).
597 2012-02-21 Chong Yidong <cyd@gnu.org>
599 * fileio.c (Vfile_name_handler_alist): Doc fix.
601 * buffer.c (Fget_file_buffer): Protect against invalid file
602 handler return value.
604 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
606 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
607 when computing $valmask.
609 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
610 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
611 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
612 It's useless in that case, and it can cause problems on hosts
613 that allocate halves of EMACS_INT values separately.
614 Reported by Dan Horák. Diagnosed by Andreas Schwab in
615 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
616 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
617 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
618 it avoids undefined behavior on hosts where shifting right by more
619 than the word width has undefined behavior.
621 2012-02-19 Chong Yidong <cyd@gnu.org>
623 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
624 (Funhandled_file_name_directory, Ffile_name_as_directory)
625 (Fdirectory_file_name, Fexpand_file_name)
626 (Fsubstitute_in_file_name): Protect against invalid file handler
627 return values (Bug#10845).
629 2012-02-18 Eli Zaretskii <eliz@gnu.org>
631 * .gdbinit (pitx): Fix incorrect references to fields of the
634 2012-02-17 Chong Yidong <cyd@gnu.org>
636 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
638 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
640 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
641 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
643 2012-02-15 Chong Yidong <cyd@gnu.org>
645 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
646 marked as special. Also, starting docstrings with * is obsolete.
648 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
650 * gnutls.c (emacs_gnutls_write): Fix last change.
652 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
654 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
657 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
659 * keymap.c (Fsingle_key_description): Handle char ranges.
661 2012-02-12 Chong Yidong <cyd@gnu.org>
663 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
664 as that creates a dangerous corner case.
666 * window.c (Fdelete_window_internal): Invalidate the mouse
667 highlight (Bug#9904).
669 2012-02-12 Glenn Morris <rgm@gnu.org>
671 * xselect.c (Fx_own_selection_internal)
672 (Fx_get_selection_internal, Fx_disown_selection_internal)
673 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
674 * nsselect.m (Fx_own_selection_internal)
675 (Fx_disown_selection_internal, Fx_selection_exists_p)
676 (Fx_selection_owner_p, Fx_get_selection_internal):
677 Sync docs and argument specs with the xselect.c versions.
679 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
681 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
683 2012-02-11 Eli Zaretskii <eliz@gnu.org>
685 * w32select.c (Fx_selection_exists_p): Sync doc string and
686 argument list with xselect.c. (Bug#10783)
688 * w16select.c (Fx_selection_exists_p): Sync doc string and
689 argument list with xselect.c. (Bug#10783)
691 2012-02-10 Glenn Morris <rgm@gnu.org>
693 * fns.c (Fsecure_hash): Doc fix.
695 2012-02-09 Kenichi Handa <handa@m17n.org>
697 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
699 2012-02-07 Chong Yidong <cyd@gnu.org>
701 * buffer.c (Fbuffer_local_variables)
702 (buffer_lisp_local_variables): Handle unbound vars correctly;
703 don't let Qunbound leak into Lisp.
705 2012-02-07 Glenn Morris <rgm@gnu.org>
707 * image.c (Fimagemagick_types): Doc fix.
709 * image.c (imagemagick-render-type): Change it from a lisp object
710 to an integer. Move the doc here from the lisp manual.
711 Treat all values not equal to 0 the same.
713 2012-02-06 Chong Yidong <cyd@gnu.org>
715 * doc.c (store_function_docstring): Avoid applying docstring of
716 alias to base function (Bug#2603).
718 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
720 * .gdbinit (pp1, pv1): Remove redundant defines.
723 2012-02-04 Chong Yidong <cyd@gnu.org>
725 * nsterm.m: Declare a global (Bug#10694).
727 2012-02-04 Eli Zaretskii <eliz@gnu.org>
729 * w32.c (get_emacs_configuration_options):
730 Include --enable-checking, if specified, in the return value.
732 2012-02-04 Martin Rudalics <rudalics@gmx.at>
734 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
735 after rounding frame sizes. (Bug#9723)
737 2012-02-04 Eli Zaretskii <eliz@gnu.org>
739 * keyboard.c (adjust_point_for_property): Don't position point
740 before BEGV. (Bug#10696)
742 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
744 Handle overflow when computing char display width (Bug#9496).
745 * character.c (char_width): Return EMACS_INT, not int.
746 (char_width, c_string_width): Check for overflow when
747 computing the width; this is possible now that individual
748 characters can have unbounded width. Problem introduced
749 by merge from Emacs 23 on 2012-01-19.
751 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
753 * dbusbind.c (Fdbus_register_method): Mention the return value
754 :ignore in the docstring.
756 2012-02-02 Glenn Morris <rgm@gnu.org>
758 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
760 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
761 Unconditionally set to t. (Bug#10673)
762 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
763 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
764 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
766 2012-02-02 Kenichi Handa <handa@m17n.org>
768 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
769 0, do not call append_composite_glyph.
771 2012-02-02 Kenichi Handa <handa@m17n.org>
773 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
775 (x_produce_glyphs): If the component of a composition is a null
776 string, set it->pixel_width to 1 to avoid zero-width glyph.
778 2012-02-01 Eli Zaretskii <eliz@gnu.org>
780 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
781 first 2 arguments are identical. This makes inserting large
782 output from a subprocess an order of magnitude faster on
783 MS-Windows, where all sbrk'ed memory is always contiguous.
785 2012-01-31 Glenn Morris <rgm@gnu.org>
787 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
788 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
789 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
791 2012-01-29 Glenn Morris <rgm@gnu.org>
793 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
795 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
797 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
799 2012-01-28 Chong Yidong <cyd@gnu.org>
801 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
803 2012-01-26 Chong Yidong <cyd@gnu.org>
805 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
807 * search.c (Fsearch_forward, Fsearch_backward): Document negative
808 repeat counts (Bug#10507).
810 2012-01-26 Glenn Morris <rgm@gnu.org>
812 * lread.c (syms_of_lread): Doc fix.
814 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
816 * coding.c (encode_designation_at_bol): Change return value to
819 2012-01-25 Chong Yidong <cyd@gnu.org>
821 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
823 2012-01-21 Chong Yidong <cyd@gnu.org>
825 * floatfns.c (Fcopysign): Make the second argument non-optional,
826 since nil is not allowed anyway.
828 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
830 * process.c (read_process_output): Use p instead of XPROCESS (proc).
831 (send_process): Likewise.
833 2012-01-19 Martin Rudalics <rudalics@gmx.at>
835 * window.c (save_window_save, Fcurrent_window_configuration)
836 (Vwindow_persistent_parameters): Do not use Qstate.
839 2012-01-19 Kenichi Handa <handa@m17n.org>
841 * character.c (char_width): New function.
842 (Fchar_width, c_string_width, lisp_string_width):
843 Use char_width (Bug#9496).
845 2012-01-16 Martin Rudalics <rudalics@gmx.at>
847 * window.c (Vwindow_persistent_parameters): New variable.
848 (Fset_window_configuration, save_window_save): Handle persistent
851 2012-01-14 Eli Zaretskii <eliz@gnu.org>
853 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
854 thrashing the stack of the thread. (Bug#9087)
856 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
858 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
860 2012-01-11 Eli Zaretskii <eliz@gnu.org>
862 * xdisp.c (rows_from_pos_range): Handle the case where the
863 highlight ends on a newline. (Bug#10464)
864 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
865 he end column for display of highlight that ends on a newline
868 2012-01-11 Glenn Morris <rgm@gnu.org>
870 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
871 from load-path also when installation-directory is nil. (Bug#10208)
873 2012-01-10 Glenn Morris <rgm@gnu.org>
875 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
877 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
878 Update template values to be closer to their typical values these days.
880 2012-01-09 Eli Zaretskii <eliz@gnu.org>
882 * xdisp.c (rows_from_pos_range): Accept additional argument
883 DISP_STRING, and accept any glyph in a row whose object is that
884 string as eligible for mouse highlight. Fixes mouse highlight of
885 display strings from overlays. (Bug#10464)
887 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
889 emacs: fix an auto-save permissions race condition (Bug#10400)
890 * fileio.c (auto_saving_dir_umask): New static var.
891 (Fmake_directory_internal): Use it.
892 (do_auto_save_make_dir): Set it, instead of invoking chmod after
893 creating the directory. The old code temporarily assigns
894 too-generous permissions to the directory.
895 (do_auto_save_eh): Clear it.
896 (Fdo_auto_save): Catch all errors, not just file errors, so
897 that the var is always cleared.
899 2012-01-07 Eli Zaretskii <eliz@gnu.org>
901 * search.c (scan_buffer): Pass character positions to
902 know_region_cache, not byte positions. (Bug#6540)
904 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
906 * w32.c (sys_rename): Report EXDEV when rename of a directory
907 fails because the target is on another logical disk. (Bug#10284)
909 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
911 * xterm.c (x_embed_request_focus): New function.
913 * xterm.h: Add prototype.
915 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
917 2012-01-05 Glenn Morris <rgm@gnu.org>
919 * emacs.c (emacs_copyright): Update short copyright year to 2012.
921 2012-01-01 Eli Zaretskii <eliz@gnu.org>
923 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
924 Load gnutls_transport_set_lowat only if GnuTLS version is below
926 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
927 GnuTLS versions below 2.11.1.
929 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
931 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
932 to the doc string advising against its use for altering the way
933 windows are scrolled.
935 2011-12-28 Kenichi Handa <handa@m17n.org>
937 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
938 coding-system ASCII compatible only when it does not produce BOM
939 on encoding (Bug#10383).
941 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
943 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
945 (create_and_show_popup_menu): Always use menu_position_func for
948 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
950 * callint.c (Fcall_interactively): Don't truncate prompt string.
952 2011-12-23 Eli Zaretskii <eliz@gnu.org>
954 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
955 property that ends at ZV, so that the bidi iteration could be
956 resumed from there (after widening). (Bug#10360)
958 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
960 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
962 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
964 * nsterm.m (x_free_frame_resources):
965 Release f->output_data.ns->miniimage.
966 (ns_index_color): Fix indentation. Do not retain
967 color_table->colors[i].
969 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
972 * nsfns.m (x_set_background_color): Assign return value from
973 ns_index_color to face-background instead of NSColor*.
974 (ns_implicitly_set_icon_type): Fix indentation.
975 Change assignment in for loop to comparison.
977 * emacs.c (ns_pool): New variable.
978 (main): Assign ns_pool.
979 (Fkill_emacs): Call ns_release_autorelease_pool.
981 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
982 autorelease fdesc, release fdAttrs and tdict.
983 (ns_get_covering_families): Release charset.
984 (ns_findfonts): Release NSFontDescriptor created with new.
985 (ns_uni_to_glyphs): Fix indentation.
986 (setString): Release attrStr before assigning new value.
988 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
990 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
992 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
993 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
995 2011-12-18 David Reitter <reitter@cmu.edu>
997 * nsterm.m (ns_term_init): Subscribe for notifications
998 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
999 to method trackingNotification in EmacsMenu.
1001 * nsmenu.m (trackingMenu): New variable.
1002 (trackingNotification): New method (from Aquamacs).
1003 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1004 from Aquamacs (Bug#7030).
1006 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1008 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1009 (symbol_to_nsstring): Fix indentation.
1010 (ns_symbol_to_pb): New function.
1011 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1012 (Fns_rotate_cut_buffers_internal): Remove.
1013 (Fns_store_selection_internal): Rename from
1014 Fns_store_cut_buffer_internal.
1015 (ns_get_foreign_selection, Fx_own_selection_internal)
1016 (Fx_disown_selection_internal, Fx_selection_exists_p)
1017 (Fns_get_selection_internal, Fns_store_selection_internal):
1018 Use ns_symbol_to_pb and check if return value is nil.
1019 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1020 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1021 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1022 renamed to Sns_store_selection_internal.
1023 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1024 and remove this function.
1025 (ns_handle_selection_clear): Remove, never used.
1026 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1029 2011-12-17 Ken Brown <kbrown@cornell.edu>
1031 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1032 GID is unknown (Bug#10257).
1034 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1036 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1037 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1038 which caused a build failure on GNU/Linux IA-64. This problem was
1039 introduced by my 2011-10-07 patch.
1041 2011-12-15 Juri Linkov <juri@jurta.org>
1043 * image.c (imagemagick_error): New function. (Bug#10112)
1044 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1045 Use `imagemagick_error' where ImageMagick functions return
1047 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1050 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1052 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1053 fill background (Bug#8992).
1055 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1057 * window.c (Vwindow_combination_resize)
1058 (Vwindow_combination_limit): Use t instead of non-nil in
1060 (Vrecenter_redisplay): Add first sentence of doc-string on
1062 (Frecenter): Fix doc-string typo.
1064 2011-12-11 Kenichi Handa <handa@m17n.org>
1066 * coding.c (Funencodable_char_position): Pay attention to the
1067 buffer text relocation (Bug#9389).
1069 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1071 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1072 gtk_init (Bug#10100).
1074 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1076 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1077 IT->string is nil. (Bug#10263)
1079 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1081 * nsterm.h (x_free_frame_resources): Declare.
1083 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1084 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1086 * nsterm.h (ns_get_defaults_value): Declare.
1088 * nsterm.m (ns_default): Call ns_get_defaults_value.
1090 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1092 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1095 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1097 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1098 that where the value of an _OBJC_* symbol points to is in the .bss
1099 section (Bug#10240).
1101 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1103 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1104 after the loop to call ccl_driver at least once (Bug#8619).
1106 2011-12-08 Kenichi Handa <handa@m17n.org>
1108 * ftfont.c (get_adstyle_property): Fix previous change
1111 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1113 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1114 dirs from the default value of EMACSLOADPATH (bug#10208).
1116 2011-12-07 Glenn Morris <rgm@gnu.org>
1118 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1119 installation and source directories as well. (Bug#10208)
1121 2011-12-06 Chong Yidong <cyd@gnu.org>
1123 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1125 2011-12-06 Glenn Morris <rgm@gnu.org>
1127 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1128 as an error, not just -1. (Bug#10217)
1130 2011-12-05 Chong Yidong <cyd@gnu.org>
1132 * keyboard.c (process_special_events): New function.
1133 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1135 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1137 * coding.c (encode_designation_at_bol): Don't use uninitialized
1138 local variable (Bug#9318).
1140 2011-12-05 Kenichi Handa <handa@m17n.org>
1142 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1143 return Qnil (Bug#8046, Bug#10193).
1145 2011-12-05 Kenichi Handa <handa@m17n.org>
1147 * coding.c (encode_designation_at_bol): New args charbuf_end and
1148 dst. Return the number of produced bytes. Callers changed.
1149 (coding_set_source): Return how many bytes coding->source was
1151 (coding_set_destination): Return how many bytes
1152 coding->destination was relocated.
1153 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1154 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1156 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1158 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1159 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1162 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1164 The following changes are to fix Bug#9318.
1166 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1167 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1168 (encode_coding_iso_2022, encode_coding_sjis)
1169 (encode_coding_big5, encode_coding_charset): Use the above macros.
1171 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1173 * lisp.h (process_quit_flag): Fix external declaration.
1175 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1177 Don't macro-inline non-performance-critical code.
1178 * eval.c (process_quit_flag): New function.
1179 * lisp.h (QUIT): Use it.
1181 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1183 * nsfns.m (get_geometry_from_preferences): New function.
1184 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1186 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1188 * emacs.c (Qkill_emacs): Define.
1189 (syms_of_emacs): Initialize it.
1190 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1191 Qquit_flag to `kill-emacs' instead.
1192 (quit_throw_to_read_char): Add parameter `from_signal'.
1193 All callers changed. Call Fkill_emacs if requested and safe.
1194 * lisp.h (QUIT): Call Fkill_emacs if requested.
1196 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1198 * widget.c (update_wm_hints): Return if wmshell is null.
1199 (widget_update_wm_size_hints): New function.
1201 * widget.h (widget_update_wm_size_hints): Declare.
1203 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1204 widget_update_wm_size_hints (Bug#10104).
1206 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1208 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1209 before a newline, prepare the bidi iterator for consuming the
1210 newline, and keep the current paragraph direction. (Bug#10183)
1211 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1213 2011-12-02 Juri Linkov <juri@jurta.org>
1215 * search.c (Fword_search_regexp): New Lisp function created from
1216 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1217 (Fword_search_backward, Fword_search_forward)
1218 (Fword_search_backward_lax, Fword_search_forward_lax):
1219 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1220 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1222 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1224 * fileio.c (Finsert_file_contents): Move after-change-function call
1225 to before the "handled:" label, since all "goto handled" appear in
1226 cases where the *-change-functions have already been properly called
1229 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1231 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1232 waiting for input. (Bug#10169)
1234 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1236 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1237 verifies glyph row's hash code--we have just reallocated the
1238 glyphs, so their contents can be complete garbage. (Bug#10164)
1240 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1242 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1244 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1246 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1247 attributes are tested _before_ calling verify_row_hash, to protect
1248 against GCC re-ordering of the tests. (Bug#10164)
1250 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1252 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1254 * xterm.c (handle_one_xevent): Only set async_visible and friends
1255 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1256 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1257 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1259 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1261 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1262 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1263 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1264 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1265 All uses changed to use GCPRO1 etc.
1266 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1267 Revert to old implementation (i.e., before 2011-03-11).
1269 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1271 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1272 of scroll runs so as to avoid assigning disabled bogus rows and
1273 unnecessary graphics copy operations.
1275 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1277 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1278 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1279 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1280 (malloc, free, realloc, calloc): Redirect to e_* only when
1283 * lisp.h (GCTYPEBITS): Move before first use.
1284 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1285 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1286 this macro definition.
1288 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1291 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1293 * gtkutil.c (xg_create_frame_widgets):
1294 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1295 present with Gtk+ 2.0.
1297 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1299 * fileio.c (Finsert_file_contents): Undo previous change; see
1300 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1302 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1304 Rename locals to avoid shadowing.
1305 * fileio.c (Finsert_file_contents):
1306 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1307 * process.c (wait_reading_process_output):
1308 Rename inner 'proc' to 'p' to avoid shadowing.
1309 Indent for consistency with usual Emacs style.
1311 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1313 * xdisp.c (redisplay_window): If cursor row is not fully visible
1314 after recentering, and scroll-conservatively is set to a large
1315 number, scroll window by a few more lines to make the cursor fully
1316 visible and out of scroll-margin. (Bug#10105)
1317 (start_display): Don't move to the next line if the display should
1318 start at a newline that is part of a display vector or an overlay
1321 2011-11-24 Juri Linkov <juri@jurta.org>
1323 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1324 after the `MagickPingImage' call. (Bug#10112)
1326 2011-11-23 Chong Yidong <cyd@gnu.org>
1328 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1330 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1332 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1333 making another buffer current. (Bug#10114)
1335 2011-11-23 Glenn Morris <rgm@gnu.org>
1337 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1339 2011-11-23 Chong Yidong <cyd@gnu.org>
1341 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1342 using it (Bug#5984).
1344 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1346 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1347 and header-lines, as they don't have one computed for them.
1350 * .gdbinit (prow): Make displayed values more self-explaining.
1351 Add row's hash code.
1353 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1355 * process.c (wait_reading_process_output): Fix asynchrounous
1356 GnuTLS socket handling on some versions of the GnuTLS library.
1357 (wait_reading_process_output): Add comment and URL.
1359 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1361 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1363 2011-11-21 Chong Yidong <cyd@gnu.org>
1365 * window.c (Fnext_window, Fprevious_window): Doc fix.
1367 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1369 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1371 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1373 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1375 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1377 * window.c (Fset_window_combination_limit): Rename argument
1379 (Vwindow_combination_limit): Remove "status" from doc-string.
1381 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1383 * m/ibms390.h: Remove.
1384 * m/ibms390x.h: Don't include "ibms390.h".
1386 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1388 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1389 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1391 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1393 * casetab.c (Fset_case_table):
1394 * charset.c (Fcharset_after): Fix typos.
1396 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1398 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1399 Otherwise, valgrind does not work on some platforms.
1400 Problem reported by Andreas Schwab in
1401 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1402 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1403 is set, removing the need for VIRT_ADDRESS_VARIES.
1404 (PURE_P): Use a more-efficient implementation that needs just one
1405 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1406 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1407 to 4 (xorl, subq, cmpq, setbe).
1408 * alloc.c (pure): Always extern now, since that's the
1409 VIRT_ADDR_VARIES behavior.
1410 (PURE_POINTER_P): Use a single comparison, not two, for
1411 consistency with the new puresize.h.
1412 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1413 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1414 Remove VIRT_ADDR_VARIES no longer needed.
1416 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1418 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1419 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1420 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1421 behave as if the cursor position were at the window margin.
1423 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1424 and the cursor position is out of bounds, behave as if the cursor
1425 position were at the window margin. (Bug#10075)
1427 2011-11-18 Chong Yidong <cyd@gnu.org>
1429 * window.c (Fwindow_combination_limit): Make first argument
1430 non-optional, since it is meaningless for live windows like the
1433 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1435 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1437 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1439 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1440 (graft_intervals_into_buffer): Simplify.
1442 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1444 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1445 hash values of the two rows.
1446 (copy_row_except_pointers): Preserve the used[] arrays and the
1447 hash values of the two rows. (Bug#10035)
1448 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1450 * xdisp.c (row_hash): New function, body extracted from
1451 compute_line_metrics.
1452 (compute_line_metrics): Call row_hash, instead of computing the
1455 * dispnew.c (verify_row_hash): Call row_hash for computing the
1456 hash code of a row, instead of duplicating code from xdisp.c.
1458 * dispextern.h (row_hash): Add prototype.
1460 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1462 * frame.c (delete_frame): Don't delete the terminal when the last
1463 X frame is closed if emacs is built with GTK toolkit.
1465 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1467 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1469 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1471 * window.c (Vwindow_splits): Rename to
1472 Vwindow_combination_resize. Suggested by Juri Linkov.
1473 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1476 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1478 * nsfns.m (Fns_font_name):
1479 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1481 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1483 * window.h (window): Rename slot "nest" to "combination_limit".
1484 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1485 (Fset_window_nest): Rename to Fset_window_combination_limit.
1486 (Vwindow_nest): Rename to Vwindow_combination_limit.
1487 (recombine_windows, make_parent_window, make_window)
1488 (Fsplit_window_internal, saved_window)
1489 (Fset_window_configuration, save_window_save): Rename all
1490 occurrences of window_nest to window_combination_limit.
1492 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1494 * image.c (imagemagick_load_image): Fix typo.
1496 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1498 * xdisp.c (display_line): Move the call to
1499 highlight_trailing_whitespace before the call to
1500 compute_line_metrics, since the latter needs to see the final
1501 faces of all the glyphs to compute ROW's hash value.
1502 Fixes assertion violations in row_equal_p. (Bug#10035)
1504 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1506 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1507 just return (bug#10044).
1509 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1511 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1512 with user-defined heap size. Bump the default size of the temacs
1513 heap to 27MB, to avoid memory warning when running temacs.
1514 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1516 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1517 current_matrix and desired_matrix. (Bug#9990)
1518 (verify_row_hash) [XASSERTS]: New function.
1519 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1520 that the hash value of glyph rows is correct.
1522 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1524 * window.h (window): Remove splits slot.
1525 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1526 (Fdelete_other_windows_internal, make_parent_window)
1527 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1528 (Fset_window_configuration, save_window_save): Don't deal with
1529 split status of windows.
1530 (saved_window): Remove splits slot.
1531 (Vwindow_splits): Rewrite doc-string.
1533 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1535 * xfns.c (unwind_create_frame):
1536 * nsfns.m (unwind_create_frame):
1537 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1538 Vframe_list (Bug#9999).
1540 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1542 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1544 2011-11-11 Kenichi Handa <handa@m17n.org>
1546 * callproc.c (Fcall_process): Set the member dst_multibyte of
1549 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1551 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1552 avoid a crash (bug#9496).
1554 2011-11-09 Chong Yidong <cyd@gnu.org>
1556 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1557 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1559 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1561 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1563 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1565 Avoid some portability problems by eschewing 'extern inline' functions.
1566 The trivial performance wins aren't worth the portability hassles; see
1567 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1569 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1570 (window_box_width, window_box_left, window_box_left_offset)
1571 (window_box_right, window_box_right_offset): Undo previous change,
1572 by removing the "extern"s.
1573 * intervals.c (adjust_intervals_for_insertion)
1574 (adjust_intervals_for_deletion): Undo previous change,
1575 making these static again.
1576 (offset_intervals, temp_set_point_both, temp_set_point)
1577 (copy_intervals_to_string): No longer inline.
1578 * xdisp.c (window_text_bottom_y, window_box_width)
1579 (window_box_height, window_box_left_offset)
1580 (window_box_right_offset, window_box_left, window_box_right)
1581 (window_box): No longer inline.
1583 2011-11-08 Chong Yidong <cyd@gnu.org>
1585 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1586 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1587 Signal an error if not a live window.
1588 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1589 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1591 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1593 * lisp.h (syms_of_abbrev): Remove declaration.
1594 Reported by CHENG Gao <chenggao@royau.me>.
1596 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1598 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1599 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1600 of temacs in GUI mode.
1602 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1604 * window.h: Declare delete_all_child_windows instead of
1605 delete_all_subwindows.
1606 * window.c (Fwindow_nest, Fset_window_nest)
1607 (Fset_window_new_total, Fset_window_new_normal)
1608 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1609 (delete_all_subwindows): Rename to delete_all_child_windows.
1610 (Fdelete_other_windows_internal, Fset_window_configuration):
1611 Call delete_all_child_windows instead of delete_all_subwindows.
1612 * frame.c (delete_frame): Call delete_all_child_windows instead
1613 of delete_all_subwindows.
1615 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1617 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1618 This is also needed for porting to any host where GC_MARK_STACK is
1619 not GC_MAKE_GCPROS_NOOPS.
1620 (which_symbols): Use it.
1622 2011-11-07 Kenichi Handa <handa@m17n.org>
1624 * coding.c (coding_set_destination): Check coding->src_pos only
1625 when coding->src_object is a buffer (bug#9910).
1627 * process.c (send_process): Set the member src_multibyte of coding
1628 to 0 (bug#9911) when sending a unibyte text.
1630 * callproc.c (Fcall_process): Set the member src_multibyte of
1631 process_coding to 0 (bug#9912).
1633 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1635 * xmenu.c (cleanup_widget_value_tree): New function.
1636 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1637 calling free_menubar_widget_value_tree directly (Bug#9830).
1639 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1641 Fix some portability problems with 'inline'.
1642 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1643 (window_box_width, window_box_left, window_box_left_offset)
1644 (window_box_right, window_box_right_offset): Declare extern.
1645 Otherwise, these inline functions do not conform to C99 and
1646 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1647 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1648 * intervals.c (adjust_intervals_for_insertion)
1649 (adjust_intervals_for_deletion): Now extern, because otherwise the
1650 extern inline functions 'offset_intervals' couldn't refer to it.
1651 (static_offset_intervals): Remove.
1652 (offset_intervals): Rewrite using the old contents of
1653 static_offset_intervals. The old version didn't conform to C99
1654 because an extern inline function contained a reference to an
1655 identifier with static linkage.
1657 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1659 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1662 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1664 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1665 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1666 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1667 return Qleft_to_right.
1669 2011-11-06 Chong Yidong <cyd@gnu.org>
1671 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1672 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1673 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1674 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1675 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1676 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1677 (Fwindow_vscroll): Doc fix.
1678 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1679 argument, since it makes no sense to pass a live window and for
1680 consistency with window-child.
1682 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1684 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1687 2011-11-05 Jason Rumney <jasonr@gnu.org>
1689 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1690 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1692 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1693 bitwise arithmetic preventing use of unicode-sip and non-truetype
1696 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1698 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1701 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1702 initialization code to keep similarity to xfns.c after changes
1705 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1707 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1708 (unwind_create_frame): New function (Bug#9943).
1709 (Fx_create_frame): Restructure code to be more similar to the one in
1710 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1711 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1712 Move terminal->reference_count++ just before making the frame official
1715 * nsterm.m (x_free_frame_resources): New function.
1716 (x_destroy_window): Move code to x_free_frame_resources.
1718 * xfns.c (unwind_create_frame): Fix comment.
1719 (Fx_create_frame, x_create_tip_frame):
1720 Move terminal->reference_count++ just before making the frame
1721 official. Move initialization of image_cache_refcount and
1722 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1724 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1726 Support MSVC build with newer versions of Visual Studio.
1727 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1728 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1731 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1732 which are not supported by MSVC.
1733 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1734 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1736 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1738 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1740 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1742 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1744 Support MSVC build with newer versions of Visual Studio.
1745 * w32.c: Don't include w32api.h for MSVC.
1746 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1748 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1749 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1750 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1751 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1753 (alloca) [_MSC_VER]: Define to _alloca.
1755 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1757 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1759 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1761 * xdisp.c (note_mouse_highlight): If either of
1762 previous/next-single-property-change returns nil, treat that as
1763 the beginning or the end of the buffer. (Bug#9955)
1765 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1767 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1768 label is not null (Bug#9951).
1769 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1772 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1774 * window.c (Fwindow_body_size): Mention in the doc string that the
1775 return value is in frame's canonical units. (Bug#9949)
1777 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1779 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1781 * w32fns.c (unwind_create_frame): If needed, free the glyph
1782 matrices of the partially constructed frame. (Bug#9943)
1783 * xfns.c (unwind_create_frame): Likewise.
1785 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1787 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1788 Don't stop backward scan on the continuation glyph, even though
1789 its CHARPOS is positive.
1790 (mouse_face_from_buffer_pos, note_mouse_highlight):
1791 Rename cover_string to disp_string.
1793 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1795 * window.c (temp_output_buffer_show): Don't use
1796 Vtemp_buffer_show_specifiers.
1797 (Vtemp_buffer_show_specifiers): Remove unused variable.
1799 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1801 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1802 past the beginning of the current glyph matrix.
1804 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1806 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1807 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1808 HAVE_GTK3 (Bug#9869).
1810 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1811 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1813 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1815 * xterm.c: Declare x_handle_net_wm_state to return int.
1816 (handle_one_xevent): Check if we are iconified but don't have
1817 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1818 (get_current_wm_state): Return non-zero if not hidden,
1819 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1820 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1821 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1822 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1824 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1826 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1827 so that this new function doesn't get optimized away by a
1828 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1830 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1832 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1834 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1836 Fix the `xbytecode' command.
1837 * .gdbinit (xprintbytestr): New command.
1838 (xwhichsymbols): Rename from `which'; all callers changed.
1839 (xbytecode): Print the byte-code string as well.
1841 2011-10-29 Kim Storm <storm@cua.dk>
1843 * alloc.c (which_symbols): New function.
1845 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1847 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1850 2011-10-29 Glenn Morris <rgm@gnu.org>
1852 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1853 Not clear what it was for, and it causes various bugs. (Bug#9839)
1855 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1857 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1858 possible random value that matches one of those tested as
1859 condition to clear the mouse face.
1861 2011-10-28 Chong Yidong <cyd@gnu.org>
1863 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1865 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1867 * window.c (make_window): Initialize phys_cursor_on_p.
1869 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1871 * lisp.h (struct Lisp_Symbol): Update comments.
1873 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1875 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1877 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1879 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1880 <oslsachem@gmail.com> for helping to debug this.
1882 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1883 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1884 (g_b_init_get_glyph_outline_w): New static variables.
1885 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1886 (GetGlyphOutlineW_Proc): New typedefs.
1887 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1888 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1890 (w32font_open_internal, compute_metrics):
1891 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1892 instead of calling the "wide" APIs directly.
1894 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1896 * w32.h (syms_of_w32font): Add prototype.
1898 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1900 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1901 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1902 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1903 (Fmove_to_window_line): Doc fix.
1905 2011-10-27 Chong Yidong <cyd@gnu.org>
1907 * process.c (make_process): Set gnutls_state to NULL.
1909 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1910 non-NULL, regardless of GNUTLS_INITSTAGE.
1911 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1912 an error. Set process slots as soon as we allocate them.
1914 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1916 2011-10-27 Chong Yidong <cyd@gnu.org>
1918 * gnutls.c (emacs_gnutls_deinit): New function.
1919 Deallocate credentials structures as well as calling gnutls_deinit.
1920 (Fgnutls_deinit, Fgnutls_boot): Use it.
1922 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1923 (deactivate_process): Call emacs_gnutls_deinit.
1925 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1927 * image.c (x_create_x_image_and_pixmap):
1928 * w32.c (sys_rename, w32_delayed_load):
1929 * w32font.c (fill_in_logfont):
1930 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1932 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1934 * w32fns.c (w32_default_color_map): New function,
1935 extracted from Fw32_default_color_map.
1936 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1938 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1940 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1942 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1944 * keyboard.c (test_undefined): New function (bug#9751).
1945 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1947 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1949 * sysdep.c (init_sys_modes): Fix the check for the controlling
1950 terminal (Bug#6649).
1952 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1954 * dispextern.h (struct bidi_it): New member next_en_type.
1956 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1957 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1958 current character, check also for next_en_type being WEAK_EN.
1959 (bidi_resolve_weak): Don't enter the expensive loop if the current
1960 position is before next_en_pos. Record the bidi type of the first
1961 non-ET, non-BN character we find, in addition to its position.
1962 (bidi_level_of_next_char): Invalidate next_en_type when
1963 next_en_pos is over-stepped.
1965 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1967 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1968 * editfns.c: Rewrite current-time-zone so that it invokes
1969 the equivalent of (format-time-string "%Z") to get the time zone name.
1970 This fixes a bug when the time zone name contains characters that
1971 need converting from the system time locale to Emacs internal format.
1972 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1973 that patch fixed format-time-string to do the conversion, but
1974 I forgot to fix current-time-zone.
1975 (format_time_string): New function, containing most of
1976 what Fformat_time_string used to contain.
1977 (Fformat_time_string): Rewrite in terms of format_time_string.
1978 This doesn't change this function's behavior.
1979 (current-time-zone): Rewrite to use format_time_string.
1980 This fixes the bug reported by Michael Schierl in
1981 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1982 Jason Rumney's 2007-06-07 change worked around this bug, but
1984 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1986 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1988 * xdisp.c (start_display): If the character at POS is displayed
1989 via a display vector, reset IT->current.dpvec_index to zero.
1990 (try_window_reusing_current_matrix): If a line ends in a display
1991 vector or the next line starts in a display vector, continue
1992 redrawing the window even though the character position of
1993 start_row was reached.
1996 2011-10-18 Chong Yidong <cyd@gnu.org>
1998 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1999 with nobreak-char-display too.
2001 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2003 Fix part 3 of bug#9771.
2004 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2005 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2006 non-neutral characters if the current character is a paragraph
2007 separator (a.k.a. Newline). This avoids running the same
2008 expensive loop twice, once when we consume the preceding newline
2009 and the other time when the line actually needs to be displayed.
2010 Avoid the loop when we see neutrals on the base embedding level
2011 following a character whose directionality is the same as the
2012 paragraph's. This avoids running the expensive loop when a line
2013 ends in a long sequence of neutrals, like control characters.
2014 Add assertion against STRONG_AL type. Slightly rearrange code
2015 that determines the type of a neutral given the first non-neutral
2017 (bidi_level_of_next_char): Set next_en_pos to zero when
2018 invalidating its info.
2020 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2022 * xdisp.c (push_display_prop): Determine whether to record string
2023 or buffer position by IT->string, not by IT->method. Allow
2024 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2025 (move_it_vertically_backward): Don't look for character position
2026 immediately after the newline when in a continuation line.
2029 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2031 * window.c (coordinates_in_window): Rewrite and delabelize
2032 vertical border check. (Bug#5357) (Bug#9618)
2034 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2036 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2037 errors in XSetWindowBorder (bug#9310).
2039 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2041 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2042 avoid crash when xmalloc overrun checking is enabled.
2044 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2046 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2047 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2048 cursor motion with <left> and <right> arrow keys.
2050 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2051 some callers set that themselves.
2053 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2055 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2056 display string and the previous row comes from the same string and
2057 is empty. (Bug#9739) (Bug#9738)
2059 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2061 * doc.c (get_doc_string): Encode file name (bug#9735).
2063 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2065 * bidi.c (bidi_level_of_next_char):
2066 * xdisp.c (get_visually_first_element): Remove old incorrect
2067 comments regarding the Unicode Line Separator character.
2069 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2071 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2073 * alloc.c (Fgc_status): Do not access beyond zombies array
2074 boundary if nzombies > MAX_ZOMBIES.
2075 * alloc.c (dump_zombies): Add missing format specifier.
2077 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2079 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2080 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2082 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2083 Some packages use them to denote characters with modifiers.
2085 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2087 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2088 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2089 matching a pp-number. Rename parameter var to var1.
2091 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2093 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2095 2011-10-08 Glenn Morris <rgm@gnu.org>
2097 * callint.c (Fcall_interactively): Give a more explicit error for the
2098 'c' case with a non-character input. (Bug#8479)
2100 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2102 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2104 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2105 lines that are hscrolled on the left.
2107 * dispnew.c (buffer_posn_from_coords): Account for a possible
2108 presence of header-line. (Bug#4426)
2110 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2112 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2113 Don't advertise functionality which we discourage or doesn't work.
2115 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2117 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2118 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2119 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2120 this makes Emacs dump core during garbage collection on rare
2121 occasions. sizeof is obviously inferior to offsetof here, so
2122 stick with offsetof.
2123 (GC_POINTER_ALIGNMENT): New macro.
2124 (mark_memory): Omit 3rd (offset) arg; caller changed.
2125 Don't assume EMACS_INT alignment is the same as pointer alignment.
2127 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2129 * keyboard.c (read_key_sequence_remapped): New var.
2130 (read_key_sequence): Compute remapping in the right buffer.
2131 (command_loop_1): Use read_key_sequence's remapping directly.
2133 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2135 * dired.c (file_name_completion): Don't expand file name.
2136 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2137 before checking file name handler.
2139 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2140 they've been requested explicitly (bug#9591).
2142 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2144 * keymap.c (Fsingle_key_description): Use make_specified_string
2145 instead of build_string to build string from push_key_description.
2148 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2150 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2151 This fixes a Y2038 bug on 64-bit hosts.
2152 * buffer.c (reset_buffer):
2153 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2154 (Fclear_buffer_auto_save_failure):
2155 Use 0, not -1, to represent an unset failure time, since time_t
2156 might not be signed.
2158 Remove dependency on glibc malloc internals.
2159 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2160 Move back here from lisp.h, but with their new implementations.
2161 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2162 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2163 * charset.c (charset_table_init): New static var.
2164 (syms_of_charset): Use it instead of xmalloc. This removes a
2165 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2166 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2167 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2168 Move back to alloc.c.
2169 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2170 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2172 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2174 * nsterm.m (windowDidResize): Call x_set_window_size only when
2175 ns_in_resize is true. Otherwise set pixelwidth/height and
2176 call change_frame_size (Bug#9628).
2178 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2180 Port --enable-checking=all to Fedora 14 x86-64.
2181 * charset.c (syms_of_charset): Also account for glibc malloc's
2182 internal overhead when calculating the initial malloc maximum.
2184 Port --enable-checking=all to Fedora 14 x86.
2185 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2187 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2188 (overrun_check_realloc, overrun_check_free):
2189 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2190 That way, xmalloc returns a properly-aligned pointer even if
2191 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2192 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2193 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2194 into account when calculating the initial malloc maximum.
2195 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2196 Move here from alloc.c, so that charset.c can use it too.
2197 Properly align; the old code wasn't right for common 32-bit hosts
2198 when configured with --enable-checking=all.
2199 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2200 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2202 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2204 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2207 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2209 * xdisp.c (compute_display_string_end): If there's no display
2210 string at CHARPOS, return -1.
2212 * bidi.c (bidi_fetch_char): When compute_display_string_end
2213 returns a negative value, treat the character as a normal
2214 character not covered by a display string. (Bug#9624)
2216 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2218 * lread.c (Fread_from_string): Fix typo in docstring.
2220 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2222 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2223 newline, reseat the iterator instead of bidi-iterating there one
2224 character at a time. (Bug#9610)
2225 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2226 TO_CHARPOS if the bidi iterator is at base embedding level.
2228 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2230 * lread.c (readevalloop): Use correct code for NBSP.
2231 (read1): Likewise. (Bug#9608)
2233 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2235 * dbusbind.c (Fdbus_register_signal): When service is not
2236 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2238 2011-09-25 Glenn Morris <rgm@gnu.org>
2240 * buffer.c (truncate-lines): Doc fix.
2242 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2244 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2245 (Fset_window_next_buffers): Doc fix.
2247 2011-09-24 Glenn Morris <rgm@gnu.org>
2249 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2251 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2253 Fix minor problems found by static checking.
2254 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2255 * indent.c (Fvertical_motion): Fix == vs = typo.
2257 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2259 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2260 Default value is now t. Doc fix.
2262 * indent.c (Fvertical_motion): Compute and apply the overshoot
2263 logic when moving up, not only when moving down. Fix the
2264 confusing name and values of the it_overshoot_expected variable;
2265 logic changes accordingly. (Bug#9254) (Bug#9549)
2267 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2268 CHARPOS is covered by a display string which includes newlines.
2269 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2270 is covered by a display string with embedded newlines.
2272 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2274 * dbusbind.c (Fdbus_register_signal): Add match rule to
2275 Vdbus_registered_objects_table. (Bug#9581)
2276 (Fdbus_register_method, Vdbus_registered_objects_table):
2279 2011-09-24 Jim Meyering <meyering@redhat.com>
2281 do not ignore write error for any output size
2282 The previous change was incomplete.
2283 While it makes emacs --batch detect the vast majority of stdout
2284 write failures, errors were still ignored whenever the output size is
2285 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2286 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2287 && echo FAIL: ignored write error
2288 FAIL: ignored write error
2289 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2290 && echo FAIL: ignored write error
2291 FAIL: ignored write error
2292 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2294 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2296 * emacs.c (Fkill_emacs): In noninteractive mode exit
2297 non-successfully if a write error occurred on stdout. (Bug#9574)
2299 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2301 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2304 * dispextern.h (struct it): Update the comment documenting what
2307 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2309 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2310 a display string, extend search for cursor position to end of row.
2311 (find_row_edges): If the row ends in a newline from a display
2312 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2313 Handle the case of a display string with multiple newlines.
2314 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2315 non-empty line. Fixes confusing cursor motion with arrow keys at
2316 the beginning of a line that starts with whitespace.
2318 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2320 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2323 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2325 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2328 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2330 * xdisp.c (display_line): Record maximum and minimum buffer
2331 positions even if no glyphs were produced (e.g., by a zero-width
2332 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2333 buffer positions that will be removed from the glyph row because
2335 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2336 column is beyond frame width: don't subtract 1 "pixel" when
2337 computing width of the stretch.
2338 (reseat_at_next_visible_line_start): Undo the change made on
2339 2011-09-17 that saved paragraph information and restored it after
2340 the call to `reseat'. (Bug#9545)
2342 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2344 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2345 and turn window cursor on if cleared (Bug#9415).
2347 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2349 * search.c (boyer_moore): Take unibyte characters from pattern
2350 literally. (Bug#9458)
2352 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2354 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2356 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2358 Fix minor problem found by static checking.
2359 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2360 initialized, to pacify gcc -Wuninitialized.
2362 * fileio.c: Report proper errno when syscall falls.
2363 (Finsert_file_contents): Save and restore errno,
2364 so that report_file_error outputs the correct diagnostic.
2365 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2367 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2369 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2371 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2373 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2374 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2376 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2378 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2379 about the current paragraph and restore it after the call to reseat.
2381 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2382 (bidi_find_paragraph_start): Search back for paragraph beginning
2383 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2384 (bidi_move_to_visually_next): Only trigger paragraph-related
2385 computations when the last character is a newline or at EOB, not
2386 just any NEUTRAL_B. (Bug#9470)
2388 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2389 truncated lines if point is covered by a display string. (Bug#9524)
2391 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2393 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2394 (cons_to_x_long): New function.
2395 (lisp_data_to_selection_data): Use it. Correct the test for
2396 short-versus-long data; it was negated. Break out of vector
2397 loop, for efficiency, when a long datum is discovered.
2399 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2401 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2403 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2405 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2406 GCC PR/17406) by declaring this function with external scope.
2408 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2410 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2411 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2413 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2415 * editfns.c (Fformat): Correctly handle text properties on "%%".
2417 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2419 * xterm.c (x_draw_composite_glyph_string_foreground):
2420 * w32term.c (x_draw_composite_glyph_string_foreground):
2421 * term.c (encode_terminal_code):
2422 * composite.c (composition_update_it, get_composition_id):
2423 * xdisp.c (get_next_display_element)
2424 (fill_composite_glyph_string): Add comments about special meaning
2425 of TAB characters in a composition.
2427 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2429 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2430 This occurs when processing a multibyte format.
2431 Problem reported by Wolfgang Jenker.
2433 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2435 * xdisp.c (try_cursor_movement): Only check for exact match if
2436 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2438 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2440 Remove unused external symbols.
2441 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2442 * xdisp.c (calc_pixel_width_or_height): Now static.
2443 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2444 * indent.c (check_display_width):
2445 * w32term.c: Fix comment to match code.
2446 * xterm.c, xterm.h (x_catching_errors): Remove.
2448 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2450 * xselect.c: Use signed conversions more consistently (Bug#9498).
2451 (selection_data_to_lisp_data): Assume incoming selection data are
2452 signed integers, not unsigned. This is to be consistent with
2453 outgoing selection data, which was modified to use signed integers
2454 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2455 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2456 expects long, not unsigned long.
2458 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2460 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2461 computation of loop end. Reported by Johan Bockgård
2464 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2466 * frame.c (Fother_visible_frames_p): Function deleted.
2468 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2470 * indent.c (compute_motion): Process display vector front to back
2471 rather than the other way around. (Bug#2496)
2473 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2475 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2477 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2479 * minibuf.c (Fread_from_minibuffer): Doc fix.
2481 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2483 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2484 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2486 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2488 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2489 value for non-existent files.
2491 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2493 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2494 set its "size" to -1. This will set the modtime_size field of
2495 the corresponding buffer to -1, which is what
2496 verify-visited-file-modtime expects for files that do not exist.
2499 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2501 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2503 * lisp.h: ... from here. push_key_description is no longer
2504 defined in keyboard.c, so its declaration should not be in
2505 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2506 logically belongs with push_key_description.
2508 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2510 * buffer.h: Include <sys/types.h> instead of <time.h>.
2511 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2512 Problem reported by Herbert J. Skuhra.
2514 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2516 * xml.c (parse_region): Make the parsing work for
2517 non-comment-starting XML files again (bug#9144).
2519 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2521 * image.c (gif_load): Fix calculation of bottom and right corner.
2524 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2526 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2527 redisplay in small windows.
2529 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2531 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2533 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2535 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2536 Operate on live windows only.
2538 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2540 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2542 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2544 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2545 only under bidi iteration.
2547 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2549 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2551 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2553 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2554 Without this fix, the command to link temacs failed due to an
2555 undefined symbol __builtin_isnan. This is because
2556 /usr/include/iso/math_c99.h #defines isnan(x) to
2557 __builtin_isnan(x), but the bundled gcc, which identifies itself
2558 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2560 * floatfns.c (isnan): #undef, and then #define to a clone of
2562 (Fisnan): Always define, since it's always available now.
2563 (syms_of_floatfns): Always define isnan at the Lisp level.
2565 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2567 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2569 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2571 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2572 The previous code assumed that file offsets (off_t values) fit in
2573 EMACS_INT variables, which is not true on typical 32-bit hosts.
2574 The code messed up by falsely reporting buffer overflow in cases
2575 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2576 when "big" contains more than 2**29 bytes, even though this
2577 inserts just one byte and does not overflow the buffer.
2578 (Finsert_file_contents): Store file offsets as off_t
2579 values, not as EMACS_INT values. Check for overflow when
2580 converting between EMACS_INT and off_t. When checking for
2581 buffer overflow or for overlap, take the offsets into account.
2582 Don't use EMACS_INT for small values where int suffices.
2583 When checking for overlap, fix a typo: ZV was used where
2584 ZV_BYTE was intended.
2585 (Fwrite_region): Don't assume off_t fits into 'long'.
2586 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2588 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2590 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2592 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2594 sprintf-related integer and memory overflow issues (Bug#9412).
2596 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2597 (esprintf, exprintf, evxprintf): New functions.
2598 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2599 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2600 (modify_event_symbol): Do not assume that the length of
2601 name_alist_or_stem is safe to alloca and fits in int.
2602 (Fexecute_extended_command): Likewise for function name and binding.
2603 (Frecursion_depth): Wrap around reliably on integer overflow.
2604 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2605 since some callers pass EMACS_INT values.
2606 (Fsingle_key_description): Don't crash if symbol name contains more
2607 than MAX_ALLOCA bytes.
2608 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2609 (get_minibuffer): Arg is now EMACS_INT, not int.
2610 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2611 (esprintf, exprintf, evxprintf): New decls.
2612 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2614 * dbusbind.c (signature_cat): New function.
2615 (xd_signature, Fdbus_register_signal):
2616 Do not overrun buffer; instead, report string overflow.
2618 * dispnew.c (add_window_display_history): Don't overrun buffer.
2619 Truncate instead; this is OK since it's just a log.
2621 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2622 even if the time zone offset is outlandishly large.
2623 Don't mishandle offset == INT_MIN.
2625 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2626 when creating daemon; the previous buffer-overflow check was incorrect.
2628 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2629 which has the guts of the old verror function.
2631 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2632 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2634 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2635 (font_unparse_xlfd): Don't blindly alloca long strings.
2636 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2637 fits in int, when using sprintf. Use single snprintf to count
2638 length of string rather than counting it via multiple sprintfs;
2639 that's simpler and more reliable.
2640 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2641 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2642 sprintf, in case result does not fit in int.
2644 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2645 (fontset_from_font): Print it.
2647 * frame.c (tty_frame_count): Now printmax_t, not int.
2648 (make_terminal_frame, set_term_frame_name): Print it.
2649 (x_report_frame_params): In X, window IDs are unsigned long,
2650 not signed long, so print them as unsigned.
2651 (validate_x_resource_name): Check for implausibly long names,
2652 and don't assume name length fits in 'int'.
2653 (x_get_resource_string): Don't blindly alloca invocation name;
2654 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2657 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2658 (xg_check_special_colors, xg_set_geometry):
2659 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2661 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2662 Use esprintf, not sprintf, in case result does not fit in int.
2664 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2665 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2666 it as a large positive number.
2667 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2668 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2670 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2671 in case result does not fit in int.
2673 * print.c (float_to_string): Detect width overflow more reliably.
2674 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2675 buffer overrun. Don't assume list length fits in 'int'. Treat
2676 print length of 0 as 0, not as infinity; to be consistent with other
2677 uses of print length in this function. Don't overflow print length
2678 index. Don't assume hash table size fits in 'long', or that
2679 vectorlike size fits in 'unsigned long'.
2681 * process.c (make_process): Use printmax_t, not int, to format
2682 process-name gensyms.
2684 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2686 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2687 to avoid potential buffer overrun.
2689 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2690 if X resource line is longer than 512 bytes.
2692 * xfns.c (x_window): Make sprintf buffer a bit bigger
2693 to avoid potential buffer overrun.
2695 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2697 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2699 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2701 Integer overflow fixes for scrolling, etc.
2702 Without these, Emacs silently mishandles large integers sometimes.
2703 For example, "C-u 4294967297 M-x recenter" was treated as if
2704 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2706 * xdisp.c (try_window_id): Check Emacs fixnum range before
2707 converting to 'int'.
2709 * window.c (window_scroll_line_based, Frecenter):
2710 Check that an Emacs fixnum is in range before assigning it to 'int'.
2711 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2712 values converted from Emacs fixnums.
2713 (Frecenter): Don't wrap around a line count if it is out of 'int'
2714 range; instead, treat it as an extreme value.
2715 (Fset_window_configuration, compare_window_configurations):
2716 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2718 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2719 that can exceed INT_MAX. Check that EMACS_INT value is in range
2720 before assigning it to the (possibly-narrower) index.
2721 (match_limit): Don't assume that a fixnum can fit in 'int'.
2723 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2726 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2727 (Fvertical_motion): Don't wrap around LINES values that don't fit
2728 in 'int'. Instead, treat them as extreme values. This is good
2729 enough for windows, which can't have more than INT_MAX lines anyway.
2731 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2733 * Require libxml/parser.h to avoid compilation warning.
2735 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2737 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2738 since this reportedly can destroy thread storage.
2740 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2742 * syntax.c (find_defun_start): Update all cache variables if
2743 exiting early (Bug#9401).
2745 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2747 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2749 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2750 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2751 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2753 * term.c (tty_append_glyph): New function.
2754 (produce_stretch_glyph): Static function and its prototype deleted.
2756 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2759 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2761 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2762 when checking :margin (Bug#9390).
2763 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2764 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2765 so that the name doesn't mislead. All uses changed.
2767 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2769 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2772 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2774 * xdisp.c (move_it_to): Don't bail out early when reaching
2775 position beyond to_charpos, if we are scanning backwards.
2776 (move_it_vertically_backward): When DY == 0, make sure we get to
2777 the first character in the line after the newline.
2779 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2781 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2782 (ccl_driver): Do not generate an out-of-range pointer.
2783 (Fccl_execute_on_string): Remove unnecessary check for
2784 integer overflow, noted by Stefan Monnier in
2785 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2786 Remove a FIXME that didn't need fixing.
2787 Simplify the newly-introduced buffer reallocation code.
2789 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2791 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2793 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2795 Integer and memory overflow issues (Bug#9196).
2797 * doc.c (get_doc_string): Rework so that
2798 get_doc_string_buffer_size is the actual buffer size, rather than
2799 being 1 less than the actual buffer size; this makes xpalloc more
2802 * image.c (x_allocate_bitmap_record, cache_image):
2803 * xselect.c (Fx_register_dnd_atom):
2804 Simplify previous changes by using xpalloc.
2806 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2807 since either will do and ptrdiff_t is convenient with xpalloc.
2809 * charset.c (charset_table_size)
2810 (struct charset_sort_data.priority): Now ptrdiff_t.
2811 (charset_compare): Don't overflow if priorities differ greatly.
2812 (Fsort_charsets): Don't assume list length fits in int.
2813 Check for size-calculation overflow when allocating sort data.
2814 (syms_of_charset): Allocate an initial charset table that is
2815 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2817 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2819 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2820 The actual value is always <= INT_MAX, and leaving it unsigned made
2821 overflow checking harder.
2823 * dispextern.h (struct glyph_matrix.rows_allocated)
2824 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2825 with xpalloc. The values are still always <= INT_MAX.
2827 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2829 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2830 (SAFE_NALLOCA): New macro.
2832 * region-cache.c (struct boundary.pos, find_cache_boundary)
2833 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2834 (set_cache_region, invalidate_region_cache)
2835 (revalidate_region_cache, know_region_cache, region_cache_forward)
2836 (region_cache_backward, pp_cache):
2837 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2838 so that ptrdiff_t * can be passed to xpalloc.
2839 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2840 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2841 (pp_cache): Don't assume cache_len fits in int.
2842 * region-cache.h: Adjust extern decls to match.
2844 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2845 EMACS_INT, since either will do, for xpalloc.
2847 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2848 (xnmalloc, xnrealloc, xpalloc): New functions.
2850 * bidi.c (bidi_shelve_header_size): New constant.
2851 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2852 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2854 * bidi.c (bidi_cache_shrink):
2855 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2857 Don't update size of array until after memory allocation succeeds,
2858 because xmalloc/xrealloc may not return.
2859 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2860 now that we have proper integer overflow checking.
2861 (record_overlay_string, overlay_strings): Catch overflows when
2862 calculating size of overlay_str_buf.
2864 * callproc.c (Fcall_process): Check for size overflow when
2865 calculating size of args2.
2866 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2867 Normally we prefer signed values, but sticking with ptrdiff_t would
2868 require adding more-complicated checks.
2870 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2871 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2872 Redo buffer-overflow calculations to avoid integer overflow.
2873 Add a FIXME comment where memory seems to be over-allocated.
2875 * character.c (Fstring): Check for size-calculation overflow.
2877 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2878 unnecessary integer overflow. Check for size overflow.
2879 (encode_coding_object): Don't update size until xmalloc succeeds.
2881 * composite.c (get_composition_id): Check for overflow in glyph
2882 length calculations.
2884 Integer and memory overflow fixes for display code.
2885 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2886 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2887 (scrolling_window): Check for overflow in size calculations.
2888 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2889 Don't assume glyph table len fits in int.
2890 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2891 (row_table_size): Now ptrdiff_t, not int.
2892 (scrolling_window): Avoid overflow in size calculations.
2893 Don't update size until allocation succeeds.
2894 * fns.c (concat): Check for overflow in size calculations.
2895 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2896 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2897 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2899 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2900 (get_doc_string): Check for size calculation overflow.
2901 Don't update size until allocation succeeds.
2902 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2903 EMACS_INT, where ptrdiff_t will do.
2904 (Fsubstitute_command_keys): Check for string overflow.
2906 * editfns.c (set_time_zone_rule): Don't assume environment length
2908 (message_length): Now ptrdiff_t, not int.
2909 (Fmessage_box): Don't update size until allocation succeeds.
2910 Don't assume message length fits in int.
2911 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2913 * emacs.c (main): Do not reallocate argv, since there is a null at
2914 the end that can be overwritten, and this way there's no need to
2915 worry about size-calculation overflow.
2916 (sort_args): Check for size-calculation overflow.
2918 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2920 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2922 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2923 (x_set_scroll_bar_width, x_figure_window_size):
2924 Check for integer overflow.
2925 (x_set_alpha): Do not assume XINT fits in int.
2927 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2928 This is for the members text_lines, text_cols, total_lines, total_cols,
2929 where the system imposes an 'int' limit.
2931 * fringe.c (Fdefine_fringe_bitmap):
2932 Don't update size until alloc works.
2934 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2935 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2937 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2938 Check for size-calculation overflow.
2939 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2940 do, as we prefer signed integers.
2941 (id_to_widget.max_size, id_to_widget.used)
2942 (xg_store_widget_in_map, xg_remove_widget_from_map)
2943 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2944 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2945 Use and return ptrdiff_t, not int.
2946 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2947 * gtkutil.h: Change prototypes to match the above.
2949 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2950 are duplicate now that they've been promoted to lisp.h.
2951 (x_allocate_bitmap_record, x_alloc_image_color)
2952 (make_image_cache, cache_image, xpm_load):
2953 Don't update size until alloc is done.
2954 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2956 Check for size calculation overflow.
2957 (ct_colors_allocated_max): New constant.
2958 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2961 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2962 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2963 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2964 Use ptrdiff_t, not int, to count maps.
2965 (read_char_minibuf_menu_prompt): Check for overflow in size
2966 calculations. Don't update size until allocation succeeds.
2967 Redo calculations to avoid overflow.
2968 * keyboard.h: Change prototypes to match the above.
2970 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2972 (current_minor_maps): Check for size calculation overflow.
2973 * keymap.h: Change prototypes to match the above.
2975 * lread.c (read1, init_obarray): Don't update size until alloc done.
2977 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2978 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2980 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2981 Now ptrdiff_t, not int.
2982 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2983 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2985 * process.c (Fnetwork_interface_list): Check for overflow
2986 in size calculation.
2988 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2990 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2991 overflow. Don't bother calling xmalloc when xrealloc will do.
2993 * search.c (Freplace_match): Check for size calculation overflow.
2994 (Fset_match_data): Don't assume list lengths fit in 'int'.
2996 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2997 for command line length. Do not attempt to address one before the
2998 beginning of an array, as that's not portable.
3000 * term.c (max_frame_lines): Remove; unused.
3001 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3003 (encode_terminal_code, calculate_costs): Check for size
3004 calculation overflow.
3005 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3006 table lengths and related sizes. Don't update size until alloc
3007 done. Redo calculations to avoid overflow.
3008 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3010 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3011 subtracting pointers.
3012 (gobble_line): Check for overflow more carefully. Don't update size
3015 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3016 Don't update size until alloc done.
3017 Redo size calculations to avoid overflow.
3018 Check for size calculation overflow.
3019 (main) [DEBUG]: Fix typo in invoking tparam1.
3021 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3022 Use ptrdiff_t, not int, for sizes.
3023 (store_mode_line_noprop_char): Don't update size until alloc done.
3025 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3026 Use ptrdiff_t, not int, for sizes.
3027 (Finternal_make_lisp_face, cache_face):
3028 Check for size calculation overflow.
3029 (cache_face): Treat size calculation overflows as if they were
3030 memory exhaustion (the usual treatment), rather than aborting.
3032 * xfns.c (x_encode_text, x_set_name_internal)
3033 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3034 sizes, since they can exceed INT_MAX in size. Check for size
3035 calculation overflow.
3037 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3038 (xg_select): Check for size calculation overflow.
3039 Don't update size until alloc done.
3041 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3042 as sprintf is limited to int lengths.
3044 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3045 (X_LONG_MIN): New macros.
3046 Use them to make the following changes clearer.
3047 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3048 This change doesn't affect the value now, but it may help remind
3049 future maintainers not to raise the value too much later.
3050 (SELECTION_QUANTUM): Remove, replacing with ...
3051 (selection_quantum): ... new function, which avoids overflow.
3053 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3054 assumption that selection length fits in 'int'.
3055 (x_reply_selection_request, x_handle_selection_request)
3056 (x_get_window_property, receive_incremental_selection)
3057 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3058 (lisp_data_to_selection_data, clean_local_selection_data):
3059 Use ptrdiff_t, not int, to record length of selection.
3060 (x_reply_selection_request, x_get_window_property)
3061 (receive_incremental_selection, x_property_data_to_lisp):
3062 Redo calculations to avoid overflow.
3063 (x_reply_selection_request): When sending hint, ceiling it at
3064 X_LONG_MAX rather than relying on wraparound overflow to send
3066 (x_get_window_property, receive_incremental_selection)
3067 (lisp_data_to_selection_data, x_property_data_to_lisp):
3068 Check for size-calculation overflow.
3069 (x_get_window_property, receive_incremental_selection)
3070 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3071 Don't store size until memory allocation succeeds.
3072 (x_get_window_property): Plug memory leak on memory exhaustion.
3073 Don't double-block input; malloc is safe here. Don't assume 2**34
3074 - 4 fits in unsigned long. Add an xassert to check
3075 XGetWindowProperty overflow. Be more careful about overflow
3076 calculations, and distinguish size from memory overflow better.
3077 (receive_incremental_selection): When tracing, don't assume
3078 unsigned int is less than INT_MAX.
3079 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3080 harmful) conversions of unsigned short to int.
3081 (lisp_data_to_selection_data): Don't assume that integers
3082 in the range -65535 through -1 fit in an X unsigned short.
3083 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3084 result parameters unless successful. Rely on cons_to_unsigned
3085 to report problems with elements; the old code wasn't right anyway.
3086 (x_check_property_data): Check for int overflow; we cannot use
3087 a wider type due to X limits.
3088 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3090 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3092 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3093 (x_term_init): Check for size calculation overflow.
3094 (x_color_cells): Don't store size until memory allocation succeeds.
3095 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3096 Don't assume alloca size is less than MAX_ALLOCA.
3097 (x_term_init): Don't assume length fits in int (sprintf is limited
3100 Use ptrdiff_t for composition IDs.
3101 * character.c (lisp_string_width):
3102 * composite.c (composition_table_size, n_compositions)
3103 (get_composition_id, composition_gstring_from_id):
3104 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3105 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3106 * window.c (Frecenter):
3107 Use ptrdiff_t, not int, for composition IDs.
3108 * composite.c (get_composition_id): Check for integer overflow.
3109 * composite.h: Adjust prototypes to match the above changes.
3111 Use ptrdiff_t for hash table indexes.
3112 * category.c (hash_get_category_set):
3113 * ccl.c (ccl_driver):
3114 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3115 * coding.c (coding_system_charset_list, detect_coding_system):
3116 * coding.h (struct coding_system.id):
3117 * composite.c (get_composition_id, gstring_lookup_cache):
3118 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3119 * image.c (xpm_get_color_table_h):
3120 * lisp.h (hash_lookup, hash_put):
3121 * minibuf.c (Ftest_completion):
3122 Use ptrdiff_t for hash table indexes, not int (which is too
3123 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3124 32-bit --with-wide-int hosts).
3126 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3127 Add a FIXME comment about memory leaks.
3128 (syms_of_charset): Don't assume xmalloc returns.
3130 Don't assume that stated character widths fit in int.
3131 * character.c (Fchar_width, c_string_width, lisp_string_width):
3132 * character.h (CHAR_WIDTH):
3133 * indent.c (MULTIBYTE_BYTES_WIDTH):
3134 Use sanitize_char_width to avoid undefined and/or bad behavior
3135 with outlandish widths.
3136 * character.h (sanitize_tab_width): Rename from sanitize_width,
3137 now that we have two such functions. All uses changed.
3138 (sanitize_char_width): New inline function.
3140 Don't assume that tab-width fits in int.
3141 * character.h (sanitize_width): New inline function.
3142 (SANE_TAB_WIDTH): New macro.
3143 (ASCII_CHAR_WIDTH): Use it.
3144 * indent.c (sane_tab_width): Remove. All uses replaced by
3145 SANE_TAB_WIDTH (current_buffer).
3146 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3148 * fileio.c: Integer overflow issues with file modes.
3149 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3151 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3152 Remove unreachable code.
3153 (read_hex, load_charset_map_from_file): Check for integer overflow.
3155 * xterm.c: Don't go over XClientMessageEvent limit.
3156 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3157 (x_send_scroll_bar_event): Likewise. Check that the size does not
3158 exceed limits imposed by XClientMessageEvent, as well as the usual
3159 ptrdiff_t and size_t limits.
3161 * keyboard.c: Overflow, signedness and related fixes.
3162 (make_lispy_movement): Use same integer type in forward decl
3163 that is used in the definition.
3164 (read_key_sequence, keyremap_step):
3165 Change bufsize argument back to int, undoing my 2011-03-30 change.
3166 We prefer signed types, and int is wide enough here.
3167 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3168 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3169 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3170 length, not size_t. Use ptrdiff_t for index, not int.
3171 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3172 possibility of integer overflow.
3174 Overflow, signedness and related fixes for images.
3176 * dispextern.h (struct it.stack[0].u.image.image_id)
3177 (struct_it.image_id, struct image.id, struct image_cache.size)
3178 (struct image_cache.used, struct image_cache.ref_count):
3179 * gtkutil.c (update_frame_tool_bar):
3180 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3181 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3182 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3183 * nsmenu.m (update_frame_tool_bar):
3184 * xdisp.c (calc_pixel_width_or_height):
3185 * xfns.c (image_cache_refcount):
3186 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3187 on typical 64-bit hosts.
3189 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3190 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3191 Omit unnecessary casts to int.
3192 (parse_image_spec): Check that integers fall into 'int' range
3193 when the callers expect that.
3194 (image_ascent): Redo ascent calculation to avoid int overflow.
3195 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3196 (lookup_image): Remove unnecessary tests.
3197 (xbm_image_p): Locals are now of int, not EMACS_INT,
3198 since parse_image_check makes sure they fit into int.
3199 (png_load, gif_load, svg_load_image):
3200 Prefer int to unsigned where either will do.
3201 (tiff_handler): New function, combining the cores of the
3202 old tiff_error_handler and tiff_warning_handler.
3203 This function is rewritten to use vsnprintf and thereby avoid
3204 stack buffer overflows. It uses only the features of vsnprintf
3205 that are common to both POSIX and native Microsoft.
3206 (tiff_error_handler, tiff_warning_handler): Use it.
3207 (tiff_load, gif_load, imagemagick_load_image):
3208 Don't assume :index value fits in 'int'.
3209 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3210 (imagemagick_load_image): Check that crop parameters fit into
3211 the integer types that MagickCropImage accepts. Don't assume
3212 Vimagemagick_render_type has a nonnegative value. Don't assume
3213 size_t fits in 'long'.
3214 (gs_load): Use printmax_t to print the widest integers possible.
3215 Check for integer overflow when computing image height and width.
3217 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3219 * xdisp.c (redisplay_window): Don't force window start if point
3220 will be invisible in the resulting window. (Bug#9324)
3222 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3224 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3225 the display spec is of the form `(space ...)'.
3226 (handle_display_spec): Return the value returned by
3227 handle_single_display_spec, not just 1 or zero.
3228 (handle_single_display_spec): If the display spec is of the form
3229 `(space ...)', and specifies display in the text area, return 2
3231 (try_cursor_movement): Check for the need to scroll more
3232 accurately, and prefer exact match for point under bidi.
3233 Don't advance `row' beyond the last row of the window.
3235 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3236 into disp_prop; all users changed.
3238 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3239 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3240 for the text covered by the display property.
3242 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3244 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3245 Change return value to nil.
3246 (Frecord_buffer): Delete unused function.
3248 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3250 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3251 buffers, return left-to-right.
3252 (set_cursor_from_row): Consider candidate row a win if its glyph
3253 represents a newline and point is on that newline. Fixes cursor
3254 positioning on the newline at EOL of R2L text within L2R
3255 paragraph, and vice versa.
3256 (try_cursor_movement): Check continued rows, in addition to
3257 continuation rows. Fixes unwarranted scroll when point enters a
3258 continued line of R2L text within an L2R paragraph, or vice versa.
3259 (cursor_row_p): Consider the case of point being equal to
3260 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3261 from the end of a short line to the beginning of a continued line
3262 of R2L text within L2R paragraph.
3263 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3264 composed characters.
3266 * bidi.c (bidi_check_type): Use xassert.
3267 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3270 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3272 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3275 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3277 * nsfont.m (ns_otf_to_script): Fix typo.
3279 2011-08-22 Kenichi Handa <handa@m17n.org>
3281 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3282 extra slot even if the purpose is char-code-property-table.
3284 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3286 * xdisp.c (redisplay_window): When computing centering_position,
3287 account for the height of the header line. (Bug#8874)
3289 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3290 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3291 candidate is selected by the mouse, and that candidate has a
3292 composed character under the mouse.
3294 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3295 coordinates reported by pos-visible-in-window-p for a composed
3296 character in column zero.
3298 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3300 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3302 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3304 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3305 consider it a hit if to_charpos is anywhere in the range of the
3306 composed buffer positions.
3308 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3310 * image.c (gif_load): Don't assume that each subimage has the same
3311 dimensions as the base image. Handle disposal method that is
3312 "undefined" by the gif spec (Bug#9335).
3314 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3316 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3317 (Fcondition_case): Document `debug' symbol in error handler.
3319 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3321 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3322 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3323 from an Org mode buffer to a Speedbar frame.
3325 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3326 a composition, take its buffer position from IT->cmp_it.charpos.
3327 Fixes cursor positioning at the beginning of a line that begins
3328 with a composed character.
3330 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3332 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3333 character bidirectional type, use STRONG_L instead. Fixes crashes
3334 in a buffer produced by `describe-categories'.
3336 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3337 members before the level stack, so they would be saved and
3338 restored when copying iterator state. Fixes incorrect reordering
3339 around TABs covered by display properties.
3341 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3343 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3345 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3347 * eval.c (internal_condition_case, internal_condition_case_1)
3348 (internal_condition_case_2, internal_condition_case_n):
3349 Remove unnecessary aborts (Bug#9081).
3351 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3353 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3354 has no `load' handler, try opening the file locally. (Bug#9311)
3356 2011-08-16 Ken Brown <kbrown@cornell.edu>
3358 * gmalloc.c: Expand comment.
3360 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3362 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3363 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3365 2011-08-16 Ken Brown <kbrown@cornell.edu>
3367 Fix memory allocation problems in Cygwin build (Bug#9273).
3369 * unexcw.c ( __malloc_initialized): Declare external variable.
3370 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3372 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3374 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3376 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3378 [CYGWIN] (special_realloc): New function.
3379 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3380 requests to realloc storage in the static heap.
3382 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3384 * bidi.c (bidi_initialize): Remove unused local.
3386 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3389 * biditype.h: Remove file.
3390 * makefile.w32-in ($(BLD)/bidi.$(O)):
3391 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3393 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3395 * chartab.c: Improve commentary for the uniprop_table API.
3397 * bidi.c (bidi_paragraph_init): Support zero value of
3398 bidi_ignore_explicit_marks_for_paragraph_level.
3399 (bidi_initialize): Use uniprop_table instead of including
3400 biditype.h and bidimirror.h.
3402 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3403 coordinates of the iterator when restoring from ppos_it.
3406 2011-08-14 Kenichi Handa <handa@m17n.org>
3408 * process.c (create_process): Call setup_process_coding_systems
3409 after the pid of the process is set to -1 (Bug#8162).
3411 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3413 * xdisp.c (move_it_in_display_line_to): Don't invoke
3414 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3415 ppos_it. Fixes vertical cursor motion when line beginning is
3416 covered by an image. (Bug#9296)
3418 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3420 * nsterm.h (ns_run_ascript): Declare.
3421 (NSAPP_DATA2_RUNASSCRIPT): Define.
3423 * nsfns.m (as_script, as_result, as_status): New static variables.
3424 (ns_run_ascript): New function.
3425 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3426 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3427 the event loop. Get status from as_status (Bug#7276).
3429 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3430 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3431 the event loop (Bug#7276).
3433 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3435 * gnutls.c (QCgnutls_bootprop_priority)
3436 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3437 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3438 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3439 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3440 (QCgnutls_bootprop_verify_hostname_error)
3441 (QCgnutls_bootprop_callbacks_verify): Rename from
3442 Qgnutls_bootprop_..., all uses changed.
3444 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3447 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3449 * xfaces.c (Qframe_set_background_mode): Now static.
3450 * dispextern.h (Qframe_set_background_mode): Remove decl.
3452 * process.c (Fnetwork_interface_info): Declare local only if needed.
3454 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3456 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3457 (Fnetwork_interface_list): Allocate in increments of bytes instead
3458 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3459 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3461 (struct ifflag_def): notrailers is smart on OSX.
3462 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3463 Get hardware address with getifaddrs if available.
3465 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3467 * xdisp.c (iterate_out_of_display_property): xassert that
3468 IT->position is set to within IT->object's boundaries. Break from
3469 the loop as soon as EOB is reached; avoids infloops in redisplay
3470 when IT->position is set up wrongly due to some bug.
3471 Set IT->current to match the bidi iterator unconditionally.
3472 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3473 entry. Force push_it to save on the stack the current
3474 buffer/string position, to be restored by pop_it. Fix flags in
3475 the iterator structure wrt the object coming from a display
3476 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3477 properties. (Bug#9284)
3479 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3481 * fontset.c (fontset_get_font_group): Add proper type checks.
3484 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3486 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3487 and LC_VERSION_MIN_MACOSX.
3488 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3489 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3491 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3493 * xdisp.c (forward_to_next_line_start): Allow to use the
3494 no-display-properties-and-no-overlays under bidi display.
3495 Set disp_pos in the bidi iterator to avoid searches for display
3496 properties and overlays.
3498 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3500 * editfns.c (Fset_time_zone_rule): Document relationship with the
3503 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3504 the font entity extracted from the cache (Bug#8109).
3506 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3508 * composite.c (autocmp_chars): Don't reset point. That is done by
3509 restore_point_unwind (Bug#5984).
3511 2011-08-07 Juri Linkov <juri@jurta.org>
3513 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3514 to show the arg `TIME' instead of `TIMEVAL'.
3516 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3518 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3519 display property strides EOL and includes a newline, as in
3520 longlines-mode. (Bug#9254)
3521 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3522 word-wrap under bidirectional display. (Bug#9224)
3524 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3525 is non-zero, even if the data buffer is NULL. Fixes a crash in
3526 vertical-motion with longlines-mode. (Bug#9254)
3528 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3530 * bidi.c <bidi_cache_total_alloc>: Now static.
3531 (bidi_initialize): Initialize bidi_cache_total_alloc.
3533 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3536 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3537 amount allocated this far in `bidi_cache_total_alloc'.
3538 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3539 non-zero, only free the data buffer without restoring the cache
3540 contents. All callers changed.
3542 * dispextern.h (bidi_unshelve_cache): Update prototype.
3544 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3545 (move_it_in_display_line, move_it_to)
3546 (move_it_vertically_backward, move_it_by_lines): Replace the call
3547 to xfree to an equivalent call to bidi_unshelve_cache.
3548 (move_it_in_display_line_to): Fix logic of returning
3549 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3551 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3553 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3554 came from a string character with a `cursor' property. (Bug#9229)
3556 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3558 * Makefile.in (LIB_PTHREAD): New variable.
3559 (LIBES): Add LIB_PTHREAD (Bug#9216).
3561 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3562 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3564 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3566 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3568 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3570 * xterm.c (x_find_topmost_parent): New function.
3571 (x_set_frame_alpha): Find topmost parent window with
3572 x_find_topmost_parent and set the property there also (bug#9181).
3573 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3575 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3577 * callproc.c (Fcall_process): Avoid vfork clobbering
3578 the local vars buffer, coding_systems, current_dir.
3580 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3582 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3584 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3586 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3587 so that it is not optimized away.
3589 * xdisp.c (compute_display_string_pos): Remove unused local.
3591 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3593 Fix slow cursor motion and scrolling in large buffers with
3594 selective display, like Org Mode buffers. (Bug#9218)
3596 * dispextern.h (struct bidi_it): New member disp_prop_p.
3598 * xdisp.c: Remove one-slot cache of display string positions.
3599 (compute_display_string_pos): Accept an additional argument
3600 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3601 for a display string or property. If found, set DISP_PROP_P
3604 * bidi.c (bidi_fetch_char): Accept an additional argument
3605 DISP_PROP_P, and pass it to compute_display_string_pos.
3606 Only handle text covered by a display string if DISP_PROP_P is returned
3607 non-zero. All callers of bidi_fetch_char changed.
3609 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3611 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3613 2010-12-03 Don March <don@ohspite.net>
3615 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3616 last character M-[char] is translated to ESC [char] (bug#7541).
3618 2011-08-02 Kenichi Handa <handa@m17n.org>
3620 * lisp.h (uniprop_table): Extern it.
3622 * chartab.c (uniprop_table): Make it non-static.
3624 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3626 * xdisp.c (forward_to_next_line_start): Accept additional argument
3627 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3629 (reseat_at_next_visible_line_start): Use the bidi iterator state
3630 returned by forward_to_next_line_start to restore the state of
3631 it->bidi_it after backing up to previous newline. (Bug#9212)
3633 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3635 * regex.c (re_comp): Protoize.
3636 (re_exec): Fix return type.
3637 (regexec): Fix type of `ret'. (Bug#9203)
3639 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3641 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3642 This is needed if max-image-size is a floating-point number.
3644 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3646 * print.c (print_object): Print empty symbol as ##.
3648 * lread.c (read1): Read ## as empty symbol.
3650 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3652 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3653 setting frame foreground color (Bug#9175).
3654 (x_set_background_color): Likewise.
3656 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3657 contents (Bug#9176).
3658 (EmacsTooltip -init): Remove bezels and add shadows to
3661 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3662 or scroll bar (Bug#8470).
3664 * nsfont.m (nsfont_open): Remove assignment to voffset and
3665 unnecessary vars hshink, expand, hd, full_height, min_height.
3666 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3668 * nsterm.h (nsfont_info): Remove voffset field.
3670 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3672 Implement strike-through and overline on NextStep (Bug#8863).
3674 * nsfont.m (nsfont_open): Use underline position provided by font,
3675 instead of hard-coded value of 2.
3676 (nsfont_draw): Call ns_draw_text_decoration instead.
3678 * nsterm.h: Add declaration for ns_draw_text_decoration.
3680 * nsterm.m (ns_draw_text_decoration): New function for drawing
3681 underline, overline, and strike-through.
3682 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3683 ns_draw_text_decoration. Change treatment of cursor drawing to
3684 accommodate underlining, etc.
3686 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3688 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3691 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3693 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3694 Without this fix, if a signal arrives just after memory fills up,
3695 'malloc' might be invoked reentrantly.
3697 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3698 In other words, assume that every image size is allowed, on non-X
3699 hosts. This assumption is probably wrong, but it lets Emacs compile.
3701 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3703 * regex.c (re_iswctype): Convert return values to boolean.
3705 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3707 * xdisp.c (compute_display_string_pos): Don't use cached display
3708 string position if the buffer had its restriction changed.
3711 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3713 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3715 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3717 Integer signedness and overflow and related fixes. (Bug#9079)
3719 * bidi.c: Integer size and overflow fixes.
3720 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3721 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3722 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3723 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3724 (bidi_find_other_level_edge):
3725 Use ptrdiff_t instead of EMACS_INT where either will do.
3726 This works better on 32-bit hosts configured --with-wide-int.
3727 (bidi_cache_ensure_space): Check for size-calculation overflow.
3728 Use % rather than repeated addition, for better worst-case speed.
3729 Don't set bidi_cache_size until after xrealloc returns, because it
3731 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3732 (bidi_cache_ensure_space): Also check that the bidi cache size
3733 does not exceed that of the largest Lisp string or buffer. See Eli
3734 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3736 * alloc.c (__malloc_size_t): Remove.
3737 All uses replaced by size_t. See Andreas Schwab's note
3738 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3740 * image.c: Improve checking for integer overflow.
3741 (check_image_size): Assume that f is nonnull, since
3742 it is always nonnull in practice. This is one less thing to
3743 worry about when checking for integer overflow later.
3744 (x_check_image_size): New function, which checks for integer
3745 overflow issues inside X.
3746 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3747 This removes the need for a memory_full check.
3748 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3749 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3750 (xbm_read_bitmap_data): Change locals back to 'int', since
3751 their values must fit in 'int'.
3752 (xpm_load_image, png_load, tiff_load):
3753 Invoke x_create_x_image_and_pixmap earlier,
3754 to avoid much needless work if the image is too large.
3755 (tiff_load): Treat overly large images as if
3756 x_create_x_image_and_pixmap failed, not as malloc failures.
3757 (gs_load): Use x_check_image_size.
3759 * gtkutil.c: Omit integer casts.
3760 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3761 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3763 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3765 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3766 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3767 would wrongly return t on a 64-bit host.
3769 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3770 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3771 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3772 and therefore cause GCC to emit a bogus diagnostic in some cases.
3774 * image.c: Integer signedness and overflow and related fixes.
3775 This is not an exhaustive set of fixes, but it's time to
3776 record what I've got.
3777 (lookup_pixel_color, check_image_size): Remove redundant decls.
3778 (check_image_size): Don't assume that arbitrary EMACS_INT values
3779 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3780 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3781 (tiff_load, imagemagick_load_image):
3782 Check for overflow in size calculations.
3783 (x_create_x_image_and_pixmap): Remove unnecessary test for
3784 xmalloc returning NULL; that can't happen.
3785 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3786 (xpm_color_bucket): Use better integer hashing function.
3787 (xpm_cache_color): Don't possibly over-allocate memory.
3788 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3789 (gif_memory_source):
3790 Use ptrdiff_t, not int or size_t, to record sizes.
3791 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3792 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3793 either works, as we prefer signed integers.
3794 (tiff_read_from_memory, tiff_write_from_memory):
3795 Return tsize_t, not size_t, since that's what the TIFF API wants.
3796 (tiff_read_from_memory): Don't fail simply because the read would
3797 go past EOF; instead, return a short read.
3798 (tiff_load): Omit no-longer-needed casts.
3799 (Fimagemagick_types): Don't assume size fits into 'int'.
3801 Improve hashing quality when configured --with-wide-int.
3802 * fns.c (hash_string): New function, taken from sxhash_string.
3803 Do not discard information about ASCII character case; this
3804 discarding is no longer needed.
3805 (sxhash-string): Use it. Change sig to match it. Caller changed.
3806 * lisp.h: Declare it.
3807 * lread.c (hash_string): Remove, since we now use fns.c's version.
3808 The fns.c version returns a wider integer if --with-wide-int is
3809 specified, so this should help the quality of the hashing a bit.
3811 * emacs.c: Integer overflow minor fix.
3812 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3813 Define only if GNU_LINUX.
3814 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3816 * dispnew.c: Integer signedness and overflow fixes.
3817 Remove unnecessary forward decls, that were a maintenance hassle.
3818 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3820 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3821 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3822 (prepare_desired_row, line_draw_cost):
3823 Use int, not unsigned, where either works.
3824 (save_current_matrix, restore_current_matrix):
3825 Use ptrdiff_t, not size_t, where either works.
3826 (init_display): Check for overflow more accurately, and without
3827 relying on undefined behavior.
3829 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3830 Remove, replacing with the new symbols in lisp.h. All uses changed.
3831 * fileio.c (make_temp_name):
3832 * filelock.c (lock_file_1, lock_file):
3833 * xdisp.c (message_dolog):
3834 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3835 Use pMd etc. instead.
3836 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3837 replacing the pWIDE etc. symbols removed from editfns.c.
3839 * keyboard.h (num_input_events): Now uintmax_t.
3840 This is (very slightly) less likely to mess up due to wraparound.
3843 * buffer.c: Integer signedness fixes.
3844 (alloc_buffer_text, enlarge_buffer_text):
3845 Use ptrdiff_t rather than size_t when either will do, as we prefer
3848 * alloc.c: Integer signedness and overflow fixes.
3849 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3850 (__malloc_size_t): Default to size_t, not to int.
3851 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3852 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3853 Prefer ptrdiff_t to size_t when either would do, as we prefer
3855 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3856 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3857 Now const. Initialize with values that are in range even if char
3859 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3860 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3861 These functions do the right thing with sizes > 2**32.
3862 (check_depth): Now ptrdiff_t, not int.
3863 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3864 Adjust to new way of storing sizes. Check for size overflow bugs
3866 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3867 slightly wrong anyway, as it missed one instance of
3868 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3869 (refill_memory_reserve): Omit needless cast to size_t.
3870 (mark_object_loop_halt): Mark as externally visible.
3872 * xselect.c: Integer signedness and overflow fixes.
3873 (Fx_register_dnd_atom, x_handle_dnd_message):
3874 Use ptrdiff_t, not size_t, since we prefer signed.
3875 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3876 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3877 x_dnd_atoms_size and x_dnd_atoms_length.
3879 * doprnt.c: Prefer signed to unsigned when either works.
3881 * doprnt.c (doprnt):
3883 * xdisp.c (vmessage):
3884 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3885 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3886 prefer signed arithmetic to avoid comparison confusion.
3887 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3888 but is a bit tricky.
3890 Assume freestanding C89 headers, string.h, stdlib.h.
3891 * data.c, doprnt.c, floatfns.c, print.c:
3892 Include float.h unconditionally.
3893 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3894 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3895 * regex.c: Likewise for stddef.h, string.h.
3896 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3897 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3898 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3899 (STDC_HEADERS): Remove obsolete defines.
3900 * sysdep.c: Include limits.h unconditionally.
3902 Assume support for memcmp, memcpy, memmove, memset.
3903 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3904 * regex.c (memcmp, memcpy):
3905 Remove; we assume C89 now.
3907 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3908 (__malloc_safe_bcopy): Remove; no longer needed.
3910 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3911 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3912 well either way, and we prefer signed to unsigned.
3914 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3916 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3917 closes the connection while we're reading (bug#9182).
3919 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3921 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3922 are specified (Bug#9168).
3924 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3926 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3927 Found by GCC static checking and --with-wide-int on a 32-bit host.
3929 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3931 * xdisp.c (compute_display_string_pos): Fix logic of caching
3932 previous display string position. Initialize cached_prev_pos to
3933 -1. Fixes slow-down at the beginning of a buffer.
3935 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3937 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3938 for attrs[LFACE_FONTSET_INDEX].
3940 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3942 * xml.c (parse_region): Remove unused local
3943 that was recently introduced.
3945 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3947 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3948 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3950 * xdisp.c (move_it_in_display_line_to): Record the best matching
3951 position for TO_CHARPOS while scanning the line, and restore it on
3952 exit if none of the characters scanned was an exact match.
3953 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3954 when exact match is impossible due to invisible text, and the
3955 lines are truncated.
3957 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3959 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3962 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3964 Fix a significant slow-down of cursor motion with C-n, C-p,
3965 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3966 auto-repeat under bidi redisplay in fontified buffers.
3967 * xdisp.c (compute_stop_pos_backwards): New function.
3968 (next_element_from_buffer): Call compute_stop_pos_backwards to
3969 find a suitable prev_stop when we find ourselves before
3971 (reseat): Don't look for prev_stop, as that could mean a very long
3973 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3974 <cached_disp_overlay_modiff>: Cache for last found display string
3976 (compute_display_string_pos): Return the cached position if asked
3977 about the same buffer in the same area of character positions, and
3978 the buffer wasn't changed since the time the display string
3979 position was cached.
3981 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3983 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3984 is an integer, which is important for empty lines. (Bug#9149)
3986 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3988 * frame.c (Fmodify_frame_parameters): In tty case, update the
3989 default face if necessary (Bug#4238).
3991 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3993 * editfns.c (Fstring_to_char): No need to explain what a character
3994 is in the docstring (Bug#6576).
3996 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3998 * xml.c (parse_region): Make sure we always return a tree.
4000 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4002 * xml.c (parse_region): If a document contains only comments,
4005 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4007 * xml.c (make_dom): Return comments, too.
4009 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4012 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4013 and the surrounding thread.
4014 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4015 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4016 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4018 * s/openbsd.h (BROKEN_SIGIO): Define.
4019 * unexelf.c (unexec) [__OpenBSD__]:
4020 Don't update the .mdebug section of the Alpha COFF symbol table.
4022 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4024 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4027 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4029 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4030 This fixes some race conditions on the permissions of any newly
4033 * alloc.c (valid_pointer_p): Use pipe, not open.
4034 This fixes some permissions issues when debugging.
4036 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4037 If fchown fails to set both uid and gid, try to set just gid,
4038 as that is sometimes allowed. Adjust the file's mode to eliminate
4039 setuid or setgid bits that are inappropriate if fchown fails.
4041 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4043 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4044 to compare Lisp_Objects.
4045 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4046 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4047 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4049 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4051 * lread.c (read_integer): Unread even EOF character.
4052 (read1): Likewise. Properly record start position of symbol.
4054 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4055 symbol character follows.
4057 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4059 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4060 This works around a problem with the previous change to Fcopy_file.
4061 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4062 and without this change, GCC might complain about discarding
4063 fchown's return value.
4065 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4067 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4069 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4071 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4073 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4075 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4076 it's used from the C level.
4078 * process.c: Use the same condition for POLL_FOR_INPUT in both
4079 keyboard.c and process.c (bug#1858).
4081 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4083 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4084 (Fgnutls_boot): Use it.
4086 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4088 * doc.c (Fsubstitute_command_keys): Revert last change.
4090 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4092 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4093 quotes the next character, and doesn't affect other longer
4094 sequences (bug#8935).
4096 * lread.c (syms_of_lread): Clarify that is isn't only
4097 `eval-buffer' and `eval-defun' that's affected by
4098 `lexical-binding' (bug#8460).
4100 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4102 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4103 bidi redisplay when a line includes both an image and is truncated.
4105 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4107 Fix minor problems found by static checking.
4108 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4109 (elsz): Now a signed constant, not a size_t var. We prefer signed
4110 types to unsigned, to avoid integer comparison confusion. Without
4111 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4112 "cannot optimize loop, the loop counter may overflow", a symptom
4114 * indent.c (Fvertical_motion): Mark locals as initialized.
4115 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4117 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4119 * search.c (Fre_search_backward): Mention `case-fold-search' in
4120 all the re_search_* functions (bug#8138).
4122 * keyboard.c (Fopen_dribble_file): Document when the file is
4125 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4127 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4130 Support bidi reordering of display and overlay strings.
4131 * xdisp.c (compute_display_string_pos)
4132 (compute_display_string_end): Accept additional argument STRING.
4133 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4134 (reseat_to_string): Initialize bidi_it->string.s and
4135 bidi_it->string.schars.
4136 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4137 NULL (avoids a crash in bidi_paragraph_init).
4138 Initialize itb.string.lstring.
4139 (init_iterator): Call bidi_init_it only of a valid
4140 buffer position was specified. Initialize paragraph_embedding to
4142 (reseat_to_string): Initialize the bidi iterator.
4143 (display_string): If we need to ignore text properties of
4144 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4145 original value of -1 will not work with bidi.)
4146 (compute_display_string_pos): First arg is now struct
4147 `text_pos *'; all callers changed. Support display properties on
4149 (compute_display_string_end): Support display properties on Lisp
4151 (init_iterator, reseat_1, reseat_to_string): Initialize the
4152 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4153 when iterating on a string not from display properties).
4154 (compute_display_string_pos, compute_display_string_end):
4155 Fix calculation of the object to scan. Fixes an error when using
4157 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4158 base_level_stop; instead, set base_level_stop to BEGV.
4159 Fixes crashes in vertical-motion.
4160 (next_element_from_buffer): Improve commentary for when
4161 the iterator is before prev_stop.
4162 (init_iterator): Initialize bidi_p from the default value of
4163 bidi-display-reordering, not from buffer-local value. Use the
4164 buffer-local value only if initializing for buffer iteration.
4165 (handle_invisible_prop): Support invisible properties on strings
4166 that are being bidi-reordered.
4167 (set_iterator_to_next): Support bidi reordering of C strings and
4169 (next_element_from_string): Support bidi reordering of Lisp
4171 (handle_stop_backwards): Support Lisp strings as well.
4172 (display_string): Support display of R2L glyph rows.
4173 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4174 (init_iterator): Don't initialize it->bidi_p for strings
4176 (reseat_to_string): Initialize it->bidi_p for strings here.
4177 (next_element_from_string, next_element_from_c_string)
4178 (next_element_from_buffer): Add xassert's for correspondence
4179 between IT's object being iterated and it->bidi_it.string
4181 (face_before_or_after_it_pos): Support bidi iteration.
4182 (next_element_from_c_string): Handle the case of the first string
4183 character that is not the first one in the visual order.
4184 (get_visually_first_element): New function, refactored from common
4185 parts of next_element_from_buffer, next_element_from_string, and
4186 next_element_from_c_string.
4187 (tool_bar_lines_needed, redisplay_tool_bar)
4188 (display_menu_bar): Force left-to-right direction. Add a FIXME
4189 comment for making that be controlled by a user option.
4190 (push_it, pop_it): Save and restore the state of the
4191 bidi iterator. Save and restore the bidi_p flag.
4192 (pop_it): Iterate out of display property for string iteration as
4194 (iterate_out_of_display_property): Support iteration over strings.
4195 (handle_single_display_spec): Set up it->bidi_it for iteration
4196 over a display string, and call bidi_init_it.
4197 (handle_single_display_spec, next_overlay_string)
4198 (get_overlay_strings_1, push_display_prop): Set up the bidi
4199 iterator for displaying display or overlay strings.
4200 (forward_to_next_line_start): Don't use the shortcut if
4202 (back_to_previous_visible_line_start): If handle_display_prop
4203 pushed the iterator stack, restore the internal state of the bidi
4204 iterator by calling bidi_pop_it same number of times.
4205 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4206 and we are bidi-iterating, don't decrement the iterator position;
4207 instead, set the first_elt flag in the bidi iterator, to produce
4209 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4210 (push_display_prop): xassert that we are iterating a buffer.
4211 (push_it, pop_it): Save and restore paragraph_embedding member.
4212 (handle_single_display_spec, next_overlay_string)
4213 (get_overlay_strings_1, reseat_1, reseat_to_string)
4214 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4215 correctly. Don't assume unibyte strings are not bidi-reordered.
4216 (compute_display_string_pos)
4217 (compute_display_string_end): Fix handling the case of C string.
4218 (push_it, pop_it): Save and restore from_disp_prop_p.
4219 (handle_single_display_spec, push_display_prop): Set the
4220 from_disp_prop_p flag.
4221 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4222 (pop_it): Call iterate_out_of_display_property only if we are
4223 popping after iteration over a string that came from a display
4224 property. Fix a typo in popping stretch info. Add an assertion
4225 for verifying that the iterator position is in sync with the bidi
4227 (handle_single_display_spec, get_overlay_strings_1)
4228 (push_display_prop): Fix initialization of paragraph direction for
4229 string when that of the parent object is not yet determined.
4230 (reseat_1): Call bidi_init_it to resync the bidi
4231 iterator with IT's position. (Bug#7616)
4232 (find_row_edges): If ROW->start.pos gives position
4233 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4234 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4235 Reset the from_disp_prop_p flag.
4236 (SAVE_IT, RESTORE_IT): New macros.
4237 (pos_visible_p, face_before_or_after_it_pos)
4238 (back_to_previous_visible_line_start)
4239 (move_it_in_display_line_to, move_it_in_display_line)
4240 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4241 (try_scrolling, redisplay_window, display_line): Use them when
4242 saving a temporary copy of the iterator and restoring it back.
4243 (back_to_previous_visible_line_start, reseat_1)
4244 (init_iterator): Empty the bidi cache "stack".
4245 (move_it_in_display_line_to): If iterator ended up at
4246 EOL, but we never saw any buffer positions smaller than
4247 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4248 motion in bidi-reordered lines.
4249 (move_it_in_display_line_to): Record prev_method and prev_pos
4250 immediately before the call to set_iterator_to_next. Fixes cursor
4251 motion in bidi-reordered lines with stretch glyphs and strings
4252 displayed in margins. (Bug#8133) (Bug#8867)
4253 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4255 (pos_visible_p): Support positions in bidi-reordered lines.
4256 Save and restore bidi cache.
4258 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4259 (bidi_paragraph_info): Delete unused struct.
4260 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4261 (bidi_cache_start): New variable.
4262 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4264 (bidi_cache_fetch_state, bidi_cache_search)
4265 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4266 (bidi_cache_find, bidi_peek_at_next_level)
4267 (bidi_level_of_next_char, bidi_find_other_level_edge)
4268 (bidi_move_to_visually_next): Compare cache index with
4269 bidi_cache_start rather than with zero.
4270 (bidi_fetch_char): Accept new argument STRING; all callers
4271 changed. Support iteration over a string. Support strings with
4272 display properties. Support unibyte strings. Fix the type of
4273 `len' according to what STRING_CHAR_AND_LENGTH expects.
4274 (bidi_paragraph_init, bidi_resolve_explicit_1)
4275 (bidi_resolve_explicit, bidi_resolve_weak)
4276 (bidi_level_of_next_char, bidi_move_to_visually_next):
4277 Support iteration over a string.
4278 (bidi_set_sor_type, bidi_resolve_explicit_1)
4279 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4280 can now be zero (for strings); special values 0 and -1 were
4281 changed to -1 and -2, respectively.
4282 (bidi_char_at_pos): New function.
4283 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4284 Call it instead of FETCH_MULTIBYTE_CHAR.
4285 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4286 initialized to valid values.
4287 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4289 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4290 the test for valid cached positions. Fix the logic for looking up
4291 the sentinel state in the cache. GCPRO the Lisp string we are
4293 (bidi_push_it, bidi_pop_it): New functions.
4294 (bidi_initialize): Initialize the bidi cache start stack pointer.
4295 (bidi_cache_ensure_space): New function, refactored from part of
4296 bidi_cache_iterator_state. Don't assume the required size is just
4297 one BIDI_CACHE_CHUNK away.
4298 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4299 (bidi_count_bytes, bidi_char_at_pos): New functions.
4300 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4301 always valid if bidi_cache_idx is valid.
4302 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4303 is valid if it's going to be used.
4304 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4305 (bidi_cache_fetch_state, bidi_cache_search)
4306 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4307 (bidi_cache_iterator_state, bidi_cache_find)
4308 (bidi_find_other_level_edge, bidi_cache_start_stack):
4309 All variables related to cache indices are now EMACS_INT.
4311 * dispextern.h (struct bidi_string_data): New structure.
4312 (struct bidi_it): New member `string'. Make flag members be 1-bit
4313 fields, and put them last in the struct.
4314 (compute_display_string_pos, compute_display_string_end):
4316 (bidi_push_it, bidi_pop_it): Add prototypes.
4317 (struct iterator_stack_entry): New members bidi_p,
4318 paragraph_embedding, and from_disp_prop_p.
4319 (struct it): Member bidi_p is now a bit field 1 bit wide.
4320 (bidi_shelve_cache, bidi_unshelve_cache):
4323 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4324 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4325 and vector-like objects.
4327 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4328 cache around display iteration.
4330 * window.c (Fwindow_end, window_scroll_pixel_based)
4331 (displayed_window_lines, Frecenter): Save and restore the bidi
4332 cache around display iteration.
4334 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4336 * editfns.c (Fdelete_region): Clarify the use of the named
4337 parameters (bug#6788).
4339 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4341 * indent.c (Fvertical_motion): Set and restore w->pointm when
4342 saving and restoring the window's buffer (Bug#9006).
4344 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4346 * editfns.c (Fstring_to_char): Clarify just what is returned
4347 (bug#6576). Text by Eli Zaretskii.
4349 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4351 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4353 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4355 * buffer.c (mmap_find): Fix a typo.
4357 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4359 Fix execution of x selection hooks.
4360 * xselect.c (Qx_lost_selection_functions)
4361 (Qx_sent_selection_functions): New vars.
4362 (syms_of_xselect): DEFSYM them.
4363 (x_handle_selection_request): Pass Qx_sent_selection_functions
4364 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4365 (x_handle_selection_clear,x_clear_frame_selections):
4366 Pass Qx_lost_selection_functions rather than
4367 Vx_lost_selection_functions to Frun_hook_with_args.
4369 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4371 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4372 The old code sometimes used this field without initializing it.
4374 * alloc.c (gc_sweep): Don't read past end of array.
4375 In theory, the old code could also have corrupted Emacs internals,
4376 though it'd be very unlikely.
4378 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4380 * character.c (Fcharacterp): Don't advertise optional ignored
4381 argument. (Bug#4026)
4383 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4385 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4388 * window.c (Fset_window_start): Doc fix (bug#4199).
4389 (Fset_window_hscroll): Ditto.
4391 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4393 Fix minor new problems caught by GCC 4.6.1.
4394 * term.c (init_tty): Remove unused local.
4395 * xsettings.c (store_monospaced_changed): Define this function only
4396 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4399 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4401 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4403 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4405 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4406 are the mini-buffer and the echo area (bug#3320).
4408 * term.c (init_tty): Remove support for supdup, c10 and perq
4409 terminals, which are no longer supported (bug#1482).
4411 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4413 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4415 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4417 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4418 for non-popups (Bug#3642).
4420 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4422 * alloc.c (reset_malloc_hooks): Protoize.
4423 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4424 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4425 * cm.c (losecursor): Likewise.
4426 * data.c (fmod): Likewise.
4427 * dispnew.c (swap_glyphs_in_rows): Likewise.
4428 * emacs.c (memory_warning_signal): Likewise.
4429 * floatfns.c (float_error): Likewise.
4430 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4431 (otf_open, font_otf_capability, generate_otf_features)
4432 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4434 * image.c (pbm_read_file): Likewise.
4435 * indent.c (string_display_width): Likewise.
4436 * intervals.c (check_for_interval, search_for_interval)
4437 (inc_interval_count, count_intervals, root_interval)
4438 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4439 * lread.c (defalias): Likewise.
4440 * ralloc.c (r_alloc_check): Likewise.
4441 * regex.c (set_image_of_range_1, set_image_of_range)
4442 (regex_grow_registers): Likewise.
4443 * sysdep.c (strerror): Likewise.
4444 * termcap.c (valid_filename_p, tprint, main): Likewise.
4445 * tparam.c (main): Likewise.
4446 * unexhp9k800.c (run_time_remap, save_data_space)
4447 (update_file_ptrs, read_header, write_header, calculate_checksum)
4448 (copy_file, copy_rest, display_header): Likewise.
4449 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4451 * xdisp.c (check_it): Likewise.
4452 * xfaces.c (register_color, unregister_color, unregister_colors):
4454 * xfns.c (print_fontset_result): Likewise.
4455 * xrdb.c (member, fatal, main): Likewise.
4457 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4459 Fix minor problems found by static checking (Bug#9031).
4460 * chartab.c (char_table_set_range, map_sub_char_table):
4461 Remove unused locals.
4462 (uniprop_table): Now static.
4463 * composite.c (_work_char): Remove unused static var.
4465 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4467 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4469 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4471 * gtkutil.c (qttip_cb): Remove code without function.
4473 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4475 * w32.c (pthread_sigmask): New stub.
4477 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4479 Use pthread_sigmask, not sigprocmask (Bug#9010).
4480 sigprocmask is portable only for single-threaded applications, and
4481 Emacs can be multi-threaded when it uses GTK.
4482 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4484 * callproc.c (Fcall_process):
4485 * process.c (create_process):
4486 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4487 Use pthread_sigmask, not sigprocmask.
4489 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4491 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4492 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4495 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4497 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4498 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4499 (xg_hide_tooltip): Fix comment.
4501 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4502 in registerServicesMenuSendTypes.
4503 (validRequestorForSendType): Don't check ns_return_types.
4505 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4508 2011-07-08 Jason Rumney <jasonr@gnu.org>
4510 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4511 SH_SHOW for hidden windows (Bug#5482).
4513 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4514 frame struct members of non-existent frames (Bug#6284).
4516 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4518 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4519 variable firstTime not needed on OSX >= 10.6.
4520 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4521 >= 10.5. Use setKnobProportion, setDoubleValue.
4523 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4524 (MAC_OS_X_VERSION_10_5): Define if not defined.
4525 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4526 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4527 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4529 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4530 cString and lossyCString on OSX >= 10.4
4532 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4533 sizeToFit on OSX >= 10.2.
4535 * nsimage.m (allocInitFromFile): Don't use deprecated method
4536 bestRepresentationForDevice on OSX >= 10.6.
4538 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4541 * emacs.c: Declare unexec_init_emacs_zone.
4543 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4545 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4547 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4548 on svcsMenu (Bug#8842).
4550 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4552 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4554 * nsterm.m (QUTF8_STRING): Declare.
4555 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4556 (validRequestorForSendType): Return type is (id).
4557 Change indexOfObjectIdenticalTo to indexOfObject.
4558 Check if we have local selection before returning self (Bug#8842).
4559 (writeSelectionToPasteboard): Put local selection into paste board
4560 if we have a local selection (Bug#8842).
4561 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4563 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4564 (ns_get_local_selection): Declare.
4566 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4568 * keymap.c (describe_map_tree): Don't insert a double newline at
4569 the end of the buffer (bug#1169) and return whether we inserted
4572 * callint.c (Fcall_interactively): Change "reading args" to
4573 "providing args" to try to clarify what it does (bug#1010).
4575 2011-07-07 Kenichi Handa <handa@m17n.org>
4577 * composite.c (composition_compute_stop_pos): Ignore a static
4578 composition starting before CHARPOS (Bug#8915).
4580 * xdisp.c (handle_composition_prop): Likewise.
4582 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4584 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4587 2011-07-07 Kenichi Handa <handa@m17n.org>
4589 * character.h (unicode_category_t): New enum type.
4591 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4592 (Qchar_code_property_table): New variable.
4593 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4594 (UNIPROP_COMPRESSED_FORM_P): New macros.
4595 (char_table_ascii): Uncompress the compressed values.
4596 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4597 Uncompress the compressed values.
4598 (sub_char_table_ref_and_range): Likewise.
4599 (char_table_ref_and_range): Uncompress the compressed values.
4600 (sub_char_table_set): New arg is_uniprop. Callers changed.
4601 Uncompress the compressed values.
4602 (sub_char_table_set_range): Args changed. Callers changed.
4603 (char_table_set_range): Adjuted for the above change.
4604 (map_sub_char_table): Delete args default_val and parent. Add arg
4605 top. Give decoded values to a Lisp function.
4606 (map_char_table): Adjust for the above change. Give decoded
4607 values to a Lisp function. Gcpro more variables.
4608 (uniprop_table_uncompress)
4609 (uniprop_decode_value_run_length): New functions.
4610 (uniprop_decoder, uniprop_decoder_count): New variables.
4611 (uniprop_get_decoder, uniprop_encode_value_character)
4612 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4614 (uniprop_encoder, uniprop_encoder_count): New variables.
4615 (uniprop_get_encoder, uniprop_table)
4616 (Funicode_property_table_internal, Fget_unicode_property_internal)
4617 (Fput_unicode_property_internal): New functions.
4618 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4619 Sunicode_property_table_internal, Sget_unicode_property_internal,
4620 and Sput_unicode_property_internal. Defvar_lisp
4621 char-code-property-alist.
4623 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4624 Vunicode_category_table.
4626 * font.c (font_range): Adjust for the change of
4627 Vunicode_category_table.
4629 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4631 * m/iris4d.h: Remove file, move contents ...
4632 * s/irix6-5.h: ... here.
4634 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4636 Remove unportable assumption about struct layout (Bug#8884).
4637 * alloc.c (mark_buffer):
4638 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4639 (clone_per_buffer_values): Don't assume that
4640 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4641 This isn't true in general, and it's particularly not true
4642 if Emacs is configured with --with-wide-int.
4643 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4644 New macros, used in the buffer.c change.
4646 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4648 * xsettings.c: Use both GConf and GSettings if both are available.
4649 (store_config_changed_event): Add comment.
4650 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4651 (store_tool_bar_style_changed): New functions.
4652 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4653 (struct xsettings): Move font inside HAVE_XFT.
4654 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4655 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4656 Move inside HAVE_XFT.
4657 (something_changed_gsettingsCB): Rename from something_changedCB.
4658 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4660 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4661 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4662 (something_changed_gconfCB): Rename from something_changedCB.
4663 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4664 (parse_settings): Move check for font inside HAVE_XFT.
4665 (read_settings, apply_xft_settings): Add comment.
4666 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4667 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4668 call store_font_name_changed.
4669 (xft_settings_event): Add comment.
4670 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4671 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4672 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4673 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4674 (xsettings_initialize): Call init_gsettings last.
4675 (xsettings_get_system_font, xsettings_get_system_normal_font):
4678 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4680 Random fixes. E.g., (random) never returned negative values.
4681 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4682 subseconds part to the entropy, as that's a bit more random.
4683 Prefer signed to unsigned, since the signedness doesn't matter and
4684 in general we prefer signed. When given a limit, use a
4685 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4686 latter isn't right if USE_2_TAGS_FOR_INTS.
4687 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4688 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4690 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4692 * textprop.c (text_property_stickiness):
4693 Obey Vtext_property_default_nonsticky.
4694 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4695 * w32fns.c (syms_of_w32fns):
4696 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4698 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4700 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4701 This is more efficient than Ffile_directory_p and avoids a minor race.
4703 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4705 * buffer.c (Foverlay_put): Say what the return value is
4708 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4709 is a directory before asking whether to use the file name
4711 (barf_or_query_if_file_exists): Make the "File is a directory"
4712 error be more correct.
4714 * fns.c (Frequire): Remove the mention of the .gz files, since
4715 that's installation-specific, but keep the mention of
4716 `get-load-suffixes'.
4718 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4720 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4721 Report string overflow if the output is too long.
4723 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4725 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4726 (syms_of_gnutls): Remove duplicate DEFSYM for
4727 Qgnutls_bootprop_verify_hostname_error, an error for
4728 Qgnutls_bootprop_verify_error (which is no longer used).
4730 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4731 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4732 Also (re)move comments that are misplaced or no longer relevant.
4734 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4736 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4738 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4740 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4741 and background color parameters if they have been changed.
4743 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4745 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4747 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4749 * xsettings.c (SYSTEM_FONT): Define only when used.
4750 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4752 * keymap.c (access_keymap_1): Now static.
4754 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4756 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4757 leave any prefix arg for the up event (Bug#1586).
4759 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4761 * lread.c (syms_of_lread): Mention single symbols defined by
4762 `defvar' or `defconst' (bug#7154).
4764 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4765 (Frequire): Mention get-load-suffixes.
4767 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4769 * window.h (window): Remove clone_number slot.
4770 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4772 (make_parent_window, make_window, saved_window)
4773 (Fset_window_configuration, save_window_save): Don't deal with
4775 * buffer.c (Qclone_number): Remove declaration.
4776 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4778 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4780 Add multiple inheritance to keymaps.
4781 * keymap.c (Fmake_composed_keymap): New function.
4782 (Fset_keymap_parent): Simplify.
4783 (fix_submap_inheritance): Remove.
4784 (access_keymap_1): New function extracted from access_keymap to handle
4785 embedded parents and handle lists of maps.
4786 (access_keymap): Use it.
4787 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4788 (Fcopy_keymap): Handle embedded parents.
4789 (Fcommand_remapping, define_as_prefix): Simplify.
4790 (Fkey_binding): Simplify.
4791 (syms_of_keymap): Move minibuffer-local-completion-map,
4792 minibuffer-local-filename-completion-map,
4793 minibuffer-local-must-match-map, and
4794 minibuffer-local-filename-must-match-map to Elisp.
4795 (syms_of_keymap): Defsubr make-composed-keymap.
4796 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4797 (parse_menu_item): Trivial simplification.
4799 2011-07-01 Glenn Morris <rgm@gnu.org>
4801 * Makefile.in (SETTINGS_LIBS): Fix typo.
4803 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4805 * coding.c (Fencode_coding_string): Record the last coding system
4806 used, as the function doc string says (bug#8738).
4808 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4810 * xsettings.c (store_monospaced_changed): Take new font as arg and
4811 check for change against current_mono_font.
4812 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4813 (emacs_settings_constructor, emacs_settings_get_property)
4814 (emacs_settings_set_property, emacs_settings_class_init)
4815 (emacs_settings_init, gsettings_obj): Remove.
4816 (something_changedCB): New function for HAVE_GSETTINGS.
4817 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4818 with value as argument.
4819 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4820 g_settings_new (Bug#8967). Do not create gsettings_obj.
4821 Remove calls to g_settings_bind. Connect something_changedCB to
4824 * xgselect.c: Add defined (HAVE_GSETTINGS).
4825 (xgselect_initialize): Ditto.
4827 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4828 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4831 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4833 * eval.c (struct backtrace): Simplify and port the data structure.
4834 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4835 signed bit field, as this assumption is not portable and it makes
4836 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4837 "char debug_on_exit : 1" as this is not portable either; instead,
4838 use the portable "unsigned int debug_on_exit : 1". Remove unused
4839 member evalargs. Remove obsolete comments about cc bombing out.
4841 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4843 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4844 Let HAVE_GSETTINGS override HAVE_GCONF.
4845 (store_monospaced_changed): New function.
4846 (EMACS_SETTINGS): A new type derived from GObject to handle
4847 GSettings notifications.
4848 (emacs_settings_constructor, emacs_settings_get_property)
4849 (emacs_settings_set_property, emacs_settings_class_init):
4851 (gsettings_client, gsettings_obj): New variables.
4852 (GSETTINGS_SCHEMA): New define.
4853 (something_changedCB): Call store_monospaced_changed.
4854 (init_gsettings): New function.
4855 (xsettings_initialize): Call init_gsettings.
4856 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4859 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4862 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4864 * window.c (resize_root_window, grow_mini_window)
4865 (shrink_mini_window): Rename Qresize_root_window to
4866 Qwindow_resize_root_window and Qresize_root_window_vertically to
4867 Qwindow_resize_root_window_vertically.
4869 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4871 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4873 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4875 * makefile.w32-in: Redesign dependencies so they reflect more
4876 clearly which files are directly included by each source file,
4877 and not through other includes.
4879 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4881 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4882 (sort_overlays, overlay_strings): When an overlay's clone number
4883 matches the window's clone number process the overlay even if
4884 the overlay's window property doesn't match the current window.
4886 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4887 (Fwindow_hchild): Rename to Fwindow_left_child.
4888 (Fwindow_next): Rename to Fwindow_next_sibling.
4889 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4890 (resize_window_check): Rename to window_resize_check.
4891 (resize_window_apply): Rename to window_resize_apply.
4892 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4893 (Fdelete_other_windows_internal, resize_frame_windows)
4894 (Fsplit_window_internal, Fdelete_window_internal)
4895 (grow_mini_window, shrink_mini_window)
4896 (Fresize_mini_window_internal): Fix callers accordingly.
4898 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4900 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4901 (emacs_fixed_set_min_size): Remove.
4902 (emacs_fixed_new): Take frame as argument.
4904 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4905 (_EmacsFixedPrivate): Remove minwidth/height.
4906 Add struct frame *f.
4907 (emacs_fixed_init): Initialize priv->f.
4908 (get_parent_class, emacs_fixed_set_min_size): Remove.
4909 (emacs_fixed_new): Set priv->f to argument.
4910 (emacs_fixed_get_preferred_width)
4911 (emacs_fixed_get_preferred_height): Use min_width/height from
4912 frames size_hint to set minimum and natural (Bug#8919).
4913 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4914 and use min_width/height from frames size_hint to set
4915 min_width/height (Bug#8919).
4917 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4918 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4921 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4923 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4924 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4927 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4929 * process.c (wait_reading_process_output): Bypass select if
4930 waiting for a cell while ignoring keyboard input, and input is
4931 pending. Suggested by Jan Djärv (Bug#8869).
4933 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4935 Use gnulib's dup2 module instead of rolling our own.
4936 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4938 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4940 * dispnew.c (scrolling_window): Before scrolling, turn off a
4941 mouse-highlight in the window being scrolled.
4943 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4945 Move DEFSYM to lisp.h and use everywhere.
4947 * character.h (DEFSYM): Move declaration...
4948 * lisp.h (DEFSYM): ...here.
4954 * w32select.c: Don't include character.h.
4956 * alloc.c (syms_of_alloc):
4957 * buffer.c (syms_of_buffer):
4958 * bytecode.c (syms_of_bytecode):
4959 * callint.c (syms_of_callint):
4960 * casefiddle.c (syms_of_casefiddle):
4961 * casetab.c (init_casetab_once):
4962 * category.c (init_category_once, syms_of_category):
4963 * ccl.c (syms_of_ccl):
4964 * cmds.c (syms_of_cmds):
4965 * composite.c (syms_of_composite):
4966 * dbusbind.c (syms_of_dbusbind):
4967 * dired.c (syms_of_dired):
4968 * dispnew.c (syms_of_display):
4969 * doc.c (syms_of_doc):
4970 * editfns.c (syms_of_editfns):
4971 * emacs.c (syms_of_emacs):
4972 * eval.c (syms_of_eval):
4973 * fileio.c (syms_of_fileio):
4974 * fns.c (syms_of_fns):
4975 * frame.c (syms_of_frame):
4976 * fringe.c (syms_of_fringe):
4977 * insdel.c (syms_of_insdel):
4978 * keymap.c (syms_of_keymap):
4979 * lread.c (init_obarray, syms_of_lread):
4980 * macros.c (syms_of_macros):
4981 * msdos.c (syms_of_msdos):
4982 * print.c (syms_of_print):
4983 * process.c (syms_of_process):
4984 * search.c (syms_of_search):
4985 * sound.c (syms_of_sound):
4986 * syntax.c (init_syntax_once, syms_of_syntax):
4987 * terminal.c (syms_of_terminal):
4988 * textprop.c (syms_of_textprop):
4989 * undo.c (syms_of_undo):
4990 * w32.c (globals_of_w32):
4991 * window.c (syms_of_window):
4992 * xdisp.c (syms_of_xdisp):
4993 * xfaces.c (syms_of_xfaces):
4994 * xfns.c (syms_of_xfns):
4995 * xmenu.c (syms_of_xmenu):
4996 * xsettings.c (syms_of_xsettings):
4997 * xterm.c (syms_of_xterm): Use DEFSYM.
4999 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5001 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5003 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5005 Integer and buffer overflow fixes (Bug#8873).
5007 * print.c (printchar, strout): Check for string overflow.
5008 (PRINTPREPARE, printchar, strout):
5009 Don't set size unless allocation succeeds.
5011 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5012 for sizes. Check for string overflow more accurately.
5013 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5015 * macros.c: Integer and buffer overflow fixes.
5016 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5017 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5018 Use ptrdiff_t, not int, for sizes.
5019 Don't increment bufsize until after realloc succeeds.
5020 Check for size-calculation overflow.
5021 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5023 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5025 * lread.c: Integer overflow fixes.
5026 (read_integer): Radix is now EMACS_INT, not int,
5027 to improve quality of diagnostics for out-of-range radices.
5028 Calculate buffer size correctly for out-of-range radices.
5029 (read1): Check for integer overflow in radices, and in
5030 read-circle numbers.
5031 (read_escape): Avoid int overflow.
5032 (Fload, openp, read_buffer_size, read1)
5033 (substitute_object_recurse, read_vector, read_list, map_obarray):
5034 Use ptrdiff_t, not int, for sizes.
5035 (read1): Use EMACS_INT, not int, for sizes.
5036 Check for size overflow.
5038 * image.c (cache_image): Check for size arithmetic overflow.
5040 * lread.c: Integer overflow issues.
5041 (saved_doc_string_size, saved_doc_string_length)
5042 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5043 Now ptrdiff_t, not int.
5044 (read1): Don't assume doc string length fits in int. Check for
5045 out-of-range doc string lengths.
5046 (read_list): Don't assume file position fits in int.
5047 (read_escape): Check for hex character overflow.
5049 2011-06-22 Leo Liu <sdl.web@gmail.com>
5051 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5052 Move to minibuffer.el.
5054 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5056 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5057 The following patches are for when GLYPH_DEBUG && !XASSERT.
5058 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5059 * dispnew.c (flush_stdout):
5060 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5061 Mark as externally visible.
5062 * dispnew.c (check_window_matrix_pointers): Now static.
5063 * dispnew.c (window_to_frame_vpos):
5064 * xfns.c (unwind_create_frame):
5065 * xterm.c (x_check_font): Remove unused local.
5066 * scroll.c (CHECK_BOUNDS):
5067 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5068 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5069 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5070 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5071 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5073 (debug_method_add): Use va_list and vsprintf rather than relying
5074 on undefined behavior with wrong number of arguments.
5075 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5076 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5077 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5078 since we're not interested in debugging glyphs with old libraries.
5079 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5080 GCC 4.6.0's static checking.
5082 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5084 Integer overflow and signedness fixes (Bug#8873).
5085 A few related buffer overrun fixes, too.
5087 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5089 * dispextern.h (struct face.stipple):
5090 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5091 (x_bitmap_mask, x_allocate_bitmap_record)
5092 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5093 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5094 (x_create_bitmap_from_xpm_data):
5095 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5096 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5098 * xfaces.c (load_pixmap):
5099 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5100 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5101 (.bitmaps_last, struct x_output.icon_bitmap):
5102 Use ptrdiff_t, not int, for bitmap indexes.
5103 (x_allocate_bitmap_record): Check for size overflow.
5104 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5106 Use ptrdiff_t, not int, for overlay counts.
5107 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5108 * editfns.c (overlays_around, get_pos_property):
5109 * textprop.c (get_char_property_and_overlay):
5110 * xdisp.c (next_overlay_change, note_mouse_highlight):
5111 * xfaces.c (face_at_buffer_position):
5112 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5113 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5114 (Fnext_overlay_change, Fprevious_overlay_change)
5115 (mouse_face_overlay_overlaps, Foverlays_in):
5116 Use ptrdiff_t, not int, for sizes.
5117 (overlays_at, overlays_in): Check for size-calculation overflow.
5119 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5121 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5122 (x_session_initialize): Do not assume string length fits in int.
5124 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5125 This is unlikely, but can occur if DPI is outlandish.
5127 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5128 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5130 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5131 * xrdb.c (magic_file_p, search_magic_path):
5132 Omit last arg SUFFIX; it was always 0. All callers changed.
5133 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5135 * xfont.c (xfont_match): Avoid need for strlen.
5137 * xfns.c: Don't assume strlen fits in int.
5138 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5140 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5141 not unsigned long, as we prefer signed integers. All callers changed.
5142 Detect integer overflow in repeat count.
5143 (message_dolog): Don't assume print length fits in 39 bytes.
5144 (display_mode_element): Don't assume strlen fits in int.
5146 * termcap.c: Don't assume sizes fit in int and never overflow.
5147 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5148 (gobble_line): Check for size-calculation overflow.
5150 * minibuf.c (Fread_buffer):
5151 * lread.c (intern, intern_c_string):
5152 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5153 Don't assume string length fits in int.
5155 * keyboard.c (parse_tool_bar_item):
5156 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5158 * font.c: Don't assume string length fits in int.
5159 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5160 Use ptrdiff_t, not int.
5161 (font_intern_prop): Don't assume string length fits in int.
5162 Don't assume integer property fits in fixnum.
5163 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5165 * filelock.c: Fix some buffer overrun and integer overflow issues.
5166 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5167 Reformulate so as not to need the command string.
5168 Invoke gzip -cd rather than gunzip, as it's more portable.
5169 (lock_info_type, lock_file_1, lock_file):
5170 Don't assume pid_t and time_t fit in unsigned long.
5171 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5172 (current_lock_owner): Prefer signed type for sizes.
5173 Use memcpy, not strncpy, where memcpy is what is really wanted.
5174 Don't assume (via atoi) that time_t and pid_t fit in int.
5175 Check for time_t and/or pid_t out of range, e.g., via a network share.
5176 Don't alloca where an auto var works fine.
5178 * fileio.c: Fix some integer overflow issues.
5179 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5180 Don't assume string length fits in int.
5181 (directory_file_name): Don't assume string length fits in long.
5182 (make_temp_name): Don't assume pid fits in int, or that its print
5183 length is less than 20.
5185 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5187 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5189 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5191 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5192 We prefer signed integers, even for size calculations.
5194 * emacs.c: Don't assume string length fits in 'int'.
5195 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5196 (main): Don't invoke strlen when not needed.
5198 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5199 (XD_DEBUG_MESSAGE): Don't waste a byte.
5201 * callproc.c (getenv_internal_1, getenv_internal)
5203 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5205 * lread.c (invalid_syntax): Omit length argument.
5206 All uses changed. This doesn't fix a bug, but it simplifies the
5207 code away from its former Hollerith-constant appearance, and it's
5208 one less 'int' to worry about when looking at integer-overflow issues.
5209 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5211 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5212 This didn't break anything, but it didn't help either.
5213 It's confusing to put a bogus integer in a place where the actual
5214 value does not matter.
5215 (LIST_END_P): Remove unused macro and its bogus comment.
5216 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5218 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5219 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5221 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5222 We prefer signed types, and the value cannot exceed the EMACS_INT
5223 range anyway (because otherwise the length would not be representable).
5224 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5225 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5226 This avoids a GCC warning when WIDE_EMACS_INT.
5228 * indent.c (sane_tab_width): New function.
5229 (current_column, scan_for_column, Findent_to, position_indentation)
5230 (compute_motion): Use it. This is just for clarity.
5231 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5233 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5235 * lisp.h (lint_assume): New macro.
5236 * composite.c (composition_gstring_put_cache):
5237 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5239 * editfns.c, insdel.c:
5240 Omit unnecessary forward decls, to simplify future changes.
5242 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5244 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5246 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5247 Use much-faster test for byte-length change.
5248 Don't assume string byte-length fits in 'int'.
5249 Check that character arg fits in 'int'.
5250 (mapcar1): Declare byte as byte, for clarity.
5252 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5254 * fns.c (concat): Catch string overflow earlier.
5255 Do not rely on integer wraparound.
5257 * dispextern.h (struct it.overlay_strings_charpos)
5258 (struct it.selective): Now EMACS_INT, not int.
5259 * xdisp.c (forward_to_next_line_start)
5260 (back_to_previous_visible_line_start)
5261 (reseat_at_next_visible_line_start, next_element_from_buffer):
5262 Don't arbitrarily truncate the value of 'selective' to int.
5264 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5266 * composite.c: Don't truncate sizes to 'int'.
5267 (composition_gstring_p, composition_reseat_it)
5268 (composition_adjust_point): Use EMACS_INT, not int.
5269 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5270 not EMACS_UINT, for indexes.
5272 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5274 * buffer.c: Include <verify.h>.
5275 (struct sortvec.priority, struct sortstr.priority):
5276 Now EMACS_INT, not int.
5277 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5278 (struct sortstr.size, record_overlay_string)
5279 (struct sortstrlist.size, struct sortlist.used):
5280 Don't truncate size to int.
5281 (record_overlay_string): Check for size-calculation overflow.
5282 (init_buffer_once): Check at compile-time, not run-time.
5284 2011-06-22 Jim Meyering <meyering@redhat.com>
5286 Don't leak an XBM-image-sized buffer
5287 * image.c (xbm_load): Free the image buffer after using it.
5289 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5292 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5293 that Sun C diagnosed.
5294 * fns.c (secure_hash): Fix pointer signedness issue.
5295 * intervals.c (static_offset_intervals): New function.
5296 (offset_intervals): Use it.
5298 2011-06-21 Leo Liu <sdl.web@gmail.com>
5301 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5304 * fns.c (secure_hash): Rename from crypto_hash_function and change
5305 the first arg to accept symbols.
5306 (Fsecure_hash): New primitive.
5307 (syms_of_fns): New symbols.
5309 2011-06-20 Deniz Dogan <deniz@dogan.se>
5311 * process.c (Fset_process_buffer): Clarify return value in
5314 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5316 * dispnew.c (add_window_display_history): Use BVAR.
5318 * xdisp.c (debug_method_add): Use BVAR.
5319 (check_window_end, dump_glyph_matrix, dump_glyph)
5320 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5322 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5325 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5326 check till after the cache is created in init_frame_faces.
5328 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5330 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5332 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5334 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5335 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5336 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5338 Improve buffer-overflow checking (Bug#8873).
5339 * fileio.c (Finsert_file_contents):
5340 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5341 Remove the old (too-loose) buffer overflow checks.
5342 They weren't needed, since make_gap checks for buffer overflow.
5343 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5344 The old code merely checked for Emacs fixnum overflow, and relied
5345 on undefined (wraparound) behavior. The new code avoids undefined
5346 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5348 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5349 Tune. Don't use wider integers than needed. Don't use alloca.
5350 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5352 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5354 * insdel.c, lisp.h (buffer_overflow): New function.
5355 (insert_from_buffer_1, replace_range, replace_range_2):
5356 * insdel.c (make_gap_larger):
5357 * editfns.c (Finsert_char):
5358 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5360 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5362 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5364 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5366 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5367 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5369 * fileio.c: Don't assume EMACS_INT fits in off_t.
5370 (emacs_lseek): New static function.
5371 (Finsert_file_contents, Fwrite_region): Use it.
5372 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5374 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5376 * fns.c: Don't overflow int when computing a list length.
5377 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5378 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5379 truncation on 64-bit hosts. Check for QUIT every
5380 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5381 faster and is responsive enough.
5382 (Flength): Report an error instead of overflowing an integer.
5383 (Fsafe_length): Return a float if the value is not representable
5384 as a fixnum. This shouldn't happen except in contrived situations.
5385 (Fnthcdr, Fsort): Don't assume list length fits in int.
5386 (Fcopy_sequence): Don't assume vector length fits in int.
5388 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5389 (header_size, word_size): New constants.
5390 (allocate_vectorlike): Don't check size overflow here.
5391 (allocate_vector): Check it here instead, since this is the only
5392 caller of allocate_vectorlike that could cause overflow.
5393 Check that the new vector's length is representable as a fixnum.
5395 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5396 The previous code was bogus. For example, next_almost_prime (32)
5397 returned 39, which is undesirable as it is a multiple of 3; and
5398 next_almost_prime (24) returned 25, which is a multiple of 5 so
5399 why was the code bothering to check for multiples of 7?
5401 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5403 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5405 Variadic C functions now count arguments with ptrdiff_t.
5406 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5407 Back then I didn't know that the Emacs coding style prefers signed int.
5408 Also, in the meantime I found a few more instances where arguments
5409 were being counted with int, which may truncate counts on 64-bit
5410 machines, or EMACS_INT, which may be unnecessarily wide.
5411 * lisp.h (struct Lisp_Subr.function.aMANY)
5412 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5413 Arg counts are now ptrdiff_t, not size_t.
5414 All variadic functions and their callers changed accordingly.
5415 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5416 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5417 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5418 * callint.c (Fcall_interactively): Check arg count for overflow,
5419 to avoid potential buffer overrun. Use signed char, not 'int',
5420 for 'varies' array, so that we needn't bother to check its size
5421 calculation for overflow.
5422 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5423 * eval.c (apply_lambda):
5424 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5425 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5426 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5428 * callint.c (Fcall_interactively): Don't use index var as event count.
5430 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5431 * mem-limits.h (SIZE): Remove; no longer used.
5433 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5435 Remove unnecessary casts.
5436 * xterm.c (x_term_init):
5437 * xfns.c (x_set_border_pixel):
5438 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5439 These aren't needed now that we assume ANSI C.
5441 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5442 It's more likely to cause problems (due to unsigned overflow)
5445 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5447 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5449 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5451 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5453 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5455 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5457 GLYPH_CODE_FACE returns EMACS_INT, not int.
5458 * dispextern.h (merge_faces):
5459 * xfaces.c (merge_faces):
5460 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5461 Don't assume EMACS_INT fits in int.
5463 * character.h (CHAR_VALID_P): Remove unused parameter.
5464 * fontset.c, lisp.h, xdisp.c: All uses changed.
5466 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5468 * fns.c (concat): Minor tuning based on overflow analysis.
5469 This doesn't fix any bugs. Use int to hold character, instead
5470 of constantly refetching from Emacs object. Use XFASTINT, not
5471 XINT, for value known to be a character. Don't bother comparing
5472 a single byte to 0400, as it's always less.
5474 * floatfns.c (Fexpt):
5475 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5477 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5480 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5482 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5483 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5484 incorrectly succeed when S was a string, because 4294967386 was
5485 truncated before it was used.
5487 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5488 Otherwise, an out-of-range integer could cause undefined behavior
5491 * composite.c: Use int, not EMACS_INT, for characters.
5492 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5493 EMACS_INT, for values that are known to be in character range.
5494 This doesn't fix any bugs but is the usual style inside Emacs and
5495 may generate better code on 32-bit machines.
5497 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5498 This is for reasons similar to the recent CHAR_STRING fix.
5499 * charset.c (Fencode_char): Check that character arg is actually
5500 a character. Pass an int to ENCODE_CHAR.
5501 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5502 wider than 'int', as a compile-time check to prevent future regressions
5505 * character.c (char_string): Remove unnecessary casts.
5507 Make sure a 64-bit char is never passed to CHAR_STRING.
5508 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5509 by silently ignoring the top 32 bits, allowing some values
5510 that were far too large to be valid characters.
5511 * character.h: Include <verify.h>.
5512 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5513 arguments are no wider than unsigned, as a compile-time check
5514 to prevent future regressions in this area.
5516 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5517 (Fsubst_char_in_region):
5519 * xdisp.c (decode_mode_spec_coding):
5520 Adjust to CHAR_STRING's new requirement.
5521 * editfns.c (Finsert_char, Fsubst_char_in_region):
5522 * fns.c (concat): Check that character args are actually
5523 characters. Without this test, these functions did the wrong
5524 thing with wildly out-of-range values on 64-bit hosts.
5526 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5527 These casts should not be needed on 32-bit hosts, either.
5528 * keyboard.c (read_char):
5529 * lread.c (Fload): Remove casts to unsigned.
5531 * lisp.h (UNSIGNED_CMP): New macro.
5532 This fixes comparison bugs on 64-bit hosts.
5533 (ASCII_CHAR_P): Use it.
5534 * casefiddle.c (casify_object):
5535 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5536 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5537 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5538 * dispextern.h (FACE_FROM_ID):
5539 * keyboard.c (read_char): Use UNSIGNED_CMP.
5541 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5542 not to EMACS_INT, to avoid GCC warning.
5544 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5546 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5547 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5548 isn't needed on 32-bit machines.
5550 * buffer.c (Fgenerate_new_buffer_name):
5551 Use EMACS_INT for count, not int.
5552 (advance_to_char_boundary): Return EMACS_INT, not int.
5554 * data.c (Qcompiled_function): Now static.
5556 * window.c (window_body_lines): Now static.
5558 * image.c (gif_load): Rename local to avoid shadowing.
5560 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5561 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5562 * alloc.c (make_save_value): Integer argument is now of type
5564 (mark_object): Use ptrdiff_t, not int.
5565 * lisp.h (pD): New macro.
5566 * print.c (print_object): Use it.
5568 * alloc.c: Use EMACS_INT, not int, to count objects.
5569 (total_conses, total_markers, total_symbols, total_vector_size)
5570 (total_free_conses, total_free_markers, total_free_symbols)
5571 (total_free_floats, total_floats, total_free_intervals)
5572 (total_intervals, total_strings, total_free_strings):
5573 Now EMACS_INT, not int. All uses changed.
5574 (Fgarbage_collect): Compute overall total using a double, so that
5575 integer overflow is less likely to be a problem. Check for overflow
5576 when converting back to an integer.
5577 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5578 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5579 These were 'int' variables that could overflow on 64-bit hosts;
5580 they were never used, so remove them instead of repairing them.
5581 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5582 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5583 Previously, this ceilinged at INT_MAX, but that doesn't work on
5585 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5587 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5588 (allocate_vectorlike): Check for ptrdiff_t overflow.
5589 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5590 when a (possibly-narrower) signed value would do just as well.
5591 We prefer using signed arithmetic, to avoid comparison confusion.
5593 * alloc.c: Catch some string size overflows that we were missing.
5594 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5595 for convenience in STRING_BYTES_MAX.
5596 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5597 The definition here is exact; the one in lisp.h was approximate.
5598 (allocate_string_data): Check for string overflow. This catches
5599 some instances we weren't catching before. Also, it catches
5600 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5601 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5602 and ptrdiff_t and EMACS_INT are both 64 bits.
5604 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5605 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5606 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5608 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5610 * alloc.c (Fmake_string): Check for out-of-range init.
5612 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5614 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5616 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5618 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5619 xg_get_default_scrollbar_width.
5621 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5622 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5623 (style_changed_cb): Call update_theme_scrollbar_width and call
5624 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5625 all frames (Bug#8505).
5626 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5627 Call gtk_window_set_resizable if HAVE_GTK3.
5628 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5629 and height if HAVE_GTK3 (Bug#8505).
5630 (scroll_bar_width_for_theme): New variable.
5631 (update_theme_scrollbar_width): New function.
5632 (xg_get_default_scrollbar_width): Move code to
5633 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5634 (xg_initialize): Call update_theme_scrollbar_width.
5636 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5638 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5640 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5642 * frame.c (make_frame): Call other_buffer_safely instead of
5645 * window.c (temp_output_buffer_show): Call display_buffer with
5646 second argument Vtemp_buffer_show_specifiers and reset latter
5647 immediately after the call.
5648 (Vtemp_buffer_show_specifiers): New variable.
5649 (auto_window_vscroll_p, next_screen_context_lines)
5650 (Vscroll_preserve_screen_position): Remove leading asterisks from
5653 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5655 Fix minor problems found by GCC 4.6.0 static checking.
5656 * buffer.c (Qclone_number): Remove for now, as it's unused.
5657 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5658 (record_buffer): Remove unused local.
5659 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5660 (set_frame_buffer_list): Remove; unused.
5661 * frame.h (other_visible_frames): Remove decl.
5662 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5663 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5664 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5666 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5667 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5668 Define only if HAVE_GPM.
5669 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5670 (update_hints_inhibit): Remove; never set. All uses removed.
5671 * widgetprv.h (emacsFrameClassRec): Remove decl.
5672 * window.c (delete_deletable_window): Now returns void, since it
5673 wasn't returning anything.
5674 (compare_window_configurations): Remove unused locals.
5675 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5676 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5677 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5678 the same widths as pointers. This follows up on the 2011-05-06 patch.
5679 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5680 * xterm.h: Likewise.
5681 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5683 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5685 * makefile.w32-in: Update dependencies.
5686 (LISP_H): Add lib/intprops.h.
5688 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5690 * image.c (gif_load): Add animation frame delay to the metadata.
5691 (syms_of_image): Use DEFSYM. New symbol `delay'.
5693 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5695 * window.c (delete_deletable_window): Re-add.
5696 (Fset_window_configuration): Rewrite to handle dead buffers and
5697 consequently deletable windows.
5698 (window_tree, Fwindow_tree): Remove. Supply functionality in
5700 (compare_window_configurations): Simplify code.
5702 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5704 * image.c (imagemagick_load_image): Fix type mismatch.
5705 (Fimagemagick_types): Likewise.
5707 * window.h (replace_buffer_in_windows): Declare.
5709 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5711 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5712 Qclone_number. Remove external declaration of Qdelete_window.
5713 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5715 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5716 Run Qbuffer_list_update_hook if allowed.
5717 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5718 buffer list implementation.
5719 (other_buffer_safely): New function.
5720 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5721 calls to replace_buffer_in_windows and
5722 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5724 (record_buffer): Inhibit quitting and rewrite using quittable
5725 functions. Run Qbuffer_list_update_hook if allowed.
5726 (Frecord_buffer, Funrecord_buffer): New functions.
5727 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5728 Move switch-to-buffer to window.el.
5729 (bury-buffer): Move to window.el.
5730 (Vbuffer_list_update_hook): New variable.
5732 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5735 * window.h (resize_frame_windows): Move up in code.
5736 (Fwindow_frame): Remove EXFUN.
5737 (replace_buffer_in_all_windows): Remove prototype.
5738 (replace_buffer_in_windows_safely): Add prototype.
5740 * window.c: Declare Qdelete_window static again. Move down
5741 declaration of select_count.
5742 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5743 (Fother_window): Move to window.el.
5744 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5745 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5746 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5748 (replace_buffer_in_windows): Implement by calling
5749 Qreplace_buffer_in_windows.
5750 (replace_buffer_in_all_windows): Remove with some functionality
5751 moved into replace_buffer_in_windows_safely.
5752 (replace_buffer_in_windows_safely): New function.
5753 (select_window_norecord, select_frame_norecord): Move in front
5754 of run_window_configuration_change_hook. Remove now obsolete
5756 (Fset_window_buffer): Rewrite doc-string.
5757 Call Qrecord_window_buffer.
5758 (keys_of_window): Move binding for other-window to window.el.
5760 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5762 * dispextern.h (struct image): Replace data member, whose int_val
5763 and ptr_val fields were not used by anything, with a single
5766 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5767 (gif_clear_image, gif_load, imagemagick_load_image)
5768 (gs_clear_image, gs_load): Callers changed.
5770 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5772 * buffer.h: Include <time.h>, for time_t.
5773 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5775 Fix minor problems found by static checking.
5777 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5779 Make identifiers static if they are not used in other modules.
5780 * data.c (Qcompiled_function, Qframe, Qvector):
5781 * image.c (QimageMagick, Qsvg):
5782 * minibuf.c (Qmetadata):
5783 * window.c (resize_window_check, resize_root_window): Now static.
5784 * window.h (resize_window_check, resize_root_window): Remove decls.
5786 * window.c (window_deletion_count, delete_deletable_window):
5788 (window_body_lines): Now static.
5789 (Fdelete_other_windows_internal): Mark vars as initialized.
5790 Make sure 'resize_failed' is initialized.
5791 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5792 (resize_window_apply): Remove unused local.
5793 * window.h (delete_deletable_window): Remove decl.
5795 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5796 (imagemagick_load_image): Fix pointer signedness problem by changing
5797 last arg from unsigned char * to char *. All uses changed.
5798 Also, fix a local for similar reasons.
5799 Remove unused locals. Remove locals to avoid shadowing.
5800 (fn_rsvg_handle_free): Remove; unused.
5801 (svg_load, svg_load_image): Fix pointer signedness problem.
5802 (imagemagick_load_image): Don't use garbage pointer image_wand.
5804 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5806 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5808 * image.c (gif_load): Fix omitted cast error introduced by
5811 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5813 * window.h (resize_proportionally, orig_total_lines)
5814 (orig_top_line): Remove from window structure.
5815 (set_window_height, set_window_width, change_window_heights)
5816 (Fdelete_window): Remove prototypes.
5817 (resize_frame_windows): Remove duplicate declaration.
5819 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5821 * window.h (resize_frame_windows, resize_window_check)
5822 (delete_deletable_window, resize_root_window)
5823 (resize_frame_windows): Declare prototypes.
5825 * window.c (resize_window_apply): Make definition be "static" to
5826 match the prototype.
5828 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5830 * window.c: Remove declarations of Qwindow_size_fixed,
5831 window_min_size_1, window_min_size_2, window_min_size,
5832 size_window, window_fixed_size_p, enlarge_window, delete_window.
5833 Remove static from declaration of Qdelete_window, it's
5834 temporarily needed by Fbury_buffer.
5835 (replace_window): Don't assign orig_top_line and
5837 (Fdelete_window, delete_window): Remove. Window deletion is
5838 handled by window.el.
5839 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5840 Replace Fdelete_window calls with calls to Qdelete_window.
5841 (Fdelete_other_windows): Remove. Deleting other windows is
5842 handled by window.el.
5843 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5844 handled in window.el.
5845 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5846 Window minimum sizes are handled in window.el.
5847 (shrink_windows, size_window, set_window_height)
5848 (set_window_width, change_window_heights, window_height)
5849 (window_width, CURBEG, CURSIZE, enlarge_window)
5850 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5851 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5852 handled in window.el.
5853 (make_dummy_parent): Rename to make_parent_window and give it a
5854 second argument horflag.
5855 (make_window): Don't set resize_proportionally any more.
5856 (Fsplit_window): Remove. Windows are split in window.el.
5857 (save_restore_action, save_restore_orig_size)
5858 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5859 Resize mini windows in window.el.
5860 (grow_mini_window, shrink_mini_window): Implement by calling
5861 Qresize_root_window_vertically, resize_window_check and
5862 resize_window_apply.
5863 (saved_window, Fset_window_configuration, save_window_save):
5864 Do not handle orig_top_line, orig_total_lines, and
5865 resize_proportionally.
5866 (window_min_height, window_min_width): Move to window.el.
5867 (keys_of_window): Move bindings for delete-other-windows,
5868 split-window, delete-window and enlarge-window to window.el.
5870 * buffer.c: Temporarily extern Qdelete_window.
5871 (Fbury_buffer): Temporarily call Qdelete_window instead of
5872 Fdelete_window (Fbury_buffer will move to window.el soon).
5874 * frame.c (set_menu_bar_lines_1): Remove code handling
5875 orig_top_line and orig_total_lines.
5877 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5878 set_window_height but set heights directly.
5879 (change_frame_size_1): Use resize_frame_windows.
5881 * xdisp.c (init_xdisp): Don't use set_window_height but set
5884 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5885 Use resize_frame_windows instead of change_window_heights and run
5886 run_window_configuration_change_hook.
5888 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5889 instead of change_window_heights and run
5890 run_window_configuration_change_hook.
5892 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5894 * window.c (replace_window): Rename second argument REPLACEMENT to
5895 NEW. New third argument SETFLAG. Rewrite.
5896 (delete_window, make_dummy_parent): Call replace_window with
5898 (window_list_1): Move down in code.
5899 (run_window_configuration_change_hook): Move set_buffer part
5900 before select_frame_norecord part in order to unwind correctly.
5901 Rename count1 to count.
5902 (recombine_windows, delete_deletable_window, resize_root_window)
5903 (Fdelete_other_windows_internal)
5904 (Frun_window_configuration_change_hook, make_parent_window)
5905 (resize_window_check, resize_window_apply, Fresize_window_apply)
5906 (resize_frame_windows, Fsplit_window_internal)
5907 (Fdelete_window_internal, Fresize_mini_window_internal):
5909 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5911 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5913 * window.h (window): Add some new members to window structure -
5914 normal_lines, normal_cols, new_total, new_normal, clone_number,
5915 splits, nest, prev_buffers, next_buffers.
5916 (WINDOW_TOTAL_SIZE): Move here from window.c.
5917 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5919 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5921 (make_dummy_parent): Set new members of windows structure.
5922 (make_window): Move down in code. Handle new members of window
5924 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5925 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5926 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5927 (Fset_window_prev_buffers, Fwindow_next_buffers)
5928 (Fset_window_next_buffers, Fset_window_clone_number):
5930 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5931 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5933 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5934 Argument WINDOW can be now internal window too.
5935 (Fwindow_use_time): Move up in code.
5936 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5938 (Fset_window_configuration, saved_window)
5939 (Fcurrent_window_configuration, save_window_save): Handle new
5940 members of window structure.
5941 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5942 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5943 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5944 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5945 Qget_mru_window, Qresize_root_window,
5946 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5947 Qauto_buffer_name; staticpro them.
5949 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5951 * window.c (Fwindow_total_size, Fwindow_left_column)
5952 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5953 (Fwindow_list_1): New functions.
5954 (window_box_text_cols): Replace with window_body_cols.
5955 (Fwindow_width, Fscroll_left, Fscroll_right):
5956 Use window_body_cols instead of window_box_text_cols.
5957 (delete_window, Fset_window_configuration):
5958 Call delete_all_subwindows with window as argument.
5959 (delete_all_subwindows): Take a window as argument and not a
5961 (window_loop): Remove handling of GET_LRU_WINDOW and
5963 (Fget_lru_window, Fget_largest_window): Move to window.el.
5965 * window.h: Extern window_body_cols instead of
5966 window_box_text_cols. delete_all_subwindows now takes a
5967 Lisp_Object as argument.
5969 * indent.c (compute_motion, Fcompute_motion):
5970 Use window_body_cols instead of window_box_text_cols.
5972 * frame.c (delete_frame): Call delete_all_subwindows with root
5975 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5977 * fns.c (Fputhash): Document return value.
5979 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5981 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5983 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5985 Cons<->int and similar integer overflow fixes (Bug#8794).
5987 Check for overflow when converting integer to cons and back.
5988 * charset.c (Fdefine_charset_internal, Fdecode_char):
5989 Use cons_to_unsigned to catch overflow.
5990 (Fencode_char): Use INTEGER_TO_CONS.
5991 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5992 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5993 * data.c (long_to_cons, cons_to_long): Remove.
5994 (cons_to_unsigned, cons_to_signed): New functions.
5995 These signal an error for invalid or out-of-range values.
5996 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5997 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5998 * font.c (Ffont_variation_glyphs):
5999 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6000 * lisp.h: Include <intprops.h>.
6001 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6002 (cons_to_signed, cons_to_unsigned): New decls.
6003 (long_to_cons, cons_to_long): Remove decls.
6004 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6005 (Fprimitive_undo): Use CONS_TO_INTEGER.
6006 * xfns.c (Fx_window_property): Likewise.
6007 * xselect.c: Include <limits.h>.
6008 (x_own_selection, selection_data_to_lisp_data):
6009 Use INTEGER_TO_CONS.
6010 (x_handle_selection_request, x_handle_selection_clear)
6011 (x_get_foreign_selection, Fx_disown_selection_internal)
6012 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6013 (lisp_data_to_selection_data): Use cons_to_unsigned.
6014 (x_fill_property_data): Use cons_to_signed.
6015 Report values out of range.
6017 Check for buffer and string overflow more precisely.
6018 * buffer.h (BUF_BYTES_MAX): New macro.
6019 * lisp.h (STRING_BYTES_MAX): New macro.
6020 * alloc.c (Fmake_string):
6021 * character.c (string_escape_byte8):
6022 * coding.c (coding_alloc_by_realloc):
6023 * doprnt.c (doprnt):
6024 * editfns.c (Fformat):
6026 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6027 since they may not be the same number.
6028 * editfns.c (Finsert_char):
6029 * fileio.c (Finsert_file_contents):
6030 Likewise for BUF_BYTES_MAX.
6032 * image.c: Use ptrdiff_t, not int, for sizes.
6033 (slurp_file): Switch from int to ptrdiff_t.
6035 (slurp_file): Check that file size fits in both size_t (for
6036 malloc) and ptrdiff_t (for sanity and safety).
6038 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6039 if b->modtime has its maximal value.
6041 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6043 Don't assume time_t can fit into int.
6044 * buffer.h (struct buffer.modtime): Now time_t, not int.
6045 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6046 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6048 Minor fixes for signed vs unsigned integers.
6049 * character.h (MAYBE_UNIFY_CHAR):
6050 * charset.c (maybe_unify_char):
6051 * keyboard.c (read_char, reorder_modifiers):
6052 XINT -> XFASTINT, since the integer must be nonnegative.
6053 * ftfont.c (ftfont_spec_pattern):
6054 * keymap.c (access_keymap, silly_event_symbol_error):
6055 XUINT -> XFASTINT, since the integer must be nonnegative.
6056 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6057 since it makes no difference and we prefer signed.
6058 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6059 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6062 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6064 * window.h (Fwindow_frame): Declare.
6066 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6068 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6069 (SPARE_MEMORY): Always define.
6070 (LARGE_REQUEST): Remove.
6071 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6073 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6075 * lisp.h: Move EXFUNS for Fframe_root_window,
6076 Fframe_first_window and Fset_frame_selected_window to window.h.
6078 * window.h: Move EXFUNS for Fframe_root_window,
6079 Fframe_first_window and Fset_frame_selected_window here from
6082 * frame.c (Fwindow_frame, Fframe_first_window)
6083 (Fframe_root_window, Fframe_selected_window)
6084 (Fset_frame_selected_window): Move to window.c.
6085 (Factive_minibuffer_window): Move to minibuf.c.
6086 (Fother_visible_frames_p): New function.
6088 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6090 * window.c (decode_window, decode_any_window): Move up in code.
6091 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6092 (inhibit_frame_unsplittable): Remove unused variable.
6093 (Fwindow_buffer): Move up and rewrite doc-string.
6094 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6095 (Fwindow_prev): New functions.
6096 (Fwindow_frame): Move here from frame.c. Accept any window as
6098 (Fframe_root_window, Fframe_first_window)
6099 (Fframe_selected_window): Move here from frame.c. Accept frame
6100 or arbitrary window as argument. Update doc-strings.
6101 (Fminibuffer_window): Move up in code.
6102 (Fwindow_minibuffer_p): Move up in code and simplify.
6103 (Fset_frame_selected_window): Move here from frame.c.
6105 (Fselected_window, select_window, Fselect_window): Move up in
6106 code. Minor doc-string fixes.
6108 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6110 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6111 Do not assume that spare memory exists; that assumption is valid
6112 only if SYSTEM_MALLOC.
6113 (LARGE_REQUEST): New macro, so that the issue of large requests
6114 is separated from the issue of spare memory.
6116 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6118 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6121 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6123 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6126 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6128 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6130 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6132 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6133 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6135 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6137 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6139 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6141 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6142 (x_clipboard_manager_save): Add return value.
6143 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6145 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6146 Obey Vx_select_enable_clipboard_manager. Catch errors in
6147 x_clipboard_manager_save (Bug#8779).
6148 (Vx_select_enable_clipboard_manager): New variable.
6149 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6151 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6153 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6155 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6157 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6158 in the current matrix if keep_current_p is non-zero.
6160 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6162 * bidi.c (bidi_level_of_next_char): Fix last change.
6164 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6166 Support bidi reordering of text covered by display properties.
6168 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6169 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6170 (bidi_cache_search, bidi_cache_iterator_state)
6171 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6172 (bidi_level_of_next_char, bidi_move_to_visually_next):
6173 Support character positions inside a run of characters covered by a
6175 (bidi_paragraph_init, bidi_resolve_explicit_1)
6176 (bidi_level_of_next_char): Call bidi_fetch_char and
6177 bidi_fetch_char_advance instead of FETCH_CHAR and
6179 (bidi_init_it): Initialize new members.
6180 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6182 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6183 instead of using explicit *_CHAR codes.
6184 (bidi_resolve_explicit, bidi_resolve_weak):
6185 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6186 bidirectional text is supported only in multibyte buffers.
6187 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6188 it to initialize the frame_window_p member of struct bidi_it.
6189 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6190 (bidi_resolve_explicit, bidi_resolve_weak)
6191 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6192 bidi_it->nchars is non-positive.
6193 (bidi_level_of_next_char): Don't try to lookup the cache for the
6194 next/previous character if nothing is cached there yet, or if we
6195 were just reseat()'ed to a new position.
6197 * xdisp.c (set_cursor_from_row): Set start and stop points
6198 according to the row's direction when priming the loop that looks
6199 for the glyph on which to display cursor.
6200 (single_display_spec_intangible_p): Function deleted.
6201 (display_prop_intangible_p): Reimplement to call
6202 handle_display_spec instead of single_display_spec_intangible_p.
6203 Accept 3 additional arguments needed by handle_display_spec.
6204 This fixes incorrect cursor motion across display property with complex
6205 values: lists, `(when COND...)' forms, etc.
6206 (single_display_spec_string_p): Support property values that are
6207 lists with the argument STRING its top-level element.
6208 (display_prop_string_p): Fix the condition for processing a
6209 property that is a list to be consistent with handle_display_spec.
6210 (handle_display_spec): New function, refactored from the
6211 last portion of handle_display_prop.
6212 (compute_display_string_pos): Accept additional argument
6213 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6214 value of a `display' property is a "replacing spec".
6215 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6216 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6217 the display property, but just return a value indicating whether
6218 the display property will replace the characters it covers.
6219 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6220 frame_window_p members of struct bidi_it.
6221 (compute_display_string_pos, compute_display_string_end):
6223 (push_it): Accept second argument POSITION, where pop_it should
6224 jump to continue iteration.
6225 (reseat_1): Initialize bidi_it.disp_pos.
6227 * keyboard.c (adjust_point_for_property): Adjust the call to
6228 display_prop_intangible_p to its new signature.
6230 * dispextern.h (struct bidi_it): New member frame_window_p.
6231 (bidi_init_it): Update prototypes.
6232 (display_prop_intangible_p): Update prototype.
6233 (compute_display_string_pos, compute_display_string_end):
6235 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6238 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6240 Malloc failure behavior now depends on size of allocation.
6241 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6242 * lisp.h: Change signatures accordingly.
6243 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6244 All callers changed. (Bug#8762)
6246 * gnutls.c: Use Emacs's memory allocators.
6247 Without this change, the gnutls library would invoke malloc etc.
6248 directly, which causes problems on non-SYNC_INPUT hosts, and which
6249 runs afoul of improving memory_full behavior. (Bug#8761)
6250 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6251 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6252 xfree instead of the default malloc, realloc, free.
6253 (Fgnutls_boot): No need to check for memory allocation failure,
6254 since xmalloc does that for us.
6256 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6257 * category.c (hash_get_category_set):
6258 * ccl.c (ccl_driver):
6259 * charset.c (Fdefine_charset_internal):
6260 * charset.h (struct charset.hash_index):
6261 * composite.c (get_composition_id, gstring_lookup_cache)
6262 (composition_gstring_put_cache):
6263 * composite.h (struct composition.hash_index):
6264 * dispextern.h (struct image.hash):
6265 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6266 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6267 (hashfn_equal, hashfn_user_defined, make_hash_table)
6268 (maybe_resize_hash_table, hash_lookup, hash_put)
6269 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6270 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6271 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6272 * image.c (make_image, search_image_cache, lookup_image)
6273 (xpm_put_color_table_h):
6274 * lisp.h (struct Lisp_Hash_Table):
6275 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6276 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6277 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6278 * alloc.c (allocate_vectorlike):
6279 Check for overflow in vector size calculations.
6280 * ccl.c (ccl_driver):
6281 Check for overflow when converting EMACS_INT to int.
6282 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6283 need to be updated by these changes.
6284 * fns.c (make_hash_table, maybe_resize_hash_table):
6285 Check for integer overflow with large hash tables.
6286 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6287 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6288 (SXHASH_REDUCE): New macro.
6289 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6290 Use it instead of discarding useful hash info with large hash values.
6291 (sxhash_float): New function.
6292 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6293 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6294 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6295 Rewrite to use FIXNUM_BITS, as this simplifies things.
6296 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6297 Adjust signatures to match updated version of code.
6298 (consing_since_gc): Now EMACS_INT, since a single hash table can
6299 use more than INT_MAX bytes.
6301 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6303 Make it possible to build with GCC-4.6+ -O2 -flto.
6305 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6307 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6309 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6310 Call minibuffer-inactive-mode.
6312 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6314 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6315 Update dependencies.
6317 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6319 * data.c (init_data): Remove code for UTS, this system is not
6322 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6324 Don't force ./temacs to start in terminal mode.
6326 * frame.c (make_initial_frame): Initialize faces in all cases, not
6327 only when CANNOT_DUMP is defined.
6328 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6330 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6332 * dispnew.c (add_window_display_history): Use const for the string
6333 pointer. Remove declaration, not needed.
6335 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6337 Use 'inline', not 'INLINE'.
6338 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6339 * alloc.c, fontset.c (INLINE): Remove.
6340 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6341 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6342 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6343 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6344 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6346 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6348 Make it possible to run ./temacs.
6350 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6351 syms_of_callproc does the same thing. Remove test for
6352 "initialized", do it in the caller.
6353 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6355 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6357 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6358 (read_minibuf): Use get_minibuffer.
6359 (syms_of_minibuf): Use DEFSYM.
6360 (Qmetadata): New var.
6361 * data.c (Qbuffer): Don't make it static.
6362 (syms_of_data): Use DEFSYM.
6364 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6366 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6367 (CCL_CODE_MIN): New macro.
6369 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6371 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6373 * eval.c (Qdebug): Now static.
6374 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6375 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6376 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6378 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6380 * image.c: Various fixes to ImageMagick code comments.
6381 (Fimagemagick_types): Doc fix.
6383 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6385 Minor fixes prompted by GCC 4.6.0 warnings.
6387 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6389 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6390 (x_clipboard_manager_save_all): Move extern decl to ...
6391 * xterm.h: ... here, so that it can be checked for consistency.
6393 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6395 * xselect.c (x_clipboard_manager_save_frame)
6396 (x_clipboard_manager_save_all): New functions.
6397 (Fx_clipboard_manager_save): Lisp function deleted.
6399 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6400 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6402 * xterm.h: Update prototype.
6404 2011-05-28 William Xu <william.xwl@gmail.com>
6406 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6409 2011-05-28 Jim Meyering <meyering@redhat.com>
6411 Avoid a sign-extension bug in crypto_hash_function.
6412 * fns.c (to_uchar): Define.
6413 (crypto_hash_function): Use it to convert some newly-signed
6414 variables to unsigned, to avoid sign-extension bugs. For example,
6415 without this change, (md5 "truc") would evaluate to
6416 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6417 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6418 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6420 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6422 Integer overflow fixes.
6424 * dbusbind.c: Serial number integer overflow fixes.
6425 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6426 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6427 to hold a serial number that is too large for a fixnum.
6428 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6429 Check for serial numbers out of range. Decode any serial number
6430 that was so large that it became a float. (Bug#8722)
6432 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6433 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6434 Use XFASTINT rather than XUINT when numbers are nonnegative.
6435 (xd_append_arg, Fdbus_method_return_internal):
6436 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6437 arguments, check that Lisp number is nonnegative, rather than
6438 silently wrapping negative numbers around. (Bug#8722)
6439 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6442 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6444 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6446 ccl: Add integer overflow checks.
6447 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6448 (IN_INT_RANGE): New macros.
6449 (ccl_driver): Use them to check for integer overflow when
6450 decoding a CCL program. Many of the new checks are whether XINT (x)
6451 fits in int; it doesn't always, on 64-bit hosts. The new version
6452 doesn't catch all possible integer overflows, but it's an
6453 improvement. (Bug#8719)
6455 * alloc.c (make_event_array): Use XINT, not XUINT.
6456 There's no need for unsigned here.
6458 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6459 This follows up to the 2011-05-06 change that substituted uintptr_t
6460 for EMACS_INT. This case wasn't caught back then.
6462 Rework Fformat to avoid integer overflow issues.
6463 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6464 now (part of C89). Include <verify.h>.
6465 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6466 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6467 (Fformat): Avoid the prepass trying to compute sizes; it was only
6468 approximate and thus did not catch overflow reliably. Instead, walk
6469 through the format just once, formatting and computing sizes as we go,
6470 checking for integer overflow at every step, and allocating a larger
6471 buffer as needed. Keep track separately whether the format is
6472 multibyte. Keep only the most-recently calculated precision, rather
6473 than them all. Record whether each argument has been converted to
6474 string. Use EMACS_INT, not int, for byte and char and arg counts.
6475 Support field widths and precisions larger than INT_MAX. Avoid
6476 sprintf's undefined behavior with conversion specifications such as %#d
6477 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6478 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6479 formatting out-of-range floating point numbers with int
6482 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6484 * data.c: Avoid integer truncation in expressions involving floats.
6485 * data.c: Include <intprops.h>.
6486 (arith_driver): When there's an integer overflow in an expression
6487 involving floating point, convert the integers to floating point
6488 so that the resulting value does not suffer from catastrophic
6489 integer truncation. For example, on a 64-bit host (* 4
6490 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6491 Do not rely on undefined behavior after integer overflow.
6493 merge count_size_as_multibyte, parse_str_to_multibyte
6494 * character.c, character.h (count_size_as_multibyte):
6495 Rename from parse_str_to_multibyte; all uses changed.
6496 Check for integer overflow.
6497 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6498 since it's now a duplicate of the other. This is more of
6499 a character than a buffer op, so better that it's in character.c.
6500 * fns.c, print.c: Adjust to above changes.
6502 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6504 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6506 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6508 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6509 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6510 (x_clipboard_manager_save): Now static.
6511 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6513 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6514 (crypto_hash_function): Now static.
6515 Fix pointer signedness problems. Avoid unnecessary initializations.
6517 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6519 * termhooks.h (Vselection_alist): Make it terminal-local.
6521 * terminal.c (create_terminal): Initialize it.
6523 * xselect.c: Support for clipboard managers.
6524 (Vselection_alist): Move to termhooks.h as terminal-local var.
6525 (LOCAL_SELECTION): New macro.
6526 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6527 (symbol_to_x_atom): Remove gratuitous arg.
6528 (x_handle_selection_request, lisp_data_to_selection_data)
6529 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6530 (x_own_selection, x_get_local_selection, x_convert_selection):
6531 New arg, specifying work frame. Use terminal-local Vselection_alist.
6532 (some_frame_on_display): Delete unused function.
6533 (Fx_own_selection_internal, Fx_get_selection_internal)
6534 (Fx_disown_selection_internal, Fx_selection_owner_p)
6535 (Fx_selection_exists_p): New optional frame arg.
6536 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6537 (x_handle_selection_clear): Don't treat other terminals with the
6538 same keyboard specially. Use the terminal-local Vselection_alist.
6539 (x_clear_frame_selections): Use Frun_hook_with_args.
6541 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6543 * xterm.h: Add support for those atoms.
6545 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6547 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6548 (converted_selections, conversion_fail_tag): New global variables.
6549 (x_selection_request_lisp_error): Free the above.
6550 (x_get_local_selection): Remove unnecessary code.
6551 (x_reply_selection_request): Args changed; handle arbitrary array
6552 of converted selections stored in converted_selections.
6553 Separate the XChangeProperty and SelectionNotify steps.
6554 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6555 (x_convert_selection): New function.
6556 (x_handle_selection_event): Simplify.
6557 (x_get_foreign_selection): Don't ignore incoming requests while
6558 waiting for an answer; this will fail when we implement
6559 SAVE_TARGETS, and seems unnecessary anyway.
6560 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6561 (Vx_sent_selection_functions): Doc fix.
6563 2011-05-26 Leo Liu <sdl.web@gmail.com>
6565 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6567 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6569 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6571 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6572 for fringe update if it has periodic bitmap.
6573 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6574 and fringe_bitmap_periodic_p.
6576 * fringe.c (get_fringe_bitmap_data): New function.
6577 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6578 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6579 row. Mark glyph row for fringe update if periodicity changed.
6581 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6582 for fringe update unless it has periodic bitmap.
6584 2011-05-25 Kenichi Handa <handa@m17n.org>
6586 * xdisp.c (get_next_display_element): Set correct it->face_id for
6587 a static composition.
6589 2011-05-24 Leo Liu <sdl.web@gmail.com>
6592 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6594 * fns.c (crypto_hash_function, Fsha1): New function.
6595 (Fmd5): Use crypto_hash_function.
6596 (syms_of_fns): Add Ssha1.
6598 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6600 * gnutls.c: Remove unused macros.
6601 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6602 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6603 Remove macros that are defined and never used.
6604 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6606 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6608 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6609 (Fx_get_selection_internal): Minor cleanup.
6610 (Fx_own_selection_internal): Rename arguments for consistency with
6613 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6615 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6617 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6619 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6621 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6623 * dispnew.c (scrolling_window): Don't exclude the case that the
6624 last enabled row in the desired matrix touches the bottom boundary.
6626 2011-05-21 Glenn Morris <rgm@gnu.org>
6628 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6629 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6630 and add some more files.
6632 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6634 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6635 report_file_error introduced by the change from 2011-05-07.
6637 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6639 * systime.h (Time): Define only if emacs is defined.
6640 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6641 where the include path doesn't have X11/X.h by default. See
6642 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6644 2011-05-20 Kenichi Handa <handa@m17n.org>
6646 * composite.c (find_automatic_composition): Fix previous change.
6648 2011-05-20 Glenn Morris <rgm@gnu.org>
6650 * lisp.mk: New file, split from Makefile.in.
6651 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6652 (shortlisp): Remove.
6653 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6655 2011-05-19 Glenn Morris <rgm@gnu.org>
6657 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6658 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6659 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6660 (lisp): Set the order to that of loadup.el.
6661 (shortlisp): Make it a copy of $lisp.
6662 (SOME_MACHINE_LISP): Remove.
6663 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6664 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6666 2011-05-18 Kenichi Handa <handa@m17n.org>
6668 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6669 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6670 (find_automatic_composition): Mostly rewrite for efficiency.
6672 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6674 * makefile.w32-in: Update dependencies.
6676 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6678 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6679 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6681 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6683 Fix some integer overflow issues, such as string length overflow.
6685 * insdel.c (count_size_as_multibyte): Check for string overflow.
6687 * character.c (lisp_string_width): Check for string overflow.
6688 Use EMACS_INT, not int, for string indexes and lengths; in
6689 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6690 the resulting string length overflows an EMACS_INT; instead,
6691 report a string overflow if no precision given. When checking for
6692 precision exhaustion, use a check that cannot possibly have
6693 integer overflow. (Bug#8675)
6694 * character.h (lisp_string_width): Adjust to new signature.
6696 * alloc.c (string_overflow): New function.
6697 (Fmake_string): Use it. This doesn't change behavior, but saves
6698 a few bytes and will simplify future changes.
6699 * character.c (string_escape_byte8): Likewise.
6700 * lisp.h (string_overflow): New decl.
6702 Fixups, following up to the user-interface timestamp change.
6703 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6704 for UI timestamps, instead of unsigned long.
6705 * msdos.c (mouse_get_pos): Likewise.
6706 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6707 * w32gui.h (Time): Define by including "systime.h" rather than by
6708 declaring it ourselves. (Bug#8664)
6710 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6711 * image.c (clear_image_cache): Likewise.
6713 * term.c (term_mouse_position): Don't assume time_t wraparound.
6715 Be more systematic about user-interface timestamps.
6716 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6717 and sometimes 'EMACS_UINT', to represent these timestamps.
6718 This change causes it to use 'Time' uniformly, as that's what X uses.
6719 This makes the code easier to follow, and makes it easier to catch
6720 integer overflow bugs such as Bug#8664.
6721 * frame.c (Fmouse_position, Fmouse_pixel_position):
6722 Use Time, not unsigned long, for user-interface timestamps.
6723 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6724 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6725 * keyboard.h (last_event_timestamp): Likewise.
6726 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6727 * menu.h (xmenu_show): Likewise.
6728 * term.c (term_mouse_position): Likewise.
6729 * termhooks.h (struct input_event.timestamp): Likewise.
6730 (struct terminal.mouse_position_hook): Likewise.
6731 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6732 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6733 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6734 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6736 * menu.h, termhooks.h: Include "systime.h", for Time.
6738 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6739 Don't assume that the difference between two unsigned long values
6740 can fit into an integer. At this point, we know button_down_time
6741 <= event->timestamp, so the difference must be nonnegative, so
6742 there's no need to cast the result if double-click-time is
6743 nonnegative, as it should be; check that it's nonnegative, just in
6744 case. This bug is triggered when events are more than 2**31 ms
6745 apart (about 25 days). (Bug#8664)
6747 * xselect.c (last_event_timestamp): Remove duplicate decl.
6748 (x_own_selection): Remove needless cast to unsigned long.
6750 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6751 that always fit in int. Use a sentinel instead of a counter, to
6752 avoid a temp and to allay GCC's concerns about possible int overflow.
6753 * frame.h (struct frame): Use int for menu_bar_items_used
6754 instead of EMACS_INT, since it always fits in int.
6756 * menu.c (grow_menu_items): Check for int overflow.
6758 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6760 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6761 Before, the code was not consistent. These values cannot exceed
6762 2**31 - 1 so there's no need to make them unsigned.
6763 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6764 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6765 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6767 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6769 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6770 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6771 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6772 presumably because the widths might not match.
6774 * window.c (size_window): Avoid needless test at loop start.
6776 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6778 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6780 2011-05-12 Drew Adams <drew.adams@oracle.com>
6782 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6784 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6786 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6787 `width' to `bar_area_x' and `bar_area_width', respectively.
6788 (x_scroll_run): Take account of fringe background extension.
6790 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6791 Rename local vars `left' and `width' to `bar_area_x' and
6792 `bar_area_width', respectively.
6793 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6794 background extension.
6796 2011-05-10 Jim Meyering <meyering@redhat.com>
6798 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6800 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6802 * image.c (Finit_image_library): Return t for built-in image types,
6803 like pbm and xbm. (Bug#8640)
6805 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6807 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6809 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6811 * w32console.c (Fset_screen_color): Doc fix.
6812 (Fget_screen_color): New function.
6813 (syms_of_ntterm): Defsubr it.
6815 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6816 unlink the temporary file if Fcall_process didn't create it in the
6818 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6819 child process will be redirected to a file specified with `:file'.
6820 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6821 cue to call_process_cleanup not to close that handle.
6823 2011-05-07 Ben Key <bkey76@gmail.com>
6825 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6826 one of two shell specific rules, either bootstrap-temacs-CMD or
6827 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6828 to the previous implementation of the bootstrap-temacs rule.
6829 The bootstrap-temacs-CMD rule is similar to the previous
6830 implementation of the bootstrap-temacs rule except that it
6831 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6834 These changes, along with some changes to nt/configure.bat,
6835 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6836 earlier fix to add support for --cflags and --ldflags options
6837 that include quotes so that it works whether make uses cmd or
6840 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6842 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6843 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6845 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6846 a string. Handle both cases.
6847 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6848 (Fdbus_register_method): Use Qinvalid_function.
6850 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6852 * makefile.w32-in: Update dependencies.
6853 (LISP_H): Add inttypes.h and stdin.h.
6854 (PROCESS_H): Add unistd.h.
6856 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6858 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6859 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6861 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6863 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6865 * term.c (vfatal): Remove stray call to va_end.
6866 It's not needed and the C Standard doesn't allow it here anyway.
6868 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6869 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6871 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6874 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6876 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6878 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6880 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6882 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6884 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6885 * charset.c (Fdefine_charset_internal): Don't initialize
6886 charset.code_space[15]. The value was garbage, on hosts with
6887 32-bit int (Bug#8600).
6889 * lread.c (read_integer): Be more consistent with string-to-number.
6890 Use string_to_number to do the actual conversion; this avoids
6891 rounding errors and fixes some other screwups. Without this fix,
6892 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6893 (digit_to_number): Move earlier, for benefit of read_integer.
6894 Return -1 if the digit is out of range for the base, -2 if it is
6895 not a digit in any supported base. (Bug#8602)
6897 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6899 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6900 to match comment at start of function. This also removes a
6901 GCC warning about overflow in a 32+64-bit port.
6903 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6905 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6906 Reported by Stefan Monnier in
6907 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6908 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6909 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6911 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6912 (EMACS_UINTPTR): Likewise, with uintptr_t.
6914 * lisp.h: Prefer 64-bit EMACS_INT if available.
6915 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6916 on 32-bit hosts that have 64-bit int, so that they can access
6918 However, temporarily disable this change unless the temporary
6919 symbol WIDE_EMACS_INT is defined.
6921 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6923 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6924 This removes an assumption that EMACS_INT and long are the same
6925 width as pointers. The assumption is true for Emacs porting targets
6926 now, but we want to make other targets possible.
6927 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6928 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6929 In the rest of the code, change types of integers that hold casted
6930 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6931 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6932 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6933 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6934 No need to cast type when ORing.
6935 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6936 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6937 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6938 assume EMACS_INT is the same width as char *.
6939 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6940 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6941 Remove no-longer-needed casts.
6942 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6943 (xg_tool_bar_help_callback, xg_make_tool_item):
6944 Use EMACS_INTPTR to hold an integer
6945 that will be cast to void *; this can avoid a GCC warning
6946 if EMACS_INT is not the same width as void *.
6947 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6948 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6949 (current_message_1, set_message_1):
6950 Use a local to convert to proper width without a cast.
6951 * xmenu.c (dialog_selection_callback): Likewise.
6953 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6954 Also, don't assume VALBITS / RAND_BITS is less than 5,
6955 and don't rely on undefined behavior when shifting a 1 left into
6957 * lisp.h (get_random): Change signature to match.
6959 * lread.c (hash_string): Use size_t, not int, for hash computation.
6960 Normally we prefer signed values; but hashing is special, because
6961 it's better to use unsigned division on hash table sizes so that
6962 the remainder is nonnegative. Also, size_t is the natural width
6963 for hashing into memory. The previous code used 'int', which doesn't
6964 retain enough info to hash well into very large tables.
6965 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6967 * dbusbind.c: Don't possibly lose pointer info when converting.
6968 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6969 Use XPNTR rather than XHASH, so that the high-order bits of
6970 the pointer aren't lost when converting through void *.
6972 * eval.c (Fautoload): Don't double-shift a pointer.
6974 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6976 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6978 * gnutls.c (DEF_GNUTLS_FN):
6979 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6981 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6983 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6986 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6988 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6989 New version that can reserve upto 2GB of heap space.
6991 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6993 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6995 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6997 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6998 `gnutls_certificate_set_x509_key_file'.
7000 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7002 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7003 Update dependencies.
7005 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7007 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7008 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7009 Remove unused parameter `fildes'.
7010 * process.c (read_process_output, send_process): Don't pass it.
7012 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7014 Fix previous change: the library cache is defined in w32.c.
7015 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7016 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7018 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7020 Implement dynamic loading of GnuTLS on Windows.
7022 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7023 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7024 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7027 * gnutls.c (Qgnutls_dll): Define.
7028 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7029 (gnutls_*): Declare function pointers.
7030 (init_gnutls_functions): New function to initialize function pointers.
7031 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7032 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7033 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7034 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7035 (emacs_gnutls_write, emacs_gnutls_read)
7036 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7037 (Fgnutls_available_p): New function.
7038 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7039 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7040 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7042 * image.c: Include w32.h.
7043 (Vimage_type_cache): Delete.
7044 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7045 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7046 (w32_delayed_load): Move to w32.c.
7048 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7050 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7051 (w32_delayed_load): Move from image.c. When loading a library, record
7052 its filename in the :loaded-from property of the library id.
7053 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7054 Initialize and staticpro them.
7055 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7057 * process.c: Include lisp.h before w32.h, not after.
7058 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7059 instead of gnutls_record_check_pending.
7061 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7063 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7065 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7066 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7069 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7071 * xterm.c (x_set_frame_alpha): Do not set property on anything
7072 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7074 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7076 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7078 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7080 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7081 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7082 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7083 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7084 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7085 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7086 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7087 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7088 (Qgnutls_bootprop_callbacks_verify): Make static.
7090 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7092 * callproc.c: Indentation fixup.
7094 * sysdep.c (wait_for_termination_1): Make static.
7095 (wait_for_termination, interruptible_wait_for_termination):
7096 Move after wait_for_termination_1.
7098 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7100 * sysdep.c (interruptible_wait_for_termination): New function
7101 which is like wait_for_termination, but allows keyboard
7104 * callproc.c (Fcall_process): Add (:file "file") as an option for
7106 (Fcall_process_region): Ditto.
7108 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7110 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7111 rather than `XVECTOR (FOO)->size'.
7113 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7114 inttypes.h, as a gnulib replacement is used if it not available in
7117 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7119 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7120 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7121 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7123 * coding.c (coding_alloc_by_realloc): Error out if destination
7124 will grow beyond MOST_POSITIVE_FIXNUM.
7125 (decode_coding_emacs_mule): Abort if there isn't enough place in
7126 charbuf for the composition carryover bytes. Reserve an extra
7127 space for up to 2 characters produced in a loop.
7128 (decode_coding_iso_2022): Abort if there isn't enough place in
7129 charbuf for the composition carryover bytes.
7131 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7133 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7134 aborting when %lld or %lll format is passed.
7135 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7136 %llo or %llx format is passed. (Bug#8545)
7138 * window.c (window_scroll_line_based): Use a marker instead of
7139 simple variables to record original value of point. (Bug#7952)
7141 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7142 produced by %s or %c overflows available buffer space. (Bug#8545)
7144 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7146 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7147 (SIZE_MAX): Move defn after all includes, as they might #define it.
7149 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7151 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7153 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7155 * keyboard.c (Qdelayed_warnings_hook): Define.
7156 (command_loop_1): Run `delayed-warnings-hook'
7157 if Vdelayed_warnings_list is non-nil.
7158 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7159 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7161 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7163 * doprnt.c (doprnt): Don't return value smaller than the buffer
7164 size if the message was truncated. (Bug#8545).
7166 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7168 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7169 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7171 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7173 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7175 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7177 * makefile.w32-in: Update dependencies.
7179 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7181 Improve `doprnt' and its usage. (Bug#8545)
7182 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7183 `format_end'. Remove support for %l as a conversion specifier.
7184 Don't use xrealloc. Improve diagnostics when the %l size modifier
7185 is used. Update the commentary.
7187 * eval.c (verror): Simplify calculation of size_t.
7189 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7192 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7194 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7197 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7199 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7200 This makes this file independent of the recent pseudovector change.
7202 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7204 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7206 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7207 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7208 Remove unused local.
7209 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7211 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7212 GCC 4.6.0 optimizes based on type-based alias analysis.
7213 For example, if b is of type struct buffer * and v of type struct
7214 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7215 != &v->size, and therefore "v->size = 1; b->size = 2; return
7216 v->size;" must therefore return 1. This assumption is incorrect
7217 for Emacs, since it type-puns struct Lisp_Vector * with many other
7218 types. To fix this problem, this patch adds a new type struct
7219 vectorlike_header that documents the constraints on layout of vectors
7220 and pseudovectors, and helps optimizing compilers not get fooled
7221 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7222 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7223 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7225 (XSETPVECTYPE): Rewrite in terms of new macro.
7226 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7227 This is a bit clearer, and further avoids the possibility of
7228 undesirable aliasing.
7229 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7230 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7231 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7232 since Lisp_Subr is a special case (no "next" field).
7233 (ASIZE): Now uses header.size rather than size.
7234 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7235 to avoid the hassle of writing XVECTOR (foo)->header.size.
7236 (struct vectorlike_header): New type.
7237 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7238 object, to help avoid aliasing.
7239 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7240 (SUBRP): Likewise, since Lisp_Subr is a special case.
7241 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7242 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7243 (struct Lisp_Hash_Table): Combine first two members into a single
7244 struct vectorlike_header member. All uses of "size" and "next" members
7245 changed to be "header.size" and "header.next".
7246 * buffer.h (struct buffer): Likewise.
7247 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7248 * frame.h (struct frame): Likewise.
7249 * process.h (struct Lisp_Process): Likewise.
7250 * termhooks.h (struct terminal): Likewise.
7251 * window.c (struct save_window_data, struct saved_window): Likewise.
7252 * window.h (struct window): Likewise.
7253 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7254 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7255 * buffer.c (init_buffer_once): Likewise.
7256 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7258 * process.c (Fformat_network_address): Use local var for size,
7261 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7263 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7264 * data.c (atof): Remove decl; no longer used or needed.
7265 (digit_to_number): Move to lread.c.
7266 (Fstring_to_number): Use new string_to_number function, to be
7267 consistent with how the Lisp reader treats infinities and NaNs.
7268 Do not assume that floating-point numbers represent EMACS_INT
7269 without losing information; this is not true on most 64-bit hosts.
7270 Avoid double-rounding errors, by insisting on integers when
7271 parsing non-base-10 numbers, as the documentation specifies.
7272 * lisp.h (string_to_number): New decl, replacing ...
7273 (isfloat_string): Remove.
7274 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7275 (read1): Do not accept +. and -. as integers; this
7276 appears to have been a coding error. Similarly, do not accept
7277 strings like +-1e0 as floating point numbers. Do not report
7278 overflow for integer overflows unless the base is not 10 which
7279 means we have no simple and reliable way to continue.
7280 Break out the floating-point parsing into a new
7281 function string_to_number, so that Fstring_to_number parses
7282 floating point numbers consistently with the Lisp reader.
7283 (digit_to_number): Move here from data.c. Make it static inline.
7284 (E_CHAR, EXP_INT): Remove, replacing with ...
7285 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7286 (string_to_number): New function, replacing isfloat_string.
7287 This function checks for valid syntax and produces the resulting
7288 Lisp float number too. Rework it so that string-to-number
7289 no longer mishandles examples like "1.0e+". Use strtoumax,
7290 so that overflow for non-base-10 numbers is reported only when
7291 there's no portable and simple way to convert to floating point.
7293 * textprop.c (set_text_properties_1): Rewrite for clarity,
7294 and to avoid GCC warning about integer overflow.
7296 * intervals.h (struct interval): Use EMACS_INT for members
7297 where EMACS_UINT might cause problems. See
7298 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7299 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7300 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7302 (offset_intervals): Tell GCC not to worry about length overflow
7303 when negating a negative length.
7305 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7306 (overrun_check_free): Likewise.
7308 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7309 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7312 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7313 (gnutls_make_error): Rename local to avoid shadowing.
7314 (gnutls_emacs_global_deinit): ifdef out; not used.
7315 (Fgnutls_boot): Use const for pointer to readonly storage.
7316 Comment out unused local. Fix pointer signedness problems.
7318 * lread.c (openp): Don't stuff size_t into an 'int'.
7319 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7320 about possible signed overflow.
7322 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7323 (GDK_KEY_g): Don't define if already defined.
7324 (xg_prepare_tooltip): Avoid pointer signedness problem.
7325 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7327 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7328 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7330 * xfns.c (Fx_window_property): Simplify a bit,
7331 to make a bit faster and to avoid GCC 4.6.0 warning.
7332 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7334 * fns.c (internal_equal): Don't assume size_t fits in int.
7336 * alloc.c (compact_small_strings): Tighten assertion a little.
7338 Replace pEd with more-general pI, and fix some printf arg casts.
7339 * lisp.h (pI): New macro, generalizing old pEd macro to other
7340 conversion specifiers. For example, use "...%"pI"d..." rather
7341 than "...%"pEd"...".
7342 (pEd): Remove. All uses replaced with similar uses of pI.
7343 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7344 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7345 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7346 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7347 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7348 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7349 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7351 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7352 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7353 * print.c (safe_debug_print, print_object): Likewise.
7354 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7356 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7357 avoiding the 0 flag, which is not portable.
7358 * process.c (Fmake_network_process): Use pI to avoid cast.
7359 * region-cache.c (pp_cache): Likewise.
7360 * xdisp.c (decode_mode_spec): Likewise.
7361 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7362 behavior on 64-bit hosts with printf arg.
7363 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7364 (x_stop_queuing_selection_requests): Likewise.
7365 (x_get_window_property): Don't truncate byte count to an 'int'
7368 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7369 here, since it parses constructs like leading '-' and spaces,
7370 which are not wanted; and it overflows with large numbers.
7371 Instead, simply match F[0-9]+, which is what is wanted anyway.
7373 * alloc.c: Remove unportable assumptions about struct layout.
7374 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7375 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7376 (allocate_vectorlike, make_pure_vector): Use the new macros,
7377 plus offsetof, to remove unportable assumptions about struct layout.
7378 These assumptions hold on all porting targets that I know of, but
7379 they are not guaranteed, they're easy to remove, and removing them
7380 makes further changes easier.
7382 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7383 This doesn't fix a bug but makes the code clearer.
7384 (string_overrun_cookie): Now const. Use initializers that
7385 don't formally overflow signed char, to avoid warnings.
7386 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7387 can cause Emacs to crash when string overrun checking is enabled.
7388 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7389 multiple of sizeof (EMACS_INT); it need not be, if
7390 alignof(EMACS_INT) < sizeof (EMACS_INT).
7391 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7393 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7395 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7397 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7399 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7400 supposed to be handshaking. (Bug#8556)
7401 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7403 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7405 * lisp.h (Qdebug): List symbol.
7406 * eval.c (Qdebug): Restore global linkage.
7407 * keyboard.c (debug-on-event): New variable.
7408 (handle_user_signal): Break into debugger when debug-on-event
7409 matches the current signal symbol.
7411 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7413 * alloc.c (check_sblock, check_string_bytes)
7414 (check_string_free_list): Convert to standard C.
7416 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7418 * w32.c (emacs_gnutls_push): Fix typo.
7420 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7422 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7423 "cast to pointer from integer of different size".
7425 Improve doprnt and its use in verror. (Bug#8545)
7426 * doprnt.c (doprnt): Document the set of format control sequences
7427 supported by the function. Use SAFE_ALLOCA instead of always
7430 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7431 is one byte too soon. Don't use xrealloc; instead xfree and
7434 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7436 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7439 * gnutls.c: Renamed global_initialized to
7440 gnutls_global_initialized. Added internals for the
7441 :verify-hostname-error, :verify-error, and :verify-flags
7442 parameters of `gnutls-boot' and documented those parameters in the
7443 docstring. Start callback support.
7444 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7445 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7446 on error. Return error code.
7447 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7448 (emacs_gnutls_read): Likewise.
7449 (Fgnutls_boot): Return handshake error code.
7450 (emacs_gnutls_handle_error): New function.
7451 (wsaerror_to_errno): Likewise.
7453 * w32.h (emacs_gnutls_pull): Add prototype.
7454 (emacs_gnutls_push): Likewise.
7456 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7457 (emacs_gnutls_push): Likewise.
7459 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7461 * process.c (wait_reading_process_output): Check if GnuTLS
7462 buffered some data internally if no FDs are set for TLS
7465 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7466 (LIBS): Link to USER_LIBS.
7467 ($(BLD)/gnutls.$(0)): New target.
7469 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7471 * xdisp.c (handle_single_display_spec): Rename the
7472 display_replaced_before_p argument into display_replaced_p, to
7473 make it consistent with the commentary. Fix typos in the
7476 * textprop.c (syms_of_textprop): Remove dead code.
7477 (copy_text_properties): Delete obsolete commentary about an
7478 interface that was deleted long ago. Fix typos in the description
7481 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7482 to changes in oldXMenu/XMenu.h from 2011-04-16.
7483 <menu_help_message, prev_menu_help_message>: Constify.
7484 (IT_menu_make_room): menu->help_text is now `const char **';
7487 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7488 to changes in oldXMenu/XMenu.h from 2011-04-16.
7489 (struct XMenu): Declare `help_text' `const char **'.
7491 * xfaces.c <Qunspecified>: Make extern again.
7493 * syntax.c: Include sys/types.h before including regex.h, as
7496 * doc.c (get_doc_string): Improve the format passed to `error'.
7498 * doprnt.c (doprnt): Improve commentary.
7500 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7502 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7505 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7506 changes in globals.h immediately force recompilation.
7507 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7508 $(CURDIR)/s/ms-w32.h.
7509 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7511 * character.c (Fchar_direction): Function deleted.
7512 (syms_of_character): Don't defsubr it.
7513 <char-direction-table>: Deleted.
7515 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7517 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7518 * doprnt.c: Include limits.h.
7519 (SIZE_MAX): New macro.
7520 (doprnt): Return a size_t value. 2nd arg is now size_t.
7521 Many local variables are now size_t instead of int or unsigned.
7522 Improve overflow protection. Support `l' modifier for integer
7523 conversions. Support %l conversion. Don't assume an EMACS_INT
7524 argument for integer conversions and for %c.
7526 * lisp.h (doprnt): Restore prototype.
7528 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7531 * Makefile.in (base_obj): Add back doprnt.o.
7533 * deps.mk (doprnt.o): Add back prerequisites.
7534 (callint.o): Depend on character.h.
7536 * eval.c (internal_lisp_condition_case): Include the handler
7537 representation in the error message.
7538 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7539 when breaking from the loop.
7541 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7543 * callint.c (Fcall_interactively): When displaying error message
7544 about invalid control letter, pass the character's codepoint, not
7545 a pointer to its multibyte form. Improve display of the character
7546 in octal and display also its hex code.
7548 * character.c (char_string): Use %x to display the (unsigned)
7549 codepoint of an invalid character, to avoid displaying a bogus
7552 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7553 `error', not SYMBOL_NAME itself.
7555 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7556 character arguments to `error'.
7558 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7559 to `error' in error message about FINAL_CHAR argument. Make sure
7560 FINAL_CHAR is a character, and use %c when it is passed as
7561 argument to `error'.
7563 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7565 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7567 * w32.c: Include <time.h>.
7568 (sys_localtime): New function.
7570 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7572 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7574 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7576 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7578 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7581 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7583 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7584 gl_state.e_property when gl_state.object is Qt.
7586 * insdel.c (make_gap_larger): Remove limitation of buffer size
7589 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7591 * xdisp.c (lookup_glyphless_char_display)
7592 (produce_glyphless_glyph): Handle cons cell entry in
7593 glyphless-char-display.
7594 (Vglyphless_char_display): Document it.
7596 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7597 glyphless-char-display.
7599 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7601 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7603 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7605 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7606 definition for no-X builds.
7608 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7610 Static checks with GCC 4.6.0 and non-default toolkits.
7612 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7614 * process.c (keyboard_bit_set): Define only if SIGIO.
7615 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7616 (send_process): Repair possible setjmp clobbering.
7618 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7620 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7622 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7624 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7625 Define only if needed.
7627 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7628 by pacifying GCC about it. Maybe it's time to retire it?
7629 * xfaces.c (USG, __TIMEVAL__): Likewise.
7631 * dispextern.h (struct redisplay_interface): Rename param
7633 * termhooks.h (struct terminal): Likewise.
7634 * xterm.c (xembed_send_message): Likewise.
7636 * insdel.c (make_gap_smaller): Define only if
7637 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7639 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7642 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7643 so that we aren't warned about unused symbols.
7645 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7647 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7649 * xfns.c (x_real_positions): Mark locals as initialized.
7651 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7653 * xterm.c: Fix problems found by static analysis with other toolkits.
7654 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7655 (x_dispatch_event): Declare static if USE_GTK, and
7656 define if USE_GTK || USE_X_TOOLKIT.
7657 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7658 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7659 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7660 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7662 * xmenu.c (menu_help_callback): Pointer type fixes.
7663 Use const pointers when pointing at readonly data. Avoid pointer
7665 (FALSE): Remove unused macro.
7666 (update_frame_menubar): Remove unused decl.
7668 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7670 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7671 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7672 (single_menu_item): Rename local to avoid shadowing.
7674 * keyboard.c (make_lispy_event): Remove unused local var.
7676 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7677 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7679 * bitmaps: Change bitmaps from unsigned char back to the X11
7680 compatible char. Avoid the old compiler warnings about
7681 out-of-range initializers by using, for example, '\xab' rather
7684 * xgselect.c (xgselect_initialize): Check vs interface
7685 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7687 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7689 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7690 to read-only memory.
7692 * fns.c (vector): Remove; this old hack is no longer needed.
7694 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7696 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7698 * xrdb.c (x_load_resources): Omit unused local.
7700 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7701 (x_window): Rename locals to avoid shadowing.
7702 (USG): Use the kludged USG macro, to pacify gcc.
7704 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7705 (x_term_init): Remove local to avoid shadowing.
7707 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7709 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7710 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7712 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7714 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7716 Fix regex.c, syntax.c and friends for buffers > 2GB.
7717 * syntax.h (struct gl_state_s): Declare character position members
7720 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7722 * textprop.c (verify_interval_modification, interval_of):
7723 Declare arguments EMACS_INT.
7725 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7728 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7730 * indent.c (Fvertical_motion): Local variable it_start is now
7733 * regex.c (re_match, re_match_2, re_match_2_internal)
7734 (bcmp_translate, regcomp, regexec, print_double_string)
7735 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7736 (re_compile_pattern, re_exec): Declare arguments and local
7737 variables `size_t' and `ssize_t' and return values `regoff_t', as
7739 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7740 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7741 <compile_stack_type>: `size' and `avail' are now `size_t'.
7743 * regex.h <regoff_t>: Use ssize_t, not int.
7744 (re_search, re_search_2, re_match, re_match_2): Arguments that
7745 specify buffer/string position and length are now ssize_t and
7746 size_t. Return type is regoff_t.
7748 2011-04-16 Ben Key <bkey76@gmail.com>
7750 * nsfont.m: Fixed bugs in ns_get_family and
7751 ns_descriptor_to_entity that were caused by using free to
7752 deallocate memory blocks that were allocated by xmalloc (via
7753 xstrdup). This caused Emacs to crash when compiled with
7754 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7755 --enable-checking=xmallocoverrun). xfree is now used to
7756 deallocate these memory blocks.
7758 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7760 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7762 emacs_write: Accept and return EMACS_INT for sizes.
7763 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7765 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7766 Accept and return EMACS_INT.
7767 (emacs_gnutls_write): Return the number of bytes written on
7769 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7770 (emacs_read, emacs_write): Remove check for negative size, as the
7771 Emacs source code has been audited now.
7772 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7773 (emacs_read, emacs_write): Use it.
7774 * process.c (send_process): Adjust to the new signatures of
7775 emacs_write and emacs_gnutls_write. Do not attempt to store
7776 a byte offset into an 'int'; it might overflow.
7777 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7779 * sound.c: Don't assume sizes fit in 'int'.
7780 (struct sound_device.period_size, alsa_period_size):
7781 Return EMACS_INT, not int.
7782 (struct sound_device.write, vox_write, alsa_write):
7783 Accept EMACS_INT, not int.
7784 (wav_play, au_play): Use EMACS_INT to store sizes and to
7785 record read return values.
7787 2011-04-15 Ben Key <bkey76@gmail.com>
7789 * keyboard.c (Qundefined): Don't declare static since it is used
7791 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7792 static since they are used in nsfont.m.
7794 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7796 * process.c (Qprocessp): Don't declare static.
7797 * lisp.h (Qprocessp): Declare again.
7799 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7801 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7803 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7805 Improve C-level modularity by making more things 'static'.
7807 Don't publish debugger-only interfaces to other modules.
7808 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7809 (verify_bytepos, count_markers): Move decls to the only modules
7811 * region-cache.h (pp_cache): Likewise.
7812 * window.h (check_all_windows): Likewise.
7813 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7815 * sysdep.c (croak): Now static, if
7816 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7817 * syssignal.h (croak): Declare only if not static.
7819 * alloc.c (refill_memory_reserve): Now static if
7820 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7821 * lisp.h (refill_memory_reserve): Declare only if not static.
7823 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7824 Define only if USE_LUCID.
7826 * xrdb.c (x_customization_string, x_rm_string): Now static.
7828 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7829 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7831 * xdisp.c (draw_row_with_mouse_face): Now static.
7832 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7834 * window.h (check_all_windows): Mark externally visible.
7836 * window.c (window_deletion_count): Now static.
7838 * undo.c: Make symbols static if they're not exported.
7839 (last_undo_buffer, last_boundary_position, pending_boundary):
7842 * textprop.c (interval_insert_behind_hooks): Now static.
7843 (interval_insert_in_front_hooks): Likewise.
7845 * term.c: Make symbols static if they're not exported.
7846 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7847 (max_frame_lines, tty_set_terminal_modes):
7848 (tty_reset_terminal_modes, tty_turn_off_highlight):
7849 (get_tty_terminal): Now static.
7850 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7851 * termhooks.h (term_mouse_moveto): Do not declare if
7853 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7854 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7856 * sysdep.c: Make symbols static if they're not exported.
7857 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7859 (sigprocmask_set, full_mask): Remove; unused.
7860 (wait_debugging): Mark as visible.
7861 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7862 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7864 * syntax.c (syntax_temp): Define only if !__GNUC__.
7866 * sound.c (current_sound_device, current_sound): Now static.
7868 * search.c (searchbufs, searchbuf_head): Now static.
7870 * scroll.c (scroll_cost): Remove; unused.
7871 * dispextern.h (scroll_cost): Remove decl.
7873 * region-cache.h (pp_cache): Mark as externally visible.
7875 * process.c: Make symbols static if they're not exported.
7876 (process_tick, update_tick, create_process, chan_process):
7877 (Vprocess_alist, proc_buffered_char, datagram_access):
7878 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7879 (deactivate_process): Mark defn as static, as well as decl.
7880 * lisp.h (create_process): Remove decl.
7881 * process.h (chan_process, Vprocess_alist): Remove decls.
7883 * print.c: Make symbols static if they're not exported.
7884 (print_depth, new_backquote_output, being_printed, print_buffer):
7885 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7886 (print_interval, print_number_index, initial_stderr_stream):
7888 * lisp.h (Fprinc): Remove decl.
7889 (debug_output_compilation_hack): Mark as externally visible.
7891 * sysdep.c (croak): Move decl from here to syssignal.h.
7892 * syssignal.h (croak): Put it here, so the API can be checked when
7893 'croak' is called from dissociate_if_controlling_tty.
7895 * minibuf.c: Make symbols static if they're not exported.
7896 (minibuf_save_list, choose_minibuf_frame): Now static.
7897 * lisp.h (choose_minibuf_frame): Remove decl.
7899 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7901 * lread.c: Make symbols static if they're not exported.
7902 (read_objects, initial_obarray, oblookup_last_bucket_number):
7904 (make_symbol): Remove; unused.
7905 * lisp.h (initial_obarray, make_symbol): Remove decls.
7907 * keyboard.c: Make symbols static if they're not exported.
7908 (single_kboard, recent_keys_index, total_keys, recent_keys):
7909 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7910 (this_single_command_key_start, echoing, last_auto_save):
7911 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7912 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7913 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7914 (Vlispy_mouse_stem, double_click_count):
7916 (force_auto_save_soon): Define only if SIGDANGER.
7917 (ignore_mouse_drag_p): Now static if
7918 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7919 (print_help): Remove; unused.
7920 (stop_character, last_timer_event): Mark as externally visible.
7921 * keyboard.h (ignore_mouse_drag_p): Declare only if
7922 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7923 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7924 * lisp.h (echoing): Remove decl.
7925 (force_auto_save_soon): Declare only if SIGDANGER.
7926 * xdisp.c (redisplay_window): Simplify code, to make it more
7927 obvious that ignore_mouse_drag_p is not accessed if !defined
7928 USE_GTK && !defined HAVE_NS.
7930 * intervals.c: Make symbols static if they're not exported.
7931 (merge_properties_sticky, merge_interval_right, delete_interval):
7933 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7935 * insdel.c: Make symbols static if they're not exported.
7936 However, leave prepare_to_modify_buffer alone. It's never
7937 called from outside this function, but that appears to be a bug.
7938 (combine_after_change_list, combine_after_change_buffer):
7939 (adjust_after_replace, signal_before_change): Now static.
7940 (adjust_after_replace_noundo): Remove; unused.
7941 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7942 (signal_before_change): Remove decls.
7944 * indent.c (val_compute_motion, val_vmotion): Now static.
7946 * image.c: Make symbols static if they're not exported.
7947 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7949 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7950 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7952 * fringe.c (standard_bitmaps): Now static.
7953 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7955 * frame.c: Make symbols static if they're not exported.
7956 (x_report_frame_params, make_terminal_frame): Now static.
7957 (get_frame_param): Now static, unless HAVE_NS.
7958 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7959 (x_get_resource_string): Remove; not used.
7960 * frame.h (make_terminal_frame, x_report_frame_params):
7961 (x_get_resource_string); Remove decls.
7962 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7963 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7965 * font.c, fontset.c: Make symbols static if they're not exported.
7966 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7967 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7968 * font.c (font_close_object): Now static.
7969 * font.h (font_close_object): Remove.
7970 * fontset.c (FONTSET_OBJLIST): Remove.
7971 (free_realized_fontset) #if-0 the body, which does nothing.
7972 (face_suitable_for_char_p): #if-0, as it's never called.
7973 * fontset.h (face_suitable_for_char_p): Remove decl.
7974 * xfaces.c (face_at_string_position):
7975 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7976 since 0 is always ASCII.
7978 * fns.c (weak_hash_tables): Now static.
7980 * fileio.c: Make symbols static if they're not exported.
7981 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7982 (Vwrite_region_annotation_buffers): Now static.
7984 * eval.c: Make symbols static if they're not exported.
7985 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7986 * lisp.h (backtrace_list): Remove decl.
7988 * emacs.c: Make symbols static if they're not exported.
7989 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7990 (fatal_error_code, fatal_error_signal_hook, standard_args):
7992 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7993 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7994 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7995 * lisp.h (fatal_error_signal_hook): Remove decl.
7996 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7998 * editfns.c: Move a (normally-unused) function to its only use.
7999 * editfns.c, lisp.h (get_operating_system_release): Remove.
8000 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8001 worth the hassle of breaking this out.
8003 * xterm.c: Make symbols static if they're not exported.
8004 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8005 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8006 (x_destroy_window, x_delete_display):
8008 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8009 (x_mouse_leave): Remove; unused.
8010 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8011 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8012 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8014 (x_mouse_leave): Declare only if WINDOWSNT.
8015 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8016 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8019 * ftxfont.c: Make symbols static if they're not exported.
8020 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8022 * font.h (ftxfont_driver): Likewise.
8024 * xfns.c: Make symbols static if they're not exported.
8025 (x_last_font_name, x_display_info_for_name):
8026 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8027 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8028 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8029 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8030 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8031 (last_show_tip_args): Now static.
8032 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8033 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8034 (x_screen_planes): Remove; unused.
8035 * dispextern.h (x_screen_planes): Remove decl.
8037 * dispnew.c: Make symbols static if they're not exported.
8038 * dispextern.h (redraw_garbaged_frames, scrolling):
8039 (increment_row_positions): Remove.
8040 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8041 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8043 (redraw_garbaged_frames): Remove; unused.
8045 * xfaces.c: Make symbols static if they're not exported.
8046 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8048 * xterm.h (defined_color): Remove decls.
8049 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8050 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8051 (menu_face_changed_default, defined_color, free_realized_face):
8052 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8053 (ascii_face_of_lisp_face): Remove; unused.
8055 * xdisp.c: Make symbols static if they're not exported.
8056 * dispextern.h (scratch_glyph_row, window_box_edges):
8057 (glyph_to_pixel_coords, set_cursor_from_row):
8058 (get_next_display_element, set_iterator_to_next):
8059 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8060 (show_mouse_face): Remove decls
8061 * frame.h (message_buf_print): Likewise.
8062 * lisp.h (pop_message, set_message, check_point_in_composition):
8064 * xterm.h (set_vertical_scroll_bar): Likewise.
8065 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8066 (message_buf_print, scratch_glyph_row, displayed_buffer):
8067 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8068 (get_next_display_element, show_mouse_face, window_box_edges):
8069 (frame_to_window_pixel_xy, check_point_in_composition):
8070 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8071 (glyph_to_pixel_coords): Remove; unused.
8073 * dired.c (file_name_completion): Now static.
8075 * dbusbind.c (xd_in_read_queued_messages): Now static.
8077 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8078 * data.c (circular_list_error): Remove.
8080 * commands.h (last_point_position, last_point_position_buffer):
8081 (last_point_position_window): Remove decls.
8082 * keyboard.c: Make these variables static.
8084 * coding.h (coding, code_convert_region, encode_coding_gap):
8086 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8087 (iso_code_class, detect_coding, code_convert_region): Now static.
8088 (encode_coding_gap): Remove; unused.
8090 * chartab.c (chartab_chars, chartab_bits): Now static.
8092 * charset.h (charset_iso_8859_1): Remove decl.
8093 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8096 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8097 * ccl.c (Vccl_program_table): Now static.
8098 (check_ccl_update): Remove; unused.
8100 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8101 * category.h: ... from here.
8102 * category.c (check_category_table, set_category_set): Now static.
8104 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8105 * lisp.h: Remove these decls.
8107 * buffer.c (buffer_count): Remove unused var.
8109 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8110 so that it's not optimized away.
8111 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8112 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8113 exported only to the debugger.
8115 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8116 * atimer.h (run_all_atimers): Remove; not exported.
8118 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8119 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8120 was inaccessible from Lisp.
8121 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8122 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8124 alloc.c: Import and export fewer symbols, and remove unused items.
8125 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8127 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8128 it's not optimized away by whole-program optimization.
8129 (message_enable_multibyte, free_misc): Remove.
8130 (catchlist, handlerlist, mark_backtrace):
8131 Declare only if BYTE_MARK_STACK.
8132 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8133 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8134 (message_enable_multibyte): Remove decl.
8135 (free_misc, interval_free_list, float_block, float_block_index):
8136 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8137 (cons_free_list, last_marked_index):
8139 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8140 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8141 (mark_backtrace): Define only if BYTE_MARK_STACK.
8142 * xdisp.c (message_enable_multibyte): Now static.
8144 Declare Lisp_Object Q* variables to be 'static' if not exported.
8145 This makes it easier for human readers (and static analyzers)
8146 to see whether these variables are used from other modules.
8147 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8148 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8149 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8150 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8151 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8152 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8153 * xmenu.c, xselect.c:
8154 Declare Q* vars static if they are not used in other modules.
8155 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8156 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8157 Remove decls of unexported vars.
8158 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8160 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8162 Make Emacs functions such as Fatom 'static' by default.
8163 This makes it easier for human readers (and static analyzers)
8164 to see whether these functions can be called from other modules.
8165 DEFUN now defines a static function. To make the function external
8166 so that it can be used in other C modules, use the new macro DEFUE.
8167 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8168 (Finit_image_library):
8169 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8170 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8171 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8172 Remove decls, since these functions are now static.
8173 (Funintern, Fget_internal_run_time): New decls, since these functions
8174 were already external.
8176 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8177 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8178 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8179 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8180 * keyboard.c, keymap.c, lread.c:
8181 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8182 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8183 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8184 Mark functions with DEFUE instead of DEFUN,
8185 if they are used in other modules.
8186 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8187 decls for now-static functions.
8188 * buffer.h (Fdelete_overlay): Remove decl.
8189 * callproc.c (Fgetenv_internal): Mark as internal.
8190 * composite.c (Fremove_list_of_text_properties): Remove decl.
8191 (Fcomposition_get_gstring): New forward static decl.
8192 * composite.h (Fcomposite_get_gstring): Remove decl.
8193 * dired.c (Ffile_attributes): New forward static decl.
8194 * doc.c (Fdocumntation_property): New forward static decl.
8195 * eval.c (Ffetch_bytecode): New forward static decl.
8196 (Funintern): Remove extern decl; now in .h file where it belongs.
8197 * fileio.c (Fmake_symbolic_link): New forward static decl.
8198 * image.c (Finit_image_library): New forward static decl.
8199 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8200 * intervals.h (Fprevious_property_change):
8201 (Fremove_list_of_text_properties): Remove decls.
8202 * keyboard.c (Fthis_command_keys): Remove decl.
8203 (Fcommand_execute): New forward static decl.
8204 * keymap.c (Flookup_key): New forward static decl.
8205 (Fcopy_keymap): Now static.
8206 * keymap.h (Flookup_key): Remove decl.
8207 * process.c (Fget_process): New forward static decl.
8208 (Fprocess_datagram_address): Mark as internal.
8209 * syntax.c (Fsyntax_table_p): New forward static decl.
8210 (skip_chars): Remove duplicate decl.
8211 * textprop.c (Fprevious_property_change): New forward static decl.
8212 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8214 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8215 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8217 * editfns.c (Fformat): Remove unreachable code.
8219 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8221 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8224 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8226 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8227 when at ZV. (Bug#8487)
8229 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8231 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8233 * keyboard.c (parse_tool_bar_item): Likewise.
8234 * sound.c (sound_cleanup, alsa_close): Likewise.
8235 * termcap.c (tgetent): Likewise.
8236 * xfns.c (x_default_font_parameter): Likewise.
8237 * xsettings.c (read_and_apply_settings): Likewise.
8239 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8240 (overrun_check_free): Protoize.
8242 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8244 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8245 since callers should never pass a negative size.
8246 Change the signature to match that of plain 'read' and 'write'; see
8247 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8248 * lisp.h: Update prototypes of emacs_write and emacs_read.
8250 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8252 * xdisp.c (redisplay_window): Don't try to determine the character
8253 position of the scroll margin if the window start point w->startp
8254 is outside the buffer's accessible region. (Bug#8468)
8256 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8258 Fix write-region and its subroutines for buffers > 2GB.
8259 * fileio.c (a_write, e_write): Modify declaration of arguments and
8260 local variables to support buffers larger than 2GB.
8261 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8263 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8264 argument, local variables, and return value.
8266 * lisp.h: Update prototypes of emacs_write and emacs_read.
8268 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8270 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8272 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8274 Fix more problems found by GCC 4.6.0's static checks.
8276 * xdisp.c (vmessage): Use a better test for character truncation.
8278 * charset.c (load_charset_map): <, not <=, for optimization,
8279 and to avoid potential problems with integer overflow.
8280 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8281 * casetab.c (set_identity, shuffle): Likewise.
8282 * editfns.c (Fformat): Likewise.
8283 * syntax.c (skip_chars): Likewise.
8285 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8286 This also lets GCC 4.6.0 generate slightly better loop code.
8288 * callint.c (Fcall_interactively): <, not <=, for optimization.
8289 (Fcall_interactively): Count the number of arguments produced,
8290 not the number of arguments given. This is simpler and lets GCC
8291 4.6.0 generate slightly better code.
8293 * ftfont.c: Distingish more carefully between FcChar8 and char.
8294 The previous code passed unsigned char * to a functions like
8295 strlen and xstrcasecmp that expect char *, which does not
8296 conform to the C standard.
8297 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8298 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8299 char * when the C standard requires it.
8301 * keyboard.c (read_char): Remove unused var.
8303 * eval.c: Port to Windows vsnprintf (Bug#8435).
8305 (SIZE_MAX): Define if the headers do not.
8306 (verror): Do not give up if vsnprintf returns a negative count.
8307 Instead, grow the buffer. This ports to Windows vsnprintf, which
8308 does not conform to C99. Problem reported by Eli Zaretskii.
8309 Also, simplify the allocation scheme, by avoiding the need for
8310 calling realloc, and removing the ALLOCATED variable.
8312 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8314 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8315 But keep the doprint source code for now, as we might revamp it
8316 and use it again (Bug#8435).
8317 * lisp.h (doprnt): Remove.
8318 * Makefile.in (base_obj): Remove doprnt.o.
8319 * deps.mk (doprnt.o): Remove.
8321 error: Print 32- and 64-bit integers portably (Bug#8435).
8322 Without this change, on typical 64-bit hosts error ("...%d...", N)
8323 was used to print both 32- and 64-bit integers N, which relied on
8325 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8326 * lisp.h (error, verror): Mark as printf-like functions.
8327 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8328 Report overflow in size calculations when allocating printf buffer.
8329 Do not truncate output string at its first null byte.
8330 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8331 Truncate the output at a character boundary, since vsnprintf does not
8333 * charset.c (check_iso_charset_parameter): Convert internal
8334 character to string before calling 'error', since %c now has the
8336 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8337 overflow when computing char to be passed to 'error'. Do not
8338 pass Lisp_Object to 'error'; pass the integer instead.
8339 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8340 formatted with plain %d.
8342 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8344 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8346 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8348 * xterm.c (x_catch_errors): Remove duplicate declaration.
8350 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8352 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8354 2011-04-10 Jim Meyering <meyering@redhat.com>
8356 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8357 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8358 return ssize_t not "int", and use size_t as the buffer length.
8359 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8360 * gnutls.h: Update declarations.
8361 * process.c (read_process_output): Use ssize_t, to match.
8362 (send_process): Likewise.
8364 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8366 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8368 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8370 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8371 Use unsigned char, to match FcChar8 type definition.
8373 * xterm.c (handle_one_xevent):
8374 * xmenu.c (create_and_show_popup_menu):
8375 * xselect.c (x_decline_selection_request)
8376 (x_reply_selection_request): Avoid type-punned deref of X events.
8378 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8380 Fix some uses of `int' instead of EMACS_INT.
8381 * search.c (string_match_1, fast_string_match)
8382 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8383 (scan_buffer, find_next_newline_no_quit)
8384 (find_before_next_newline, search_command, Freplace_match)
8385 (Fmatch_data): Make some `int' variables be EMACS_INT.
8387 * xdisp.c (display_count_lines): 3rd argument and return value now
8388 EMACS_INT. All callers changed.
8389 (pint2hrstr): Last argument is now EMACS_INT.
8391 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8392 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8393 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8394 (decode_coding_utf_16, decode_coding_emacs_mule)
8395 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8396 (decode_coding_ccl, decode_coding_charset)
8397 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8398 (decode_coding_iso_2022, decode_coding_emacs_mule)
8399 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8400 <char_offset, last_offset>: Declare EMACS_INT.
8401 (encode_coding_utf_8, encode_coding_utf_16)
8402 (encode_coding_emacs_mule, encode_invocation_designation)
8403 (encode_designation_at_bol, encode_coding_iso_2022)
8404 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8405 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8407 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8408 (encode_invocation_designation): Last argument P_NCHARS is now
8410 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8411 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8413 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8416 * ccl.c (Fccl_execute_on_string): Declare some variables
8419 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8421 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8423 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8425 * process.c (Fformat_network_address): Doc fix.
8427 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8429 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8431 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8433 * keyboard.c (read_char): Call Lisp function help-form-show,
8434 instead of using internal_with_output_to_temp_buffer.
8435 (Qhelp_form_show): New var.
8436 (syms_of_keyboard): Use DEFSYM macro.
8438 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8440 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8442 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8444 * process.c (Flist_processes): Remove to Lisp.
8445 (list_processes_1): Delete.
8447 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8449 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8451 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8453 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8455 Fix more problems found by GCC 4.6.0's static checks.
8457 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8459 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8461 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8463 * xdisp.c (vmessage): Mark as a printf-like function.
8465 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8467 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8469 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8470 printf-like functions.
8471 (tiff_load): Add casts to remove these marks before passing them
8472 to system-supplied API.
8474 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8476 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8477 This avoids several warnings with gcc -Wstrict-overflow.
8478 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8479 directly, rather than having caller test rule sign. This avoids
8480 some unnecessary tests.
8481 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8482 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8483 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8485 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8486 (xfont_open): Avoid unnecessary tests.
8488 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8490 * composite.h, composite.c (composition_gstring_put_cache):
8491 Use EMACS_INT, not int, for length.
8493 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8494 breaking out part of COMPOSITION_DECODE_RULE.
8495 (COMPOSITION_DECODE_RULE): Use it.
8496 * composite.c (get_composition_id): Remove unused local vars,
8497 by using the new macro.
8499 * textprop.c (set_text_properties_1): Change while to do-while,
8500 since the condition is always true at first.
8502 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8503 (interval_deletion_adjustment): Return unsigned value.
8506 * process.c (list_processes_1, create_pty, read_process_output):
8507 (exec_sentinel): Remove vars that were set but not used.
8508 (create_pty): Remove unnecessary "volatile"s.
8509 (Fnetwork_interface_info): Avoid possibility of int overflow.
8510 (read_process_output): Do adaptive read buffering even if carryover.
8511 (read_process_output): Simplify nbytes computation if buffered.
8513 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8515 * syntax.c (scan_words): Remove var that was set but not used.
8516 (update_syntax_table): Use unsigned instead of int.
8518 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8519 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8520 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8522 * print.c (print_error_message): Avoid int overflow.
8524 * font.c (font_list_entities): Redo for clarity,
8525 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8527 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8528 (font_score): Avoid potential overflow in diff calculation.
8530 * fns.c (substring_both): Remove var that is set but not used.
8531 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8533 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8535 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8536 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8537 can always succeed if overflow has undefined behavior.
8539 * search.c (boyer_moore, wordify): Remove vars set but not used.
8540 (wordify): Omit three unnecessary tests.
8542 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8543 All callers changed. This avoids the need for an unused var.
8545 * casefiddle.c (casify_region): Remove var that is set but not used.
8547 * dired.c (file_name_completion): Remove var that is set but not used.
8549 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8551 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8552 (Finsert_file_contents): Remove unnecessary code checking fd.
8554 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8555 Check for integer overflow on size calculations.
8557 * buffer.c (Fprevious_overlay_change): Remove var that is set
8560 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8561 Remove vars that are set but not used.
8562 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8563 (timer_check_2): Mark vars as initialized.
8565 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8567 * image.c (lookup_image): Remove var that is set but not used.
8568 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8570 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8571 that are set but not used.
8573 * xfns.c (make_invisible_cursor): Don't return garbage
8574 if XCreateBitmapFromData fails (Bug#8410).
8576 * xselect.c (x_get_local_selection, x_handle_property_notify):
8577 Remove vars that are set but not used.
8579 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8580 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8582 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8583 Remove var that is set but not used.
8584 (scroll_bar_windows_size): Now size_t, not int.
8585 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8588 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8589 (map_tty_color) [!defined MSDOS]: Likewise.
8591 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8593 * coding.c: Remove vars that are set but not used.
8594 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8595 All callers changed.
8596 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8597 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8598 (decode_coding_charset): Remove vars that are set but not used.
8600 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8601 that is set but not used.
8603 * print.c (print_object): Remove var that is set but not used.
8605 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8606 The gnulib version avoids calling malloc in the usual case,
8607 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8608 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8609 * filelock.c (current_lock_owner): Likewise.
8610 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8611 * sysdep.c: Include allocator.h, careadlinkat.h.
8612 (emacs_no_realloc_allocator): New static constant.
8613 (emacs_readlink): New function.
8614 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8615 ../lib/careadlinkat.h.
8617 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8619 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8620 first non-nil return value).
8622 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8624 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8625 if not defined (Bug#8403).
8627 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8629 * xdisp.c (display_count_lines): Remove parameter `start',
8630 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8631 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8632 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8633 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8634 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8635 and thereabouts. All callers changed.
8636 (get_per_char_metric): Remove parameter `f', unused since
8637 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8639 2011-04-02 Jim Meyering <meyering@redhat.com>
8641 do not dereference NULL upon failed strdup
8642 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8643 (ns_get_family): Likewise.
8645 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8647 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8649 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8651 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8654 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8656 Add lexical binding.
8658 * window.c (Ftemp_output_buffer_show): New fun.
8659 (Fsave_window_excursion):
8660 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8662 * lread.c (lisp_file_lexically_bound_p): New function.
8663 (Fload): Bind Qlexical_binding.
8664 (readevalloop): Remove `evalfun' arg.
8665 Bind Qinternal_interpreter_environment.
8666 (Feval_buffer): Bind Qlexical_binding.
8667 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8669 (syms_of_lread): Declare `lexical-binding'.
8671 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8673 * keyboard.c (eval_dyn): New fun.
8674 (menu_item_eval_property): Use it.
8676 * image.c (parse_image_spec): Use Ffunctionp.
8678 * fns.c (concat, mapcar1): Accept byte-code-functions.
8680 * eval.c (Fsetq): Handle lexical vars.
8681 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8682 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8683 (FletX, Flet): Obey lexical binding.
8684 (Fcommandp): Handle closures.
8685 (Feval): New `lexical' arg.
8686 (eval_sub): New function extracted from Feval. Use it almost
8687 everywhere where Feval was used. Look up vars in lexical env.
8689 (Ffunctionp): Move from subr.el.
8690 (Ffuncall): Handle closures.
8691 (apply_lambda): Remove `eval_flags'.
8692 (funcall_lambda): Handle closures and new byte-code-functions.
8693 (Fspecial_variable_p): New function.
8694 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8695 but without exporting it to Lisp.
8697 * doc.c (Fdocumentation, store_function_docstring):
8698 * data.c (Finteractive_form): Handle closures.
8700 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8703 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8705 (exec_byte_code): New function extracted from Fbyte_code to handle new
8706 calling convention for byte-code-functions. Add new byte-codes.
8708 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8710 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8712 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8714 * xdisp.c (redisplay_internal): Fix prototype.
8716 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8718 * xdisp.c (SCROLL_LIMIT): New macro.
8719 (try_scrolling): Use it when setting scroll_limit.
8720 Limit scrolling to 100 screen lines.
8721 (redisplay_window): Even when falling back on "recentering",
8722 position point in the window according to scroll-conservatively,
8723 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8725 (try_scrolling): When point is above the window, allow searching
8726 as far as scroll_max, or one screenful, to compute vertical
8727 distance from PT to the scroll margin position. This prevents
8728 try_scrolling from unnecessarily failing when
8729 scroll-conservatively is set to a value slightly larger than the
8730 window height. Clean up the case of PT below the margin at bottom
8731 of window: scroll_max can no longer be INT_MAX. When aggressive
8732 scrolling is in use, don't let point enter the opposite scroll
8733 margin as result of the scroll.
8734 (syms_of_xdisp) <scroll-conservatively>: Document the
8735 threshold of 100 lines for never-recentering scrolling.
8737 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8739 * dispextern.h (move_it_by_lines):
8740 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8741 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8742 (message_log_check_duplicate): Remove parameters `prev_bol' and
8743 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8744 (redisplay_internal): Remove parameter `preserve_echo_area',
8745 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8747 * indent.c (Fvertical_motion):
8748 * window.c (window_scroll_pixel_based, Frecenter):
8749 Don't pass `need_y_p' to `move_it_by_lines'.
8751 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8753 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8754 steal a few bits to be more compact.
8755 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8756 Remove unneeded casts.
8758 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8760 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8762 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8763 binding" message (bug#7967).
8765 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8767 Fix more problems found by GCC 4.6.0's static checks.
8769 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8770 Remove unused local var.
8772 * editfns.c (Fmessage_box): Remove unused local var.
8774 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8775 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8776 Omit unused local vars.
8777 * window.c (shrink_windows): Omit unused local var.
8778 * menu.c (digest_single_submenu): Omit unused local var.
8779 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8780 Omit unused local var.
8782 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8783 Don't assume string length fits in int.
8784 (keyremap_step, read_key_sequence): Use size_t for sizes.
8785 (read_key_sequence): Don't check last_real_key_start redundantly.
8787 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8788 instead of alloca (Bug#8344).
8790 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8791 (Fbacktrace_frame): Don't assume nframes fits in int.
8793 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8795 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8798 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8800 * cm.c (calccost): Turn while-do into do-while, for clarity.
8802 * keyboard.c (syms_of_keyboard): Use the same style as later
8803 in this function when indexing through an array. This also
8804 works around GCC bug 48267.
8806 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8808 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8810 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8811 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8813 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8814 This avoids undefined behavior on integer overflow, and is a bit
8815 more convenient anyway since it is compared to a size_t variable.
8817 Variadic C functions now count arguments with size_t, not int.
8818 This avoids an unnecessary limitation on 64-bit machines, which
8819 caused (substring ...) to crash on large vectors (Bug#8344).
8820 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8821 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8822 All variadic functions and their callers changed accordingly.
8823 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8824 * data.c (arith_driver, float_arith_driver): Likewise.
8825 * editfns.c (general_insert_function): Likewise.
8826 * eval.c (struct backtrace.nargs, interactive_p)
8827 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8828 (funcall_lambda, mark_backtrace): Likewise.
8829 * fns.c (concat): Likewise.
8830 * frame.c (x_set_frame_parameters): Likewise.
8831 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8832 0 if not found, not -1. All callers changed.
8834 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8835 (stack_copy_size): Now size_t, not int.
8836 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8838 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8840 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8841 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8842 All callers changed.
8844 * lisp.h (multibyte_char_to_unibyte):
8845 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8846 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8847 * character.h (CHAR_TO_BYTE8):
8848 * cmds.c (internal_self_insert):
8849 * editfns.c (general_insert_function):
8850 * keymap.c (push_key_description):
8851 * search.c (Freplace_match):
8852 * xdisp.c (message_dolog, set_message_1): All callers changed.
8854 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8856 * keyboard.c (safe_run_hook_funcall): New function.
8857 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8858 don't set the hook to nil, but remove the offending function instead.
8859 (Qcommand_hook_internal): Remove, unused.
8860 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8861 Vcommand_hook_internal.
8863 * eval.c (enum run_hooks_condition): Remove.
8864 (funcall_nil, funcall_not): New functions.
8865 (run_hook_with_args): Call each function through a `funcall' argument.
8866 Remove `cond' argument, now redundant.
8867 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8868 (Frun_hook_with_args_until_failure): Adjust accordingly.
8869 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8871 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8873 * dispextern.h (string_buffer_position): Remove declaration.
8875 * print.c (strout): Remove parameter `multibyte', unused since
8876 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8878 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8879 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8880 All callers changed.
8882 * w32.c (_wsa_errlist): Use braces for struct initializers.
8884 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8885 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8886 All callers changed.
8887 (string_buffer_position): Likewise. Also, make static (it's never
8888 used outside xdisp.c).
8889 (cursor_row_p): Remove parameter `w', unused since
8890 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8891 (decode_mode_spec): Remove parameter `precision', introduced during
8892 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8893 All callers changed.
8895 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8897 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8899 2011-03-27 Anders Lindgren <andlind@gmail.com>
8901 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8902 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8903 (ns_update_auto_hide_menu_bar): New functions.
8904 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8905 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8906 ns_constrain_all_frames.
8907 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8908 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8910 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8912 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8914 2011-03-27 Glenn Morris <rgm@gnu.org>
8916 * syssignal.h: Replace RETSIGTYPE with void.
8917 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8918 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8919 Replace SIGTYPE with void everywhere.
8920 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8921 * s/template.h (SIGTYPE): Remove commented out definition.
8923 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8925 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8926 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8928 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8930 * w32.c (read_unc_volume): Use parameter `henum', instead of
8931 global variable `wget_enum_handle'.
8933 * keymap.c (describe_vector): Remove parameters `indices' and
8934 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8935 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8937 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8939 * keyboard.c (timer_check): Remove parameter `do_it_now',
8940 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8941 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8942 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8944 * keyboard.c (read_char):
8945 * w32menu.c (w32_menu_display_help):
8946 * xmenu.c (show_help_event, menu_help_callback):
8947 Adjust calls to `show_help_echo'.
8949 * gtkutil.c (xg_maybe_add_timer):
8950 * keyboard.c (readable_events):
8951 * process.c (wait_reading_process_output):
8952 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8954 * insdel.c (adjust_markers_gap_motion):
8955 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8956 (gap_left, gap_right): Don't call it.
8958 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8960 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8961 incurred during fontification.
8963 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8965 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8966 (DEFVAR_PER_BUFFER): Don't pass it.
8968 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8969 (scrolling_window): Don't pass it.
8971 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8973 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8975 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8977 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8978 of variables specific to SELinux and computation of `encoded_absname'.
8980 * image.c (XPutPixel): Remove unused variable `height'.
8982 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8984 * unexw32.c (get_section_info): Remove unused variable `section'.
8986 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8987 (system_process_attributes): Remove unused variable `sess'.
8988 (sys_read): Remove unused variable `err'.
8990 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8991 (w32_wnd_proc): Remove unused variable `isdead'.
8992 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8993 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8994 (x_create_tip_frame): Remove unused variable `tem'.
8996 * w32inevt.c (w32_console_read_socket):
8997 Remove unused variable `no_events'.
8999 * w32term.c (x_draw_composite_glyph_string_foreground):
9000 Remove unused variable `width'.
9002 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9004 * w32term.c (x_set_glyph_string_clipping):
9005 Don't pass uninitialized region to CombineRgn.
9007 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9009 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9010 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9011 (Fx_close_connection): Remove unused variable `i'.
9013 * w32font.c (w32font_draw): Return number of glyphs.
9014 (w32font_open_internal): Remove unused variable `i'.
9015 (w32font_driver): Add missing initializer.
9017 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9018 (fill_in_menu): Remove unused variable `items_added'.
9020 * w32term.c (last_mouse_press_frame): Remove static global variable.
9021 (w32_clip_to_row): Remove unused variable `f'.
9022 (x_delete_terminal): Remove unused variable `i'.
9024 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9025 (NOTHING): Remove unused static global variable.
9026 (uniscribe_check_otf): Remove unused variable `table'.
9027 (uniscribe_font_driver): Add missing initializers.
9029 2011-03-23 Julien Danjou <julien@danjou.info>
9031 * term.c (Fsuspend_tty, Fresume_tty):
9032 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9033 * window.c (temp_output_buffer_show):
9034 * insdel.c (signal_before_change):
9035 * frame.c (Fhandle_switch_frame):
9036 * fileio.c (Fdo_auto_save):
9037 * emacs.c (Fkill_emacs):
9038 * editfns.c (save_excursion_restore):
9039 * cmds.c (internal_self_insert):
9040 * callint.c (Fcall_interactively):
9041 * buffer.c (Fkill_all_local_variables):
9042 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9044 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9045 unconditionally since it does the check itself.
9047 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9049 Fix more problems found by GCC 4.5.2's static checks.
9051 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9052 the first time through the loop, since we know p0 < p1 then.
9053 This also avoids a gcc -Wstrict-overflow warning.
9055 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9056 leading to a memory leak, possible in functions like
9057 load_charset_map_from_file that can allocate an unbounded number
9058 of objects (Bug#8318).
9060 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9061 that could (at least in theory) be that large.
9063 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9064 This is less likely to overflow, and avoids undefined behavior if
9065 overflow does occur. All callers changed. Use strtoul to scan
9066 for the unsigned long integer.
9067 (pint2hrstr): Simplify and tune code slightly.
9068 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9070 * scroll.c (do_scrolling): Work around GCC bug 48228.
9071 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9073 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9074 This also avoids a warning with gcc -Wstrict-overflow.
9075 (validate_x_resource_name): Simplify count usage.
9076 This also avoids a warning with gcc -Wstrict-overflow.
9078 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9081 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9083 * process.c (Fmake_network_process): Use socklen_t, not int,
9084 where POSIX says socklen_t is required in portable programs.
9085 This fixes a porting bug on hosts like 64-bit HP-UX, where
9086 socklen_t is wider than int (Bug#8277).
9087 (Fmake_network_process, server_accept_connection):
9088 (wait_reading_process_output, read_process_output):
9091 * process.c: Rename or move locals to avoid shadowing.
9092 (list_processes_1, Fmake_network_process):
9093 (read_process_output_error_handler, exec_sentinel_error_handler):
9094 Rename or move locals.
9095 (Fmake_network_process): Define label "retry_connect" only if needed.
9096 (Fnetwork_interface_info): Fix pointer signedness.
9097 (process_send_signal): Add cast to avoid pointer signedness problem.
9098 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9099 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9101 Make tparam.h and terminfo.c consistent.
9102 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9103 Include tparam.h instead, since it declares them.
9104 * cm.h (PC): Remove extern decl; tparam.h now does this.
9105 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9106 * terminfo.c: Include tparam.h, to check interfaces.
9107 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9108 (tparam): Adjust signature to match interface in tparam.h;
9109 this removes some undefined behavior. Check that outstring and len
9110 are zero, which they always are with Emacs.
9111 * tparam.h (PC, BC, UP): New extern decls.
9113 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9114 (xftfont_open): Rename locals to avoid shadowing.
9116 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9117 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9118 (OTF_TAG_SYM): Omit macro if not needed.
9119 (ftfont_list): Remove unused local.
9120 (get_adstyle_property, ftfont_pattern_entity):
9121 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9122 Rename locals to avoid shadowing.
9124 * xfont.c (xfont_list_family): Mark var as initialized.
9126 * xml.c (make_dom): Now static.
9128 * composite.c (composition_compute_stop_pos): Rename local to
9130 (composition_reseat_it): Remove unused locals.
9131 (find_automatic_composition, composition_adjust_point): Likewise.
9132 (composition_update_it): Mark var as initialized.
9133 (find_automatic_composition): Mark vars as initialized,
9134 with a FIXME (Bug#8290).
9136 character.h: Rename locals to avoid shadowing.
9137 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9138 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9139 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9140 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9143 * textprop.c (property_change_between_p): Remove; unused.
9145 * intervals.c (interval_start_pos): Now static.
9147 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9149 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9150 Rename locals to avoid shadowing.
9152 * sound.c (wav_play, au_play, Fplay_sound_internal):
9153 Fix pointer signedness.
9154 (alsa_choose_format): Remove unused local var.
9155 (wav_play): Initialize a variable to 0, to prevent undefined
9156 behavior (Bug#8278).
9158 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9160 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9162 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9163 clobbering (Bug#8298).
9164 * sysdep.c (sys_subshell): Likewise.
9165 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9167 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9168 This should get cleaned up, so that child_setup has the
9169 same signature on all platforms.
9171 * callproc.c (call_process_cleanup): Now static.
9172 (relocate_fd): Rename locals to avoid shadowing.
9174 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9176 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9177 not to be necessary, and produces flickering.
9179 2011-03-20 Glenn Morris <rgm@gnu.org>
9181 * config.in: Remove file.
9183 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9185 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9186 are now in src/globals.h.
9187 (syms_of_minibuf): Remove spurious & from previous change.
9189 2011-03-20 Leo Liu <sdl.web@gmail.com>
9191 * minibuf.c (completing-read-function): New variable.
9192 (completing-read-default): Rename from completing-read.
9193 (completing-read): Call completing-read-function.
9195 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9197 * xfaces.c (Fx_load_color_file):
9198 Read color file from absolute filename (bug#8250).
9200 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9202 * makefile.w32-in: Update dependencies.
9204 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9206 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9208 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9210 Fix more problems found by GCC 4.5.2's static checks.
9212 * process.c (make_serial_process_unwind, send_process_trap):
9213 (sigchld_handler): Now static.
9215 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9216 That way, the code declares only the vars that it needs.
9217 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9218 * s/cygwin.h (PTY_ITERATION): Likewise.
9219 * s/darwin.h (PTY_ITERATION): Likewise.
9220 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9222 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9223 * process.c (allocate_pty): Don't declare stb unless it's needed.
9225 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9226 (CONSTANTLIM): Remove; unused.
9227 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9228 Define only if needed.
9230 * unexelf.c (unexec): Name an expression,
9231 to avoid gcc -Wbad-function-cast warning.
9232 Use a different way to cause a compilation error if anyone uses
9233 n rather than nn, a way that does not involve shadowing.
9234 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9236 * deps.mk (unexalpha.o): Remove; unused.
9238 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9239 * unexec.h: New file.
9240 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9241 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9243 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9244 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9245 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9246 Change as necessary to match prototype in unexec.h.
9248 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9250 (back_comment, skip_chars): Mark vars as initialized.
9252 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9253 Rename locals to avoid shadowing.
9255 * lread.c (read1): Rewrite so as not to use empty "else".
9256 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9258 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9260 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9261 warning when compiling print.c.
9263 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9264 instead of using an uninitialized var.
9265 (font_sort_entities): Mark var as initialized.
9267 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9269 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9270 pointers to constants.
9271 (font_parse_fcname): Remove unused vars.
9272 (font_delete_unmatched): Now static.
9273 (font_get_spec): Remove; unused.
9274 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9275 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9276 Rename or move locals to avoid shadowing.
9278 * fns.c (require_nesting_list, require_unwind): Now static.
9279 (Ffillarray): Rename locals to avoid shadowing.
9281 * floatfns.c (domain_error2): Define only if needed.
9282 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9284 * alloc.c (mark_backtrace): Move decl from here ...
9285 * lisp.h: ... to here, so that it can be checked.
9287 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9288 (Fdefvar): Rewrite so as not to use empty "else".
9289 (lisp_indirect_variable): Name an expression,
9290 to avoid gcc -Wbad-function-cast warning.
9291 (Fdefvar): Rename locals to avoid shadowing.
9293 * callint.c (quotify_arg, quotify_args): Now static.
9294 (Fcall_interactively): Rename locals to avoid shadowing.
9295 Use const pointer when appropriate.
9297 * lisp.h (get_system_name, get_operating_system_release):
9298 Move decls here, to check interfaces.
9299 * process.c (get_operating_system_release): Move decl to lisp.h.
9300 * xrdb.c (get_system_name): Likewise.
9301 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9302 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9303 some of which prompt warnings from gcc -Wbad-function-cast.
9304 (Fformat_time_string, Fencode_time, Finsert_char):
9305 (Ftranslate_region_internal, Fformat):
9306 Rename or remove local vars to avoid shadowing.
9307 (Ftranslate_region_internal): Mark var as initialized.
9309 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9312 * lisp.h (eassert): Check that the argument compiles, even if
9313 ENABLE_CHECKING is not defined.
9315 * data.c (Findirect_variable): Name an expression, to avoid
9316 gcc -Wbad-function-cast warning.
9317 (default_value, arithcompare, arith_driver, arith_error): Now static.
9318 (store_symval_forwarding): Rename local to avoid shadowing.
9319 (Fmake_variable_buffer_local, Fmake_local_variable):
9320 Mark variables as initialized.
9321 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9323 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9324 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9325 Rename locals to avoid shadowing.
9326 (mark_stack): Move local variables into the #ifdef region where
9328 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9329 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9331 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9332 (GC_STRING_CHARS): Remove; not used.
9333 (Fmemory_limit): Cast sbrk's returned value to char *.
9335 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9336 avoids undefined behavior in theory.
9338 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9340 Use functions, not macros, for up- and down-casing (Bug#8254).
9341 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9342 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9343 to use the following functions instead of these macros.
9344 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9345 EMACS_INT, since callers assume the returned value fits in int.
9346 (upcase1): Likewise, for UPCASE_TABLE.
9347 (uppercasep, lowercasep, upcase): New static inline functions.
9348 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9349 the race-condition problem in the old DOWNCASE.
9351 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9352 Rename locals to avoid shadowing.
9353 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9354 (regex_compile, re_search_2, re_match_2_internal):
9355 Remove unused local vars.
9356 (FREE_VAR): Rewrite so as not to use empty "else",
9357 which gcc can warn about.
9358 (regex_compile, re_match_2_internal): Mark locals as initialized.
9359 (RETALLOC_IF): Define only if needed.
9360 (WORDCHAR_P): Likewise. This one is never needed, but is used
9361 only in a comment talking about a compiler bug, so put inside
9362 the #if 0 of that comment.
9363 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9364 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9367 * search.c (boyer_moore): Rename locals to avoid shadowing.
9368 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9369 (PREV_CHAR_BOUNDARY): Likewise.
9371 * search.c (simple_search): Remove unused var.
9373 * dired.c (compile_pattern): Move decl from here ...
9374 * lisp.h: ... to here, so that it can be checked.
9375 (struct re_registers): New forward decl.
9377 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9379 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9381 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9382 Rename locals to avoid shadowing.
9383 (Fvertical_motion): Mark locals as initialized.
9385 * casefiddle.c (casify_object, casify_region): Now static.
9386 (casify_region): Mark local as initialized.
9388 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9390 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9391 New macros, so that the caller can use some names other than
9392 gcpro1, gcpro2, etc.
9393 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9395 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9396 argument, for consistency with GCPRO2_VAR, etc: it is now the
9397 prefix of the variable, not the variable itself. All uses
9399 * dired.c (directory_files_internal, file_name_completion):
9400 Rename locals to avoid shadowing.
9402 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9403 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9404 dired.c's scmp function, had undefined behavior.
9405 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9406 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9407 * buffer.h: ... to here, because these macros use current_buffer,
9408 and the new implementation with inline functions needs to have
9409 current_buffer in scope now, rather than later when the macros
9411 (downcase, upcase1): New static inline functions.
9412 (DOWNCASE, UPCASE1): Reimplement using these functions.
9413 This avoids undefined behavior in expressions like
9414 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9415 from race conditions in accessing the global variables
9416 case_temp1 and case_temp2.
9417 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9418 * lisp.h (case_temp1, case_temp2): Remove their decls.
9419 * character.h (ASCII_CHAR_P): Move from here ...
9420 * lisp.h: ... to here, so that the inline functions mentioned
9423 * dired.c (directory_files_internal_unwind): Now static.
9425 * fileio.c (file_name_as_directory, directory_file_name):
9426 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9428 (file_name_as_directory): Use const pointers when appropriate.
9429 (Fexpand_file_name): Likewise. In particular, newdir might
9430 point at constant storage, so make it a const pointer.
9431 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9432 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9434 (Fset_file_times, Finsert_file_contents, auto_save_error):
9435 Rename locals to avoid shadowing.
9437 * minibuf.c (choose_minibuf_frame_1): Now static.
9438 (Ftry_completion, Fall_completions): Rename or remove locals
9441 * marker.c (bytepos_to_charpos): Remove; unused.
9443 * lisp.h (verify_bytepos, count_markers): New decls,
9444 so that gcc does not warn that these functions aren't declared.
9446 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9447 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9448 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9449 (copy_text): Remove unused local var.
9451 * filelock.c (within_one_second): Now static.
9452 (lock_file_1): Rename local to avoid shadowing.
9454 * buffer.c (fix_overlays_before): Mark locals as initialized.
9455 (fix_start_end_in_overlays): Likewise. This function should be
9456 simplified by using pointers-to-pointers, but that's a different
9458 (switch_to_buffer_1): Now static.
9459 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9460 (report_overlay_modification): Rename locals to avoid shadowing.
9462 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9463 Fix pointer signedness issue.
9464 (sys_subshell): Mark local as volatile if checking for lint,
9465 to suppress a gcc -Wclobbered warning that does not seem to be right.
9466 (MAXPATHLEN): Define only if needed.
9468 * process.c (serial_open, serial_configure): Move decls from here ...
9469 * systty.h: ... to here, so that they can be checked.
9471 * fns.c (get_random, seed_random): Move extern decls from here ...
9472 * lisp.h: ... to here, so that they can be checked.
9474 * sysdep.c (reset_io): Now static.
9475 (wait_for_termination_signal): Remove; unused.
9477 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9478 (copy_keymap_item, append_key, push_text_char_description):
9480 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9481 (DENSE_TABLE_SIZE): Remove; unused.
9482 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9483 (describe_map_tree):
9484 Rename locals to avoid shadowing.
9486 * keyboard.c: Declare functions static if they are not used elsewhere.
9487 (echo_char, echo_dash, cmd_error, top_level_2):
9488 (poll_for_input, handle_async_input): Now static.
9489 (read_char, kbd_buffer_get_event, make_lispy_position):
9490 (make_lispy_event, make_lispy_movement, apply_modifiers):
9491 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9492 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9493 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9494 (read_key_sequence, read_char): Mark locals as initialized.
9495 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9497 * keyboard.h (make_ctrl_char): New decl.
9498 (mark_kboards): Move decl here ...
9499 * alloc.c (mark_kboards): ... from here.
9501 * lisp.h (force_auto_save_soon): New decl.
9503 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9504 (DEFINE_DUMMY_FUNCTION): New macro.
9505 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9507 (main): Add casts to avoid warnings
9508 if GCC considers string literals to be constants.
9510 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9512 * dbusbind.c: Pointer signedness fixes.
9513 (xd_signature, xd_append_arg, xd_initialize):
9514 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9515 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9516 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9517 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9519 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9520 if GCC considers string literals to be constants.
9521 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9523 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9525 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9526 (print_preprocess, print_object): New macro to fix last change.
9528 * print.c (print_preprocess): Don't forget font objects.
9530 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9532 * emacs.c (USAGE3): Doc fixes.
9534 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9536 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9539 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9541 * lisp.h (VWindow_system, Qfile_name_history):
9542 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9543 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9544 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9546 * w32select.c: Don't #include "keyboard.h".
9547 (run_protected): Add extern declaration for waiting_for_input.
9549 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9550 * w32console.c (detect_input_pending, read_input_pending)
9551 (encode_terminal_code):
9552 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9553 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9554 (w32_system_caret_y, Qfile_name_history):
9555 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9556 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9557 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9558 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9559 * w32proc.c (Qlocal, report_file_error):
9560 * w32term.c (Vwindow_system, updating_frame):
9561 * w32uniscribe.c (initialized, uniscribe_font_driver):
9562 Remove unneeded extern declarations.
9564 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9566 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9568 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9570 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9571 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9572 These macros can no longer be used for assignment.
9574 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9575 Assign struct members directly, instead of using BUF_BEGV etc.
9576 (record_buffer_markers, fetch_buffer_markers): New functions for
9577 recording and fetching special buffer markers.
9578 (set_buffer_internal_1, set_buffer_temp): Use them.
9580 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9582 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9584 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9585 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9587 * xdisp.c (hscroll_window_tree):
9588 (reconsider_clip_changes): Use PT instead of BUF_PT.
9590 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9592 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9593 $(EMACS_ROOT)/lib/intprops.h.
9595 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9597 Fix more problems found by GCC 4.5.2's static checks.
9599 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9600 to unsigned char * to avoid compiler diagnostic.
9601 (xg_free_frame_widgets): Make it clear that a local variable is
9602 needed only if USE_GTK_TOOLTIP.
9603 (gdk_window_get_screen): Make it clear that this macro is needed
9604 only if USE_GTK_TOOLTIP.
9605 (int_gtk_range_get_value): New function, which avoids a diagnostic
9606 from gcc -Wbad-function-cast.
9607 (xg_set_toolkit_scroll_bar_thumb): Use it.
9608 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9609 diagnostic from gcc -Wbad-function-cast.
9610 (get_utf8_string, xg_get_file_with_chooser):
9611 Rename locals to avoid shadowing.
9612 (create_dialog): Move locals to avoid shadowing.
9614 * xgselect.c (xg_select): Remove unused var.
9616 * image.c (four_corners_best): Mark locals as initialized.
9617 (gif_load): Initialize transparent_p to zero (Bug#8238).
9618 Mark another local as initialized.
9619 (my_png_error, my_error_exit): Mark with NO_RETURN.
9621 * image.c (clear_image_cache): Now static.
9622 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9623 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9624 (x_edge_detection): Remove unnecessary cast that
9625 gcc -Wbad-function-cast diagnoses.
9626 (gif_load): Fix pointer signedness.
9627 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9628 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9630 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9632 Improve quality of tests for time stamp overflow.
9633 For example, without this patch (encode-time 0 0 0 1 1
9634 1152921504606846976) returns the obviously-bogus value (-948597
9635 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9636 reports time overflow. See
9637 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9638 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9639 * editfns.c: Include limits.h and intprops.h.
9640 (TIME_T_MIN, TIME_T_MAX): New macros.
9641 (time_overflow): Move earlier, to before first use.
9642 (hi_time, lo_time): New functions, for an accurate test for
9644 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9645 (Fget_internal_run_time): Don't assume time_t fits in int.
9646 (make_time): Use list2 instead of Fcons twice.
9647 (Fdecode_time): More accurate test for out-of-range times.
9648 (check_tm_member): New function.
9649 (Fencode_time): Use it, to test for out-of-range times.
9650 (lisp_time_argument): Don't rely on undefined left-shift and
9651 right-shift behavior when checking for time stamp overflow.
9653 * editfns.c (time_overflow): New function, refactoring common code.
9654 (Fformat_time_string, Fdecode_time, Fencode_time):
9655 (Fcurrent_time_string): Use it.
9657 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9658 * dired.c (make_time): Move to ...
9659 * editfns.c (make_time): ... here.
9660 * systime.h: Note the move.
9662 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9664 * fringe.c (update_window_fringes): Remove unused variables.
9666 * unexmacosx.c (copy_data_segment): Also copy __got section.
9669 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9671 * termcap.c [MSDOS]: Include "msdos.h".
9672 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9673 Constify `char *' arguments and their references according to
9674 prototypes in tparam.h.
9676 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9678 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9679 Adapt all references accordingly.
9681 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9683 2011-03-11 Tom Tromey <tromey@redhat.com>
9685 * buffer.c (syms_of_buffer): Remove obsolete comment.
9687 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9689 * termhooks.h (encode_terminal_code): Declare prototype.
9691 * msdos.c (encode_terminal_code): Don't declare prototype.
9693 * term.c (encode_terminal_code): Now external again, used by
9694 w32console.c and msdos.c.
9696 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9697 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9699 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9701 Fix some minor problems found by GCC 4.5.2's static checks.
9703 * fringe.c (update_window_fringes): Mark locals as initialized
9705 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9707 * alloc.c (mark_fringe_data): Move decl from here ...
9708 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9709 to check its interface.
9710 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9712 * fontset.c (free_realized_fontset): Now static.
9713 (Fset_fontset_font): Rename local to avoid shadowing.
9714 (fontset_font): Mark local as initialized.
9715 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9717 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9719 * xselect.c (x_disown_buffer_selections): Remove; not used.
9720 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9721 (x_own_selection, Fx_disown_selection_internal): Rename locals
9723 (x_handle_dnd_message): Remove local to avoid shadowing.
9725 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9726 so that the caller can use some name other than gcpro1.
9727 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9728 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9729 (Fx_backspace_delete_keys_p):
9730 Use them to avoid shadowing, and rename vars to avoid shadowing.
9731 (x_decode_color, x_set_name, x_window): Now static.
9732 (Fx_create_frame): Add braces to silence GCC warning.
9733 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9734 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9735 Remove unused locals.
9736 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9737 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9738 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9741 * xterm.h (x_mouse_leave): New decl.
9743 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9744 Remove unused functions.
9745 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9746 (x_calc_absolute_position): Now static.
9747 (XTread_socket): Don't define label "out" unless it's used.
9748 Don't declare local "event" unless it's used.
9749 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9750 unless they are used.
9751 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9752 (x_fatal_error_signal): Remove; not used.
9753 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9754 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9755 (x_error_catcher, x_connection_closed, x_error_handler):
9756 (x_error_quitter, xembed_send_message, x_iconify_frame):
9757 (my_log_handler): Rename locals to avoid shadowing.
9758 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9759 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9761 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9762 Rename or move locals to avoid shadowing.
9763 (tty_defined_color, merge_face_heights): Now static.
9764 (free_realized_faces_for_fontset): Remove; not used.
9765 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9766 does not deduce is never used uninitialized.
9767 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9768 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9770 * terminal.c (store_terminal_param): Now static.
9772 * xmenu.c (menu_highlight_callback): Now static.
9773 (set_frame_menubar): Remove unused local.
9774 (xmenu_show): Rename parameter to avoid shadowing.
9775 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9776 since they might point to immutable storage.
9777 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9778 since it's unused otherwise.
9780 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9781 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9782 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9783 avoids a gcc -Wuninitialized diagnostic.
9784 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9785 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9786 does not deduce are never used uninitialized.
9788 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9790 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9791 * window.c (window_loop, size_window):
9792 (run_window_configuration_change_hook, enlarge_window): Likewise.
9794 * window.c (display_buffer): Now static.
9795 (size_window): Mark variables that gcc -Wuninitialized
9796 does not deduce are never used uninitialized.
9797 * window.h (check_all_windows): New decl, to forestall
9798 gcc -Wmissing-prototypes diagnostic.
9799 * dispextern.h (bidi_dump_cached_states): Likewise.
9801 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9803 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9805 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9806 and to avoid gcc -Wuninitialized warning.
9807 (load_charset_map): Mark variables that gcc -Wuninitialized
9808 does not deduce are never used uninitialized.
9809 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9811 * coding.c (coding_set_source, coding_set_destination):
9812 Use "else { /* comment */ }" rather than "else /* comment */;"
9813 for clarity, and to avoid gcc -Wempty-body warning.
9814 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9815 a block, when the outer 'i' will do.
9816 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9817 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9818 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9819 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9820 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9821 Rename locals to avoid shadowing.
9822 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9823 * coding.c (emacs_mule_char, encode_invocation_designation):
9824 Now static, since they're not used elsewhere.
9825 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9826 (decode_coding_object, encode_coding_object, detect_coding_system):
9827 (decode_coding_emacs_mule): Mark variables that gcc
9828 -Wuninitialized does not deduce are never used uninitialized.
9829 (detect_coding_iso_2022): Initialize a local variable that might
9830 be used uninitialized. Leave a FIXME because it's not clear that
9831 this initialization is needed. (Bug#8211)
9832 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9833 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9834 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9835 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9836 Remove unused macros.
9838 * category.c (hash_get_category_set): Remove unused local var.
9839 (copy_category_table): Now static, since it's not used elsewhere.
9840 * character.c (string_count_byte8): Likewise.
9842 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9843 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9845 * chartab.c (copy_sub_char_table): Now static, since it's not used
9847 (sub_char_table_ref_and_range, char_table_ref_and_range):
9848 Rename locals to avoid shadowing.
9849 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9851 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9852 (BIDI_BOB): Remove unused macro.
9854 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9855 deduce are never used uninitialized.
9856 * term.c (encode_terminal_code): Likewise.
9858 * term.c (encode_terminal_code): Now static. Remove unused local.
9860 * tparam.h: New file.
9861 * term.c, tparam.h: Include it.
9862 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9863 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9864 Move these decls to tparam.h, and make them agree with what
9865 is actually in tparam.c. The previous trick of using incompatible
9866 decls in different modules does not conform to the C standard.
9867 All callers of tparam changed to use tparam's actual API.
9868 * tparam.c (tparam1, tparam, tgoto):
9869 Use const pointers where appropriate.
9871 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9872 * cm.h (struct cm): Likewise.
9873 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9874 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9875 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9876 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9877 (turn_on_face, init_tty): Likewise.
9878 * termchar.h (struct tty_display_info): Likewise.
9880 * term.c (term_mouse_position): Rename local to avoid shadowing.
9882 * alloc.c (mark_ttys): Move decl from here ...
9883 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9885 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9887 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9889 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9891 * search.c (compile_pattern_1): Remove argument regp, unused since
9892 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9893 (compile_pattern): Don't pass it.
9895 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9897 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9898 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9900 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9902 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9904 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9905 gdk_window_get_screen, gdk_window_get_geometry,
9906 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9907 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9908 (xg_get_pixbuf_from_pixmap): New function.
9909 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9910 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9911 Call xg_get_pixbuf_from_pixmap instead of
9912 gdk_pixbuf_get_from_drawable.
9913 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9914 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9915 (xg_check_special_colors): Use GtkStyleContext and its functions
9917 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9918 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9919 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9920 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9921 Call gtk_widget_get_preferred_size.
9922 (xg_frame_resized): gdk_window_get_geometry only takes 5
9924 (xg_win_to_widget, xg_event_is_for_menubar):
9925 Call gdk_x11_window_lookup_for_display.
9926 (xg_set_widget_bg): New function.
9927 (delete_cb): New function.
9928 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9929 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9930 (xg_set_background_color): Call xg_set_widget_bg.
9931 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9932 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9933 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9934 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9936 (update_frame_tool_bar): Call gtk_widget_hide.
9937 (xg_initialize): Use GDK_KEY_g.
9939 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9941 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9943 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9944 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9945 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9947 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9949 * w32xfns.c (select_palette): Check success of RealizePalette against
9950 GDI_ERROR, not zero.
9952 See ChangeLog.11 for earlier changes.
9958 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9960 This file is part of GNU Emacs.
9962 GNU Emacs is free software: you can redistribute it and/or modify
9963 it under the terms of the GNU General Public License as published by
9964 the Free Software Foundation, either version 3 of the License, or
9965 (at your option) any later version.
9967 GNU Emacs is distributed in the hope that it will be useful,
9968 but WITHOUT ANY WARRANTY; without even the implied warranty of
9969 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9970 GNU General Public License for more details.
9972 You should have received a copy of the GNU General Public License
9973 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.