]> code.delx.au - gnu-emacs/blob - src/ChangeLog
ecomplete.el (ecomplete-display-matches): Intercept key sequence from terminal as...
[gnu-emacs] / src / ChangeLog
1 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4 the xassert test.
5
6 * dispextern.h (struct it): Update the comment documenting what
7 can it->OBJECT be.
8
9 2011-09-20 Eli Zaretskii <eliz@gnu.org>
10
11 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
12 a display string, extend search for cursor position to end of row.
13 (find_row_edges): If the row ends in a newline from a display
14 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
15 Handle the case of a display string with multiple newlines.
16 (Fcurrent_bidi_paragraph_direction): Fix search for previous
17 non-empty line. Fixes confusing cursor motion with arrow keys at
18 the beginning of a line that starts with whitespace.
19
20 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
21
22 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
23 (bug#9493).
24
25 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
26
27 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
28 boolean (Bug#9154).
29
30 2011-09-18 Eli Zaretskii <eliz@gnu.org>
31
32 * xdisp.c (display_line): Record maximum and minimum buffer
33 positions even if no glyphs were produced (e.g., by a zero-width
34 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
35 buffer positions that will be removed from the glyph row because
36 they don't fit.
37 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
38 column is beyond frame width: don't subtract 1 "pixel" when
39 computing width of the stretch.
40 (reseat_at_next_visible_line_start): Undo the change made on
41 2011-09-17 that saved paragraph information and restored it after
42 the call to `reseat'. (Bug#9545)
43
44 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
45
46 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
47 and turn window cursor on if cleared (Bug#9415).
48
49 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
50
51 * search.c (boyer_moore): Take unibyte characters from pattern
52 literally. (Bug#9458)
53
54 2011-09-18 Eli Zaretskii <eliz@gnu.org>
55
56 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
57
58 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
59
60 Fix minor problem found by static checking.
61 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
62 initialized, to pacify gcc -Wuninitialized.
63
64 * fileio.c: Report proper errno when syscall falls.
65 (Finsert_file_contents): Save and restore errno,
66 so that report_file_error outputs the correct diagnostic.
67 (Fwrite_region) [CLASH_DETECTION]: Likewise.
68
69 2011-09-18 Eli Zaretskii <eliz@gnu.org>
70
71 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
72
73 2011-09-17 Eli Zaretskii <eliz@gnu.org>
74
75 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
76 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
77
78 2011-09-17 Eli Zaretskii <eliz@gnu.org>
79
80 * xdisp.c (reseat_at_next_visible_line_start): Keep information
81 about the current paragraph and restore it after the call to
82 reseat.
83
84 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
85 (bidi_find_paragraph_start): Search back for paragraph beginning
86 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
87 (bidi_move_to_visually_next): Only trigger paragraph-related
88 computations when the last character is a newline or at EOB, not
89 just any NEUTRAL_B. (Bug#9470)
90
91 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
92 truncated lines if point is covered by a display string. (Bug#9524)
93
94 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
95
96 * xselect.c: Relax test for outgoing X longs (Bug#9498).
97 (cons_to_x_long): New function.
98 (lisp_data_to_selection_data): Use it. Correct the test for
99 short-versus-long data; it was negated. Break out of vector
100 loop, for efficiency, when a long datum is discovered.
101
102 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
103
104 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
105
106 2011-09-16 Eli Zaretskii <eliz@gnu.org>
107
108 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
109 GCC PR/17406) by declaring this function with external scope.
110
111 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
112
113 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
114 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
115
116 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
117
118 * editfns.c (Fformat): Correctly handle text properties on "%%".
119
120 2011-09-15 Eli Zaretskii <eliz@gnu.org>
121
122 * xterm.c (x_draw_composite_glyph_string_foreground):
123 * w32term.c (x_draw_composite_glyph_string_foreground):
124 * term.c (encode_terminal_code):
125 * composite.c (composition_update_it, get_composition_id):
126 * xdisp.c (get_next_display_element)
127 (fill_composite_glyph_string): Add comments about special meaning
128 of TAB characters in a composition.
129
130 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
131
132 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
133 This occurs when processing a multibyte format.
134 Problem reported by Wolfgang Jenker.
135
136 2011-09-15 Johan Bockgård <bojohan@gnu.org>
137
138 * xdisp.c (try_cursor_movement): Only check for exact match if
139 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
140
141 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
142
143 Remove unused external symbols.
144 * dispextern.h (calc_pixel_width_or_height): Remove decl.
145 * xdisp.c (calc_pixel_width_or_height): Now static.
146 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
147 * indent.c (check_display_width):
148 * w32term.c: Fix comment to match code.
149 * xterm.c, xterm.h (x_catching_errors): Remove.
150
151 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
152
153 * xselect.c: Use signed conversions more consistently (Bug#9498).
154 (selection_data_to_lisp_data): Assume incoming selection data are
155 signed integers, not unsigned. This is to be consistent with
156 outgoing selection data, which was modified to use signed integers
157 in as part of the fix to Bug#9196 in response to Jan D.'s comment
158 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
159 expects long, not unsigned long.
160
161 2011-09-14 Eli Zaretskii <eliz@gnu.org>
162
163 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
164 computation of loop end. Reported by Johan Bockgård
165 <bojohan@gnu.org>.
166
167 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
168
169 * frame.c (Fother_visible_frames_p): Function deleted.
170
171 2011-09-12 Eli Zaretskii <eliz@gnu.org>
172
173 * indent.c (compute_motion): Process display vector front to back
174 rather than the other way around. (Bug#2496)
175
176 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
177
178 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
179
180 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
181
182 * minibuf.c (Fread_from_minibuffer): Doc fix.
183
184 2011-09-11 Eli Zaretskii <eliz@gnu.org>
185
186 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
187 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
188
189 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
190
191 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
192 value for non-existent files.
193
194 2011-09-11 Eli Zaretskii <eliz@gnu.org>
195
196 * fileio.c (Finsert_file_contents): If the file cannot be opened,
197 set its "size" to -1. This will set the modtime_size field of
198 the corresponding buffer to -1, which is what
199 verify-visited-file-modtime expects for files that do not exist.
200 (Bug#9139)
201
202 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
203
204 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
205 here ...
206 * lisp.h: ... from here. push_key_description is no longer
207 defined in keyboard.c, so its declaration should not be in
208 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
209 logically belongs with push_key_description.
210
211 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
212
213 * buffer.h: Include <sys/types.h> instead of <time.h>.
214 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
215 Problem reported by Herbert J. Skuhra.
216
217 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
218
219 * xml.c (parse_region): Make the parsing work for
220 non-comment-starting XML files again (bug#9144).
221
222 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
223
224 * image.c (gif_load): Fix calculation of bottom and right corner.
225 (Bug#9468)
226
227 2011-09-10 Eli Zaretskii <eliz@gnu.org>
228
229 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
230 redisplay in small windows.
231
232 2011-09-09 Eli Zaretskii <eliz@gnu.org>
233
234 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
235
236 2011-09-08 Martin Rudalics <rudalics@gmx.at>
237
238 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
239 Operate on live windows only.
240
241 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
242
243 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
244
245 2011-09-07 Eli Zaretskii <eliz@gnu.org>
246
247 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
248 only under bidi iteration.
249
250 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
251
252 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
253
254 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
255
256 isnan: Fix porting problem to Solaris 10 with bundled gcc.
257 Without this fix, the command to link temacs failed due to an
258 undefined symbol __builtin_isnan. This is because
259 /usr/include/iso/math_c99.h #defines isnan(x) to
260 __builtin_isnan(x), but the bundled gcc, which identifies itself
261 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
262 a __builtin_isnan.
263 * floatfns.c (isnan): #undef, and then #define to a clone of
264 what's in data.c.
265 (Fisnan): Always define, since it's always available now.
266 (syms_of_floatfns): Always define isnan at the Lisp level.
267
268 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
269
270 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
271
272 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
273
274 * fileio.c: Fix bugs with large file offsets (Bug#9428).
275 The previous code assumed that file offsets (off_t values) fit in
276 EMACS_INT variables, which is not true on typical 32-bit hosts.
277 The code messed up by falsely reporting buffer overflow in cases
278 such as (insert-file-contents "big" nil 1 2) into an empty buffer
279 when "big" contains more than 2**29 bytes, even though this
280 inserts just one byte and does not overflow the buffer.
281 (Finsert_file_contents): Store file offsets as off_t
282 values, not as EMACS_INT values. Check for overflow when
283 converting between EMACS_INT and off_t. When checking for
284 buffer overflow or for overlap, take the offsets into account.
285 Don't use EMACS_INT for small values where int suffices.
286 When checking for overlap, fix a typo: ZV was used where
287 ZV_BYTE was intended.
288 (Fwrite_region): Don't assume off_t fits into 'long'.
289 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
290
291 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
292
293 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
294
295 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
296
297 sprintf-related integer and memory overflow issues (Bug#9412).
298
299 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
300 (esprintf, exprintf, evxprintf): New functions.
301 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
302 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
303 (modify_event_symbol): Do not assume that the length of
304 name_alist_or_stem is safe to alloca and fits in int.
305 (Fexecute_extended_command): Likewise for function name and binding.
306 (Frecursion_depth): Wrap around reliably on integer overflow.
307 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
308 since some callers pass EMACS_INT values.
309 (Fsingle_key_description): Don't crash if symbol name contains more
310 than MAX_ALLOCA bytes.
311 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
312 (get_minibuffer): Arg is now EMACS_INT, not int.
313 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
314 (esprintf, exprintf, evxprintf): New decls.
315 * window.h (command_loop_level, minibuf_level): Reflect API changes.
316
317 * dbusbind.c (signature_cat): New function.
318 (xd_signature, Fdbus_register_signal):
319 Do not overrun buffer; instead, report string overflow.
320
321 * dispnew.c (add_window_display_history): Don't overrun buffer.
322 Truncate instead; this is OK since it's just a log.
323
324 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
325 even if the time zone offset is outlandishly large.
326 Don't mishandle offset == INT_MIN.
327
328 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
329 when creating daemon; the previous buffer-overflow check was incorrect.
330
331 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
332 which has the guts of the old verror function.
333
334 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
335 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
336
337 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
338 (font_unparse_xlfd): Don't blindly alloca long strings.
339 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
340 fits in int, when using sprintf. Use single snprintf to count
341 length of string rather than counting it via multiple sprintfs;
342 that's simpler and more reliable.
343 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
344 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
345 sprintf, in case result does not fit in int.
346
347 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
348 (fontset_from_font): Print it.
349
350 * frame.c (tty_frame_count): Now printmax_t, not int.
351 (make_terminal_frame, set_term_frame_name): Print it.
352 (x_report_frame_params): In X, window IDs are unsigned long,
353 not signed long, so print them as unsigned.
354 (validate_x_resource_name): Check for implausibly long names,
355 and don't assume name length fits in 'int'.
356 (x_get_resource_string): Don't blindly alloca invocation name;
357 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
358 not fit in int.
359
360 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
361 (xg_check_special_colors, xg_set_geometry):
362 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
363
364 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
365 Use esprintf, not sprintf, in case result does not fit in int.
366
367 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
368 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
369 it as a large positive number.
370 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
371 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
372
373 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
374 in case result does not fit in int.
375
376 * print.c (float_to_string): Detect width overflow more reliably.
377 (print_object): Make sprintf buffer a bit bigger, to avoid potential
378 buffer overrun. Don't assume list length fits in 'int'. Treat
379 print length of 0 as 0, not as infinity; to be consistent with other
380 uses of print length in this function. Don't overflow print length
381 index. Don't assume hash table size fits in 'long', or that
382 vectorlike size fits in 'unsigned long'.
383
384 * process.c (make_process): Use printmax_t, not int, to format
385 process-name gensyms.
386
387 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
388
389 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
390 to avoid potential buffer overrun.
391
392 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
393 if X resource line is longer than 512 bytes.
394
395 * xfns.c (x_window): Make sprintf buffer a bit bigger
396 to avoid potential buffer overrun.
397
398 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
399
400 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
401
402 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
403
404 Integer overflow fixes for scrolling, etc.
405 Without these, Emacs silently mishandles large integers sometimes.
406 For example, "C-u 4294967297 M-x recenter" was treated as if
407 it were "C-u 1 M-x recenter" on a typical 64-bit host.
408
409 * xdisp.c (try_window_id): Check Emacs fixnum range before
410 converting to 'int'.
411
412 * window.c (window_scroll_line_based, Frecenter):
413 Check that an Emacs fixnum is in range before assigning it to 'int'.
414 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
415 values converted from Emacs fixnums.
416 (Frecenter): Don't wrap around a line count if it is out of 'int'
417 range; instead, treat it as an extreme value.
418 (Fset_window_configuration, compare_window_configurations):
419 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
420
421 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
422 that can exceed INT_MAX. Check that EMACS_INT value is in range
423 before assigning it to the (possibly-narrower) index.
424 (match_limit): Don't assume that a fixnum can fit in 'int'.
425
426 * print.c (print_object): Use ptrdiff_t, not int, for index that can
427 exceed INT_MAX.
428
429 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
430 (Fvertical_motion): Don't wrap around LINES values that don't fit
431 in 'int'. Instead, treat them as extreme values. This is good
432 enough for windows, which can't have more than INT_MAX lines anyway.
433
434 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
435
436 * Require libxml/parser.h to avoid compilation warning.
437
438 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
439
440 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
441 since this reportedly can destroy thread storage.
442
443 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
444
445 * syntax.c (find_defun_start): Update all cache variables if
446 exiting early (Bug#9401).
447
448 2011-08-30 Eli Zaretskii <eliz@gnu.org>
449
450 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
451
452 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
453 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
454 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
455
456 * term.c (tty_append_glyph): New function.
457 (produce_stretch_glyph): Static function and its prototype deleted.
458
459 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
460 prototypes.
461
462 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
463
464 * image.c (parse_image_spec): Check for nonnegative, not for positive,
465 when checking :margin (Bug#9390).
466 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
467 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
468 so that the name doesn't mislead. All uses changed.
469
470 2011-08-28 Johan Bockgård <bojohan@gnu.org>
471
472 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
473 set_tty_hooks.
474
475 2011-08-27 Eli Zaretskii <eliz@gnu.org>
476
477 * xdisp.c (move_it_to): Don't bail out early when reaching
478 position beyond to_charpos, if we are scanning backwards.
479 (move_it_vertically_backward): When DY == 0, make sure we get to
480 the first character in the line after the newline.
481
482 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
483
484 * ccl.c: Improve and simplify overflow checking (Bug#9196).
485 (ccl_driver): Do not generate an out-of-range pointer.
486 (Fccl_execute_on_string): Remove unnecessary check for
487 integer overflow, noted by Stefan Monnier in
488 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
489 Remove a FIXME that didn't need fixing.
490 Simplify the newly-introduced buffer reallocation code.
491
492 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
493
494 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
495
496 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
497
498 Integer and memory overflow issues (Bug#9196).
499
500 * doc.c (get_doc_string): Rework so that
501 get_doc_string_buffer_size is the actual buffer size, rather than
502 being 1 less than the actual buffer size; this makes xpalloc more
503 convenient.
504
505 * image.c (x_allocate_bitmap_record, cache_image):
506 * xselect.c (Fx_register_dnd_atom):
507 Simplify previous changes by using xpalloc.
508
509 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
510 since either will do and ptrdiff_t is convenient with xpalloc.
511
512 * charset.c (charset_table_size)
513 (struct charset_sort_data.priority): Now ptrdiff_t.
514 (charset_compare): Don't overflow if priorities differ greatly.
515 (Fsort_charsets): Don't assume list length fits in int.
516 Check for size-calculation overflow when allocating sort data.
517 (syms_of_charset): Allocate an initial charset table that is
518 just under 64 KiB, to avoid problems with glibc malloc and mmap.
519
520 * cmds.c (internal_self_insert): Check for size-calculation overflow.
521
522 * composite.h (struct composition.glyph_len): Now int, not unsigned.
523 The actual value is always <= INT_MAX, and leaving it unsigned made
524 overflow checking harder.
525
526 * dispextern.h (struct glyph_matrix.rows_allocated)
527 (struct face_cache.size): Now ptrdiff_t, for convenience in use
528 with xpalloc. The values are still always <= INT_MAX.
529
530 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
531
532 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
533 (SAFE_NALLOCA): New macro.
534
535 * region-cache.c (struct boundary.pos, find_cache_boundary)
536 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
537 (set_cache_region, invalidate_region_cache)
538 (revalidate_region_cache, know_region_cache, region_cache_forward)
539 (region_cache_backward, pp_cache):
540 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
541 so that ptrdiff_t * can be passed to xpalloc.
542 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
543 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
544 (pp_cache): Don't assume cache_len fits in int.
545 * region-cache.h: Adjust extern decls to match.
546
547 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
548 EMACS_INT, since either will do, for xpalloc.
549
550 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
551 (xnmalloc, xnrealloc, xpalloc): New functions.
552
553 * bidi.c (bidi_shelve_header_size): New constant.
554 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
555 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
556
557 * bidi.c (bidi_cache_shrink):
558 * buffer.c (overlays_at, overlays_in, record_overlay_string)
559 (overlay_strings):
560 Don't update size of array until after memory allocation succeeds,
561 because xmalloc/xrealloc may not return.
562 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
563 now that we have proper integer overflow checking.
564 (record_overlay_string, overlay_strings): Catch overflows when
565 calculating size of overlay_str_buf.
566
567 * callproc.c (Fcall_process): Check for size overflow when
568 calculating size of args2.
569 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
570 Normally we prefer signed values, but sticking with ptrdiff_t would
571 require adding more-complicated checks.
572
573 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
574 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
575 Redo buffer-overflow calculations to avoid integer overflow.
576 Add a FIXME comment where memory seems to be over-allocated.
577
578 * character.c (Fstring): Check for size-calculation overflow.
579
580 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
581 unnecessary integer overflow. Check for size overflow.
582 (encode_coding_object): Don't update size until xmalloc succeeds.
583
584 * composite.c (get_composition_id): Check for overflow in glyph
585 length calculations.
586
587 Integer and memory overflow fixes for display code.
588 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
589 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
590 (scrolling_window): Check for overflow in size calculations.
591 (line_draw_cost, realloc_glyph_pool, add_row_entry):
592 Don't assume glyph table len fits in int.
593 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
594 (row_table_size): Now ptrdiff_t, not int.
595 (scrolling_window): Avoid overflow in size calculations.
596 Don't update size until allocation succeeds.
597 * fns.c (concat): Check for overflow in size calculations.
598 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
599 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
600 (NEXT_ALMOST_PRIME_LIMIT): New constant.
601
602 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
603 (get_doc_string): Check for size calculation overflow.
604 Don't update size until allocation succeeds.
605 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
606 EMACS_INT, where ptrdiff_t will do.
607 (Fsubstitute_command_keys): Check for string overflow.
608
609 * editfns.c (set_time_zone_rule): Don't assume environment length
610 fits in int.
611 (message_length): Now ptrdiff_t, not int.
612 (Fmessage_box): Don't update size until allocation succeeds.
613 Don't assume message length fits in int.
614 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
615
616 * emacs.c (main): Do not reallocate argv, since there is a null at
617 the end that can be overwritten, and this way there's no need to
618 worry about size-calculation overflow.
619 (sort_args): Check for size-calculation overflow.
620
621 * eval.c (init_eval_once, grow_specpdl): Don't update size until
622 alloc succeeds.
623 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
624
625 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
626 (x_set_scroll_bar_width, x_figure_window_size):
627 Check for integer overflow.
628 (x_set_alpha): Do not assume XINT fits in int.
629
630 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
631 This is for the members text_lines, text_cols, total_lines, total_cols,
632 where the system imposes an 'int' limit.
633
634 * fringe.c (Fdefine_fringe_bitmap):
635 Don't update size until alloc works.
636
637 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
638 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
639
640 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
641 Check for size-calculation overflow.
642 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
643 do, as we prefer signed integers.
644 (id_to_widget.max_size, id_to_widget.used)
645 (xg_store_widget_in_map, xg_remove_widget_from_map)
646 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
647 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
648 Use and return ptrdiff_t, not int.
649 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
650 * gtkutil.h: Change prototypes to match the above.
651
652 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
653 are duplicate now that they've been promoted to lisp.h.
654 (x_allocate_bitmap_record, x_alloc_image_color)
655 (make_image_cache, cache_image, xpm_load):
656 Don't update size until alloc is done.
657 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
658 (x_detect_edges):
659 Check for size calculation overflow.
660 (ct_colors_allocated_max): New constant.
661 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
662 overflow.
663
664 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
665 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
666 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
667 Use ptrdiff_t, not int, to count maps.
668 (read_char_minibuf_menu_prompt): Check for overflow in size
669 calculations. Don't update size until allocation succeeds. Redo
670 calculations to avoid overflow.
671 * keyboard.h: Change prototypes to match the above.
672
673 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
674 to count maps.
675 (current_minor_maps): Check for size calculation overflow.
676 * keymap.h: Change prototypes to match the above.
677
678 * lread.c (read1, init_obarray): Don't update size until alloc done.
679
680 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
681 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
682
683 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
684 Now ptrdiff_t, not int.
685 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
686 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
687
688 * process.c (Fnetwork_interface_list): Check for overflow
689 in size calculation.
690
691 * region-cache.c (move_cache_gap): Check for size calculation overflow.
692
693 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
694 overflow. Don't bother calling xmalloc when xrealloc will do.
695
696 * search.c (Freplace_match): Check for size calculation overflow.
697 (Fset_match_data): Don't assume list lengths fit in 'int'.
698
699 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
700 for command line length. Do not attempt to address one before the
701 beginning of an array, as that's not portable.
702
703 * term.c (max_frame_lines): Remove; unused.
704 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
705 not int.
706 (encode_terminal_code, calculate_costs): Check for size
707 calculation overflow.
708 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
709 table lengths and related sizes. Don't update size until alloc
710 done. Redo calculations to avoid overflow.
711 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
712
713 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
714 subtracting pointers.
715 (gobble_line): Check for overflow more carefully. Don't update size
716 until alloc done.
717
718 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
719 Don't update size until alloc done.
720 Redo size calculations to avoid overflow.
721 Check for size calculation overflow.
722 (main) [DEBUG]: Fix typo in invoking tparam1.
723
724 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
725 Use ptrdiff_t, not int, for sizes.
726 (store_mode_line_noprop_char): Don't update size until alloc done.
727
728 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
729 Use ptrdiff_t, not int, for sizes.
730 (Finternal_make_lisp_face, cache_face):
731 Check for size calculation overflow.
732 (cache_face): Treat size calculation overflows as if they were
733 memory exhaustion (the usual treatment), rather than aborting.
734
735 * xfns.c (x_encode_text, x_set_name_internal)
736 (Fx_change_window_property): Use ptrdiff_t, not int, to count
737 sizes, since they can exceed INT_MAX in size. Check for size
738 calculation overflow.
739
740 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
741 (xg_select): Check for size calculation overflow.
742 Don't update size until alloc done.
743
744 * xrdb.c (get_environ_db): Don't assume path length fits in int,
745 as sprintf is limited to int lengths.
746
747 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
748 (X_LONG_MIN): New macros.
749 Use them to make the following changes clearer.
750 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
751 This change doesn't affect the value now, but it may help remind
752 future maintainers not to raise the value too much later.
753 (SELECTION_QUANTUM): Remove, replacing with ...
754 (selection_quantum): ... new function, which avoids overflow.
755 All uses changed.
756 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
757 assumption that selection length fits in 'int'.
758 (x_reply_selection_request, x_handle_selection_request)
759 (x_get_window_property, receive_incremental_selection)
760 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
761 (lisp_data_to_selection_data, clean_local_selection_data):
762 Use ptrdiff_t, not int, to record length of selection.
763 (x_reply_selection_request, x_get_window_property)
764 (receive_incremental_selection, x_property_data_to_lisp):
765 Redo calculations to avoid overflow.
766 (x_reply_selection_request): When sending hint, ceiling it at
767 X_LONG_MAX rather than relying on wraparound overflow to send
768 something.
769 (x_get_window_property, receive_incremental_selection)
770 (lisp_data_to_selection_data, x_property_data_to_lisp):
771 Check for size-calculation overflow.
772 (x_get_window_property, receive_incremental_selection)
773 (lisp_data_to_selection_data, Fx_register_dnd_atom):
774 Don't store size until memory allocation succeeds.
775 (x_get_window_property): Plug memory leak on memory exhaustion.
776 Don't double-block input; malloc is safe here. Don't assume 2**34
777 - 4 fits in unsigned long. Add an xassert to check
778 XGetWindowProperty overflow. Be more careful about overflow
779 calculations, and distinguish size from memory overflow better.
780 (receive_incremental_selection): When tracing, don't assume
781 unsigned int is less than INT_MAX.
782 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
783 harmful) conversions of unsigned short to int.
784 (lisp_data_to_selection_data): Don't assume that integers
785 in the range -65535 through -1 fit in an X unsigned short.
786 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
787 result parameters unless successful. Rely on cons_to_unsigned
788 to report problems with elements; the old code wasn't right anyway.
789 (x_check_property_data): Check for int overflow; we cannot use
790 a wider type due to X limits.
791 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
792
793 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
794
795 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
796 (x_term_init): Check for size calculation overflow.
797 (x_color_cells): Don't store size until memory allocation succeeds.
798 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
799 Don't assume alloca size is less than MAX_ALLOCA.
800 (x_term_init): Don't assume length fits in int (sprintf is limited
801 to int size).
802
803 Use ptrdiff_t for composition IDs.
804 * character.c (lisp_string_width):
805 * composite.c (composition_table_size, n_compositions)
806 (get_composition_id, composition_gstring_from_id):
807 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
808 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
809 * window.c (Frecenter):
810 Use ptrdiff_t, not int, for composition IDs.
811 * composite.c (get_composition_id): Check for integer overflow.
812 * composite.h: Adjust prototypes to match the above changes.
813
814 Use ptrdiff_t for hash table indexes.
815 * category.c (hash_get_category_set):
816 * ccl.c (ccl_driver):
817 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
818 * coding.c (coding_system_charset_list, detect_coding_system):
819 * coding.h (struct coding_system.id):
820 * composite.c (get_composition_id, gstring_lookup_cache):
821 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
822 * image.c (xpm_get_color_table_h):
823 * lisp.h (hash_lookup, hash_put):
824 * minibuf.c (Ftest_completion):
825 Use ptrdiff_t for hash table indexes, not int (which is too
826 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
827 32-bit --with-wide-int hosts).
828
829 * charset.c (Fdefine_charset_internal): Check for integer overflow.
830 Add a FIXME comment about memory leaks.
831 (syms_of_charset): Don't assume xmalloc returns.
832
833 Don't assume that stated character widths fit in int.
834 * character.c (Fchar_width, c_string_width, lisp_string_width):
835 * character.h (CHAR_WIDTH):
836 * indent.c (MULTIBYTE_BYTES_WIDTH):
837 Use sanitize_char_width to avoid undefined and/or bad behavior
838 with outlandish widths.
839 * character.h (sanitize_tab_width): Renamed from sanitize_width,
840 now that we have two such functions. All uses changed.
841 (sanitize_char_width): New inline function.
842
843 Don't assume that tab-width fits in int.
844 * character.h (sanitize_width): New inline function.
845 (SANE_TAB_WIDTH): New macro.
846 (ASCII_CHAR_WIDTH): Use it.
847 * indent.c (sane_tab_width): Remove. All uses replaced by
848 SANE_TAB_WIDTH (current_buffer).
849 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
850
851 * fileio.c: Integer overflow issues with file modes.
852 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
853
854 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
855 Remove unreachable code.
856 (read_hex, load_charset_map_from_file): Check for integer overflow.
857
858 * xterm.c: don't go over XClientMessageEvent limit
859 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
860 (x_send_scroll_bar_event): Likewise. Check that the size does not
861 exceed limits imposed by XClientMessageEvent, as well as the usual
862 ptrdiff_t and size_t limits.
863
864 * keyboard.c: Overflow, signedness and related fixes.
865 (make_lispy_movement): Use same integer type in forward decl
866 that is used in the definition.
867 (read_key_sequence, keyremap_step):
868 Change bufsize argument back to int, undoing my 2011-03-30 change.
869 We prefer signed types, and int is wide enough here.
870 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
871 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
872 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
873 length, not size_t. Use ptrdiff_t for index, not int.
874 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
875 possibility of integer overflow.
876
877 Overflow, signedness and related fixes for images.
878
879 * dispextern.h (struct it.stack[0].u.image.image_id)
880 (struct_it.image_id, struct image.id, struct image_cache.size)
881 (struct image_cache.used, struct image_cache.ref_count):
882 * gtkutil.c (update_frame_tool_bar):
883 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
884 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
885 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
886 * nsmenu.m (update_frame_tool_bar):
887 * xdisp.c (calc_pixel_width_or_height):
888 * xfns.c (image_cache_refcount):
889 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
890 on typical 64-bit hosts.
891
892 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
893 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
894 Omit unnecessary casts to int.
895 (parse_image_spec): Check that integers fall into 'int' range
896 when the callers expect that.
897 (image_ascent): Redo ascent calculation to avoid int overflow.
898 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
899 (lookup_image): Remove unnecessary tests.
900 (xbm_image_p): Locals are now of int, not EMACS_INT,
901 since parse_image_check makes sure they fit into int.
902 (png_load, gif_load, svg_load_image):
903 Prefer int to unsigned where either will do.
904 (tiff_handler): New function, combining the cores of the
905 old tiff_error_handler and tiff_warning_handler. This
906 function is rewritten to use vsnprintf and thereby avoid
907 stack buffer overflows. It uses only the features of vsnprintf
908 that are common to both POSIX and native Microsoft.
909 (tiff_error_handler, tiff_warning_handler): Use it.
910 (tiff_load, gif_load, imagemagick_load_image):
911 Don't assume :index value fits in 'int'.
912 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
913 (imagemagick_load_image): Check that crop parameters fit into
914 the integer types that MagickCropImage accepts. Don't assume
915 Vimagemagick_render_type has a nonnegative value. Don't assume
916 size_t fits in 'long'.
917 (gs_load): Use printmax_t to print the widest integers possible.
918 Check for integer overflow when computing image height and width.
919
920 2011-08-26 Eli Zaretskii <eliz@gnu.org>
921
922 * xdisp.c (redisplay_window): Don't force window start if point
923 will be invisible in the resulting window. (Bug#9324)
924
925 2011-08-25 Eli Zaretskii <eliz@gnu.org>
926
927 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
928 the display spec is of the form `(space ...)'.
929 (handle_display_spec): Return the value returned by
930 handle_single_display_spec, not just 1 or zero.
931 (handle_single_display_spec): If the display spec is of the form
932 `(space ...)', and specifies display in the text area, return 2
933 rather than 1.
934 (try_cursor_movement): Check for the need to scroll more
935 accurately, and prefer exact match for point under bidi. Don't
936 advance `row' beyond the last row of the window.
937
938 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
939 into disp_prop; all users changed.
940
941 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
942 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
943 for the text covered by the display property.
944
945 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
946
947 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
948 Change return value to nil.
949 (Frecord_buffer): Delete unused function.
950
951 2011-08-24 Eli Zaretskii <eliz@gnu.org>
952
953 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
954 buffers, return left-to-right.
955 (set_cursor_from_row): Consider candidate row a win if its glyph
956 represents a newline and point is on that newline. Fixes cursor
957 positioning on the newline at EOL of R2L text within L2R
958 paragraph, and vice versa.
959 (try_cursor_movement): Check continued rows, in addition to
960 continuation rows. Fixes unwarranted scroll when point enters a
961 continued line of R2L text within an L2R paragraph, or vice versa.
962 (cursor_row_p): Consider the case of point being equal to
963 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
964 from the end of a short line to the beginning of a continued line
965 of R2L text within L2R paragraph.
966 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
967 composed characters.
968
969 * bidi.c (bidi_check_type): Use xassert.
970 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
971 members.
972
973 2011-08-23 Eli Zaretskii <eliz@gnu.org>
974
975 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
976 a character.
977
978 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
979
980 * nsfont.m (ns_otf_to_script): Fix typo.
981
982 2011-08-22 Kenichi Handa <handa@m17n.org>
983
984 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
985 extra slot even if the purpose is char-code-property-table.
986
987 2011-08-23 Eli Zaretskii <eliz@gnu.org>
988
989 * xdisp.c (redisplay_window): When computing centering_position,
990 account for the height of the header line. (Bug#8874)
991
992 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
993 instead of CHAR_TO_BYTE. Fixes a crash when a completion
994 candidate is selected by the mouse, and that candidate has a
995 composed character under the mouse.
996
997 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
998 coordinates reported by pos-visible-in-window-p for a composed
999 character in column zero.
1000
1001 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1002
1003 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1004
1005 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1006
1007 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1008 consider it a hit if to_charpos is anywhere in the range of the
1009 composed buffer positions.
1010
1011 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1012
1013 * image.c (gif_load): Don't assume that each subimage has the same
1014 dimensions as the base image. Handle disposal method that is
1015 "undefined" by the gif spec (Bug#9335).
1016
1017 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1018
1019 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1020 (Fcondition_case): Document `debug' symbol in error handler.
1021
1022 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1023
1024 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1025 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1026 from an Org mode buffer to a Speedbar frame.
1027
1028 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1029 a composition, take its buffer position from IT->cmp_it.charpos.
1030 Fixes cursor positioning at the beginning of a line that begins
1031 with a composed character.
1032
1033 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1034
1035 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1036 character bidirectional type, use STRONG_L instead. Fixes crashes
1037 in a buffer produced by `describe-categories'.
1038
1039 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1040 members before the level stack, so they would be saved and
1041 restored when copying iterator state. Fixes incorrect reordering
1042 around TABs covered by display properties.
1043
1044 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1045
1046 * process.c (Fnetwork_interface_list): Correctly determine buffer
1047 size.
1048
1049 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1050
1051 * eval.c (internal_condition_case, internal_condition_case_1)
1052 (internal_condition_case_2, internal_condition_case_n):
1053 Remove unnecessary aborts (Bug#9081).
1054
1055 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1056
1057 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1058 has no `load' handler, try opening the file locally. (Bug#9311)
1059
1060 2011-08-16 Ken Brown <kbrown@cornell.edu>
1061
1062 * gmalloc.c: Expand comment.
1063
1064 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1065
1066 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1067 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1068
1069 2011-08-16 Ken Brown <kbrown@cornell.edu>
1070
1071 Fix memory allocation problems in Cygwin build (Bug#9273).
1072
1073 * unexcw.c ( __malloc_initialized): Declare external variable.
1074 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1075
1076 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1077 New variables.
1078 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1079 dumped emacs.
1080 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1081 in the static heap.
1082 [CYGWIN] (special_realloc): New function.
1083 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1084 requests to realloc storage in the static heap.
1085
1086 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1087
1088 * bidi.c (bidi_initialize): Remove unused local.
1089
1090 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1091
1092 * biditype.h: File removed.
1093
1094 * bidimirror.h: File removed.
1095
1096 * deps.mk (bidi.o): Remove biditype.h and
1097 bidimirror.h.
1098
1099 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1100 bidimirror.h.
1101
1102 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1103
1104 * chartab.c: Improve commentary for the uniprop_table API.
1105
1106 * bidi.c (bidi_paragraph_init): Support zero value of
1107 bidi_ignore_explicit_marks_for_paragraph_level.
1108 (bidi_initialize): Use uniprop_table instead of including
1109 biditype.h and bidimirror.h.
1110
1111 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1112 coordinates of the iterator when restoring from ppos_it.
1113 (Bug#9296)
1114
1115 2011-08-14 Kenichi Handa <handa@m17n.org>
1116
1117 * process.c (create_process): Call setup_process_coding_systems
1118 after the pid of the process is set to -1 (Bug#8162).
1119
1120 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1121
1122 * xdisp.c (move_it_in_display_line_to): Don't invoke
1123 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1124 ppos_it. Fixes vertical cursor motion when line beginning is
1125 covered by an image. (Bug#9296)
1126
1127 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1128
1129 * nsterm.h (ns_run_ascript): Declare.
1130 (NSAPP_DATA2_RUNASSCRIPT): Define.
1131
1132 * nsfns.m (as_script, as_result, as_status): New static variables.
1133 (ns_run_ascript): New function.
1134 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1135 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1136 the event loop. Get status from as_status (Bug#7276).
1137
1138 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1139 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1140 the event loop (Bug#7276).
1141
1142 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1143
1144 * gnutls.c (QCgnutls_bootprop_priority)
1145 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1146 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1147 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1148 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1149 (QCgnutls_bootprop_verify_hostname_error)
1150 (QCgnutls_bootprop_callbacks_verify): Rename from
1151 Qgnutls_bootprop_..., all uses changed.
1152
1153 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1154 uses changed.
1155
1156 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1157
1158 * xfaces.c (Qframe_set_background_mode): Now static.
1159 * dispextern.h (Qframe_set_background_mode): Remove decl.
1160
1161 * process.c (Fnetwork_interface_info): Declare local only if needed.
1162
1163 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1164
1165 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1166 (Fnetwork_interface_list): Allocate in increments of bytes instead
1167 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1168 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1169 sockaddr.
1170 (struct ifflag_def): notrailers is smart on OSX.
1171 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1172 Get hardware address with getifaddrs if available.
1173
1174 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1175
1176 * xdisp.c (iterate_out_of_display_property): xassert that
1177 IT->position is set to within IT->object's boundaries. Break from
1178 the loop as soon as EOB is reached; avoids infloops in redisplay
1179 when IT->position is set up wrongly due to some bug.
1180 Set IT->current to match the bidi iterator unconditionally.
1181 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1182 entry. Force push_it to save on the stack the current
1183 buffer/string position, to be restored by pop_it. Fix flags in
1184 the iterator structure wrt the object coming from a display
1185 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1186 properties. (Bug#9284)
1187
1188 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1189
1190 * fontset.c (fontset_get_font_group): Add proper type checks.
1191 (Bug#9172)
1192
1193 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1194
1195 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1196 and LC_VERSION_MIN_MACOSX.
1197 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1198 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1199
1200 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1201
1202 * xdisp.c (forward_to_next_line_start): Allow to use the
1203 no-display-properties-and-no-overlays under bidi display.
1204 Set disp_pos in the bidi iterator to avoid searches for display
1205 properties and overlays.
1206
1207 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1208
1209 * editfns.c (Fset_time_zone_rule): Document relationship with the
1210 setenv function.
1211
1212 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1213 the font entity extracted from the cache (Bug#8109).
1214
1215 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1216
1217 * composite.c (autocmp_chars): Don't reset point. That is done by
1218 restore_point_unwind (Bug#5984).
1219
1220 2011-08-07 Juri Linkov <juri@jurta.org>
1221
1222 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1223 to show the arg `TIME' instead of `TIMEVAL'.
1224
1225 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1226
1227 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1228 display property strides EOL and includes a newline, as in
1229 longlines-mode. (Bug#9254)
1230 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1231 word-wrap under bidirectional display. (Bug#9224)
1232
1233 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1234 is non-zero, even if the data buffer is NULL. Fixes a crash in
1235 vertical-motion with longlines-mode. (Bug#9254)
1236
1237 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1238
1239 * bidi.c <bidi_cache_total_alloc>: Now static.
1240 (bidi_initialize): Initialize bidi_cache_total_alloc.
1241
1242 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1243 cache. (Bug#9221)
1244
1245 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1246 amount allocated this far in `bidi_cache_total_alloc'.
1247 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1248 non-zero, only free the data buffer without restoring the cache
1249 contents. All callers changed.
1250
1251 * dispextern.h (bidi_unshelve_cache): Update prototype.
1252
1253 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1254 (move_it_in_display_line, move_it_to)
1255 (move_it_vertically_backward, move_it_by_lines): Replace the call
1256 to xfree to an equivalent call to bidi_unshelve_cache.
1257 (move_it_in_display_line_to): Fix logic of returning
1258 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1259
1260 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1261
1262 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1263 came from a string character with a `cursor' property. (Bug#9229)
1264
1265 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1266
1267 * Makefile.in (LIB_PTHREAD): New variable.
1268 (LIBES): Add LIB_PTHREAD (Bug#9216).
1269
1270 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1271 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1272
1273 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1274
1275 * regex.c (re_iswctype): Remove some redundant boolean
1276 conversions.
1277
1278 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1279
1280 * xterm.c (x_find_topmost_parent): New function.
1281 (x_set_frame_alpha): Find topmost parent window with
1282 x_find_topmost_parent and set the property there also (bug#9181).
1283 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1284
1285 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1286
1287 * callproc.c (Fcall_process): Avoid vfork clobbering
1288 the local vars buffer, coding_systems, current_dir.
1289
1290 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1291
1292 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1293
1294 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1295
1296 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1297 so that it is not optimized away.
1298
1299 * xdisp.c (compute_display_string_pos): Remove unused local.
1300
1301 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1302
1303 Fix slow cursor motion and scrolling in large buffers with
1304 selective display, like Org Mode buffers. (Bug#9218)
1305
1306 * dispextern.h (struct bidi_it): New member disp_prop_p.
1307
1308 * xdisp.c: Remove one-slot cache of display string positions.
1309 (compute_display_string_pos): Accept an additional argument
1310 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1311 for a display string or property. If found, set DISP_PROP_P
1312 non-zero.
1313
1314 * bidi.c (bidi_fetch_char): Accept an additional argument
1315 DISP_PROP_P, and pass it to compute_display_string_pos.
1316 Only handle text covered by a display string if DISP_PROP_P is returned
1317 non-zero. All callers of bidi_fetch_char changed.
1318
1319 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1320
1321 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1322
1323 2010-12-03 Don March <don@ohspite.net>
1324
1325 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1326 last character M-[char] is translated to ESC [char] (bug#7541).
1327
1328 2011-08-02 Kenichi Handa <handa@m17n.org>
1329
1330 * lisp.h (uniprop_table): Extern it.
1331
1332 * chartab.c (uniprop_table): Make it non-static.
1333
1334 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1335
1336 * xdisp.c (forward_to_next_line_start): Accept additional argument
1337 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1338 on the newline.
1339 (reseat_at_next_visible_line_start): Use the bidi iterator state
1340 returned by forward_to_next_line_start to restore the state of
1341 it->bidi_it after backing up to previous newline. (Bug#9212)
1342
1343 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1344
1345 * regex.c (re_comp): Protoize.
1346 (re_exec): Fix return type.
1347 (regexec): Fix type of `ret'. (Bug#9203)
1348
1349 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1350
1351 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1352 This is needed if max-image-size is a floating-point number.
1353
1354 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1355
1356 * print.c (print_object): Print empty symbol as ##.
1357
1358 * lread.c (read1): Read ## as empty symbol.
1359
1360 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1361
1362 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1363 setting frame foreground color (Bug#9175).
1364 (x_set_background_color): Likewise.
1365
1366 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1367 contents (Bug#9176).
1368 (EmacsTooltip -init): Remove bezels and add shadows to
1369 tooltip windows.
1370
1371 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1372 or scroll bar (Bug#8470).
1373
1374 * nsfont.m (nsfont_open): Remove assignment to voffset and
1375 unnecessary vars hshink, expand, hd, full_height, min_height.
1376 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1377
1378 * nsterm.h (nsfont_info): Remove voffset field.
1379
1380 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1381
1382 Implement strike-through and overline on NextStep (Bug#8863).
1383
1384 * nsfont.m (nsfont_open): Use underline position provided by font,
1385 instead of hard-coded value of 2.
1386 (nsfont_draw): Call ns_draw_text_decoration instead.
1387
1388 * nsterm.h: Add declaration for ns_draw_text_decoration.
1389
1390 * nsterm.m (ns_draw_text_decoration): New function for drawing
1391 underline, overline, and strike-through.
1392 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1393 ns_draw_text_decoration. Change treatment of cursor drawing to
1394 accommodate underlining, etc.
1395
1396 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1397
1398 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1399 default.
1400
1401 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1402
1403 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1404 Without this fix, if a signal arrives just after memory fills up,
1405 'malloc' might be invoked reentrantly.
1406
1407 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1408 In other words, assume that every image size is allowed, on non-X
1409 hosts. This assumption is probably wrong, but it lets Emacs compile.
1410
1411 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1412
1413 * regex.c (re_iswctype): Convert return values to boolean.
1414
1415 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1416
1417 * xdisp.c (compute_display_string_pos): Don't use cached display
1418 string position if the buffer had its restriction changed.
1419 (Bug#9184)
1420
1421 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1422
1423 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1424
1425 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1426
1427 Integer signedness and overflow and related fixes. (Bug#9079)
1428
1429 * bidi.c: Integer size and overflow fixes.
1430 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1431 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1432 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1433 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1434 (bidi_find_other_level_edge):
1435 Use ptrdiff_t instead of EMACS_INT where either will do.
1436 This works better on 32-bit hosts configured --with-wide-int.
1437 (bidi_cache_ensure_space): Check for size-calculation overflow.
1438 Use % rather than repeated addition, for better worst-case speed.
1439 Don't set bidi_cache_size until after xrealloc returns, because it
1440 might not return.
1441 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1442 (bidi_cache_ensure_space): Also check that the bidi cache size
1443 does not exceed that of the largest Lisp string or buffer. See Eli
1444 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1445
1446 * alloc.c (__malloc_size_t): Remove.
1447 All uses replaced by size_t. See Andreas Schwab's note
1448 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1449
1450 * image.c: Improve checking for integer overflow.
1451 (check_image_size): Assume that f is nonnull, since
1452 it is always nonnull in practice. This is one less thing to
1453 worry about when checking for integer overflow later.
1454 (x_check_image_size): New function, which checks for integer
1455 overflow issues inside X.
1456 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1457 This removes the need for a memory_full check.
1458 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1459 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1460 (xbm_read_bitmap_data): Change locals back to 'int', since
1461 their values must fit in 'int'.
1462 (xpm_load_image, png_load, tiff_load):
1463 Invoke x_create_x_image_and_pixmap earlier,
1464 to avoid much needless work if the image is too large.
1465 (tiff_load): Treat overly large images as if
1466 x_create_x_image_and_pixmap failed, not as malloc failures.
1467 (gs_load): Use x_check_image_size.
1468
1469 * gtkutil.c: Omit integer casts.
1470 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1471 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1472
1473 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1474
1475 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1476 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1477 would wrongly return t on a 64-bit host.
1478
1479 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1480 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1481 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1482 and therefore cause GCC to emit a bogus diagnostic in some cases.
1483
1484 * image.c: Integer signedness and overflow and related fixes.
1485 This is not an exhaustive set of fixes, but it's time to
1486 record what I've got.
1487 (lookup_pixel_color, check_image_size): Remove redundant decls.
1488 (check_image_size): Don't assume that arbitrary EMACS_INT values
1489 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1490 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1491 (tiff_load, imagemagick_load_image):
1492 Check for overflow in size calculations.
1493 (x_create_x_image_and_pixmap): Remove unnecessary test for
1494 xmalloc returning NULL; that can't happen.
1495 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1496 (xpm_color_bucket): Use better integer hashing function.
1497 (xpm_cache_color): Don't possibly over-allocate memory.
1498 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1499 (gif_memory_source):
1500 Use ptrdiff_t, not int or size_t, to record sizes.
1501 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1502 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1503 either works, as we prefer signed integers.
1504 (tiff_read_from_memory, tiff_write_from_memory):
1505 Return tsize_t, not size_t, since that's what the TIFF API wants.
1506 (tiff_read_from_memory): Don't fail simply because the read would
1507 go past EOF; instead, return a short read.
1508 (tiff_load): Omit no-longer-needed casts.
1509 (Fimagemagick_types): Don't assume size fits into 'int'.
1510
1511 Improve hashing quality when configured --with-wide-int.
1512 * fns.c (hash_string): New function, taken from sxhash_string.
1513 Do not discard information about ASCII character case; this
1514 discarding is no longer needed.
1515 (sxhash-string): Use it. Change sig to match it. Caller changed.
1516 * lisp.h: Declare it.
1517 * lread.c (hash_string): Remove, since we now use fns.c's version.
1518 The fns.c version returns a wider integer if --with-wide-int is
1519 specified, so this should help the quality of the hashing a bit.
1520
1521 * emacs.c: Integer overflow minor fix.
1522 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1523 Define only if GNU_LINUX.
1524 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1525
1526 * dispnew.c: Integer signedness and overflow fixes.
1527 Remove unnecessary forward decls, that were a maintenance hassle.
1528 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1529 All uses changed.
1530 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1531 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1532 (prepare_desired_row, line_draw_cost):
1533 Use int, not unsigned, where either works.
1534 (save_current_matrix, restore_current_matrix):
1535 Use ptrdiff_t, not size_t, where either works.
1536 (init_display): Check for overflow more accurately, and without
1537 relying on undefined behavior.
1538
1539 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1540 Remove, replacing with the new symbols in lisp.h. All uses changed.
1541 * fileio.c (make_temp_name):
1542 * filelock.c (lock_file_1, lock_file):
1543 * xdisp.c (message_dolog):
1544 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1545 Use pMd etc. instead.
1546 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1547 replacing the pWIDE etc. symbols removed from editfns.c.
1548
1549 * keyboard.h (num_input_events): Now uintmax_t.
1550 This is (very slightly) less likely to mess up due to wraparound.
1551 All uses changed.
1552
1553 * buffer.c: Integer signedness fixes.
1554 (alloc_buffer_text, enlarge_buffer_text):
1555 Use ptrdiff_t rather than size_t when either will do, as we prefer
1556 signed integers.
1557
1558 * alloc.c: Integer signedness and overflow fixes.
1559 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1560 (__malloc_size_t): Default to size_t, not to int.
1561 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1562 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1563 Prefer ptrdiff_t to size_t when either would do, as we prefer
1564 signed integers.
1565 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1566 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1567 Now const. Initialize with values that are in range even if char
1568 is signed.
1569 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1570 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1571 These functions do the right thing with sizes > 2**32.
1572 (check_depth): Now ptrdiff_t, not int.
1573 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1574 Adjust to new way of storing sizes. Check for size overflow bugs
1575 in rest of code.
1576 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1577 slightly wrong anyway, as it missed one instance of
1578 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1579 (refill_memory_reserve): Omit needless cast to size_t.
1580 (mark_object_loop_halt): Mark as externally visible.
1581
1582 * xselect.c: Integer signedness and overflow fixes.
1583 (Fx_register_dnd_atom, x_handle_dnd_message):
1584 Use ptrdiff_t, not size_t, since we prefer signed.
1585 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1586 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1587 x_dnd_atoms_size and x_dnd_atoms_length.
1588
1589 * doprnt.c: Prefer signed to unsigned when either works.
1590 * eval.c (verror):
1591 * doprnt.c (doprnt):
1592 * lisp.h (doprnt):
1593 * xdisp.c (vmessage):
1594 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1595 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1596 prefer signed arithmetic to avoid comparison confusion.
1597 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1598 but is a bit tricky.
1599
1600 Assume freestanding C89 headers, string.h, stdlib.h.
1601 * data.c, doprnt.c, floatfns.c, print.c:
1602 Include float.h unconditionally.
1603 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1604 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1605 * regex.c: Likewise for stddef.h, string.h.
1606 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1607 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1608 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1609 (STDC_HEADERS): Remove obsolete defines.
1610 * sysdep.c: Include limits.h unconditionally.
1611
1612 Assume support for memcmp, memcpy, memmove, memset.
1613 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1614 * regex.c (memcmp, memcpy):
1615 Remove; we assume C89 now.
1616
1617 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1618 (__malloc_safe_bcopy): Remove; no longer needed.
1619
1620 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1621 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1622 well either way, and we prefer signed to unsigned.
1623
1624 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1625
1626 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1627 closes the connection while we're reading (bug#9182).
1628
1629 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1630
1631 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1632 are specified (Bug#9168).
1633
1634 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1635
1636 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1637 Found by GCC static checking and --with-wide-int on a 32-bit host.
1638
1639 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1640
1641 * xdisp.c (compute_display_string_pos): Fix logic of caching
1642 previous display string position. Initialize cached_prev_pos to
1643 -1. Fixes slow-down at the beginning of a buffer.
1644
1645 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1646
1647 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1648 for attrs[LFACE_FONTSET_INDEX].
1649
1650 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1651
1652 * xml.c (parse_region): Remove unused local
1653 that was recently introduced.
1654
1655 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1656
1657 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1658 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1659
1660 * xdisp.c (move_it_in_display_line_to): Record the best matching
1661 position for TO_CHARPOS while scanning the line, and restore it on
1662 exit if none of the characters scanned was an exact match.
1663 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1664 when exact match is impossible due to invisible text, and the
1665 lines are truncated.
1666
1667 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1668
1669 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1670 for OSX >= 10.7.
1671
1672 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1673
1674 Fix a significant slow-down of cursor motion with C-n, C-p,
1675 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1676 auto-repeat under bidi redisplay in fontified buffers.
1677 * xdisp.c (compute_stop_pos_backwards): New function.
1678 (next_element_from_buffer): Call compute_stop_pos_backwards to
1679 find a suitable prev_stop when we find ourselves before
1680 base_level_stop.
1681 (reseat): Don't look for prev_stop, as that could mean a very long
1682 run.
1683 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1684 <cached_disp_overlay_modiff>: Cache for last found display string
1685 position.
1686 (compute_display_string_pos): Return the cached position if asked
1687 about the same buffer in the same area of character positions, and
1688 the buffer wasn't changed since the time the display string
1689 position was cached.
1690
1691 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1692
1693 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1694 is an integer, which is important for empty lines. (Bug#9149)
1695
1696 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1697
1698 * frame.c (Fmodify_frame_parameters): In tty case, update the
1699 default face if necessary (Bug#4238).
1700
1701 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1702
1703 * editfns.c (Fstring_to_char): No need to explain what a character
1704 is in the docstring (Bug#6576).
1705
1706 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1707
1708 * xml.c (parse_region): Make sure we always return a tree.
1709
1710 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1711
1712 * xml.c (parse_region): If a document contains only comments,
1713 return that, too.
1714
1715 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1716
1717 * xml.c (make_dom): Return comments, too.
1718
1719 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1720
1721 Port to OpenBSD.
1722 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1723 and the surrounding thread.
1724 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1725 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1726 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1727 timer goes off.
1728 * s/openbsd.h (BROKEN_SIGIO): Define.
1729 * unexelf.c (unexec) [__OpenBSD__]:
1730 Don't update the .mdebug section of the Alpha COFF symbol table.
1731
1732 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1733
1734 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1735 (bug#8460).
1736
1737 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1738
1739 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1740 This fixes some race conditions on the permissions of any newly
1741 created file.
1742
1743 * alloc.c (valid_pointer_p): Use pipe, not open.
1744 This fixes some permissions issues when debugging.
1745
1746 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1747 If fchown fails to set both uid and gid, try to set just gid,
1748 as that is sometimes allowed. Adjust the file's mode to eliminate
1749 setuid or setgid bits that are inappropriate if fchown fails.
1750
1751 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1752
1753 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1754 to compare Lisp_Objects.
1755 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1756 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1757 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1758
1759 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1760
1761 * lread.c (read_integer): Unread even EOF character.
1762 (read1): Likewise. Properly record start position of symbol.
1763
1764 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1765 symbol character follows.
1766
1767 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1768
1769 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1770 This works around a problem with the previous change to Fcopy_file.
1771 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1772 and without this change, GCC might complain about discarding
1773 fchown's return value.
1774
1775 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1776
1777 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1778
1779 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1780
1781 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1782
1783 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1784
1785 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1786 it's used from the C level.
1787
1788 * process.c: Use the same condition for POLL_FOR_INPUT in both
1789 keyboard.c and process.c (bug#1858).
1790
1791 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1792
1793 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1794 (Fgnutls_boot): Use it.
1795
1796 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1797
1798 * doc.c (Fsubstitute_command_keys): Revert last change.
1799
1800 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1801
1802 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1803 quotes the next character, and doesn't affect other longer
1804 sequences (bug#8935).
1805
1806 * lread.c (syms_of_lread): Clarify that is isn't only
1807 `eval-buffer' and `eval-defun' that's affected by
1808 `lexical-binding' (bug#8460).
1809
1810 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1811
1812 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1813 bidi redisplay when a line includes both an image and is
1814 truncated.
1815
1816 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1817
1818 Fix minor problems found by static checking.
1819 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1820 (elsz): Now a signed constant, not a size_t var. We prefer signed
1821 types to unsigned, to avoid integer comparison confusion. Without
1822 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1823 "cannot optimize loop, the loop counter may overflow", a symptom
1824 of the confusion.
1825 * indent.c (Fvertical_motion): Mark locals as initialized.
1826 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1827
1828 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1829
1830 * search.c (Fre_search_backward): Mention `case-fold-search' in
1831 all the re_search_* functions (bug#8138).
1832
1833 * keyboard.c (Fopen_dribble_file): Document when the file is
1834 closed (bug#8056).
1835
1836 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1837
1838 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1839 bidi_cache_idx.
1840
1841 Support bidi reordering of display and overlay strings.
1842 * xdisp.c (compute_display_string_pos)
1843 (compute_display_string_end): Accept additional argument STRING.
1844 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1845 (reseat_to_string): Initialize bidi_it->string.s and
1846 bidi_it->string.schars.
1847 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1848 NULL (avoids a crash in bidi_paragraph_init).
1849 Initialize itb.string.lstring.
1850 (init_iterator): Call bidi_init_it only of a valid
1851 buffer position was specified. Initialize paragraph_embedding to
1852 L2R.
1853 (reseat_to_string): Initialize the bidi iterator.
1854 (display_string): If we need to ignore text properties of
1855 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1856 original value of -1 will not work with bidi.)
1857 (compute_display_string_pos): First arg is now struct
1858 `text_pos *'; all callers changed. Support display properties on
1859 Lisp strings.
1860 (compute_display_string_end): Support display properties on Lisp
1861 strings.
1862 (init_iterator, reseat_1, reseat_to_string): Initialize the
1863 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1864 when iterating on a string not from display properties).
1865 (compute_display_string_pos, compute_display_string_end):
1866 Fix calculation of the object to scan. Fixes an error when using
1867 arrow keys.
1868 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1869 base_level_stop; instead, set base_level_stop to BEGV.
1870 Fixes crashes in vertical-motion.
1871 (next_element_from_buffer): Improve commentary for when
1872 the iterator is before prev_stop.
1873 (init_iterator): Initialize bidi_p from the default value of
1874 bidi-display-reordering, not from buffer-local value. Use the
1875 buffer-local value only if initializing for buffer iteration.
1876 (handle_invisible_prop): Support invisible properties on strings
1877 that are being bidi-reordered.
1878 (set_iterator_to_next): Support bidi reordering of C strings and
1879 Lisp strings.
1880 (next_element_from_string): Support bidi reordering of Lisp
1881 strings.
1882 (handle_stop_backwards): Support Lisp strings as well.
1883 (display_string): Support display of R2L glyph rows.
1884 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1885 (init_iterator): Don't initialize it->bidi_p for strings
1886 here.
1887 (reseat_to_string): Initialize it->bidi_p for strings here.
1888 (next_element_from_string, next_element_from_c_string)
1889 (next_element_from_buffer): Add xassert's for correspondence
1890 between IT's object being iterated and it->bidi_it.string
1891 structure.
1892 (face_before_or_after_it_pos): Support bidi iteration.
1893 (next_element_from_c_string): Handle the case of the first string
1894 character that is not the first one in the visual order.
1895 (get_visually_first_element): New function, refactored from common
1896 parts of next_element_from_buffer, next_element_from_string, and
1897 next_element_from_c_string.
1898 (tool_bar_lines_needed, redisplay_tool_bar)
1899 (display_menu_bar): Force left-to-right direction. Add a FIXME
1900 comment for making that be controlled by a user option.
1901 (push_it, pop_it): Save and restore the state of the
1902 bidi iterator. Save and restore the bidi_p flag.
1903 (pop_it): Iterate out of display property for string iteration as
1904 well.
1905 (iterate_out_of_display_property): Support iteration over strings.
1906 (handle_single_display_spec): Set up it->bidi_it for iteration
1907 over a display string, and call bidi_init_it.
1908 (handle_single_display_spec, next_overlay_string)
1909 (get_overlay_strings_1, push_display_prop): Set up the bidi
1910 iterator for displaying display or overlay strings.
1911 (forward_to_next_line_start): Don't use the shortcut if
1912 bidi-iterating.
1913 (back_to_previous_visible_line_start): If handle_display_prop
1914 pushed the iterator stack, restore the internal state of the bidi
1915 iterator by calling bidi_pop_it same number of times.
1916 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1917 and we are bidi-iterating, don't decrement the iterator position;
1918 instead, set the first_elt flag in the bidi iterator, to produce
1919 the same effect.
1920 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1921 (push_display_prop): xassert that we are iterating a buffer.
1922 (push_it, pop_it): Save and restore paragraph_embedding member.
1923 (handle_single_display_spec, next_overlay_string)
1924 (get_overlay_strings_1, reseat_1, reseat_to_string)
1925 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1926 correctly. Don't assume unibyte strings are not bidi-reordered.
1927 (compute_display_string_pos)
1928 (compute_display_string_end): Fix handling the case of C string.
1929 (push_it, pop_it): Save and restore from_disp_prop_p.
1930 (handle_single_display_spec, push_display_prop): Set the
1931 from_disp_prop_p flag.
1932 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1933 (pop_it): Call iterate_out_of_display_property only if we are
1934 popping after iteration over a string that came from a display
1935 property. Fix a typo in popping stretch info. Add an assertion
1936 for verifying that the iterator position is in sync with the bidi
1937 iterator.
1938 (handle_single_display_spec, get_overlay_strings_1)
1939 (push_display_prop): Fix initialization of paragraph direction for
1940 string when that of the parent object is not yet determined.
1941 (reseat_1): Call bidi_init_it to resync the bidi
1942 iterator with IT's position. (Bug#7616)
1943 (find_row_edges): If ROW->start.pos gives position
1944 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1945 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1946 Reset the from_disp_prop_p flag.
1947 (SAVE_IT, RESTORE_IT): New macros.
1948 (pos_visible_p, face_before_or_after_it_pos)
1949 (back_to_previous_visible_line_start)
1950 (move_it_in_display_line_to, move_it_in_display_line)
1951 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1952 (try_scrolling, redisplay_window, display_line): Use them when
1953 saving a temporary copy of the iterator and restoring it back.
1954 (back_to_previous_visible_line_start, reseat_1)
1955 (init_iterator): Empty the bidi cache "stack".
1956 (move_it_in_display_line_to): If iterator ended up at
1957 EOL, but we never saw any buffer positions smaller than
1958 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1959 motion in bidi-reordered lines.
1960 (move_it_in_display_line_to): Record prev_method and prev_pos
1961 immediately before the call to set_iterator_to_next. Fixes cursor
1962 motion in bidi-reordered lines with stretch glyphs and strings
1963 displayed in margins. (Bug#8133) (Bug#8867)
1964 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1965 TO_CHARPOS.
1966 (pos_visible_p): Support positions in bidi-reordered lines.
1967 Save and restore bidi cache.
1968
1969 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1970 (bidi_paragraph_info): Delete unused struct.
1971 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1972 (bidi_cache_start): New variable.
1973 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1974 to zero.
1975 (bidi_cache_fetch_state, bidi_cache_search)
1976 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1977 (bidi_cache_find, bidi_peek_at_next_level)
1978 (bidi_level_of_next_char, bidi_find_other_level_edge)
1979 (bidi_move_to_visually_next): Compare cache index with
1980 bidi_cache_start rather than with zero.
1981 (bidi_fetch_char): Accept new argument STRING; all callers
1982 changed. Support iteration over a string. Support strings with
1983 display properties. Support unibyte strings. Fix the type of
1984 `len' according to what STRING_CHAR_AND_LENGTH expects.
1985 (bidi_paragraph_init, bidi_resolve_explicit_1)
1986 (bidi_resolve_explicit, bidi_resolve_weak)
1987 (bidi_level_of_next_char, bidi_move_to_visually_next):
1988 Support iteration over a string.
1989 (bidi_set_sor_type, bidi_resolve_explicit_1)
1990 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1991 can now be zero (for strings); special values 0 and -1 were
1992 changed to -1 and -2, respectively.
1993 (bidi_char_at_pos): New function.
1994 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1995 Call it instead of FETCH_MULTIBYTE_CHAR.
1996 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1997 initialized to valid values.
1998 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1999 values.
2000 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2001 the test for valid cached positions. Fix the logic for looking up
2002 the sentinel state in the cache. GCPRO the Lisp string we are
2003 iterating.
2004 (bidi_push_it, bidi_pop_it): New functions.
2005 (bidi_initialize): Initialize the bidi cache start stack pointer.
2006 (bidi_cache_ensure_space): New function, refactored from part of
2007 bidi_cache_iterator_state. Don't assume the required size is just
2008 one BIDI_CACHE_CHUNK away.
2009 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2010 (bidi_count_bytes, bidi_char_at_pos): New functions.
2011 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2012 always valid if bidi_cache_idx is valid.
2013 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2014 is valid if it's going to be used.
2015 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2016 (bidi_cache_fetch_state, bidi_cache_search)
2017 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2018 (bidi_cache_iterator_state, bidi_cache_find)
2019 (bidi_find_other_level_edge, bidi_cache_start_stack):
2020 All variables related to cache indices are now EMACS_INT.
2021
2022 * dispextern.h (struct bidi_string_data): New structure.
2023 (struct bidi_it): New member `string'. Make flag members be 1-bit
2024 fields, and put them last in the struct.
2025 (compute_display_string_pos, compute_display_string_end):
2026 Update prototypes.
2027 (bidi_push_it, bidi_pop_it): Add prototypes.
2028 (struct iterator_stack_entry): New members bidi_p,
2029 paragraph_embedding, and from_disp_prop_p.
2030 (struct it): Member bidi_p is now a bit field 1 bit wide.
2031 (bidi_shelve_cache, bidi_unshelve_cache):
2032 Declare prototypes.
2033
2034 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2035 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2036 and vector-like objects.
2037
2038 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2039 cache around display iteration.
2040
2041 * window.c (Fwindow_end, window_scroll_pixel_based)
2042 (displayed_window_lines, Frecenter): Save and restore the bidi
2043 cache around display iteration.
2044
2045 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2046
2047 * editfns.c (Fdelete_region): Clarify the use of the named
2048 parameters (bug#6788).
2049
2050 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2051
2052 * indent.c (Fvertical_motion): Set and restore w->pointm when
2053 saving and restoring the window's buffer (Bug#9006).
2054
2055 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2056
2057 * editfns.c (Fstring_to_char): Clarify just what is returned
2058 (bug#6576). Text by Eli Zaretskii.
2059
2060 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2061
2062 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2063
2064 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2065
2066 * buffer.c (mmap_find): Fix a typo.
2067
2068 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2069
2070 Fix execution of x selection hooks.
2071 * xselect.c (Qx_lost_selection_functions)
2072 (Qx_sent_selection_functions): New vars.
2073 (syms_of_xselect): DEFSYM them.
2074 (x_handle_selection_request): Pass Qx_sent_selection_functions
2075 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2076 (x_handle_selection_clear,x_clear_frame_selections):
2077 Pass Qx_lost_selection_functions rather than
2078 Vx_lost_selection_functions to Frun_hook_with_args.
2079
2080 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2081
2082 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2083 The old code sometimes used this field without initializing it.
2084
2085 * alloc.c (gc_sweep): Don't read past end of array.
2086 In theory, the old code could also have corrupted Emacs internals,
2087 though it'd be very unlikely.
2088
2089 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2090
2091 * character.c (Fcharacterp): Don't advertise optional ignored
2092 argument. (Bug#4026)
2093
2094 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2095
2096 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2097 key" (bug#4257).
2098
2099 * window.c (Fset_window_start): Doc fix (bug#4199).
2100 (Fset_window_hscroll): Ditto.
2101
2102 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2103
2104 Fix minor new problems caught by GCC 4.6.1.
2105 * term.c (init_tty): Remove unused local.
2106 * xsettings.c (store_monospaced_changed): Define this function only
2107 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2108 not used otherwise.
2109
2110 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2111
2112 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2113
2114 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2115
2116 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2117 are the mini-buffer and the echo area (bug#3320).
2118
2119 * term.c (init_tty): Remove support for supdup, c10 and perq
2120 terminals, which are no longer supported (bug#1482).
2121
2122 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2123
2124 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2125
2126 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2127
2128 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2129 for non-popups (Bug#3642).
2130
2131 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2132
2133 * alloc.c (reset_malloc_hooks): Protoize.
2134 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2135 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2136 * cm.c (losecursor): Likewise.
2137 * data.c (fmod): Likewise.
2138 * dispnew.c (swap_glyphs_in_rows): Likewise.
2139 * emacs.c (memory_warning_signal): Likewise.
2140 * floatfns.c (float_error): Likewise.
2141 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2142 (otf_open, font_otf_capability, generate_otf_features)
2143 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2144 Likewise.
2145 * image.c (pbm_read_file): Likewise.
2146 * indent.c (string_display_width): Likewise.
2147 * intervals.c (check_for_interval, search_for_interval)
2148 (inc_interval_count, count_intervals, root_interval)
2149 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2150 * lread.c (defalias): Likewise.
2151 * ralloc.c (r_alloc_check): Likewise.
2152 * regex.c (set_image_of_range_1, set_image_of_range)
2153 (regex_grow_registers): Likewise.
2154 * sysdep.c (strerror): Likewise.
2155 * termcap.c (valid_filename_p, tprint, main): Likewise.
2156 * tparam.c (main): Likewise.
2157 * unexhp9k800.c (run_time_remap, save_data_space)
2158 (update_file_ptrs, read_header, write_header, calculate_checksum)
2159 (copy_file, copy_rest, display_header): Likewise.
2160 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2161 Likewise.
2162 * xdisp.c (check_it): Likewise.
2163 * xfaces.c (register_color, unregister_color, unregister_colors):
2164 Likewise.
2165 * xfns.c (print_fontset_result): Likewise.
2166 * xrdb.c (member, fatal, main): Likewise.
2167
2168 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2169
2170 Fix minor problems found by static checking (Bug#9031).
2171 * chartab.c (char_table_set_range, map_sub_char_table):
2172 Remove unused locals.
2173 (uniprop_table): Now static.
2174 * composite.c (_work_char): Remove unused static var.
2175
2176 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2177
2178 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2179
2180 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2181
2182 * gtkutil.c (qttip_cb): Remove code without function.
2183
2184 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2185
2186 * w32.c (pthread_sigmask): New stub.
2187
2188 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2189
2190 Use pthread_sigmask, not sigprocmask (Bug#9010).
2191 sigprocmask is portable only for single-threaded applications, and
2192 Emacs can be multi-threaded when it uses GTK.
2193 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2194 (LIBES): Use it.
2195 * callproc.c (Fcall_process):
2196 * process.c (create_process):
2197 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2198 Use pthread_sigmask, not sigprocmask.
2199
2200 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2201
2202 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2203 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2204 wrong (Bug#8591).
2205
2206 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2207
2208 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2209 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2210 (xg_hide_tooltip): Fix comment.
2211
2212 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2213 in registerServicesMenuSendTypes.
2214 (validRequestorForSendType): Don't check ns_return_types.
2215
2216 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2217 ns_return_type.
2218
2219 2011-07-08 Jason Rumney <jasonr@gnu.org>
2220
2221 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2222 frame struct members of non-existent frames (Bug#6284).
2223
2224 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2225
2226 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2227 variable firstTime not needed on OSX >= 10.6.
2228 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2229 >= 10.5. Use setKnobProportion, setDoubleValue.
2230
2231 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2232 (MAC_OS_X_VERSION_10_5): Define if not defined.
2233 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2234 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2235 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2236
2237 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2238 cString and lossyCString on OSX >= 10.4
2239
2240 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2241 sizeToFit on OSX >= 10.2.
2242
2243 * nsimage.m (allocInitFromFile): Don't use deprecated method
2244 bestRepresentationForDevice on OSX >= 10.6.
2245
2246 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2247 to avoid warning.
2248
2249 * emacs.c: Declare unexec_init_emacs_zone.
2250
2251 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2252
2253 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2254
2255 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2256 on svcsMenu (Bug#8842).
2257
2258 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2259 ns_return_types.
2260 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2261
2262 * nsterm.m (QUTF8_STRING): Declare.
2263 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2264 (validRequestorForSendType): Return type is (id).
2265 Change indexOfObjectIdenticalTo to indexOfObject.
2266 Check if we have local selection before returning self (Bug#8842).
2267 (writeSelectionToPasteboard): Put local selection into paste board
2268 if we have a local selection (Bug#8842).
2269 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2270
2271 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2272 (ns_get_local_selection): Declare.
2273
2274 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2275
2276 * keymap.c (describe_map_tree): Don't insert a double newline at
2277 the end of the buffer (bug#1169) and return whether we inserted
2278 something.
2279
2280 * callint.c (Fcall_interactively): Change "reading args" to
2281 "providing args" to try to clarify what it does (bug#1010).
2282
2283 2011-07-07 Kenichi Handa <handa@m17n.org>
2284
2285 * composite.c (composition_compute_stop_pos): Ignore a static
2286 composition starting before CHARPOS (Bug#8915).
2287
2288 * xdisp.c (handle_composition_prop): Likewise.
2289
2290 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2291
2292 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2293 (Bug#9015)
2294
2295 2011-07-07 Kenichi Handa <handa@m17n.org>
2296
2297 * character.h (unicode_category_t): New enum type.
2298
2299 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2300 (Qchar_code_property_table): New variable.
2301 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2302 (UNIPROP_COMPRESSED_FORM_P): New macros.
2303 (char_table_ascii): Uncompress the compressed values.
2304 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2305 Uncompress the compressed values.
2306 (sub_char_table_ref_and_range): Likewise.
2307 (char_table_ref_and_range): Uncompress the compressed values.
2308 (sub_char_table_set): New arg is_uniprop. Callers changed.
2309 Uncompress the compressed values.
2310 (sub_char_table_set_range): Args changed. Callers changed.
2311 (char_table_set_range): Adjuted for the above change.
2312 (map_sub_char_table): Delete args default_val and parent. Add arg
2313 top. Give decoded values to a Lisp function.
2314 (map_char_table): Adjust for the above change. Give decoded
2315 values to a Lisp function. Gcpro more variables.
2316 (uniprop_table_uncompress)
2317 (uniprop_decode_value_run_length): New functions.
2318 (uniprop_decoder, uniprop_decoder_count): New variables.
2319 (uniprop_get_decoder, uniprop_encode_value_character)
2320 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2321 New functions.
2322 (uniprop_encoder, uniprop_encoder_count): New variables.
2323 (uniprop_get_encoder, uniprop_table)
2324 (Funicode_property_table_internal, Fget_unicode_property_internal)
2325 (Fput_unicode_property_internal): New functions.
2326 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2327 Sunicode_property_table_internal, Sget_unicode_property_internal,
2328 and Sput_unicode_property_internal. Defvar_lisp
2329 char-code-property-alist.
2330
2331 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2332 Vunicode_category_table.
2333
2334 * font.c (font_range): Adjust for the change of
2335 Vunicode_category_table.
2336
2337 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2338
2339 * m/iris4d.h: Remove file, move contents ...
2340 * s/irix6-5.h: ... here.
2341
2342 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2343
2344 Remove unportable assumption about struct layout (Bug#8884).
2345 * alloc.c (mark_buffer):
2346 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2347 (clone_per_buffer_values): Don't assume that
2348 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2349 This isn't true in general, and it's particularly not true
2350 if Emacs is configured with --with-wide-int.
2351 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2352 New macros, used in the buffer.c change.
2353
2354 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2355
2356 * xsettings.c: Use both GConf and GSettings if both are available.
2357 (store_config_changed_event): Add comment.
2358 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2359 (store_tool_bar_style_changed): New functions.
2360 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2361 (struct xsettings): Move font inside HAVE_XFT.
2362 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2363 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2364 Move inside HAVE_XFT.
2365 (something_changed_gsettingsCB): Rename from something_changedCB.
2366 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2367 also.
2368 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2369 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2370 (something_changed_gconfCB): Rename from something_changedCB.
2371 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2372 (parse_settings): Move check for font inside HAVE_XFT.
2373 (read_settings, apply_xft_settings): Add comment.
2374 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2375 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2376 call store_font_name_changed.
2377 (xft_settings_event): Add comment.
2378 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2379 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2380 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2381 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2382 (xsettings_initialize): Call init_gsettings last.
2383 (xsettings_get_system_font, xsettings_get_system_normal_font):
2384 Add comment.
2385
2386 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2387
2388 Random fixes. E.g., (random) never returned negative values.
2389 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2390 subseconds part to the entropy, as that's a bit more random.
2391 Prefer signed to unsigned, since the signedness doesn't matter and
2392 in general we prefer signed. When given a limit, use a
2393 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2394 latter isn't right if USE_2_TAGS_FOR_INTS.
2395 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2396 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2397
2398 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2399
2400 * textprop.c (text_property_stickiness):
2401 Obey Vtext_property_default_nonsticky.
2402 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2403 * w32fns.c (syms_of_w32fns):
2404 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2405
2406 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2407
2408 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2409 This is more efficient than Ffile_directory_p and avoids a minor race.
2410
2411 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2412
2413 * buffer.c (Foverlay_put): Say what the return value is
2414 (bug#7835).
2415
2416 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2417 is a directory before asking whether to use the file name
2418 (bug#7564).
2419 (barf_or_query_if_file_exists): Make the "File is a directory"
2420 error be more correct.
2421
2422 * fns.c (Frequire): Remove the mention of the .gz files, since
2423 that's installation-specific, but keep the mention of
2424 `get-load-suffixes'.
2425
2426 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2427
2428 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2429 Report string overflow if the output is too long.
2430
2431 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2432
2433 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2434 (syms_of_gnutls): Remove duplicate DEFSYM for
2435 Qgnutls_bootprop_verify_hostname_error, an error for
2436 Qgnutls_bootprop_verify_error (which is no longer used).
2437
2438 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2439 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2440 Also (re)move comments that are misplaced or no longer relevant.
2441
2442 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2443
2444 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2445
2446 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2447
2448 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2449 and background color parameters if they have been changed.
2450
2451 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2452
2453 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2454
2455 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2456
2457 * xsettings.c (SYSTEM_FONT): Define only when used.
2458 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2459
2460 * keymap.c (access_keymap_1): Now static.
2461
2462 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2463
2464 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2465 leave any prefix arg for the up event (Bug#1586).
2466
2467 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2468
2469 * lread.c (syms_of_lread): Mention single symbols defined by
2470 `defvar' or `defconst' (bug#7154).
2471
2472 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2473 (Frequire): Mention get-load-suffixes.
2474
2475 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2476
2477 * window.h (window): Remove clone_number slot.
2478 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2479 Remove.
2480 (make_parent_window, make_window, saved_window)
2481 (Fset_window_configuration, save_window_save): Don't deal with
2482 clone numbers.
2483 * buffer.c (Qclone_number): Remove declaration.
2484 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2485
2486 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2487
2488 Add multiple inheritance to keymaps.
2489 * keymap.c (Fmake_composed_keymap): New function.
2490 (Fset_keymap_parent): Simplify.
2491 (fix_submap_inheritance): Remove.
2492 (access_keymap_1): New function extracted from access_keymap to handle
2493 embedded parents and handle lists of maps.
2494 (access_keymap): Use it.
2495 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2496 (Fcopy_keymap): Handle embedded parents.
2497 (Fcommand_remapping, define_as_prefix): Simplify.
2498 (Fkey_binding): Simplify.
2499 (syms_of_keymap): Move minibuffer-local-completion-map,
2500 minibuffer-local-filename-completion-map,
2501 minibuffer-local-must-match-map, and
2502 minibuffer-local-filename-must-match-map to Elisp.
2503 (syms_of_keymap): Defsubr make-composed-keymap.
2504 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2505 (parse_menu_item): Trivial simplification.
2506
2507 2011-07-01 Glenn Morris <rgm@gnu.org>
2508
2509 * Makefile.in (SETTINGS_LIBS): Fix typo.
2510
2511 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2512
2513 * coding.c (Fencode_coding_string): Record the last coding system
2514 used, as the function doc string says (bug#8738).
2515
2516 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2517
2518 * xsettings.c (store_monospaced_changed): Take new font as arg and
2519 check for change against current_mono_font.
2520 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2521 (emacs_settings_constructor, emacs_settings_get_property)
2522 (emacs_settings_set_property, emacs_settings_class_init)
2523 (emacs_settings_init, gsettings_obj): Remove.
2524 (something_changedCB): New function for HAVE_GSETTINGS.
2525 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2526 with value as argument.
2527 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2528 g_settings_new (Bug#8967). Do not create gsettings_obj.
2529 Remove calls to g_settings_bind. Connect something_changedCB to
2530 "changed".
2531
2532 * xgselect.c: Add defined (HAVE_GSETTINGS).
2533 (xgselect_initialize): Ditto.
2534
2535 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2536 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2537 xg_select.
2538
2539 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2540
2541 * eval.c (struct backtrace): Simplify and port the data structure.
2542 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2543 signed bit field, as this assumption is not portable and it makes
2544 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2545 "char debug_on_exit : 1" as this is not portable either; instead,
2546 use the portable "unsigned int debug_on_exit : 1". Remove unused
2547 member evalargs. Remove obsolete comments about cc bombing out.
2548
2549 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2550
2551 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2552 Let HAVE_GSETTINGS override HAVE_GCONF.
2553 (store_monospaced_changed): New function.
2554 (EMACS_SETTINGS): A new type derived from GObject to handle
2555 GSettings notifications.
2556 (emacs_settings_constructor, emacs_settings_get_property)
2557 (emacs_settings_set_property, emacs_settings_class_init):
2558 New functions.
2559 (gsettings_client, gsettings_obj): New variables.
2560 (GSETTINGS_SCHEMA): New define.
2561 (something_changedCB): Call store_monospaced_changed.
2562 (init_gsettings): New function.
2563 (xsettings_initialize): Call init_gsettings.
2564 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2565 to NULL.
2566
2567 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2568 GCONF_CFLAGS/LIBS.
2569
2570 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2571
2572 * window.c (resize_root_window, grow_mini_window)
2573 (shrink_mini_window): Rename Qresize_root_window to
2574 Qwindow_resize_root_window and Qresize_root_window_vertically to
2575 Qwindow_resize_root_window_vertically.
2576
2577 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2578
2579 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2580
2581 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2582
2583 * makefile.w32-in: Redesign dependencies so they reflect more
2584 clearly which files are directly included by each source file,
2585 and not through other includes.
2586
2587 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2588
2589 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2590 (sort_overlays, overlay_strings): When an overlay's clone number
2591 matches the window's clone number process the overlay even if
2592 the overlay's window property doesn't match the current window.
2593
2594 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2595 (Fwindow_hchild): Rename to Fwindow_left_child.
2596 (Fwindow_next): Rename to Fwindow_next_sibling.
2597 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2598 (resize_window_check): Rename to window_resize_check.
2599 (resize_window_apply): Rename to window_resize_apply.
2600 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2601 (Fdelete_other_windows_internal, resize_frame_windows)
2602 (Fsplit_window_internal, Fdelete_window_internal)
2603 (grow_mini_window, shrink_mini_window)
2604 (Fresize_mini_window_internal): Fix callers accordingly.
2605
2606 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2607
2608 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2609 (emacs_fixed_set_min_size): Remove.
2610 (emacs_fixed_new): Take frame as argument.
2611
2612 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2613 (_EmacsFixedPrivate): Remove minwidth/height.
2614 Add struct frame *f.
2615 (emacs_fixed_init): Initialize priv->f.
2616 (get_parent_class, emacs_fixed_set_min_size): Remove.
2617 (emacs_fixed_new): Set priv->f to argument.
2618 (emacs_fixed_get_preferred_width)
2619 (emacs_fixed_get_preferred_height): Use min_width/height from
2620 frames size_hint to set minimum and natural (Bug#8919).
2621 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2622 and use min_width/height from frames size_hint to set
2623 min_width/height (Bug#8919).
2624
2625 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2626 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2627 Fix indentation.
2628
2629 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2630
2631 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2632 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2633 called at ZV.
2634
2635 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2636
2637 * process.c (wait_reading_process_output): Bypass select if
2638 waiting for a cell while ignoring keyboard input, and input is
2639 pending. Suggested by Jan Djärv (Bug#8869).
2640
2641 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2642
2643 Use gnulib's dup2 module instead of rolling our own.
2644 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2645
2646 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2647
2648 * dispnew.c (scrolling_window): Before scrolling, turn off a
2649 mouse-highlight in the window being scrolled.
2650
2651 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2652
2653 Move DEFSYM to lisp.h and use everywhere.
2654
2655 * character.h (DEFSYM): Move declaration...
2656 * lisp.h (DEFSYM): ...here.
2657
2658 * gnutls.c:
2659 * minibuf.c:
2660 * w32menu.c:
2661 * w32proc.c:
2662 * w32select.c: Don't include character.h.
2663
2664 * alloc.c (syms_of_alloc):
2665 * buffer.c (syms_of_buffer):
2666 * bytecode.c (syms_of_bytecode):
2667 * callint.c (syms_of_callint):
2668 * casefiddle.c (syms_of_casefiddle):
2669 * casetab.c (init_casetab_once):
2670 * category.c (init_category_once, syms_of_category):
2671 * ccl.c (syms_of_ccl):
2672 * cmds.c (syms_of_cmds):
2673 * composite.c (syms_of_composite):
2674 * dbusbind.c (syms_of_dbusbind):
2675 * dired.c (syms_of_dired):
2676 * dispnew.c (syms_of_display):
2677 * doc.c (syms_of_doc):
2678 * editfns.c (syms_of_editfns):
2679 * emacs.c (syms_of_emacs):
2680 * eval.c (syms_of_eval):
2681 * fileio.c (syms_of_fileio):
2682 * fns.c (syms_of_fns):
2683 * frame.c (syms_of_frame):
2684 * fringe.c (syms_of_fringe):
2685 * insdel.c (syms_of_insdel):
2686 * keymap.c (syms_of_keymap):
2687 * lread.c (init_obarray, syms_of_lread):
2688 * macros.c (syms_of_macros):
2689 * msdos.c (syms_of_msdos):
2690 * print.c (syms_of_print):
2691 * process.c (syms_of_process):
2692 * search.c (syms_of_search):
2693 * sound.c (syms_of_sound):
2694 * syntax.c (init_syntax_once, syms_of_syntax):
2695 * terminal.c (syms_of_terminal):
2696 * textprop.c (syms_of_textprop):
2697 * undo.c (syms_of_undo):
2698 * w32.c (globals_of_w32):
2699 * window.c (syms_of_window):
2700 * xdisp.c (syms_of_xdisp):
2701 * xfaces.c (syms_of_xfaces):
2702 * xfns.c (syms_of_xfns):
2703 * xmenu.c (syms_of_xmenu):
2704 * xsettings.c (syms_of_xsettings):
2705 * xterm.c (syms_of_xterm): Use DEFSYM.
2706
2707 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2708
2709 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2710
2711 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2712
2713 Integer and buffer overflow fixes (Bug#8873).
2714
2715 * print.c (printchar, strout): Check for string overflow.
2716 (PRINTPREPARE, printchar, strout):
2717 Don't set size unless allocation succeeds.
2718
2719 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2720 for sizes. Check for string overflow more accurately.
2721 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2722
2723 * macros.c: Integer and buffer overflow fixes.
2724 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2725 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2726 Use ptrdiff_t, not int, for sizes.
2727 Don't increment bufsize until after realloc succeeds.
2728 Check for size-calculation overflow.
2729 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2730
2731 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2732
2733 * lread.c: Integer overflow fixes.
2734 (read_integer): Radix is now EMACS_INT, not int,
2735 to improve quality of diagnostics for out-of-range radices.
2736 Calculate buffer size correctly for out-of-range radices.
2737 (read1): Check for integer overflow in radices, and in
2738 read-circle numbers.
2739 (read_escape): Avoid int overflow.
2740 (Fload, openp, read_buffer_size, read1)
2741 (substitute_object_recurse, read_vector, read_list, map_obarray):
2742 Use ptrdiff_t, not int, for sizes.
2743 (read1): Use EMACS_INT, not int, for sizes.
2744 Check for size overflow.
2745
2746 * image.c (cache_image): Check for size arithmetic overflow.
2747
2748 * lread.c: Integer overflow issues.
2749 (saved_doc_string_size, saved_doc_string_length)
2750 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2751 Now ptrdiff_t, not int.
2752 (read1): Don't assume doc string length fits in int. Check for
2753 out-of-range doc string lengths.
2754 (read_list): Don't assume file position fits in int.
2755 (read_escape): Check for hex character overflow.
2756
2757 2011-06-22 Leo Liu <sdl.web@gmail.com>
2758
2759 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2760 Move to minibuffer.el.
2761
2762 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2763
2764 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2765 The following patches are for when GLYPH_DEBUG && !XASSERT.
2766 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2767 * dispnew.c (flush_stdout):
2768 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2769 Mark as externally visible.
2770 * dispnew.c (check_window_matrix_pointers): Now static.
2771 * dispnew.c (window_to_frame_vpos):
2772 * xfns.c (unwind_create_frame):
2773 * xterm.c (x_check_font): Remove unused local.
2774 * scroll.c (CHECK_BOUNDS):
2775 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2776 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2777 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2778 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2779 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2780 Now static.
2781 (debug_method_add): Use va_list and vsprintf rather than relying
2782 on undefined behavior with wrong number of arguments.
2783 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2784 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2785 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2786 since we're not interested in debugging glyphs with old libraries.
2787 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2788 GCC 4.6.0's static checking.
2789
2790 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2791
2792 Integer overflow and signedness fixes (Bug#8873).
2793 A few related buffer overrun fixes, too.
2794
2795 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2796
2797 * dispextern.h (struct face.stipple):
2798 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2799 (x_bitmap_mask, x_allocate_bitmap_record)
2800 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2801 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2802 (x_create_bitmap_from_xpm_data):
2803 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2804 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2805 (.bitmaps_last):
2806 * xfaces.c (load_pixmap):
2807 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2808 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2809 (.bitmaps_last, struct x_output.icon_bitmap):
2810 Use ptrdiff_t, not int, for bitmap indexes.
2811 (x_allocate_bitmap_record): Check for size overflow.
2812 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2813
2814 Use ptrdiff_t, not int, for overlay counts.
2815 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2816 * editfns.c (overlays_around, get_pos_property):
2817 * textprop.c (get_char_property_and_overlay):
2818 * xdisp.c (next_overlay_change, note_mouse_highlight):
2819 * xfaces.c (face_at_buffer_position):
2820 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2821 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2822 (Fnext_overlay_change, Fprevious_overlay_change)
2823 (mouse_face_overlay_overlaps, Foverlays_in):
2824 Use ptrdiff_t, not int, for sizes.
2825 (overlays_at, overlays_in): Check for size-calculation overflow.
2826
2827 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2828
2829 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2830 (x_session_initialize): Do not assume string length fits in int.
2831
2832 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2833 This is unlikely, but can occur if DPI is outlandish.
2834
2835 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2836 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2837
2838 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2839 * xrdb.c (magic_file_p, search_magic_path):
2840 Omit last arg SUFFIX; it was always 0. All callers changed.
2841 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2842
2843 * xfont.c (xfont_match): Avoid need for strlen.
2844
2845 * xfns.c: Don't assume strlen fits in int.
2846 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2847
2848 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2849 not unsigned long, as we prefer signed integers. All callers changed.
2850 Detect integer overflow in repeat count.
2851 (message_dolog): Don't assume print length fits in 39 bytes.
2852 (display_mode_element): Don't assume strlen fits in int.
2853
2854 * termcap.c: Don't assume sizes fit in int and never overflow.
2855 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2856 (gobble_line): Check for size-calculation overflow.
2857
2858 * minibuf.c (Fread_buffer):
2859 * lread.c (intern, intern_c_string):
2860 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2861 Don't assume string length fits in int.
2862
2863 * keyboard.c (parse_tool_bar_item):
2864 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2865
2866 * font.c: Don't assume string length fits in int.
2867 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2868 Use ptrdiff_t, not int.
2869 (font_intern_prop): Don't assume string length fits in int.
2870 Don't assume integer property fits in fixnum.
2871 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2872
2873 * filelock.c: Fix some buffer overrun and integer overflow issues.
2874 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2875 Reformulate so as not to need the command string.
2876 Invoke gzip -cd rather than gunzip, as it's more portable.
2877 (lock_info_type, lock_file_1, lock_file):
2878 Don't assume pid_t and time_t fit in unsigned long.
2879 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2880 (current_lock_owner): Prefer signed type for sizes.
2881 Use memcpy, not strncpy, where memcpy is what is really wanted.
2882 Don't assume (via atoi) that time_t and pid_t fit in int.
2883 Check for time_t and/or pid_t out of range, e.g., via a network share.
2884 Don't alloca where an auto var works fine.
2885
2886 * fileio.c: Fix some integer overflow issues.
2887 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2888 Don't assume string length fits in int.
2889 (directory_file_name): Don't assume string length fits in long.
2890 (make_temp_name): Don't assume pid fits in int, or that its print
2891 length is less than 20.
2892
2893 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2894
2895 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2896
2897 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2898
2899 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2900 We prefer signed integers, even for size calculations.
2901
2902 * emacs.c: Don't assume string length fits in 'int'.
2903 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2904 (main): Don't invoke strlen when not needed.
2905
2906 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2907 (XD_DEBUG_MESSAGE): Don't waste a byte.
2908
2909 * callproc.c (getenv_internal_1, getenv_internal)
2910 (Fgetenv_internal):
2911 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2912
2913 * lread.c (invalid_syntax): Omit length argument.
2914 All uses changed. This doesn't fix a bug, but it simplifies the
2915 code away from its former Hollerith-constant appearance, and it's
2916 one less 'int' to worry about when looking at integer-overflow issues.
2917 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2918
2919 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2920 This didn't break anything, but it didn't help either.
2921 It's confusing to put a bogus integer in a place where the actual
2922 value does not matter.
2923 (LIST_END_P): Remove unused macro and its bogus comment.
2924 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2925
2926 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2927 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2928 implementation.
2929 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2930 We prefer signed types, and the value cannot exceed the EMACS_INT
2931 range anyway (because otherwise the length would not be representable).
2932 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2933 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2934 This avoids a GCC warning when WIDE_EMACS_INT.
2935
2936 * indent.c (sane_tab_width): New function.
2937 (current_column, scan_for_column, Findent_to, position_indentation)
2938 (compute_motion): Use it. This is just for clarity.
2939 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2940
2941 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2942
2943 * lisp.h (lint_assume): New macro.
2944 * composite.c (composition_gstring_put_cache):
2945 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2946
2947 * editfns.c, insdel.c:
2948 Omit unnecessary forward decls, to simplify future changes.
2949
2950 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2951
2952 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2953
2954 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2955 Use much-faster test for byte-length change.
2956 Don't assume string byte-length fits in 'int'.
2957 Check that character arg fits in 'int'.
2958 (mapcar1): Declare byte as byte, for clarity.
2959
2960 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2961
2962 * fns.c (concat): Catch string overflow earlier.
2963 Do not rely on integer wraparound.
2964
2965 * dispextern.h (struct it.overlay_strings_charpos)
2966 (struct it.selective): Now EMACS_INT, not int.
2967 * xdisp.c (forward_to_next_line_start)
2968 (back_to_previous_visible_line_start)
2969 (reseat_at_next_visible_line_start, next_element_from_buffer):
2970 Don't arbitrarily truncate the value of 'selective' to int.
2971
2972 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2973
2974 * composite.c: Don't truncate sizes to 'int'.
2975 (composition_gstring_p, composition_reseat_it)
2976 (composition_adjust_point): Use EMACS_INT, not int.
2977 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2978 not EMACS_UINT, for indexes.
2979
2980 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2981
2982 * buffer.c: Include <verify.h>.
2983 (struct sortvec.priority, struct sortstr.priority):
2984 Now EMACS_INT, not int.
2985 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2986 (struct sortstr.size, record_overlay_string)
2987 (struct sortstrlist.size, struct sortlist.used):
2988 Don't truncate size to int.
2989 (record_overlay_string): Check for size-calculation overflow.
2990 (init_buffer_once): Check at compile-time, not run-time.
2991
2992 2011-06-22 Jim Meyering <meyering@redhat.com>
2993
2994 Don't leak an XBM-image-sized buffer
2995 * image.c (xbm_load): Free the image buffer after using it.
2996
2997 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2998
2999 Port to Sun C.
3000 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3001 that Sun C diagnosed.
3002 * fns.c (secure_hash): Fix pointer signedness issue.
3003 * intervals.c (static_offset_intervals): New function.
3004 (offset_intervals): Use it.
3005
3006 2011-06-21 Leo Liu <sdl.web@gmail.com>
3007
3008 * deps.mk (fns.o):
3009 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3010 sha512.h.
3011
3012 * fns.c (secure_hash): Rename from crypto_hash_function and change
3013 the first arg to accept symbols.
3014 (Fsecure_hash): New primitive.
3015 (syms_of_fns): New symbols.
3016
3017 2011-06-20 Deniz Dogan <deniz@dogan.se>
3018
3019 * process.c (Fset_process_buffer): Clarify return value in
3020 docstring.
3021
3022 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3023
3024 * dispnew.c (add_window_display_history): Use BVAR.
3025
3026 * xdisp.c (debug_method_add): Use BVAR.
3027 (check_window_end, dump_glyph_matrix, dump_glyph)
3028 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3029
3030 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3031 Likewise.
3032
3033 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3034 check till after the cache is created in init_frame_faces.
3035
3036 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3037
3038 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3039
3040 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3041
3042 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3043 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3044 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3045
3046 Improve buffer-overflow checking (Bug#8873).
3047 * fileio.c (Finsert_file_contents):
3048 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3049 Remove the old (too-loose) buffer overflow checks.
3050 They weren't needed, since make_gap checks for buffer overflow.
3051 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3052 The old code merely checked for Emacs fixnum overflow, and relied
3053 on undefined (wraparound) behavior. The new code avoids undefined
3054 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3055
3056 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3057 Tune. Don't use wider integers than needed. Don't use alloca.
3058 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3059
3060 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3061
3062 * insdel.c, lisp.h (buffer_overflow): New function.
3063 (insert_from_buffer_1, replace_range, replace_range_2):
3064 * insdel.c (make_gap_larger):
3065 * editfns.c (Finsert_char):
3066 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3067
3068 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3069
3070 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3071
3072 Integer overflow and signedness fixes (Bug#8873).
3073
3074 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3075 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3076
3077 * fileio.c: Don't assume EMACS_INT fits in off_t.
3078 (emacs_lseek): New static function.
3079 (Finsert_file_contents, Fwrite_region): Use it.
3080 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3081
3082 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3083
3084 * fns.c: Don't overflow int when computing a list length.
3085 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3086 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3087 truncation on 64-bit hosts. Check for QUIT every
3088 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3089 faster and is responsive enough.
3090 (Flength): Report an error instead of overflowing an integer.
3091 (Fsafe_length): Return a float if the value is not representable
3092 as a fixnum. This shouldn't happen except in contrived situations.
3093 (Fnthcdr, Fsort): Don't assume list length fits in int.
3094 (Fcopy_sequence): Don't assume vector length fits in int.
3095
3096 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3097 (header_size, word_size): New constants.
3098 (allocate_vectorlike): Don't check size overflow here.
3099 (allocate_vector): Check it here instead, since this is the only
3100 caller of allocate_vectorlike that could cause overflow.
3101 Check that the new vector's length is representable as a fixnum.
3102
3103 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3104 The previous code was bogus. For example, next_almost_prime (32)
3105 returned 39, which is undesirable as it is a multiple of 3; and
3106 next_almost_prime (24) returned 25, which is a multiple of 5 so
3107 why was the code bothering to check for multiples of 7?
3108
3109 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3110
3111 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3112
3113 Variadic C functions now count arguments with ptrdiff_t.
3114 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3115 Back then I didn't know that the Emacs coding style prefers signed int.
3116 Also, in the meantime I found a few more instances where arguments
3117 were being counted with int, which may truncate counts on 64-bit
3118 machines, or EMACS_INT, which may be unnecessarily wide.
3119 * lisp.h (struct Lisp_Subr.function.aMANY)
3120 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3121 Arg counts are now ptrdiff_t, not size_t.
3122 All variadic functions and their callers changed accordingly.
3123 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3124 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3125 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3126 * callint.c (Fcall_interactively): Check arg count for overflow,
3127 to avoid potential buffer overrun. Use signed char, not 'int',
3128 for 'varies' array, so that we needn't bother to check its size
3129 calculation for overflow.
3130 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3131 * eval.c (apply_lambda):
3132 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3133 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3134 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3135
3136 * callint.c (Fcall_interactively): Don't use index var as event count.
3137
3138 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3139 * mem-limits.h (SIZE): Remove; no longer used.
3140
3141 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3142
3143 Remove unnecessary casts.
3144 * xterm.c (x_term_init):
3145 * xfns.c (x_set_border_pixel):
3146 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3147 These aren't needed now that we assume ANSI C.
3148
3149 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3150 It's more likely to cause problems (due to unsigned overflow)
3151 than to cure them.
3152
3153 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3154
3155 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3156
3157 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3158
3159 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3160
3161 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3162
3163 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3164
3165 GLYPH_CODE_FACE returns EMACS_INT, not int.
3166 * dispextern.h (merge_faces):
3167 * xfaces.c (merge_faces):
3168 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3169 Don't assume EMACS_INT fits in int.
3170
3171 * character.h (CHAR_VALID_P): Remove unused parameter.
3172 * fontset.c, lisp.h, xdisp.c: All uses changed.
3173
3174 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3175
3176 * fns.c (concat): Minor tuning based on overflow analysis.
3177 This doesn't fix any bugs. Use int to hold character, instead
3178 of constantly refetching from Emacs object. Use XFASTINT, not
3179 XINT, for value known to be a character. Don't bother comparing
3180 a single byte to 0400, as it's always less.
3181
3182 * floatfns.c (Fexpt):
3183 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3184
3185 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3186 for characters.
3187
3188 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3189
3190 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3191 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3192 incorrectly succeed when S was a string, because 4294967386 was
3193 truncated before it was used.
3194
3195 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3196 Otherwise, an out-of-range integer could cause undefined behavior
3197 on a 64-bit host.
3198
3199 * composite.c: Use int, not EMACS_INT, for characters.
3200 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3201 EMACS_INT, for values that are known to be in character range.
3202 This doesn't fix any bugs but is the usual style inside Emacs and
3203 may generate better code on 32-bit machines.
3204
3205 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3206 This is for reasons similar to the recent CHAR_STRING fix.
3207 * charset.c (Fencode_char): Check that character arg is actually
3208 a character. Pass an int to ENCODE_CHAR.
3209 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3210 wider than 'int', as a compile-time check to prevent future regressions
3211 in this area.
3212
3213 * character.c (char_string): Remove unnecessary casts.
3214
3215 Make sure a 64-bit char is never passed to CHAR_STRING.
3216 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3217 by silently ignoring the top 32 bits, allowing some values
3218 that were far too large to be valid characters.
3219 * character.h: Include <verify.h>.
3220 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3221 arguments are no wider than unsigned, as a compile-time check
3222 to prevent future regressions in this area.
3223 * data.c (Faset):
3224 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3225 (Fsubst_char_in_region):
3226 * fns.c (concat):
3227 * xdisp.c (decode_mode_spec_coding):
3228 Adjust to CHAR_STRING's new requirement.
3229 * editfns.c (Finsert_char, Fsubst_char_in_region):
3230 * fns.c (concat): Check that character args are actually
3231 characters. Without this test, these functions did the wrong
3232 thing with wildly out-of-range values on 64-bit hosts.
3233
3234 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3235 These casts should not be needed on 32-bit hosts, either.
3236 * keyboard.c (read_char):
3237 * lread.c (Fload): Remove casts to unsigned.
3238
3239 * lisp.h (UNSIGNED_CMP): New macro.
3240 This fixes comparison bugs on 64-bit hosts.
3241 (ASCII_CHAR_P): Use it.
3242 * casefiddle.c (casify_object):
3243 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3244 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3245 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3246 * dispextern.h (FACE_FROM_ID):
3247 * keyboard.c (read_char): Use UNSIGNED_CMP.
3248
3249 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3250 not to EMACS_INT, to avoid GCC warning.
3251
3252 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3253
3254 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3255 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3256 isn't needed on 32-bit machines.
3257
3258 * buffer.c (Fgenerate_new_buffer_name):
3259 Use EMACS_INT for count, not int.
3260 (advance_to_char_boundary): Return EMACS_INT, not int.
3261
3262 * data.c (Qcompiled_function): Now static.
3263
3264 * window.c (window_body_lines): Now static.
3265
3266 * image.c (gif_load): Rename local to avoid shadowing.
3267
3268 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3269 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3270 * alloc.c (make_save_value): Integer argument is now of type
3271 ptrdiff_t, not int.
3272 (mark_object): Use ptrdiff_t, not int.
3273 * lisp.h (pD): New macro.
3274 * print.c (print_object): Use it.
3275
3276 * alloc.c: Use EMACS_INT, not int, to count objects.
3277 (total_conses, total_markers, total_symbols, total_vector_size)
3278 (total_free_conses, total_free_markers, total_free_symbols)
3279 (total_free_floats, total_floats, total_free_intervals)
3280 (total_intervals, total_strings, total_free_strings):
3281 Now EMACS_INT, not int. All uses changed.
3282 (Fgarbage_collect): Compute overall total using a double, so that
3283 integer overflow is less likely to be a problem. Check for overflow
3284 when converting back to an integer.
3285 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3286 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3287 These were 'int' variables that could overflow on 64-bit hosts;
3288 they were never used, so remove them instead of repairing them.
3289 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3290 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3291 Previously, this ceilinged at INT_MAX, but that doesn't work on
3292 64-bit machines.
3293 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3294
3295 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3296 (allocate_vectorlike): Check for ptrdiff_t overflow.
3297 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3298 when a (possibly-narrower) signed value would do just as well.
3299 We prefer using signed arithmetic, to avoid comparison confusion.
3300
3301 * alloc.c: Catch some string size overflows that we were missing.
3302 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3303 for convenience in STRING_BYTES_MAX.
3304 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3305 The definition here is exact; the one in lisp.h was approximate.
3306 (allocate_string_data): Check for string overflow. This catches
3307 some instances we weren't catching before. Also, it catches
3308 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3309 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3310 and ptrdiff_t and EMACS_INT are both 64 bits.
3311
3312 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3313 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3314 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3315
3316 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3317
3318 * alloc.c (Fmake_string): Check for out-of-range init.
3319
3320 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3321
3322 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3323
3324 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3325
3326 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3327 xg_get_default_scrollbar_width.
3328
3329 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3330 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3331 (style_changed_cb): Call update_theme_scrollbar_width and call
3332 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3333 all frames (Bug#8505).
3334 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3335 Call gtk_window_set_resizable if HAVE_GTK3.
3336 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3337 and height if HAVE_GTK3 (Bug#8505).
3338 (scroll_bar_width_for_theme): New variable.
3339 (update_theme_scrollbar_width): New function.
3340 (xg_get_default_scrollbar_width): Move code to
3341 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3342 (xg_initialize): Call update_theme_scrollbar_width.
3343
3344 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3345
3346 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3347
3348 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3349
3350 * frame.c (make_frame): Call other_buffer_safely instead of
3351 other_buffer.
3352
3353 * window.c (temp_output_buffer_show): Call display_buffer with
3354 second argument Vtemp_buffer_show_specifiers and reset latter
3355 immediately after the call.
3356 (Vtemp_buffer_show_specifiers): New variable.
3357 (auto_window_vscroll_p, next_screen_context_lines)
3358 (Vscroll_preserve_screen_position): Remove leading asterisks from
3359 doc-strings.
3360
3361 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3362
3363 Fix minor problems found by GCC 4.6.0 static checking.
3364 * buffer.c (Qclone_number): Remove for now, as it's unused.
3365 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3366 (record_buffer): Remove unused local.
3367 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3368 (set_frame_buffer_list): Remove; unused.
3369 * frame.h (other_visible_frames): Remove decl.
3370 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3371 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3372 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3373 if HAVE_GPM.
3374 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3375 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3376 Define only if HAVE_GPM.
3377 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3378 (update_hints_inhibit): Remove; never set. All uses removed.
3379 * widgetprv.h (emacsFrameClassRec): Remove decl.
3380 * window.c (delete_deletable_window): Now returns void, since it
3381 wasn't returning anything.
3382 (compare_window_configurations): Remove unused locals.
3383 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3384 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3385 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3386 the same widths as pointers. This follows up on the 2011-05-06 patch.
3387 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3388 * xterm.h: Likewise.
3389 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3390
3391 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3392
3393 * makefile.w32-in: Update dependencies.
3394 (LISP_H): Add lib/intprops.h.
3395
3396 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3397
3398 * image.c (gif_load): Add animation frame delay to the metadata.
3399 (syms_of_image): Use DEFSYM. New symbol `delay'.
3400
3401 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3402
3403 * window.c (delete_deletable_window): Re-add.
3404 (Fset_window_configuration): Rewrite to handle dead buffers and
3405 consequently deletable windows.
3406 (window_tree, Fwindow_tree): Remove. Supply functionality in
3407 window.el.
3408 (compare_window_configurations): Simplify code.
3409
3410 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3411
3412 * image.c (imagemagick_load_image): Fix type mismatch.
3413 (Fimagemagick_types): Likewise.
3414
3415 * window.h (replace_buffer_in_windows): Declare.
3416
3417 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3418
3419 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3420 Qclone_number. Remove external declaration of Qdelete_window.
3421 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3422 code.
3423 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3424 Run Qbuffer_list_update_hook if allowed.
3425 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3426 buffer list implementation.
3427 (other_buffer_safely): New function.
3428 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3429 calls to replace_buffer_in_windows and
3430 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3431 if allowed.
3432 (record_buffer): Inhibit quitting and rewrite using quittable
3433 functions. Run Qbuffer_list_update_hook if allowed.
3434 (Frecord_buffer, Funrecord_buffer): New functions.
3435 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3436 Move switch-to-buffer to window.el.
3437 (bury-buffer): Move to window.el.
3438 (Vbuffer_list_update_hook): New variable.
3439
3440 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3441 section.
3442
3443 * window.h (resize_frame_windows): Move up in code.
3444 (Fwindow_frame): Remove EXFUN.
3445 (replace_buffer_in_all_windows): Remove prototype.
3446 (replace_buffer_in_windows_safely): Add prototype.
3447
3448 * window.c: Declare Qdelete_window static again. Move down
3449 declaration of select_count.
3450 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3451 (Fother_window): Move to window.el.
3452 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3453 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3454 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3455 window.el.
3456 (replace_buffer_in_windows): Implement by calling
3457 Qreplace_buffer_in_windows.
3458 (replace_buffer_in_all_windows): Remove with some functionality
3459 moved into replace_buffer_in_windows_safely.
3460 (replace_buffer_in_windows_safely): New function.
3461 (select_window_norecord, select_frame_norecord): Move in front
3462 of run_window_configuration_change_hook. Remove now obsolete
3463 declarations.
3464 (Fset_window_buffer): Rewrite doc-string.
3465 Call Qrecord_window_buffer.
3466 (keys_of_window): Move binding for other-window to window.el.
3467
3468 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3469
3470 * dispextern.h (struct image): Replace data member, whose int_val
3471 and ptr_val fields were not used by anything, with a single
3472 lisp_val object.
3473
3474 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3475 (gif_clear_image, gif_load, imagemagick_load_image)
3476 (gs_clear_image, gs_load): Callers changed.
3477
3478 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3479
3480 * buffer.h: Include <time.h>, for time_t.
3481 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3482
3483 Fix minor problems found by static checking.
3484
3485 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3486
3487 Make identifiers static if they are not used in other modules.
3488 * data.c (Qcompiled_function, Qframe, Qvector):
3489 * image.c (QimageMagick, Qsvg):
3490 * minibuf.c (Qmetadata):
3491 * window.c (resize_window_check, resize_root_window): Now static.
3492 * window.h (resize_window_check, resize_root_window): Remove decls.
3493
3494 * window.c (window_deletion_count, delete_deletable_window):
3495 Remove; unused.
3496 (window_body_lines): Now static.
3497 (Fdelete_other_windows_internal): Mark vars as initialized.
3498 Make sure 'resize_failed' is initialized.
3499 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3500 (resize_window_apply): Remove unused local.
3501 * window.h (delete_deletable_window): Remove decl.
3502
3503 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3504 (imagemagick_load_image): Fix pointer signedness problem by changing
3505 last arg from unsigned char * to char *. All uses changed.
3506 Also, fix a local for similar reasons.
3507 Remove unused locals. Remove locals to avoid shadowing.
3508 (fn_rsvg_handle_free): Remove; unused.
3509 (svg_load, svg_load_image): Fix pointer signedness problem.
3510 (imagemagick_load_image): Don't use garbage pointer image_wand.
3511
3512 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3513
3514 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3515
3516 * image.c (gif_load): Fix omitted cast error introduced by
3517 2011-06-06 change.
3518
3519 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3520
3521 * window.h (resize_proportionally, orig_total_lines)
3522 (orig_top_line): Remove from window structure.
3523 (set_window_height, set_window_width, change_window_heights)
3524 (Fdelete_window): Remove prototypes.
3525 (resize_frame_windows): Remove duplicate declaration.
3526
3527 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3528
3529 * window.h (resize_frame_windows, resize_window_check)
3530 (delete_deletable_window, resize_root_window)
3531 (resize_frame_windows): Declare prototypes.
3532
3533 * window.c (resize_window_apply): Make definition be "static" to
3534 match the prototype.
3535
3536 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3537
3538 * window.c: Remove declarations of Qwindow_size_fixed,
3539 window_min_size_1, window_min_size_2, window_min_size,
3540 size_window, window_fixed_size_p, enlarge_window, delete_window.
3541 Remove static from declaration of Qdelete_window, it's
3542 temporarily needed by Fbury_buffer.
3543 (replace_window): Don't assign orig_top_line and
3544 orig_total_lines.
3545 (Fdelete_window, delete_window): Remove. Window deletion is
3546 handled by window.el.
3547 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3548 Replace Fdelete_window calls with calls to Qdelete_window.
3549 (Fdelete_other_windows): Remove. Deleting other windows is
3550 handled by window.el.
3551 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3552 handled in window.el.
3553 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3554 Window minimum sizes are handled in window.el.
3555 (shrink_windows, size_window, set_window_height)
3556 (set_window_width, change_window_heights, window_height)
3557 (window_width, CURBEG, CURSIZE, enlarge_window)
3558 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3559 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3560 handled in window.el.
3561 (make_dummy_parent): Rename to make_parent_window and give it a
3562 second argument horflag.
3563 (make_window): Don't set resize_proportionally any more.
3564 (Fsplit_window): Remove. Windows are split in window.el.
3565 (save_restore_action, save_restore_orig_size)
3566 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3567 Resize mini windows in window.el.
3568 (grow_mini_window, shrink_mini_window): Implement by calling
3569 Qresize_root_window_vertically, resize_window_check and
3570 resize_window_apply.
3571 (saved_window, Fset_window_configuration, save_window_save):
3572 Do not handle orig_top_line, orig_total_lines, and
3573 resize_proportionally.
3574 (window_min_height, window_min_width): Move to window.el.
3575 (keys_of_window): Move bindings for delete-other-windows,
3576 split-window, delete-window and enlarge-window to window.el.
3577
3578 * buffer.c: Temporarily extern Qdelete_window.
3579 (Fbury_buffer): Temporarily call Qdelete_window instead of
3580 Fdelete_window (Fbury_buffer will move to window.el soon).
3581
3582 * frame.c (set_menu_bar_lines_1): Remove code handling
3583 orig_top_line and orig_total_lines.
3584
3585 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3586 set_window_height but set heights directly.
3587 (change_frame_size_1): Use resize_frame_windows.
3588
3589 * xdisp.c (init_xdisp): Don't use set_window_height but set
3590 heights directly.
3591
3592 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3593 Use resize_frame_windows instead of change_window_heights and run
3594 run_window_configuration_change_hook.
3595
3596 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3597 instead of change_window_heights and run
3598 run_window_configuration_change_hook.
3599
3600 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3601
3602 * window.c (replace_window): Rename second argument REPLACEMENT to
3603 NEW. New third argument SETFLAG. Rewrite.
3604 (delete_window, make_dummy_parent): Call replace_window with
3605 third argument 1.
3606 (window_list_1): Move down in code.
3607 (run_window_configuration_change_hook): Move set_buffer part
3608 before select_frame_norecord part in order to unwind correctly.
3609 Rename count1 to count.
3610 (recombine_windows, delete_deletable_window, resize_root_window)
3611 (Fdelete_other_windows_internal)
3612 (Frun_window_configuration_change_hook, make_parent_window)
3613 (resize_window_check, resize_window_apply, Fresize_window_apply)
3614 (resize_frame_windows, Fsplit_window_internal)
3615 (Fdelete_window_internal, Fresize_mini_window_internal):
3616 New functions.
3617 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3618
3619 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3620
3621 * window.h (window): Add some new members to window structure -
3622 normal_lines, normal_cols, new_total, new_normal, clone_number,
3623 splits, nest, prev_buffers, next_buffers.
3624 (WINDOW_TOTAL_SIZE): Move here from window.c.
3625 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3626
3627 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3628 Remove.
3629 (make_dummy_parent): Set new members of windows structure.
3630 (make_window): Move down in code. Handle new members of window
3631 structure.
3632 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3633 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3634 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3635 (Fset_window_prev_buffers, Fwindow_next_buffers)
3636 (Fset_window_next_buffers, Fset_window_clone_number):
3637 New functions.
3638 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3639 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3640 Doc-string fixes.
3641 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3642 Argument WINDOW can be now internal window too.
3643 (Fwindow_use_time): Move up in code.
3644 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3645 Rewrite doc-string.
3646 (Fset_window_configuration, saved_window)
3647 (Fcurrent_window_configuration, save_window_save): Handle new
3648 members of window structure.
3649 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3650 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3651 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3652 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3653 Qget_mru_window, Qresize_root_window,
3654 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3655 Qauto_buffer_name; staticpro them.
3656
3657 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3658
3659 * window.c (Fwindow_total_size, Fwindow_left_column)
3660 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3661 (Fwindow_list_1): New functions.
3662 (window_box_text_cols): Replace with window_body_cols.
3663 (Fwindow_width, Fscroll_left, Fscroll_right):
3664 Use window_body_cols instead of window_box_text_cols.
3665 (delete_window, Fset_window_configuration):
3666 Call delete_all_subwindows with window as argument.
3667 (delete_all_subwindows): Take a window as argument and not a
3668 structure. Rewrite.
3669 (window_loop): Remove handling of GET_LRU_WINDOW and
3670 GET_LARGEST_WINDOW.
3671 (Fget_lru_window, Fget_largest_window): Move to window.el.
3672
3673 * window.h: Extern window_body_cols instead of
3674 window_box_text_cols. delete_all_subwindows now takes a
3675 Lisp_Object as argument.
3676
3677 * indent.c (compute_motion, Fcompute_motion):
3678 Use window_body_cols instead of window_box_text_cols.
3679
3680 * frame.c (delete_frame): Call delete_all_subwindows with root
3681 window as argument.
3682
3683 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3684
3685 * fns.c (Fputhash): Document return value.
3686
3687 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3688
3689 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3690
3691 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3692
3693 Cons<->int and similar integer overflow fixes (Bug#8794).
3694
3695 Check for overflow when converting integer to cons and back.
3696 * charset.c (Fdefine_charset_internal, Fdecode_char):
3697 Use cons_to_unsigned to catch overflow.
3698 (Fencode_char): Use INTEGER_TO_CONS.
3699 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3700 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3701 * data.c (long_to_cons, cons_to_long): Remove.
3702 (cons_to_unsigned, cons_to_signed): New functions.
3703 These signal an error for invalid or out-of-range values.
3704 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3705 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3706 * font.c (Ffont_variation_glyphs):
3707 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3708 * lisp.h: Include <intprops.h>.
3709 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3710 (cons_to_signed, cons_to_unsigned): New decls.
3711 (long_to_cons, cons_to_long): Remove decls.
3712 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3713 (Fprimitive_undo): Use CONS_TO_INTEGER.
3714 * xfns.c (Fx_window_property): Likewise.
3715 * xselect.c: Include <limits.h>.
3716 (x_own_selection, selection_data_to_lisp_data):
3717 Use INTEGER_TO_CONS.
3718 (x_handle_selection_request, x_handle_selection_clear)
3719 (x_get_foreign_selection, Fx_disown_selection_internal)
3720 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3721 (lisp_data_to_selection_data): Use cons_to_unsigned.
3722 (x_fill_property_data): Use cons_to_signed.
3723 Report values out of range.
3724
3725 Check for buffer and string overflow more precisely.
3726 * buffer.h (BUF_BYTES_MAX): New macro.
3727 * lisp.h (STRING_BYTES_MAX): New macro.
3728 * alloc.c (Fmake_string):
3729 * character.c (string_escape_byte8):
3730 * coding.c (coding_alloc_by_realloc):
3731 * doprnt.c (doprnt):
3732 * editfns.c (Fformat):
3733 * eval.c (verror):
3734 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3735 since they may not be the same number.
3736 * editfns.c (Finsert_char):
3737 * fileio.c (Finsert_file_contents):
3738 Likewise for BUF_BYTES_MAX.
3739
3740 * image.c: Use ptrdiff_t, not int, for sizes.
3741 (slurp_file): Switch from int to ptrdiff_t.
3742 All uses changed.
3743 (slurp_file): Check that file size fits in both size_t (for
3744 malloc) and ptrdiff_t (for sanity and safety).
3745
3746 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3747 if b->modtime has its maximal value.
3748
3749 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3750
3751 Don't assume time_t can fit into int.
3752 * buffer.h (struct buffer.modtime): Now time_t, not int.
3753 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3754 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3755
3756 Minor fixes for signed vs unsigned integers.
3757 * character.h (MAYBE_UNIFY_CHAR):
3758 * charset.c (maybe_unify_char):
3759 * keyboard.c (read_char, reorder_modifiers):
3760 XINT -> XFASTINT, since the integer must be nonnegative.
3761 * ftfont.c (ftfont_spec_pattern):
3762 * keymap.c (access_keymap, silly_event_symbol_error):
3763 XUINT -> XFASTINT, since the integer must be nonnegative.
3764 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3765 since it makes no difference and we prefer signed.
3766 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3767 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3768 nonnegative.
3769
3770 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3771
3772 * window.h (Fwindow_frame): Declare.
3773
3774 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3775
3776 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3777 (SPARE_MEMORY): Always define.
3778 (LARGE_REQUEST): Remove.
3779 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3780
3781 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3782
3783 * lisp.h: Move EXFUNS for Fframe_root_window,
3784 Fframe_first_window and Fset_frame_selected_window to window.h.
3785
3786 * window.h: Move EXFUNS for Fframe_root_window,
3787 Fframe_first_window and Fset_frame_selected_window here from
3788 lisp.h.
3789
3790 * frame.c (Fwindow_frame, Fframe_first_window)
3791 (Fframe_root_window, Fframe_selected_window)
3792 (Fset_frame_selected_window): Move to window.c.
3793 (Factive_minibuffer_window): Move to minibuf.c.
3794 (Fother_visible_frames_p): New function.
3795
3796 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3797
3798 * window.c (decode_window, decode_any_window): Move up in code.
3799 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3800 (inhibit_frame_unsplittable): Remove unused variable.
3801 (Fwindow_buffer): Move up and rewrite doc-string.
3802 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3803 (Fwindow_prev): New functions.
3804 (Fwindow_frame): Move here from frame.c. Accept any window as
3805 argument.
3806 (Fframe_root_window, Fframe_first_window)
3807 (Fframe_selected_window): Move here from frame.c. Accept frame
3808 or arbitrary window as argument. Update doc-strings.
3809 (Fminibuffer_window): Move up in code.
3810 (Fwindow_minibuffer_p): Move up in code and simplify.
3811 (Fset_frame_selected_window): Move here from frame.c.
3812 Marginal rewrite.
3813 (Fselected_window, select_window, Fselect_window): Move up in
3814 code. Minor doc-string fixes.
3815
3816 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3817
3818 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3819 Do not assume that spare memory exists; that assumption is valid
3820 only if SYSTEM_MALLOC.
3821 (LARGE_REQUEST): New macro, so that the issue of large requests
3822 is separated from the issue of spare memory.
3823
3824 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3825
3826 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3827 format. (Bug#8806)
3828
3829 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3830
3831 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3832 before statements.
3833
3834 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3835
3836 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3837
3838 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3839
3840 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3841 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3842
3843 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3844
3845 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3846
3847 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3848
3849 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3850 (x_clipboard_manager_save): Add return value.
3851 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3852 New error handlers.
3853 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3854 Obey Vx_select_enable_clipboard_manager. Catch errors in
3855 x_clipboard_manager_save (Bug#8779).
3856 (Vx_select_enable_clipboard_manager): New variable.
3857 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3858
3859 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3860
3861 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3862
3863 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3864
3865 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3866 in the current matrix if keep_current_p is non-zero.
3867
3868 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3869
3870 * bidi.c (bidi_level_of_next_char): Fix last change.
3871
3872 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3873
3874 Support bidi reordering of text covered by display properties.
3875
3876 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3877 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3878 (bidi_cache_search, bidi_cache_iterator_state)
3879 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3880 (bidi_level_of_next_char, bidi_move_to_visually_next):
3881 Support character positions inside a run of characters covered by a
3882 display string.
3883 (bidi_paragraph_init, bidi_resolve_explicit_1)
3884 (bidi_level_of_next_char): Call bidi_fetch_char and
3885 bidi_fetch_char_advance instead of FETCH_CHAR and
3886 FETCH_CHAR_ADVANCE.
3887 (bidi_init_it): Initialize new members.
3888 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3889 definitions.
3890 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3891 instead of using explicit *_CHAR codes.
3892 (bidi_resolve_explicit, bidi_resolve_weak):
3893 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3894 bidirectional text is supported only in multibyte buffers.
3895 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3896 it to initialize the frame_window_p member of struct bidi_it.
3897 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3898 (bidi_resolve_explicit, bidi_resolve_weak)
3899 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3900 bidi_it->nchars is non-positive.
3901 (bidi_level_of_next_char): Don't try to lookup the cache for the
3902 next/previous character if nothing is cached there yet, or if we
3903 were just reseat()'ed to a new position.
3904
3905 * xdisp.c (set_cursor_from_row): Set start and stop points
3906 according to the row's direction when priming the loop that looks
3907 for the glyph on which to display cursor.
3908 (single_display_spec_intangible_p): Function deleted.
3909 (display_prop_intangible_p): Reimplement to call
3910 handle_display_spec instead of single_display_spec_intangible_p.
3911 Accept 3 additional arguments needed by handle_display_spec.
3912 This fixes incorrect cursor motion across display property with complex
3913 values: lists, `(when COND...)' forms, etc.
3914 (single_display_spec_string_p): Support property values that are
3915 lists with the argument STRING its top-level element.
3916 (display_prop_string_p): Fix the condition for processing a
3917 property that is a list to be consistent with handle_display_spec.
3918 (handle_display_spec): New function, refactored from the
3919 last portion of handle_display_prop.
3920 (compute_display_string_pos): Accept additional argument
3921 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3922 value of a `display' property is a "replacing spec".
3923 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3924 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3925 the display property, but just return a value indicating whether
3926 the display property will replace the characters it covers.
3927 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3928 frame_window_p members of struct bidi_it.
3929 (compute_display_string_pos, compute_display_string_end):
3930 New functions.
3931 (push_it): Accept second argument POSITION, where pop_it should
3932 jump to continue iteration.
3933 (reseat_1): Initialize bidi_it.disp_pos.
3934
3935 * keyboard.c (adjust_point_for_property): Adjust the call to
3936 display_prop_intangible_p to its new signature.
3937
3938 * dispextern.h (struct bidi_it): New member frame_window_p.
3939 (bidi_init_it): Update prototypes.
3940 (display_prop_intangible_p): Update prototype.
3941 (compute_display_string_pos, compute_display_string_end):
3942 Declare prototypes.
3943 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3944 EMACS_INT.
3945
3946 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3947
3948 Malloc failure behavior now depends on size of allocation.
3949 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3950 * lisp.h: Change signatures accordingly.
3951 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3952 All callers changed. (Bug#8762)
3953
3954 * gnutls.c: Use Emacs's memory allocators.
3955 Without this change, the gnutls library would invoke malloc etc.
3956 directly, which causes problems on non-SYNC_INPUT hosts, and which
3957 runs afoul of improving memory_full behavior. (Bug#8761)
3958 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3959 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3960 xfree instead of the default malloc, realloc, free.
3961 (Fgnutls_boot): No need to check for memory allocation failure,
3962 since xmalloc does that for us.
3963
3964 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3965 * category.c (hash_get_category_set):
3966 * ccl.c (ccl_driver):
3967 * charset.c (Fdefine_charset_internal):
3968 * charset.h (struct charset.hash_index):
3969 * composite.c (get_composition_id, gstring_lookup_cache)
3970 (composition_gstring_put_cache):
3971 * composite.h (struct composition.hash_index):
3972 * dispextern.h (struct image.hash):
3973 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3974 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3975 (hashfn_equal, hashfn_user_defined, make_hash_table)
3976 (maybe_resize_hash_table, hash_lookup, hash_put)
3977 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3978 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3979 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3980 * image.c (make_image, search_image_cache, lookup_image)
3981 (xpm_put_color_table_h):
3982 * lisp.h (struct Lisp_Hash_Table):
3983 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3984 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3985 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3986 * alloc.c (allocate_vectorlike):
3987 Check for overflow in vector size calculations.
3988 * ccl.c (ccl_driver):
3989 Check for overflow when converting EMACS_INT to int.
3990 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3991 need to be updated by these changes.
3992 * fns.c (make_hash_table, maybe_resize_hash_table):
3993 Check for integer overflow with large hash tables.
3994 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3995 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3996 (SXHASH_REDUCE): New macro.
3997 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3998 Use it instead of discarding useful hash info with large hash values.
3999 (sxhash_float): New function.
4000 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4001 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4002 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4003 Rewrite to use FIXNUM_BITS, as this simplifies things.
4004 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4005 Adjust signatures to match updated version of code.
4006 (consing_since_gc): Now EMACS_INT, since a single hash table can
4007 use more than INT_MAX bytes.
4008
4009 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4010
4011 Make it possible to build with GCC-4.6+ -O2 -flto.
4012
4013 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4014
4015 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4016
4017 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4018 Call minibuffer-inactive-mode.
4019
4020 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4021
4022 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4023 Update dependencies.
4024
4025 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4026
4027 * data.c (init_data): Remove code for UTS, this system is not
4028 supported anymore.
4029
4030 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4031
4032 Don't force ./temacs to start in terminal mode.
4033
4034 * frame.c (make_initial_frame): Initialize faces in all cases, not
4035 only when CANNOT_DUMP is defined.
4036 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4037
4038 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4039
4040 * dispnew.c (add_window_display_history): Use const for the string
4041 pointer. Remove declaration, not needed.
4042
4043 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4044
4045 Use 'inline', not 'INLINE'.
4046 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4047 * alloc.c, fontset.c (INLINE): Remove.
4048 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4049 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4050 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4051 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4052 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4053
4054 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4055
4056 Make it possible to run ./temacs.
4057
4058 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4059 syms_of_callproc does the same thing. Remove test for
4060 "initialized", do it in the caller.
4061 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4062
4063 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4064
4065 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4066 (read_minibuf): Use get_minibuffer.
4067 (syms_of_minibuf): Use DEFSYM.
4068 (Qmetadata): New var.
4069 * data.c (Qbuffer): Don't make it static.
4070 (syms_of_data): Use DEFSYM.
4071
4072 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4073
4074 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4075 (CCL_CODE_MIN): New macro.
4076
4077 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4078
4079 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4080
4081 * eval.c (Qdebug): Now static.
4082 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4083 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4084 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4085
4086 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4087
4088 * image.c: Various fixes to ImageMagick code comments.
4089 (Fimagemagick_types): Doc fix.
4090
4091 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4092
4093 Minor fixes prompted by GCC 4.6.0 warnings.
4094
4095 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4096
4097 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4098 (x_clipboard_manager_save_all): Move extern decl to ...
4099 * xterm.h: ... here, so that it can be checked for consistency.
4100
4101 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4102
4103 * xselect.c (x_clipboard_manager_save_frame)
4104 (x_clipboard_manager_save_all): New functions.
4105 (Fx_clipboard_manager_save): Lisp function deleted.
4106
4107 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4108 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4109
4110 * xterm.h: Update prototype.
4111
4112 2011-05-28 William Xu <william.xwl@gmail.com>
4113
4114 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4115 exiting (Bug#8239).
4116
4117 2011-05-28 Jim Meyering <meyering@redhat.com>
4118
4119 Avoid a sign-extension bug in crypto_hash_function.
4120 * fns.c (to_uchar): Define.
4121 (crypto_hash_function): Use it to convert some newly-signed
4122 variables to unsigned, to avoid sign-extension bugs. For example,
4123 without this change, (md5 "truc") would evaluate to
4124 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4125 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4126 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4127
4128 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4129
4130 Integer overflow fixes.
4131
4132 * dbusbind.c: Serial number integer overflow fixes.
4133 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4134 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4135 to hold a serial number that is too large for a fixnum.
4136 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4137 Check for serial numbers out of range. Decode any serial number
4138 that was so large that it became a float. (Bug#8722)
4139
4140 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4141 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4142 Use XFASTINT rather than XUINT when numbers are nonnegative.
4143 (xd_append_arg, Fdbus_method_return_internal):
4144 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4145 arguments, check that Lisp number is nonnegative, rather than
4146 silently wrapping negative numbers around. (Bug#8722)
4147 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4148 (Bug#8722)
4149
4150 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4151
4152 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4153
4154 ccl: add integer overflow checks
4155 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4156 (IN_INT_RANGE): New macros.
4157 (ccl_driver): Use them to check for integer overflow when
4158 decoding a CCL program. Many of the new checks are whether XINT (x)
4159 fits in int; it doesn't always, on 64-bit hosts. The new version
4160 doesn't catch all possible integer overflows, but it's an
4161 improvement. (Bug#8719)
4162
4163 * alloc.c (make_event_array): Use XINT, not XUINT.
4164 There's no need for unsigned here.
4165
4166 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4167 This follows up to the 2011-05-06 change that substituted uintptr_t
4168 for EMACS_INT. This case wasn't caught back then.
4169
4170 Rework Fformat to avoid integer overflow issues.
4171 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4172 now (part of C89). Include <verify.h>.
4173 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4174 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4175 (Fformat): Avoid the prepass trying to compute sizes; it was only
4176 approximate and thus did not catch overflow reliably. Instead, walk
4177 through the format just once, formatting and computing sizes as we go,
4178 checking for integer overflow at every step, and allocating a larger
4179 buffer as needed. Keep track separately whether the format is
4180 multibyte. Keep only the most-recently calculated precision, rather
4181 than them all. Record whether each argument has been converted to
4182 string. Use EMACS_INT, not int, for byte and char and arg counts.
4183 Support field widths and precisions larger than INT_MAX. Avoid
4184 sprintf's undefined behavior with conversion specifications such as %#d
4185 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4186 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4187 formatting out-of-range floating point numbers with int
4188 formats. (Bug#8668)
4189
4190 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4191
4192 * data.c: Avoid integer truncation in expressions involving floats.
4193 * data.c: Include <intprops.h>.
4194 (arith_driver): When there's an integer overflow in an expression
4195 involving floating point, convert the integers to floating point
4196 so that the resulting value does not suffer from catastrophic
4197 integer truncation. For example, on a 64-bit host (* 4
4198 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4199 Do not rely on undefined behavior after integer overflow.
4200
4201 merge count_size_as_multibyte, parse_str_to_multibyte
4202 * character.c, character.h (count_size_as_multibyte):
4203 Rename from parse_str_to_multibyte; all uses changed.
4204 Check for integer overflow.
4205 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4206 since it's now a duplicate of the other. This is more of
4207 a character than a buffer op, so better that it's in character.c.
4208 * fns.c, print.c: Adjust to above changes.
4209
4210 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4211
4212 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4213
4214 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4215
4216 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4217 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4218 (x_clipboard_manager_save): Now static.
4219 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4220
4221 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4222 (crypto_hash_function): Now static.
4223 Fix pointer signedness problems. Avoid unnecessary initializations.
4224
4225 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4226
4227 * termhooks.h (Vselection_alist): Make it terminal-local.
4228
4229 * terminal.c (create_terminal): Initialize it.
4230
4231 * xselect.c: Support for clipboard managers.
4232 (Vselection_alist): Move to termhooks.h as terminal-local var.
4233 (LOCAL_SELECTION): New macro.
4234 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4235 (symbol_to_x_atom): Remove gratuitous arg.
4236 (x_handle_selection_request, lisp_data_to_selection_data)
4237 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4238 (x_own_selection, x_get_local_selection, x_convert_selection):
4239 New arg, specifying work frame. Use terminal-local Vselection_alist.
4240 (some_frame_on_display): Delete unused function.
4241 (Fx_own_selection_internal, Fx_get_selection_internal)
4242 (Fx_disown_selection_internal, Fx_selection_owner_p)
4243 (Fx_selection_exists_p): New optional frame arg.
4244 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4245 (x_handle_selection_clear): Don't treat other terminals with the
4246 same keyboard specially. Use the terminal-local Vselection_alist.
4247 (x_clear_frame_selections): Use Frun_hook_with_args.
4248
4249 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4250
4251 * xterm.h: Add support for those atoms.
4252
4253 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4254
4255 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4256 (converted_selections, conversion_fail_tag): New global variables.
4257 (x_selection_request_lisp_error): Free the above.
4258 (x_get_local_selection): Remove unnecessary code.
4259 (x_reply_selection_request): Args changed; handle arbitrary array
4260 of converted selections stored in converted_selections.
4261 Separate the XChangeProperty and SelectionNotify steps.
4262 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4263 (x_convert_selection): New function.
4264 (x_handle_selection_event): Simplify.
4265 (x_get_foreign_selection): Don't ignore incoming requests while
4266 waiting for an answer; this will fail when we implement
4267 SAVE_TARGETS, and seems unnecessary anyway.
4268 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4269 (Vx_sent_selection_functions): Doc fix.
4270
4271 2011-05-26 Leo Liu <sdl.web@gmail.com>
4272
4273 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4274
4275 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4276
4277 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4278
4279 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4280 for fringe update if it has periodic bitmap.
4281 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4282 and fringe_bitmap_periodic_p.
4283
4284 * fringe.c (get_fringe_bitmap_data): New function.
4285 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4286 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4287 row. Mark glyph row for fringe update if periodicity changed.
4288
4289 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4290 for fringe update unless it has periodic bitmap.
4291
4292 2011-05-25 Kenichi Handa <handa@m17n.org>
4293
4294 * xdisp.c (get_next_display_element): Set correct it->face_id for
4295 a static composition.
4296
4297 2011-05-24 Leo Liu <sdl.web@gmail.com>
4298
4299 * deps.mk (fns.o):
4300 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4301
4302 * fns.c (crypto_hash_function, Fsha1): New function.
4303 (Fmd5): Use crypto_hash_function.
4304 (syms_of_fns): Add Ssha1.
4305
4306 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4307
4308 * gnutls.c: Remove unused macros.
4309 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4310 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4311 Remove macros that are defined and never used.
4312 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4313
4314 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4315
4316 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4317 (Fx_get_selection_internal): Minor cleanup.
4318 (Fx_own_selection_internal): Rename arguments for consistency with
4319 select.el.
4320
4321 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4322
4323 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4324
4325 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4326
4327 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4328
4329 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4330
4331 * dispnew.c (scrolling_window): Don't exclude the case that the
4332 last enabled row in the desired matrix touches the bottom boundary.
4333
4334 2011-05-21 Glenn Morris <rgm@gnu.org>
4335
4336 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4337 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4338 and add some more files.
4339
4340 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4341
4342 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4343 report_file_error introduced by the change from 2011-05-07.
4344
4345 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4346
4347 * systime.h (Time): Define only if emacs is defined.
4348 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4349 where the include path doesn't have X11/X.h by default. See
4350 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4351
4352 2011-05-20 Kenichi Handa <handa@m17n.org>
4353
4354 * composite.c (find_automatic_composition): Fix previous change.
4355
4356 2011-05-20 Glenn Morris <rgm@gnu.org>
4357
4358 * lisp.mk: New file, split from Makefile.in.
4359 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4360 (shortlisp): Remove.
4361 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4362
4363 2011-05-19 Glenn Morris <rgm@gnu.org>
4364
4365 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4366 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4367 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4368 (lisp): Set the order to that of loadup.el.
4369 (shortlisp): Make it a copy of $lisp.
4370 (SOME_MACHINE_LISP): Remove.
4371 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4372 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4373
4374 2011-05-18 Kenichi Handa <handa@m17n.org>
4375
4376 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4377 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4378 (find_automatic_composition): Mostly rewrite for efficiency.
4379
4380 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4381
4382 * makefile.w32-in: Update dependencies.
4383
4384 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4385
4386 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4387 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4388
4389 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4390
4391 Fix some integer overflow issues, such as string length overflow.
4392
4393 * insdel.c (count_size_as_multibyte): Check for string overflow.
4394
4395 * character.c (lisp_string_width): Check for string overflow.
4396 Use EMACS_INT, not int, for string indexes and lengths; in
4397 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4398 the resulting string length overflows an EMACS_INT; instead,
4399 report a string overflow if no precision given. When checking for
4400 precision exhaustion, use a check that cannot possibly have
4401 integer overflow. (Bug#8675)
4402 * character.h (lisp_string_width): Adjust to new signature.
4403
4404 * alloc.c (string_overflow): New function.
4405 (Fmake_string): Use it. This doesn't change behavior, but saves
4406 a few bytes and will simplify future changes.
4407 * character.c (string_escape_byte8): Likewise.
4408 * lisp.h (string_overflow): New decl.
4409
4410 Fixups, following up to the user-interface timestamp change.
4411 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4412 for UI timestamps, instead of unsigned long.
4413 * msdos.c (mouse_get_pos): Likewise.
4414 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4415 * w32gui.h (Time): Define by including "systime.h" rather than by
4416 declaring it ourselves. (Bug#8664)
4417
4418 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4419 * image.c (clear_image_cache): Likewise.
4420
4421 * term.c (term_mouse_position): Don't assume time_t wraparound.
4422
4423 Be more systematic about user-interface timestamps.
4424 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4425 and sometimes 'EMACS_UINT', to represent these timestamps.
4426 This change causes it to use 'Time' uniformly, as that's what X uses.
4427 This makes the code easier to follow, and makes it easier to catch
4428 integer overflow bugs such as Bug#8664.
4429 * frame.c (Fmouse_position, Fmouse_pixel_position):
4430 Use Time, not unsigned long, for user-interface timestamps.
4431 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4432 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4433 * keyboard.h (last_event_timestamp): Likewise.
4434 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4435 * menu.h (xmenu_show): Likewise.
4436 * term.c (term_mouse_position): Likewise.
4437 * termhooks.h (struct input_event.timestamp): Likewise.
4438 (struct terminal.mouse_position_hook): Likewise.
4439 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4440 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4441 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4442 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4443 what it was before.
4444 * menu.h, termhooks.h: Include "systime.h", for Time.
4445
4446 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4447 Don't assume that the difference between two unsigned long values
4448 can fit into an integer. At this point, we know button_down_time
4449 <= event->timestamp, so the difference must be nonnegative, so
4450 there's no need to cast the result if double-click-time is
4451 nonnegative, as it should be; check that it's nonnegative, just in
4452 case. This bug is triggered when events are more than 2**31 ms
4453 apart (about 25 days). (Bug#8664)
4454
4455 * xselect.c (last_event_timestamp): Remove duplicate decl.
4456 (x_own_selection): Remove needless cast to unsigned long.
4457
4458 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4459 that always fit in int. Use a sentinel instead of a counter, to
4460 avoid a temp and to allay GCC's concerns about possible int overflow.
4461 * frame.h (struct frame): Use int for menu_bar_items_used
4462 instead of EMACS_INT, since it always fits in int.
4463
4464 * menu.c (grow_menu_items): Check for int overflow.
4465
4466 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4467
4468 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4469 Before, the code was not consistent. These values cannot exceed
4470 2**31 - 1 so there's no need to make them unsigned.
4471 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4472 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4473 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4474 as modifiers.
4475 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4476
4477 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4478 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4479 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4480 presumably because the widths might not match.
4481
4482 * window.c (size_window): Avoid needless test at loop start.
4483
4484 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4485
4486 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4487
4488 2011-05-12 Drew Adams <drew.adams@oracle.com>
4489
4490 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4491
4492 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4493
4494 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4495 `width' to `bar_area_x' and `bar_area_width', respectively.
4496 (x_scroll_run): Take account of fringe background extension.
4497
4498 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4499 Rename local vars `left' and `width' to `bar_area_x' and
4500 `bar_area_width', respectively.
4501 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4502 background extension.
4503
4504 2011-05-10 Jim Meyering <meyering@redhat.com>
4505
4506 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4507
4508 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4509
4510 * image.c (Finit_image_library): Return t for built-in image types,
4511 like pbm and xbm. (Bug#8640)
4512
4513 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4514
4515 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4516
4517 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4518
4519 * w32console.c (Fset_screen_color): Doc fix.
4520 (Fget_screen_color): New function.
4521 (syms_of_ntterm): Defsubr it.
4522
4523 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4524 unlink the temporary file if Fcall_process didn't create it in the
4525 first place.
4526 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4527 child process will be redirected to a file specified with `:file'.
4528 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4529 cue to call_process_cleanup not to close that handle.
4530
4531 2011-05-07 Ben Key <bkey76@gmail.com>
4532
4533 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4534 one of two shell specific rules, either bootstrap-temacs-CMD or
4535 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4536 to the previous implementation of the bootstrap-temacs rule.
4537 The bootstrap-temacs-CMD rule is similar to the previous
4538 implementation of the bootstrap-temacs rule except that it
4539 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4540 variable.
4541
4542 These changes, along with some changes to nt/configure.bat,
4543 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4544 earlier fix to add support for --cflags and --ldflags options
4545 that include quotes so that it works whether make uses cmd or
4546 sh as the shell.
4547
4548 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4549
4550 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4551 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4552 is a constant.
4553 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4554 a string. Handle both cases.
4555 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4556 (Fdbus_register_method): Use Qinvalid_function.
4557
4558 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4559
4560 * makefile.w32-in: Update dependencies.
4561 (LISP_H): Add inttypes.h and stdin.h.
4562 (PROCESS_H): Add unistd.h.
4563
4564 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4565
4566 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4567 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4568
4569 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4570
4571 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4572
4573 * term.c (vfatal): Remove stray call to va_end.
4574 It's not needed and the C Standard doesn't allow it here anyway.
4575
4576 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4577 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4578
4579 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4580 bytes.
4581
4582 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4583
4584 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4585
4586 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4587
4588 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4589
4590 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4591
4592 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4593 * charset.c (Fdefine_charset_internal): Don't initialize
4594 charset.code_space[15]. The value was garbage, on hosts with
4595 32-bit int (Bug#8600).
4596
4597 * lread.c (read_integer): Be more consistent with string-to-number.
4598 Use string_to_number to do the actual conversion; this avoids
4599 rounding errors and fixes some other screwups. Without this fix,
4600 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4601 (digit_to_number): Move earlier, for benefit of read_integer.
4602 Return -1 if the digit is out of range for the base, -2 if it is
4603 not a digit in any supported base. (Bug#8602)
4604
4605 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4606
4607 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4608 to match comment at start of function. This also removes a
4609 GCC warning about overflow in a 32+64-bit port.
4610
4611 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4612
4613 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4614 Reported by Stefan Monnier in
4615 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4616 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4617 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4618
4619 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4620 (EMACS_UINTPTR): Likewise, with uintptr_t.
4621
4622 * lisp.h: Prefer 64-bit EMACS_INT if available.
4623 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4624 on 32-bit hosts that have 64-bit int, so that they can access
4625 large files.
4626 However, temporarily disable this change unless the temporary
4627 symbol WIDE_EMACS_INT is defined.
4628
4629 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4630
4631 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4632 This removes an assumption that EMACS_INT and long are the same
4633 width as pointers. The assumption is true for Emacs porting targets
4634 now, but we want to make other targets possible.
4635 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4636 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4637 In the rest of the code, change types of integers that hold casted
4638 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4639 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4640 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4641 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4642 No need to cast type when ORing.
4643 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4644 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4645 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4646 assume EMACS_INT is the same width as char *.
4647 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4648 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4649 Remove no-longer-needed casts.
4650 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4651 (xg_tool_bar_help_callback, xg_make_tool_item):
4652 Use EMACS_INTPTR to hold an integer
4653 that will be cast to void *; this can avoid a GCC warning
4654 if EMACS_INT is not the same width as void *.
4655 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4656 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4657 (current_message_1, set_message_1):
4658 Use a local to convert to proper width without a cast.
4659 * xmenu.c (dialog_selection_callback): Likewise.
4660
4661 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4662 Also, don't assume VALBITS / RAND_BITS is less than 5,
4663 and don't rely on undefined behavior when shifting a 1 left into
4664 the sign bit.
4665 * lisp.h (get_random): Change signature to match.
4666
4667 * lread.c (hash_string): Use size_t, not int, for hash computation.
4668 Normally we prefer signed values; but hashing is special, because
4669 it's better to use unsigned division on hash table sizes so that
4670 the remainder is nonnegative. Also, size_t is the natural width
4671 for hashing into memory. The previous code used 'int', which doesn't
4672 retain enough info to hash well into very large tables.
4673 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4674
4675 * dbusbind.c: Don't possibly lose pointer info when converting.
4676 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4677 Use XPNTR rather than XHASH, so that the high-order bits of
4678 the pointer aren't lost when converting through void *.
4679
4680 * eval.c (Fautoload): Don't double-shift a pointer.
4681
4682 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4683
4684 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4685
4686 * gnutls.c (DEF_GNUTLS_FN):
4687 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4688
4689 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4690
4691 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4692 marker. (Bug#8610)
4693
4694 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4695
4696 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4697 New version that can reserve upto 2GB of heap space.
4698
4699 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4700
4701 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4702
4703 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4704
4705 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4706 `gnutls_certificate_set_x509_key_file'.
4707
4708 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4709
4710 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4711 Update dependencies.
4712
4713 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4714
4715 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4716 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4717 Remove unused parameter `fildes'.
4718 * process.c (read_process_output, send_process): Don't pass it.
4719
4720 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4721
4722 Fix previous change: the library cache is defined in w32.c.
4723 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4724 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4725
4726 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4727
4728 Implement dynamic loading of GnuTLS on Windows.
4729
4730 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4731 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4732 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4733 Declare.
4734
4735 * gnutls.c (Qgnutls_dll): Define.
4736 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4737 (gnutls_*): Declare function pointers.
4738 (init_gnutls_functions): New function to initialize function pointers.
4739 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4740 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4741 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4742 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4743 (emacs_gnutls_write, emacs_gnutls_read)
4744 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4745 (Fgnutls_available_p): New function.
4746 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4747 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4748 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4749
4750 * image.c: Include w32.h.
4751 (Vimage_type_cache): Delete.
4752 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4753 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4754 (w32_delayed_load): Move to w32.c.
4755
4756 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4757
4758 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4759 (w32_delayed_load): Move from image.c. When loading a library, record
4760 its filename in the :loaded-from property of the library id.
4761 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4762 Initialize and staticpro them.
4763 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4764
4765 * process.c: Include lisp.h before w32.h, not after.
4766 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4767 instead of gnutls_record_check_pending.
4768
4769 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4770
4771 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4772
4773 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4774 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4775 as passed in.
4776
4777 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4778
4779 * xterm.c (x_set_frame_alpha): Do not set property on anything
4780 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4781
4782 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4783
4784 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4785
4786 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4787
4788 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4789 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4790 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4791 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4792 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4793 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4794 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4795 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4796 (Qgnutls_bootprop_callbacks_verify): Make static.
4797
4798 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4799
4800 * callproc.c: Indentation fixup.
4801
4802 * sysdep.c (wait_for_termination_1): Make static.
4803 (wait_for_termination, interruptible_wait_for_termination):
4804 Move after wait_for_termination_1.
4805
4806 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4807
4808 * sysdep.c (interruptible_wait_for_termination): New function
4809 which is like wait_for_termination, but allows keyboard
4810 interruptions.
4811
4812 * callproc.c (Fcall_process): Add (:file "file") as an option for
4813 the STDOUT buffer.
4814 (Fcall_process_region): Ditto.
4815
4816 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4817
4818 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4819 rather than `XVECTOR (FOO)->size'.
4820
4821 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4822 inttypes.h, as a gnulib replacement is used if it not available in
4823 system headers.
4824
4825 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4826
4827 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4828 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4829 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4830
4831 * coding.c (coding_alloc_by_realloc): Error out if destination
4832 will grow beyond MOST_POSITIVE_FIXNUM.
4833 (decode_coding_emacs_mule): Abort if there isn't enough place in
4834 charbuf for the composition carryover bytes. Reserve an extra
4835 space for up to 2 characters produced in a loop.
4836 (decode_coding_iso_2022): Abort if there isn't enough place in
4837 charbuf for the composition carryover bytes.
4838
4839 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4840
4841 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4842 aborting when %lld or %lll format is passed.
4843 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4844 %llo or %llx format is passed. (Bug#8545)
4845
4846 * window.c (window_scroll_line_based): Use a marker instead of
4847 simple variables to record original value of point. (Bug#7952)
4848
4849 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4850 produced by %s or %c overflows available buffer space. (Bug#8545)
4851
4852 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4853
4854 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4855 (SIZE_MAX): Move defn after all includes, as they might #define it.
4856
4857 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4858
4859 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4860
4861 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4862
4863 * keyboard.c (Qdelayed_warnings_hook): Define.
4864 (command_loop_1): Run `delayed-warnings-hook'
4865 if Vdelayed_warnings_list is non-nil.
4866 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4867 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4868
4869 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4870
4871 * doprnt.c (doprnt): Don't return value smaller than the buffer
4872 size if the message was truncated. (Bug#8545).
4873
4874 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4875
4876 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4877 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4878
4879 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4880
4881 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4882
4883 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4884
4885 * makefile.w32-in: Update dependencies.
4886
4887 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4888
4889 Improve `doprnt' and its usage. (Bug#8545)
4890 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4891 `format_end'. Remove support for %l as a conversion specifier.
4892 Don't use xrealloc. Improve diagnostics when the %l size modifier
4893 is used. Update the commentary.
4894
4895 * eval.c (verror): Simplify calculation of size_t.
4896
4897 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4898 messages.
4899
4900 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4901
4902 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4903 change.
4904
4905 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4906
4907 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4908 This makes this file independent of the recent pseudovector change.
4909
4910 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4911
4912 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4913
4914 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4915 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4916 Remove unused local.
4917 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4918
4919 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4920 GCC 4.6.0 optimizes based on type-based alias analysis.
4921 For example, if b is of type struct buffer * and v of type struct
4922 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4923 != &v->size, and therefore "v->size = 1; b->size = 2; return
4924 v->size;" must therefore return 1. This assumption is incorrect
4925 for Emacs, since it type-puns struct Lisp_Vector * with many other
4926 types. To fix this problem, this patch adds a new type struct
4927 vectorlike_header that documents the constraints on layout of vectors
4928 and pseudovectors, and helps optimizing compilers not get fooled
4929 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4930 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4931 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4932 the size member.
4933 (XSETPVECTYPE): Rewrite in terms of new macro.
4934 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4935 This is a bit clearer, and further avoids the possibility of
4936 undesirable aliasing.
4937 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4938 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4939 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4940 since Lisp_Subr is a special case (no "next" field).
4941 (ASIZE): Now uses header.size rather than size.
4942 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4943 to avoid the hassle of writing XVECTOR (foo)->header.size.
4944 (struct vectorlike_header): New type.
4945 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4946 object, to help avoid aliasing.
4947 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4948 (SUBRP): Likewise, since Lisp_Subr is a special case.
4949 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4950 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4951 (struct Lisp_Hash_Table): Combine first two members into a single
4952 struct vectorlike_header member. All uses of "size" and "next" members
4953 changed to be "header.size" and "header.next".
4954 * buffer.h (struct buffer): Likewise.
4955 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4956 * frame.h (struct frame): Likewise.
4957 * process.h (struct Lisp_Process): Likewise.
4958 * termhooks.h (struct terminal): Likewise.
4959 * window.c (struct save_window_data, struct saved_window): Likewise.
4960 * window.h (struct window): Likewise.
4961 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4962 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4963 * buffer.c (init_buffer_once): Likewise.
4964 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4965 special case.
4966 * process.c (Fformat_network_address): Use local var for size,
4967 for brevity.
4968
4969 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4970
4971 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4972 * data.c (atof): Remove decl; no longer used or needed.
4973 (digit_to_number): Move to lread.c.
4974 (Fstring_to_number): Use new string_to_number function, to be
4975 consistent with how the Lisp reader treats infinities and NaNs.
4976 Do not assume that floating-point numbers represent EMACS_INT
4977 without losing information; this is not true on most 64-bit hosts.
4978 Avoid double-rounding errors, by insisting on integers when
4979 parsing non-base-10 numbers, as the documentation specifies.
4980 * lisp.h (string_to_number): New decl, replacing ...
4981 (isfloat_string): Remove.
4982 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4983 (read1): Do not accept +. and -. as integers; this
4984 appears to have been a coding error. Similarly, do not accept
4985 strings like +-1e0 as floating point numbers. Do not report
4986 overflow for integer overflows unless the base is not 10 which
4987 means we have no simple and reliable way to continue.
4988 Break out the floating-point parsing into a new
4989 function string_to_number, so that Fstring_to_number parses
4990 floating point numbers consistently with the Lisp reader.
4991 (digit_to_number): Move here from data.c. Make it static inline.
4992 (E_CHAR, EXP_INT): Remove, replacing with ...
4993 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4994 (string_to_number): New function, replacing isfloat_string.
4995 This function checks for valid syntax and produces the resulting
4996 Lisp float number too. Rework it so that string-to-number
4997 no longer mishandles examples like "1.0e+". Use strtoumax,
4998 so that overflow for non-base-10 numbers is reported only when
4999 there's no portable and simple way to convert to floating point.
5000
5001 * textprop.c (set_text_properties_1): Rewrite for clarity,
5002 and to avoid GCC warning about integer overflow.
5003
5004 * intervals.h (struct interval): Use EMACS_INT for members
5005 where EMACS_UINT might cause problems. See
5006 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5007 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5008 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5009 All uses changed.
5010 (offset_intervals): Tell GCC not to worry about length overflow
5011 when negating a negative length.
5012
5013 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5014 (overrun_check_free): Likewise.
5015
5016 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5017 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5018 word size.
5019
5020 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5021 (gnutls_make_error): Rename local to avoid shadowing.
5022 (gnutls_emacs_global_deinit): ifdef out; not used.
5023 (Fgnutls_boot): Use const for pointer to readonly storage.
5024 Comment out unused local. Fix pointer signedness problems.
5025
5026 * lread.c (openp): Don't stuff size_t into an 'int'.
5027 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5028 about possible signed overflow.
5029
5030 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5031 (GDK_KEY_g): Don't define if already defined.
5032 (xg_prepare_tooltip): Avoid pointer signedness problem.
5033 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5034
5035 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5036 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5037
5038 * xfns.c (Fx_window_property): Simplify a bit,
5039 to make a bit faster and to avoid GCC 4.6.0 warning.
5040 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5041
5042 * fns.c (internal_equal): Don't assume size_t fits in int.
5043
5044 * alloc.c (compact_small_strings): Tighten assertion a little.
5045
5046 Replace pEd with more-general pI, and fix some printf arg casts.
5047 * lisp.h (pI): New macro, generalizing old pEd macro to other
5048 conversion specifiers. For example, use "...%"pI"d..." rather
5049 than "...%"pEd"...".
5050 (pEd): Remove. All uses replaced with similar uses of pI.
5051 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5052 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5053 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5054 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5055 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5056 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5057 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5058 64-bit hosts.
5059 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5060 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5061 * print.c (safe_debug_print, print_object): Likewise.
5062 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5063 to int.
5064 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5065 avoiding the 0 flag, which is not portable.
5066 * process.c (Fmake_network_process): Use pI to avoid cast.
5067 * region-cache.c (pp_cache): Likewise.
5068 * xdisp.c (decode_mode_spec): Likewise.
5069 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5070 behavior on 64-bit hosts with printf arg.
5071 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5072 (x_stop_queuing_selection_requests): Likewise.
5073 (x_get_window_property): Don't truncate byte count to an 'int'
5074 when tracing.
5075
5076 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5077 here, since it parses constructs like leading '-' and spaces,
5078 which are not wanted; and it overflows with large numbers.
5079 Instead, simply match F[0-9]+, which is what is wanted anyway.
5080
5081 * alloc.c: Remove unportable assumptions about struct layout.
5082 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5083 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5084 (allocate_vectorlike, make_pure_vector): Use the new macros,
5085 plus offsetof, to remove unportable assumptions about struct layout.
5086 These assumptions hold on all porting targets that I know of, but
5087 they are not guaranteed, they're easy to remove, and removing them
5088 makes further changes easier.
5089
5090 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5091 This doesn't fix a bug but makes the code clearer.
5092 (string_overrun_cookie): Now const. Use initializers that
5093 don't formally overflow signed char, to avoid warnings.
5094 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5095 can cause Emacs to crash when string overrun checking is enabled.
5096 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5097 multiple of sizeof (EMACS_INT); it need not be, if
5098 alignof(EMACS_INT) < sizeof (EMACS_INT).
5099 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5100
5101 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5102
5103 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5104
5105 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5106
5107 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5108 supposed to be handshaking. (Bug#8556)
5109 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5110
5111 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5112
5113 * lisp.h (Qdebug): List symbol.
5114 * eval.c (Qdebug): Restore global linkage.
5115 * keyboard.c (debug-on-event): New variable.
5116 (handle_user_signal): Break into debugger when debug-on-event
5117 matches the current signal symbol.
5118
5119 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5120
5121 * alloc.c (check_sblock, check_string_bytes)
5122 (check_string_free_list): Convert to standard C.
5123
5124 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5125
5126 * w32.c (emacs_gnutls_push): Fix typo.
5127
5128 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5129
5130 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5131 "cast to pointer from integer of different size".
5132
5133 Improve doprnt and its use in verror. (Bug#8545)
5134 * doprnt.c (doprnt): Document the set of format control sequences
5135 supported by the function. Use SAFE_ALLOCA instead of always
5136 using `alloca'.
5137
5138 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5139 is one byte too soon. Don't use xrealloc; instead xfree and
5140 xmalloc anew.
5141
5142 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5143
5144 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5145 callbacks stage.
5146
5147 * gnutls.c: Renamed global_initialized to
5148 gnutls_global_initialized. Added internals for the
5149 :verify-hostname-error, :verify-error, and :verify-flags
5150 parameters of `gnutls-boot' and documented those parameters in the
5151 docstring. Start callback support.
5152 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5153 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5154 on error. Return error code.
5155 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5156 (emacs_gnutls_read): Likewise.
5157 (Fgnutls_boot): Return handshake error code.
5158 (emacs_gnutls_handle_error): New function.
5159 (wsaerror_to_errno): Likewise.
5160
5161 * w32.h (emacs_gnutls_pull): Add prototype.
5162 (emacs_gnutls_push): Likewise.
5163
5164 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5165 (emacs_gnutls_push): Likewise.
5166
5167 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5168
5169 * process.c (wait_reading_process_output): Check if GnuTLS
5170 buffered some data internally if no FDs are set for TLS
5171 connections.
5172
5173 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5174 (LIBS): Link to USER_LIBS.
5175 ($(BLD)/gnutls.$(0)): New target.
5176
5177 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5178
5179 * xdisp.c (handle_single_display_spec): Rename the
5180 display_replaced_before_p argument into display_replaced_p, to
5181 make it consistent with the commentary. Fix typos in the
5182 commentary.
5183
5184 * textprop.c (syms_of_textprop): Remove dead code.
5185 (copy_text_properties): Delete obsolete commentary about an
5186 interface that was deleted long ago. Fix typos in the description
5187 of arguments.
5188
5189 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5190 to changes in oldXMenu/XMenu.h from 2011-04-16.
5191 <menu_help_message, prev_menu_help_message>: Constify.
5192 (IT_menu_make_room): menu->help_text is now `const char **';
5193 adjust.
5194
5195 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5196 to changes in oldXMenu/XMenu.h from 2011-04-16.
5197 (struct XMenu): Declare `help_text' `const char **'.
5198
5199 * xfaces.c <Qunspecified>: Make extern again.
5200
5201 * syntax.c: Include sys/types.h before including regex.h, as
5202 required by Posix.
5203
5204 * doc.c (get_doc_string): Improve the format passed to `error'.
5205
5206 * doprnt.c (doprnt): Improve commentary.
5207
5208 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5209
5210 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5211 them with etags.
5212
5213 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5214 changes in globals.h immediately force recompilation.
5215 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5216 $(CURDIR)/s/ms-w32.h.
5217 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5218
5219 * character.c (Fchar_direction): Function deleted.
5220 (syms_of_character): Don't defsubr it.
5221 <char-direction-table>: Deleted.
5222
5223 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5224
5225 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5226 * doprnt.c: Include limits.h.
5227 (SIZE_MAX): New macro.
5228 (doprnt): Return a size_t value. 2nd arg is now size_t.
5229 Many local variables are now size_t instead of int or unsigned.
5230 Improve overflow protection. Support `l' modifier for integer
5231 conversions. Support %l conversion. Don't assume an EMACS_INT
5232 argument for integer conversions and for %c.
5233
5234 * lisp.h (doprnt): Restore prototype.
5235
5236 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5237 $(SRC)/character.h.
5238
5239 * Makefile.in (base_obj): Add back doprnt.o.
5240
5241 * deps.mk (doprnt.o): Add back prerequisites.
5242 (callint.o): Depend on character.h.
5243
5244 * eval.c (internal_lisp_condition_case): Include the handler
5245 representation in the error message.
5246 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5247 when breaking from the loop.
5248
5249 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5250
5251 * callint.c (Fcall_interactively): When displaying error message
5252 about invalid control letter, pass the character's codepoint, not
5253 a pointer to its multibyte form. Improve display of the character
5254 in octal and display also its hex code.
5255
5256 * character.c (char_string): Use %x to display the (unsigned)
5257 codepoint of an invalid character, to avoid displaying a bogus
5258 negative value.
5259
5260 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5261 `error', not SYMBOL_NAME itself.
5262
5263 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5264 character arguments to `error'.
5265
5266 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5267 to `error' in error message about FINAL_CHAR argument. Make sure
5268 FINAL_CHAR is a character, and use %c when it is passed as
5269 argument to `error'.
5270
5271 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5272
5273 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5274
5275 * w32.c: Include <time.h>.
5276 (sys_localtime): New function.
5277
5278 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5279
5280 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5281
5282 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5283
5284 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5285
5286 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5287 zombies (Bug#8467).
5288
5289 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5290
5291 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5292 gl_state.e_property when gl_state.object is Qt.
5293
5294 * insdel.c (make_gap_larger): Remove limitation of buffer size
5295 to <= INT_MAX.
5296
5297 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5298
5299 * xdisp.c (lookup_glyphless_char_display)
5300 (produce_glyphless_glyph): Handle cons cell entry in
5301 glyphless-char-display.
5302 (Vglyphless_char_display): Document it.
5303
5304 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5305 glyphless-char-display.
5306
5307 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5308
5309 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5310
5311 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5312
5313 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5314 definition for no-X builds.
5315
5316 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5317
5318 Static checks with GCC 4.6.0 and non-default toolkits.
5319
5320 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5321
5322 * process.c (keyboard_bit_set): Define only if SIGIO.
5323 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5324 (send_process): Repair possible setjmp clobbering.
5325
5326 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5327
5328 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5329
5330 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5331
5332 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5333 Define only if needed.
5334
5335 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5336 by pacifying GCC about it. Maybe it's time to retire it?
5337 * xfaces.c (USG, __TIMEVAL__): Likewise.
5338
5339 * dispextern.h (struct redisplay_interface): Rename param
5340 to avoid shadowing.
5341 * termhooks.h (struct terminal): Likewise.
5342 * xterm.c (xembed_send_message): Likewise.
5343
5344 * insdel.c (make_gap_smaller): Define only if
5345 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5346
5347 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5348 it.
5349
5350 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5351 so that we aren't warned about unused symbols.
5352
5353 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5354
5355 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5356
5357 * xfns.c (x_real_positions): Mark locals as initialized.
5358
5359 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5360
5361 * xterm.c: Fix problems found by static analysis with other toolkits.
5362 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5363 (x_dispatch_event): Declare static if USE_GTK, and
5364 define if USE_GTK || USE_X_TOOLKIT.
5365 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5366 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5367 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5368 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5369
5370 * xmenu.c (menu_help_callback): Pointer type fixes.
5371 Use const pointers when pointing at readonly data. Avoid pointer
5372 signedness clashes.
5373 (FALSE): Remove unused macro.
5374 (update_frame_menubar): Remove unused decl.
5375
5376 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5377
5378 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5379 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5380 (single_menu_item): Rename local to avoid shadowing.
5381
5382 * keyboard.c (make_lispy_event): Remove unused local var.
5383
5384 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5385 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5386
5387 * bitmaps: Change bitmaps from unsigned char back to the X11
5388 compatible char. Avoid the old compiler warnings about
5389 out-of-range initializers by using, for example, '\xab' rather
5390 than 0xab.
5391
5392 * xgselect.c (xgselect_initialize): Check vs interface
5393 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5394
5395 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5396
5397 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5398 to read-only memory.
5399
5400 * fns.c (vector): Remove; this old hack is no longer needed.
5401
5402 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5403 Remove unused var.
5404 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5405
5406 * xrdb.c (x_load_resources): Omit unused local.
5407
5408 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5409 (x_window): Rename locals to avoid shadowing.
5410 (USG): Use the kludged USG macro, to pacify gcc.
5411
5412 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5413 (x_term_init): Remove local to avoid shadowing.
5414
5415 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5416
5417 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5418 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5419
5420 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5421
5422 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5423
5424 Fix regex.c, syntax.c and friends for buffers > 2GB.
5425 * syntax.h (struct gl_state_s): Declare character position members
5426 EMACS_INT.
5427
5428 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5429
5430 * textprop.c (verify_interval_modification, interval_of):
5431 Declare arguments EMACS_INT.
5432
5433 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5434 EMACS_INT.
5435
5436 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5437
5438 * indent.c (Fvertical_motion): Local variable it_start is now
5439 EMACS_INT.
5440
5441 * regex.c (re_match, re_match_2, re_match_2_internal)
5442 (bcmp_translate, regcomp, regexec, print_double_string)
5443 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5444 (re_compile_pattern, re_exec): Declare arguments and local
5445 variables `size_t' and `ssize_t' and return values `regoff_t', as
5446 appropriate.
5447 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5448 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5449 <compile_stack_type>: `size' and `avail' are now `size_t'.
5450
5451 * regex.h <regoff_t>: Use ssize_t, not int.
5452 (re_search, re_search_2, re_match, re_match_2): Arguments that
5453 specify buffer/string position and length are now ssize_t and
5454 size_t. Return type is regoff_t.
5455
5456 2011-04-16 Ben Key <bkey76@gmail.com>
5457
5458 * nsfont.m: Fixed bugs in ns_get_family and
5459 ns_descriptor_to_entity that were caused by using free to
5460 deallocate memory blocks that were allocated by xmalloc (via
5461 xstrdup). This caused Emacs to crash when compiled with
5462 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5463 --enable-checking=xmallocoverrun). xfree is now used to
5464 deallocate these memory blocks.
5465
5466 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5467
5468 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5469
5470 emacs_write: Accept and return EMACS_INT for sizes.
5471 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5472 et seq.
5473 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5474 Accept and return EMACS_INT.
5475 (emacs_gnutls_write): Return the number of bytes written on
5476 partial writes.
5477 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5478 (emacs_read, emacs_write): Remove check for negative size, as the
5479 Emacs source code has been audited now.
5480 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5481 (emacs_read, emacs_write): Use it.
5482 * process.c (send_process): Adjust to the new signatures of
5483 emacs_write and emacs_gnutls_write. Do not attempt to store
5484 a byte offset into an 'int'; it might overflow.
5485 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5486
5487 * sound.c: Don't assume sizes fit in 'int'.
5488 (struct sound_device.period_size, alsa_period_size):
5489 Return EMACS_INT, not int.
5490 (struct sound_device.write, vox_write, alsa_write):
5491 Accept EMACS_INT, not int.
5492 (wav_play, au_play): Use EMACS_INT to store sizes and to
5493 record read return values.
5494
5495 2011-04-15 Ben Key <bkey76@gmail.com>
5496
5497 * keyboard.c (Qundefined): Don't declare static since it is used
5498 in nsfns.m.
5499 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5500 static since they are used in nsfont.m.
5501
5502 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5503
5504 * process.c (Qprocessp): Don't declare static.
5505 * lisp.h (Qprocessp): Declare again.
5506
5507 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5508
5509 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5510
5511 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5512
5513 Improve C-level modularity by making more things 'static'.
5514
5515 Don't publish debugger-only interfaces to other modules.
5516 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5517 (verify_bytepos, count_markers): Move decls to the only modules
5518 that need them.
5519 * region-cache.h (pp_cache): Likewise.
5520 * window.h (check_all_windows): Likewise.
5521 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5522
5523 * sysdep.c (croak): Now static, if
5524 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5525 * syssignal.h (croak): Declare only if not static.
5526
5527 * alloc.c (refill_memory_reserve): Now static if
5528 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5529 * lisp.h (refill_memory_reserve): Declare only if not static.
5530
5531 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5532 Define only if USE_LUCID.
5533
5534 * xrdb.c (x_customization_string, x_rm_string): Now static.
5535
5536 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5537 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5538
5539 * xdisp.c (draw_row_with_mouse_face): Now static.
5540 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5541
5542 * window.h (check_all_windows): Mark externally visible.
5543
5544 * window.c (window_deletion_count): Now static.
5545
5546 * undo.c: Make symbols static if they're not exported.
5547 (last_undo_buffer, last_boundary_position, pending_boundary):
5548 Now static.
5549
5550 * textprop.c (interval_insert_behind_hooks): Now static.
5551 (interval_insert_in_front_hooks): Likewise.
5552
5553 * term.c: Make symbols static if they're not exported.
5554 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5555 (max_frame_lines, tty_set_terminal_modes):
5556 (tty_reset_terminal_modes, tty_turn_off_highlight):
5557 (get_tty_terminal): Now static.
5558 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5559 * termhooks.h (term_mouse_moveto): Do not declare if
5560 HAVE_WINDOW_SYSTEM.
5561 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5562 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5563
5564 * sysdep.c: Make symbols static if they're not exported.
5565 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5566 Now static.
5567 (sigprocmask_set, full_mask): Remove; unused.
5568 (wait_debugging): Mark as visible.
5569 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5570 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5571
5572 * syntax.c (syntax_temp): Define only if !__GNUC__.
5573
5574 * sound.c (current_sound_device, current_sound): Now static.
5575
5576 * search.c (searchbufs, searchbuf_head): Now static.
5577
5578 * scroll.c (scroll_cost): Remove; unused.
5579 * dispextern.h (scroll_cost): Remove decl.
5580
5581 * region-cache.h (pp_cache): Mark as externally visible.
5582
5583 * process.c: Make symbols static if they're not exported.
5584 (process_tick, update_tick, create_process, chan_process):
5585 (Vprocess_alist, proc_buffered_char, datagram_access):
5586 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5587 (deactivate_process): Mark defn as static, as well as decl.
5588 * lisp.h (create_process): Remove decl.
5589 * process.h (chan_process, Vprocess_alist): Remove decls.
5590
5591 * print.c: Make symbols static if they're not exported.
5592 (print_depth, new_backquote_output, being_printed, print_buffer):
5593 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5594 (print_interval, print_number_index, initial_stderr_stream):
5595 Now static.
5596 * lisp.h (Fprinc): Remove decl.
5597 (debug_output_compilation_hack): Mark as externally visible.
5598
5599 * sysdep.c (croak): Move decl from here to syssignal.h.
5600 * syssignal.h (croak): Put it here, so the API can be checked when
5601 'croak' is called from dissociate_if_controlling_tty.
5602
5603 * minibuf.c: Make symbols static if they're not exported.
5604 (minibuf_save_list, choose_minibuf_frame): Now static.
5605 * lisp.h (choose_minibuf_frame): Remove decl.
5606
5607 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5608
5609 * lread.c: Make symbols static if they're not exported.
5610 (read_objects, initial_obarray, oblookup_last_bucket_number):
5611 Now static.
5612 (make_symbol): Remove; unused.
5613 * lisp.h (initial_obarray, make_symbol): Remove decls.
5614
5615 * keyboard.c: Make symbols static if they're not exported.
5616 (single_kboard, recent_keys_index, total_keys, recent_keys):
5617 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5618 (this_single_command_key_start, echoing, last_auto_save):
5619 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5620 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5621 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5622 (Vlispy_mouse_stem, double_click_count):
5623 Now static.
5624 (force_auto_save_soon): Define only if SIGDANGER.
5625 (ignore_mouse_drag_p): Now static if
5626 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5627 (print_help): Remove; unused.
5628 (stop_character, last_timer_event): Mark as externally visible.
5629 * keyboard.h (ignore_mouse_drag_p): Declare only if
5630 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5631 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5632 * lisp.h (echoing): Remove decl.
5633 (force_auto_save_soon): Declare only if SIGDANGER.
5634 * xdisp.c (redisplay_window): Simplify code, to make it more
5635 obvious that ignore_mouse_drag_p is not accessed if !defined
5636 USE_GTK && !defined HAVE_NS.
5637
5638 * intervals.c: Make symbols static if they're not exported.
5639 (merge_properties_sticky, merge_interval_right, delete_interval):
5640 Now static.
5641 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5642
5643 * insdel.c: Make symbols static if they're not exported.
5644 However, leave prepare_to_modify_buffer alone. It's never
5645 called from outside this function, but that appears to be a bug.
5646 (combine_after_change_list, combine_after_change_buffer):
5647 (adjust_after_replace, signal_before_change): Now static.
5648 (adjust_after_replace_noundo): Remove; unused.
5649 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5650 (signal_before_change): Remove decls.
5651
5652 * indent.c (val_compute_motion, val_vmotion): Now static.
5653
5654 * image.c: Make symbols static if they're not exported.
5655 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5656 if USE_GTK.
5657 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5658 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5659
5660 * fringe.c (standard_bitmaps): Now static.
5661 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5662
5663 * frame.c: Make symbols static if they're not exported.
5664 (x_report_frame_params, make_terminal_frame): Now static.
5665 (get_frame_param): Now static, unless HAVE_NS.
5666 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5667 (x_get_resource_string): Remove; not used.
5668 * frame.h (make_terminal_frame, x_report_frame_params):
5669 (x_get_resource_string); Remove decls.
5670 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5671 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5672
5673 * font.c, fontset.c: Make symbols static if they're not exported.
5674 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5675 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5676 * font.c (font_close_object): Now static.
5677 * font.h (font_close_object): Remove.
5678 * fontset.c (FONTSET_OBJLIST): Remove.
5679 (free_realized_fontset) #if-0 the body, which does nothing.
5680 (face_suitable_for_char_p): #if-0, as it's never called.
5681 * fontset.h (face_suitable_for_char_p): Remove decl.
5682 * xfaces.c (face_at_string_position):
5683 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5684 since 0 is always ASCII.
5685
5686 * fns.c (weak_hash_tables): Now static.
5687
5688 * fileio.c: Make symbols static if they're not exported.
5689 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5690 (Vwrite_region_annotation_buffers): Now static.
5691
5692 * eval.c: Make symbols static if they're not exported.
5693 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5694 * lisp.h (backtrace_list): Remove decl.
5695
5696 * emacs.c: Make symbols static if they're not exported.
5697 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5698 (fatal_error_code, fatal_error_signal_hook, standard_args):
5699 Now static.
5700 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5701 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5702 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5703 * lisp.h (fatal_error_signal_hook): Remove decl.
5704 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5705
5706 * editfns.c: Move a (normally-unused) function to its only use.
5707 * editfns.c, lisp.h (get_operating_system_release): Remove.
5708 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5709 worth the hassle of breaking this out.
5710
5711 * xterm.c: Make symbols static if they're not exported.
5712 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5713 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5714 (x_destroy_window, x_delete_display):
5715 Now static.
5716 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5717 (x_mouse_leave): Remove; unused.
5718 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5719 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5720 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5721 Remove decls.
5722 (x_mouse_leave): Declare only if WINDOWSNT.
5723 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5724 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5725 USE_X_TOOLKIT.
5726
5727 * ftxfont.c: Make symbols static if they're not exported.
5728 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5729 HAVE_FREETYPE.
5730 * font.h (ftxfont_driver): Likewise.
5731
5732 * xfns.c: Make symbols static if they're not exported.
5733 (x_last_font_name, x_display_info_for_name):
5734 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5735 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5736 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5737 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5738 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5739 (last_show_tip_args): Now static.
5740 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5741 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5742 (x_screen_planes): Remove; unused.
5743 * dispextern.h (x_screen_planes): Remove decl.
5744
5745 * dispnew.c: Make symbols static if they're not exported.
5746 * dispextern.h (redraw_garbaged_frames, scrolling):
5747 (increment_row_positions): Remove.
5748 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5749 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5750 Now static.
5751 (redraw_garbaged_frames): Remove; unused.
5752
5753 * xfaces.c: Make symbols static if they're not exported.
5754 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5755 Remove decls.
5756 * xterm.h (defined_color): Remove decls.
5757 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5758 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5759 (menu_face_changed_default, defined_color, free_realized_face):
5760 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5761 (ascii_face_of_lisp_face): Remove; unused.
5762
5763 * xdisp.c: Make symbols static if they're not exported.
5764 * dispextern.h (scratch_glyph_row, window_box_edges):
5765 (glyph_to_pixel_coords, set_cursor_from_row):
5766 (get_next_display_element, set_iterator_to_next):
5767 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5768 (show_mouse_face): Remove decls
5769 * frame.h (message_buf_print): Likewise.
5770 * lisp.h (pop_message, set_message, check_point_in_composition):
5771 Likewise.
5772 * xterm.h (set_vertical_scroll_bar): Likewise.
5773 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5774 (message_buf_print, scratch_glyph_row, displayed_buffer):
5775 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5776 (get_next_display_element, show_mouse_face, window_box_edges):
5777 (frame_to_window_pixel_xy, check_point_in_composition):
5778 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5779 (glyph_to_pixel_coords): Remove; unused.
5780
5781 * dired.c (file_name_completion): Now static.
5782
5783 * dbusbind.c (xd_in_read_queued_messages): Now static.
5784
5785 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5786 * data.c (circular_list_error): Remove.
5787
5788 * commands.h (last_point_position, last_point_position_buffer):
5789 (last_point_position_window): Remove decls.
5790 * keyboard.c: Make these variables static.
5791
5792 * coding.h (coding, code_convert_region, encode_coding_gap):
5793 Remove decls.
5794 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5795 (iso_code_class, detect_coding, code_convert_region): Now static.
5796 (encode_coding_gap): Remove; unused.
5797
5798 * chartab.c (chartab_chars, chartab_bits): Now static.
5799
5800 * charset.h (charset_iso_8859_1): Remove decl.
5801 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5802 Now static.
5803
5804 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5805 * ccl.c (Vccl_program_table): Now static.
5806 (check_ccl_update): Remove; unused.
5807
5808 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5809 * category.h: ... from here.
5810 * category.c (check_category_table, set_category_set): Now static.
5811
5812 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5813 * lisp.h: Remove these decls.
5814
5815 * buffer.c (buffer_count): Remove unused var.
5816
5817 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5818 so that it's not optimized away.
5819 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5820 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5821 exported only to the debugger.
5822
5823 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5824 * atimer.h (run_all_atimers): Remove; not exported.
5825
5826 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5827 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5828 was inaccessible from Lisp.
5829 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5830 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5831
5832 alloc.c: Import and export fewer symbols, and remove unused items.
5833 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5834 is defined.
5835 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5836 it's not optimized away by whole-program optimization.
5837 (message_enable_multibyte, free_misc): Remove.
5838 (catchlist, handlerlist, mark_backtrace):
5839 Declare only if BYTE_MARK_STACK.
5840 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5841 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5842 (message_enable_multibyte): Remove decl.
5843 (free_misc, interval_free_list, float_block, float_block_index):
5844 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5845 (cons_free_list, last_marked_index):
5846 Now static.
5847 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5848 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5849 (mark_backtrace): Define only if BYTE_MARK_STACK.
5850 * xdisp.c (message_enable_multibyte): Now static.
5851
5852 Declare Lisp_Object Q* variables to be 'static' if not exported.
5853 This makes it easier for human readers (and static analyzers)
5854 to see whether these variables are used from other modules.
5855 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5856 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5857 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5858 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5859 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5860 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5861 * xmenu.c, xselect.c:
5862 Declare Q* vars static if they are not used in other modules.
5863 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5864 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5865 Remove decls of unexported vars.
5866 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5867
5868 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5869
5870 Make Emacs functions such as Fatom 'static' by default.
5871 This makes it easier for human readers (and static analyzers)
5872 to see whether these functions can be called from other modules.
5873 DEFUN now defines a static function. To make the function external
5874 so that it can be used in other C modules, use the new macro DEFUE.
5875 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5876 (Finit_image_library):
5877 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5878 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5879 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5880 Remove decls, since these functions are now static.
5881 (Funintern, Fget_internal_run_time): New decls, since these functions
5882 were already external.
5883
5884 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5885 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5886 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5887 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5888 * keyboard.c, keymap.c, lread.c:
5889 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5890 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5891 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5892 Mark functions with DEFUE instead of DEFUN,
5893 if they are used in other modules.
5894 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5895 decls for now-static functions.
5896 * buffer.h (Fdelete_overlay): Remove decl.
5897 * callproc.c (Fgetenv_internal): Mark as internal.
5898 * composite.c (Fremove_list_of_text_properties): Remove decl.
5899 (Fcomposition_get_gstring): New forward static decl.
5900 * composite.h (Fcomposite_get_gstring): Remove decl.
5901 * dired.c (Ffile_attributes): New forward static decl.
5902 * doc.c (Fdocumntation_property): New forward static decl.
5903 * eval.c (Ffetch_bytecode): New forward static decl.
5904 (Funintern): Remove extern decl; now in .h file where it belongs.
5905 * fileio.c (Fmake_symbolic_link): New forward static decl.
5906 * image.c (Finit_image_library): New forward static decl.
5907 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5908 * intervals.h (Fprevious_property_change):
5909 (Fremove_list_of_text_properties): Remove decls.
5910 * keyboard.c (Fthis_command_keys): Remove decl.
5911 (Fcommand_execute): New forward static decl.
5912 * keymap.c (Flookup_key): New forward static decl.
5913 (Fcopy_keymap): Now static.
5914 * keymap.h (Flookup_key): Remove decl.
5915 * process.c (Fget_process): New forward static decl.
5916 (Fprocess_datagram_address): Mark as internal.
5917 * syntax.c (Fsyntax_table_p): New forward static decl.
5918 (skip_chars): Remove duplicate decl.
5919 * textprop.c (Fprevious_property_change): New forward static decl.
5920 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5921 Now internal.
5922 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5923 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5924
5925 * editfns.c (Fformat): Remove unreachable code.
5926
5927 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5928
5929 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5930 change. (Bug#8496)
5931
5932 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5933
5934 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5935 when at ZV. (Bug#8487)
5936
5937 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5938
5939 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5940 (Bug#8437)
5941 * keyboard.c (parse_tool_bar_item): Likewise.
5942 * sound.c (sound_cleanup, alsa_close): Likewise.
5943 * termcap.c (tgetent): Likewise.
5944 * xfns.c (x_default_font_parameter): Likewise.
5945 * xsettings.c (read_and_apply_settings): Likewise.
5946
5947 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5948 (overrun_check_free): Protoize.
5949
5950 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5951
5952 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5953 since callers should never pass a negative size.
5954 Change the signature to match that of plain 'read' and 'write'; see
5955 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5956 * lisp.h: Update prototypes of emacs_write and emacs_read.
5957
5958 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5959
5960 * xdisp.c (redisplay_window): Don't try to determine the character
5961 position of the scroll margin if the window start point w->startp
5962 is outside the buffer's accessible region. (Bug#8468)
5963
5964 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5965
5966 Fix write-region and its subroutines for buffers > 2GB.
5967 * fileio.c (a_write, e_write): Modify declaration of arguments and
5968 local variables to support buffers larger than 2GB.
5969 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5970
5971 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5972 argument, local variables, and return value.
5973
5974 * lisp.h: Update prototypes of emacs_write and emacs_read.
5975
5976 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5977
5978 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5979
5980 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5981
5982 Fix more problems found by GCC 4.6.0's static checks.
5983
5984 * xdisp.c (vmessage): Use a better test for character truncation.
5985
5986 * charset.c (load_charset_map): <, not <=, for optimization,
5987 and to avoid potential problems with integer overflow.
5988 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5989 * casetab.c (set_identity, shuffle): Likewise.
5990 * editfns.c (Fformat): Likewise.
5991 * syntax.c (skip_chars): Likewise.
5992
5993 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5994 This also lets GCC 4.6.0 generate slightly better loop code.
5995
5996 * callint.c (Fcall_interactively): <, not <=, for optimization.
5997 (Fcall_interactively): Count the number of arguments produced,
5998 not the number of arguments given. This is simpler and lets GCC
5999 4.6.0 generate slightly better code.
6000
6001 * ftfont.c: Distingish more carefully between FcChar8 and char.
6002 The previous code passed unsigned char * to a functions like
6003 strlen and xstrcasecmp that expect char *, which does not
6004 conform to the C standard.
6005 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6006 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6007 char * when the C standard requires it.
6008
6009 * keyboard.c (read_char): Remove unused var.
6010
6011 * eval.c: Port to Windows vsnprintf (Bug#8435).
6012 Include <limits.h>.
6013 (SIZE_MAX): Define if the headers do not.
6014 (verror): Do not give up if vsnprintf returns a negative count.
6015 Instead, grow the buffer. This ports to Windows vsnprintf, which
6016 does not conform to C99. Problem reported by Eli Zaretskii.
6017 Also, simplify the allocation scheme, by avoiding the need for
6018 calling realloc, and removing the ALLOCATED variable.
6019
6020 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6021
6022 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6023 But keep the doprint source code for now, as we might revamp it
6024 and use it again (Bug#8435).
6025 * lisp.h (doprnt): Remove.
6026 * Makefile.in (base_obj): Remove doprnt.o.
6027 * deps.mk (doprnt.o): Remove.
6028
6029 error: Print 32- and 64-bit integers portably (Bug#8435).
6030 Without this change, on typical 64-bit hosts error ("...%d...", N)
6031 was used to print both 32- and 64-bit integers N, which relied on
6032 undefined behavior.
6033 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6034 New macro.
6035 * lisp.h (error, verror): Mark as printf-like functions.
6036 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6037 Report overflow in size calculations when allocating printf buffer.
6038 Do not truncate output string at its first null byte.
6039 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6040 Truncate the output at a character boundary, since vsnprintf does not
6041 do that.
6042 * charset.c (check_iso_charset_parameter): Convert internal
6043 character to string before calling 'error', since %c now has the
6044 printf meaning.
6045 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6046 overflow when computing char to be passed to 'error'. Do not
6047 pass Lisp_Object to 'error'; pass the integer instead.
6048 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6049 formatted with plain %d.
6050
6051 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6052
6053 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6054
6055 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6056
6057 * xterm.c (x_catch_errors): Remove duplicate declaration.
6058
6059 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6060
6061 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6062
6063 2011-04-10 Jim Meyering <meyering@redhat.com>
6064
6065 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6066 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6067 return ssize_t not "int", and use size_t as the buffer length.
6068 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6069 * gnutls.h: Update declarations.
6070 * process.c (read_process_output): Use ssize_t, to match.
6071 (send_process): Likewise.
6072
6073 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6074
6075 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6076
6077 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6078
6079 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6080 Use unsigned char, to match FcChar8 type definition.
6081
6082 * xterm.c (handle_one_xevent):
6083 * xmenu.c (create_and_show_popup_menu):
6084 * xselect.c (x_decline_selection_request)
6085 (x_reply_selection_request): Avoid type-punned deref of X events.
6086
6087 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6088
6089 Fix some uses of `int' instead of EMACS_INT.
6090 * search.c (string_match_1, fast_string_match)
6091 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6092 (scan_buffer, find_next_newline_no_quit)
6093 (find_before_next_newline, search_command, Freplace_match)
6094 (Fmatch_data): Make some `int' variables be EMACS_INT.
6095
6096 * xdisp.c (display_count_lines): 3rd argument and return value now
6097 EMACS_INT. All callers changed.
6098 (pint2hrstr): Last argument is now EMACS_INT.
6099
6100 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6101 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6102 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6103 (decode_coding_utf_16, decode_coding_emacs_mule)
6104 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6105 (decode_coding_ccl, decode_coding_charset)
6106 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6107 (decode_coding_iso_2022, decode_coding_emacs_mule)
6108 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6109 <char_offset, last_offset>: Declare EMACS_INT.
6110 (encode_coding_utf_8, encode_coding_utf_16)
6111 (encode_coding_emacs_mule, encode_invocation_designation)
6112 (encode_designation_at_bol, encode_coding_iso_2022)
6113 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6114 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6115 Declare EMACS_INT.
6116 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6117 (encode_invocation_designation): Last argument P_NCHARS is now
6118 EMACS_INT.
6119 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6120 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6121
6122 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6123 All users changed.
6124
6125 * ccl.c (Fccl_execute_on_string): Declare some variables
6126 EMACS_INT.
6127
6128 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6129
6130 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6131
6132 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6133
6134 * process.c (Fformat_network_address): Doc fix.
6135
6136 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6137
6138 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6139
6140 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6141
6142 * keyboard.c (read_char): Call Lisp function help-form-show,
6143 instead of using internal_with_output_to_temp_buffer.
6144 (Qhelp_form_show): New var.
6145 (syms_of_keyboard): Use DEFSYM macro.
6146
6147 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6148
6149 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6150
6151 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6152
6153 * process.c (Flist_processes): Remove to Lisp.
6154 (list_processes_1): Delete.
6155
6156 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6157
6158 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6159
6160 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6161
6162 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6163
6164 Fix more problems found by GCC 4.6.0's static checks.
6165
6166 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6167
6168 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6169
6170 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6171
6172 * xdisp.c (vmessage): Mark as a printf-like function.
6173
6174 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6175
6176 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6177
6178 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6179 printf-like functions.
6180 (tiff_load): Add casts to remove these marks before passing them
6181 to system-supplied API.
6182
6183 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6184
6185 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6186 This avoids several warnings with gcc -Wstrict-overflow.
6187 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6188 directly, rather than having caller test rule sign. This avoids
6189 some unnecessary tests.
6190 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6191 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6192 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6193
6194 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6195 (xfont_open): Avoid unnecessary tests.
6196
6197 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6198
6199 * composite.h, composite.c (composition_gstring_put_cache):
6200 Use EMACS_INT, not int, for length.
6201
6202 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6203 breaking out part of COMPOSITION_DECODE_RULE.
6204 (COMPOSITION_DECODE_RULE): Use it.
6205 * composite.c (get_composition_id): Remove unused local vars,
6206 by using the new macro.
6207
6208 * textprop.c (set_text_properties_1): Change while to do-while,
6209 since the condition is always true at first.
6210
6211 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6212 (interval_deletion_adjustment): Return unsigned value.
6213 All uses changed.
6214
6215 * process.c (list_processes_1, create_pty, read_process_output):
6216 (exec_sentinel): Remove vars that were set but not used.
6217 (create_pty): Remove unnecessary "volatile"s.
6218 (Fnetwork_interface_info): Avoid possibility of int overflow.
6219 (read_process_output): Do adaptive read buffering even if carryover.
6220 (read_process_output): Simplify nbytes computation if buffered.
6221
6222 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6223
6224 * syntax.c (scan_words): Remove var that was set but not used.
6225 (update_syntax_table): Use unsigned instead of int.
6226
6227 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6228 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6229 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6230
6231 * print.c (print_error_message): Avoid int overflow.
6232
6233 * font.c (font_list_entities): Redo for clarity,
6234 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6235
6236 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6237 (font_score): Avoid potential overflow in diff calculation.
6238
6239 * fns.c (substring_both): Remove var that is set but not used.
6240 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6241
6242 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6243
6244 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6245 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6246 can always succeed if overflow has undefined behavior.
6247
6248 * search.c (boyer_moore, wordify): Remove vars set but not used.
6249 (wordify): Omit three unnecessary tests.
6250
6251 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6252 All callers changed. This avoids the need for an unused var.
6253
6254 * casefiddle.c (casify_region): Remove var that is set but not used.
6255
6256 * dired.c (file_name_completion): Remove var that is set but not used.
6257
6258 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6259
6260 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6261 (Finsert_file_contents): Remove unnecessary code checking fd.
6262
6263 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6264 Check for integer overflow on size calculations.
6265
6266 * buffer.c (Fprevious_overlay_change): Remove var that is set
6267 but not used.
6268
6269 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6270 Remove vars that are set but not used.
6271 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6272 (timer_check_2): Mark vars as initialized.
6273
6274 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6275
6276 * image.c (lookup_image): Remove var that is set but not used.
6277 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6278
6279 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6280 that are set but not used.
6281
6282 * xfns.c (make_invisible_cursor): Don't return garbage
6283 if XCreateBitmapFromData fails (Bug#8410).
6284
6285 * xselect.c (x_get_local_selection, x_handle_property_notify):
6286 Remove vars that are set but not used.
6287
6288 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6289 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6290
6291 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6292 Remove var that is set but not used.
6293 (scroll_bar_windows_size): Now size_t, not int.
6294 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6295 Check for overflow.
6296
6297 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6298 (map_tty_color) [!defined MSDOS]: Likewise.
6299
6300 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6301
6302 * coding.c: Remove vars that are set but not used.
6303 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6304 All callers changed.
6305 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6306 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6307 (decode_coding_charset): Remove vars that are set but not used.
6308
6309 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6310 that is set but not used.
6311
6312 * print.c (print_object): Remove var that is set but not used.
6313
6314 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6315 The gnulib version avoids calling malloc in the usual case,
6316 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6317 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6318 * filelock.c (current_lock_owner): Likewise.
6319 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6320 * sysdep.c: Include allocator.h, careadlinkat.h.
6321 (emacs_no_realloc_allocator): New static constant.
6322 (emacs_readlink): New function.
6323 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6324 ../lib/careadlinkat.h.
6325
6326 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6327
6328 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6329 first non-nil return value).
6330
6331 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6332
6333 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6334 if not defined (Bug#8403).
6335
6336 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6337
6338 * xdisp.c (display_count_lines): Remove parameter `start',
6339 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6340 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6341 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6342 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6343 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6344 and thereabouts. All callers changed.
6345 (get_per_char_metric): Remove parameter `f', unused since
6346 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6347
6348 2011-04-02 Jim Meyering <meyering@redhat.com>
6349
6350 do not dereference NULL upon failed strdup
6351 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6352 (ns_get_family): Likewise.
6353
6354 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6355
6356 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6357
6358 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6359
6360 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6361 later (Bug#8403).
6362
6363 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6364
6365 Add lexical binding.
6366
6367 * window.c (Ftemp_output_buffer_show): New fun.
6368 (Fsave_window_excursion):
6369 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6370
6371 * lread.c (lisp_file_lexically_bound_p): New function.
6372 (Fload): Bind Qlexical_binding.
6373 (readevalloop): Remove `evalfun' arg.
6374 Bind Qinternal_interpreter_environment.
6375 (Feval_buffer): Bind Qlexical_binding.
6376 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6377 Mark as dynamic.
6378 (syms_of_lread): Declare `lexical-binding'.
6379
6380 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6381
6382 * keyboard.c (eval_dyn): New fun.
6383 (menu_item_eval_property): Use it.
6384
6385 * image.c (parse_image_spec): Use Ffunctionp.
6386
6387 * fns.c (concat, mapcar1): Accept byte-code-functions.
6388
6389 * eval.c (Fsetq): Handle lexical vars.
6390 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6391 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6392 (FletX, Flet): Obey lexical binding.
6393 (Fcommandp): Handle closures.
6394 (Feval): New `lexical' arg.
6395 (eval_sub): New function extracted from Feval. Use it almost
6396 everywhere where Feval was used. Look up vars in lexical env.
6397 Handle closures.
6398 (Ffunctionp): Move from subr.el.
6399 (Ffuncall): Handle closures.
6400 (apply_lambda): Remove `eval_flags'.
6401 (funcall_lambda): Handle closures and new byte-code-functions.
6402 (Fspecial_variable_p): New function.
6403 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6404 but without exporting it to Lisp.
6405
6406 * doc.c (Fdocumentation, store_function_docstring):
6407 * data.c (Finteractive_form): Handle closures.
6408
6409 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6410 interactive spec.
6411
6412 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6413 New byte-codes.
6414 (exec_byte_code): New function extracted from Fbyte_code to handle new
6415 calling convention for byte-code-functions. Add new byte-codes.
6416
6417 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6418
6419 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6420
6421 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6422
6423 * xdisp.c (redisplay_internal): Fix prototype.
6424
6425 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6426
6427 * xdisp.c (SCROLL_LIMIT): New macro.
6428 (try_scrolling): Use it when setting scroll_limit.
6429 Limit scrolling to 100 screen lines.
6430 (redisplay_window): Even when falling back on "recentering",
6431 position point in the window according to scroll-conservatively,
6432 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6433
6434 (try_scrolling): When point is above the window, allow searching
6435 as far as scroll_max, or one screenful, to compute vertical
6436 distance from PT to the scroll margin position. This prevents
6437 try_scrolling from unnecessarily failing when
6438 scroll-conservatively is set to a value slightly larger than the
6439 window height. Clean up the case of PT below the margin at bottom
6440 of window: scroll_max can no longer be INT_MAX. When aggressive
6441 scrolling is in use, don't let point enter the opposite scroll
6442 margin as result of the scroll.
6443 (syms_of_xdisp) <scroll-conservatively>: Document the
6444 threshold of 100 lines for never-recentering scrolling.
6445
6446 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6447
6448 * dispextern.h (move_it_by_lines):
6449 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6450 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6451 (message_log_check_duplicate): Remove parameters `prev_bol' and
6452 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6453 (redisplay_internal): Remove parameter `preserve_echo_area',
6454 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6455
6456 * indent.c (Fvertical_motion):
6457 * window.c (window_scroll_pixel_based, Frecenter):
6458 Don't pass `need_y_p' to `move_it_by_lines'.
6459
6460 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6461
6462 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6463 steal a few bits to be more compact.
6464 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6465 Remove unneeded casts.
6466
6467 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6468
6469 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6470
6471 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6472 binding" message (bug#7967).
6473
6474 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6475
6476 Fix more problems found by GCC 4.6.0's static checks.
6477
6478 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6479 Remove unused local var.
6480
6481 * editfns.c (Fmessage_box): Remove unused local var.
6482
6483 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6484 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6485 Omit unused local vars.
6486 * window.c (shrink_windows): Omit unused local var.
6487 * menu.c (digest_single_submenu): Omit unused local var.
6488 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6489 Omit unused local var.
6490
6491 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6492 Don't assume string length fits in int.
6493 (keyremap_step, read_key_sequence): Use size_t for sizes.
6494 (read_key_sequence): Don't check last_real_key_start redundantly.
6495
6496 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6497 instead of alloca (Bug#8344).
6498
6499 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6500 (Fbacktrace_frame): Don't assume nframes fits in int.
6501
6502 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6503
6504 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6505 concerns.
6506
6507 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6508
6509 * cm.c (calccost): Turn while-do into do-while, for clarity.
6510
6511 * keyboard.c (syms_of_keyboard): Use the same style as later
6512 in this function when indexing through an array. This also
6513 works around GCC bug 48267.
6514
6515 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6516
6517 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6518
6519 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6520 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6521
6522 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6523 This avoids undefined behavior on integer overflow, and is a bit
6524 more convenient anyway since it is compared to a size_t variable.
6525
6526 Variadic C functions now count arguments with size_t, not int.
6527 This avoids an unnecessary limitation on 64-bit machines, which
6528 caused (substring ...) to crash on large vectors (Bug#8344).
6529 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6530 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6531 All variadic functions and their callers changed accordingly.
6532 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6533 * data.c (arith_driver, float_arith_driver): Likewise.
6534 * editfns.c (general_insert_function): Likewise.
6535 * eval.c (struct backtrace.nargs, interactive_p)
6536 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6537 (funcall_lambda, mark_backtrace): Likewise.
6538 * fns.c (concat): Likewise.
6539 * frame.c (x_set_frame_parameters): Likewise.
6540 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6541 0 if not found, not -1. All callers changed.
6542
6543 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6544 (stack_copy_size): Now size_t, not int.
6545 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6546
6547 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6548
6549 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6550 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6551 All callers changed.
6552
6553 * lisp.h (multibyte_char_to_unibyte):
6554 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6555 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6556 * character.h (CHAR_TO_BYTE8):
6557 * cmds.c (internal_self_insert):
6558 * editfns.c (general_insert_function):
6559 * keymap.c (push_key_description):
6560 * search.c (Freplace_match):
6561 * xdisp.c (message_dolog, set_message_1): All callers changed.
6562
6563 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6564
6565 * keyboard.c (safe_run_hook_funcall): New function.
6566 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6567 don't set the hook to nil, but remove the offending function instead.
6568 (Qcommand_hook_internal): Remove, unused.
6569 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6570 Vcommand_hook_internal.
6571
6572 * eval.c (enum run_hooks_condition): Remove.
6573 (funcall_nil, funcall_not): New functions.
6574 (run_hook_with_args): Call each function through a `funcall' argument.
6575 Remove `cond' argument, now redundant.
6576 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6577 (Frun_hook_with_args_until_failure): Adjust accordingly.
6578 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6579
6580 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6581
6582 * dispextern.h (string_buffer_position): Remove declaration.
6583
6584 * print.c (strout): Remove parameter `multibyte', unused since
6585 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6586
6587 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6588 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6589 All callers changed.
6590
6591 * w32.c (_wsa_errlist): Use braces for struct initializers.
6592
6593 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6594 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6595 All callers changed.
6596 (string_buffer_position): Likewise. Also, make static (it's never
6597 used outside xdisp.c).
6598 (cursor_row_p): Remove parameter `w', unused since
6599 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6600 (decode_mode_spec): Remove parameter `precision', introduced during
6601 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6602 All callers changed.
6603
6604 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6605
6606 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6607
6608 2011-03-27 Anders Lindgren <andlind@gmail.com>
6609
6610 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6611 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6612 (ns_update_auto_hide_menu_bar): New functions.
6613 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6614 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6615 ns_constrain_all_frames.
6616 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6617 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6618
6619 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6620
6621 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6622
6623 2011-03-27 Glenn Morris <rgm@gnu.org>
6624
6625 * syssignal.h: Replace RETSIGTYPE with void.
6626 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6627 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6628 Replace SIGTYPE with void everywhere.
6629 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6630 * s/template.h (SIGTYPE): Remove commented out definition.
6631
6632 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6633
6634 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6635 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6636
6637 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6638
6639 * w32.c (read_unc_volume): Use parameter `henum', instead of
6640 global variable `wget_enum_handle'.
6641
6642 * keymap.c (describe_vector): Remove parameters `indices' and
6643 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6644 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6645
6646 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6647
6648 * keyboard.c (timer_check): Remove parameter `do_it_now',
6649 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6650 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6651 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6652
6653 * keyboard.c (read_char):
6654 * w32menu.c (w32_menu_display_help):
6655 * xmenu.c (show_help_event, menu_help_callback):
6656 Adjust calls to `show_help_echo'.
6657
6658 * gtkutil.c (xg_maybe_add_timer):
6659 * keyboard.c (readable_events):
6660 * process.c (wait_reading_process_output):
6661 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6662
6663 * insdel.c (adjust_markers_gap_motion):
6664 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6665 (gap_left, gap_right): Don't call it.
6666
6667 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6668
6669 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6670 incurred during fontification.
6671
6672 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6673
6674 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6675 (DEFVAR_PER_BUFFER): Don't pass it.
6676
6677 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6678 (scrolling_window): Don't pass it.
6679
6680 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6681
6682 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6683
6684 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6685 and `suffix'.
6686 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6687 of variables specific to SELinux and computation of `encoded_absname'.
6688
6689 * image.c (XPutPixel): Remove unused variable `height'.
6690
6691 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6692
6693 * unexw32.c (get_section_info): Remove unused variable `section'.
6694
6695 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6696 (system_process_attributes): Remove unused variable `sess'.
6697 (sys_read): Remove unused variable `err'.
6698
6699 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6700 (w32_wnd_proc): Remove unused variable `isdead'.
6701 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6702 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6703 (x_create_tip_frame): Remove unused variable `tem'.
6704
6705 * w32inevt.c (w32_console_read_socket):
6706 Remove unused variable `no_events'.
6707
6708 * w32term.c (x_draw_composite_glyph_string_foreground):
6709 Remove unused variable `width'.
6710
6711 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6712
6713 * w32term.c (x_set_glyph_string_clipping):
6714 Don't pass uninitialized region to CombineRgn.
6715
6716 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6717
6718 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6719 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6720 (Fx_close_connection): Remove unused variable `i'.
6721
6722 * w32font.c (w32font_draw): Return number of glyphs.
6723 (w32font_open_internal): Remove unused variable `i'.
6724 (w32font_driver): Add missing initializer.
6725
6726 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6727 (fill_in_menu): Remove unused variable `items_added'.
6728
6729 * w32term.c (last_mouse_press_frame): Remove static global variable.
6730 (w32_clip_to_row): Remove unused variable `f'.
6731 (x_delete_terminal): Remove unused variable `i'.
6732
6733 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6734 (NOTHING): Remove unused static global variable.
6735 (uniscribe_check_otf): Remove unused variable `table'.
6736 (uniscribe_font_driver): Add missing initializers.
6737
6738 2011-03-23 Julien Danjou <julien@danjou.info>
6739
6740 * term.c (Fsuspend_tty, Fresume_tty):
6741 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6742 * window.c (temp_output_buffer_show):
6743 * insdel.c (signal_before_change):
6744 * frame.c (Fhandle_switch_frame):
6745 * fileio.c (Fdo_auto_save):
6746 * emacs.c (Fkill_emacs):
6747 * editfns.c (save_excursion_restore):
6748 * cmds.c (internal_self_insert):
6749 * callint.c (Fcall_interactively):
6750 * buffer.c (Fkill_all_local_variables):
6751 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6752 Use Frun_hooks.
6753 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6754 unconditionnaly since it does the check itself.
6755
6756 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6757
6758 Fix more problems found by GCC 4.5.2's static checks.
6759
6760 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6761 the first time through the loop, since we know p0 < p1 then.
6762 This also avoids a gcc -Wstrict-overflow warning.
6763
6764 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6765 leading to a memory leak, possible in functions like
6766 load_charset_map_from_file that can allocate an unbounded number
6767 of objects (Bug#8318).
6768
6769 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6770 that could (at least in theory) be that large.
6771
6772 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6773 This is less likely to overflow, and avoids undefined behavior if
6774 overflow does occur. All callers changed. Use strtoul to scan
6775 for the unsigned long integer.
6776 (pint2hrstr): Simplify and tune code slightly.
6777 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6778
6779 * scroll.c (do_scrolling): Work around GCC bug 48228.
6780 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6781
6782 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6783 This also avoids a warning with gcc -Wstrict-overflow.
6784 (validate_x_resource_name): Simplify count usage.
6785 This also avoids a warning with gcc -Wstrict-overflow.
6786
6787 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6788 fail (Bug#8306).
6789
6790 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6791
6792 * process.c (Fmake_network_process): Use socklen_t, not int,
6793 where POSIX says socklen_t is required in portable programs.
6794 This fixes a porting bug on hosts like 64-bit HP-UX, where
6795 socklen_t is wider than int (Bug#8277).
6796 (Fmake_network_process, server_accept_connection):
6797 (wait_reading_process_output, read_process_output):
6798 Likewise.
6799
6800 * process.c: Rename or move locals to avoid shadowing.
6801 (list_processes_1, Fmake_network_process):
6802 (read_process_output_error_handler, exec_sentinel_error_handler):
6803 Rename or move locals.
6804 (Fmake_network_process): Define label "retry_connect" only if needed.
6805 (Fnetwork_interface_info): Fix pointer signedness.
6806 (process_send_signal): Add cast to avoid pointer signedness problem.
6807 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6808 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6809
6810 Make tparam.h and terminfo.c consistent.
6811 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6812 Include tparam.h instead, since it declares them.
6813 * cm.h (PC): Remove extern decl; tparam.h now does this.
6814 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6815 * terminfo.c: Include tparam.h, to check interfaces.
6816 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6817 (tparam): Adjust signature to match interface in tparam.h;
6818 this removes some undefined behavior. Check that outstring and len
6819 are zero, which they always are with Emacs.
6820 * tparam.h (PC, BC, UP): New extern decls.
6821
6822 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6823 (xftfont_open): Rename locals to avoid shadowing.
6824
6825 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6826 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6827 (OTF_TAG_SYM): Omit macro if not needed.
6828 (ftfont_list): Remove unused local.
6829 (get_adstyle_property, ftfont_pattern_entity):
6830 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6831 Rename locals to avoid shadowing.
6832
6833 * xfont.c (xfont_list_family): Mark var as initialized.
6834
6835 * xml.c (make_dom): Now static.
6836
6837 * composite.c (composition_compute_stop_pos): Rename local to
6838 avoid shadowing.
6839 (composition_reseat_it): Remove unused locals.
6840 (find_automatic_composition, composition_adjust_point): Likewise.
6841 (composition_update_it): Mark var as initialized.
6842 (find_automatic_composition): Mark vars as initialized,
6843 with a FIXME (Bug#8290).
6844
6845 character.h: Rename locals to avoid shadowing.
6846 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6847 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6848 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6849 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6850 to avoid shadowing.
6851
6852 * textprop.c (property_change_between_p): Remove; unused.
6853
6854 * intervals.c (interval_start_pos): Now static.
6855
6856 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6857
6858 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6859 Rename locals to avoid shadowing.
6860
6861 * sound.c (wav_play, au_play, Fplay_sound_internal):
6862 Fix pointer signedness.
6863 (alsa_choose_format): Remove unused local var.
6864 (wav_play): Initialize a variable to 0, to prevent undefined
6865 behavior (Bug#8278).
6866
6867 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6868
6869 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6870
6871 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6872 clobbering (Bug#8298).
6873 * sysdep.c (sys_subshell): Likewise.
6874 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6875
6876 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6877 This should get cleaned up, so that child_setup has the
6878 same signature on all platforms.
6879
6880 * callproc.c (call_process_cleanup): Now static.
6881 (relocate_fd): Rename locals to avoid shadowing.
6882
6883 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6884
6885 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6886 not to be necessary, and produces flickering.
6887
6888 2011-03-20 Glenn Morris <rgm@gnu.org>
6889
6890 * config.in: Remove file.
6891
6892 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6893
6894 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6895 are now in src/globals.h.
6896 (syms_of_minibuf): Remove spurious & from previous change.
6897
6898 2011-03-20 Leo <sdl.web@gmail.com>
6899
6900 * minibuf.c (completing-read-function): New variable.
6901 (completing-read-default): Rename from completing-read.
6902 (completing-read): Call completing-read-function.
6903
6904 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6905
6906 * xfaces.c (Fx_load_color_file):
6907 Read color file from absolute filename (bug#8250).
6908
6909 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6910
6911 * makefile.w32-in: Update dependencies.
6912
6913 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6914
6915 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6916
6917 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6918
6919 Fix more problems found by GCC 4.5.2's static checks.
6920
6921 * process.c (make_serial_process_unwind, send_process_trap):
6922 (sigchld_handler): Now static.
6923
6924 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6925 That way, the code declares only the vars that it needs.
6926 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6927 * s/cygwin.h (PTY_ITERATION): Likewise.
6928 * s/darwin.h (PTY_ITERATION): Likewise.
6929 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6930
6931 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6932 * process.c (allocate_pty): Don't declare stb unless it's needed.
6933
6934 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6935 (CONSTANTLIM): Remove; unused.
6936 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6937 Define only if needed.
6938
6939 * unexelf.c (unexec): Name an expression,
6940 to avoid gcc -Wbad-function-cast warning.
6941 Use a different way to cause a compilation error if anyone uses
6942 n rather than nn, a way that does not involve shadowing.
6943 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6944
6945 * deps.mk (unexalpha.o): Remove; unused.
6946
6947 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6948 * unexec.h: New file.
6949 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6950 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6951 Depend on unexec.h.
6952 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6953 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6954 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6955 Change as necessary to match prototype in unexec.h.
6956
6957 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6958 shadowing.
6959 (back_comment, skip_chars): Mark vars as initialized.
6960
6961 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6962 Rename locals to avoid shadowing.
6963
6964 * lread.c (read1): Rewrite so as not to use empty "else".
6965 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6966
6967 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6968
6969 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6970 warning when compiling print.c.
6971
6972 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6973 instead of using an uninitialized var.
6974 (font_sort_entities): Mark var as initialized.
6975
6976 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6977
6978 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6979 pointers to constants.
6980 (font_parse_fcname): Remove unused vars.
6981 (font_delete_unmatched): Now static.
6982 (font_get_spec): Remove; unused.
6983 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6984 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6985 Rename or move locals to avoid shadowing.
6986
6987 * fns.c (require_nesting_list, require_unwind): Now static.
6988 (Ffillarray): Rename locals to avoid shadowing.
6989
6990 * floatfns.c (domain_error2): Define only if needed.
6991 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6992
6993 * alloc.c (mark_backtrace): Move decl from here ...
6994 * lisp.h: ... to here, so that it can be checked.
6995
6996 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6997 (Fdefvar): Rewrite so as not to use empty "else".
6998 (lisp_indirect_variable): Name an expression,
6999 to avoid gcc -Wbad-function-cast warning.
7000 (Fdefvar): Rename locals to avoid shadowing.
7001
7002 * callint.c (quotify_arg, quotify_args): Now static.
7003 (Fcall_interactively): Rename locals to avoid shadowing.
7004 Use const pointer when appropriate.
7005
7006 * lisp.h (get_system_name, get_operating_system_release):
7007 Move decls here, to check interfaces.
7008 * process.c (get_operating_system_release): Move decl to lisp.h.
7009 * xrdb.c (get_system_name): Likewise.
7010 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7011 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7012 some of which prompt warnings from gcc -Wbad-function-cast.
7013 (Fformat_time_string, Fencode_time, Finsert_char):
7014 (Ftranslate_region_internal, Fformat):
7015 Rename or remove local vars to avoid shadowing.
7016 (Ftranslate_region_internal): Mark var as initialized.
7017
7018 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7019 avoid shadowing.
7020
7021 * lisp.h (eassert): Check that the argument compiles, even if
7022 ENABLE_CHECKING is not defined.
7023
7024 * data.c (Findirect_variable): Name an expression, to avoid
7025 gcc -Wbad-function-cast warning.
7026 (default_value, arithcompare, arith_driver, arith_error): Now static.
7027 (store_symval_forwarding): Rename local to avoid shadowing.
7028 (Fmake_variable_buffer_local, Fmake_local_variable):
7029 Mark variables as initialized.
7030 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7031
7032 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7033 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7034 Rename locals to avoid shadowing.
7035 (mark_stack): Move local variables into the #ifdef region where
7036 they're used.
7037 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7038 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7039 needed otherwise.
7040 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7041 (GC_STRING_CHARS): Remove; not used.
7042 (Fmemory_limit): Cast sbrk's returned value to char *.
7043
7044 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7045 avoids undefined behavior in theory.
7046
7047 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7048
7049 Use functions, not macros, for up- and down-casing (Bug#8254).
7050 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7051 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7052 to use the following functions instead of these macros.
7053 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7054 EMACS_INT, since callers assume the returned value fits in int.
7055 (upcase1): Likewise, for UPCASE_TABLE.
7056 (uppercasep, lowercasep, upcase): New static inline functions.
7057 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7058 the race-condition problem in the old DOWNCASE.
7059
7060 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7061 Rename locals to avoid shadowing.
7062 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7063 (regex_compile, re_search_2, re_match_2_internal):
7064 Remove unused local vars.
7065 (FREE_VAR): Rewrite so as not to use empty "else",
7066 which gcc can warn about.
7067 (regex_compile, re_match_2_internal): Mark locals as initialized.
7068 (RETALLOC_IF): Define only if needed.
7069 (WORDCHAR_P): Likewise. This one is never needed, but is used
7070 only in a comment talking about a compiler bug, so put inside
7071 the #if 0 of that comment.
7072 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7073 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7074 Remove; unused.
7075
7076 * search.c (boyer_moore): Rename locals to avoid shadowing.
7077 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7078 (PREV_CHAR_BOUNDARY): Likewise.
7079
7080 * search.c (simple_search): Remove unused var.
7081
7082 * dired.c (compile_pattern): Move decl from here ...
7083 * lisp.h: ... to here, so that it can be checked.
7084 (struct re_registers): New forward decl.
7085
7086 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7087
7088 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7089 All uses changed.
7090 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7091 Rename locals to avoid shadowing.
7092 (Fvertical_motion): Mark locals as initialized.
7093
7094 * casefiddle.c (casify_object, casify_region): Now static.
7095 (casify_region): Mark local as initialized.
7096
7097 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7098
7099 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7100 New macros, so that the caller can use some names other than
7101 gcpro1, gcpro2, etc.
7102 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7103 of the new macros.
7104 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7105 argument, for consistency with GCPRO2_VAR, etc: it is now the
7106 prefix of the variable, not the variable itself. All uses
7107 changed.
7108 * dired.c (directory_files_internal, file_name_completion):
7109 Rename locals to avoid shadowing.
7110
7111 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7112 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7113 dired.c's scmp function, had undefined behavior.
7114 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7115 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7116 * buffer.h: ... to here, because these macros use current_buffer,
7117 and the new implementation with inline functions needs to have
7118 current_buffer in scope now, rather than later when the macros
7119 are used.
7120 (downcase, upcase1): New static inline functions.
7121 (DOWNCASE, UPCASE1): Reimplement using these functions.
7122 This avoids undefined behavior in expressions like
7123 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7124 from race conditions in accessing the global variables
7125 case_temp1 and case_temp2.
7126 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7127 * lisp.h (case_temp1, case_temp2): Remove their decls.
7128 * character.h (ASCII_CHAR_P): Move from here ...
7129 * lisp.h: ... to here, so that the inline functions mentioned
7130 above can use them.
7131
7132 * dired.c (directory_files_internal_unwind): Now static.
7133
7134 * fileio.c (file_name_as_directory, directory_file_name):
7135 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7136 Now static.
7137 (file_name_as_directory): Use const pointers when appropriate.
7138 (Fexpand_file_name): Likewise. In particular, newdir might
7139 point at constant storage, so make it a const pointer.
7140 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7141 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7142 signedness issues.
7143 (Fset_file_times, Finsert_file_contents, auto_save_error):
7144 Rename locals to avoid shadowing.
7145
7146 * minibuf.c (choose_minibuf_frame_1): Now static.
7147 (Ftry_completion, Fall_completions): Rename or remove locals
7148 to avoid shadowing.
7149
7150 * marker.c (bytepos_to_charpos): Remove; unused.
7151
7152 * lisp.h (verify_bytepos, count_markers): New decls,
7153 so that gcc does not warn that these functions aren't declared.
7154
7155 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7156 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7157 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7158 (copy_text): Remove unused local var.
7159
7160 * filelock.c (within_one_second): Now static.
7161 (lock_file_1): Rename local to avoid shadowing.
7162
7163 * buffer.c (fix_overlays_before): Mark locals as initialized.
7164 (fix_start_end_in_overlays): Likewise. This function should be
7165 simplified by using pointers-to-pointers, but that's a different
7166 matter.
7167 (switch_to_buffer_1): Now static.
7168 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7169 (report_overlay_modification): Rename locals to avoid shadowing.
7170
7171 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7172 Fix pointer signedness issue.
7173 (sys_subshell): Mark local as volatile if checking for lint,
7174 to suppress a gcc -Wclobbered warning that does not seem to be right.
7175 (MAXPATHLEN): Define only if needed.
7176
7177 * process.c (serial_open, serial_configure): Move decls from here ...
7178 * systty.h: ... to here, so that they can be checked.
7179
7180 * fns.c (get_random, seed_random): Move extern decls from here ...
7181 * lisp.h: ... to here, so that they can be checked.
7182
7183 * sysdep.c (reset_io): Now static.
7184 (wait_for_termination_signal): Remove; unused.
7185
7186 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7187 (copy_keymap_item, append_key, push_text_char_description):
7188 Now static.
7189 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7190 (DENSE_TABLE_SIZE): Remove; unused.
7191 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7192 (describe_map_tree):
7193 Rename locals to avoid shadowing.
7194
7195 * keyboard.c: Declare functions static if they are not used elsewhere.
7196 (echo_char, echo_dash, cmd_error, top_level_2):
7197 (poll_for_input, handle_async_input): Now static.
7198 (read_char, kbd_buffer_get_event, make_lispy_position):
7199 (make_lispy_event, make_lispy_movement, apply_modifiers):
7200 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7201 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7202 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7203 (read_key_sequence, read_char): Mark locals as initialized.
7204 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7205
7206 * keyboard.h (make_ctrl_char): New decl.
7207 (mark_kboards): Move decl here ...
7208 * alloc.c (mark_kboards): ... from here.
7209
7210 * lisp.h (force_auto_save_soon): New decl.
7211
7212 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7213 (DEFINE_DUMMY_FUNCTION): New macro.
7214 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7215 Use it.
7216 (main): Add casts to avoid warnings
7217 if GCC considers string literals to be constants.
7218
7219 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7220
7221 * dbusbind.c: Pointer signedness fixes.
7222 (xd_signature, xd_append_arg, xd_initialize):
7223 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7224 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7225 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7226 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7227
7228 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7229 if GCC considers string literals to be constants.
7230 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7231
7232 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7233
7234 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7235 (print_preprocess, print_object): New macro to fix last change.
7236
7237 * print.c (print_preprocess): Don't forget font objects.
7238
7239 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7240
7241 * emacs.c (USAGE3): Doc fixes.
7242
7243 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7244
7245 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7246 structure.
7247
7248 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7249
7250 * lisp.h (VWindow_system, Qfile_name_history):
7251 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7252 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7253 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7254
7255 * w32select.c: Don't #include "keyboard.h".
7256 (run_protected): Add extern declaration for waiting_for_input.
7257
7258 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7259 * w32console.c (detect_input_pending, read_input_pending)
7260 (encode_terminal_code):
7261 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7262 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7263 (w32_system_caret_y, Qfile_name_history):
7264 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7265 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7266 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7267 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7268 * w32proc.c (Qlocal, report_file_error):
7269 * w32term.c (Vwindow_system, updating_frame):
7270 * w32uniscribe.c (initialized, uniscribe_font_driver):
7271 Remove unneeded extern declarations.
7272
7273 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7274
7275 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7276
7277 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7278
7279 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7280 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7281 These macros can no longer be used for assignment.
7282
7283 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7284 Assign struct members directly, instead of using BUF_BEGV etc.
7285 (record_buffer_markers, fetch_buffer_markers): New functions for
7286 recording and fetching special buffer markers.
7287 (set_buffer_internal_1, set_buffer_temp): Use them.
7288
7289 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7290
7291 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7292
7293 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7294 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7295
7296 * xdisp.c (hscroll_window_tree):
7297 (reconsider_clip_changes): Use PT instead of BUF_PT.
7298
7299 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7300
7301 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7302 $(EMACS_ROOT)/lib/intprops.h.
7303
7304 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7305
7306 Fix more problems found by GCC 4.5.2's static checks.
7307
7308 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7309 to unsigned char * to avoid compiler diagnostic.
7310 (xg_free_frame_widgets): Make it clear that a local variable is
7311 needed only if USE_GTK_TOOLTIP.
7312 (gdk_window_get_screen): Make it clear that this macro is needed
7313 only if USE_GTK_TOOLTIP.
7314 (int_gtk_range_get_value): New function, which avoids a diagnostic
7315 from gcc -Wbad-function-cast.
7316 (xg_set_toolkit_scroll_bar_thumb): Use it.
7317 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7318 diagnostic from gcc -Wbad-function-cast.
7319 (get_utf8_string, xg_get_file_with_chooser):
7320 Rename locals to avoid shadowing.
7321 (create_dialog): Move locals to avoid shadowing.
7322
7323 * xgselect.c (xg_select): Remove unused var.
7324
7325 * image.c (four_corners_best): Mark locals as initialized.
7326 (gif_load): Initialize transparent_p to zero (Bug#8238).
7327 Mark another local as initialized.
7328 (my_png_error, my_error_exit): Mark with NO_RETURN.
7329
7330 * image.c (clear_image_cache): Now static.
7331 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7332 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7333 (x_edge_detection): Remove unnecessary cast that
7334 gcc -Wbad-function-cast diagnoses.
7335 (gif_load): Fix pointer signedness.
7336 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7337 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7338
7339 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7340
7341 Improve quality of tests for time stamp overflow.
7342 For example, without this patch (encode-time 0 0 0 1 1
7343 1152921504606846976) returns the obviously-bogus value (-948597
7344 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7345 reports time overflow. See
7346 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7347 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7348 * editfns.c: Include limits.h and intprops.h.
7349 (TIME_T_MIN, TIME_T_MAX): New macros.
7350 (time_overflow): Move earlier, to before first use.
7351 (hi_time, lo_time): New functions, for an accurate test for
7352 out-of-range times.
7353 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7354 (Fget_internal_run_time): Don't assume time_t fits in int.
7355 (make_time): Use list2 instead of Fcons twice.
7356 (Fdecode_time): More accurate test for out-of-range times.
7357 (check_tm_member): New function.
7358 (Fencode_time): Use it, to test for out-of-range times.
7359 (lisp_time_argument): Don't rely on undefined left-shift and
7360 right-shift behavior when checking for time stamp overflow.
7361
7362 * editfns.c (time_overflow): New function, refactoring common code.
7363 (Fformat_time_string, Fdecode_time, Fencode_time):
7364 (Fcurrent_time_string): Use it.
7365
7366 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7367 * dired.c (make_time): Move to ...
7368 * editfns.c (make_time): ... here.
7369 * systime.h: Note the move.
7370
7371 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7372
7373 * fringe.c (update_window_fringes): Remove unused variables.
7374
7375 * unexmacosx.c (copy_data_segment): Also copy __got section.
7376 (Bug#8223)
7377
7378 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7379
7380 * termcap.c [MSDOS]: Include "msdos.h".
7381 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7382 Constify `char *' arguments and their references according to
7383 prototypes in tparam.h.
7384
7385 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7386
7387 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7388 Adapt all references accordingly.
7389
7390 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7391
7392 2011-03-11 Tom Tromey <tromey@redhat.com>
7393
7394 * buffer.c (syms_of_buffer): Remove obsolete comment.
7395
7396 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7397
7398 * termhooks.h (encode_terminal_code): Declare prototype.
7399
7400 * msdos.c (encode_terminal_code): Don't declare prototype.
7401
7402 * term.c (encode_terminal_code): Now external again, used by
7403 w32console.c and msdos.c.
7404
7405 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7406 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7407
7408 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7409
7410 Fix some minor problems found by GCC 4.5.2's static checks.
7411
7412 * fringe.c (update_window_fringes): Mark locals as initialized
7413 (Bug#8227).
7414 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7415
7416 * alloc.c (mark_fringe_data): Move decl from here ...
7417 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7418 to check its interface.
7419 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7420
7421 * fontset.c (free_realized_fontset): Now static.
7422 (Fset_fontset_font): Rename local to avoid shadowing.
7423 (fontset_font): Mark local as initialized.
7424 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7425
7426 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7427
7428 * xselect.c (x_disown_buffer_selections): Remove; not used.
7429 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7430 (x_own_selection, Fx_disown_selection_internal): Rename locals
7431 to avoid shadowing.
7432 (x_handle_dnd_message): Remove local to avoid shadowing.
7433
7434 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7435 so that the caller can use some name other than gcpro1.
7436 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7437 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7438 (Fx_backspace_delete_keys_p):
7439 Use them to avoid shadowing, and rename vars to avoid shadowing.
7440 (x_decode_color, x_set_name, x_window): Now static.
7441 (Fx_create_frame): Add braces to silence GCC warning.
7442 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7443 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7444 Remove unused locals.
7445 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7446 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7447 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7448 macros.
7449
7450 * xterm.h (x_mouse_leave): New decl.
7451
7452 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7453 Remove unused functions.
7454 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7455 (x_calc_absolute_position): Now static.
7456 (XTread_socket): Don't define label "out" unless it's used.
7457 Don't declare local "event" unless it's used.
7458 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7459 unless they are used.
7460 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7461 (x_fatal_error_signal): Remove; not used.
7462 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7463 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7464 (x_error_catcher, x_connection_closed, x_error_handler):
7465 (x_error_quitter, xembed_send_message, x_iconify_frame):
7466 (my_log_handler): Rename locals to avoid shadowing.
7467 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7468 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7469
7470 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7471 Rename or move locals to avoid shadowing.
7472 (tty_defined_color, merge_face_heights): Now static.
7473 (free_realized_faces_for_fontset): Remove; not used.
7474 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7475 does not deduce is never used uninitialized.
7476 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7477 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7478
7479 * terminal.c (store_terminal_param): Now static.
7480
7481 * xmenu.c (menu_highlight_callback): Now static.
7482 (set_frame_menubar): Remove unused local.
7483 (xmenu_show): Rename parameter to avoid shadowing.
7484 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7485 since they might point to immutable storage.
7486 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7487 since it's unused otherwise.
7488
7489 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7490 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7491 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7492 avoids a gcc -Wuninitialized diagnostic.
7493 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7494 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7495 does not deduce are never used uninitialized.
7496
7497 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7498
7499 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7500 * window.c (window_loop, size_window):
7501 (run_window_configuration_change_hook, enlarge_window): Likewise.
7502
7503 * window.c (display_buffer): Now static.
7504 (size_window): Mark variables that gcc -Wuninitialized
7505 does not deduce are never used uninitialized.
7506 * window.h (check_all_windows): New decl, to forestall
7507 gcc -Wmissing-prototypes diagnostic.
7508 * dispextern.h (bidi_dump_cached_states): Likewise.
7509
7510 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7511 shadowing.
7512 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7513 Include <limits.h>.
7514 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7515 and to avoid gcc -Wuninitialized warning.
7516 (load_charset_map): Mark variables that gcc -Wuninitialized
7517 does not deduce are never used uninitialized.
7518 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7519
7520 * coding.c (coding_set_source, coding_set_destination):
7521 Use "else { /* comment */ }" rather than "else /* comment */;"
7522 for clarity, and to avoid gcc -Wempty-body warning.
7523 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7524 a block, when the outer 'i' will do.
7525 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7526 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7527 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7528 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7529 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7530 Rename locals to avoid shadowing.
7531 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7532 * coding.c (emacs_mule_char, encode_invocation_designation):
7533 Now static, since they're not used elsewhere.
7534 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7535 (decode_coding_object, encode_coding_object, detect_coding_system):
7536 (decode_coding_emacs_mule): Mark variables that gcc
7537 -Wuninitialized does not deduce are never used uninitialized.
7538 (detect_coding_iso_2022): Initialize a local variable that might
7539 be used uninitialized. Leave a FIXME because it's not clear that
7540 this initialization is needed. (Bug#8211)
7541 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7542 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7543 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7544 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7545 Remove unused macros.
7546
7547 * category.c (hash_get_category_set): Remove unused local var.
7548 (copy_category_table): Now static, since it's not used elsewhere.
7549 * character.c (string_count_byte8): Likewise.
7550
7551 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7552 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7553
7554 * chartab.c (copy_sub_char_table): Now static, since it's not used
7555 elsewhere.
7556 (sub_char_table_ref_and_range, char_table_ref_and_range):
7557 Rename locals to avoid shadowing.
7558 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7559
7560 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7561 (BIDI_BOB): Remove unused macro.
7562
7563 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7564 deduce are never used uninitialized.
7565 * term.c (encode_terminal_code): Likewise.
7566
7567 * term.c (encode_terminal_code): Now static. Remove unused local.
7568
7569 * tparam.h: New file.
7570 * term.c, tparam.h: Include it.
7571 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7572 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7573 Move these decls to tparam.h, and make them agree with what
7574 is actually in tparam.c. The previous trick of using incompatible
7575 decls in different modules does not conform to the C standard.
7576 All callers of tparam changed to use tparam's actual API.
7577 * tparam.c (tparam1, tparam, tgoto):
7578 Use const pointers where appropriate.
7579
7580 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7581 * cm.h (struct cm): Likewise.
7582 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7583 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7584 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7585 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7586 (turn_on_face, init_tty): Likewise.
7587 * termchar.h (struct tty_display_info): Likewise.
7588
7589 * term.c (term_mouse_position): Rename local to avoid shadowing.
7590
7591 * alloc.c (mark_ttys): Move decl from here ...
7592 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7593
7594 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7595
7596 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7597
7598 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7599
7600 * search.c (compile_pattern_1): Remove argument regp, unused since
7601 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7602 (compile_pattern): Don't pass it.
7603
7604 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7605
7606 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7607 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7608 for ! HAVE_GTK3.
7609 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7610
7611 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7612
7613 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7614 gdk_window_get_screen, gdk_window_get_geometry,
7615 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7616 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7617 (xg_get_pixbuf_from_pixmap): New function.
7618 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7619 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7620 Call xg_get_pixbuf_from_pixmap instead of
7621 gdk_pixbuf_get_from_drawable.
7622 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7623 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7624 (xg_check_special_colors): Use GtkStyleContext and its functions
7625 for HAVE_GTK3.
7626 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7627 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7628 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7629 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7630 Call gtk_widget_get_preferred_size.
7631 (xg_frame_resized): gdk_window_get_geometry only takes 5
7632 parameters.
7633 (xg_win_to_widget, xg_event_is_for_menubar):
7634 Call gdk_x11_window_lookup_for_display.
7635 (xg_set_widget_bg): New function.
7636 (delete_cb): New function.
7637 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7638 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7639 (xg_set_background_color): Call xg_set_widget_bg.
7640 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7641 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7642 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7643 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7644 if ! HAVE_GTK3.
7645 (update_frame_tool_bar): Call gtk_widget_hide.
7646 (xg_initialize): Use GDK_KEY_g.
7647
7648 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7649 if ! HAVE_GTK3
7650 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7651
7652 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7653 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7654 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7655
7656 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7657
7658 * w32xfns.c (select_palette): Check success of RealizePalette against
7659 GDI_ERROR, not zero.
7660
7661 See ChangeLog.11 for earlier changes.
7662
7663 ;; Local Variables:
7664 ;; coding: utf-8
7665 ;; End:
7666
7667 Copyright (C) 2011 Free Software Foundation, Inc.
7668
7669 This file is part of GNU Emacs.
7670
7671 GNU Emacs is free software: you can redistribute it and/or modify
7672 it under the terms of the GNU General Public License as published by
7673 the Free Software Foundation, either version 3 of the License, or
7674 (at your option) any later version.
7675
7676 GNU Emacs is distributed in the hope that it will be useful,
7677 but WITHOUT ANY WARRANTY; without even the implied warranty of
7678 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7679 GNU General Public License for more details.
7680
7681 You should have received a copy of the GNU General Public License
7682 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.