]> code.delx.au - gnu-emacs/commitdiff
Port recent xdisp.c fix to picky C compilers
authorPaul Eggert <eggert@cs.ucla.edu>
Fri, 22 Jan 2016 23:27:55 +0000 (15:27 -0800)
committerPaul Eggert <eggert@cs.ucla.edu>
Fri, 22 Jan 2016 23:28:34 +0000 (15:28 -0800)
* src/xdisp.c (dump_glyph): Redo the call to fprintf to avoid
putting #if inside the arguments to a standard function, which
the C standard says has undefined behavior.

src/xdisp.c

index 157fa729fcfe3b12ce2ecaaecd46217dbcade661..5185e77732407c059d68f4a84c7d2ed8beb48ccd 100644 (file)
@@ -18827,12 +18827,11 @@ dump_glyph (struct glyph_row *row, struct glyph *glyph, int area)
     }
   else if (glyph->type == XWIDGET_GLYPH)
     {
+#ifndef HAVE_XWIDGETS
+      eassume (false);
+#else
       fprintf (stderr,
-#ifdef HAVE_XWIDGETS
               "  %5d %4c %6d %c %3d 0x%05x %c %4d %1.1d%1.1d\n",
-#else
-              "  %5d %4c %6d %c %3d %c %4d %1.1d%1.1d\n",
-#endif
               glyph - row->glyphs[TEXT_AREA],
               'X',
               glyph->charpos,
@@ -18842,14 +18841,12 @@ dump_glyph (struct glyph_row *row, struct glyph *glyph, int area)
                   ? 'S'
                   : '-')),
               glyph->pixel_width,
-#ifdef HAVE_XWIDGETS
               glyph->u.xwidget,
-#endif
               '.',
               glyph->face_id,
               glyph->left_box_line_p,
               glyph->right_box_line_p);
-
+#endif
     }
 }