]> code.delx.au - pulseaudio/commit
equalizer: Don't cleanup u->sink in sink_input_kill_cb yet
authorMatthijs Kooijman <matthijs@stdin.nl>
Mon, 24 Sep 2012 12:40:06 +0000 (14:40 +0200)
committerTanu Kaskinen <tanuk@iki.fi>
Tue, 25 Sep 2012 17:39:15 +0000 (20:39 +0300)
commit3d2d30f68802a76b09e9c90ffa2f2960bdde76e0
tree61ae8e7fe181e2b517fa1e161d0ec68d2dd9dc31
parent626085ed9caa21b5d835f7d92123ce4e6dd7105f
equalizer: Don't cleanup u->sink in sink_input_kill_cb yet

Previously, sink_input_kill_cb would cleanup u->sink an then unload the
module. However, during module unload, both save_state and dbus_done
tried to use u->sink, causing a segfault or assertion failure.

The segfault is easy to reproduce: Load module-equalizer-sink and then
press ctrl-C to terminate pulseaudio.

This commit removes the u->sink cleanup in sink_input_kill_cb, since
u->sink will be cleaned up by the module's pa__done as well (after it
has been used).

Signed-off-by: Matthijs Kooijman <matthijs@stdin.nl>
src/modules/module-equalizer-sink.c