]> code.delx.au - pulseaudio/commit
bluetooth: Don't free read_smoother in pa__done().
authorTanu Kaskinen <tanu.kaskinen@digia.com>
Thu, 22 Mar 2012 10:23:13 +0000 (12:23 +0200)
committerTanu Kaskinen <tanuk@iki.fi>
Wed, 19 Dec 2012 10:31:49 +0000 (12:31 +0200)
commit9f832ca565f1c73d0bfec389314f1ece9d2b4424
treef020c381feab13d8045c5ea302f6652422de1357
parentf36148a82e99b40a0adebfdf10c83e480b484847
bluetooth: Don't free read_smoother in pa__done().

pa__done() calls stop_thread(), and stop_thread() already
frees the smoother. The duplicate freeing is not strictly
a bug, but static analyzers (in this case Coverity) may
complain about double-freeing, because when pa__done()
"frees" the smoother (which doesn't actually ever happen),
the pointer is not nulled. pa__done() then calls
bt_transport_release(), which will also free the smoother
if it's not NULL.

The analyzer complaint could be silenced also by nulling
the pointer in pa__done(), but since this is clearly
redundant code, I chose to remove it.
src/modules/bluetooth/module-bluetooth-device.c