module-equalizer-sink: reverted buffering logic back to how the ladspa sink did it

[pulseaudio] / src / modules / module-equalizer-sink.c

/***
This file is part of PulseAudio.

This module is based off Lennart Poettering's LADSPA sink and swaps out
LADSPA functionality for a STFT OLA based digital equalizer.  All new work
is published under Pulseaudio's original license.
Copyright 2009 Jason Newton <nevion@gmail.com>

Original Author:
Copyright 2004-2008 Lennart Poettering

PulseAudio is free software; you can redistribute it and/or modify
it under the terms of the GNU Lesser General Public License as published
by the Free Software Foundation; either version 2.1 of the License,
or (at your option) any later version.

PulseAudio is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
General Public License for more details.

You should have received a copy of the GNU Lesser General Public License
along with PulseAudio; if not, write to the Free Software
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
USA.
***/

#ifdef HAVE_CONFIG_H
#include <config.h>
#endif

#include <stdlib.h>
#include <stdio.h>
#include <float.h>
#include <math.h>
#include <fftw3.h>
#include <string.h>

#include <pulse/xmalloc.h>
#include <pulse/i18n.h>

#include <pulsecore/core-error.h>
#include <pulsecore/namereg.h>
#include <pulsecore/sink.h>
#include <pulsecore/module.h>
#include <pulsecore/core-util.h>
#include <pulsecore/modargs.h>
#include <pulsecore/log.h>
#include <pulsecore/thread.h>
#include <pulsecore/thread-mq.h>
#include <pulsecore/rtpoll.h>
#include <pulsecore/sample-util.h>
#include <pulsecore/shared.h>
#include <pulsecore/idxset.h>
#include <pulsecore/database.h>
#include <pulsecore/protocol-dbus.h>
#include <pulsecore/dbus-util.h>

#include <stdint.h>
#include <time.h>


//#undef __SSE2__
#ifdef __SSE2__
#include <xmmintrin.h>
#include <emmintrin.h>
#endif



#include "module-equalizer-sink-symdef.h"

PA_MODULE_AUTHOR("Jason Newton");
PA_MODULE_DESCRIPTION(_("General Purpose Equalizer"));
PA_MODULE_VERSION(PACKAGE_VERSION);
PA_MODULE_LOAD_ONCE(FALSE);
PA_MODULE_USAGE(_("sink=<sink to connect to> "));

#define MEMBLOCKQ_MAXLENGTH (16*1024*1024)


struct userdata {
    pa_core *core;
    pa_module *module;
    pa_sink *sink, *master;
    pa_sink_input *sink_input;
    char *name;

    size_t channels;
    size_t fft_size;//length (res) of fft
    size_t window_size;/*
                        *sliding window size
                        *effectively chooses R
                        */
    size_t R;/* the hop size between overlapping windows
              * the latency of the filter, calculated from window_size
              * based on constraints of COLA and window function
              */
    size_t latency;//Really just R but made into it's own variable
    //for twiddling with pulseaudio
    size_t overlap_size;//window_size-R
    size_t samples_gathered;
    size_t max_output;//max amount of samples outputable in a single
    //message
    size_t target_samples;
    float *H;//frequency response filter (magnitude based)
    float *W;//windowing function (time domain)
    float *work_buffer, **input, **overlap_accum;
    fftwf_complex *output_window;
    fftwf_plan forward_plan, inverse_plan;
    //size_t samplings;

    float *Hs[2];//thread updatable copies
    pa_aupdate *a_H;
    pa_memchunk conv_buffer;
    pa_memblockq *input_q;

    pa_dbus_protocol *dbus_protocol;
    char *dbus_path;

    pa_database *database;
};

static const char* const valid_modargs[] = {
    "sink_name",
    "sink_properties",
    "master",
    "format",
    "rate",
    "channels",
    "channel_map",
    NULL
};

static uint64_t time_diff(struct timespec *timeA_p, struct timespec *timeB_p);
static void hanning_window(float *W, size_t window_size);
void fix_filter(float *H, size_t fft_size);
void interpolate(float *signal, size_t length, uint32_t *xs, float *ys, size_t n_points);
static void array_out(const char *name, float *a, size_t length);
static int is_monotonic(uint32_t *xs, size_t length);
static void process_samples(struct userdata *u, pa_memchunk *tchunk);
static void input_buffer(struct userdata *u, pa_memchunk *in);
static void save_profile(struct userdata *u,char *name);
static void save_state(struct userdata *u);
static void remove_profile(pa_core *u,char *name);
static const char * load_profile(struct userdata *u,char *name);
static void load_state(struct userdata *u);

void dsp_logic(
    float * __restrict__ dst,
    float * __restrict__ src,
    float * __restrict__ overlap,
    const float * __restrict__ H,
    const float * __restrict__ W,
    fftwf_complex * __restrict__ output_window,
    struct userdata *u);


/*
 * DBus Routines and Callbacks
 */
#define EXTNAME "org.PulseAudio.Ext.Equalizing1"
#define MANAGER_PATH "/org/pulseaudio/equalizing1"
static void dbus_init(struct userdata *u);
static void dbus_done(struct userdata *u);
static void manager_get_revision(DBusConnection *conn, DBusMessage *msg, void *_u);
static void manager_get_sinks(DBusConnection *conn, DBusMessage *msg, void *_u);
static void manager_get_profiles(DBusConnection *conn, DBusMessage *msg, void *_u);
static void manager_get_all(DBusConnection *conn, DBusMessage *msg, void *_u);
static void manager_handle_remove_profile(DBusConnection *conn, DBusMessage *msg, void *_u);
static void equalizer_get_revision(DBusConnection *conn, DBusMessage *msg, void *_u);
static void equalizer_get_sample_rate(DBusConnection *conn, DBusMessage *msg, void *_u);
static void equalizer_get_filter_rate(DBusConnection *conn, DBusMessage *msg, void *_u);
static void equalizer_get_n_coefs(DBusConnection *conn, DBusMessage *msg, void *_u);
static void equalizer_get_filter(DBusConnection *conn, DBusMessage *msg, void *_u);
static void equalizer_get_all(DBusConnection *conn, DBusMessage *msg, void *_u);
static void equalizer_set_filter(DBusConnection *conn, DBusMessage *msg, void *_u);
static void equalizer_handle_seed_filter(DBusConnection *conn, DBusMessage *msg, void *_u);
static void equalizer_handle_get_filter_points(DBusConnection *conn, DBusMessage *msg, void *_u);
static void equalizer_handle_save_profile(DBusConnection *conn, DBusMessage *msg, void *_u);
static void equalizer_handle_load_profile(DBusConnection *conn, DBusMessage *msg, void *_u);

#define v_size 4
#define gettime(x) clock_gettime(CLOCK_MONOTONIC, &x)
#define tdiff(x, y) time_diff(&x, &y)
#define mround(x, y) (x % y == 0 ? x : ( x / y + 1) * y)
#define SINKLIST "equalized_sinklist"
#define EQDB "equalizer_db"

uint64_t time_diff(struct timespec *timeA_p, struct timespec *timeB_p)
{
    return ((timeA_p->tv_sec * 1000000000ULL) + timeA_p->tv_nsec) -
    ((timeB_p->tv_sec * 1000000000ULL) + timeB_p->tv_nsec);
}

void hanning_window(float *W, size_t window_size){
    //h=.5*(1-cos(2*pi*j/(window_size+1)), COLA for R=(M+1)/2
    for(size_t i=0; i < window_size;++i){
        W[i] = (float).5*(1-cos(2*M_PI*i/(window_size+1)));
    }
}

void fix_filter(float *H, size_t fft_size){
    //divide out the fft gain
    for(size_t i = 0; i < fft_size / 2 + 1; ++i){
        H[i] /= fft_size;
    }
}

void interpolate(float *signal, size_t length, uint32_t *xs, float *ys, size_t n_points){
    //Note that xs must be monotonically increasing!
    pa_assert_se(n_points>=2);
    pa_assert_se(xs[0] == 0);
    pa_assert_se(xs[n_points - 1] == length - 1);
    for(size_t x = 0, x_range_lower_i = 0; x < length-1; ++x){
        pa_assert(x_range_lower_i < n_points-1);
        float x_range_lower = (float) (xs[x_range_lower_i]);
        float x_range_upper = (float) (xs[x_range_lower_i+1]);
        pa_assert_se(x_range_lower < x_range_upper);
        pa_assert_se(x >= x_range_lower);
        pa_assert_se(x <= x_range_upper);
        //bilinear-interpolation of coefficients specified
        float c0 = (x-x_range_lower)/(x_range_upper-x_range_lower);
        pa_assert_se(c0 >= 0&&c0 <= 1.0);
        signal[x] = ((1.0f - c0) * ys[x_range_lower_i] + c0 * ys[x_range_lower_i + 1]);
        while(x >= xs[x_range_lower_i + 1]){
            x_range_lower_i++;
        }
    }
    signal[length-1]=ys[n_points-1];
}

void array_out(const char *name, float *a, size_t length){
    FILE *p=fopen(name, "w");
    if(!p){
        pa_log("opening %s failed!", name);
        return;
    }
    for(size_t i = 0; i < length; ++i){
        fprintf(p, "%e,", a[i]);
        //if(i%1000==0){
        //    fprintf(p, "\n");
        //}
    }
    fprintf(p, "\n");
    fclose(p);
}
static int is_monotonic(uint32_t *xs,size_t length){
    if(length<2){
        return 1;
    }
    for(size_t i = 1; i < length; ++i){
        if(xs[i]<=xs[i-1]){
            return 0;
        }
    }
    return 1;
}


/* Called from I/O thread context */
static int sink_process_msg(pa_msgobject *o, int code, void *data, int64_t offset, pa_memchunk *chunk) {
    struct userdata *u = PA_SINK(o)->userdata;

    switch (code) {

        case PA_SINK_MESSAGE_GET_LATENCY: {
            pa_usec_t usec = 0;
            pa_sample_spec *ss=&u->sink->sample_spec;
            //size_t fs=pa_frame_size(&(u->sink->sample_spec));

            /* Get the latency of the master sink */
            if (PA_MSGOBJECT(u->master)->process_msg(PA_MSGOBJECT(u->master), PA_SINK_MESSAGE_GET_LATENCY, &usec, 0, NULL) < 0)
                usec = 0;

            //usec += pa_bytes_to_usec(u->latency * fs, ss);
            //usec += pa_bytes_to_usec(u->samples_gathered * fs, ss);
            usec += pa_bytes_to_usec(pa_memblockq_get_length(u->input_q), ss);
            /* Add the latency internal to our sink input on top */
            usec += pa_bytes_to_usec(pa_memblockq_get_length(u->sink_input->thread_info.render_memblockq), &u->master->sample_spec);
            *((pa_usec_t*) data) = usec;
            return 0;
        }
    }

    return pa_sink_process_msg(o, code, data, offset, chunk);
}


/* Called from main context */
static int sink_set_state(pa_sink *s, pa_sink_state_t state) {
    struct userdata *u;

    pa_sink_assert_ref(s);
    pa_assert_se(u = s->userdata);

    if (PA_SINK_IS_LINKED(state) &&
        u->sink_input &&
        PA_SINK_INPUT_IS_LINKED(pa_sink_input_get_state(u->sink_input)))

        pa_sink_input_cork(u->sink_input, state == PA_SINK_SUSPENDED);

    return 0;
}

/* Called from I/O thread context */
static void sink_request_rewind(pa_sink *s) {
    struct userdata *u;

    pa_sink_assert_ref(s);
    pa_assert_se(u = s->userdata);

    //pa_memblockq_drop(u->input_q,pa_memblockq_get_length(u->input_q));

    /* Just hand this one over to the master sink */
    pa_sink_input_request_rewind(u->sink_input, s->thread_info.rewind_nbytes+pa_memblockq_get_length(u->input_q), TRUE, FALSE, FALSE);
}

/* Called from I/O thread context */
static void sink_update_requested_latency(pa_sink *s) {
    struct userdata *u;

    pa_sink_assert_ref(s);
    pa_assert_se(u = s->userdata);

    /* Just hand this one over to the master sink */
    pa_sink_input_set_requested_latency_within_thread(
            u->sink_input,
            pa_sink_get_requested_latency_within_thread(s));
}

static void process_samples(struct userdata *u, pa_memchunk *tchunk){
    size_t fs=pa_frame_size(&(u->sink->sample_spec));
    pa_assert(u->samples_gathered >= u->R);
    float *dst;
    tchunk->index=0;
    tchunk->length=u->R*fs;
    tchunk->memblock=pa_memblock_new(u->core->mempool, tchunk->length);
    dst=((float*)pa_memblock_acquire(tchunk->memblock));
    for(size_t c=0;c < u->channels; c++) {
        dsp_logic(
            u->work_buffer,
            u->input[c],
            u->overlap_accum[c],
            u->H,
            u->W,
            u->output_window,
            u
        );
        pa_sample_clamp(PA_SAMPLE_FLOAT32NE, dst + c, fs, u->work_buffer, sizeof(float), u->R);
    }
    pa_memblock_release(tchunk->memblock);
    u->samples_gathered-=u->R;
}

typedef float v4sf __attribute__ ((__aligned__(v_size*sizeof(float))));
typedef union float_vector {
    float f[v_size];
    v4sf v;
#ifdef __SSE2__
    __m128 m;
#endif
} float_vector_t;

//reference implementation
void dsp_logic(
    float * __restrict__ dst,//used as a temp array too, needs to be fft_length!
    float * __restrict__ src,/*input data w/ overlap at start,
                               *automatically cycled in routine
                               */
    float * __restrict__ overlap,//The size of the overlap
    const float * __restrict__ H,//The freq. magnitude scalers filter
    const float * __restrict__ W,//The windowing function
    fftwf_complex * __restrict__ output_window,//The transformed window'd src
    struct userdata *u){
    //use a linear-phase sliding STFT and overlap-add method (for each channel)
    //zero padd the data
    memset(dst + u->window_size, 0, (u->fft_size - u->window_size) * sizeof(float));
    //window the data
    for(size_t j = 0;j < u->window_size; ++j){
        dst[j] = W[j] * src[j];
    }
    //Processing is done here!
    //do fft
    fftwf_execute_dft_r2c(u->forward_plan, dst, output_window);
    //perform filtering
    for(size_t j = 0; j < u->fft_size / 2 + 1; ++j){
        u->output_window[j][0] *= u->H[j];
        u->output_window[j][1] *= u->H[j];
    }
    //inverse fft
    fftwf_execute_dft_c2r(u->inverse_plan, output_window, dst);
    ////debug: tests overlaping add
    ////and negates ALL PREVIOUS processing
    ////yields a perfect reconstruction if COLA is held
    //for(size_t j = 0; j < u->window_size; ++j){
    //    u->work_buffer[j] = u->W[j] * u->input[c][j];
    //}

    //overlap add and preserve overlap component from this window (linear phase)
    for(size_t j = 0;j < u->overlap_size; ++j){
        u->work_buffer[j] += overlap[j];
        overlap[j] = dst[u->R+j];
    }
    ////debug: tests if basic buffering works
    ////shouldn't modify the signal AT ALL (beyond roundoff)
    //for(size_t j = 0; j < u->window_size;++j){
    //    u->work_buffer[j] = u->input[c][j];
    //}

    //preseve the needed input for the next window's overlap
    memmove(src, src+u->R,
        ((u->overlap_size + u->samples_gathered) - u->R)*sizeof(float)
    );
}

////regardless of sse enabled, the loops in here assume
////16 byte aligned addresses and memory allocations divisible by v_size
//void dsp_logic(
//    float * __restrict__ dst,//used as a temp array too, needs to be fft_length!
//    float * __restrict__ src,/*input data w/ overlap at start,
//                               *automatically cycled in routine
//                               */
//    float * __restrict__ overlap,//The size of the overlap
//    const float * __restrict__ H,//The freq. magnitude scalers filter
//    const float * __restrict__ W,//The windowing function
//    fftwf_complex * __restrict__ output_window,//The transformed window'd src
//    struct userdata *u){//Collection of constants
//
//    const size_t window_size = mround(u->window_size,v_size);
//    const size_t fft_h = mround(u->fft_size / 2 + 1, v_size / 2);
//    //const size_t R = mround(u->R, v_size);
//    const size_t overlap_size = mround(u->overlap_size, v_size);
//
//    //assert(u->samples_gathered >= u->R);
//    //zero out the bit beyond the real overlap so we don't add garbage
//    for(size_t j = overlap_size; j > u->overlap_size; --j){
//       overlap[j-1] = 0;
//    }
//    //use a linear-phase sliding STFT and overlap-add method
//    //zero padd the data
//    memset(dst + u->window_size, 0, (u->fft_size - u->window_size)*sizeof(float));
//    //window the data
//    for(size_t j = 0; j < window_size; j += v_size){
//        //dst[j] = W[j]*src[j];
//        float_vector_t *d = (float_vector_t*) (dst+j);
//        float_vector_t *w = (float_vector_t*) (W+j);
//        float_vector_t *s = (float_vector_t*) (src+j);
//#if __SSE2__
//        d->m = _mm_mul_ps(w->m, s->m);
//#else
//        d->v = w->v * s->v;
//#endif
//    }
//    //Processing is done here!
//    //do fft
//    fftwf_execute_dft_r2c(u->forward_plan, dst, output_window);
//
//
//    //perform filtering - purely magnitude based
//    for(size_t j = 0;j < fft_h; j+=v_size/2){
//        //output_window[j][0]*=H[j];
//        //output_window[j][1]*=H[j];
//        float_vector_t *d = (float_vector_t*)(output_window+j);
//        float_vector_t h;
//        h.f[0] = h.f[1] = H[j];
//        h.f[2] = h.f[3] = H[j+1];
//#if __SSE2__
//        d->m = _mm_mul_ps(d->m, h.m);
//#else
//        d->v = d->v*h->v;
//#endif
//    }
//
//
//    //inverse fft
//    fftwf_execute_dft_c2r(u->inverse_plan, output_window, dst);
//
//    ////debug: tests overlaping add
//    ////and negates ALL PREVIOUS processing
//    ////yields a perfect reconstruction if COLA is held
//    //for(size_t j = 0; j < u->window_size; ++j){
//    //    dst[j] = W[j]*src[j];
//    //}
//
//    //overlap add and preserve overlap component from this window (linear phase)
//    for(size_t j = 0; j < overlap_size; j+=v_size){
//        //dst[j]+=overlap[j];
//        //overlap[j]+=dst[j+R];
//        float_vector_t *d = (float_vector_t*)(dst+j);
//        float_vector_t *o = (float_vector_t*)(overlap+j);
//#if __SSE2__
//        d->m = _mm_add_ps(d->m, o->m);
//        o->m = ((float_vector_t*)(dst+u->R+j))->m;
//#else
//        d->v = d->v+o->v;
//        o->v = ((float_vector_t*)(dst+u->R+j))->v;
//#endif
//    }
//    //memcpy(overlap, dst+u->R, u->overlap_size*sizeof(float));
//
//    //////debug: tests if basic buffering works
//    //////shouldn't modify the signal AT ALL (beyond roundoff)
//    //for(size_t j = 0; j < u->window_size; ++j){
//    //    dst[j] = src[j];
//    //}
//
//    //preseve the needed input for the next window's overlap
//    memmove(src, src+u->R,
//        ((u->overlap_size+u->samples_gathered)+-u->R)*sizeof(float)
//    );
//}



void input_buffer(struct userdata *u, pa_memchunk *in){
    size_t fs = pa_frame_size(&(u->sink->sample_spec));
    size_t samples = in->length/fs;
    pa_assert_se(samples <= u->target_samples-u->samples_gathered);
    float *src = (float*) ((uint8_t*) pa_memblock_acquire(in->memblock) + in->index);
    for(size_t c = 0; c < u->channels; c++) {
        //buffer with an offset after the overlap from previous
        //iterations
        pa_assert_se(
            u->input[c]+u->overlap_size+u->samples_gathered+samples <= u->input[c]+u->overlap_size+u->target_samples
        );
        pa_sample_clamp(PA_SAMPLE_FLOAT32NE, u->input[c]+u->overlap_size+u->samples_gathered, sizeof(float), src + c, fs, samples);
    }
    u->samples_gathered+=samples;
    pa_memblock_release(in->memblock);
}

/* Called from I/O thread context */
static int sink_input_pop_cb(pa_sink_input *i, size_t nbytes, pa_memchunk *chunk) {
    struct userdata *u;
    pa_sink_input_assert_ref(i);
    pa_assert(chunk);
    pa_assert(u = i->userdata);
    pa_assert(u->sink);
    size_t fs = pa_frame_size(&(u->sink->sample_spec));
    pa_memchunk tchunk;
    chunk->memblock = NULL;
    if (!u->sink || !PA_SINK_IS_OPENED(u->sink->thread_info.state))
        return -1;

    /* Hmm, process any rewind request that might be queued up */
    pa_sink_process_rewind(u->sink, 0);

    //pa_log("start output-buffered %ld, input-buffered %ld, requested %ld",buffered_samples,u->samples_gathered,samples_requested);
    struct timespec start, end;

    do{
        size_t input_remaining = u->target_samples-u->samples_gathered;
        pa_assert(input_remaining>0);
        //collect samples

        //buffer = &u->conv_buffer;
        //buffer->length = input_remaining*fs;
        //buffer->index = 0;
        //pa_memblock_ref(buffer->memblock);
        //pa_sink_render_into(u->sink, buffer);
        while(pa_memblockq_peek(u->input_q, &tchunk) < 0){
            pa_sink_render(u->sink, input_remaining*fs, &tchunk);
            pa_memblockq_push(u->input_q, &tchunk);
            pa_memblock_unref(tchunk.memblock);
        }
        tchunk.length = PA_MIN(input_remaining*fs, tchunk.length);
        pa_memblockq_drop(u->input_q,tchunk.length);
        //pa_log("asked for %ld input samples, got %ld samples",input_remaining,buffer->length/fs);
        /* copy new input */
        gettime(start);
        input_buffer(u, &tchunk);
        gettime(end);
        //pa_log("Took %0.5f seconds to setup", tdiff(end, start)*1e-9);
        pa_memblock_unref(tchunk.memblock);
    }while(u->samples_gathered < u->R);

    pa_assert(u->fft_size >= u->window_size);
    pa_assert(u->R < u->window_size);
    /* set the H filter */
    unsigned H_i = pa_aupdate_read_begin(u->a_H);
    u->H = u->Hs[H_i];
    gettime(start);
    /* process a block */
    process_samples(u,chunk);
    gettime(end);
    //pa_log("Took %0.5f seconds to process", tdiff(end, start)*1e-9);
    pa_aupdate_read_end(u->a_H);

    pa_assert(chunk->memblock);
    //pa_log("gave %ld", chunk->length/fs);
    //pa_log("end pop");
    return 0;
}

/* Called from I/O thread context */
static void sink_input_process_rewind_cb(pa_sink_input *i, size_t nbytes) {
    struct userdata *u;
    size_t amount = 0;

    pa_log_debug("Rewind callback!");
    pa_sink_input_assert_ref(i);
    pa_assert_se(u = i->userdata);

    if (!u->sink || !PA_SINK_IS_OPENED(u->sink->thread_info.state))
        return;

    if (u->sink->thread_info.rewind_nbytes > 0) {
        size_t max_rewrite;

        //max_rewrite = nbytes;
        max_rewrite = nbytes + pa_memblockq_get_length(u->input_q);
        //PA_MIN(pa_memblockq_get_length(u->input_q), nbytes);
        amount = PA_MIN(u->sink->thread_info.rewind_nbytes, max_rewrite);
        u->sink->thread_info.rewind_nbytes = 0;

        if (amount > 0) {
            //pa_sample_spec *ss = &u->sink->sample_spec;
            //invalidate the output q
            pa_memblockq_seek(u->input_q, - (int64_t) amount, PA_SEEK_RELATIVE, TRUE);
            //pa_memblockq_drop(u->input_q, pa_memblockq_get_length(u->input_q));
            //pa_memblockq_seek(u->input_q, - (int64_t) amount, PA_SEEK_RELATIVE, TRUE);
            pa_log_debug("Resetting equalizer");
            u->samples_gathered = 0;
        }
    }

    pa_sink_process_rewind(u->sink, amount);
    pa_memblockq_rewind(u->input_q, nbytes);
}

/* Called from I/O thread context */
static void sink_input_update_max_rewind_cb(pa_sink_input *i, size_t nbytes) {
    struct userdata *u;

    pa_sink_input_assert_ref(i);
    pa_assert_se(u = i->userdata);

    if (!u->sink || !PA_SINK_IS_LINKED(u->sink->thread_info.state))
        return;

    pa_memblockq_set_maxrewind(u->input_q, nbytes);
    pa_sink_set_max_rewind_within_thread(u->sink, nbytes);
}

/* Called from I/O thread context */
static void sink_input_update_max_request_cb(pa_sink_input *i, size_t nbytes) {
    struct userdata *u;

    pa_sink_input_assert_ref(i);
    pa_assert_se(u = i->userdata);

    if (!u->sink || !PA_SINK_IS_LINKED(u->sink->thread_info.state))
        return;

    size_t fs = pa_frame_size(&(u->sink->sample_spec));
    //pa_sink_set_max_request_within_thread(u->sink, nbytes);
    //pa_sink_set_max_request_within_thread(u->sink, u->R*fs);
    pa_sink_set_max_request_within_thread(u->sink, ((nbytes+u->R*fs-1)/(u->R*fs))*(u->R*fs));
}

/* Called from I/O thread context */
static void sink_input_update_sink_latency_range_cb(pa_sink_input *i) {
    struct userdata *u;

    pa_sink_input_assert_ref(i);
    pa_assert_se(u = i->userdata);

    if (!u->sink || !PA_SINK_IS_LINKED(u->sink->thread_info.state))
        return;

    //pa_sink_set_latency_range_within_thread(u->sink, u->master->thread_info.min_latency, u->latency*fs);
    //pa_sink_set_latency_range_within_thread(u->sink, u->latency*fs, u->latency*fs );
    pa_sink_set_latency_range_within_thread(u->sink, i->sink->thread_info.min_latency, i->sink->thread_info.max_latency);
}

/* Called from I/O thread context */
static void sink_input_detach_cb(pa_sink_input *i) {
    struct userdata *u;

    pa_sink_input_assert_ref(i);
    pa_assert_se(u = i->userdata);

    if (!u->sink || !PA_SINK_IS_LINKED(u->sink->thread_info.state))
        return;

    pa_sink_detach_within_thread(u->sink);
    pa_sink_set_asyncmsgq(u->sink, NULL);
    pa_sink_set_rtpoll(u->sink, NULL);
}

/* Called from I/O thread context */
static void sink_input_attach_cb(pa_sink_input *i) {
    struct userdata *u;

    pa_sink_input_assert_ref(i);
    pa_assert_se(u = i->userdata);

    if (!u->sink || !PA_SINK_IS_LINKED(u->sink->thread_info.state))
        return;

    pa_sink_set_asyncmsgq(u->sink, i->sink->asyncmsgq);
    pa_sink_set_rtpoll(u->sink, i->sink->rtpoll);
    pa_sink_attach_within_thread(u->sink);

    //size_t fs = pa_frame_size(&(u->sink->sample_spec));
    //pa_sink_set_latency_range_within_thread(u->sink, u->latency*fs, u->latency*fs);
    //pa_sink_set_latency_range_within_thread(u->sink, u->latency*fs, u->master->thread_info.max_latency);
    //TODO: setting this guy minimizes drop outs but doesn't get rid
    //of them completely, figure out why
    //pa_sink_set_latency_range_within_thread(u->sink, u->master->thread_info.min_latency, u->latency*fs);
    //TODO: this guy causes dropouts constantly+rewinds, it's unusable
    pa_sink_set_latency_range_within_thread(u->sink, u->master->thread_info.min_latency, u->master->thread_info.max_latency);
}

/* Called from main context */
static void sink_input_kill_cb(pa_sink_input *i) {
    struct userdata *u;

    pa_sink_input_assert_ref(i);
    pa_assert_se(u = i->userdata);

    pa_sink_unlink(u->sink);
    pa_sink_input_unlink(u->sink_input);

    pa_sink_unref(u->sink);
    u->sink = NULL;
    pa_sink_input_unref(u->sink_input);
    u->sink_input = NULL;

    pa_module_unload_request(u->module, TRUE);
}

/* Called from IO thread context */
static void sink_input_state_change_cb(pa_sink_input *i, pa_sink_input_state_t state) {
    struct userdata *u;

    pa_sink_input_assert_ref(i);
    pa_assert_se(u = i->userdata);

    /* If we are added for the first time, ask for a rewinding so that
     * we are heard right-away. */
    if (PA_SINK_INPUT_IS_LINKED(state) &&
        i->thread_info.state == PA_SINK_INPUT_INIT) {
        pa_log_debug("Requesting rewind due to state change.");
        pa_sink_input_request_rewind(i, 0, FALSE, TRUE, TRUE);
    }
}

void save_profile(struct userdata *u, char *name){
    float *H_n = pa_xmalloc((u->fft_size / 2 + 1) * sizeof(float));
    const float *H = u->Hs[pa_aupdate_read_begin(u->a_H)];
    for(size_t i = 0 ; i <= u->fft_size / 2 + 1; ++i){
        //H_n[i] = H[i] * u->fft_size;
        H_n[i] = H[i];
    }
    pa_aupdate_read_end(u->a_H);
    pa_datum key, data;
    key.data=name;
    key.size = strlen(key.data);
    data.data = H_n;
    data.size = (u->fft_size / 2 + 1) * sizeof(float);
    pa_database_set(u->database, &key, &data, TRUE);
    pa_database_sync(u->database);
}

void save_state(struct userdata *u){
    char *state_name = pa_sprintf_malloc("%s-previous-state", u->name);
    save_profile(u, state_name);
    pa_xfree(state_name);
}

void remove_profile(pa_core *c,char *name){
    pa_datum key;
    key.data = name;
    key.size = strlen(key.data);
    pa_database *database;
    pa_assert_se(database = pa_shared_get(c,EQDB));
    pa_database_unset(database,&key);
    pa_database_sync(database);
}

const char* load_profile(struct userdata *u,char *name){
    pa_datum key,value;
    key.data = name;
    key.size = strlen(key.data);
    if(pa_database_get(u->database, &key, &value) != NULL){
        if(value.size == (u->fft_size / 2 + 1) * sizeof(float)){
            float *H=u->Hs[pa_aupdate_write_begin(u->a_H)];
            memcpy(H, value.data, value.size);
            pa_aupdate_write_swap(u->a_H);
            pa_aupdate_write_end(u->a_H);
        }else{
            return "incompatible size";
        }
        pa_datum_free(&value);
    }else{
        return "profile doesn't exist";
    }
    return NULL;
    //fix_filter(u->H, u->fft_size);
}
void load_state(struct userdata *u){
    char *state_name=pa_sprintf_malloc("%s-previous-state", u->name);
    load_profile(u,state_name);
    pa_xfree(state_name);
}


/* Called from main context */
static pa_bool_t sink_input_may_move_to_cb(pa_sink_input *i, pa_sink *dest) {
    struct userdata *u;

    pa_sink_input_assert_ref(i);
    pa_assert_se(u = i->userdata);

    return u->sink != dest;
}


//ensure's memory allocated is a multiple of v_size
//and aligned
static void * alloc(size_t x,size_t s){
    size_t f = mround(x*s, sizeof(float)*v_size);
    pa_assert_se(f >= x*s);
    //printf("requested %ld floats=%ld bytes, rem=%ld\n", x, x*sizeof(float), x*sizeof(float)%16);
    //printf("giving %ld floats=%ld bytes, rem=%ld\n", f, f*sizeof(float), f*sizeof(float)%16);
    float *t = fftwf_malloc(f);
    memset(t, 0, f);
    return t;
}

int pa__init(pa_module*m) {
    struct userdata *u;
    pa_sample_spec ss;
    pa_channel_map map;
    pa_modargs *ma;
    const char *z;
    pa_sink *master;
    pa_sink_input_new_data sink_input_data;
    pa_sink_new_data sink_data;
    pa_bool_t *use_default = NULL;
    size_t fs;

    pa_assert(m);

    if (!(ma = pa_modargs_new(m->argument, valid_modargs))) {
        pa_log("Failed to parse module arguments.");
        goto fail;
    }

    if (!(master = pa_namereg_get(m->core, pa_modargs_get_value(ma, "master", NULL), PA_NAMEREG_SINK))) {
        pa_log("Master sink not found");
        goto fail;
    }

    ss = master->sample_spec;
    ss.format = PA_SAMPLE_FLOAT32;
    map = master->channel_map;
    if (pa_modargs_get_sample_spec_and_channel_map(ma, &ss, &map, PA_CHANNEL_MAP_DEFAULT) < 0) {
        pa_log("Invalid sample format specification or channel map");
        goto fail;
    }
    fs = pa_frame_size(&ss);

    u = pa_xnew0(struct userdata, 1);
    u->core = m->core;
    u->module = m;
    m->userdata = u;
    u->master = master;
    u->sink = NULL;
    u->sink_input = NULL;

    u->channels = ss.channels;
    u->fft_size = pow(2, ceil(log(ss.rate)/log(2)));
    pa_log("fft size: %ld", u->fft_size);
    u->window_size = 15999;
    u->R = (u->window_size+1)/2;
    u->overlap_size = u->window_size-u->R;
    u->target_samples = 1*u->R;
    u->samples_gathered = 0;
    u->max_output = pa_frame_align(pa_mempool_block_size_max(m->core->mempool), &ss)/pa_frame_size(&ss);
    u->input_q = pa_memblockq_new(0,  MEMBLOCKQ_MAXLENGTH, 0, fs, 1, 1, 0, NULL);
    u->a_H = pa_aupdate_new();
    u->conv_buffer.memblock = pa_memblock_new(u->core->mempool, u->target_samples*fs);
    u->latency = u->R;
    for(size_t i = 0; i < 2; ++i){
        u->Hs[i] = alloc((u->fft_size / 2 + 1), sizeof(float));
    }
    u->W = alloc(u->window_size, sizeof(float));
    u->work_buffer = alloc(u->fft_size, sizeof(float));
    memset(u->work_buffer, 0, u->fft_size*sizeof(float));
    u->input = (float **)pa_xmalloc0(sizeof(float *)*u->channels);
    u->overlap_accum = (float **)pa_xmalloc0(sizeof(float *)*u->channels);
    for(size_t c = 0; c < u->channels; ++c){
        u->input[c] = alloc(u->overlap_size+u->target_samples, sizeof(float));
        pa_assert_se(u->input[c]);
        memset(u->input[c], 0, (u->overlap_size+u->target_samples)*sizeof(float));
        pa_assert_se(u->input[c]);
        u->overlap_accum[c] = alloc(u->overlap_size, sizeof(float));
        pa_assert_se(u->overlap_accum[c]);
        memset(u->overlap_accum[c], 0, u->overlap_size*sizeof(float));
    }
    u->output_window = alloc((u->fft_size / 2 + 1), sizeof(fftwf_complex));
    u->forward_plan = fftwf_plan_dft_r2c_1d(u->fft_size, u->work_buffer, u->output_window, FFTW_ESTIMATE);
    u->inverse_plan = fftwf_plan_dft_c2r_1d(u->fft_size, u->output_window, u->work_buffer, FFTW_ESTIMATE);

    hanning_window(u->W, u->window_size);

    /* Create sink */
    pa_sink_new_data_init(&sink_data);
    sink_data.driver = __FILE__;
    sink_data.module = m;
    if (!(sink_data.name = pa_xstrdup(pa_modargs_get_value(ma, "sink_name", NULL))))
        sink_data.name = pa_sprintf_malloc("%s.equalizer", master->name);
    sink_data.namereg_fail = FALSE;
    pa_sink_new_data_set_sample_spec(&sink_data, &ss);
    pa_sink_new_data_set_channel_map(&sink_data, &map);
    z = pa_proplist_gets(master->proplist, PA_PROP_DEVICE_DESCRIPTION);
    pa_proplist_sets(sink_data.proplist, PA_PROP_DEVICE_DESCRIPTION, "FFT based equalizer");
    pa_proplist_sets(sink_data.proplist, PA_PROP_DEVICE_MASTER_DEVICE, master->name);
    pa_proplist_sets(sink_data.proplist, PA_PROP_DEVICE_CLASS, "filter");

    if (pa_modargs_get_proplist(ma, "sink_properties", sink_data.proplist, PA_UPDATE_REPLACE) < 0) {
        pa_log("Invalid properties");
        pa_sink_new_data_done(&sink_data);
        goto fail;
    }

    u->sink = pa_sink_new(m->core, &sink_data, PA_SINK_LATENCY|PA_SINK_DYNAMIC_LATENCY);
    pa_sink_new_data_done(&sink_data);

    if (!u->sink) {
        pa_log("Failed to create sink.");
        goto fail;
    }
    u->name=pa_xstrdup(u->sink->name);
    u->sink->parent.process_msg = sink_process_msg;
    u->sink->set_state = sink_set_state;
    u->sink->update_requested_latency = sink_update_requested_latency;
    u->sink->request_rewind = sink_request_rewind;
    u->sink->userdata = u;

    pa_sink_set_asyncmsgq(u->sink, master->asyncmsgq);
    pa_sink_set_rtpoll(u->sink, master->rtpoll);
    pa_sink_set_max_request(u->sink,
        ((pa_sink_get_max_request(u->sink)+u->R*fs-1)/(u->R*fs))*(u->R*fs)
    );
    //pa_sink_set_fixed_latency(u->sink, pa_bytes_to_usec(u->R*fs, &ss));

    /* Create sink input */
    pa_sink_input_new_data_init(&sink_input_data);
    sink_input_data.driver = __FILE__;
    sink_input_data.module = m;
    sink_input_data.sink = u->master;
    pa_proplist_sets(sink_input_data.proplist, PA_PROP_MEDIA_NAME, "Equalized Stream");
    pa_proplist_sets(sink_input_data.proplist, PA_PROP_MEDIA_ROLE, "filter");
    pa_sink_input_new_data_set_sample_spec(&sink_input_data, &ss);
    pa_sink_input_new_data_set_channel_map(&sink_input_data, &map);

    pa_sink_input_new(&u->sink_input, m->core, &sink_input_data, PA_SINK_INPUT_DONT_MOVE);
    pa_sink_input_new_data_done(&sink_input_data);

    if (!u->sink_input)
        goto fail;

    u->sink_input->pop = sink_input_pop_cb;
    u->sink_input->process_rewind = sink_input_process_rewind_cb;
    u->sink_input->update_max_rewind = sink_input_update_max_rewind_cb;
    u->sink_input->update_max_request = sink_input_update_max_request_cb;
    u->sink_input->update_sink_latency_range = sink_input_update_sink_latency_range_cb;
    u->sink_input->kill = sink_input_kill_cb;
    u->sink_input->attach = sink_input_attach_cb;
    u->sink_input->detach = sink_input_detach_cb;
    u->sink_input->state_change = sink_input_state_change_cb;
    u->sink_input->may_move_to = sink_input_may_move_to_cb;
    u->sink_input->userdata = u;

    pa_sink_put(u->sink);
    pa_sink_input_put(u->sink_input);

    pa_modargs_free(ma);

    pa_xfree(use_default);

    dbus_init(u);

    //default filter to these
    for(size_t i = 0; i < u->fft_size / 2 + 1; ++i){
        u->Hs[1][i]=u->Hs[0][i] = 1.0;
    }
    //load old parameters
    load_state(u);

    return 0;

fail:
    if (ma)
        pa_modargs_free(ma);

    pa_xfree(use_default);

    pa__done(m);

    return -1;
}

int pa__get_n_used(pa_module *m) {
    struct userdata *u;

    pa_assert(m);
    pa_assert_se(u = m->userdata);

    return pa_sink_linked_by(u->sink);
}

void pa__done(pa_module*m) {
    struct userdata *u;

    pa_assert(m);

    if (!(u = m->userdata))
        return;

    save_state(u);

    dbus_done(u);

    if (u->sink) {
        pa_sink_unlink(u->sink);
        pa_sink_unref(u->sink);
    }

    if (u->sink_input) {
        pa_sink_input_unlink(u->sink_input);
        pa_sink_input_unref(u->sink_input);
    }

    pa_aupdate_free(u->a_H);
    pa_memblock_unref(u->conv_buffer.memblock);
    pa_memblockq_free(u->input_q);

    fftwf_destroy_plan(u->inverse_plan);
    fftwf_destroy_plan(u->forward_plan);
    pa_xfree(u->output_window);
    for(size_t c=0; c < u->channels; ++c){
        pa_xfree(u->overlap_accum[c]);
        pa_xfree(u->input[c]);
    }
    pa_xfree(u->overlap_accum);
    pa_xfree(u->input);
    pa_xfree(u->work_buffer);
    pa_xfree(u->W);
    for(size_t i = 0; i < 2; ++i){
        pa_xfree(u->Hs[i]);
    }

    pa_xfree(u->name);

    pa_xfree(u);
}

enum manager_method_index {
    MANAGER_METHOD_REMOVE_PROFILE,
    MANAGER_METHOD_MAX
};

pa_dbus_arg_info remove_profile_args[]={
    {"name", "s","in"},
};

static pa_dbus_method_handler manager_methods[MANAGER_METHOD_MAX]={
    [MANAGER_METHOD_REMOVE_PROFILE]{
        .method_name="RemoveProfile",
        .arguments=remove_profile_args,
        .n_arguments=sizeof(remove_profile_args)/sizeof(pa_dbus_arg_info),
        .receive_cb=manager_handle_remove_profile}
};

enum manager_handler_index {
    MANAGER_HANDLER_REVISION,
    MANAGER_HANDLER_EQUALIZED_SINKS,
    MANAGER_HANDLER_PROFILES,
    MANAGER_HANDLER_MAX
};

static pa_dbus_property_handler manager_handlers[MANAGER_HANDLER_MAX]={
    [MANAGER_HANDLER_REVISION]={.property_name="InterfaceRevision",.type="u",.get_cb=manager_get_revision,.set_cb=NULL},
    [MANAGER_HANDLER_EQUALIZED_SINKS]={.property_name="EqualizedSinks",.type="ao",.get_cb=manager_get_sinks,.set_cb=NULL},
    [MANAGER_HANDLER_PROFILES]={.property_name="Profiles",.type="as",.get_cb=manager_get_profiles,.set_cb=NULL}
};

static pa_dbus_interface_info manager_info={
    .name=EXTNAME ".Manager",
    .method_handlers=manager_methods,
    .n_method_handlers=MANAGER_METHOD_MAX,
    .property_handlers=manager_handlers,
    .n_property_handlers=MANAGER_HANDLER_MAX,
    .get_all_properties_cb=manager_get_all,
    .signals=NULL,
    .n_signals=0
};


enum equalizer_method_index {
    EQUALIZER_METHOD_FILTER_POINTS,
    EQUALIZER_METHOD_SEED_FILTER,
    EQUALIZER_METHOD_SAVE_PROFILE,
    EQUALIZER_METHOD_LOAD_PROFILE,
    EQUALIZER_METHOD_SET_FILTER,
    EQUALIZER_METHOD_GET_FILTER,
    EQUALIZER_METHOD_MAX
};

enum equalizer_handler_index {
    EQUALIZER_HANDLER_REVISION,
    EQUALIZER_HANDLER_SAMPLERATE,
    EQUALIZER_HANDLER_FILTERSAMPLERATE,
    EQUALIZER_HANDLER_N_COEFS,
    EQUALIZER_HANDLER_MAX
};

pa_dbus_arg_info filter_points_args[]={
    {"xs", "au","in"},
    {"ys", "ad","out"},
};
pa_dbus_arg_info seed_filter_args[]={
    {"xs", "au","in"},
    {"ys", "ad","in"},
};
pa_dbus_arg_info save_profile_args[]={
    {"name", "s","in"},
};
pa_dbus_arg_info load_profile_args[]={
    {"name", "s","in"},
};
pa_dbus_arg_info set_filter_args[]={
    {"coefficients", "ad","in"},
};
pa_dbus_arg_info get_filter_args[]={
    {"coefficients", "ad","out"},
};

static pa_dbus_method_handler equalizer_methods[EQUALIZER_METHOD_MAX]={
    [EQUALIZER_METHOD_SEED_FILTER]{
        .method_name="SeedFilter",
        .arguments=seed_filter_args,
        .n_arguments=sizeof(seed_filter_args)/sizeof(pa_dbus_arg_info),
        .receive_cb=equalizer_handle_seed_filter},
    [EQUALIZER_METHOD_FILTER_POINTS]{
        .method_name="FilterAtPoints",
        .arguments=filter_points_args,
        .n_arguments=sizeof(filter_points_args)/sizeof(pa_dbus_arg_info),
        .receive_cb=equalizer_handle_get_filter_points},
    [EQUALIZER_METHOD_SAVE_PROFILE]{
        .method_name="SaveProfile",
        .arguments=save_profile_args,
        .n_arguments=sizeof(save_profile_args)/sizeof(pa_dbus_arg_info),
        .receive_cb=equalizer_handle_save_profile},
    [EQUALIZER_METHOD_LOAD_PROFILE]{
        .method_name="LoadProfile",
        .arguments=load_profile_args,
        .n_arguments=sizeof(load_profile_args)/sizeof(pa_dbus_arg_info),
        .receive_cb=equalizer_handle_load_profile},
    [EQUALIZER_METHOD_SET_FILTER]{
        .method_name="SetFilterCoefficients",
        .arguments=set_filter_args,
        .n_arguments=sizeof(set_filter_args)/sizeof(pa_dbus_arg_info),
        .receive_cb=equalizer_set_filter},
    [EQUALIZER_METHOD_GET_FILTER]{
        .method_name="GetFilterCoefficients",
        .arguments=get_filter_args,
        .n_arguments=sizeof(get_filter_args)/sizeof(pa_dbus_arg_info),
        .receive_cb=equalizer_get_filter}
};

static pa_dbus_property_handler equalizer_handlers[EQUALIZER_HANDLER_MAX]={
    [EQUALIZER_HANDLER_REVISION]={.property_name="InterfaceRevision",.type="u",.get_cb=equalizer_get_revision,.set_cb=NULL},
    [EQUALIZER_HANDLER_SAMPLERATE]{.property_name="SampleRate",.type="u",.get_cb=equalizer_get_sample_rate,.set_cb=NULL},
    [EQUALIZER_HANDLER_FILTERSAMPLERATE]{.property_name="FilterSampleRate",.type="u",.get_cb=equalizer_get_filter_rate,.set_cb=NULL},
    [EQUALIZER_HANDLER_N_COEFS]{.property_name="NFilterCoefficients",.type="u",.get_cb=equalizer_get_n_coefs,.set_cb=NULL},
};

//static pa_dbus_arg_info new_equalizer_args[] = { { "path","o",NULL} };
//static pa_dbus_signal_info signals[SIGNAL_MAX] = {
//    [SIGNAL_NEW_EQUALIZER]={.name="NewEqualizer",.arguments=new_equalizer_args,.n_arguments=1}
//};

static pa_dbus_interface_info equalizer_info={
    .name=EXTNAME ".Equalizer",
    .method_handlers=equalizer_methods,
    .n_method_handlers=EQUALIZER_METHOD_MAX,
    .property_handlers=equalizer_handlers,
    .n_property_handlers=EQUALIZER_HANDLER_MAX,
    .get_all_properties_cb=equalizer_get_all,
    .signals=NULL,
    .n_signals=0
};

void dbus_init(struct userdata *u){
    u->dbus_protocol=pa_dbus_protocol_get(u->core);
    u->dbus_path=pa_sprintf_malloc("/org/pulseaudio/core1/sink%d", u->sink->index);

    pa_dbus_protocol_add_interface(u->dbus_protocol, u->dbus_path, &equalizer_info, u);
    pa_idxset *sink_list=pa_shared_get(u->core,SINKLIST);
    u->database=pa_shared_get(u->core,EQDB);
    if(sink_list==NULL){
        sink_list=pa_idxset_new(&pa_idxset_trivial_hash_func, &pa_idxset_trivial_compare_func);
        pa_shared_set(u->core, SINKLIST, sink_list);
        char *dbname;
        pa_assert_se(dbname = pa_state_path("equalizers", TRUE));
        pa_assert_se(u->database = pa_database_open(dbname, TRUE));
        pa_xfree(dbname);
        pa_shared_set(u->core,EQDB,u->database);
        pa_dbus_protocol_add_interface(u->dbus_protocol, MANAGER_PATH, &manager_info, u->core);
        pa_dbus_protocol_register_extension(u->dbus_protocol, EXTNAME);
    }
    uint32_t dummy;
    pa_idxset_put(sink_list,u,&dummy);
}

void dbus_done(struct userdata *u){
    pa_idxset *sink_list;
    uint32_t dummy;

    pa_assert_se(sink_list=pa_shared_get(u->core,SINKLIST));
    pa_idxset_remove_by_data(sink_list,u,&dummy);
    if(pa_idxset_size(sink_list)==0){
        pa_dbus_protocol_unregister_extension(u->dbus_protocol, EXTNAME);
        pa_dbus_protocol_remove_interface(u->dbus_protocol, MANAGER_PATH, manager_info.name);
        pa_shared_remove(u->core, EQDB);
        pa_database_close(u->database);
        pa_shared_remove(u->core, SINKLIST);
        pa_xfree(sink_list);
    }
    pa_dbus_protocol_remove_interface(u->dbus_protocol, u->dbus_path, equalizer_info.name);
    pa_xfree(u->dbus_path);
    pa_dbus_protocol_unref(u->dbus_protocol);
}

void manager_handle_remove_profile(DBusConnection *conn, DBusMessage *msg, void *_u) {
    DBusError error;
    pa_core *c = (pa_core *)_u;
    pa_assert(conn);
    pa_assert(msg);
    pa_assert(c);
    dbus_error_init(&error);
    char *name;
    if(!dbus_message_get_args(msg, &error,
                 DBUS_TYPE_STRING, &name,
                DBUS_TYPE_INVALID)){
        pa_dbus_send_error(conn, msg, DBUS_ERROR_INVALID_ARGS, "%s", error.message);
        dbus_error_free(&error);
        return;
    }
    remove_profile(c,name);
    pa_dbus_send_empty_reply(conn, msg);
}

void manager_get_revision(DBusConnection *conn, DBusMessage *msg, void *_u){
    uint32_t rev=1;
    pa_dbus_send_basic_value_reply(conn, msg, DBUS_TYPE_UINT32, &rev);
}

void manager_get_sinks(DBusConnection *conn, DBusMessage *msg, void *_u){
    pa_assert(conn);
    pa_assert(msg);
    pa_assert(_u);

    pa_core *c = (pa_core *)_u;
    pa_idxset *sink_list;
    uint32_t dummy;

    pa_assert_se(sink_list = pa_shared_get(c, SINKLIST));
    unsigned n_sinks = (unsigned) pa_idxset_size(sink_list);
    char **names = NULL;
    void *iter = NULL;
    struct userdata *sink_u = NULL;
    pa_assert_se(names = pa_xnew0(char *,n_sinks));
    for(uint32_t i = 0; i < n_sinks; ++i){
        sink_u=(struct userdata *) pa_idxset_iterate(sink_list, &iter, &dummy);
        names[i] = sink_u->dbus_path;
    }
    pa_dbus_send_basic_array_variant_reply(conn, msg, DBUS_TYPE_OBJECT_PATH, names, n_sinks);
    pa_xfree(names);
}

void manager_get_profiles(DBusConnection *conn, DBusMessage *msg, void *_u){
    pa_assert(conn);
    pa_assert(msg);
    pa_assert(_u);

    pa_core *core=_u;
    DBusMessage *reply = NULL;
    DBusMessageIter msg_iter, array_iter;

    pa_assert_se((reply = dbus_message_new_method_return(msg)));
    dbus_message_iter_init_append(reply, &msg_iter);
    pa_assert_se(dbus_message_iter_open_container(&msg_iter, DBUS_TYPE_ARRAY, "s", &array_iter));

    char *name;
    pa_datum key,next_key;
    int done;
    pa_database *database;
    pa_assert_se(database=pa_shared_get(core, EQDB));
    done = !pa_database_first(database, &key, NULL);

    while(!done){
        done = !pa_database_next(database, &key, &next_key, NULL);
        name=pa_xmalloc(key.size + 1);
        memcpy(name, key.data, key.size);
        name[key.size] = '\0';
        pa_datum_free(&key);
        dbus_message_iter_append_basic(&array_iter, DBUS_TYPE_STRING, &name);
        pa_xfree(name);
        key = next_key;
    }
    dbus_message_iter_close_container(&msg_iter, &array_iter);
    pa_assert_se(dbus_connection_send(conn, reply, NULL));
    dbus_message_unref(reply);
}

void manager_get_all(DBusConnection *conn, DBusMessage *msg, void *_u){
    pa_assert(conn);
    pa_assert(msg);
    pa_assert(_u);

    pa_core *u=(pa_core *) _u;
    DBusMessage *reply = NULL;
    DBusMessageIter msg_iter, dict_iter, sub_iter, array_iter;
    pa_assert_se((reply = dbus_message_new_method_return(msg)));
    dbus_message_iter_init_append(reply, &msg_iter);
    pa_assert_se(dbus_message_iter_open_container(&msg_iter, DBUS_TYPE_ARRAY, "{sv}", &dict_iter));

    uint32_t rev=1;
    pa_idxset *sink_list;
    pa_dbus_append_basic_variant_dict_entry(&dict_iter, manager_handlers[MANAGER_HANDLER_REVISION].property_name, DBUS_TYPE_UINT32, &rev);

    pa_assert_se(sink_list = pa_shared_get(u, SINKLIST));
    unsigned n_sinks = (unsigned) pa_idxset_size(sink_list);
    char **names = NULL;
    void *iter = NULL;
    struct userdata *sink_u = NULL;
    pa_assert_se(names = pa_xnew0(char *,n_sinks));
    for(uint32_t i = 0; i < n_sinks; ++i){
        unsigned dummy;
        sink_u=(struct userdata *) pa_idxset_iterate(sink_list, &iter, &dummy);
        names[i] = sink_u->dbus_path;
    }
    pa_dbus_append_basic_array_variant_dict_entry(&dict_iter, manager_handlers[MANAGER_HANDLER_EQUALIZED_SINKS].property_name, DBUS_TYPE_OBJECT_PATH, names, n_sinks);
    pa_xfree(names);

    pa_database *database;
    pa_assert_se(database=pa_shared_get(u, EQDB));

    pa_datum key,next_key;
    char *profile_name;
    int done;
    done = !pa_database_first(database, &key, NULL);
    dbus_message_iter_open_container(&dict_iter, DBUS_TYPE_DICT_ENTRY, NULL, &sub_iter);
    dbus_message_iter_append_basic(&sub_iter, DBUS_TYPE_STRING, &manager_handlers[MANAGER_HANDLER_PROFILES].property_name);

    dbus_message_iter_open_container(&sub_iter, DBUS_TYPE_ARRAY, "s", &array_iter);
    while(!done){
        done = !pa_database_next(database, &key, &next_key, NULL);
        profile_name=pa_xmalloc(key.size + 1);
        memcpy(profile_name, key.data, key.size);
        profile_name[key.size] = '\0';
        pa_datum_free(&key);
        dbus_message_iter_append_basic(&array_iter, DBUS_TYPE_STRING, &profile_name);
        pa_xfree(profile_name);
        key = next_key;
    }
    pa_assert_se(dbus_message_iter_close_container(&sub_iter, &array_iter));
    pa_assert_se(dbus_message_iter_close_container(&dict_iter, &sub_iter));
    pa_assert_se(dbus_message_iter_close_container(&msg_iter, &dict_iter));
    pa_assert_se(dbus_connection_send(conn, reply, NULL));
    dbus_message_unref(reply);
}

void equalizer_handle_seed_filter(DBusConnection *conn, DBusMessage *msg, void *_u) {
    struct userdata *u=(struct userdata *) _u;
    DBusError error;

    pa_assert(conn);
    pa_assert(msg);
    pa_assert(u);
    float *ys;
    uint32_t *xs;
    double *_ys;
    unsigned x_npoints,y_npoints;

    dbus_error_init(&error);

    if(!dbus_message_get_args(msg, &error,
                DBUS_TYPE_ARRAY, DBUS_TYPE_UINT32, &xs, &x_npoints,
                DBUS_TYPE_ARRAY, DBUS_TYPE_DOUBLE, &_ys, &y_npoints,
                DBUS_TYPE_INVALID)){
        pa_dbus_send_error(conn, msg, DBUS_ERROR_INVALID_ARGS, "%s", error.message);
        dbus_error_free(&error);
        return;
    }
    int points_good=1;
    for(size_t i = 0; i < x_npoints; ++i){
        if(xs[i] >= u->fft_size / 2 + 1){
            points_good=0;
            break;
        }
    }
    if(!is_monotonic(xs,x_npoints) || !points_good){
        pa_dbus_send_error(conn, msg, DBUS_ERROR_INVALID_ARGS, "xs must be monotonic and 0<x<%ld", u->fft_size / 2);
        dbus_error_free(&error);
        return;

    }
    else if(x_npoints != y_npoints || x_npoints < 2 || x_npoints > u->fft_size / 2 +1  ){
        pa_dbus_send_error(conn, msg, DBUS_ERROR_INVALID_ARGS, "xs and ys must be the same length and 2<=l<=%ld!", u->fft_size / 2 + 1);
        dbus_error_free(&error);
        return;
    }

    ys = pa_xmalloc(x_npoints * sizeof(float));
    for(uint32_t i = 0; i < x_npoints; ++i){
        ys[i] = (float) _ys[i];
    }

    float *H = u->Hs[pa_aupdate_write_begin(u->a_H)];
    interpolate(H, u->fft_size / 2 + 1, xs, ys, x_npoints);
    fix_filter(H, u->fft_size);
    pa_aupdate_write_swap(u->a_H);
    pa_aupdate_write_end(u->a_H);
    pa_xfree(ys);

    //Stupid for IO reasons?  Add a save signal to dbus instead
    //save_state(u);

    pa_dbus_send_empty_reply(conn, msg);
}

void equalizer_handle_get_filter_points(DBusConnection *conn, DBusMessage *msg, void *_u) {
    struct userdata *u=(struct userdata *) _u;
    DBusError error;

    pa_assert(conn);
    pa_assert(msg);
    pa_assert(u);
    uint32_t *xs;
    double *ys;
    unsigned x_npoints;

    dbus_error_init(&error);

    if(!dbus_message_get_args(msg, &error,
                DBUS_TYPE_ARRAY, DBUS_TYPE_UINT32, &xs, &x_npoints,
                DBUS_TYPE_INVALID)){
        pa_dbus_send_error(conn, msg, DBUS_ERROR_INVALID_ARGS, "%s", error.message);
        dbus_error_free(&error);
        return;
    }
    int points_good=1;
    for(size_t i = 0; i < x_npoints; ++i){
        if(xs[i] >= u->fft_size / 2 + 1){
            points_good=0;
            break;
        }
    }

    if(x_npoints > u->fft_size / 2 +1 || !points_good){
        pa_dbus_send_error(conn, msg, DBUS_ERROR_INVALID_ARGS, "xs indices/length must be <= %ld!", u->fft_size / 2 + 1);
        dbus_error_free(&error);
        return;
    }

    ys = pa_xmalloc(x_npoints * sizeof(double));
    float *H = u->Hs[pa_aupdate_read_begin(u->a_H)];
    for(uint32_t i = 0; i < x_npoints; ++i){
        ys[i] = H[xs[i]] * u->fft_size;
    }
    pa_aupdate_read_end(u->a_H);

    pa_dbus_send_basic_array_variant_reply(conn, msg, DBUS_TYPE_DOUBLE, ys, x_npoints);
    pa_xfree(ys);
}

void equalizer_handle_save_profile(DBusConnection *conn, DBusMessage *msg, void *_u) {
    struct userdata *u=(struct userdata *) _u;
    DBusError error;
    pa_assert(conn);
    pa_assert(msg);
    pa_assert(u);
    dbus_error_init(&error);
    char *name;

    if(!dbus_message_get_args(msg, &error,
                 DBUS_TYPE_STRING, &name,
                DBUS_TYPE_INVALID)){
        pa_dbus_send_error(conn, msg, DBUS_ERROR_INVALID_ARGS, "%s", error.message);
        dbus_error_free(&error);
        return;
    }
    save_profile(u,name);
    pa_dbus_send_empty_reply(conn, msg);
}

void equalizer_handle_load_profile(DBusConnection *conn, DBusMessage *msg, void *_u) {
    struct userdata *u=(struct userdata *) _u;
    DBusError error;

    pa_assert(conn);
    pa_assert(msg);
    pa_assert(u);
    dbus_error_init(&error);
    char *name;

    if(!dbus_message_get_args(msg, &error,
                 DBUS_TYPE_STRING, &name,
                DBUS_TYPE_INVALID)){
        pa_dbus_send_error(conn, msg, DBUS_ERROR_INVALID_ARGS, "%s", error.message);
        dbus_error_free(&error);
        return;
    }
    const char *err_msg=load_profile(u,name);
    if(err_msg!=NULL){
        pa_dbus_send_error(conn, msg, DBUS_ERROR_FAILED, "error loading profile %s: %s", name,err_msg);
        dbus_error_free(&error);
        return;
    }
    pa_dbus_send_empty_reply(conn, msg);
}

void equalizer_get_revision(DBusConnection *conn, DBusMessage *msg, void *_u){
    uint32_t rev=1;
    pa_dbus_send_basic_value_reply(conn, msg, DBUS_TYPE_UINT32, &rev);
}

void equalizer_get_n_coefs(DBusConnection *conn, DBusMessage *msg, void *_u){
    pa_assert(conn);
    pa_assert(msg);
    pa_assert(_u);

    struct userdata *u=(struct userdata *)_u;

    uint32_t n_coefs=(uint32_t)(u->fft_size / 2 + 1);
    pa_dbus_send_basic_variant_reply(conn, msg, DBUS_TYPE_UINT32, &n_coefs);
}

void equalizer_get_sample_rate(DBusConnection *conn, DBusMessage *msg, void *_u){
    pa_assert(conn);
    pa_assert(msg);
    pa_assert(_u);

    struct userdata *u=(struct userdata *) _u;
    uint32_t rate=(uint32_t) u->sink->sample_spec.rate;
    pa_dbus_send_basic_variant_reply(conn, msg, DBUS_TYPE_UINT32, &rate);
}

void equalizer_get_filter_rate(DBusConnection *conn, DBusMessage *msg, void *_u){
    pa_assert(conn);
    pa_assert(msg);
    pa_assert(_u);

    struct userdata *u=(struct userdata *) _u;
    uint32_t fft_size=(uint32_t) u->fft_size;
    pa_dbus_send_basic_variant_reply(conn, msg, DBUS_TYPE_UINT32, &fft_size);
}

void equalizer_get_all(DBusConnection *conn, DBusMessage *msg, void *_u){
    pa_assert(conn);
    pa_assert(msg);
    pa_assert(_u);

    struct userdata *u=(struct userdata *) _u;
    DBusMessage *reply = NULL;
    DBusMessageIter msg_iter, dict_iter;
    uint32_t rev=1;
    uint32_t n_coefs=(uint32_t)(u->fft_size / 2 + 1);
    uint32_t rate=(uint32_t) u->sink->sample_spec.rate;
    uint32_t fft_size=(uint32_t) u->fft_size;

    pa_assert_se((reply = dbus_message_new_method_return(msg)));
    dbus_message_iter_init_append(reply, &msg_iter);
    pa_assert_se(dbus_message_iter_open_container(&msg_iter, DBUS_TYPE_ARRAY, "{sv}", &dict_iter));

    pa_dbus_append_basic_variant_dict_entry(&dict_iter, equalizer_handlers[EQUALIZER_HANDLER_REVISION].property_name, DBUS_TYPE_UINT32, &rev);
    pa_dbus_append_basic_variant_dict_entry(&dict_iter, equalizer_handlers[EQUALIZER_HANDLER_SAMPLERATE].property_name, DBUS_TYPE_UINT32, &rate);
    pa_dbus_append_basic_variant_dict_entry(&dict_iter, equalizer_handlers[EQUALIZER_HANDLER_FILTERSAMPLERATE].property_name, DBUS_TYPE_UINT32, &fft_size);
    pa_dbus_append_basic_variant_dict_entry(&dict_iter, equalizer_handlers[EQUALIZER_HANDLER_N_COEFS].property_name, DBUS_TYPE_UINT32, &n_coefs);

    pa_assert_se(dbus_message_iter_close_container(&msg_iter, &dict_iter));
    pa_assert_se(dbus_connection_send(conn, reply, NULL));
    dbus_message_unref(reply);
}

void equalizer_get_filter(DBusConnection *conn, DBusMessage *msg, void *_u){
    pa_assert(conn);
    pa_assert(msg);
    pa_assert(_u);

    struct userdata *u = (struct userdata *)_u;
    
    unsigned n_coefs = (unsigned) (u->fft_size / 2 + 1);
    double *H_ = (double *) pa_xmalloc0(n_coefs * sizeof(double));
    
    float *H=u->Hs[pa_aupdate_read_begin(u->a_H)];
    for(size_t i = 0;i < u->fft_size / 2 + 1; ++i){
        H_[i] = H[i] * u->fft_size;
    }
    pa_aupdate_read_end(u->a_H);
    pa_dbus_send_basic_array_variant_reply(conn, msg, DBUS_TYPE_DOUBLE, H_, n_coefs);
    pa_xfree(H_);
}

void equalizer_set_filter(DBusConnection *conn, DBusMessage *msg, void *_u){
    pa_assert(conn);
    pa_assert(msg);
    pa_assert(_u);

    struct userdata *u=(struct userdata *)_u;
    double *H_;
    unsigned _n_coefs;
    if(pa_dbus_get_fixed_array_set_property_arg(conn, msg, DBUS_TYPE_DOUBLE, &H_, &_n_coefs)){
        return;
    }
    if(_n_coefs!=u->fft_size / 2 + 1){
        pa_dbus_send_error(conn, msg, DBUS_ERROR_INVALID_ARGS, "This filter takes exactly %ld coefficients, you gave %d", u->fft_size / 2 + 1, _n_coefs);
        return;
    }
    float *H = u->Hs[pa_aupdate_write_begin(u->a_H)];
    for(size_t i = 0; i < u->fft_size / 2 + 1; ++i){
        H[i] = (float) H_[i];
    }
    fix_filter(H, u->fft_size);
    pa_aupdate_write_swap(u->a_H);
    pa_aupdate_write_end(u->a_H);

    //Stupid for IO reasons?  Add a save signal to dbus instead
    //save_state(u);

    pa_dbus_send_empty_reply(conn, msg);
}