]> code.delx.au - pulseaudio/commitdiff
alsa: Fix crash when profile_set == NULL
authorDavid Henningsson <david.henningsson@canonical.com>
Tue, 14 May 2013 09:01:13 +0000 (11:01 +0200)
committerDavid Henningsson <david.henningsson@canonical.com>
Tue, 14 May 2013 09:05:24 +0000 (11:05 +0200)
Better check if the pointer is NULL before dereferencing it, instead of
after!

BugLink: https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/1159853
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
src/modules/alsa/module-alsa-card.c

index b37eabc466939864b0977efe406180dc2f975dd6..fe05e3d3ed6ff75e216ef5f6c0257b4d15805264 100644 (file)
@@ -689,11 +689,11 @@ int pa__init(pa_module *m) {
         pa_xfree(fn);
     }
 
-    u->profile_set->ignore_dB = ignore_dB;
-
     if (!u->profile_set)
         goto fail;
 
+    u->profile_set->ignore_dB = ignore_dB;
+
     pa_alsa_profile_set_probe(u->profile_set, u->device_id, &m->core->default_sample_spec, m->core->default_n_fragments, m->core->default_fragment_size_msec);
     pa_alsa_profile_set_dump(u->profile_set);