core-util: don't leak memory in pa_unset_env_recorded()

diff --git a/src/pulsecore/core-util.c b/src/pulsecore/core-util.c
index 9034dc32bf2d57c166f87b271360ae7c0be4f509..a3c601303878fd8c0a1a232fe6a2c61ac6a14579 100644 (file)
--- a/src/pulsecore/core-util.c
+++ b/src/pulsecore/core-util.c
@@ -2474,9 +2474,11 @@ void pa_unset_env_recorded(void) {
     /* This is not thread-safe */
 
     for (;;) {
-        char *s = NULL;
+        char *s;
 
-        if (!(recorded_env = pa_strlist_pop(recorded_env, &s)))
+        recorded_env = pa_strlist_pop(recorded_env, &s);
+
+        if (!s)
             break;
 
         unsetenv(s);