core: svolume tests should generate realistic random volume data

assuming RAND_MAX is around 1<<31, rand() >> 1 generates large numbers as
random volume data; these likely causes saturated sample values after
applying the volume function -- not a good test

diff --git a/src/pulsecore/svolume_arm.c b/src/pulsecore/svolume_arm.c
index 455d746b6ebbb7935cf893ddf10264078049d5e6..f938e57dfa2f6ca2597b588f2b2ebb8a9825fd6f 100644 (file)
--- a/src/pulsecore/svolume_arm.c
+++ b/src/pulsecore/svolume_arm.c
@@ -151,7 +151,7 @@ static void run_test(void) {
     memcpy(samples_orig, samples, sizeof(samples));
 
     for (i = 0; i < CHANNELS; i++)
-        volumes[i] = PA_CLAMP_VOLUME(rand() >> 1);
+        volumes[i] = PA_CLAMP_VOLUME(rand() >> 15);
     for (padding = 0; padding < PADDING; padding++, i++)
         volumes[i] = volumes[padding];
 

diff --git a/src/pulsecore/svolume_mmx.c b/src/pulsecore/svolume_mmx.c
index 43c1058b5a383c2d519f0df173da3202aaf49a10..f9fc1752dbff3c2d68e48d1a6b23a7511c962666 100644 (file)
--- a/src/pulsecore/svolume_mmx.c
+++ b/src/pulsecore/svolume_mmx.c
@@ -272,7 +272,7 @@ static void run_test(void) {
     memcpy(samples_orig, samples, sizeof(samples));
 
     for (i = 0; i < CHANNELS; i++)
-        volumes[i] = PA_CLAMP_VOLUME(rand() >> 1);
+        volumes[i] = PA_CLAMP_VOLUME(rand() >> 15);
         /* volumes[i] = 0x0000ffff; */
     for (padding = 0; padding < PADDING; padding++, i++)
         volumes[i] = volumes[padding];

diff --git a/src/pulsecore/svolume_orc.c b/src/pulsecore/svolume_orc.c
index 86f843e8936d7325dacf18d28ce8f4fc69bd3c9c..b178bbfd071e262718e04a8a86bb7812e0fbc9cb 100644 (file)
--- a/src/pulsecore/svolume_orc.c
+++ b/src/pulsecore/svolume_orc.c
@@ -75,7 +75,7 @@ static void run_test(void) {
     memcpy(samples_orig, samples, sizeof(samples));
 
     for (i = 0; i < CHANNELS; i++)
-        volumes[i] = PA_CLAMP_VOLUME(rand() >> 1);
+        volumes[i] = PA_CLAMP_VOLUME(rand() >> 15);
     for (padding = 0; padding < PADDING; padding++, i++)
         volumes[i] = volumes[padding];
 

diff --git a/src/pulsecore/svolume_sse.c b/src/pulsecore/svolume_sse.c
index 89414c6bb9ee9d1e5f7d5d251a20dc9c9ad01894..fe08de42301908a63db29e9f748c6fbb6a28c709 100644 (file)
--- a/src/pulsecore/svolume_sse.c
+++ b/src/pulsecore/svolume_sse.c
@@ -282,7 +282,7 @@ static void run_test(void) {
     memcpy(samples_orig, samples, sizeof(samples));
 
     for (i = 0; i < CHANNELS; i++)
-        volumes[i] = PA_CLAMP_VOLUME(rand() >> 1);
+        volumes[i] = PA_CLAMP_VOLUME(rand() >> 15);
     for (padding = 0; padding < PADDING; padding++, i++)
         volumes[i] = volumes[padding];