]> code.delx.au - pulseaudio/commitdiff
oss: don't deadlock when we try to resume an OSS device that lacks a mixer
authorLennart Poettering <lennart@poettering.net>
Tue, 26 May 2009 20:30:36 +0000 (22:30 +0200)
committerLennart Poettering <lennart@poettering.net>
Tue, 26 May 2009 20:30:36 +0000 (22:30 +0200)
src/modules/oss/module-oss.c

index ab26137f4fa7194d94cbc32a66dbc29674d2295f..d6f549cd3b58d368d54c426e254d00cf4e839dbf 100644 (file)
@@ -477,6 +477,7 @@ static void build_pollfd(struct userdata *u) {
     pollfd->revents = 0;
 }
 
+/* Called from IO context */
 static int suspend(struct userdata *u) {
     pa_assert(u);
     pa_assert(u->fd >= 0);
@@ -526,6 +527,7 @@ static int suspend(struct userdata *u) {
     return 0;
 }
 
+/* Called from IO context */
 static int unsuspend(struct userdata *u) {
     int m;
     pa_sample_spec ss, *ss_original;
@@ -616,10 +618,10 @@ static int unsuspend(struct userdata *u) {
 
     build_pollfd(u);
 
-    if (u->sink)
-        pa_sink_get_volume(u->sink, TRUE, FALSE);
-    if (u->source)
-        pa_source_get_volume(u->source, TRUE);
+    if (u->sink && u->sink->get_volume)
+        u->sink->get_volume(u->sink);
+    if (u->source && u->source->get_volume)
+        u->source->get_volume(u->source);
 
     pa_log_info("Resumed successfully...");
 
@@ -631,6 +633,7 @@ fail:
     return -1;
 }
 
+/* Called from IO context */
 static int sink_process_msg(pa_msgobject *o, int code, void *data, int64_t offset, pa_memchunk *chunk) {
     struct userdata *u = PA_SINK(o)->userdata;
     int ret;