]> code.delx.au - pulseaudio/commitdiff
modules: Fix resource leak in raop_client
authorPeter Meerwald <p.meerwald@bct-electronic.com>
Mon, 16 Dec 2013 15:44:28 +0000 (16:44 +0100)
committerPeter Meerwald <p.meerwald@bct-electronic.com>
Fri, 20 Dec 2013 11:55:05 +0000 (12:55 +0100)
https://scan7.coverity.com:8443/reports.htm#v10205/p10016/fileInstanceId=8899&defectInstanceId=3735&mergedDefectId=591272

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
src/modules/raop/raop_client.c

index 98a98224acccd2f0ac4f6984647eb1de1d3d2426..5bb0bb4575cae58853cb553004b6034d6f5d0e4f 100644 (file)
@@ -367,7 +367,7 @@ static void rtsp_cb(pa_rtsp_client *rtsp, pa_rtsp_state state, pa_headerlist* he
 
 pa_raop_client* pa_raop_client_new(pa_core *core, const char* host) {
     pa_parsed_address a;
-    pa_raop_client* c = pa_xnew0(pa_raop_client, 1);
+    pa_raop_client* c;
 
     pa_assert(core);
     pa_assert(host);
@@ -375,6 +375,7 @@ pa_raop_client* pa_raop_client_new(pa_core *core, const char* host) {
     if (pa_parse_address(host, &a) < 0 || a.type == PA_PARSED_ADDRESS_UNIX)
         return NULL;
 
+    c = pa_xnew0(pa_raop_client, 1);
     c->core = core;
     c->fd = -1;