]> code.delx.au - pulseaudio/commitdiff
ucm: Add a FIXME comment about bad error handling
authorTanu Kaskinen <tanu.kaskinen@linux.intel.com>
Mon, 18 Nov 2013 16:48:05 +0000 (18:48 +0200)
committerTanu Kaskinen <tanu.kaskinen@linux.intel.com>
Fri, 29 Nov 2013 05:21:37 +0000 (07:21 +0200)
src/modules/alsa/alsa-ucm.c

index ef3ddb29c4e9a2e36fdeda53cf5a7f4df6aa0799..ac7f70d984e702845042440a704b0796ea51d3ae 100644 (file)
@@ -1125,6 +1125,9 @@ static void alsa_mapping_add_ucm_modifier(pa_alsa_mapping *m, pa_alsa_ucm_modifi
     }
 
     if (channel_str) {
+        /* FIXME: channel_str is unsanitized input from the UCM configuration,
+         * we should do proper error handling instead of asserting.
+         * https://bugs.freedesktop.org/show_bug.cgi?id=71823 */
         pa_assert_se(pa_atou(channel_str, &channels) == 0 && channels < PA_CHANNELS_MAX);
         pa_log_debug("Got channel count %" PRIu32 " for modifier", channels);
     }